)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"66aa98433ffcac29c33df938a7c15794b8adf96b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds support to manila client for the mountable snapshots"},{"line_number":10,"context_line":"feature."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint manila-mountable-snapshots"},{"line_number":13,"context_line":"Change-Id: I785a784bcae7cf3bcef4fa6c64ba28ee58328389"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dada55a8_1ddd9e14","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":0},"updated":"2016-07-25 02:31:17.000000000","message":"Add a depends-on..","commit_id":"21c2a40f30fa6a9ad838c09c363c345121eb3494"}],"manilaclient/api_versions.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7c5bc45afd9f4a30742d90066f418def02db7634","unresolved":false,"context_lines":[{"line_number":212,"context_line":"    \"\"\"Returns checked APIVersion object.\"\"\""},{"line_number":213,"context_line":"    version_string \u003d str(version_string)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    api_version \u003d APIVersion(version_string)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    check_version_supported(api_version)"},{"line_number":218,"context_line":"    return api_version"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_3c0137b0","line":215,"range":{"start_line":215,"start_character":44,"end_line":215,"end_character":44},"updated":"2016-07-26 12:04:54.000000000","message":":) line 216 is not necessary.","commit_id":"21c2a40f30fa6a9ad838c09c363c345121eb3494"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"37f1c33061e20f0d3b093e29c2566b8d41cb5575","unresolved":false,"context_lines":[{"line_number":213,"context_line":"    version_string \u003d str(version_string)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    api_version \u003d APIVersion(version_string)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    check_version_supported(api_version)"},{"line_number":218,"context_line":"    return api_version"},{"line_number":219,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7a3c09a3_657bec28","line":216,"updated":"2017-01-17 12:38:24.000000000","message":"unrelated change, please remove","commit_id":"54e1f222ab46e449a638d83b493c3bf784800fd6"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"8fdc95fff3887a54a00024500737f7d3872f374f","unresolved":false,"context_lines":[{"line_number":213,"context_line":"    version_string \u003d str(version_string)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    api_version \u003d APIVersion(version_string)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    check_version_supported(api_version)"},{"line_number":218,"context_line":"    return api_version"},{"line_number":219,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7a3c09a3_5325cf06","line":216,"in_reply_to":"7a3c09a3_657bec28","updated":"2017-01-17 17:39:17.000000000","message":"Ops. Removed.","commit_id":"54e1f222ab46e449a638d83b493c3bf784800fd6"}],"manilaclient/tests/functional/client.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"064dae4e5e9a8a921537f12b387af1ac2b351c3f","unresolved":false,"context_lines":[{"line_number":813,"context_line":"        export_locations \u003d utils.listing(export_locations_raw)"},{"line_number":814,"context_line":"        return export_locations"},{"line_number":815,"context_line":""},{"line_number":816,"context_line":"    @not_found_wrapper"},{"line_number":817,"context_line":"    def list_snapshot_instance_export_locations(self, snapshot_instance,"},{"line_number":818,"context_line":"                                                columns\u003dNone,"},{"line_number":819,"context_line":"                                                microversion\u003dNone):"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_daeec6eb","line":816,"updated":"2017-01-19 12:54:48.000000000","message":"+ @forbidden_wrapper","commit_id":"2e776e83859fe5d37ff89aed7068b83b975f2a95"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"dc0797209f395e6db5a9c639aefd22a23392cc7c","unresolved":false,"context_lines":[{"line_number":813,"context_line":"        export_locations \u003d utils.listing(export_locations_raw)"},{"line_number":814,"context_line":"        return export_locations"},{"line_number":815,"context_line":""},{"line_number":816,"context_line":"    @not_found_wrapper"},{"line_number":817,"context_line":"    def list_snapshot_instance_export_locations(self, snapshot_instance,"},{"line_number":818,"context_line":"                                                columns\u003dNone,"},{"line_number":819,"context_line":"                                                microversion\u003dNone):"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_c62504c3","line":816,"in_reply_to":"5a3905b3_daeec6eb","updated":"2017-01-19 19:09:25.000000000","message":"Done","commit_id":"2e776e83859fe5d37ff89aed7068b83b975f2a95"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"064dae4e5e9a8a921537f12b387af1ac2b351c3f","unresolved":false,"context_lines":[{"line_number":941,"context_line":"            if access[\u0027id\u0027] \u003d\u003d access_id:"},{"line_number":942,"context_line":"                return access"},{"line_number":943,"context_line":"        raise tempest_lib_exc.NotFound()"},{"line_number":944,"context_line":""},{"line_number":945,"context_line":"    def snapshot_access_allow(self, snapshot_id, access_type, access_to,"},{"line_number":946,"context_line":"                              microversion\u003dNone):"},{"line_number":947,"context_line":"        raw_access \u003d self.manila("}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_7a95d23e","line":944,"updated":"2017-01-19 12:54:48.000000000","message":"@not_found_wrapper","commit_id":"2e776e83859fe5d37ff89aed7068b83b975f2a95"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"dc0797209f395e6db5a9c639aefd22a23392cc7c","unresolved":false,"context_lines":[{"line_number":941,"context_line":"            if access[\u0027id\u0027] \u003d\u003d access_id:"},{"line_number":942,"context_line":"                return access"},{"line_number":943,"context_line":"        raise tempest_lib_exc.NotFound()"},{"line_number":944,"context_line":""},{"line_number":945,"context_line":"    def snapshot_access_allow(self, snapshot_id, access_type, access_to,"},{"line_number":946,"context_line":"                              microversion\u003dNone):"},{"line_number":947,"context_line":"        raw_access \u003d self.manila("}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_06946ce0","line":944,"in_reply_to":"5a3905b3_7a95d23e","updated":"2017-01-19 19:09:25.000000000","message":"Done","commit_id":"2e776e83859fe5d37ff89aed7068b83b975f2a95"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"064dae4e5e9a8a921537f12b387af1ac2b351c3f","unresolved":false,"context_lines":[{"line_number":952,"context_line":"            },"},{"line_number":953,"context_line":"            microversion\u003dmicroversion)"},{"line_number":954,"context_line":"        return output_parser.details(raw_access)"},{"line_number":955,"context_line":""},{"line_number":956,"context_line":"    def snapshot_access_deny(self, snapshot_id, access_id, microversion\u003dNone):"},{"line_number":957,"context_line":"        return self.manila("},{"line_number":958,"context_line":"            \u0027snapshot-access-deny %(share_id)s %(access_id)s\u0027 % {"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_3aab4a8b","line":955,"updated":"2017-01-19 12:54:48.000000000","message":"@not_found_wrapper","commit_id":"2e776e83859fe5d37ff89aed7068b83b975f2a95"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"dc0797209f395e6db5a9c639aefd22a23392cc7c","unresolved":false,"context_lines":[{"line_number":952,"context_line":"            },"},{"line_number":953,"context_line":"            microversion\u003dmicroversion)"},{"line_number":954,"context_line":"        return output_parser.details(raw_access)"},{"line_number":955,"context_line":""},{"line_number":956,"context_line":"    def snapshot_access_deny(self, snapshot_id, access_id, microversion\u003dNone):"},{"line_number":957,"context_line":"        return self.manila("},{"line_number":958,"context_line":"            \u0027snapshot-access-deny %(share_id)s %(access_id)s\u0027 % {"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_46bcb46c","line":955,"in_reply_to":"5a3905b3_3aab4a8b","updated":"2017-01-19 19:09:25.000000000","message":"Done","commit_id":"2e776e83859fe5d37ff89aed7068b83b975f2a95"}],"manilaclient/tests/functional/test_share_access.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"999c8d5c84444c5179c9cf377aac30bc2aa59d7c","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            cls.protocol, \u0027\u0027).split(\u0027 \u0027)"},{"line_number":46,"context_line":"        if not cls.access_types:"},{"line_number":47,"context_line":"            raise cls.skipException(\"No access levels were provided for %s \""},{"line_number":48,"context_line":"                                    \"share access tests.\" % cls.protocol)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        cls.share \u003d cls.create_share(share_protocol\u003dcls.protocol,"},{"line_number":51,"context_line":"                                     public\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a57fde8_59401c57","line":48,"range":{"start_line":48,"start_character":36,"end_line":48,"end_character":73},"updated":"2017-01-12 17:41:56.000000000","message":"It is unrelated bugfix. Should be separated to another commit.","commit_id":"0425e93958174cf25d0994f27a146e4f876da33e"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"2729841dd722d6f4ea6320c81dd3926e14b6681b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            cls.protocol, \u0027\u0027).split(\u0027 \u0027)"},{"line_number":46,"context_line":"        if not cls.access_types:"},{"line_number":47,"context_line":"            raise cls.skipException(\"No access levels were provided for %s \""},{"line_number":48,"context_line":"                                    \"share access tests.\" % cls.protocol)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        cls.share \u003d cls.create_share(share_protocol\u003dcls.protocol,"},{"line_number":51,"context_line":"                                     public\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a3c09a3_e373df4b","line":48,"range":{"start_line":48,"start_character":36,"end_line":48,"end_character":73},"in_reply_to":"9a57fde8_59401c57","updated":"2017-01-16 12:03:13.000000000","message":"ok :/","commit_id":"0425e93958174cf25d0994f27a146e4f876da33e"}],"manilaclient/tests/functional/test_snapshot_access.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"8f3a2edebb04c20f2a1671d1c3d75216da82b6c1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"# under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# from tempest.lib import exceptions as tempest_lib_exc"},{"line_number":17,"context_line":"from manilaclient import config"},{"line_number":18,"context_line":"from manilaclient.tests.functional import base"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ba5201f7_f03a83e6","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":55},"updated":"2017-01-10 23:27:08.000000000","message":"I guess this is to be removed?","commit_id":"5492322e106e4a3bc918c09d7b2c4c85c1b7ff2c"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"999c8d5c84444c5179c9cf377aac30bc2aa59d7c","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"CONF \u003d config.CONF"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class SnapshotAccessReadBase(base.BaseTestCase):"},{"line_number":24,"context_line":"    protocol \u003d None"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9a57fde8_f42557ae","line":22,"updated":"2017-01-12 17:41:56.000000000","message":"https://github.com/openstack/python-manilaclient/blob/03889ddd/manilaclient/tests/functional/test_snapshot_instances.py#L28-L30","commit_id":"0425e93958174cf25d0994f27a146e4f876da33e"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"2729841dd722d6f4ea6320c81dd3926e14b6681b","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"CONF \u003d config.CONF"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class SnapshotAccessReadBase(base.BaseTestCase):"},{"line_number":24,"context_line":"    protocol \u003d None"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"7a3c09a3_e3ef5fae","line":22,"in_reply_to":"9a57fde8_f42557ae","updated":"2017-01-16 12:03:13.000000000","message":"Done","commit_id":"0425e93958174cf25d0994f27a146e4f876da33e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"999c8d5c84444c5179c9cf377aac30bc2aa59d7c","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        snapshot \u003d self.create_snapshot(share\u003dself.share[\u0027id\u0027],"},{"line_number":66,"context_line":"                                        client\u003dself.get_user_client(),"},{"line_number":67,"context_line":"                                        cleanup_in_class\u003dFalse)"},{"line_number":68,"context_line":"        self.skip_if_microversion_not_supported(self.microversion)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        access \u003d self._test_create_list_access_rule_for_snapshot("},{"line_number":71,"context_line":"            snapshot[\u0027id\u0027], microversion\u003dself.microversion)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a57fde8_54aaa3d5","line":68,"range":{"start_line":68,"start_character":8,"end_line":68,"end_character":66},"updated":"2017-01-12 17:41:56.000000000","message":"this","commit_id":"0425e93958174cf25d0994f27a146e4f876da33e"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"2729841dd722d6f4ea6320c81dd3926e14b6681b","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        snapshot \u003d self.create_snapshot(share\u003dself.share[\u0027id\u0027],"},{"line_number":66,"context_line":"                                        client\u003dself.get_user_client(),"},{"line_number":67,"context_line":"                                        cleanup_in_class\u003dFalse)"},{"line_number":68,"context_line":"        self.skip_if_microversion_not_supported(self.microversion)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        access \u003d self._test_create_list_access_rule_for_snapshot("},{"line_number":71,"context_line":"            snapshot[\u0027id\u0027], microversion\u003dself.microversion)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a3c09a3_23096796","line":68,"range":{"start_line":68,"start_character":8,"end_line":68,"end_character":66},"in_reply_to":"9a57fde8_54aaa3d5","updated":"2017-01-16 12:03:13.000000000","message":"Done","commit_id":"0425e93958174cf25d0994f27a146e4f876da33e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"999c8d5c84444c5179c9cf377aac30bc2aa59d7c","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        snapshot \u003d self.create_snapshot(share\u003dself.share[\u0027id\u0027],"},{"line_number":89,"context_line":"                                        client\u003dself.get_user_client(),"},{"line_number":90,"context_line":"                                        cleanup_in_class\u003dFalse)"},{"line_number":91,"context_line":"        self.skip_if_microversion_not_supported(self.microversion)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        self._test_create_list_access_rule_for_snapshot("},{"line_number":94,"context_line":"            snapshot[\u0027id\u0027], microversion\u003dself.microversion)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a57fde8_74afa7e3","line":91,"range":{"start_line":91,"start_character":8,"end_line":91,"end_character":66},"updated":"2017-01-12 17:41:56.000000000","message":"this","commit_id":"0425e93958174cf25d0994f27a146e4f876da33e"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"2729841dd722d6f4ea6320c81dd3926e14b6681b","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        snapshot \u003d self.create_snapshot(share\u003dself.share[\u0027id\u0027],"},{"line_number":89,"context_line":"                                        client\u003dself.get_user_client(),"},{"line_number":90,"context_line":"                                        cleanup_in_class\u003dFalse)"},{"line_number":91,"context_line":"        self.skip_if_microversion_not_supported(self.microversion)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        self._test_create_list_access_rule_for_snapshot("},{"line_number":94,"context_line":"            snapshot[\u0027id\u0027], microversion\u003dself.microversion)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a3c09a3_43fe736c","line":91,"range":{"start_line":91,"start_character":8,"end_line":91,"end_character":66},"in_reply_to":"9a57fde8_74afa7e3","updated":"2017-01-16 12:03:13.000000000","message":"Done","commit_id":"0425e93958174cf25d0994f27a146e4f876da33e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"999c8d5c84444c5179c9cf377aac30bc2aa59d7c","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def _create_delete_access_rule(self, snapshot_id, access_type, access_to,"},{"line_number":105,"context_line":"                                   microversion\u003dNone):"},{"line_number":106,"context_line":"        self.skip_if_microversion_not_supported(microversion)"},{"line_number":107,"context_line":"        if access_type not in self.access_types:"},{"line_number":108,"context_line":"            raise self.skipException("},{"line_number":109,"context_line":"                \"\u0027%(access_type)s\u0027 access rules is disabled for protocol \""}],"source_content_type":"text/x-python","patch_set":11,"id":"9a57fde8_14873b62","line":106,"range":{"start_line":106,"start_character":8,"end_line":106,"end_character":61},"updated":"2017-01-12 17:41:56.000000000","message":"and this will be removed after addressing comment for line 22.","commit_id":"0425e93958174cf25d0994f27a146e4f876da33e"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"2729841dd722d6f4ea6320c81dd3926e14b6681b","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def _create_delete_access_rule(self, snapshot_id, access_type, access_to,"},{"line_number":105,"context_line":"                                   microversion\u003dNone):"},{"line_number":106,"context_line":"        self.skip_if_microversion_not_supported(microversion)"},{"line_number":107,"context_line":"        if access_type not in self.access_types:"},{"line_number":108,"context_line":"            raise self.skipException("},{"line_number":109,"context_line":"                \"\u0027%(access_type)s\u0027 access rules is disabled for protocol \""}],"source_content_type":"text/x-python","patch_set":11,"id":"7a3c09a3_83f85b7e","line":106,"range":{"start_line":106,"start_character":8,"end_line":106,"end_character":61},"in_reply_to":"9a57fde8_14873b62","updated":"2017-01-16 12:03:13.000000000","message":"Done","commit_id":"0425e93958174cf25d0994f27a146e4f876da33e"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"37f1c33061e20f0d3b093e29c2566b8d41cb5575","unresolved":false,"context_lines":[{"line_number":22,"context_line":"CONF \u003d config.CONF"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"@testtools.skipUnless(CONF.run_snapshot_tests,"},{"line_number":26,"context_line":"                      \u0027Snapshot tests disabled.\u0027)"},{"line_number":27,"context_line":"@utils.skip_if_microversion_not_supported(\u00272.27\u0027)"},{"line_number":28,"context_line":"class SnapshotAccessReadBase(base.BaseTestCase):"},{"line_number":29,"context_line":"    protocol \u003d None"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a3c09a3_08979f3a","line":26,"range":{"start_line":25,"start_character":0,"end_line":26,"end_character":49},"updated":"2017-01-17 12:38:24.000000000","message":"should also have a config variable to disable mountable snapshot tests","commit_id":"54e1f222ab46e449a638d83b493c3bf784800fd6"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"8fdc95fff3887a54a00024500737f7d3872f374f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"CONF \u003d config.CONF"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"@testtools.skipUnless(CONF.run_snapshot_tests,"},{"line_number":26,"context_line":"                      \u0027Snapshot tests disabled.\u0027)"},{"line_number":27,"context_line":"@utils.skip_if_microversion_not_supported(\u00272.27\u0027)"},{"line_number":28,"context_line":"class SnapshotAccessReadBase(base.BaseTestCase):"},{"line_number":29,"context_line":"    protocol \u003d None"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a3c09a3_5907ad17","line":26,"range":{"start_line":25,"start_character":0,"end_line":26,"end_character":49},"in_reply_to":"7a3c09a3_08979f3a","updated":"2017-01-17 17:39:17.000000000","message":"Added CONF.run_mount_snapshot_tests","commit_id":"54e1f222ab46e449a638d83b493c3bf784800fd6"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"37f1c33061e20f0d3b093e29c2566b8d41cb5575","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            \u0027user\u0027: [\u0027foo_user_%d\u0027 % i for i in int_range],"},{"line_number":51,"context_line":"            \u0027cert\u0027: [\u0027tenant_%d.example.com\u0027 % i for i in int_range],"},{"line_number":52,"context_line":"        }"},{"line_number":53,"context_line":"        cls.microversion \u003d \"2.27\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def _test_create_list_access_rule_for_snapshot(self, snapshot_id,"},{"line_number":56,"context_line":"                                                   microversion):"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a3c09a3_a52a348e","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":33},"updated":"2017-01-17 12:38:24.000000000","message":"this should not be needed, it is configured to use the latest","commit_id":"54e1f222ab46e449a638d83b493c3bf784800fd6"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"8fdc95fff3887a54a00024500737f7d3872f374f","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            \u0027user\u0027: [\u0027foo_user_%d\u0027 % i for i in int_range],"},{"line_number":51,"context_line":"            \u0027cert\u0027: [\u0027tenant_%d.example.com\u0027 % i for i in int_range],"},{"line_number":52,"context_line":"        }"},{"line_number":53,"context_line":"        cls.microversion \u003d \"2.27\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def _test_create_list_access_rule_for_snapshot(self, snapshot_id,"},{"line_number":56,"context_line":"                                                   microversion):"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a3c09a3_5f5a2d2b","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":33},"in_reply_to":"7a3c09a3_a52a348e","updated":"2017-01-17 17:39:17.000000000","message":"Done","commit_id":"54e1f222ab46e449a638d83b493c3bf784800fd6"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"37f1c33061e20f0d3b093e29c2566b8d41cb5575","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                          [access_list[j][\u0027access_type\u0027] for j in range(0, 5)])"},{"line_number":86,"context_line":"            self.assertIn(access[i][\u0027access_to\u0027],"},{"line_number":87,"context_line":"                          [access_list[j][\u0027access_to\u0027] for j in range(0, 5)])"},{"line_number":88,"context_line":"            self.assertTrue(access_list[i][\u0027access_type\u0027] is not None)"},{"line_number":89,"context_line":"            self.assertTrue(access_list[i][\u0027access_to\u0027] is not None)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def test_create_list_access_rule_for_snapshot_select_column(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a3c09a3_c85f57e3","line":88,"range":{"start_line":88,"start_character":17,"end_line":88,"end_character":27},"updated":"2017-01-17 12:38:24.000000000","message":"you should use assertIsNotNone","commit_id":"54e1f222ab46e449a638d83b493c3bf784800fd6"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"8fdc95fff3887a54a00024500737f7d3872f374f","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                          [access_list[j][\u0027access_type\u0027] for j in range(0, 5)])"},{"line_number":86,"context_line":"            self.assertIn(access[i][\u0027access_to\u0027],"},{"line_number":87,"context_line":"                          [access_list[j][\u0027access_to\u0027] for j in range(0, 5)])"},{"line_number":88,"context_line":"            self.assertTrue(access_list[i][\u0027access_type\u0027] is not None)"},{"line_number":89,"context_line":"            self.assertTrue(access_list[i][\u0027access_to\u0027] is not None)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def test_create_list_access_rule_for_snapshot_select_column(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a3c09a3_b34b5386","line":88,"range":{"start_line":88,"start_character":17,"end_line":88,"end_character":27},"in_reply_to":"7a3c09a3_c85f57e3","updated":"2017-01-17 17:39:17.000000000","message":"Done","commit_id":"54e1f222ab46e449a638d83b493c3bf784800fd6"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"37f1c33061e20f0d3b093e29c2566b8d41cb5575","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            self.assertIn(access[i][\u0027access_to\u0027],"},{"line_number":87,"context_line":"                          [access_list[j][\u0027access_to\u0027] for j in range(0, 5)])"},{"line_number":88,"context_line":"            self.assertTrue(access_list[i][\u0027access_type\u0027] is not None)"},{"line_number":89,"context_line":"            self.assertTrue(access_list[i][\u0027access_to\u0027] is not None)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def test_create_list_access_rule_for_snapshot_select_column(self):"},{"line_number":92,"context_line":"        snapshot \u003d self.create_snapshot(share\u003dself.share[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a3c09a3_285b7bf7","line":89,"range":{"start_line":89,"start_character":17,"end_line":89,"end_character":27},"updated":"2017-01-17 12:38:24.000000000","message":"same as above","commit_id":"54e1f222ab46e449a638d83b493c3bf784800fd6"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"8fdc95fff3887a54a00024500737f7d3872f374f","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            self.assertIn(access[i][\u0027access_to\u0027],"},{"line_number":87,"context_line":"                          [access_list[j][\u0027access_to\u0027] for j in range(0, 5)])"},{"line_number":88,"context_line":"            self.assertTrue(access_list[i][\u0027access_type\u0027] is not None)"},{"line_number":89,"context_line":"            self.assertTrue(access_list[i][\u0027access_to\u0027] is not None)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def test_create_list_access_rule_for_snapshot_select_column(self):"},{"line_number":92,"context_line":"        snapshot \u003d self.create_snapshot(share\u003dself.share[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a3c09a3_937c97b6","line":89,"range":{"start_line":89,"start_character":17,"end_line":89,"end_character":27},"in_reply_to":"7a3c09a3_285b7bf7","updated":"2017-01-17 17:39:17.000000000","message":"Done","commit_id":"54e1f222ab46e449a638d83b493c3bf784800fd6"}],"manilaclient/tests/functional/test_snapshot_instances_export_locations.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"37f1c33061e20f0d3b093e29c2566b8d41cb5575","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"@ddt.ddt"},{"line_number":28,"context_line":"@testtools.skipUnless(CONF.run_snapshot_tests,"},{"line_number":29,"context_line":"                      \u0027Snapshot tests disabled.\u0027)"},{"line_number":30,"context_line":"@utils.skip_if_microversion_not_supported(\u00272.27\u0027)"},{"line_number":31,"context_line":"class SnapshotExportLocationReadWriteTest(base.BaseTestCase):"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7a3c09a3_289c5b5c","line":29,"range":{"start_line":28,"start_character":0,"end_line":29,"end_character":49},"updated":"2017-01-17 12:38:24.000000000","message":"same","commit_id":"54e1f222ab46e449a638d83b493c3bf784800fd6"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"8fdc95fff3887a54a00024500737f7d3872f374f","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"@ddt.ddt"},{"line_number":28,"context_line":"@testtools.skipUnless(CONF.run_snapshot_tests,"},{"line_number":29,"context_line":"                      \u0027Snapshot tests disabled.\u0027)"},{"line_number":30,"context_line":"@utils.skip_if_microversion_not_supported(\u00272.27\u0027)"},{"line_number":31,"context_line":"class SnapshotExportLocationReadWriteTest(base.BaseTestCase):"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7a3c09a3_0462183e","line":29,"range":{"start_line":28,"start_character":0,"end_line":29,"end_character":49},"in_reply_to":"7a3c09a3_289c5b5c","updated":"2017-01-17 17:39:17.000000000","message":"Done","commit_id":"54e1f222ab46e449a638d83b493c3bf784800fd6"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4f44998c9a7cce909ca29f8aa7588035c091081b","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        self.assertGreater(len(export_locations), 0)"},{"line_number":111,"context_line":"        expected_keys \u003d (\u0027Id\u0027, \u0027Path\u0027)"},{"line_number":112,"context_line":"        unexpected_keys \u003d (\u0027Updated At\u0027, \u0027Created At\u0027, \u0027Is Admin only\u0027)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        for el in export_locations:"},{"line_number":115,"context_line":"            for key in expected_keys:"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_9d37d8e2","line":112,"range":{"start_line":112,"start_character":27,"end_line":112,"end_character":53},"updated":"2017-01-19 13:01:24.000000000","message":"Presence of these two in \"detail\" API is not tested.","commit_id":"2e776e83859fe5d37ff89aed7068b83b975f2a95"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"dc0797209f395e6db5a9c639aefd22a23392cc7c","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        self.assertGreater(len(export_locations), 0)"},{"line_number":111,"context_line":"        expected_keys \u003d (\u0027Id\u0027, \u0027Path\u0027)"},{"line_number":112,"context_line":"        unexpected_keys \u003d (\u0027Updated At\u0027, \u0027Created At\u0027, \u0027Is Admin only\u0027)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        for el in export_locations:"},{"line_number":115,"context_line":"            for key in expected_keys:"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_3feec622","line":112,"range":{"start_line":112,"start_character":27,"end_line":112,"end_character":53},"in_reply_to":"5a3905b3_9d37d8e2","updated":"2017-01-19 19:09:25.000000000","message":"You are right, I\u0027m adding these keys to test.","commit_id":"2e776e83859fe5d37ff89aed7068b83b975f2a95"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"aa5eced14765e33c02446912995d25e3d17190d7","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                      CONF.run_mount_snapshot_tests,"},{"line_number":30,"context_line":"                      \"Snapshots or mountable snapshots tests are disabled.\")"},{"line_number":31,"context_line":"@utils.skip_if_microversion_not_supported(\u00272.31\u0027)"},{"line_number":32,"context_line":"class SnapshotExportLocationReadWriteTest(base.BaseTestCase):"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @classmethod"},{"line_number":35,"context_line":"    def setUpClass(cls):"}],"source_content_type":"text/x-python","patch_set":23,"id":"5a3905b3_f8a65cbf","line":32,"updated":"2017-01-24 11:43:09.000000000","message":"Lost \"Instance\" inside of the class name?","commit_id":"576cd94281ea0bd221085f3f7cb7da3fb24571ee"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"f2c80e542b09ae783faf23bbf59b3a93455221f0","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                      CONF.run_mount_snapshot_tests,"},{"line_number":30,"context_line":"                      \"Snapshots or mountable snapshots tests are disabled.\")"},{"line_number":31,"context_line":"@utils.skip_if_microversion_not_supported(\u00272.31\u0027)"},{"line_number":32,"context_line":"class SnapshotExportLocationReadWriteTest(base.BaseTestCase):"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @classmethod"},{"line_number":35,"context_line":"    def setUpClass(cls):"}],"source_content_type":"text/x-python","patch_set":23,"id":"5a3905b3_f6ebcd10","line":32,"in_reply_to":"5a3905b3_f8a65cbf","updated":"2017-01-24 13:20:29.000000000","message":"Done","commit_id":"576cd94281ea0bd221085f3f7cb7da3fb24571ee"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"aa5eced14765e33c02446912995d25e3d17190d7","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @classmethod"},{"line_number":35,"context_line":"    def setUpClass(cls):"},{"line_number":36,"context_line":"        super(SnapshotExportLocationReadWriteTest, cls).setUpClass()"},{"line_number":37,"context_line":"        cls.share \u003d cls.create_share("},{"line_number":38,"context_line":"            client\u003dcls.get_user_client(),"},{"line_number":39,"context_line":"            cleanup_in_class\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":23,"id":"5a3905b3_58985078","line":36,"range":{"start_line":36,"start_character":14,"end_line":36,"end_character":49},"updated":"2017-01-24 11:43:09.000000000","message":"ditto","commit_id":"576cd94281ea0bd221085f3f7cb7da3fb24571ee"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"f2c80e542b09ae783faf23bbf59b3a93455221f0","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @classmethod"},{"line_number":35,"context_line":"    def setUpClass(cls):"},{"line_number":36,"context_line":"        super(SnapshotExportLocationReadWriteTest, cls).setUpClass()"},{"line_number":37,"context_line":"        cls.share \u003d cls.create_share("},{"line_number":38,"context_line":"            client\u003dcls.get_user_client(),"},{"line_number":39,"context_line":"            cleanup_in_class\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":23,"id":"5a3905b3_16ef791e","line":36,"range":{"start_line":36,"start_character":14,"end_line":36,"end_character":49},"in_reply_to":"5a3905b3_58985078","updated":"2017-01-24 13:20:29.000000000","message":"Done","commit_id":"576cd94281ea0bd221085f3f7cb7da3fb24571ee"}],"manilaclient/tests/functional/test_snapshots_export_locations.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"999c8d5c84444c5179c9cf377aac30bc2aa59d7c","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"@ddt.ddt"},{"line_number":23,"context_line":"class SnapshotExportLocationReadWriteTest(base.BaseTestCase):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @classmethod"},{"line_number":26,"context_line":"    def setUpClass(cls):"},{"line_number":27,"context_line":"        super(SnapshotExportLocationReadWriteTest, cls).setUpClass()"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a57fde8_b4902f97","line":24,"updated":"2017-01-12 17:41:56.000000000","message":"Same as for https://review.openstack.org/#/c/345625/11/manilaclient/tests/functional/test_snapshot_access.py","commit_id":"0425e93958174cf25d0994f27a146e4f876da33e"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"2729841dd722d6f4ea6320c81dd3926e14b6681b","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"@ddt.ddt"},{"line_number":23,"context_line":"class SnapshotExportLocationReadWriteTest(base.BaseTestCase):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @classmethod"},{"line_number":26,"context_line":"    def setUpClass(cls):"},{"line_number":27,"context_line":"        super(SnapshotExportLocationReadWriteTest, cls).setUpClass()"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a3c09a3_0379cbfc","line":24,"in_reply_to":"9a57fde8_b4902f97","updated":"2017-01-16 12:03:13.000000000","message":"Done","commit_id":"0425e93958174cf25d0994f27a146e4f876da33e"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"37f1c33061e20f0d3b093e29c2566b8d41cb5575","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"@ddt.ddt"},{"line_number":28,"context_line":"@testtools.skipUnless(CONF.run_snapshot_tests,"},{"line_number":29,"context_line":"                      \u0027Snapshot tests disabled.\u0027)"},{"line_number":30,"context_line":"@utils.skip_if_microversion_not_supported(\u00272.27\u0027)"},{"line_number":31,"context_line":"class SnapshotExportLocationReadWriteTest(base.BaseTestCase):"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7a3c09a3_e81893d5","line":29,"range":{"start_line":28,"start_character":0,"end_line":29,"end_character":49},"updated":"2017-01-17 12:38:24.000000000","message":"same","commit_id":"54e1f222ab46e449a638d83b493c3bf784800fd6"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"8fdc95fff3887a54a00024500737f7d3872f374f","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"@ddt.ddt"},{"line_number":28,"context_line":"@testtools.skipUnless(CONF.run_snapshot_tests,"},{"line_number":29,"context_line":"                      \u0027Snapshot tests disabled.\u0027)"},{"line_number":30,"context_line":"@utils.skip_if_microversion_not_supported(\u00272.27\u0027)"},{"line_number":31,"context_line":"class SnapshotExportLocationReadWriteTest(base.BaseTestCase):"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7a3c09a3_e4e0ac98","line":29,"range":{"start_line":28,"start_character":0,"end_line":29,"end_character":49},"in_reply_to":"7a3c09a3_e81893d5","updated":"2017-01-17 17:39:17.000000000","message":"Done","commit_id":"54e1f222ab46e449a638d83b493c3bf784800fd6"}],"manilaclient/tests/unit/v2/fakes.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"49192280b0867e495987bfecc4a0724a3a5dc858","unresolved":false,"context_lines":[{"line_number":980,"context_line":""},{"line_number":981,"context_line":"    def get_snapshots_1234_access_list(self, **kw):"},{"line_number":982,"context_line":"        access_list \u003d {\u0027snapshot_access_list\u0027: [{"},{"line_number":983,"context_line":"            \u0027access_level\u0027: \u0027rw\u0027,"},{"line_number":984,"context_line":"            \u0027state\u0027: \u0027active\u0027,"},{"line_number":985,"context_line":"            \u0027id\u0027: \u00271234\u0027,"},{"line_number":986,"context_line":"            \u0027access_type\u0027: \u0027ip\u0027,"}],"source_content_type":"text/x-python","patch_set":20,"id":"5a3905b3_cb56845b","line":983,"range":{"start_line":983,"start_character":13,"end_line":983,"end_character":33},"updated":"2017-01-22 05:20:27.000000000","message":"The model should have no access_level","commit_id":"dd7e665494028d1d3de47173262ec87c22b70369"}],"manilaclient/tests/unit/v2/test_share_snapshots.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"c54099067667d6a942b80ccc06b7e61c8b8260ec","unresolved":false,"context_lines":[{"line_number":207,"context_line":"        with mock.patch.object(manager, \"_action\"):"},{"line_number":208,"context_line":"            manager.deny(snapshot, id)"},{"line_number":209,"context_line":"            manager._action.assert_called_once_with("},{"line_number":210,"context_line":"                \"deny_access\", snapshot, {\u0027access_id\u0027: id})"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_74fbc347","line":210,"updated":"2016-07-30 06:05:36.000000000","message":"please add the test for list access.","commit_id":"21c2a40f30fa6a9ad838c09c363c345121eb3494"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"741278634bc6c1843f3b0eb63410ad7246f94e39","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        access \u003d (\"foo\", {\"access\": \"fake\"})"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        version \u003d api_versions.APIVersion(\"2.19\")"},{"line_number":191,"context_line":"        mock_microversion \u003d mock.Mock(api_version\u003dversion)"},{"line_number":192,"context_line":"        manager \u003d share_snapshots.ShareSnapshotManager(api\u003dmock_microversion)"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_730cd33b","line":190,"range":{"start_line":190,"start_character":43,"end_line":190,"end_character":47},"updated":"2016-12-20 07:08:20.000000000","message":"2.25?","commit_id":"180dfb355aa043c71466af82a4157b54cc78545a"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"741278634bc6c1843f3b0eb63410ad7246f94e39","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        snapshot \u003d \"fake_snapshot\""},{"line_number":201,"context_line":"        id \u003d \"fake_id\""},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        version \u003d api_versions.APIVersion(\"2.19\")"},{"line_number":204,"context_line":"        mock_microversion \u003d mock.Mock(api_version\u003dversion)"},{"line_number":205,"context_line":"        manager \u003d share_snapshots.ShareSnapshotManager(api\u003dmock_microversion)"},{"line_number":206,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_5357d701","line":203,"range":{"start_line":203,"start_character":43,"end_line":203,"end_character":47},"updated":"2016-12-20 07:08:20.000000000","message":"ditto","commit_id":"180dfb355aa043c71466af82a4157b54cc78545a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"49192280b0867e495987bfecc4a0724a3a5dc858","unresolved":false,"context_lines":[{"line_number":210,"context_line":"            manager.deny(snapshot, access_id)"},{"line_number":211,"context_line":"            manager._action.assert_called_once_with("},{"line_number":212,"context_line":"                \"deny_access\", snapshot, {\u0027access_id\u0027: access_id})"},{"line_number":213,"context_line":"        cs.assert_called(\u0027DELETE\u0027, \u0027/snapshots/1234\u0027)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def test_access_list(self):"},{"line_number":216,"context_line":"        cs.share_snapshots.access_list(1234)"}],"source_content_type":"text/x-python","patch_set":20,"id":"5a3905b3_6b67504d","line":213,"range":{"start_line":213,"start_character":25,"end_line":213,"end_character":52},"updated":"2017-01-22 05:20:27.000000000","message":"?","commit_id":"dd7e665494028d1d3de47173262ec87c22b70369"}],"manilaclient/tests/unit/v2/test_shell.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"37f1c33061e20f0d3b093e29c2566b8d41cb5575","unresolved":false,"context_lines":[{"line_number":1472,"context_line":"        cliutils.print_list.assert_called_with("},{"line_number":1473,"context_line":"            mock.ANY, [\u0027id\u0027, \u0027access_type\u0027, \u0027access_to\u0027, \u0027state\u0027])"},{"line_number":1474,"context_line":""},{"line_number":1475,"context_line":"    @mock.patch.object(cliutils, \u0027print_dict\u0027, mock.Mock())"},{"line_number":1476,"context_line":"    def test_snapshot_access_allow(self):"},{"line_number":1477,"context_line":"        self.run_command(\"snapshot-access-allow 1234 ip 1.1.1.1\")"},{"line_number":1478,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7a3c09a3_0b55d9f8","line":1475,"range":{"start_line":1475,"start_character":47,"end_line":1475,"end_character":58},"updated":"2017-01-17 12:38:24.000000000","message":"this is default, please remove. Same for other entries below.","commit_id":"54e1f222ab46e449a638d83b493c3bf784800fd6"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"8fdc95fff3887a54a00024500737f7d3872f374f","unresolved":false,"context_lines":[{"line_number":1472,"context_line":"        cliutils.print_list.assert_called_with("},{"line_number":1473,"context_line":"            mock.ANY, [\u0027id\u0027, \u0027access_type\u0027, \u0027access_to\u0027, \u0027state\u0027])"},{"line_number":1474,"context_line":""},{"line_number":1475,"context_line":"    @mock.patch.object(cliutils, \u0027print_dict\u0027, mock.Mock())"},{"line_number":1476,"context_line":"    def test_snapshot_access_allow(self):"},{"line_number":1477,"context_line":"        self.run_command(\"snapshot-access-allow 1234 ip 1.1.1.1\")"},{"line_number":1478,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7a3c09a3_1796c93e","line":1475,"range":{"start_line":1475,"start_character":47,"end_line":1475,"end_character":58},"in_reply_to":"7a3c09a3_0b55d9f8","updated":"2017-01-17 17:39:17.000000000","message":"If I omit this the mock will be created and passed as an extra argument to the function. So, to keep consistent with other tests from this file, I think is better to keep it.","commit_id":"54e1f222ab46e449a638d83b493c3bf784800fd6"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"251b0c7a0a76d5cc3fe960c0c993798ca715880e","unresolved":false,"context_lines":[{"line_number":2065,"context_line":"        self.assert_called("},{"line_number":2066,"context_line":"            \u0027GET\u0027, \u0027/snapshot-instances?snapshot_id\u003dfake-snapshot-id\u0027)"},{"line_number":2067,"context_line":""},{"line_number":2068,"context_line":"    def test_snapshot_instance_show(self):"},{"line_number":2069,"context_line":"        self.run_command(\u0027snapshot-instance-show 1234\u0027)"},{"line_number":2070,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/snapshot-instances/1234\u0027)"},{"line_number":2071,"context_line":""},{"line_number":2072,"context_line":"    def test_snapshot_instance_reset_state(self):"},{"line_number":2073,"context_line":"        self.run_command(\u0027snapshot-instance-reset-state 1234\u0027)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_faed428f","side":"PARENT","line":2070,"range":{"start_line":2068,"start_character":1,"end_line":2070,"end_character":61},"updated":"2017-01-19 12:57:09.000000000","message":"Why it is deleted?","commit_id":"87d07e15879a09ff457179b764df476545259a04"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"dc0797209f395e6db5a9c639aefd22a23392cc7c","unresolved":false,"context_lines":[{"line_number":2065,"context_line":"        self.assert_called("},{"line_number":2066,"context_line":"            \u0027GET\u0027, \u0027/snapshot-instances?snapshot_id\u003dfake-snapshot-id\u0027)"},{"line_number":2067,"context_line":""},{"line_number":2068,"context_line":"    def test_snapshot_instance_show(self):"},{"line_number":2069,"context_line":"        self.run_command(\u0027snapshot-instance-show 1234\u0027)"},{"line_number":2070,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/snapshot-instances/1234\u0027)"},{"line_number":2071,"context_line":""},{"line_number":2072,"context_line":"    def test_snapshot_instance_reset_state(self):"},{"line_number":2073,"context_line":"        self.run_command(\u0027snapshot-instance-reset-state 1234\u0027)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_66e290d7","side":"PARENT","line":2070,"range":{"start_line":2068,"start_character":1,"end_line":2070,"end_character":61},"in_reply_to":"5a3905b3_faed428f","updated":"2017-01-19 19:09:25.000000000","message":"moved back","commit_id":"87d07e15879a09ff457179b764df476545259a04"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a37416e95b684e1fb8bcb9028aa3939d8fdbdb01","unresolved":false,"context_lines":[{"line_number":2162,"context_line":""},{"line_number":2163,"context_line":"    def test_snapshot_instance_show(self):"},{"line_number":2164,"context_line":"        self.run_command(\u0027snapshot-instance-show 1234\u0027)"},{"line_number":2165,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/snapshot-instances/1234/export-locations\u0027)"},{"line_number":2166,"context_line":""},{"line_number":2167,"context_line":"    def test_snapshot_instance_reset_state(self):"},{"line_number":2168,"context_line":"        self.run_command(\u0027snapshot-instance-reset-state 1234\u0027)"}],"source_content_type":"text/x-python","patch_set":23,"id":"5a3905b3_db143aa1","line":2165,"range":{"start_line":2165,"start_character":8,"end_line":2165,"end_character":78},"updated":"2017-01-24 11:57:49.000000000","message":"Actually it is second call, not the only one.","commit_id":"576cd94281ea0bd221085f3f7cb7da3fb24571ee"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"f2c80e542b09ae783faf23bbf59b3a93455221f0","unresolved":false,"context_lines":[{"line_number":2162,"context_line":""},{"line_number":2163,"context_line":"    def test_snapshot_instance_show(self):"},{"line_number":2164,"context_line":"        self.run_command(\u0027snapshot-instance-show 1234\u0027)"},{"line_number":2165,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/snapshot-instances/1234/export-locations\u0027)"},{"line_number":2166,"context_line":""},{"line_number":2167,"context_line":"    def test_snapshot_instance_reset_state(self):"},{"line_number":2168,"context_line":"        self.run_command(\u0027snapshot-instance-reset-state 1234\u0027)"}],"source_content_type":"text/x-python","patch_set":23,"id":"5a3905b3_51b82b75","line":2165,"range":{"start_line":2165,"start_character":8,"end_line":2165,"end_character":78},"in_reply_to":"5a3905b3_db143aa1","updated":"2017-01-24 13:20:29.000000000","message":"Added an assert to previous call","commit_id":"576cd94281ea0bd221085f3f7cb7da3fb24571ee"}],"manilaclient/v2/share_snapshot_export_locations.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"741278634bc6c1843f3b0eb63410ad7246f94e39","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"class ShareSnapshotExportLocation(common_base.Resource):"},{"line_number":12,"context_line":"    \"\"\"Represent a snapshot of a share.\"\"\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    def __repr__(self):"},{"line_number":15,"context_line":"        return \"\u003cShareSnapshotExportLocation: %s\u003e\" % self.id"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_d8814491","line":12,"range":{"start_line":12,"start_character":27,"end_line":12,"end_character":28},"updated":"2016-12-20 07:08:20.000000000","message":"export location","commit_id":"180dfb355aa043c71466af82a4157b54cc78545a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"999c8d5c84444c5179c9cf377aac30bc2aa59d7c","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def __getitem__(self, key):"},{"line_number":33,"context_line":"        return self._info[key]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class ShareSnapshotExportLocationManager(base.ManagerWithFind):"},{"line_number":37,"context_line":"    \"\"\"Manage :class:`ShareExportLocation` resources.\"\"\""},{"line_number":38,"context_line":"    resource_class \u003d ShareSnapshotExportLocation"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a57fde8_99ffe433","line":35,"updated":"2017-01-12 17:41:56.000000000","message":"It is inconsistent with current approach to mix snapshot and snapshot instance export locations into one module.\n\nI think, it will be better to add those 2 new actions to each of existing modules for snapshot and snapshot instances. Further the same could be done to share and share instance export locations.","commit_id":"0425e93958174cf25d0994f27a146e4f876da33e"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"2729841dd722d6f4ea6320c81dd3926e14b6681b","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def __getitem__(self, key):"},{"line_number":33,"context_line":"        return self._info[key]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class ShareSnapshotExportLocationManager(base.ManagerWithFind):"},{"line_number":37,"context_line":"    \"\"\"Manage :class:`ShareExportLocation` resources.\"\"\""},{"line_number":38,"context_line":"    resource_class \u003d ShareSnapshotExportLocation"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a3c09a3_bf135f65","line":35,"in_reply_to":"9a57fde8_99ffe433","updated":"2017-01-16 12:03:13.000000000","message":"Hmm, ok, creating separated modules to snapshots and snapshot instances.","commit_id":"0425e93958174cf25d0994f27a146e4f876da33e"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"37f1c33061e20f0d3b093e29c2566b8d41cb5575","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class ShareSnapshotExportLocation(common_base.Resource):"},{"line_number":27,"context_line":"    \"\"\"Represent a export location snapshot of a share.\"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def __repr__(self):"},{"line_number":30,"context_line":"        return \"\u003cShareSnapshotExportLocation: %s\u003e\" % self.id"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a3c09a3_c84bd785","line":27,"range":{"start_line":27,"start_character":49,"end_line":27,"end_character":54},"updated":"2017-01-17 12:38:24.000000000","message":"snapshot","commit_id":"54e1f222ab46e449a638d83b493c3bf784800fd6"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"8fdc95fff3887a54a00024500737f7d3872f374f","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class ShareSnapshotExportLocation(common_base.Resource):"},{"line_number":27,"context_line":"    \"\"\"Represent a export location snapshot of a share.\"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def __repr__(self):"},{"line_number":30,"context_line":"        return \"\u003cShareSnapshotExportLocation: %s\u003e\" % self.id"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a3c09a3_eef090ff","line":27,"range":{"start_line":27,"start_character":49,"end_line":27,"end_character":54},"in_reply_to":"7a3c09a3_c84bd785","updated":"2017-01-17 17:39:17.000000000","message":"Done","commit_id":"54e1f222ab46e449a638d83b493c3bf784800fd6"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"82d2667a8755926b5c4188d0b1df70dd631e6c03","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        return self._get(\"/%(model)s/%(id)s/export-locations/\""},{"line_number":61,"context_line":"                         \"%(export_location_id)s\" % params,"},{"line_number":62,"context_line":"                         \"share_snapshot_export_locations\")"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_e981ec90","line":62,"range":{"start_line":62,"start_character":56,"end_line":62,"end_character":57},"updated":"2017-01-19 17:29:57.000000000","message":"this changed to singular","commit_id":"2e776e83859fe5d37ff89aed7068b83b975f2a95"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"dc0797209f395e6db5a9c639aefd22a23392cc7c","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        return self._get(\"/%(model)s/%(id)s/export-locations/\""},{"line_number":61,"context_line":"                         \"%(export_location_id)s\" % params,"},{"line_number":62,"context_line":"                         \"share_snapshot_export_locations\")"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_e4b91330","line":62,"range":{"start_line":62,"start_character":56,"end_line":62,"end_character":57},"in_reply_to":"5a3905b3_e981ec90","updated":"2017-01-19 19:09:25.000000000","message":"Done","commit_id":"2e776e83859fe5d37ff89aed7068b83b975f2a95"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"49192280b0867e495987bfecc4a0724a3a5dc858","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class ShareSnapshotExportLocation(common_base.Resource):"},{"line_number":27,"context_line":"    \"\"\"Represent a export location snapshot of a snapshot.\"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def __repr__(self):"},{"line_number":30,"context_line":"        return \"\u003cShareSnapshotExportLocation: %s\u003e\" % self.id"}],"source_content_type":"text/x-python","patch_set":20,"id":"5a3905b3_0bf08cc8","line":27,"range":{"start_line":27,"start_character":17,"end_line":27,"end_character":18},"updated":"2017-01-22 05:20:27.000000000","message":"nit: an","commit_id":"dd7e665494028d1d3de47173262ec87c22b70369"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"49192280b0867e495987bfecc4a0724a3a5dc858","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        params \u003d {"},{"line_number":55,"context_line":"            \"model\": \"snapshots\","},{"line_number":56,"context_line":"            \"id\": common_base.getid(snapshot),"},{"line_number":57,"context_line":"            \"export_location_id\": export_location_id"},{"line_number":58,"context_line":"        }"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        return self._get(\"/%(model)s/%(id)s/export-locations/\""}],"source_content_type":"text/x-python","patch_set":20,"id":"5a3905b3_4bbc54dc","line":57,"range":{"start_line":57,"start_character":34,"end_line":57,"end_character":52},"updated":"2017-01-22 05:20:27.000000000","message":"trailing comma","commit_id":"dd7e665494028d1d3de47173262ec87c22b70369"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"cd0e4f827744b07f33a1ada92b71e8f7644de1c9","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    def list(self, snapshot\u003dNone):"},{"line_number":42,"context_line":"        params \u003d {"},{"line_number":43,"context_line":"            \u0027id\u0027: common_base.getid(snapshot),"},{"line_number":44,"context_line":"            \u0027model\u0027: \u0027snapshots\u0027,"},{"line_number":45,"context_line":"        }"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        return self._list(\"/%(model)s/%(id)s/export-locations\" % params,"}],"source_content_type":"text/x-python","patch_set":23,"id":"5a3905b3_984d58c6","line":44,"range":{"start_line":44,"start_character":12,"end_line":44,"end_character":33},"updated":"2017-01-24 11:46:40.000000000","message":"It is always the same value, why do you need to have it as substitution part? Same below.","commit_id":"576cd94281ea0bd221085f3f7cb7da3fb24571ee"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"f2c80e542b09ae783faf23bbf59b3a93455221f0","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    def list(self, snapshot\u003dNone):"},{"line_number":42,"context_line":"        params \u003d {"},{"line_number":43,"context_line":"            \u0027id\u0027: common_base.getid(snapshot),"},{"line_number":44,"context_line":"            \u0027model\u0027: \u0027snapshots\u0027,"},{"line_number":45,"context_line":"        }"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        return self._list(\"/%(model)s/%(id)s/export-locations\" % params,"}],"source_content_type":"text/x-python","patch_set":23,"id":"5a3905b3_360e35e5","line":44,"range":{"start_line":44,"start_character":12,"end_line":44,"end_character":33},"in_reply_to":"5a3905b3_984d58c6","updated":"2017-01-24 13:20:29.000000000","message":"Done","commit_id":"576cd94281ea0bd221085f3f7cb7da3fb24571ee"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"cd0e4f827744b07f33a1ada92b71e8f7644de1c9","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        params \u003d {"},{"line_number":55,"context_line":"            \"model\": \"snapshots\","},{"line_number":56,"context_line":"            \"id\": common_base.getid(snapshot),"},{"line_number":57,"context_line":"            \"export_location_id\": export_location_id,"},{"line_number":58,"context_line":"        }"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        return self._get(\"/%(model)s/%(id)s/export-locations/\""}],"source_content_type":"text/x-python","patch_set":23,"id":"5a3905b3_58b3f097","line":57,"range":{"start_line":57,"start_character":34,"end_line":57,"end_character":52},"updated":"2017-01-24 11:46:40.000000000","message":"It is used only once as well as for \"snapshot\" argument. So, you have inconsistent approach for alike arguments in this method.","commit_id":"576cd94281ea0bd221085f3f7cb7da3fb24571ee"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"f2c80e542b09ae783faf23bbf59b3a93455221f0","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        params \u003d {"},{"line_number":55,"context_line":"            \"model\": \"snapshots\","},{"line_number":56,"context_line":"            \"id\": common_base.getid(snapshot),"},{"line_number":57,"context_line":"            \"export_location_id\": export_location_id,"},{"line_number":58,"context_line":"        }"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        return self._get(\"/%(model)s/%(id)s/export-locations/\""}],"source_content_type":"text/x-python","patch_set":23,"id":"5a3905b3_f6a3cdaf","line":57,"range":{"start_line":57,"start_character":34,"end_line":57,"end_character":52},"in_reply_to":"5a3905b3_58b3f097","updated":"2017-01-24 13:20:29.000000000","message":"Done","commit_id":"576cd94281ea0bd221085f3f7cb7da3fb24571ee"}],"manilaclient/v2/share_snapshot_instance_export_locations.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"82d2667a8755926b5c4188d0b1df70dd631e6c03","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        }"},{"line_number":59,"context_line":"        return self._get(\"/%(model)s/%(id)s/export-locations/\""},{"line_number":60,"context_line":"                         \"%(export_location_id)s\" % params,"},{"line_number":61,"context_line":"                         \"share_snapshot_export_locations\")"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_a977e4d2","line":61,"range":{"start_line":61,"start_character":56,"end_line":61,"end_character":57},"updated":"2017-01-19 17:29:57.000000000","message":"this changed to singular","commit_id":"2e776e83859fe5d37ff89aed7068b83b975f2a95"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"dc0797209f395e6db5a9c639aefd22a23392cc7c","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        }"},{"line_number":59,"context_line":"        return self._get(\"/%(model)s/%(id)s/export-locations/\""},{"line_number":60,"context_line":"                         \"%(export_location_id)s\" % params,"},{"line_number":61,"context_line":"                         \"share_snapshot_export_locations\")"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_84812f4d","line":61,"range":{"start_line":61,"start_character":56,"end_line":61,"end_character":57},"in_reply_to":"5a3905b3_a977e4d2","updated":"2017-01-19 19:09:25.000000000","message":"Done","commit_id":"2e776e83859fe5d37ff89aed7068b83b975f2a95"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"49192280b0867e495987bfecc4a0724a3a5dc858","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class ShareSnapshotInstanceExportLocation(common_base.Resource):"},{"line_number":27,"context_line":"    \"\"\"Represent a export location from a snapshot instance.\"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def __repr__(self):"},{"line_number":30,"context_line":"        return \"\u003cShareSnapshotInstanceExportLocation: %s\u003e\" % self.id"}],"source_content_type":"text/x-python","patch_set":20,"id":"5a3905b3_ebe6e013","line":27,"range":{"start_line":27,"start_character":17,"end_line":27,"end_character":18},"updated":"2017-01-22 05:20:27.000000000","message":"nit: an","commit_id":"dd7e665494028d1d3de47173262ec87c22b70369"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"cd0e4f827744b07f33a1ada92b71e8f7644de1c9","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    def list(self, snapshot_instance\u003dNone):"},{"line_number":42,"context_line":"        params \u003d {"},{"line_number":43,"context_line":"            \u0027id\u0027: common_base.getid(snapshot_instance),"},{"line_number":44,"context_line":"            \u0027model\u0027: \u0027snapshot-instances\u0027,"},{"line_number":45,"context_line":"        }"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        return self._list(\"/%(model)s/%(id)s/export-locations\" % params,"}],"source_content_type":"text/x-python","patch_set":23,"id":"5a3905b3_58577057","line":44,"range":{"start_line":44,"start_character":12,"end_line":44,"end_character":42},"updated":"2017-01-24 11:46:40.000000000","message":"It is always the same value, why do you need to have it as substitution part? Same below.","commit_id":"576cd94281ea0bd221085f3f7cb7da3fb24571ee"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"f2c80e542b09ae783faf23bbf59b3a93455221f0","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    def list(self, snapshot_instance\u003dNone):"},{"line_number":42,"context_line":"        params \u003d {"},{"line_number":43,"context_line":"            \u0027id\u0027: common_base.getid(snapshot_instance),"},{"line_number":44,"context_line":"            \u0027model\u0027: \u0027snapshot-instances\u0027,"},{"line_number":45,"context_line":"        }"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        return self._list(\"/%(model)s/%(id)s/export-locations\" % params,"}],"source_content_type":"text/x-python","patch_set":23,"id":"5a3905b3_b6c30537","line":44,"range":{"start_line":44,"start_character":12,"end_line":44,"end_character":42},"in_reply_to":"5a3905b3_58577057","updated":"2017-01-24 13:20:29.000000000","message":"Done","commit_id":"576cd94281ea0bd221085f3f7cb7da3fb24571ee"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"cd0e4f827744b07f33a1ada92b71e8f7644de1c9","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        params \u003d {"},{"line_number":55,"context_line":"            \"model\": \"snapshot-instances\","},{"line_number":56,"context_line":"            \"id\": common_base.getid(snapshot_instance),"},{"line_number":57,"context_line":"            \"export_location_id\": export_location_id,"},{"line_number":58,"context_line":"        }"},{"line_number":59,"context_line":"        return self._get(\"/%(model)s/%(id)s/export-locations/\""},{"line_number":60,"context_line":"                         \"%(export_location_id)s\" % params,"}],"source_content_type":"text/x-python","patch_set":23,"id":"5a3905b3_98a9d826","line":57,"range":{"start_line":57,"start_character":34,"end_line":57,"end_character":52},"updated":"2017-01-24 11:46:40.000000000","message":"It is used only once as well as for \"snapshot\" argument. So, you have inconsistent approach for alike arguments in this method.","commit_id":"576cd94281ea0bd221085f3f7cb7da3fb24571ee"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"f2c80e542b09ae783faf23bbf59b3a93455221f0","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        params \u003d {"},{"line_number":55,"context_line":"            \"model\": \"snapshot-instances\","},{"line_number":56,"context_line":"            \"id\": common_base.getid(snapshot_instance),"},{"line_number":57,"context_line":"            \"export_location_id\": export_location_id,"},{"line_number":58,"context_line":"        }"},{"line_number":59,"context_line":"        return self._get(\"/%(model)s/%(id)s/export-locations/\""},{"line_number":60,"context_line":"                         \"%(export_location_id)s\" % params,"}],"source_content_type":"text/x-python","patch_set":23,"id":"5a3905b3_f6066d84","line":57,"range":{"start_line":57,"start_character":34,"end_line":57,"end_character":52},"in_reply_to":"5a3905b3_98a9d826","updated":"2017-01-24 13:20:29.000000000","message":"Done","commit_id":"576cd94281ea0bd221085f3f7cb7da3fb24571ee"}],"manilaclient/v2/share_snapshots.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"c54099067667d6a942b80ccc06b7e61c8b8260ec","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        return self.manager.allow(self, access_type, access_to)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def deny(self, id):"},{"line_number":60,"context_line":"        \"\"\"Denies access to a share snapshot.\"\"\""},{"line_number":61,"context_line":"        return self.manager.deny(self, id)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def access_list(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_54f83f49","line":60,"range":{"start_line":60,"start_character":11,"end_line":60,"end_character":17},"updated":"2016-07-30 06:05:36.000000000","message":"Deny","commit_id":"21c2a40f30fa6a9ad838c09c363c345121eb3494"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"c66dbd8b13a0345a5f8dd5bd1cb6cf86fd1e3bd6","unresolved":false,"context_lines":[{"line_number":214,"context_line":"    def reset_state(self, snapshot, state):"},{"line_number":215,"context_line":"        return self._do_reset_state(snapshot, state, \"reset_status\")"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    def _do_allow(self, snapshot, access_type, access_to):"},{"line_number":218,"context_line":"        access_params \u003d {"},{"line_number":219,"context_line":"            \u0027access_type\u0027: access_type,"},{"line_number":220,"context_line":"            \u0027access_to\u0027: access_to,"},{"line_number":221,"context_line":"        }"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        return self._action(\u0027allow_access\u0027, snapshot,"},{"line_number":224,"context_line":"                            access_params)[1][\u0027access\u0027]"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    @api_versions.wraps(\"2.19\")"},{"line_number":227,"context_line":"    def allow(self, snapshot, access_type, access_to):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_d592cd9e","line":224,"range":{"start_line":217,"start_character":0,"end_line":224,"end_character":55},"updated":"2016-07-23 14:50:29.000000000","message":"I find the methods simple enough to not need to be divided like this","commit_id":"21c2a40f30fa6a9ad838c09c363c345121eb3494"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7c5bc45afd9f4a30742d90066f418def02db7634","unresolved":false,"context_lines":[{"line_number":227,"context_line":"    def allow(self, snapshot, access_type, access_to):"},{"line_number":228,"context_line":"        return self._do_allow(snapshot, access_type, access_to)"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    def _do_deny(self, snapshot, id):"},{"line_number":231,"context_line":"        return self._action(\u0027deny_access\u0027, snapshot, {\u0027access_id\u0027: id})"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"    @api_versions.wraps(\"2.19\")"},{"line_number":234,"context_line":"    def deny(self, snapshot, id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_70c2b335","line":231,"range":{"start_line":230,"start_character":4,"end_line":231,"end_character":71},"updated":"2016-07-26 12:04:54.000000000","message":"Agree with Rodrigo Barbieri, the deny function is the same.","commit_id":"21c2a40f30fa6a9ad838c09c363c345121eb3494"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"c54099067667d6a942b80ccc06b7e61c8b8260ec","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        access_list \u003d self._action("},{"line_number":239,"context_line":"            \u0027access_list\u0027, snapshot)[1][\"snapshot_access_list\"]"},{"line_number":240,"context_line":"        if access_list:"},{"line_number":241,"context_line":"            t \u003d collections.namedtuple(\u0027Access\u0027, list(access_list[0]))"},{"line_number":242,"context_line":"            return [t(*value.values()) for value in access_list]"},{"line_number":243,"context_line":"        else:"},{"line_number":244,"context_line":"            return []"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_14b08789","line":241,"range":{"start_line":241,"start_character":54,"end_line":241,"end_character":68},"updated":"2016-07-30 06:05:36.000000000","message":"suggest using a more explicit way, like access_lists[0].keys()","commit_id":"21c2a40f30fa6a9ad838c09c363c345121eb3494"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"064dae4e5e9a8a921537f12b387af1ac2b351c3f","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    def unmanage_snapshot(self):"},{"line_number":51,"context_line":"        \"\"\"Unmanage this snapshot.\"\"\""},{"line_number":52,"context_line":"        self.manager.unmanage(self)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def allow(self, access_type, access_to):"},{"line_number":55,"context_line":"        \"\"\"Allow access to a share snapshot.\"\"\""},{"line_number":56,"context_line":"        return self.manager.allow(self, access_type, access_to)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_5a03b673","line":53,"updated":"2017-01-19 12:54:48.000000000","message":"Same as in [1] - why \"access\" logic is part of existing \"snapshot\" modules and \"export_locations\"  are not?\n\n[1] https://review.openstack.org/#/c/345526/44/manila/api/v2/share_snapshots.py","commit_id":"2e776e83859fe5d37ff89aed7068b83b975f2a95"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"82d2667a8755926b5c4188d0b1df70dd631e6c03","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    def unmanage_snapshot(self):"},{"line_number":51,"context_line":"        \"\"\"Unmanage this snapshot.\"\"\""},{"line_number":52,"context_line":"        self.manager.unmanage(self)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def allow(self, access_type, access_to):"},{"line_number":55,"context_line":"        \"\"\"Allow access to a share snapshot.\"\"\""},{"line_number":56,"context_line":"        return self.manager.allow(self, access_type, access_to)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_e9aacc18","line":53,"in_reply_to":"5a3905b3_5a03b673","updated":"2017-01-19 17:29:57.000000000","message":"As discussed on IRC, this will be not implemented within the scope of this patch.","commit_id":"2e776e83859fe5d37ff89aed7068b83b975f2a95"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"dc0797209f395e6db5a9c639aefd22a23392cc7c","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    def unmanage_snapshot(self):"},{"line_number":51,"context_line":"        \"\"\"Unmanage this snapshot.\"\"\""},{"line_number":52,"context_line":"        self.manager.unmanage(self)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def allow(self, access_type, access_to):"},{"line_number":55,"context_line":"        \"\"\"Allow access to a share snapshot.\"\"\""},{"line_number":56,"context_line":"        return self.manager.allow(self, access_type, access_to)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_c4da5778","line":53,"in_reply_to":"5a3905b3_e9aacc18","updated":"2017-01-19 19:09:25.000000000","message":"k","commit_id":"2e776e83859fe5d37ff89aed7068b83b975f2a95"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"741278634bc6c1843f3b0eb63410ad7246f94e39","unresolved":false,"context_lines":[{"line_number":1166,"context_line":"    \u0027access_to\u0027,"},{"line_number":1167,"context_line":"    metavar\u003d\u0027\u003caccess_to\u003e\u0027,"},{"line_number":1168,"context_line":"    help\u003d\u0027Value that defines access.\u0027)"},{"line_number":1169,"context_line":"def do_snapshot_access_allow(cs, args):"},{"line_number":1170,"context_line":"    \"\"\"Allow access to the share snapshot.\"\"\""},{"line_number":1171,"context_line":"    share_snapshot \u003d _find_share_snapshot(cs, args.snapshot)"},{"line_number":1172,"context_line":"    access \u003d share_snapshot.allow(args.access_type, args.access_to)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_d3e7673e","line":1169,"range":{"start_line":1169,"start_character":4,"end_line":1169,"end_character":28},"updated":"2016-12-20 07:08:20.000000000","message":"this new added shell command should be covered by UT, and the following command as well.","commit_id":"180dfb355aa043c71466af82a4157b54cc78545a"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"741278634bc6c1843f3b0eb63410ad7246f94e39","unresolved":false,"context_lines":[{"line_number":1779,"context_line":"    metavar\u003d\u0027\u003cexport_location\u003e\u0027,"},{"line_number":1780,"context_line":"    help\u003d\u0027ID of the share snapshot export location.\u0027)"},{"line_number":1781,"context_line":"def do_snapshot_instance_export_location_show(cs, args):"},{"line_number":1782,"context_line":"    \"\"\"Show export location of the share snapshot.\"\"\""},{"line_number":1783,"context_line":"    snapshot_instance \u003d _find_share_snapshot_instance(cs,"},{"line_number":1784,"context_line":"                                                      args.snapshot_instance)"},{"line_number":1785,"context_line":"    export_location \u003d cs.share_snapshot_export_locations.get("}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_98db4ced","line":1782,"range":{"start_line":1782,"start_character":40,"end_line":1782,"end_character":41},"updated":"2016-12-20 07:08:20.000000000","message":"instance","commit_id":"180dfb355aa043c71466af82a4157b54cc78545a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"999c8d5c84444c5179c9cf377aac30bc2aa59d7c","unresolved":false,"context_lines":[{"line_number":1750,"context_line":"    snapshot._info[\u0027export_locations\u0027] \u003d export_locations"},{"line_number":1751,"context_line":"    _print_share_snapshot(cs, snapshot)"},{"line_number":1752,"context_line":""},{"line_number":1753,"context_line":""},{"line_number":1754,"context_line":"@api_versions.wraps(\"2.26\")"},{"line_number":1755,"context_line":"@cliutils.arg("},{"line_number":1756,"context_line":"    \u0027snapshot\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a57fde8_39b0b8dd","line":1753,"updated":"2017-01-12 17:41:56.000000000","message":"Where are \"do_snapshot_export_location_list\" and \"do_snapshot_instance_export_location_list\" functions?","commit_id":"0425e93958174cf25d0994f27a146e4f876da33e"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"2729841dd722d6f4ea6320c81dd3926e14b6681b","unresolved":false,"context_lines":[{"line_number":1750,"context_line":"    snapshot._info[\u0027export_locations\u0027] \u003d export_locations"},{"line_number":1751,"context_line":"    _print_share_snapshot(cs, snapshot)"},{"line_number":1752,"context_line":""},{"line_number":1753,"context_line":""},{"line_number":1754,"context_line":"@api_versions.wraps(\"2.26\")"},{"line_number":1755,"context_line":"@cliutils.arg("},{"line_number":1756,"context_line":"    \u0027snapshot\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a3c09a3_5fe27ba0","line":1753,"in_reply_to":"9a57fde8_39b0b8dd","updated":"2017-01-16 12:03:13.000000000","message":"Adding both functions.","commit_id":"0425e93958174cf25d0994f27a146e4f876da33e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"999c8d5c84444c5179c9cf377aac30bc2aa59d7c","unresolved":false,"context_lines":[{"line_number":1777,"context_line":"@cliutils.arg("},{"line_number":1778,"context_line":"    \u0027export_location\u0027,"},{"line_number":1779,"context_line":"    metavar\u003d\u0027\u003cexport_location\u003e\u0027,"},{"line_number":1780,"context_line":"    help\u003d\u0027ID of the share snapshot export location.\u0027)"},{"line_number":1781,"context_line":"def do_snapshot_instance_export_location_show(cs, args):"},{"line_number":1782,"context_line":"    \"\"\"Show export location of the share instance snapshot.\"\"\""},{"line_number":1783,"context_line":"    snapshot_instance \u003d _find_share_snapshot_instance(cs,"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a57fde8_d9c16c30","line":1780,"range":{"start_line":1780,"start_character":34,"end_line":1780,"end_character":35},"updated":"2017-01-12 17:41:56.000000000","message":"instance","commit_id":"0425e93958174cf25d0994f27a146e4f876da33e"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"2729841dd722d6f4ea6320c81dd3926e14b6681b","unresolved":false,"context_lines":[{"line_number":1777,"context_line":"@cliutils.arg("},{"line_number":1778,"context_line":"    \u0027export_location\u0027,"},{"line_number":1779,"context_line":"    metavar\u003d\u0027\u003cexport_location\u003e\u0027,"},{"line_number":1780,"context_line":"    help\u003d\u0027ID of the share snapshot export location.\u0027)"},{"line_number":1781,"context_line":"def do_snapshot_instance_export_location_show(cs, args):"},{"line_number":1782,"context_line":"    \"\"\"Show export location of the share instance snapshot.\"\"\""},{"line_number":1783,"context_line":"    snapshot_instance \u003d _find_share_snapshot_instance(cs,"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a3c09a3_069b99ca","line":1780,"range":{"start_line":1780,"start_character":34,"end_line":1780,"end_character":35},"in_reply_to":"9a57fde8_d9c16c30","updated":"2017-01-16 12:03:13.000000000","message":"Done","commit_id":"0425e93958174cf25d0994f27a146e4f876da33e"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"37f1c33061e20f0d3b093e29c2566b8d41cb5575","unresolved":false,"context_lines":[{"line_number":1156,"context_line":"@cliutils.arg("},{"line_number":1157,"context_line":"    \u0027snapshot\u0027,"},{"line_number":1158,"context_line":"    metavar\u003d\u0027\u003csnapshot\u003e\u0027,"},{"line_number":1159,"context_line":"    help\u003d\u0027Name or ID of the NAS share snapshot to modify.\u0027)"},{"line_number":1160,"context_line":"@cliutils.arg("},{"line_number":1161,"context_line":"    \u0027access_type\u0027,"},{"line_number":1162,"context_line":"    metavar\u003d\u0027\u003caccess_type\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a3c09a3_2bcd35b7","line":1159,"range":{"start_line":1159,"start_character":50,"end_line":1159,"end_character":56},"updated":"2017-01-17 12:38:24.000000000","message":"allow access to","commit_id":"54e1f222ab46e449a638d83b493c3bf784800fd6"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"8fdc95fff3887a54a00024500737f7d3872f374f","unresolved":false,"context_lines":[{"line_number":1156,"context_line":"@cliutils.arg("},{"line_number":1157,"context_line":"    \u0027snapshot\u0027,"},{"line_number":1158,"context_line":"    metavar\u003d\u0027\u003csnapshot\u003e\u0027,"},{"line_number":1159,"context_line":"    help\u003d\u0027Name or ID of the NAS share snapshot to modify.\u0027)"},{"line_number":1160,"context_line":"@cliutils.arg("},{"line_number":1161,"context_line":"    \u0027access_type\u0027,"},{"line_number":1162,"context_line":"    metavar\u003d\u0027\u003caccess_type\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a3c09a3_f3015807","line":1159,"range":{"start_line":1159,"start_character":50,"end_line":1159,"end_character":56},"in_reply_to":"7a3c09a3_2bcd35b7","updated":"2017-01-17 17:39:17.000000000","message":"Done","commit_id":"54e1f222ab46e449a638d83b493c3bf784800fd6"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"37f1c33061e20f0d3b093e29c2566b8d41cb5575","unresolved":false,"context_lines":[{"line_number":1191,"context_line":"@cliutils.arg("},{"line_number":1192,"context_line":"    \u0027snapshot\u0027,"},{"line_number":1193,"context_line":"    metavar\u003d\u0027\u003csnapshot\u003e\u0027,"},{"line_number":1194,"context_line":"    help\u003d\u0027Name or ID of the NAS share snapshot to modify.\u0027)"},{"line_number":1195,"context_line":"@cliutils.arg("},{"line_number":1196,"context_line":"    \u0027id\u0027,"},{"line_number":1197,"context_line":"    metavar\u003d\u0027\u003cid\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a3c09a3_abb92517","line":1194,"range":{"start_line":1194,"start_character":50,"end_line":1194,"end_character":56},"updated":"2017-01-17 12:38:24.000000000","message":"deny access to","commit_id":"54e1f222ab46e449a638d83b493c3bf784800fd6"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"8fdc95fff3887a54a00024500737f7d3872f374f","unresolved":false,"context_lines":[{"line_number":1191,"context_line":"@cliutils.arg("},{"line_number":1192,"context_line":"    \u0027snapshot\u0027,"},{"line_number":1193,"context_line":"    metavar\u003d\u0027\u003csnapshot\u003e\u0027,"},{"line_number":1194,"context_line":"    help\u003d\u0027Name or ID of the NAS share snapshot to modify.\u0027)"},{"line_number":1195,"context_line":"@cliutils.arg("},{"line_number":1196,"context_line":"    \u0027id\u0027,"},{"line_number":1197,"context_line":"    metavar\u003d\u0027\u003cid\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a3c09a3_930e5439","line":1194,"range":{"start_line":1194,"start_character":50,"end_line":1194,"end_character":56},"in_reply_to":"7a3c09a3_abb92517","updated":"2017-01-17 17:39:17.000000000","message":"Done","commit_id":"54e1f222ab46e449a638d83b493c3bf784800fd6"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"37f1c33061e20f0d3b093e29c2566b8d41cb5575","unresolved":false,"context_lines":[{"line_number":1259,"context_line":"@cliutils.arg("},{"line_number":1260,"context_line":"    \u0027snapshot\u0027,"},{"line_number":1261,"context_line":"    metavar\u003d\u0027\u003csnapshot\u003e\u0027,"},{"line_number":1262,"context_line":"    help\u003d\u0027Name or ID of the share snapshot.\u0027)"},{"line_number":1263,"context_line":"@cliutils.arg("},{"line_number":1264,"context_line":"    \u0027--columns\u0027,"},{"line_number":1265,"context_line":"    metavar\u003d\u0027\u003ccolumns\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a3c09a3_eb0b2dd4","line":1262,"range":{"start_line":1262,"start_character":42,"end_line":1262,"end_character":45},"updated":"2017-01-17 12:38:24.000000000","message":"to list access of","commit_id":"54e1f222ab46e449a638d83b493c3bf784800fd6"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"8fdc95fff3887a54a00024500737f7d3872f374f","unresolved":false,"context_lines":[{"line_number":1259,"context_line":"@cliutils.arg("},{"line_number":1260,"context_line":"    \u0027snapshot\u0027,"},{"line_number":1261,"context_line":"    metavar\u003d\u0027\u003csnapshot\u003e\u0027,"},{"line_number":1262,"context_line":"    help\u003d\u0027Name or ID of the share snapshot.\u0027)"},{"line_number":1263,"context_line":"@cliutils.arg("},{"line_number":1264,"context_line":"    \u0027--columns\u0027,"},{"line_number":1265,"context_line":"    metavar\u003d\u0027\u003ccolumns\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a3c09a3_73156847","line":1262,"range":{"start_line":1262,"start_character":42,"end_line":1262,"end_character":45},"in_reply_to":"7a3c09a3_eb0b2dd4","updated":"2017-01-17 17:39:17.000000000","message":"Done","commit_id":"54e1f222ab46e449a638d83b493c3bf784800fd6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"49192280b0867e495987bfecc4a0724a3a5dc858","unresolved":false,"context_lines":[{"line_number":1196,"context_line":"    metavar\u003d\u0027\u003caccess_to\u003e\u0027,"},{"line_number":1197,"context_line":"    help\u003d\u0027Value that defines access.\u0027)"},{"line_number":1198,"context_line":"def do_snapshot_access_allow(cs, args):"},{"line_number":1199,"context_line":"    \"\"\"Allow access to the share snapshot.\"\"\""},{"line_number":1200,"context_line":"    share_snapshot \u003d _find_share_snapshot(cs, args.snapshot)"},{"line_number":1201,"context_line":"    access \u003d share_snapshot.allow(args.access_type, args.access_to)"},{"line_number":1202,"context_line":"    cliutils.print_dict(access)"}],"source_content_type":"text/x-python","patch_set":20,"id":"5a3905b3_8bc8fca9","line":1199,"range":{"start_line":1199,"start_character":23,"end_line":1199,"end_character":26},"updated":"2017-01-22 05:20:27.000000000","message":"a","commit_id":"dd7e665494028d1d3de47173262ec87c22b70369"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"49192280b0867e495987bfecc4a0724a3a5dc858","unresolved":false,"context_lines":[{"line_number":1196,"context_line":"    metavar\u003d\u0027\u003caccess_to\u003e\u0027,"},{"line_number":1197,"context_line":"    help\u003d\u0027Value that defines access.\u0027)"},{"line_number":1198,"context_line":"def do_snapshot_access_allow(cs, args):"},{"line_number":1199,"context_line":"    \"\"\"Allow access to the share snapshot.\"\"\""},{"line_number":1200,"context_line":"    share_snapshot \u003d _find_share_snapshot(cs, args.snapshot)"},{"line_number":1201,"context_line":"    access \u003d share_snapshot.allow(args.access_type, args.access_to)"},{"line_number":1202,"context_line":"    cliutils.print_dict(access)"}],"source_content_type":"text/x-python","patch_set":20,"id":"5a3905b3_8b563ccc","line":1199,"range":{"start_line":1199,"start_character":27,"end_line":1199,"end_character":32},"updated":"2017-01-22 05:20:27.000000000","message":"remove","commit_id":"dd7e665494028d1d3de47173262ec87c22b70369"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"49192280b0867e495987bfecc4a0724a3a5dc858","unresolved":false,"context_lines":[{"line_number":1226,"context_line":"    metavar\u003d\u0027\u003cid\u003e\u0027,"},{"line_number":1227,"context_line":"    help\u003d\u0027ID of the access rule to be deleted.\u0027)"},{"line_number":1228,"context_line":"def do_snapshot_access_deny(cs, args):"},{"line_number":1229,"context_line":"    \"\"\"Deny access to a share snapshot.\"\"\""},{"line_number":1230,"context_line":"    snapshot \u003d _find_share_snapshot(cs, args.snapshot)"},{"line_number":1231,"context_line":"    snapshot.deny(args.id)"},{"line_number":1232,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"5a3905b3_6b6590b3","line":1229,"range":{"start_line":1229,"start_character":24,"end_line":1229,"end_character":29},"updated":"2017-01-22 05:20:27.000000000","message":"remove","commit_id":"dd7e665494028d1d3de47173262ec87c22b70369"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"49192280b0867e495987bfecc4a0724a3a5dc858","unresolved":false,"context_lines":[{"line_number":1227,"context_line":"    help\u003d\u0027ID of the access rule to be deleted.\u0027)"},{"line_number":1228,"context_line":"def do_snapshot_access_deny(cs, args):"},{"line_number":1229,"context_line":"    \"\"\"Deny access to a share snapshot.\"\"\""},{"line_number":1230,"context_line":"    snapshot \u003d _find_share_snapshot(cs, args.snapshot)"},{"line_number":1231,"context_line":"    snapshot.deny(args.id)"},{"line_number":1232,"context_line":""},{"line_number":1233,"context_line":""},{"line_number":1234,"context_line":"@api_versions.wraps(\"1.0\", \"2.20\")"}],"source_content_type":"text/x-python","patch_set":20,"id":"5a3905b3_4b39b4a3","line":1231,"range":{"start_line":1230,"start_character":0,"end_line":1231,"end_character":26},"updated":"2017-01-22 05:20:27.000000000","message":"please allow multiple rules to be denied at once","commit_id":"dd7e665494028d1d3de47173262ec87c22b70369"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"49192280b0867e495987bfecc4a0724a3a5dc858","unresolved":false,"context_lines":[{"line_number":1297,"context_line":"    help\u003d\u0027Comma separated list of columns to be displayed \u0027"},{"line_number":1298,"context_line":"         \u0027e.g. --columns \"access_type,access_to\"\u0027)"},{"line_number":1299,"context_line":"def do_snapshot_access_list(cs, args):"},{"line_number":1300,"context_line":"    \"\"\"Show access list for share snapshot.\"\"\""},{"line_number":1301,"context_line":"    list_of_keys \u003d ["},{"line_number":1302,"context_line":"        \u0027id\u0027, \u0027access_type\u0027, \u0027access_to\u0027, \u0027state\u0027"},{"line_number":1303,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":20,"id":"5a3905b3_2b51c8d8","line":1300,"range":{"start_line":1300,"start_character":28,"end_line":1300,"end_character":33},"updated":"2017-01-22 05:20:27.000000000","message":"a","commit_id":"dd7e665494028d1d3de47173262ec87c22b70369"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"49192280b0867e495987bfecc4a0724a3a5dc858","unresolved":false,"context_lines":[{"line_number":1299,"context_line":"def do_snapshot_access_list(cs, args):"},{"line_number":1300,"context_line":"    \"\"\"Show access list for share snapshot.\"\"\""},{"line_number":1301,"context_line":"    list_of_keys \u003d ["},{"line_number":1302,"context_line":"        \u0027id\u0027, \u0027access_type\u0027, \u0027access_to\u0027, \u0027state\u0027"},{"line_number":1303,"context_line":"    ]"},{"line_number":1304,"context_line":""},{"line_number":1305,"context_line":"    if args.columns is not None:"}],"source_content_type":"text/x-python","patch_set":20,"id":"5a3905b3_6bdaf04d","line":1302,"range":{"start_line":1302,"start_character":9,"end_line":1302,"end_character":49},"updated":"2017-01-22 05:20:27.000000000","message":"Sentence case?","commit_id":"dd7e665494028d1d3de47173262ec87c22b70369"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b6c9ddca3d400138724e374d4eb31434145e004c","unresolved":false,"context_lines":[{"line_number":1202,"context_line":"    metavar\u003d\u0027\u003caccess_to\u003e\u0027,"},{"line_number":1203,"context_line":"    help\u003d\u0027Value that defines access.\u0027)"},{"line_number":1204,"context_line":"def do_snapshot_access_allow(cs, args):"},{"line_number":1205,"context_line":"    \"\"\"Allow access to a snapshot.\"\"\""},{"line_number":1206,"context_line":"    share_snapshot \u003d _find_share_snapshot(cs, args.snapshot)"},{"line_number":1207,"context_line":"    access \u003d share_snapshot.allow(args.access_type, args.access_to)"},{"line_number":1208,"context_line":"    cliutils.print_dict(access)"}],"source_content_type":"text/x-python","patch_set":23,"id":"5a3905b3_fbee5620","line":1205,"range":{"start_line":1205,"start_character":7,"end_line":1205,"end_character":34},"updated":"2017-01-24 11:54:03.000000000","message":"I guess it should say explicitly that it will be RO access always.","commit_id":"576cd94281ea0bd221085f3f7cb7da3fb24571ee"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"f2c80e542b09ae783faf23bbf59b3a93455221f0","unresolved":false,"context_lines":[{"line_number":1202,"context_line":"    metavar\u003d\u0027\u003caccess_to\u003e\u0027,"},{"line_number":1203,"context_line":"    help\u003d\u0027Value that defines access.\u0027)"},{"line_number":1204,"context_line":"def do_snapshot_access_allow(cs, args):"},{"line_number":1205,"context_line":"    \"\"\"Allow access to a snapshot.\"\"\""},{"line_number":1206,"context_line":"    share_snapshot \u003d _find_share_snapshot(cs, args.snapshot)"},{"line_number":1207,"context_line":"    access \u003d share_snapshot.allow(args.access_type, args.access_to)"},{"line_number":1208,"context_line":"    cliutils.print_dict(access)"}],"source_content_type":"text/x-python","patch_set":23,"id":"5a3905b3_b680658c","line":1205,"range":{"start_line":1205,"start_character":7,"end_line":1205,"end_character":34},"in_reply_to":"5a3905b3_fbee5620","updated":"2017-01-24 13:20:29.000000000","message":"Done","commit_id":"576cd94281ea0bd221085f3f7cb7da3fb24571ee"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b6c9ddca3d400138724e374d4eb31434145e004c","unresolved":false,"context_lines":[{"line_number":1231,"context_line":"    \u0027id\u0027,"},{"line_number":1232,"context_line":"    metavar\u003d\u0027\u003cid\u003e\u0027,"},{"line_number":1233,"context_line":"    nargs\u003d\u0027+\u0027,"},{"line_number":1234,"context_line":"    help\u003d\u0027ID(s) of the access rule to be deleted.\u0027)"},{"line_number":1235,"context_line":"def do_snapshot_access_deny(cs, args):"},{"line_number":1236,"context_line":"    \"\"\"Deny access to a snapshot.\"\"\""},{"line_number":1237,"context_line":"    snapshot \u003d _find_share_snapshot(cs, args.snapshot)"}],"source_content_type":"text/x-python","patch_set":23,"id":"5a3905b3_dbd27a5b","line":1234,"range":{"start_line":1234,"start_character":30,"end_line":1234,"end_character":34},"updated":"2017-01-24 11:54:03.000000000","message":"rule(s)","commit_id":"576cd94281ea0bd221085f3f7cb7da3fb24571ee"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"f2c80e542b09ae783faf23bbf59b3a93455221f0","unresolved":false,"context_lines":[{"line_number":1231,"context_line":"    \u0027id\u0027,"},{"line_number":1232,"context_line":"    metavar\u003d\u0027\u003cid\u003e\u0027,"},{"line_number":1233,"context_line":"    nargs\u003d\u0027+\u0027,"},{"line_number":1234,"context_line":"    help\u003d\u0027ID(s) of the access rule to be deleted.\u0027)"},{"line_number":1235,"context_line":"def do_snapshot_access_deny(cs, args):"},{"line_number":1236,"context_line":"    \"\"\"Deny access to a snapshot.\"\"\""},{"line_number":1237,"context_line":"    snapshot \u003d _find_share_snapshot(cs, args.snapshot)"}],"source_content_type":"text/x-python","patch_set":23,"id":"5a3905b3_76defddd","line":1234,"range":{"start_line":1234,"start_character":30,"end_line":1234,"end_character":34},"in_reply_to":"5a3905b3_dbd27a5b","updated":"2017-01-24 13:20:29.000000000","message":"Done","commit_id":"576cd94281ea0bd221085f3f7cb7da3fb24571ee"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b6c9ddca3d400138724e374d4eb31434145e004c","unresolved":false,"context_lines":[{"line_number":1241,"context_line":"        except Exception as e:"},{"line_number":1242,"context_line":"            print(\"Failed to remove rule %(access)s: %(reason)s.\""},{"line_number":1243,"context_line":"                  % {\u0027access\u0027: access_id, \u0027reason\u0027: e},"},{"line_number":1244,"context_line":"                  file\u003dsys.stderr)"},{"line_number":1245,"context_line":""},{"line_number":1246,"context_line":""},{"line_number":1247,"context_line":"@api_versions.wraps(\"1.0\", \"2.20\")"}],"source_content_type":"text/x-python","patch_set":23,"id":"5a3905b3_fb3c9694","line":1244,"updated":"2017-01-24 11:54:03.000000000","message":"need to exit with error code.","commit_id":"576cd94281ea0bd221085f3f7cb7da3fb24571ee"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"f2c80e542b09ae783faf23bbf59b3a93455221f0","unresolved":false,"context_lines":[{"line_number":1241,"context_line":"        except Exception as e:"},{"line_number":1242,"context_line":"            print(\"Failed to remove rule %(access)s: %(reason)s.\""},{"line_number":1243,"context_line":"                  % {\u0027access\u0027: access_id, \u0027reason\u0027: e},"},{"line_number":1244,"context_line":"                  file\u003dsys.stderr)"},{"line_number":1245,"context_line":""},{"line_number":1246,"context_line":""},{"line_number":1247,"context_line":"@api_versions.wraps(\"1.0\", \"2.20\")"}],"source_content_type":"text/x-python","patch_set":23,"id":"5a3905b3_76b35d98","line":1244,"in_reply_to":"5a3905b3_fb3c9694","updated":"2017-01-24 13:20:29.000000000","message":"Done","commit_id":"576cd94281ea0bd221085f3f7cb7da3fb24571ee"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b6c9ddca3d400138724e374d4eb31434145e004c","unresolved":false,"context_lines":[{"line_number":1311,"context_line":"         \u0027e.g. --columns \"access_type,access_to\"\u0027)"},{"line_number":1312,"context_line":"def do_snapshot_access_list(cs, args):"},{"line_number":1313,"context_line":"    \"\"\"Show access list for a snapshot.\"\"\""},{"line_number":1314,"context_line":"    list_of_keys \u003d [\u0027id\u0027, \u0027access_type\u0027, \u0027access_to\u0027, \u0027state\u0027]"},{"line_number":1315,"context_line":""},{"line_number":1316,"context_line":"    if args.columns is not None:"},{"line_number":1317,"context_line":"        list_of_keys \u003d _split_columns(columns\u003dargs.columns)"},{"line_number":1318,"context_line":""},{"line_number":1319,"context_line":"    snapshot \u003d _find_share_snapshot(cs, args.snapshot)"},{"line_number":1320,"context_line":"    access_list \u003d snapshot.access_list()"}],"source_content_type":"text/x-python","patch_set":23,"id":"5a3905b3_3b5a9ef2","line":1317,"range":{"start_line":1314,"start_character":4,"end_line":1317,"end_character":59},"updated":"2017-01-24 11:54:03.000000000","message":"if args.columns is not None:\n    list_of_keys \u003d _split_columns(columns\u003dargs.columns)\nelse:\n    list_of_keys \u003d [\u0027id\u0027, \u0027access_type\u0027, \u0027access_to\u0027, \u0027state\u0027]","commit_id":"576cd94281ea0bd221085f3f7cb7da3fb24571ee"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"f2c80e542b09ae783faf23bbf59b3a93455221f0","unresolved":false,"context_lines":[{"line_number":1311,"context_line":"         \u0027e.g. --columns \"access_type,access_to\"\u0027)"},{"line_number":1312,"context_line":"def do_snapshot_access_list(cs, args):"},{"line_number":1313,"context_line":"    \"\"\"Show access list for a snapshot.\"\"\""},{"line_number":1314,"context_line":"    list_of_keys \u003d [\u0027id\u0027, \u0027access_type\u0027, \u0027access_to\u0027, \u0027state\u0027]"},{"line_number":1315,"context_line":""},{"line_number":1316,"context_line":"    if args.columns is not None:"},{"line_number":1317,"context_line":"        list_of_keys \u003d _split_columns(columns\u003dargs.columns)"},{"line_number":1318,"context_line":""},{"line_number":1319,"context_line":"    snapshot \u003d _find_share_snapshot(cs, args.snapshot)"},{"line_number":1320,"context_line":"    access_list \u003d snapshot.access_list()"}],"source_content_type":"text/x-python","patch_set":23,"id":"5a3905b3_d64891b5","line":1317,"range":{"start_line":1314,"start_character":4,"end_line":1317,"end_character":59},"in_reply_to":"5a3905b3_3b5a9ef2","updated":"2017-01-24 13:20:29.000000000","message":"Done","commit_id":"576cd94281ea0bd221085f3f7cb7da3fb24571ee"}]}
