)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"15f7c5ea8c893dddfe8284a779ef676fae73d3ad","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add columns support for share-replica-list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"share-replica-list doesn\u0027t support \"--columns\" like \"list\" does."},{"line_number":10,"context_line":"Add parameter \"--column\" and add a unit test for that."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5d266572cb6efb1b2771e6b61e57a4aebc12ad89"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad45d7e_c697898e","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":64},"updated":"2016-08-10 07:22:10.000000000","message":"The share-replica-list command does not allow specifying the required columns to format the output of the command.","commit_id":"1dca8a115ced483f6b5c9e5bd075a8da2edff67d"},{"author":{"_account_id":22310,"name":"Faiz Abidi","email":"fabidi89@vt.edu","username":"faiz89"},"change_message_id":"896002d3e48019eb0e273899043ef0c2c463ab39","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add columns support for share-replica-list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"share-replica-list doesn\u0027t support \"--columns\" like \"list\" does."},{"line_number":10,"context_line":"Add parameter \"--column\" and add a unit test for that."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5d266572cb6efb1b2771e6b61e57a4aebc12ad89"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad45d7e_f033f2f3","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":64},"in_reply_to":"9ad45d7e_c697898e","updated":"2016-08-11 21:02:30.000000000","message":"Done","commit_id":"1dca8a115ced483f6b5c9e5bd075a8da2edff67d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"15f7c5ea8c893dddfe8284a779ef676fae73d3ad","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add columns support for share-replica-list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"share-replica-list doesn\u0027t support \"--columns\" like \"list\" does."},{"line_number":10,"context_line":"Add parameter \"--column\" and add a unit test for that."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5d266572cb6efb1b2771e6b61e57a4aebc12ad89"},{"line_number":13,"context_line":"Closes-bug: #1608664"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad45d7e_5206b4ce","line":10,"range":{"start_line":10,"start_character":15,"end_line":10,"end_character":24},"updated":"2016-08-10 07:22:10.000000000","message":"s / \"--column\"  / \"--columns\"","commit_id":"1dca8a115ced483f6b5c9e5bd075a8da2edff67d"},{"author":{"_account_id":22310,"name":"Faiz Abidi","email":"fabidi89@vt.edu","username":"faiz89"},"change_message_id":"896002d3e48019eb0e273899043ef0c2c463ab39","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add columns support for share-replica-list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"share-replica-list doesn\u0027t support \"--columns\" like \"list\" does."},{"line_number":10,"context_line":"Add parameter \"--column\" and add a unit test for that."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5d266572cb6efb1b2771e6b61e57a4aebc12ad89"},{"line_number":13,"context_line":"Closes-bug: #1608664"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad45d7e_10532618","line":10,"range":{"start_line":10,"start_character":15,"end_line":10,"end_character":24},"in_reply_to":"9ad45d7e_5206b4ce","updated":"2016-08-11 21:02:30.000000000","message":"Done","commit_id":"1dca8a115ced483f6b5c9e5bd075a8da2edff67d"}],"manilaclient/tests/unit/v2/test_shell.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"253fb8ae4e6bfc44f62162254f4b8adfbaeefa7f","unresolved":false,"context_lines":[{"line_number":1767,"context_line":""},{"line_number":1768,"context_line":"    @mock.patch.object(cliutils, \u0027print_list\u0027, mock.Mock())"},{"line_number":1769,"context_line":"    def test_share_replica_list_select_column(self):"},{"line_number":1770,"context_line":"        self.run_command(\u0027share-replica-list --columns id,status\u0027)"},{"line_number":1771,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/share-replicas/detail\u0027)"},{"line_number":1772,"context_line":"        cliutils.print_list.assert_called_once_with("},{"line_number":1773,"context_line":"            mock.ANY, [\u0027Id\u0027, \u0027Status\u0027])"},{"line_number":1774,"context_line":""},{"line_number":1775,"context_line":"    @ddt.data("},{"line_number":1776,"context_line":"        \u0027fake-share-id --az fake-az\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_1cb3330b","line":1773,"range":{"start_line":1770,"start_character":8,"end_line":1773,"end_character":39},"updated":"2016-08-12 02:45:17.000000000","message":"the convention for unit tests is:\n\n    def test_my_fancy_method(self):\n      some_mocks\n      \n      method_call()\n\n      asserts\n\n\nSo, please add a blank line between your method call and your asserts..","commit_id":"be1e41f2f54e88840fac6e1fbed892cca058e8ef"},{"author":{"_account_id":22310,"name":"Faiz Abidi","email":"fabidi89@vt.edu","username":"faiz89"},"change_message_id":"91fae11d3b145b514eca2d2afe0b9021f3bd27a8","unresolved":false,"context_lines":[{"line_number":1767,"context_line":""},{"line_number":1768,"context_line":"    @mock.patch.object(cliutils, \u0027print_list\u0027, mock.Mock())"},{"line_number":1769,"context_line":"    def test_share_replica_list_select_column(self):"},{"line_number":1770,"context_line":"        self.run_command(\u0027share-replica-list --columns id,status\u0027)"},{"line_number":1771,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/share-replicas/detail\u0027)"},{"line_number":1772,"context_line":"        cliutils.print_list.assert_called_once_with("},{"line_number":1773,"context_line":"            mock.ANY, [\u0027Id\u0027, \u0027Status\u0027])"},{"line_number":1774,"context_line":""},{"line_number":1775,"context_line":"    @ddt.data("},{"line_number":1776,"context_line":"        \u0027fake-share-id --az fake-az\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_ce92614b","line":1773,"range":{"start_line":1770,"start_character":8,"end_line":1773,"end_character":39},"in_reply_to":"9ad45d7e_1cb3330b","updated":"2016-08-12 15:11:13.000000000","message":"Confused between the convention code and your comment. Did you mean line after some_mocks and not between method_call() and asserts?","commit_id":"be1e41f2f54e88840fac6e1fbed892cca058e8ef"},{"author":{"_account_id":22310,"name":"Faiz Abidi","email":"fabidi89@vt.edu","username":"faiz89"},"change_message_id":"37848b178f62db1673e728470ab3dd8cd3ee70f0","unresolved":false,"context_lines":[{"line_number":1767,"context_line":""},{"line_number":1768,"context_line":"    @mock.patch.object(cliutils, \u0027print_list\u0027, mock.Mock())"},{"line_number":1769,"context_line":"    def test_share_replica_list_select_column(self):"},{"line_number":1770,"context_line":"        self.run_command(\u0027share-replica-list --columns id,status\u0027)"},{"line_number":1771,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/share-replicas/detail\u0027)"},{"line_number":1772,"context_line":"        cliutils.print_list.assert_called_once_with("},{"line_number":1773,"context_line":"            mock.ANY, [\u0027Id\u0027, \u0027Status\u0027])"},{"line_number":1774,"context_line":""},{"line_number":1775,"context_line":"    @ddt.data("},{"line_number":1776,"context_line":"        \u0027fake-share-id --az fake-az\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_db54dccb","line":1773,"range":{"start_line":1770,"start_character":8,"end_line":1773,"end_character":39},"in_reply_to":"9ad45d7e_ce92614b","updated":"2016-08-12 15:46:47.000000000","message":"Done","commit_id":"be1e41f2f54e88840fac6e1fbed892cca058e8ef"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d60d49ec5792d8d47bd4908a670cf85fed207149","unresolved":false,"context_lines":[{"line_number":1767,"context_line":""},{"line_number":1768,"context_line":"    @mock.patch.object(cliutils, \u0027print_list\u0027, mock.Mock())"},{"line_number":1769,"context_line":"    def test_share_replica_list_select_column(self):"},{"line_number":1770,"context_line":"        self.run_command(\u0027share-replica-list --columns id,status\u0027)"},{"line_number":1771,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/share-replicas/detail\u0027)"},{"line_number":1772,"context_line":"        cliutils.print_list.assert_called_once_with("},{"line_number":1773,"context_line":"            mock.ANY, [\u0027Id\u0027, \u0027Status\u0027])"},{"line_number":1774,"context_line":""},{"line_number":1775,"context_line":"    @ddt.data("},{"line_number":1776,"context_line":"        \u0027fake-share-id --az fake-az\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_82c67d47","line":1773,"range":{"start_line":1770,"start_character":8,"end_line":1773,"end_character":39},"in_reply_to":"9ad45d7e_ce92614b","updated":"2016-08-12 15:12:19.000000000","message":"sigh, gerrit messes up the formatting. \n\n   def test_my_fancy_method(self):\n      some_mocks\n      \n      method_call()\n   \n      asserts","commit_id":"be1e41f2f54e88840fac6e1fbed892cca058e8ef"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"253fb8ae4e6bfc44f62162254f4b8adfbaeefa7f","unresolved":false,"context_lines":[{"line_number":3280,"context_line":"        list_of_keys \u003d _split_columns(columns\u003dargs.columns)"},{"line_number":3281,"context_line":"    else:"},{"line_number":3282,"context_line":"        list_of_keys \u003d ["},{"line_number":3283,"context_line":"            \u0027ID\u0027, \u0027Status\u0027, \u0027Replica State\u0027, \u0027Share ID\u0027,"},{"line_number":3284,"context_line":"            \u0027Host\u0027, \u0027Availability Zone\u0027, \u0027Updated At\u0027"},{"line_number":3285,"context_line":"        ]"},{"line_number":3286,"context_line":""},{"line_number":3287,"context_line":"    if share:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_5ceacbdb","line":3284,"range":{"start_line":3283,"start_character":12,"end_line":3284,"end_character":53},"updated":"2016-08-12 02:45:17.000000000","message":"See the formatting guideline here:\n\nhttp://docs.openstack.org/developer/hacking/#dictionaries-lists","commit_id":"be1e41f2f54e88840fac6e1fbed892cca058e8ef"},{"author":{"_account_id":22310,"name":"Faiz Abidi","email":"fabidi89@vt.edu","username":"faiz89"},"change_message_id":"91fae11d3b145b514eca2d2afe0b9021f3bd27a8","unresolved":false,"context_lines":[{"line_number":3280,"context_line":"        list_of_keys \u003d _split_columns(columns\u003dargs.columns)"},{"line_number":3281,"context_line":"    else:"},{"line_number":3282,"context_line":"        list_of_keys \u003d ["},{"line_number":3283,"context_line":"            \u0027ID\u0027, \u0027Status\u0027, \u0027Replica State\u0027, \u0027Share ID\u0027,"},{"line_number":3284,"context_line":"            \u0027Host\u0027, \u0027Availability Zone\u0027, \u0027Updated At\u0027"},{"line_number":3285,"context_line":"        ]"},{"line_number":3286,"context_line":""},{"line_number":3287,"context_line":"    if share:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_42a925df","line":3284,"range":{"start_line":3283,"start_character":12,"end_line":3284,"end_character":53},"in_reply_to":"9ad45d7e_5ceacbdb","updated":"2016-08-12 15:11:13.000000000","message":"Done","commit_id":"be1e41f2f54e88840fac6e1fbed892cca058e8ef"}],"releasenotes/notes/bug-1608664-add-support-columns-share-replica-list-885bd8c8b4bfa8f1.yaml":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"15f7c5ea8c893dddfe8284a779ef676fae73d3ad","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Added \"--columns\" support for share-replica-list"},{"line_number":4,"context_line":"    in manila."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9ad45d7e_527a34f2","line":3,"range":{"start_line":3,"start_character":34,"end_line":3,"end_character":52},"updated":"2016-08-10 07:22:10.000000000","message":"share-replica-list command","commit_id":"1dca8a115ced483f6b5c9e5bd075a8da2edff67d"},{"author":{"_account_id":22310,"name":"Faiz Abidi","email":"fabidi89@vt.edu","username":"faiz89"},"change_message_id":"896002d3e48019eb0e273899043ef0c2c463ab39","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Added \"--columns\" support for share-replica-list"},{"line_number":4,"context_line":"    in manila."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9ad45d7e_3002aa0a","line":3,"range":{"start_line":3,"start_character":34,"end_line":3,"end_character":52},"in_reply_to":"9ad45d7e_527a34f2","updated":"2016-08-11 21:02:30.000000000","message":"Done","commit_id":"1dca8a115ced483f6b5c9e5bd075a8da2edff67d"}]}
