)]}'
{"manilaclient/tests/functional/base.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8128c380151b24a1ba7c4f4bc23165eed5cb0701","unresolved":false,"context_lines":[{"line_number":173,"context_line":"    def create_share_type(cls, name\u003dNone, driver_handles_share_servers\u003dTrue,"},{"line_number":174,"context_line":"                          snapshot_support\u003dNone, is_public\u003dTrue, client\u003dNone,"},{"line_number":175,"context_line":"                          cleanup_in_class\u003dTrue, microversion\u003dNone,"},{"line_number":176,"context_line":"                          extra_specs\u003dNone, create_share_from_snapshot\u003dNone):"},{"line_number":177,"context_line":"        if client is None:"},{"line_number":178,"context_line":"            client \u003d cls.get_admin_client()"},{"line_number":179,"context_line":"        share_type \u003d client.create_share_type("}],"source_content_type":"text/x-python","patch_set":8,"id":"3a71b18c_4c63911a","line":176,"range":{"start_line":176,"start_character":44,"end_line":176,"end_character":75},"updated":"2016-12-09 16:07:11.000000000","message":"Better to place it after existing \"snapshot_support\" arg.","commit_id":"652612c3195c22d76b3857199dac74c350d9ae12"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"824f07a3de5afae7f47bb5a67792a731e0d69c37","unresolved":false,"context_lines":[{"line_number":173,"context_line":"    def create_share_type(cls, name\u003dNone, driver_handles_share_servers\u003dTrue,"},{"line_number":174,"context_line":"                          snapshot_support\u003dNone, is_public\u003dTrue, client\u003dNone,"},{"line_number":175,"context_line":"                          cleanup_in_class\u003dTrue, microversion\u003dNone,"},{"line_number":176,"context_line":"                          extra_specs\u003dNone, create_share_from_snapshot\u003dNone):"},{"line_number":177,"context_line":"        if client is None:"},{"line_number":178,"context_line":"            client \u003d cls.get_admin_client()"},{"line_number":179,"context_line":"        share_type \u003d client.create_share_type("}],"source_content_type":"text/x-python","patch_set":8,"id":"fa48f94a_9530a609","line":176,"range":{"start_line":176,"start_character":44,"end_line":176,"end_character":75},"in_reply_to":"3a71b18c_4c63911a","updated":"2016-12-21 20:09:11.000000000","message":"Done","commit_id":"652612c3195c22d76b3857199dac74c350d9ae12"}],"manilaclient/tests/functional/client.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8128c380151b24a1ba7c4f4bc23165eed5cb0701","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    def create_share_type(self, name\u003dNone, driver_handles_share_servers\u003dTrue,"},{"line_number":166,"context_line":"                          snapshot_support\u003dNone, is_public\u003dTrue,"},{"line_number":167,"context_line":"                          microversion\u003dNone, extra_specs\u003dNone,"},{"line_number":168,"context_line":"                          create_share_from_snapshot\u003dNone):"},{"line_number":169,"context_line":"        \"\"\"Creates share type."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        :param name: text -- name of share type to use, if not set then"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a71b18c_2c54951f","line":168,"range":{"start_line":168,"start_character":26,"end_line":168,"end_character":57},"updated":"2016-12-09 16:07:11.000000000","message":"Same as in https://review.openstack.org/#/c/356683/8/manilaclient/tests/functional/base.py","commit_id":"652612c3195c22d76b3857199dac74c350d9ae12"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"824f07a3de5afae7f47bb5a67792a731e0d69c37","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    def create_share_type(self, name\u003dNone, driver_handles_share_servers\u003dTrue,"},{"line_number":166,"context_line":"                          snapshot_support\u003dNone, is_public\u003dTrue,"},{"line_number":167,"context_line":"                          microversion\u003dNone, extra_specs\u003dNone,"},{"line_number":168,"context_line":"                          create_share_from_snapshot\u003dNone):"},{"line_number":169,"context_line":"        \"\"\"Creates share type."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        :param name: text -- name of share type to use, if not set then"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa48f94a_98dc5d1a","line":168,"range":{"start_line":168,"start_character":26,"end_line":168,"end_character":57},"in_reply_to":"3a71b18c_2c54951f","updated":"2016-12-21 20:09:11.000000000","message":"Done","commit_id":"652612c3195c22d76b3857199dac74c350d9ae12"}],"manilaclient/tests/functional/test_share_types.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"bad161cf8339429383a2cfedf020c55c91ba87c2","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from manilaclient.tests.functional import base"},{"line_number":20,"context_line":"from manilaclient.tests.unit.v2 import test_types as unit_test_types"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a629dbe_c8b6ed89","line":20,"range":{"start_line":20,"start_character":18,"end_line":20,"end_character":28},"updated":"2016-11-08 07:58:30.000000000","message":"is it appropriate that functional module references from unit module? Maybe it\u0027s better that functional tests are independent.","commit_id":"ad4bca8fccc37d45d4a4cd75fa9050e5ec6fd659"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"a6d0733d7e19e82a404c801e9e537a8e42525b8d","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from manilaclient.tests.functional import base"},{"line_number":20,"context_line":"from manilaclient.tests.unit.v2 import test_types as unit_test_types"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a629dbe_70caff6f","line":20,"range":{"start_line":20,"start_character":18,"end_line":20,"end_character":28},"in_reply_to":"9a629dbe_c8b6ed89","updated":"2016-11-08 22:46:00.000000000","message":"The alternative is to copy/paste a large piece of code for generating test inputs.  If they must diverge, then OK, but until then why not have a single source?","commit_id":"ad4bca8fccc37d45d4a4cd75fa9050e5ec6fd659"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8128c380151b24a1ba7c4f4bc23165eed5cb0701","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    @ddt.data(*unit_test_types.get_valid_create_data())"},{"line_number":182,"context_line":"    @ddt.unpack"},{"line_number":183,"context_line":"    def test_create_delete_share_type_2_23("},{"line_number":184,"context_line":"            self, is_public, dhss, spec_snapshot_support,"},{"line_number":185,"context_line":"            spec_create_share_from_snapshot, extra_specs):"},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a71b18c_074c126f","line":183,"range":{"start_line":183,"start_character":8,"end_line":183,"end_character":42},"updated":"2016-12-09 16:07:11.000000000","message":"This test should be combined with above one. Too big duplication.","commit_id":"652612c3195c22d76b3857199dac74c350d9ae12"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"824f07a3de5afae7f47bb5a67792a731e0d69c37","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    @ddt.data(*unit_test_types.get_valid_create_data())"},{"line_number":182,"context_line":"    @ddt.unpack"},{"line_number":183,"context_line":"    def test_create_delete_share_type_2_23("},{"line_number":184,"context_line":"            self, is_public, dhss, spec_snapshot_support,"},{"line_number":185,"context_line":"            spec_create_share_from_snapshot, extra_specs):"},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"da4df55a_7748a85c","line":183,"range":{"start_line":183,"start_character":8,"end_line":183,"end_character":42},"in_reply_to":"3a71b18c_074c126f","updated":"2016-12-21 20:09:11.000000000","message":"Done","commit_id":"652612c3195c22d76b3857199dac74c350d9ae12"}],"manilaclient/tests/unit/v2/test_shell.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"f35dca9718275f4bacf3331fa8c2a51bb5947b86","unresolved":false,"context_lines":[{"line_number":785,"context_line":"            \u0027 --extra-specs driver_handles_share_servers\u003d\u0027 + value,"},{"line_number":786,"context_line":"        )"},{"line_number":787,"context_line":""},{"line_number":788,"context_line":"    @ddt.data(*itertools.product("},{"line_number":789,"context_line":"        [\u0027snapshot_support\u0027, \u0027create_share_from_snapshot_support\u0027],"},{"line_number":790,"context_line":"        [\u0027True\u0027, \u0027False\u0027])"},{"line_number":791,"context_line":"    )"},{"line_number":792,"context_line":"    @ddt.unpack"},{"line_number":793,"context_line":"    def test_type_create_duplicate_switch_and_extra_spec(self, key, value):"},{"line_number":794,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba5201f7_ae3429fb","line":791,"range":{"start_line":788,"start_character":0,"end_line":791,"end_character":5},"updated":"2017-01-03 20:22:25.000000000","message":"bookmarked, as it were :D","commit_id":"1525c74b20e80bc9abacaa8a46650dba993f97a0"}],"manilaclient/v2/share_types.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"5229e75ec9532adb46d83309d66df6d2a0bd4cc0","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            \"os-share-type-access:is_public\","},{"line_number":174,"context_line":"            spec_create_share_from_snapshot_support)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    @api_versions.wraps(\"2.7\")  # noqa"},{"line_number":177,"context_line":"    def create(self, name, spec_driver_handles_share_servers,"},{"line_number":178,"context_line":"               spec_snapshot_support\u003dTrue, is_public\u003dTrue,"},{"line_number":179,"context_line":"               spec_create_share_from_snapshot_support\u003dTrue):"},{"line_number":180,"context_line":"        return self._do_create("},{"line_number":181,"context_line":"            name,"},{"line_number":182,"context_line":"            spec_driver_handles_share_servers,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_66776702","line":179,"range":{"start_line":176,"start_character":4,"end_line":179,"end_character":61},"updated":"2016-08-18 02:34:32.000000000","message":"Hi Clinton Knight, This method should become versioned. Because \"spec_create_share_from_snapshot_support\" really will be used only in case of 2.21+ microversion. So, for 2.20- we should restrict its usage? Does you will add it later? or I missing something?\n\nhttp://docs.openstack.org/developer/manila/devref/api_microversion_dev.html#when-do-i-need-a-new-microversion\n\nhttps://review.openstack.org/#/c/356682/1/manila/api/views/shares.py","commit_id":"7396ae45d8ae3407ccf0d8a6961ae5abd604db54"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"3940bf1e6d7a840108c5aa68013d34daf137fee2","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            \"os-share-type-access:is_public\","},{"line_number":174,"context_line":"            spec_create_share_from_snapshot_support)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    @api_versions.wraps(\"2.7\")  # noqa"},{"line_number":177,"context_line":"    def create(self, name, spec_driver_handles_share_servers,"},{"line_number":178,"context_line":"               spec_snapshot_support\u003dTrue, is_public\u003dTrue,"},{"line_number":179,"context_line":"               spec_create_share_from_snapshot_support\u003dTrue):"},{"line_number":180,"context_line":"        return self._do_create("},{"line_number":181,"context_line":"            name,"},{"line_number":182,"context_line":"            spec_driver_handles_share_servers,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_13e31607","line":179,"range":{"start_line":176,"start_character":4,"end_line":179,"end_character":61},"in_reply_to":"3ac371cc_66776702","updated":"2016-08-18 18:23:38.000000000","message":"I agree, thanks.  Fixed.","commit_id":"7396ae45d8ae3407ccf0d8a6961ae5abd604db54"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"d352df48d4afb47af3e63d6135b421a3d486c6b7","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        }"},{"line_number":159,"context_line":"        if spec_create_share_from_snapshot_support is not None:"},{"line_number":160,"context_line":"            body[\u0027share_type\u0027][\u0027extra_specs\u0027]["},{"line_number":161,"context_line":"                \u0027create_share_from_snapshot_support\u0027] \u003d \\"},{"line_number":162,"context_line":"                spec_create_share_from_snapshot_support"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        return self._create(\"/types\", body, \"share_type\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_10b49acf","line":161,"range":{"start_line":161,"start_character":56,"end_line":161,"end_character":57},"updated":"2016-08-19 01:21:45.000000000","message":"suggest using () as the line connector","commit_id":"820a068ecd793482781ca05aa3f870743162353f"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"bad161cf8339429383a2cfedf020c55c91ba87c2","unresolved":false,"context_lines":[{"line_number":2930,"context_line":"        \u0027create_share_from_snapshot_support\u0027,"},{"line_number":2931,"context_line":"    ]"},{"line_number":2932,"context_line":"    for arg in potential_duplicate_args:"},{"line_number":2933,"context_line":"        if getattr(args, arg) is not None and arg in kwargs[\u0027extra_specs\u0027]:"},{"line_number":2934,"context_line":"            msg \u003d (\"Argument \u0027%s\u0027 value specified twice.\" % arg)"},{"line_number":2935,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":2936,"context_line":""},{"line_number":2937,"context_line":"    try:"},{"line_number":2938,"context_line":"        if args.snapshot_support:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a629dbe_689de164","line":2935,"range":{"start_line":2933,"start_character":8,"end_line":2935,"end_character":46},"updated":"2016-11-08 07:58:30.000000000","message":"please add UT for this exception.","commit_id":"ad4bca8fccc37d45d4a4cd75fa9050e5ec6fd659"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"a6d0733d7e19e82a404c801e9e537a8e42525b8d","unresolved":false,"context_lines":[{"line_number":2930,"context_line":"        \u0027create_share_from_snapshot_support\u0027,"},{"line_number":2931,"context_line":"    ]"},{"line_number":2932,"context_line":"    for arg in potential_duplicate_args:"},{"line_number":2933,"context_line":"        if getattr(args, arg) is not None and arg in kwargs[\u0027extra_specs\u0027]:"},{"line_number":2934,"context_line":"            msg \u003d (\"Argument \u0027%s\u0027 value specified twice.\" % arg)"},{"line_number":2935,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":2936,"context_line":""},{"line_number":2937,"context_line":"    try:"},{"line_number":2938,"context_line":"        if args.snapshot_support:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a629dbe_d04aeb82","line":2935,"range":{"start_line":2933,"start_character":8,"end_line":2935,"end_character":46},"in_reply_to":"9a629dbe_689de164","updated":"2016-11-08 22:46:00.000000000","message":"Already present for snapshot_support.  I refactored the test to include create_share_from_snapshot_support.","commit_id":"ad4bca8fccc37d45d4a4cd75fa9050e5ec6fd659"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"bad161cf8339429383a2cfedf020c55c91ba87c2","unresolved":false,"context_lines":[{"line_number":2958,"context_line":"                    kwargs[\u0027extra_specs\u0027]"},{"line_number":2959,"context_line":"                    [\u0027create_share_from_snapshot_support\u0027], strict\u003dTrue))"},{"line_number":2960,"context_line":"    except ValueError as e:"},{"line_number":2961,"context_line":"        msg \u003d (\"Argument \u0027create_share_from_snapshot_support\u0027 is of boolean \""},{"line_number":2962,"context_line":"               \"type and has invalid value: %s\" % six.text_type(e))"},{"line_number":2963,"context_line":"        raise exceptions.CommandError(msg)"},{"line_number":2964,"context_line":""},{"line_number":2965,"context_line":"    stype \u003d cs.share_types.create(**kwargs)"},{"line_number":2966,"context_line":"    _print_share_type(stype)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a629dbe_a88d3933","line":2963,"range":{"start_line":2961,"start_character":8,"end_line":2963,"end_character":42},"updated":"2016-11-08 07:58:30.000000000","message":"ditto","commit_id":"ad4bca8fccc37d45d4a4cd75fa9050e5ec6fd659"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"a6d0733d7e19e82a404c801e9e537a8e42525b8d","unresolved":false,"context_lines":[{"line_number":2958,"context_line":"                    kwargs[\u0027extra_specs\u0027]"},{"line_number":2959,"context_line":"                    [\u0027create_share_from_snapshot_support\u0027], strict\u003dTrue))"},{"line_number":2960,"context_line":"    except ValueError as e:"},{"line_number":2961,"context_line":"        msg \u003d (\"Argument \u0027create_share_from_snapshot_support\u0027 is of boolean \""},{"line_number":2962,"context_line":"               \"type and has invalid value: %s\" % six.text_type(e))"},{"line_number":2963,"context_line":"        raise exceptions.CommandError(msg)"},{"line_number":2964,"context_line":""},{"line_number":2965,"context_line":"    stype \u003d cs.share_types.create(**kwargs)"},{"line_number":2966,"context_line":"    _print_share_type(stype)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a629dbe_1342ad10","line":2963,"range":{"start_line":2961,"start_character":8,"end_line":2963,"end_character":42},"in_reply_to":"9a629dbe_a88d3933","updated":"2016-11-08 22:46:00.000000000","message":"Done","commit_id":"ad4bca8fccc37d45d4a4cd75fa9050e5ec6fd659"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8128c380151b24a1ba7c4f4bc23165eed5cb0701","unresolved":false,"context_lines":[{"line_number":2934,"context_line":"            msg \u003d (\"Argument \u0027%s\u0027 value specified twice.\" % arg)"},{"line_number":2935,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":2936,"context_line":""},{"line_number":2937,"context_line":"    try:"},{"line_number":2938,"context_line":"        if args.snapshot_support:"},{"line_number":2939,"context_line":"            kwargs[\u0027spec_snapshot_support\u0027] \u003d strutils.bool_from_string("},{"line_number":2940,"context_line":"                args.snapshot_support, strict\u003dTrue)"},{"line_number":2941,"context_line":"        elif \u0027snapshot_support\u0027 in kwargs[\u0027extra_specs\u0027]:"},{"line_number":2942,"context_line":"            kwargs[\u0027extra_specs\u0027][\u0027snapshot_support\u0027] \u003d ("},{"line_number":2943,"context_line":"                strutils.bool_from_string("},{"line_number":2944,"context_line":"                    kwargs[\u0027extra_specs\u0027][\u0027snapshot_support\u0027], strict\u003dTrue))"},{"line_number":2945,"context_line":"    except ValueError as e:"},{"line_number":2946,"context_line":"        msg \u003d (\"Argument \u0027snapshot_support\u0027 is of boolean type and has \""},{"line_number":2947,"context_line":"               \"invalid value: %s\" % six.text_type(e))"},{"line_number":2948,"context_line":"        raise exceptions.CommandError(msg)"},{"line_number":2949,"context_line":""},{"line_number":2950,"context_line":"    try:"},{"line_number":2951,"context_line":"        if args.create_share_from_snapshot_support:"},{"line_number":2952,"context_line":"            kwargs[\u0027extra_specs\u0027][\u0027create_share_from_snapshot_support\u0027] \u003d ("},{"line_number":2953,"context_line":"                strutils.bool_from_string("},{"line_number":2954,"context_line":"                    args.create_share_from_snapshot_support, strict\u003dTrue))"},{"line_number":2955,"context_line":"        elif \u0027create_share_from_snapshot_support\u0027 in kwargs[\u0027extra_specs\u0027]:"},{"line_number":2956,"context_line":"            kwargs[\u0027extra_specs\u0027][\u0027create_share_from_snapshot_support\u0027] \u003d ("},{"line_number":2957,"context_line":"                strutils.bool_from_string("},{"line_number":2958,"context_line":"                    kwargs[\u0027extra_specs\u0027]"},{"line_number":2959,"context_line":"                    [\u0027create_share_from_snapshot_support\u0027], strict\u003dTrue))"},{"line_number":2960,"context_line":"    except ValueError as e:"},{"line_number":2961,"context_line":"        msg \u003d (\"Argument \u0027create_share_from_snapshot_support\u0027 is of boolean \""},{"line_number":2962,"context_line":"               \"type and has invalid value: %s\" % six.text_type(e))"},{"line_number":2963,"context_line":"        raise exceptions.CommandError(msg)"},{"line_number":2964,"context_line":""},{"line_number":2965,"context_line":"    stype \u003d cs.share_types.create(**kwargs)"},{"line_number":2966,"context_line":"    _print_share_type(stype)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a71b18c_8cb049df","line":2963,"range":{"start_line":2937,"start_character":4,"end_line":2963,"end_character":42},"updated":"2016-12-09 16:07:11.000000000","message":"keys \u003d (\u0027snapshot_support\u0027, \u0027create_share_From_snapshot_support\u0027)\nfor key in keys:\n    value \u003d getattr(args, key)\n    try:\n        if value:\n            kwargs[\u0027extra_specs\u0027][key] \u003d (\n                strutils.bool_from_string(value, strict\u003dTrue))\n        elif key in kwargs[\u0027extra_specs\u0027]:\n            kwargs[\u0027extra_specs\u0027][key] \u003d (\n                strutils.bool_from_string(\n                    kwargs[\u0027extra_specs\u0027][key], strict\u003dTrue))\n    except ValueError as e:\n        msg \u003d (\"Argument \u0027%s\u0027 is of boolean \"\n               \"type and has invalid value: %s\" % (key, six.text_type(e)))\n        raise exceptions.CommandError(msg)","commit_id":"652612c3195c22d76b3857199dac74c350d9ae12"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"824f07a3de5afae7f47bb5a67792a731e0d69c37","unresolved":false,"context_lines":[{"line_number":2934,"context_line":"            msg \u003d (\"Argument \u0027%s\u0027 value specified twice.\" % arg)"},{"line_number":2935,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":2936,"context_line":""},{"line_number":2937,"context_line":"    try:"},{"line_number":2938,"context_line":"        if args.snapshot_support:"},{"line_number":2939,"context_line":"            kwargs[\u0027spec_snapshot_support\u0027] \u003d strutils.bool_from_string("},{"line_number":2940,"context_line":"                args.snapshot_support, strict\u003dTrue)"},{"line_number":2941,"context_line":"        elif \u0027snapshot_support\u0027 in kwargs[\u0027extra_specs\u0027]:"},{"line_number":2942,"context_line":"            kwargs[\u0027extra_specs\u0027][\u0027snapshot_support\u0027] \u003d ("},{"line_number":2943,"context_line":"                strutils.bool_from_string("},{"line_number":2944,"context_line":"                    kwargs[\u0027extra_specs\u0027][\u0027snapshot_support\u0027], strict\u003dTrue))"},{"line_number":2945,"context_line":"    except ValueError as e:"},{"line_number":2946,"context_line":"        msg \u003d (\"Argument \u0027snapshot_support\u0027 is of boolean type and has \""},{"line_number":2947,"context_line":"               \"invalid value: %s\" % six.text_type(e))"},{"line_number":2948,"context_line":"        raise exceptions.CommandError(msg)"},{"line_number":2949,"context_line":""},{"line_number":2950,"context_line":"    try:"},{"line_number":2951,"context_line":"        if args.create_share_from_snapshot_support:"},{"line_number":2952,"context_line":"            kwargs[\u0027extra_specs\u0027][\u0027create_share_from_snapshot_support\u0027] \u003d ("},{"line_number":2953,"context_line":"                strutils.bool_from_string("},{"line_number":2954,"context_line":"                    args.create_share_from_snapshot_support, strict\u003dTrue))"},{"line_number":2955,"context_line":"        elif \u0027create_share_from_snapshot_support\u0027 in kwargs[\u0027extra_specs\u0027]:"},{"line_number":2956,"context_line":"            kwargs[\u0027extra_specs\u0027][\u0027create_share_from_snapshot_support\u0027] \u003d ("},{"line_number":2957,"context_line":"                strutils.bool_from_string("},{"line_number":2958,"context_line":"                    kwargs[\u0027extra_specs\u0027]"},{"line_number":2959,"context_line":"                    [\u0027create_share_from_snapshot_support\u0027], strict\u003dTrue))"},{"line_number":2960,"context_line":"    except ValueError as e:"},{"line_number":2961,"context_line":"        msg \u003d (\"Argument \u0027create_share_from_snapshot_support\u0027 is of boolean \""},{"line_number":2962,"context_line":"               \"type and has invalid value: %s\" % six.text_type(e))"},{"line_number":2963,"context_line":"        raise exceptions.CommandError(msg)"},{"line_number":2964,"context_line":""},{"line_number":2965,"context_line":"    stype \u003d cs.share_types.create(**kwargs)"},{"line_number":2966,"context_line":"    _print_share_type(stype)"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa48f94a_787ed9af","line":2963,"range":{"start_line":2937,"start_character":4,"end_line":2963,"end_character":42},"in_reply_to":"3a71b18c_8cb049df","updated":"2016-12-21 20:09:11.000000000","message":"Done, and combined with previous section as well.","commit_id":"652612c3195c22d76b3857199dac74c350d9ae12"}]}
