)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"3577822df53c63c191f839dad18dfd096bf72a2e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add share_type filter to pool_list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Administrators intend to get the pool\u0027s information filtered by share type"},{"line_number":10,"context_line":"more directly. The blueprint is to add a filter-key \u0027share-type\u0027 to cover"},{"line_number":11,"context_line":"this situation."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implements: blueprint pool-list-by-share-type"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a8bc5a2_09e25a9f","line":10,"range":{"start_line":10,"start_character":53,"end_line":10,"end_character":63},"updated":"2016-09-24 06:57:13.000000000","message":"share_type","commit_id":"6833578c7cee62d6378a3f66701abc56f6b0ab33"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"3577822df53c63c191f839dad18dfd096bf72a2e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Administrators intend to get the pool\u0027s information filtered by share type"},{"line_number":10,"context_line":"more directly. The blueprint is to add a filter-key \u0027share-type\u0027 to cover"},{"line_number":11,"context_line":"this situation."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implements: blueprint pool-list-by-share-type"},{"line_number":14,"context_line":"Change-Id: Ia100eb6b4b83c8e2cc91f6fc86f01caa9bce87d4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a8bc5a2_a9032641","line":12,"updated":"2016-09-24 06:57:13.000000000","message":"you also added a new \u0027detailed\u0027 parameter. please present it here.","commit_id":"6833578c7cee62d6378a3f66701abc56f6b0ab33"}],"manilaclient/tests/functional/test_scheduler_stats.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ab04dc422f0988505cd340b39074d7e76d1875de","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def test_pools_list_with_share_type_filter(self):"},{"line_number":32,"context_line":"        self.clients[\u0027admin\u0027].manila(\u0027pool-list\u0027,"},{"line_number":33,"context_line":"                                     params\u003d\u0027--share_type default\u0027)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def test_pools_list_with_filters(self):"},{"line_number":36,"context_line":"        self.clients[\u0027admin\u0027].manila("}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_e4b9cd2f","line":33,"range":{"start_line":33,"start_character":58,"end_line":33,"end_character":65},"updated":"2016-12-21 01:56:20.000000000","message":"Hmmm, this only works if the default share type is called default.","commit_id":"94e01b1d1fc04a5a079d16d88e7881c224f8a597"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b002fd6fc0d4e95d3912acb990e38de0478f57a7","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        share_type \u003d self.create_share_type("},{"line_number":34,"context_line":"            name\u003ddata_utils.rand_name(\u0027manilaclient_functional_test\u0027),"},{"line_number":35,"context_line":"            snapshot_support\u003dTrue,"},{"line_number":36,"context_line":"            extra_specs\u003d{\u0027replication_type\u0027: \u0027fake_repl_type1\u0027},"},{"line_number":37,"context_line":"        )"},{"line_number":38,"context_line":"        self.clients[\u0027admin\u0027].manila(\u0027pool-list\u0027,"},{"line_number":39,"context_line":"                                     params\u003d\u0027--share_type \u0027 +"}],"source_content_type":"text/x-python","patch_set":10,"id":"da4df55a_ee083694","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":64},"updated":"2016-12-22 01:55:18.000000000","message":"remove","commit_id":"666cccbfa8161ba5730a07e2ac85fc2b627cc7ab"},{"author":{"_account_id":24309,"name":"xinyanzhang","email":"236592348@qq.com","username":"xinyanzhang"},"change_message_id":"dfd928992741db0adc6e0d26ff4e8f398b9b04aa","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        share_type \u003d self.create_share_type("},{"line_number":34,"context_line":"            name\u003ddata_utils.rand_name(\u0027manilaclient_functional_test\u0027),"},{"line_number":35,"context_line":"            snapshot_support\u003dTrue,"},{"line_number":36,"context_line":"            extra_specs\u003d{\u0027replication_type\u0027: \u0027fake_repl_type1\u0027},"},{"line_number":37,"context_line":"        )"},{"line_number":38,"context_line":"        self.clients[\u0027admin\u0027].manila(\u0027pool-list\u0027,"},{"line_number":39,"context_line":"                                     params\u003d\u0027--share_type \u0027 +"}],"source_content_type":"text/x-python","patch_set":10,"id":"da4df55a_e4677723","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":64},"in_reply_to":"da4df55a_ee083694","updated":"2016-12-22 03:39:47.000000000","message":"Done","commit_id":"666cccbfa8161ba5730a07e2ac85fc2b627cc7ab"}],"manilaclient/tests/unit/v2/test_shell.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"485ee30cc3e00bae2ad196292d7a17bdc60963c8","unresolved":false,"context_lines":[{"line_number":1581,"context_line":"        self.run_command(\u0027pool-list\u0027)"},{"line_number":1582,"context_line":"        self.assert_called("},{"line_number":1583,"context_line":"            \u0027GET\u0027,"},{"line_number":1584,"context_line":"            \u0027/scheduler-stats/pools/detail?backend\u003d.%2A\u0026host\u003d.%2A\u0026pool\u003d.%2A\u0027,"},{"line_number":1585,"context_line":"        )"},{"line_number":1586,"context_line":"        cliutils.print_list.assert_called_with("},{"line_number":1587,"context_line":"            mock.ANY,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_0815999a","line":1584,"updated":"2016-09-27 06:25:13.000000000","message":"please add a test for non-detail query.","commit_id":"118a20ac2fc89aceedb27b62266e3424e7b65cf4"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"485ee30cc3e00bae2ad196292d7a17bdc60963c8","unresolved":false,"context_lines":[{"line_number":1606,"context_line":"        self.assert_called("},{"line_number":1607,"context_line":"            \u0027GET\u0027,"},{"line_number":1608,"context_line":"            \u0027/scheduler-stats/pools/detail?backend\u003dbackend1\u0026host\u003dhost1\u0026\u0027"},{"line_number":1609,"context_line":"            \u0027pool\u003dpool1\u0026share_type\u003dtest_type\u0027,"},{"line_number":1610,"context_line":"        )"},{"line_number":1611,"context_line":"        cliutils.print_list.assert_called_with("},{"line_number":1612,"context_line":"            mock.ANY,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_8829a9e8","line":1609,"updated":"2016-09-27 06:25:13.000000000","message":"add a test for non detail query as well.","commit_id":"118a20ac2fc89aceedb27b62266e3424e7b65cf4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bfea9b9c16b70846c3e295efb7eb30e8e8561a8c","unresolved":false,"context_lines":[{"line_number":1627,"context_line":"    def test_pool_list_with_filters(self):"},{"line_number":1628,"context_line":"        self.run_command("},{"line_number":1629,"context_line":"            \u0027pool-list --host host1 --backend backend1 --pool pool1 \u0027"},{"line_number":1630,"context_line":"            \u0027--share-type test_type\u0027)"},{"line_number":1631,"context_line":"        self.assert_called("},{"line_number":1632,"context_line":"            \u0027GET\u0027,"},{"line_number":1633,"context_line":"            \u0027/scheduler-stats/pools?backend\u003dbackend1\u0026host\u003dhost1\u0026\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_a4e7d510","line":1630,"range":{"start_line":1630,"start_character":13,"end_line":1630,"end_character":25},"updated":"2016-12-21 02:02:47.000000000","message":"You need to test for the aliases as well. Please use ddt and provide the other aliases.","commit_id":"94e01b1d1fc04a5a079d16d88e7881c224f8a597"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b002fd6fc0d4e95d3912acb990e38de0478f57a7","unresolved":false,"context_lines":[{"line_number":1631,"context_line":"    )"},{"line_number":1632,"context_line":"    @ddt.unpack"},{"line_number":1633,"context_line":"    @mock.patch.object(cliutils, \u0027print_list\u0027, mock.Mock())"},{"line_number":1634,"context_line":"    def test_pool_list_with_filters(self, param, except_filter):"},{"line_number":1635,"context_line":"        cmd \u003d (\u0027pool-list --host host1 --backend backend1 --pool pool1\u0027 + \u0027 \u0027 +"},{"line_number":1636,"context_line":"               param)"},{"line_number":1637,"context_line":"        self.run_command(cmd)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da4df55a_6ef52682","line":1634,"range":{"start_line":1634,"start_character":47,"end_line":1634,"end_character":62},"updated":"2016-12-22 01:55:18.000000000","message":"not necessary","commit_id":"666cccbfa8161ba5730a07e2ac85fc2b627cc7ab"},{"author":{"_account_id":24309,"name":"xinyanzhang","email":"236592348@qq.com","username":"xinyanzhang"},"change_message_id":"dfd928992741db0adc6e0d26ff4e8f398b9b04aa","unresolved":false,"context_lines":[{"line_number":1631,"context_line":"    )"},{"line_number":1632,"context_line":"    @ddt.unpack"},{"line_number":1633,"context_line":"    @mock.patch.object(cliutils, \u0027print_list\u0027, mock.Mock())"},{"line_number":1634,"context_line":"    def test_pool_list_with_filters(self, param, except_filter):"},{"line_number":1635,"context_line":"        cmd \u003d (\u0027pool-list --host host1 --backend backend1 --pool pool1\u0027 + \u0027 \u0027 +"},{"line_number":1636,"context_line":"               param)"},{"line_number":1637,"context_line":"        self.run_command(cmd)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da4df55a_ffc9c2ad","line":1634,"range":{"start_line":1634,"start_character":47,"end_line":1634,"end_character":62},"in_reply_to":"da4df55a_6ef52682","updated":"2016-12-22 03:39:47.000000000","message":"Done","commit_id":"666cccbfa8161ba5730a07e2ac85fc2b627cc7ab"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b002fd6fc0d4e95d3912acb990e38de0478f57a7","unresolved":false,"context_lines":[{"line_number":1638,"context_line":"        self.assert_called("},{"line_number":1639,"context_line":"            \u0027GET\u0027,"},{"line_number":1640,"context_line":"            \u0027/scheduler-stats/pools?backend\u003dbackend1\u0026host\u003dhost1\u0026\u0027"},{"line_number":1641,"context_line":"            \u0027pool\u003dpool1\u0026\u0027 + except_filter,"},{"line_number":1642,"context_line":"        )"},{"line_number":1643,"context_line":"        cliutils.print_list.assert_called_with("},{"line_number":1644,"context_line":"            mock.ANY,"}],"source_content_type":"text/x-python","patch_set":10,"id":"da4df55a_ce2a92e7","line":1641,"range":{"start_line":1641,"start_character":24,"end_line":1641,"end_character":41},"updated":"2016-12-22 01:55:18.000000000","message":"share_type\u003d%s\u0027 % param.split()[-1]","commit_id":"666cccbfa8161ba5730a07e2ac85fc2b627cc7ab"},{"author":{"_account_id":24309,"name":"xinyanzhang","email":"236592348@qq.com","username":"xinyanzhang"},"change_message_id":"dfd928992741db0adc6e0d26ff4e8f398b9b04aa","unresolved":false,"context_lines":[{"line_number":1638,"context_line":"        self.assert_called("},{"line_number":1639,"context_line":"            \u0027GET\u0027,"},{"line_number":1640,"context_line":"            \u0027/scheduler-stats/pools?backend\u003dbackend1\u0026host\u003dhost1\u0026\u0027"},{"line_number":1641,"context_line":"            \u0027pool\u003dpool1\u0026\u0027 + except_filter,"},{"line_number":1642,"context_line":"        )"},{"line_number":1643,"context_line":"        cliutils.print_list.assert_called_with("},{"line_number":1644,"context_line":"            mock.ANY,"}],"source_content_type":"text/x-python","patch_set":10,"id":"da4df55a_3fc42a91","line":1641,"range":{"start_line":1641,"start_character":24,"end_line":1641,"end_character":41},"in_reply_to":"da4df55a_ce2a92e7","updated":"2016-12-22 03:39:47.000000000","message":"Done","commit_id":"666cccbfa8161ba5730a07e2ac85fc2b627cc7ab"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"3577822df53c63c191f839dad18dfd096bf72a2e","unresolved":false,"context_lines":[{"line_number":2905,"context_line":"         \u0027e.g. --columns \"name,host\"\u0027)"},{"line_number":2906,"context_line":"@cliutils.arg("},{"line_number":2907,"context_line":"    \u0027--detailed\u0027,"},{"line_number":2908,"context_line":"    metavar\u003d\u0027\u003cdetailed\u003e\u0027,"},{"line_number":2909,"context_line":"    default\u003dTrue,"},{"line_number":2910,"context_line":"    help\u003d\u0027Show detailed information about pools.\u0027)"},{"line_number":2911,"context_line":"@cliutils.arg("}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_091dfabc","line":2908,"updated":"2016-09-24 06:57:13.000000000","message":"choices\u003d[\u0027True\u0027, \u0027False\u0027],","commit_id":"6833578c7cee62d6378a3f66701abc56f6b0ab33"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"fe124952058727e00713d807adba5818a7c8b2b6","unresolved":false,"context_lines":[{"line_number":2928,"context_line":"    }"},{"line_number":2929,"context_line":"    list_detailed \u003d True"},{"line_number":2930,"context_line":""},{"line_number":2931,"context_line":"    if args.detailed:"},{"line_number":2932,"context_line":"        try:"},{"line_number":2933,"context_line":"            list_detailed \u003d strutils.bool_from_string("},{"line_number":2934,"context_line":"                args.detailed, strict\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a8bc5a2_2d4ea296","line":2931,"updated":"2016-09-28 07:16:50.000000000","message":"this check is not necessary, cause args.detailed is always one of\n[\u0027True\u0027, \u0027False\u0027, True], it\u0027ll always be true.","commit_id":"e22ead44b54c3f954254db78f047f6a88b7bd475"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"f2bc655cf37639ca9233e294f6909e6b6f14cf7e","unresolved":false,"context_lines":[{"line_number":2930,"context_line":""},{"line_number":2931,"context_line":"    if args.detailed:"},{"line_number":2932,"context_line":"        try:"},{"line_number":2933,"context_line":"            list_detailed \u003d strutils.bool_from_string("},{"line_number":2934,"context_line":"                args.detailed, strict\u003dTrue)"},{"line_number":2935,"context_line":"        except ValueError:"},{"line_number":2936,"context_line":"            msg \u003d (\"Argument --detailed is not valid: %s \""},{"line_number":2937,"context_line":"                   \"bool is expected\" % six.text_type(args.detailed))"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a8bc5a2_adc0f27d","line":2934,"range":{"start_line":2933,"start_character":12,"end_line":2934,"end_character":43},"updated":"2016-09-28 06:52:59.000000000","message":"why add this converting?\nthe detailed parameter is confined in [\u0027True\u0027, \u0027False\u0027],\nif the input value not in this range, error will be raised.\nplease tell me if I missed something.","commit_id":"e22ead44b54c3f954254db78f047f6a88b7bd475"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"0a144f171d92a8e39b5006d60758db2315bfbe5a","unresolved":false,"context_lines":[{"line_number":2930,"context_line":""},{"line_number":2931,"context_line":"    if args.detailed:"},{"line_number":2932,"context_line":"        try:"},{"line_number":2933,"context_line":"            list_detailed \u003d strutils.bool_from_string("},{"line_number":2934,"context_line":"                args.detailed, strict\u003dTrue)"},{"line_number":2935,"context_line":"        except ValueError:"},{"line_number":2936,"context_line":"            msg \u003d (\"Argument --detailed is not valid: %s \""},{"line_number":2937,"context_line":"                   \"bool is expected\" % six.text_type(args.detailed))"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a8bc5a2_6de18afe","line":2934,"range":{"start_line":2933,"start_character":12,"end_line":2934,"end_character":43},"in_reply_to":"5a8bc5a2_adc0f27d","updated":"2016-09-28 06:59:34.000000000","message":"Sorry, I took this wrong. this converting is indeed needed.","commit_id":"e22ead44b54c3f954254db78f047f6a88b7bd475"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"fe124952058727e00713d807adba5818a7c8b2b6","unresolved":false,"context_lines":[{"line_number":2932,"context_line":"        try:"},{"line_number":2933,"context_line":"            list_detailed \u003d strutils.bool_from_string("},{"line_number":2934,"context_line":"                args.detailed, strict\u003dTrue)"},{"line_number":2935,"context_line":"        except ValueError:"},{"line_number":2936,"context_line":"            msg \u003d (\"Argument --detailed is not valid: %s \""},{"line_number":2937,"context_line":"                   \"bool is expected\" % six.text_type(args.detailed))"},{"line_number":2938,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":2939,"context_line":""},{"line_number":2940,"context_line":"    if list_detailed:"},{"line_number":2941,"context_line":"        fields \u003d [\"Name\", \"Host\", \"Backend\", \"Pool\", \"Capabilities\"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a8bc5a2_88124457","line":2938,"range":{"start_line":2935,"start_character":8,"end_line":2938,"end_character":46},"updated":"2016-09-28 07:16:50.000000000","message":"this try...except statement not necessary too, the reason as above, the exception won\u0027t be raised.","commit_id":"e22ead44b54c3f954254db78f047f6a88b7bd475"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"698dda2d5f86b60296dcdbaeda728cb921972f5e","unresolved":false,"context_lines":[{"line_number":2905,"context_line":"         \u0027e.g. --columns \"name,host\"\u0027)"},{"line_number":2906,"context_line":"@cliutils.arg("},{"line_number":2907,"context_line":"    \u0027--detailed\u0027,"},{"line_number":2908,"context_line":"    metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":2909,"context_line":"    choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":2910,"context_line":"    default\u003dTrue,"},{"line_number":2911,"context_line":"    help\u003d\u0027Show detailed information about pools.\u0027)"},{"line_number":2912,"context_line":"@cliutils.arg("}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5da102_d0aa0bd4","line":2909,"range":{"start_line":2908,"start_character":4,"end_line":2909,"end_character":30},"updated":"2016-10-28 08:42:44.000000000","message":"As your another patch https://review.openstack.org/#/c/368567, here could be improved, the presence of this argument as \"True\" and absence as \"False\".","commit_id":"c09ae2e2d36256efe69f9df3049f0a91e1064211"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"e9a43125fec253235c32e2c36766550d32fafd6a","unresolved":false,"context_lines":[{"line_number":2905,"context_line":"         \u0027e.g. --columns \"name,host\"\u0027)"},{"line_number":2906,"context_line":"@cliutils.arg("},{"line_number":2907,"context_line":"    \u0027--detail\u0027,"},{"line_number":2908,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":2909,"context_line":"    help\u003d\u0027Show detailed information about pools. (Default\u003dFalse) \u0027)"},{"line_number":2910,"context_line":"@cliutils.arg("},{"line_number":2911,"context_line":"    \u0027--share-type\u0027, \u0027--share_type\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5da102_4c0d748f","line":2908,"updated":"2016-10-29 01:51:01.000000000","message":"missing default\u003dFalse?","commit_id":"d0ac644675d07e38995d2cb771b3e4bd1a6847a6"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"e1897f037dadb15440d51ffbbda67a450600ee2f","unresolved":false,"context_lines":[{"line_number":2905,"context_line":"         \u0027e.g. --columns \"name,host\"\u0027)"},{"line_number":2906,"context_line":"@cliutils.arg("},{"line_number":2907,"context_line":"    \u0027--detail\u0027,"},{"line_number":2908,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":2909,"context_line":"    help\u003d\u0027Show detailed information about pools. (Default\u003dFalse) \u0027)"},{"line_number":2910,"context_line":"@cliutils.arg("},{"line_number":2911,"context_line":"    \u0027--share-type\u0027, \u0027--share_type\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5da102_2c7da0e7","line":2908,"in_reply_to":"ba5da102_4c0d748f","updated":"2016-10-29 01:57:08.000000000","message":"I had check the lib\u0027s documentation, and believed it\u0027s unnecessary, please take a look[1]\n\n[1] https://docs.python.org/2/library/argparse.html#action","commit_id":"d0ac644675d07e38995d2cb771b3e4bd1a6847a6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bfea9b9c16b70846c3e295efb7eb30e8e8561a8c","unresolved":false,"context_lines":[{"line_number":3017,"context_line":"    help\u003d\u0027Comma separated list of columns to be displayed \u0027"},{"line_number":3018,"context_line":"         \u0027e.g. --columns \"name,host\"\u0027)"},{"line_number":3019,"context_line":"@cliutils.arg("},{"line_number":3020,"context_line":"    \u0027--detail\u0027,"},{"line_number":3021,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":3022,"context_line":"    help\u003d\u0027Show detailed information about pools. (Default\u003dFalse) \u0027)"},{"line_number":3023,"context_line":"@cliutils.arg("}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_442fe13d","line":3020,"range":{"start_line":3020,"start_character":7,"end_line":3020,"end_character":13},"updated":"2016-12-21 02:02:47.000000000","message":"actually, other commands use \"--detailed\", maybe you can add an alias for --detailed as well.","commit_id":"94e01b1d1fc04a5a079d16d88e7881c224f8a597"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ab04dc422f0988505cd340b39074d7e76d1875de","unresolved":false,"context_lines":[{"line_number":3019,"context_line":"@cliutils.arg("},{"line_number":3020,"context_line":"    \u0027--detail\u0027,"},{"line_number":3021,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":3022,"context_line":"    help\u003d\u0027Show detailed information about pools. (Default\u003dFalse) \u0027)"},{"line_number":3023,"context_line":"@cliutils.arg("},{"line_number":3024,"context_line":"    \u0027--share-type\u0027, \u0027--share_type\u0027,"},{"line_number":3025,"context_line":"    metavar\u003d\u0027\u003cshare_type\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_043089e7","line":3022,"range":{"start_line":3022,"start_character":64,"end_line":3022,"end_character":65},"updated":"2016-12-21 01:56:20.000000000","message":"remove space","commit_id":"94e01b1d1fc04a5a079d16d88e7881c224f8a597"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bfea9b9c16b70846c3e295efb7eb30e8e8561a8c","unresolved":false,"context_lines":[{"line_number":3021,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":3022,"context_line":"    help\u003d\u0027Show detailed information about pools. (Default\u003dFalse) \u0027)"},{"line_number":3023,"context_line":"@cliutils.arg("},{"line_number":3024,"context_line":"    \u0027--share-type\u0027, \u0027--share_type\u0027,"},{"line_number":3025,"context_line":"    metavar\u003d\u0027\u003cshare_type\u003e\u0027,"},{"line_number":3026,"context_line":"    type\u003dstr,"},{"line_number":3027,"context_line":"    default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_a420b54a","line":3024,"range":{"start_line":3024,"start_character":4,"end_line":3024,"end_character":34},"updated":"2016-12-21 02:02:47.000000000","message":"Please add \u0027--share-type-id\u0027, \u0027--share_type_id\u0027 as well","commit_id":"94e01b1d1fc04a5a079d16d88e7881c224f8a597"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ab04dc422f0988505cd340b39074d7e76d1875de","unresolved":false,"context_lines":[{"line_number":3026,"context_line":"    type\u003dstr,"},{"line_number":3027,"context_line":"    default\u003dNone,"},{"line_number":3028,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":3029,"context_line":"    help\u003d\u0027Filter results by share type name or ID. (Default\u003dNone) \u0027"},{"line_number":3030,"context_line":"         \u0027Available only for microversion \u003e\u003d 2.23\u0027)"},{"line_number":3031,"context_line":"def do_pool_list(cs, args):"},{"line_number":3032,"context_line":"    \"\"\"List all backend storage pools known to the scheduler (Admin only).\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_a441953b","line":3029,"range":{"start_line":3029,"start_character":65,"end_line":3029,"end_character":66},"updated":"2016-12-21 01:56:20.000000000","message":"remove space","commit_id":"94e01b1d1fc04a5a079d16d88e7881c224f8a597"}],"releasenotes/notes/add-query-params-pools-list--12cf1s14ddf40kdd.yaml":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"485ee30cc3e00bae2ad196292d7a17bdc60963c8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add ``--detailed`` argument to pool list"},{"line_number":4,"context_line":"  - Add ``--share_type`` argument to pool list"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5a8bc5a2_68ad3d9a","line":3,"updated":"2016-09-27 06:25:13.000000000","message":"add tail period.","commit_id":"118a20ac2fc89aceedb27b62266e3424e7b65cf4"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"485ee30cc3e00bae2ad196292d7a17bdc60963c8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add ``--detailed`` argument to pool list"},{"line_number":4,"context_line":"  - Add ``--share_type`` argument to pool list"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5a8bc5a2_0892f94b","line":4,"range":{"start_line":4,"start_character":42,"end_line":4,"end_character":46},"updated":"2016-09-27 06:25:13.000000000","message":"add tail period.","commit_id":"118a20ac2fc89aceedb27b62266e3424e7b65cf4"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"485ee30cc3e00bae2ad196292d7a17bdc60963c8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add ``--detailed`` argument to pool list"},{"line_number":4,"context_line":"  - Add ``--share_type`` argument to pool list"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5a8bc5a2_c8757132","line":4,"range":{"start_line":4,"start_character":24,"end_line":4,"end_character":25},"updated":"2016-09-27 06:25:13.000000000","message":"or \u0027--share-type\u0027","commit_id":"118a20ac2fc89aceedb27b62266e3424e7b65cf4"}],"releasenotes/notes/add-query-params-pools-list-api-12cf1s14ddf40kdd.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ab04dc422f0988505cd340b39074d7e76d1875de","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add ``--detailed`` argument to pool list."},{"line_number":4,"context_line":"  - Add ``--share_type`` or ``--share-type`` argument to pool list."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1a6eadb0_8423b9a6","line":3,"range":{"start_line":3,"start_character":10,"end_line":3,"end_character":20},"updated":"2016-12-21 01:56:20.000000000","message":"--detail","commit_id":"94e01b1d1fc04a5a079d16d88e7881c224f8a597"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ab04dc422f0988505cd340b39074d7e76d1875de","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add ``--detailed`` argument to pool list."},{"line_number":4,"context_line":"  - Add ``--share_type`` or ``--share-type`` argument to pool list."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1a6eadb0_840c993c","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":7},"updated":"2016-12-21 01:56:20.000000000","message":"Added","commit_id":"94e01b1d1fc04a5a079d16d88e7881c224f8a597"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ab04dc422f0988505cd340b39074d7e76d1875de","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add ``--detailed`` argument to pool list."},{"line_number":4,"context_line":"  - Add ``--share_type`` or ``--share-type`` argument to pool list."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1a6eadb0_a413555b","line":3,"range":{"start_line":3,"start_character":35,"end_line":3,"end_character":44},"updated":"2016-12-21 01:56:20.000000000","message":"pool list command","commit_id":"94e01b1d1fc04a5a079d16d88e7881c224f8a597"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ab04dc422f0988505cd340b39074d7e76d1875de","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add ``--detailed`` argument to pool list."},{"line_number":4,"context_line":"  - Add ``--share_type`` or ``--share-type`` argument to pool list."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1a6eadb0_04196979","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":7},"updated":"2016-12-21 01:56:20.000000000","message":"Added","commit_id":"94e01b1d1fc04a5a079d16d88e7881c224f8a597"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ab04dc422f0988505cd340b39074d7e76d1875de","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add ``--detailed`` argument to pool list."},{"line_number":4,"context_line":"  - Add ``--share_type`` or ``--share-type`` argument to pool list."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1a6eadb0_4429a188","line":4,"range":{"start_line":4,"start_character":57,"end_line":4,"end_character":66},"updated":"2016-12-21 01:56:20.000000000","message":"pool list command","commit_id":"94e01b1d1fc04a5a079d16d88e7881c224f8a597"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b002fd6fc0d4e95d3912acb990e38de0478f57a7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added ``--detail`` argument to pool list command."},{"line_number":4,"context_line":"  - Added ``--share_type`` or ``--share-type`` argument to pool list command."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"da4df55a_ce11b2b1","line":4,"range":{"start_line":4,"start_character":27,"end_line":4,"end_character":47},"updated":"2016-12-22 01:55:18.000000000","message":"not necessary","commit_id":"666cccbfa8161ba5730a07e2ac85fc2b627cc7ab"},{"author":{"_account_id":24309,"name":"xinyanzhang","email":"236592348@qq.com","username":"xinyanzhang"},"change_message_id":"dfd928992741db0adc6e0d26ff4e8f398b9b04aa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added ``--detail`` argument to pool list command."},{"line_number":4,"context_line":"  - Added ``--share_type`` or ``--share-type`` argument to pool list command."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"da4df55a_5fc1ee7f","line":4,"range":{"start_line":4,"start_character":27,"end_line":4,"end_character":47},"in_reply_to":"da4df55a_ce11b2b1","updated":"2016-12-22 03:39:47.000000000","message":"Done","commit_id":"666cccbfa8161ba5730a07e2ac85fc2b627cc7ab"}]}