)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6ea96ebfac4847bddacdb260ae5ec9715d52d92b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add the ability to check tenant quota usages"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For other component such like cinder, the administrator could check"},{"line_number":10,"context_line":"the quota usage of tenant. Manila should have the same function which"},{"line_number":11,"context_line":"is general user case in the cloud."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ibc0f9f65891b8e2a308358420d2c4dc3ea4697ce"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a8bc5a2_fb78eb2d","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":26},"updated":"2016-09-28 10:49:22.000000000","message":"It is not argument.","commit_id":"ec0d7702b61692751b4501da25e98879c4a17a22"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6ea96ebfac4847bddacdb260ae5ec9715d52d92b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add the ability to check tenant quota usages"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For other component such like cinder, the administrator could check"},{"line_number":10,"context_line":"the quota usage of tenant. Manila should have the same function which"},{"line_number":11,"context_line":"is general user case in the cloud."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ibc0f9f65891b8e2a308358420d2c4dc3ea4697ce"},{"line_number":14,"context_line":"Implements: blueprint admin-check-tenant-quota-usage"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a8bc5a2_bb9d835b","line":11,"range":{"start_line":10,"start_character":27,"end_line":11,"end_character":34},"updated":"2016-09-28 10:49:22.000000000","message":"Better to describe use case itself. Not just saying \"it is\".","commit_id":"ec0d7702b61692751b4501da25e98879c4a17a22"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6ea96ebfac4847bddacdb260ae5ec9715d52d92b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For other component such like cinder, the administrator could check"},{"line_number":10,"context_line":"the quota usage of tenant. Manila should have the same function which"},{"line_number":11,"context_line":"is general user case in the cloud."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ibc0f9f65891b8e2a308358420d2c4dc3ea4697ce"},{"line_number":14,"context_line":"Implements: blueprint admin-check-tenant-quota-usage"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a8bc5a2_fb91cb53","line":11,"range":{"start_line":11,"start_character":11,"end_line":11,"end_character":20},"updated":"2016-09-28 10:49:22.000000000","message":"Maybe you wanted to say \"use case\"?","commit_id":"ec0d7702b61692751b4501da25e98879c4a17a22"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"79d9ca37a358cf3108601d61ef7df955091d73c1","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the quota usage of tenant. Currently Manila retrieves the quota set"},{"line_number":11,"context_line":"information only with \u0027limit\u0027 property."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch intend to enhance the API by return more properties"},{"line_number":14,"context_line":"(\u0027in_use\u0027, \u0027limit\u0027, \u0027reserved\u0027) with new option  \u0027--usages\u0027."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ibc0f9f65891b8e2a308358420d2c4dc3ea4697ce"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a98d1f4_06145042","line":13,"range":{"start_line":13,"start_character":11,"end_line":13,"end_character":17},"updated":"2016-09-29 08:37:15.000000000","message":"intends","commit_id":"bf5e831e132574584953ee6c5d4bf10b3fcbd60f"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"c54bdd59b86b9d2b5b3622f7559ed7b92015d3b5","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the quota usage of tenant. Currently Manila retrieves the quota set"},{"line_number":11,"context_line":"information only with \u0027limit\u0027 property."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch intend to enhance the API by return more properties"},{"line_number":14,"context_line":"(\u0027in_use\u0027, \u0027limit\u0027, \u0027reserved\u0027) with new option  \u0027--usages\u0027."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ibc0f9f65891b8e2a308358420d2c4dc3ea4697ce"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a95cdbc_4c534639","line":13,"range":{"start_line":13,"start_character":11,"end_line":13,"end_character":17},"in_reply_to":"3a98d1f4_06145042","updated":"2016-10-09 01:14:10.000000000","message":"Done","commit_id":"bf5e831e132574584953ee6c5d4bf10b3fcbd60f"}],"manilaclient/api_versions.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e94329cee059a00e22b8ee6f2713b407908b128f","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"MAX_VERSION \u003d \u00272.23\u0027"},{"line_number":31,"context_line":"MIN_VERSION \u003d \u00272.0\u0027"},{"line_number":32,"context_line":"DEPRECATED_VERSION \u003d \u00271.0\u0027"},{"line_number":33,"context_line":"_VERSIONED_METHOD_MAP \u003d {}"}],"source_content_type":"text/x-python","patch_set":12,"id":"da4df55a_4688afc5","line":30,"range":{"start_line":30,"start_character":17,"end_line":30,"end_character":19},"updated":"2016-12-27 22:57:14.000000000","message":"2.25","commit_id":"243d46fdb20c1a9e861dca6d08aac1bc7c4418ef"},{"author":{"_account_id":24309,"name":"xinyanzhang","email":"236592348@qq.com","username":"xinyanzhang"},"change_message_id":"6182d684f067468882afbfe56e8c72c7a8836eca","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"MAX_VERSION \u003d \u00272.23\u0027"},{"line_number":31,"context_line":"MIN_VERSION \u003d \u00272.0\u0027"},{"line_number":32,"context_line":"DEPRECATED_VERSION \u003d \u00271.0\u0027"},{"line_number":33,"context_line":"_VERSIONED_METHOD_MAP \u003d {}"}],"source_content_type":"text/x-python","patch_set":12,"id":"da4df55a_2b9c4b0e","line":30,"range":{"start_line":30,"start_character":17,"end_line":30,"end_character":19},"in_reply_to":"da4df55a_4688afc5","updated":"2016-12-28 07:36:33.000000000","message":"Done","commit_id":"243d46fdb20c1a9e861dca6d08aac1bc7c4418ef"}],"manilaclient/tests/functional/test_quotas.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6328dc4ea8f6982b5b62d209c6b1c254179c7cd9","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        self._get_quotas(role, \"show\", \"2.7\")"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    @ddt.data(\u0027admin\u0027, \u0027user\u0027)"},{"line_number":84,"context_line":"    @utils.skip_if_microversion_not_supported(\"2.23\")"},{"line_number":85,"context_line":"    def test_quota_show_api_2_23(self, role):"},{"line_number":86,"context_line":"        self._get_quotas(role, \"show  --detail\", \"2.23\")"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba5201f7_9a0403c7","line":84,"range":{"start_line":84,"start_character":47,"end_line":84,"end_character":51},"updated":"2017-01-10 17:20:51.000000000","message":"2.25 and below","commit_id":"318cadfc92dd0b4b6e7168251acbf9f98d911253"}],"manilaclient/tests/unit/v2/fakes.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"dd52130b0a0c5e22d0937355e4bb275fe3e708b3","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from manilaclient.v2 import client"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class FakeKeystoneClient(object):"},{"line_number":24,"context_line":"    def __init__(self):"},{"line_number":25,"context_line":"        self.project_id \u003d \u00271234\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class FakeClient(fakes.FakeClient):"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba5201f7_96a83edd","line":25,"range":{"start_line":23,"start_character":0,"end_line":25,"end_character":32},"updated":"2017-01-11 09:58:43.000000000","message":"Why do you need it?","commit_id":"eb68821aa2fc0f7b8378f7bb3225c64195f7aee5"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6b4b3abeb3433fcb662a2eb603c0c555e450b9f9","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from manilaclient.v2 import client"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class FakeKeystoneClient(object):"},{"line_number":24,"context_line":"    def __init__(self):"},{"line_number":25,"context_line":"        self.project_id \u003d \u00271234\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class FakeClient(fakes.FakeClient):"}],"source_content_type":"text/x-python","patch_set":15,"id":"7a3c09a3_a6739ab0","line":25,"range":{"start_line":23,"start_character":0,"end_line":25,"end_character":32},"in_reply_to":"ba5201f7_6293e65b","updated":"2017-01-13 14:05:02.000000000","message":"No, it is not used. It should be removed as well as line 44.","commit_id":"eb68821aa2fc0f7b8378f7bb3225c64195f7aee5"},{"author":{"_account_id":24309,"name":"xinyanzhang","email":"236592348@qq.com","username":"xinyanzhang"},"change_message_id":"8abac102035c7f2f9c927713637e436279ee0d7a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from manilaclient.v2 import client"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class FakeKeystoneClient(object):"},{"line_number":24,"context_line":"    def __init__(self):"},{"line_number":25,"context_line":"        self.project_id \u003d \u00271234\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class FakeClient(fakes.FakeClient):"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba5201f7_6293e65b","line":25,"range":{"start_line":23,"start_character":0,"end_line":25,"end_character":32},"in_reply_to":"ba5201f7_96a83edd","updated":"2017-01-12 03:48:22.000000000","message":"This used in tests/unit/v2/test_quotas.py, method test_quota_show(), trying to access an url with projectid \"1234\".","commit_id":"eb68821aa2fc0f7b8378f7bb3225c64195f7aee5"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"dd52130b0a0c5e22d0937355e4bb275fe3e708b3","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            api_version\u003dkwargs.get(\"api_version\", manilaclient.API_MAX_VERSION)"},{"line_number":42,"context_line":"        )"},{"line_number":43,"context_line":"        self.client \u003d FakeHTTPClient(**kwargs)"},{"line_number":44,"context_line":"        self.keystone_client \u003d FakeKeystoneClient()"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"fake_share_instance \u003d {"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba5201f7_d6aac6d1","line":44,"range":{"start_line":44,"start_character":8,"end_line":44,"end_character":51},"updated":"2017-01-11 09:58:43.000000000","message":"Same here.","commit_id":"eb68821aa2fc0f7b8378f7bb3225c64195f7aee5"}],"manilaclient/tests/unit/v2/test_quotas.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"66f05d92222d1f53bbd96f8cb5384cdeb92cbfe4","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    @ddt.data(\"2.6\", \"2.7\", \"2.23\")"},{"line_number":39,"context_line":"    def test_tenant_quotas_get(self, microversion):"},{"line_number":40,"context_line":"        tenant_id \u003d \u0027test\u0027"},{"line_number":41,"context_line":"        usages \u003d True"},{"line_number":42,"context_line":"        manager \u003d self._get_manager(microversion)"},{"line_number":43,"context_line":"        resource_path \u003d self._get_resource_path(microversion)"},{"line_number":44,"context_line":"        version \u003d api_versions.APIVersion(microversion)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_449fe9b3","line":41,"range":{"start_line":41,"start_character":8,"end_line":41,"end_character":14},"updated":"2016-09-24 07:28:58.000000000","message":"this definition is not necessary, cause it\u0027s only used in one call manager.get below. you could directly use True constant in place.","commit_id":"16c4741a2e22e6a9c1f87a5f6eb816c3409e916a"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"758abfd600cfa17219f294308d5c2df2a113f078","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    @ddt.data(\"2.6\", \"2.7\", \"2.23\")"},{"line_number":39,"context_line":"    def test_tenant_quotas_get(self, microversion):"},{"line_number":40,"context_line":"        tenant_id \u003d \u0027test\u0027"},{"line_number":41,"context_line":"        usages \u003d True"},{"line_number":42,"context_line":"        manager \u003d self._get_manager(microversion)"},{"line_number":43,"context_line":"        resource_path \u003d self._get_resource_path(microversion)"},{"line_number":44,"context_line":"        version \u003d api_versions.APIVersion(microversion)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_658051c1","line":41,"range":{"start_line":41,"start_character":8,"end_line":41,"end_character":14},"in_reply_to":"5a8bc5a2_449fe9b3","updated":"2016-09-26 02:29:55.000000000","message":"Done","commit_id":"16c4741a2e22e6a9c1f87a5f6eb816c3409e916a"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"66f05d92222d1f53bbd96f8cb5384cdeb92cbfe4","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    def test_user_quotas_get(self, microversion):"},{"line_number":59,"context_line":"        tenant_id \u003d \u0027test\u0027"},{"line_number":60,"context_line":"        user_id \u003d \u0027fake_user\u0027"},{"line_number":61,"context_line":"        usages \u003d True"},{"line_number":62,"context_line":"        manager \u003d self._get_manager(microversion)"},{"line_number":63,"context_line":"        resource_path \u003d self._get_resource_path(microversion)"},{"line_number":64,"context_line":"        version \u003d api_versions.APIVersion(microversion)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_64a6a511","line":61,"range":{"start_line":61,"start_character":8,"end_line":61,"end_character":14},"updated":"2016-09-24 07:28:58.000000000","message":"ditto","commit_id":"16c4741a2e22e6a9c1f87a5f6eb816c3409e916a"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"758abfd600cfa17219f294308d5c2df2a113f078","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    def test_user_quotas_get(self, microversion):"},{"line_number":59,"context_line":"        tenant_id \u003d \u0027test\u0027"},{"line_number":60,"context_line":"        user_id \u003d \u0027fake_user\u0027"},{"line_number":61,"context_line":"        usages \u003d True"},{"line_number":62,"context_line":"        manager \u003d self._get_manager(microversion)"},{"line_number":63,"context_line":"        resource_path \u003d self._get_resource_path(microversion)"},{"line_number":64,"context_line":"        version \u003d api_versions.APIVersion(microversion)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_05fb0d48","line":61,"range":{"start_line":61,"start_character":8,"end_line":61,"end_character":14},"in_reply_to":"5a8bc5a2_64a6a511","updated":"2016-09-26 02:29:55.000000000","message":"Done","commit_id":"16c4741a2e22e6a9c1f87a5f6eb816c3409e916a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e94329cee059a00e22b8ee6f2713b407908b128f","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            return quotas.RESOURCE_PATH"},{"line_number":36,"context_line":"        return quotas.RESOURCE_PATH_LEGACY"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @ddt.data(\"2.6\", \"2.7\", \"2.23\")"},{"line_number":39,"context_line":"    def test_tenant_quotas_get(self, microversion):"},{"line_number":40,"context_line":"        tenant_id \u003d \u0027test\u0027"},{"line_number":41,"context_line":"        manager \u003d self._get_manager(microversion)"}],"source_content_type":"text/x-python","patch_set":12,"id":"da4df55a_86f7f757","line":38,"range":{"start_line":38,"start_character":32,"end_line":38,"end_character":33},"updated":"2016-12-27 22:57:14.000000000","message":"5","commit_id":"243d46fdb20c1a9e861dca6d08aac1bc7c4418ef"},{"author":{"_account_id":24309,"name":"xinyanzhang","email":"236592348@qq.com","username":"xinyanzhang"},"change_message_id":"6182d684f067468882afbfe56e8c72c7a8836eca","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            return quotas.RESOURCE_PATH"},{"line_number":36,"context_line":"        return quotas.RESOURCE_PATH_LEGACY"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @ddt.data(\"2.6\", \"2.7\", \"2.23\")"},{"line_number":39,"context_line":"    def test_tenant_quotas_get(self, microversion):"},{"line_number":40,"context_line":"        tenant_id \u003d \u0027test\u0027"},{"line_number":41,"context_line":"        manager \u003d self._get_manager(microversion)"}],"source_content_type":"text/x-python","patch_set":12,"id":"da4df55a_8b8b77c2","line":38,"range":{"start_line":38,"start_character":32,"end_line":38,"end_character":33},"in_reply_to":"da4df55a_86f7f757","updated":"2016-12-28 07:36:33.000000000","message":"Done","commit_id":"243d46fdb20c1a9e861dca6d08aac1bc7c4418ef"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e94329cee059a00e22b8ee6f2713b407908b128f","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"            manager._get.assert_called_once_with(expected_url, \"quota_set\")"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @ddt.data(\"2.6\", \"2.7\", \"2.23\")"},{"line_number":57,"context_line":"    def test_user_quotas_get(self, microversion):"},{"line_number":58,"context_line":"        tenant_id \u003d \u0027test\u0027"},{"line_number":59,"context_line":"        user_id \u003d \u0027fake_user\u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"da4df55a_a696bbed","line":56,"range":{"start_line":56,"start_character":29,"end_line":56,"end_character":33},"updated":"2016-12-27 22:57:14.000000000","message":"2.25","commit_id":"243d46fdb20c1a9e861dca6d08aac1bc7c4418ef"},{"author":{"_account_id":24309,"name":"xinyanzhang","email":"236592348@qq.com","username":"xinyanzhang"},"change_message_id":"6182d684f067468882afbfe56e8c72c7a8836eca","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"            manager._get.assert_called_once_with(expected_url, \"quota_set\")"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @ddt.data(\"2.6\", \"2.7\", \"2.23\")"},{"line_number":57,"context_line":"    def test_user_quotas_get(self, microversion):"},{"line_number":58,"context_line":"        tenant_id \u003d \u0027test\u0027"},{"line_number":59,"context_line":"        user_id \u003d \u0027fake_user\u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"da4df55a_ab883bc6","line":56,"range":{"start_line":56,"start_character":29,"end_line":56,"end_character":33},"in_reply_to":"da4df55a_a696bbed","updated":"2016-12-28 07:36:33.000000000","message":"Done","commit_id":"243d46fdb20c1a9e861dca6d08aac1bc7c4418ef"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6328dc4ea8f6982b5b62d209c6b1c254179c7cd9","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        manager \u003d self._get_manager(microversion)"},{"line_number":42,"context_line":"        resource_path \u003d self._get_resource_path(microversion)"},{"line_number":43,"context_line":"        version \u003d api_versions.APIVersion(microversion)"},{"line_number":44,"context_line":"        if version \u003e\u003d api_versions.APIVersion(\u00272.23\u0027):"},{"line_number":45,"context_line":"            expected_url \u003d \"%s/test/detail\" % resource_path"},{"line_number":46,"context_line":"        else:"},{"line_number":47,"context_line":"            expected_url \u003d (\"%s/test\""}],"source_content_type":"text/x-python","patch_set":14,"id":"ba5201f7_da576bc8","line":44,"range":{"start_line":44,"start_character":47,"end_line":44,"end_character":51},"updated":"2017-01-10 17:20:51.000000000","message":"2.25","commit_id":"318cadfc92dd0b4b6e7168251acbf9f98d911253"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6328dc4ea8f6982b5b62d209c6b1c254179c7cd9","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        manager \u003d self._get_manager(microversion)"},{"line_number":61,"context_line":"        resource_path \u003d self._get_resource_path(microversion)"},{"line_number":62,"context_line":"        version \u003d api_versions.APIVersion(microversion)"},{"line_number":63,"context_line":"        if version \u003e\u003d api_versions.APIVersion(\u00272.23\u0027):"},{"line_number":64,"context_line":"            expected_url \u003d (\"%s/test/detail?user_id\u003dfake_user\""},{"line_number":65,"context_line":"                            % resource_path)"},{"line_number":66,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba5201f7_9a5de3ee","line":63,"range":{"start_line":63,"start_character":47,"end_line":63,"end_character":51},"updated":"2017-01-10 17:20:51.000000000","message":"2.25","commit_id":"318cadfc92dd0b4b6e7168251acbf9f98d911253"}],"manilaclient/tests/unit/v2/test_shell.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"054350cbcba80adc7ac7cde0e1110aaf681b1e12","unresolved":false,"context_lines":[{"line_number":1598,"context_line":""},{"line_number":1599,"context_line":"    @mock.patch.object(cliutils, \u0027print_dict\u0027, mock.Mock())"},{"line_number":1600,"context_line":"    def test_quota_show(self):"},{"line_number":1601,"context_line":"        self.run_command(\u0027quota-show\u0027)"},{"line_number":1602,"context_line":"        self.assert_called("},{"line_number":1603,"context_line":"            \u0027GET\u0027,"},{"line_number":1604,"context_line":"            \u0027/quota-sets/1234?usages\u003dFalse\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a8bc5a2_d775d132","line":1601,"updated":"2016-09-28 06:14:47.000000000","message":"please cover the situation of \u0027--usages True\u0027.","commit_id":"ec0d7702b61692751b4501da25e98879c4a17a22"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"b247487c54707a9cb7eab5532f937971e4890704","unresolved":false,"context_lines":[{"line_number":1598,"context_line":""},{"line_number":1599,"context_line":"    @mock.patch.object(cliutils, \u0027print_dict\u0027, mock.Mock())"},{"line_number":1600,"context_line":"    def test_quota_show(self):"},{"line_number":1601,"context_line":"        self.run_command(\u0027quota-show\u0027)"},{"line_number":1602,"context_line":"        self.assert_called("},{"line_number":1603,"context_line":"            \u0027GET\u0027,"},{"line_number":1604,"context_line":"            \u0027/quota-sets/1234?usages\u003dFalse\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a98d1f4_eabe54fe","line":1601,"in_reply_to":"5a8bc5a2_4a51060e","updated":"2016-09-29 03:20:08.000000000","message":"Done","commit_id":"ec0d7702b61692751b4501da25e98879c4a17a22"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6ea96ebfac4847bddacdb260ae5ec9715d52d92b","unresolved":false,"context_lines":[{"line_number":1598,"context_line":""},{"line_number":1599,"context_line":"    @mock.patch.object(cliutils, \u0027print_dict\u0027, mock.Mock())"},{"line_number":1600,"context_line":"    def test_quota_show(self):"},{"line_number":1601,"context_line":"        self.run_command(\u0027quota-show\u0027)"},{"line_number":1602,"context_line":"        self.assert_called("},{"line_number":1603,"context_line":"            \u0027GET\u0027,"},{"line_number":1604,"context_line":"            \u0027/quota-sets/1234?usages\u003dFalse\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a8bc5a2_4a51060e","line":1601,"in_reply_to":"5a8bc5a2_d775d132","updated":"2016-09-28 10:49:22.000000000","message":"+1","commit_id":"ec0d7702b61692751b4501da25e98879c4a17a22"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"b247487c54707a9cb7eab5532f937971e4890704","unresolved":false,"context_lines":[{"line_number":1598,"context_line":""},{"line_number":1599,"context_line":"    @mock.patch.object(cliutils, \u0027print_dict\u0027, mock.Mock())"},{"line_number":1600,"context_line":"    def test_quota_show(self):"},{"line_number":1601,"context_line":"        self.run_command(\u0027quota-show\u0027)"},{"line_number":1602,"context_line":"        self.assert_called("},{"line_number":1603,"context_line":"            \u0027GET\u0027,"},{"line_number":1604,"context_line":"            \u0027/quota-sets/1234?usages\u003dFalse\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a98d1f4_0abc6004","line":1601,"in_reply_to":"5a8bc5a2_d775d132","updated":"2016-09-29 03:20:08.000000000","message":"Done","commit_id":"ec0d7702b61692751b4501da25e98879c4a17a22"}],"manilaclient/v2/quotas.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"66f05d92222d1f53bbd96f8cb5384cdeb92cbfe4","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        }"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        if user_id:"},{"line_number":50,"context_line":"            url \u003d (\"%(resource_path)s/%(tenant_id)s?user_id\u003d%(user_id)s\""},{"line_number":51,"context_line":"                   % data)"},{"line_number":52,"context_line":"            url +\u003d \"\u0026usages\u003d%(usages)s\" % data"},{"line_number":53,"context_line":"        else:"},{"line_number":54,"context_line":"            url \u003d \"%(resource_path)s/%(tenant_id)s\" % data"},{"line_number":55,"context_line":"            url +\u003d \"?usages\u003d%(usages)s\" % data"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_4451a90d","line":52,"range":{"start_line":50,"start_character":12,"end_line":52,"end_character":46},"updated":"2016-09-24 07:28:58.000000000","message":"why not merge these two lines to one?","commit_id":"16c4741a2e22e6a9c1f87a5f6eb816c3409e916a"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"758abfd600cfa17219f294308d5c2df2a113f078","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        }"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        if user_id:"},{"line_number":50,"context_line":"            url \u003d (\"%(resource_path)s/%(tenant_id)s?user_id\u003d%(user_id)s\""},{"line_number":51,"context_line":"                   % data)"},{"line_number":52,"context_line":"            url +\u003d \"\u0026usages\u003d%(usages)s\" % data"},{"line_number":53,"context_line":"        else:"},{"line_number":54,"context_line":"            url \u003d \"%(resource_path)s/%(tenant_id)s\" % data"},{"line_number":55,"context_line":"            url +\u003d \"?usages\u003d%(usages)s\" % data"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_65f5b155","line":52,"range":{"start_line":50,"start_character":12,"end_line":52,"end_character":46},"in_reply_to":"5a8bc5a2_4451a90d","updated":"2016-09-26 02:29:55.000000000","message":"Done","commit_id":"16c4741a2e22e6a9c1f87a5f6eb816c3409e916a"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"66f05d92222d1f53bbd96f8cb5384cdeb92cbfe4","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                   % data)"},{"line_number":52,"context_line":"            url +\u003d \"\u0026usages\u003d%(usages)s\" % data"},{"line_number":53,"context_line":"        else:"},{"line_number":54,"context_line":"            url \u003d \"%(resource_path)s/%(tenant_id)s\" % data"},{"line_number":55,"context_line":"            url +\u003d \"?usages\u003d%(usages)s\" % data"},{"line_number":56,"context_line":"        return self._get(url, \"quota_set\")"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @api_versions.wraps(\"1.0\", \"2.6\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_64586533","line":55,"range":{"start_line":54,"start_character":12,"end_line":55,"end_character":46},"updated":"2016-09-24 07:28:58.000000000","message":"ditto","commit_id":"16c4741a2e22e6a9c1f87a5f6eb816c3409e916a"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"758abfd600cfa17219f294308d5c2df2a113f078","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                   % data)"},{"line_number":52,"context_line":"            url +\u003d \"\u0026usages\u003d%(usages)s\" % data"},{"line_number":53,"context_line":"        else:"},{"line_number":54,"context_line":"            url \u003d \"%(resource_path)s/%(tenant_id)s\" % data"},{"line_number":55,"context_line":"            url +\u003d \"?usages\u003d%(usages)s\" % data"},{"line_number":56,"context_line":"        return self._get(url, \"quota_set\")"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @api_versions.wraps(\"1.0\", \"2.6\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_85e63dae","line":55,"range":{"start_line":54,"start_character":12,"end_line":55,"end_character":46},"in_reply_to":"5a8bc5a2_64586533","updated":"2016-09-26 02:29:55.000000000","message":"Done","commit_id":"16c4741a2e22e6a9c1f87a5f6eb816c3409e916a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6ea96ebfac4847bddacdb260ae5ec9715d52d92b","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        }"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        if user_id:"},{"line_number":50,"context_line":"            url \u003d (\"%(resource_path)s/%(tenant_id)s?\""},{"line_number":51,"context_line":"                   \"user_id\u003d%(user_id)s\u0026usages\u003d%(usages)s\""},{"line_number":52,"context_line":"                   % data)"},{"line_number":53,"context_line":"        else:"},{"line_number":54,"context_line":"            url \u003d (\"%(resource_path)s/%(tenant_id)s?\""},{"line_number":55,"context_line":"                   \"usages\u003d%(usages)s\" % data)"},{"line_number":56,"context_line":"        return self._get(url, \"quota_set\")"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @api_versions.wraps(\"1.0\", \"2.6\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a8bc5a2_5b11dfae","line":55,"range":{"start_line":50,"start_character":18,"end_line":55,"end_character":46},"updated":"2016-09-28 10:49:22.000000000","message":"We should not provide it always. Only when needed.","commit_id":"ec0d7702b61692751b4501da25e98879c4a17a22"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"b247487c54707a9cb7eab5532f937971e4890704","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        }"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        if user_id:"},{"line_number":50,"context_line":"            url \u003d (\"%(resource_path)s/%(tenant_id)s?\""},{"line_number":51,"context_line":"                   \"user_id\u003d%(user_id)s\u0026usages\u003d%(usages)s\""},{"line_number":52,"context_line":"                   % data)"},{"line_number":53,"context_line":"        else:"},{"line_number":54,"context_line":"            url \u003d (\"%(resource_path)s/%(tenant_id)s?\""},{"line_number":55,"context_line":"                   \"usages\u003d%(usages)s\" % data)"},{"line_number":56,"context_line":"        return self._get(url, \"quota_set\")"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @api_versions.wraps(\"1.0\", \"2.6\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a98d1f4_8ab950ec","line":55,"range":{"start_line":50,"start_character":18,"end_line":55,"end_character":46},"in_reply_to":"5a8bc5a2_5b11dfae","updated":"2016-09-29 03:20:08.000000000","message":"Done","commit_id":"ec0d7702b61692751b4501da25e98879c4a17a22"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"79d9ca37a358cf3108601d61ef7df955091d73c1","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            tenant_id \u003d tenant_id.tenant_id"},{"line_number":43,"context_line":"        query_dict \u003d {"},{"line_number":44,"context_line":"            \"user_id\": user_id,"},{"line_number":45,"context_line":"            \"usages\": usages"},{"line_number":46,"context_line":"        }"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        query_string \u003d urlparse.urlencode("}],"source_content_type":"text/x-python","patch_set":5,"id":"3a98d1f4_e6bbe470","line":45,"updated":"2016-09-29 08:37:15.000000000","message":"add tail comma","commit_id":"bf5e831e132574584953ee6c5d4bf10b3fcbd60f"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"c54bdd59b86b9d2b5b3622f7559ed7b92015d3b5","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            tenant_id \u003d tenant_id.tenant_id"},{"line_number":43,"context_line":"        query_dict \u003d {"},{"line_number":44,"context_line":"            \"user_id\": user_id,"},{"line_number":45,"context_line":"            \"usages\": usages"},{"line_number":46,"context_line":"        }"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        query_string \u003d urlparse.urlencode("}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_6c3482fb","line":45,"in_reply_to":"3a98d1f4_e6bbe470","updated":"2016-10-09 01:14:10.000000000","message":"Done","commit_id":"bf5e831e132574584953ee6c5d4bf10b3fcbd60f"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"79d9ca37a358cf3108601d61ef7df955091d73c1","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        }"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        query_string \u003d urlparse.urlencode("},{"line_number":49,"context_line":"            sorted([(k, v) for (k, v) in list(query_dict.items()) if v]))"},{"line_number":50,"context_line":"        if query_string:"},{"line_number":51,"context_line":"            query_string \u003d \"?%s\" % (query_string,)"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a98d1f4_265cec4a","line":49,"range":{"start_line":49,"start_character":41,"end_line":49,"end_character":45},"updated":"2016-09-29 08:37:15.000000000","message":"no need to convert to list","commit_id":"bf5e831e132574584953ee6c5d4bf10b3fcbd60f"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"79d9ca37a358cf3108601d61ef7df955091d73c1","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        }"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        query_string \u003d urlparse.urlencode("},{"line_number":49,"context_line":"            sorted([(k, v) for (k, v) in list(query_dict.items()) if v]))"},{"line_number":50,"context_line":"        if query_string:"},{"line_number":51,"context_line":"            query_string \u003d \"?%s\" % (query_string,)"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a98d1f4_61e5fe35","line":49,"range":{"start_line":49,"start_character":12,"end_line":49,"end_character":18},"updated":"2016-09-29 08:37:15.000000000","message":"why need sorting?","commit_id":"bf5e831e132574584953ee6c5d4bf10b3fcbd60f"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"c54bdd59b86b9d2b5b3622f7559ed7b92015d3b5","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        }"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        query_string \u003d urlparse.urlencode("},{"line_number":49,"context_line":"            sorted([(k, v) for (k, v) in list(query_dict.items()) if v]))"},{"line_number":50,"context_line":"        if query_string:"},{"line_number":51,"context_line":"            query_string \u003d \"?%s\" % (query_string,)"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_ec28929c","line":49,"range":{"start_line":49,"start_character":41,"end_line":49,"end_character":45},"in_reply_to":"3a98d1f4_265cec4a","updated":"2016-10-09 01:14:10.000000000","message":"Done","commit_id":"bf5e831e132574584953ee6c5d4bf10b3fcbd60f"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"c54bdd59b86b9d2b5b3622f7559ed7b92015d3b5","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        }"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        query_string \u003d urlparse.urlencode("},{"line_number":49,"context_line":"            sorted([(k, v) for (k, v) in list(query_dict.items()) if v]))"},{"line_number":50,"context_line":"        if query_string:"},{"line_number":51,"context_line":"            query_string \u003d \"?%s\" % (query_string,)"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_ec0fb234","line":49,"range":{"start_line":49,"start_character":12,"end_line":49,"end_character":18},"in_reply_to":"3a98d1f4_61e5fe35","updated":"2016-10-09 01:14:10.000000000","message":"yeah,it can be expected when use it or accomplish it\u0027s testcase with this sort(), or in another way, make it more friendly to documentation.","commit_id":"bf5e831e132574584953ee6c5d4bf10b3fcbd60f"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"79d9ca37a358cf3108601d61ef7df955091d73c1","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        query_string \u003d urlparse.urlencode("},{"line_number":49,"context_line":"            sorted([(k, v) for (k, v) in list(query_dict.items()) if v]))"},{"line_number":50,"context_line":"        if query_string:"},{"line_number":51,"context_line":"            query_string \u003d \"?%s\" % (query_string,)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        data \u003d {"},{"line_number":54,"context_line":"            \"resource_path\": resource_path,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a98d1f4_61017eae","line":51,"range":{"start_line":51,"start_character":35,"end_line":51,"end_character":50},"updated":"2016-09-29 08:37:15.000000000","message":"why use a tuple, just query_string is enough.","commit_id":"bf5e831e132574584953ee6c5d4bf10b3fcbd60f"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"c54bdd59b86b9d2b5b3622f7559ed7b92015d3b5","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        query_string \u003d urlparse.urlencode("},{"line_number":49,"context_line":"            sorted([(k, v) for (k, v) in list(query_dict.items()) if v]))"},{"line_number":50,"context_line":"        if query_string:"},{"line_number":51,"context_line":"            query_string \u003d \"?%s\" % (query_string,)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        data \u003d {"},{"line_number":54,"context_line":"            \"resource_path\": resource_path,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_ac3a0ae5","line":51,"range":{"start_line":51,"start_character":35,"end_line":51,"end_character":50},"in_reply_to":"3a98d1f4_61017eae","updated":"2016-10-09 01:14:10.000000000","message":"Done","commit_id":"bf5e831e132574584953ee6c5d4bf10b3fcbd60f"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"79d9ca37a358cf3108601d61ef7df955091d73c1","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        data \u003d {"},{"line_number":54,"context_line":"            \"resource_path\": resource_path,"},{"line_number":55,"context_line":"            \"tenant_id\": tenant_id,"},{"line_number":56,"context_line":"            \"query_string\": query_string"},{"line_number":57,"context_line":"        }"},{"line_number":58,"context_line":"        url \u003d \"%(resource_path)s/%(tenant_id)s%(query_string)s\" % data"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a98d1f4_c66d0806","line":56,"updated":"2016-09-29 08:37:15.000000000","message":"tail comma","commit_id":"bf5e831e132574584953ee6c5d4bf10b3fcbd60f"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"c54bdd59b86b9d2b5b3622f7559ed7b92015d3b5","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        data \u003d {"},{"line_number":54,"context_line":"            \"resource_path\": resource_path,"},{"line_number":55,"context_line":"            \"tenant_id\": tenant_id,"},{"line_number":56,"context_line":"            \"query_string\": query_string"},{"line_number":57,"context_line":"        }"},{"line_number":58,"context_line":"        url \u003d \"%(resource_path)s/%(tenant_id)s%(query_string)s\" % data"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_0c0bfe2a","line":56,"in_reply_to":"3a98d1f4_c66d0806","updated":"2016-10-09 01:14:10.000000000","message":"Done","commit_id":"bf5e831e132574584953ee6c5d4bf10b3fcbd60f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e94329cee059a00e22b8ee6f2713b407908b128f","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        return self._do_get(tenant_id, user_id,"},{"line_number":61,"context_line":"                            resource_path\u003dRESOURCE_PATH_LEGACY)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    @api_versions.wraps(\"2.7\", \"2.22\")  # noqa"},{"line_number":64,"context_line":"    def get(self, tenant_id, user_id\u003dNone, detail\u003dFalse):"},{"line_number":65,"context_line":"        return self._do_get(tenant_id, user_id,"},{"line_number":66,"context_line":"                            resource_path\u003dRESOURCE_PATH)"}],"source_content_type":"text/x-python","patch_set":12,"id":"da4df55a_268babc4","line":63,"range":{"start_line":63,"start_character":34,"end_line":63,"end_character":36},"updated":"2016-12-27 22:57:14.000000000","message":"2.24","commit_id":"243d46fdb20c1a9e861dca6d08aac1bc7c4418ef"},{"author":{"_account_id":24309,"name":"xinyanzhang","email":"236592348@qq.com","username":"xinyanzhang"},"change_message_id":"6182d684f067468882afbfe56e8c72c7a8836eca","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        return self._do_get(tenant_id, user_id,"},{"line_number":61,"context_line":"                            resource_path\u003dRESOURCE_PATH_LEGACY)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    @api_versions.wraps(\"2.7\", \"2.22\")  # noqa"},{"line_number":64,"context_line":"    def get(self, tenant_id, user_id\u003dNone, detail\u003dFalse):"},{"line_number":65,"context_line":"        return self._do_get(tenant_id, user_id,"},{"line_number":66,"context_line":"                            resource_path\u003dRESOURCE_PATH)"}],"source_content_type":"text/x-python","patch_set":12,"id":"da4df55a_cb91fff2","line":63,"range":{"start_line":63,"start_character":34,"end_line":63,"end_character":36},"in_reply_to":"da4df55a_268babc4","updated":"2016-12-28 07:36:33.000000000","message":"Done","commit_id":"243d46fdb20c1a9e861dca6d08aac1bc7c4418ef"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e94329cee059a00e22b8ee6f2713b407908b128f","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        return self._do_get(tenant_id, user_id,"},{"line_number":66,"context_line":"                            resource_path\u003dRESOURCE_PATH)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @api_versions.wraps(\"2.23\")  # noqa"},{"line_number":69,"context_line":"    def get(self, tenant_id, user_id\u003dNone, detail\u003dFalse):"},{"line_number":70,"context_line":"        return self._do_get(tenant_id, user_id, detail,"},{"line_number":71,"context_line":"                            resource_path\u003dRESOURCE_PATH)"}],"source_content_type":"text/x-python","patch_set":12,"id":"da4df55a_06a2274b","line":68,"range":{"start_line":68,"start_character":25,"end_line":68,"end_character":29},"updated":"2016-12-27 22:57:14.000000000","message":"2.25","commit_id":"243d46fdb20c1a9e861dca6d08aac1bc7c4418ef"},{"author":{"_account_id":24309,"name":"xinyanzhang","email":"236592348@qq.com","username":"xinyanzhang"},"change_message_id":"6182d684f067468882afbfe56e8c72c7a8836eca","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        return self._do_get(tenant_id, user_id,"},{"line_number":66,"context_line":"                            resource_path\u003dRESOURCE_PATH)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @api_versions.wraps(\"2.23\")  # noqa"},{"line_number":69,"context_line":"    def get(self, tenant_id, user_id\u003dNone, detail\u003dFalse):"},{"line_number":70,"context_line":"        return self._do_get(tenant_id, user_id, detail,"},{"line_number":71,"context_line":"                            resource_path\u003dRESOURCE_PATH)"}],"source_content_type":"text/x-python","patch_set":12,"id":"da4df55a_eb8ec3ce","line":68,"range":{"start_line":68,"start_character":25,"end_line":68,"end_character":29},"in_reply_to":"da4df55a_06a2274b","updated":"2016-12-28 07:36:33.000000000","message":"Done","commit_id":"243d46fdb20c1a9e861dca6d08aac1bc7c4418ef"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6328dc4ea8f6982b5b62d209c6b1c254179c7cd9","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        if hasattr(tenant_id, \u0027tenant_id\u0027):"},{"line_number":41,"context_line":"            tenant_id \u003d tenant_id.tenant_id"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        query \u003d \u0027\u0027"},{"line_number":44,"context_line":"        if user_id:"},{"line_number":45,"context_line":"            query \u003d \u0027?user_id\u003d%s\u0027 % user_id"},{"line_number":46,"context_line":"        data \u003d {"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba5201f7_faa7cf08","line":43,"range":{"start_line":43,"start_character":8,"end_line":43,"end_character":18},"updated":"2017-01-10 17:20:51.000000000","message":"query \u003d \u0027/detail\u0027 if detail else \u0027\u0027","commit_id":"318cadfc92dd0b4b6e7168251acbf9f98d911253"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6328dc4ea8f6982b5b62d209c6b1c254179c7cd9","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        data \u003d {"},{"line_number":47,"context_line":"            \"resource_path\": resource_path,"},{"line_number":48,"context_line":"            \"tenant_id\": tenant_id,"},{"line_number":49,"context_line":"            \"query\": query,"},{"line_number":50,"context_line":"        }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        if detail:"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba5201f7_faf50fed","line":49,"range":{"start_line":49,"start_character":12,"end_line":49,"end_character":27},"updated":"2017-01-10 17:20:51.000000000","message":"remove it","commit_id":"318cadfc92dd0b4b6e7168251acbf9f98d911253"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6328dc4ea8f6982b5b62d209c6b1c254179c7cd9","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            \"query\": query,"},{"line_number":50,"context_line":"        }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        if detail:"},{"line_number":53,"context_line":"            url \u003d \"%(resource_path)s/%(tenant_id)s/detail%(query)s\" % data"},{"line_number":54,"context_line":"        else:"},{"line_number":55,"context_line":"            url \u003d \"%(resource_path)s/%(tenant_id)s%(query)s\" % data"},{"line_number":56,"context_line":"        return self._get(url, \"quota_set\")"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @api_versions.wraps(\"1.0\", \"2.6\")"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba5201f7_7a8bdf68","line":55,"range":{"start_line":52,"start_character":8,"end_line":55,"end_character":67},"updated":"2017-01-10 17:20:51.000000000","message":"url \u003d (\"%(resource_path)s/%(tenant_id)s\" + query) % data","commit_id":"318cadfc92dd0b4b6e7168251acbf9f98d911253"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"66f05d92222d1f53bbd96f8cb5384cdeb92cbfe4","unresolved":false,"context_lines":[{"line_number":360,"context_line":"    \u0027--usages\u0027,"},{"line_number":361,"context_line":"    metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":362,"context_line":"    choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":363,"context_line":"    help\u003d\u0027Optional flag to indicate whether to lists quota usages. \u0027"},{"line_number":364,"context_line":"    \u0027(Default\u003dFalse) Available only for microversion \u003e\u003d 2.23\u0027,"},{"line_number":365,"context_line":"    default\u003dFalse)"},{"line_number":366,"context_line":"def do_quota_show(cs, args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_4403690d","line":363,"range":{"start_line":363,"start_character":47,"end_line":363,"end_character":52},"updated":"2016-09-24 07:28:58.000000000","message":"list","commit_id":"16c4741a2e22e6a9c1f87a5f6eb816c3409e916a"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"758abfd600cfa17219f294308d5c2df2a113f078","unresolved":false,"context_lines":[{"line_number":360,"context_line":"    \u0027--usages\u0027,"},{"line_number":361,"context_line":"    metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":362,"context_line":"    choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":363,"context_line":"    help\u003d\u0027Optional flag to indicate whether to lists quota usages. \u0027"},{"line_number":364,"context_line":"    \u0027(Default\u003dFalse) Available only for microversion \u003e\u003d 2.23\u0027,"},{"line_number":365,"context_line":"    default\u003dFalse)"},{"line_number":366,"context_line":"def do_quota_show(cs, args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_45f0b567","line":363,"range":{"start_line":363,"start_character":47,"end_line":363,"end_character":52},"in_reply_to":"5a8bc5a2_4403690d","updated":"2016-09-26 02:29:55.000000000","message":"Done","commit_id":"16c4741a2e22e6a9c1f87a5f6eb816c3409e916a"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"af7deb7e8ee937595f2ab7db97fed2af3117c9e7","unresolved":false,"context_lines":[{"line_number":366,"context_line":"    metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":367,"context_line":"    choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":368,"context_line":"    help\u003d\u0027Optional flag to indicate whether to list quota usages. \u0027"},{"line_number":369,"context_line":"    \u0027(Default\u003dFalse) Available only for microversion \u003e\u003d 2.23\u0027,"},{"line_number":370,"context_line":"    default\u003dFalse)"},{"line_number":371,"context_line":"def do_quota_show(cs, args):"},{"line_number":372,"context_line":"    \"\"\"List the quotas for a tenant/user.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_7bd7114b","line":369,"range":{"start_line":369,"start_character":56,"end_line":369,"end_character":60},"updated":"2016-09-26 04:50:10.000000000","message":"add a tail period.","commit_id":"bc25f4403d94405a971a0f95aa17a5ed40868f8d"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"af7deb7e8ee937595f2ab7db97fed2af3117c9e7","unresolved":false,"context_lines":[{"line_number":366,"context_line":"    metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":367,"context_line":"    choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":368,"context_line":"    help\u003d\u0027Optional flag to indicate whether to list quota usages. \u0027"},{"line_number":369,"context_line":"    \u0027(Default\u003dFalse) Available only for microversion \u003e\u003d 2.23\u0027,"},{"line_number":370,"context_line":"    default\u003dFalse)"},{"line_number":371,"context_line":"def do_quota_show(cs, args):"},{"line_number":372,"context_line":"    \"\"\"List the quotas for a tenant/user.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_dbdf4567","line":369,"updated":"2016-09-26 04:50:10.000000000","message":"indent this line as above.","commit_id":"bc25f4403d94405a971a0f95aa17a5ed40868f8d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6ea96ebfac4847bddacdb260ae5ec9715d52d92b","unresolved":false,"context_lines":[{"line_number":328,"context_line":"def _quota_show(quotas):"},{"line_number":329,"context_line":"    quota_dict \u003d {}"},{"line_number":330,"context_line":"    for resource in _quota_resources:"},{"line_number":331,"context_line":"        quota_dict[resource] \u003d getattr(quotas, resource, None)"},{"line_number":332,"context_line":"    cliutils.print_dict(quota_dict)"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a8bc5a2_d624e6c7","line":331,"range":{"start_line":331,"start_character":8,"end_line":331,"end_character":62},"updated":"2016-09-28 10:49:22.000000000","message":"Replace this with following:\n\n\"\"\"\nquota_dict[resource] \u003d quotas.get(resource, None)\n\"\"\"","commit_id":"ec0d7702b61692751b4501da25e98879c4a17a22"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"b247487c54707a9cb7eab5532f937971e4890704","unresolved":false,"context_lines":[{"line_number":328,"context_line":"def _quota_show(quotas):"},{"line_number":329,"context_line":"    quota_dict \u003d {}"},{"line_number":330,"context_line":"    for resource in _quota_resources:"},{"line_number":331,"context_line":"        quota_dict[resource] \u003d getattr(quotas, resource, None)"},{"line_number":332,"context_line":"    cliutils.print_dict(quota_dict)"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a98d1f4_0af0e08f","line":331,"range":{"start_line":331,"start_character":8,"end_line":331,"end_character":62},"in_reply_to":"5a8bc5a2_d624e6c7","updated":"2016-09-29 03:20:08.000000000","message":"Done","commit_id":"ec0d7702b61692751b4501da25e98879c4a17a22"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6ea96ebfac4847bddacdb260ae5ec9715d52d92b","unresolved":false,"context_lines":[{"line_number":370,"context_line":"    default\u003dFalse)"},{"line_number":371,"context_line":"def do_quota_show(cs, args):"},{"line_number":372,"context_line":"    \"\"\"List the quotas for a tenant/user.\"\"\""},{"line_number":373,"context_line":"    project_id \u003d cs.keystone_client.project_id"},{"line_number":374,"context_line":"    if not args.tenant:"},{"line_number":375,"context_line":"        _quota_show(cs.quotas.get(project_id, user_id\u003dargs.user,"},{"line_number":376,"context_line":"                                  usages\u003dargs.usages))"},{"line_number":377,"context_line":"    else:"},{"line_number":378,"context_line":"        _quota_show(cs.quotas.get(args.tenant, user_id\u003dargs.user,"},{"line_number":379,"context_line":"                                  usages\u003dargs.usages))"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"@cliutils.arg("}],"source_content_type":"text/x-python","patch_set":4,"id":"5a8bc5a2_761cf277","line":379,"range":{"start_line":373,"start_character":4,"end_line":379,"end_character":54},"updated":"2016-09-28 10:49:22.000000000","message":"And do here following:\n\"\"\"\nproject \u003d args.tenant or cs.keystone_client.project_id\nquotas \u003d cs.quotas.get(project, user_id\u003dargs.user, usages\u003dargs.usages)\nnew_quotas \u003d {}\nfor quota_k, quota_v in quotas.to_dict().items():\n    if isinstance(quota_v, dict):\n        quota_v \u003d \u0027\\n\u0027.join(\n            [\u0027%s \u003d %s\u0027 % (k, v) for k, v in quota_v.items()])\n    new_quotas[quota_k] \u003d quota_v\n_quota_show(new_quotas)\n\"\"\"\n\nIt will print nice output in both cases - old and new one.","commit_id":"ec0d7702b61692751b4501da25e98879c4a17a22"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"b247487c54707a9cb7eab5532f937971e4890704","unresolved":false,"context_lines":[{"line_number":370,"context_line":"    default\u003dFalse)"},{"line_number":371,"context_line":"def do_quota_show(cs, args):"},{"line_number":372,"context_line":"    \"\"\"List the quotas for a tenant/user.\"\"\""},{"line_number":373,"context_line":"    project_id \u003d cs.keystone_client.project_id"},{"line_number":374,"context_line":"    if not args.tenant:"},{"line_number":375,"context_line":"        _quota_show(cs.quotas.get(project_id, user_id\u003dargs.user,"},{"line_number":376,"context_line":"                                  usages\u003dargs.usages))"},{"line_number":377,"context_line":"    else:"},{"line_number":378,"context_line":"        _quota_show(cs.quotas.get(args.tenant, user_id\u003dargs.user,"},{"line_number":379,"context_line":"                                  usages\u003dargs.usages))"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"@cliutils.arg("}],"source_content_type":"text/x-python","patch_set":4,"id":"3a98d1f4_ea93b4f8","line":379,"range":{"start_line":373,"start_character":4,"end_line":379,"end_character":54},"in_reply_to":"5a8bc5a2_761cf277","updated":"2016-09-29 03:20:08.000000000","message":"great~,thanks for your patient review and fantastic demonstration","commit_id":"ec0d7702b61692751b4501da25e98879c4a17a22"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"79d9ca37a358cf3108601d61ef7df955091d73c1","unresolved":false,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    new_quotas \u003d {}"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    for quota_k, quota_v in quotas.to_dict().items():"},{"line_number":228,"context_line":"        if isinstance(quota_v, dict):"},{"line_number":229,"context_line":"            quota_v \u003d \u0027\\n\u0027.join("},{"line_number":230,"context_line":"                [\u0027%s \u003d %s\u0027 % (k, v) for k, v in quota_v.items()])"},{"line_number":231,"context_line":"        new_quotas[quota_k] \u003d quota_v"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"    return new_quotas"},{"line_number":234,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a98d1f4_61efbee8","line":231,"range":{"start_line":227,"start_character":4,"end_line":231,"end_character":37},"updated":"2016-09-29 08:37:15.000000000","message":"should add a test to cover this logic, check the converting result.","commit_id":"bf5e831e132574584953ee6c5d4bf10b3fcbd60f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e38396022c47eb9baa484b5aff205aa8d0d911be","unresolved":false,"context_lines":[{"line_number":342,"context_line":"def _quota_show(quotas):"},{"line_number":343,"context_line":"    quota_dict \u003d {}"},{"line_number":344,"context_line":"    for resource in _quota_resources:"},{"line_number":345,"context_line":"        quota_dict[resource] \u003d getattr(quotas, resource, None)"},{"line_number":346,"context_line":"    cliutils.print_dict(quota_dict)"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_9c308cea","line":345,"range":{"start_line":345,"start_character":39,"end_line":345,"end_character":45},"updated":"2016-10-12 16:40:10.000000000","message":"\"quotas\" is always dict here and you always will get \"None\" as a result. Why it was changed from \"quotas.get\" that was in PS6? Also, the fact that such bug exists means you should improve unit tests. But in really good case - implement functional tests.\n\nOriginal comment can be found here:\n\nhttps://review.openstack.org/#/c/368567/4..8/manilaclient/v2/shell.py","commit_id":"85d4424e74bae20d09af99aa2c89de065d208ba4"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"4bb739e4c72b2a04863841e26217ff440a0e0255","unresolved":false,"context_lines":[{"line_number":342,"context_line":"def _quota_show(quotas):"},{"line_number":343,"context_line":"    quota_dict \u003d {}"},{"line_number":344,"context_line":"    for resource in _quota_resources:"},{"line_number":345,"context_line":"        quota_dict[resource] \u003d getattr(quotas, resource, None)"},{"line_number":346,"context_line":"    cliutils.print_dict(quota_dict)"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_36d14358","line":345,"range":{"start_line":345,"start_character":39,"end_line":345,"end_character":45},"in_reply_to":"fa6399be_9c308cea","updated":"2016-10-13 06:16:34.000000000","message":"_quota_show is used in multiply functions and both object and dict are possible passed into, thanks for your reminder,I left this function untouched and did the print stuff just in \u0027_quota_set_pretty_format\u0027 method. please check the latest one","commit_id":"85d4424e74bae20d09af99aa2c89de065d208ba4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e38396022c47eb9baa484b5aff205aa8d0d911be","unresolved":false,"context_lines":[{"line_number":378,"context_line":"@cliutils.arg("},{"line_number":379,"context_line":"    \u0027--detail\u0027,"},{"line_number":380,"context_line":"    metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":381,"context_line":"    choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":382,"context_line":"    help\u003d\u0027Optional flag to indicate whether to list quota usages \u0027"},{"line_number":383,"context_line":"         \u0027(Default\u003dFalse) Available only for microversion \u003e\u003d 2.23.\u0027,"},{"line_number":384,"context_line":"    default\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_fc58a8fc","line":381,"range":{"start_line":381,"start_character":4,"end_line":381,"end_character":30},"updated":"2016-10-12 16:40:10.000000000","message":"I guess it is redundant. We should consider presence of this arg as \"True\" and absence as \"False\" values. As we do for \"--all-tenants\" in \"do_list\" command. Also, \"nova\" has exactly such approach for \"quota-show\".","commit_id":"85d4424e74bae20d09af99aa2c89de065d208ba4"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"4bb739e4c72b2a04863841e26217ff440a0e0255","unresolved":false,"context_lines":[{"line_number":378,"context_line":"@cliutils.arg("},{"line_number":379,"context_line":"    \u0027--detail\u0027,"},{"line_number":380,"context_line":"    metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":381,"context_line":"    choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":382,"context_line":"    help\u003d\u0027Optional flag to indicate whether to list quota usages \u0027"},{"line_number":383,"context_line":"         \u0027(Default\u003dFalse) Available only for microversion \u003e\u003d 2.23.\u0027,"},{"line_number":384,"context_line":"    default\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_35d8601d","line":381,"range":{"start_line":381,"start_character":4,"end_line":381,"end_character":30},"in_reply_to":"fa6399be_fc58a8fc","updated":"2016-10-13 06:16:34.000000000","message":"Done","commit_id":"85d4424e74bae20d09af99aa2c89de065d208ba4"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"85ce246aafde03583c205737aca1b9c3b5a58d98","unresolved":false,"context_lines":[{"line_number":219,"context_line":"    cliutils.print_dict(info)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"def _quota_set_pretty_show(quotas):"},{"line_number":223,"context_line":"    \"\"\"convert quotas object to dict and display\"\"\""},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    new_quotas \u003d {}"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_c96ea895","line":222,"updated":"2016-10-13 06:49:09.000000000","message":"Still, it\u0027s necessary to add an UT covering this object to dict converting logic.","commit_id":"5d937d00fec82bfa607924bbfca76f6f5c918f63"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"85ce246aafde03583c205737aca1b9c3b5a58d98","unresolved":false,"context_lines":[{"line_number":378,"context_line":"    \u0027--detail\u0027,"},{"line_number":379,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":380,"context_line":"    default\u003dFalse,"},{"line_number":381,"context_line":"    help\u003d\u0027Optional flag to indicate whether to show quota in detail \u0027"},{"line_number":382,"context_line":"         \u0027Default false, Available only for microversion \u003e\u003d 2.23.\u0027)"},{"line_number":383,"context_line":"def do_quota_show(cs, args):"},{"line_number":384,"context_line":"    \"\"\"List the quotas for a tenant/user.\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_a921744f","line":381,"range":{"start_line":381,"start_character":61,"end_line":381,"end_character":67},"updated":"2016-10-13 06:49:09.000000000","message":"add a tail period.","commit_id":"5d937d00fec82bfa607924bbfca76f6f5c918f63"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"2dc3b2bd9e25f08ce64862b00c9167be7a6b8ecc","unresolved":false,"context_lines":[{"line_number":378,"context_line":"    \u0027--detail\u0027,"},{"line_number":379,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":380,"context_line":"    default\u003dFalse,"},{"line_number":381,"context_line":"    help\u003d\u0027Optional flag to indicate whether to show quota in detail \u0027"},{"line_number":382,"context_line":"         \u0027Default false, Available only for microversion \u003e\u003d 2.23.\u0027)"},{"line_number":383,"context_line":"def do_quota_show(cs, args):"},{"line_number":384,"context_line":"    \"\"\"List the quotas for a tenant/user.\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_616ae182","line":381,"range":{"start_line":381,"start_character":61,"end_line":381,"end_character":67},"in_reply_to":"fa6399be_a921744f","updated":"2016-10-14 03:46:28.000000000","message":"Done","commit_id":"5d937d00fec82bfa607924bbfca76f6f5c918f63"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"85ce246aafde03583c205737aca1b9c3b5a58d98","unresolved":false,"context_lines":[{"line_number":379,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":380,"context_line":"    default\u003dFalse,"},{"line_number":381,"context_line":"    help\u003d\u0027Optional flag to indicate whether to show quota in detail \u0027"},{"line_number":382,"context_line":"         \u0027Default false, Available only for microversion \u003e\u003d 2.23.\u0027)"},{"line_number":383,"context_line":"def do_quota_show(cs, args):"},{"line_number":384,"context_line":"    \"\"\"List the quotas for a tenant/user.\"\"\""},{"line_number":385,"context_line":"    project \u003d args.tenant or cs.keystone_client.project_id"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_c91ce815","line":382,"range":{"start_line":382,"start_character":25,"end_line":382,"end_character":34},"updated":"2016-10-13 06:49:09.000000000","message":"available","commit_id":"5d937d00fec82bfa607924bbfca76f6f5c918f63"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"2dc3b2bd9e25f08ce64862b00c9167be7a6b8ecc","unresolved":false,"context_lines":[{"line_number":379,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":380,"context_line":"    default\u003dFalse,"},{"line_number":381,"context_line":"    help\u003d\u0027Optional flag to indicate whether to show quota in detail \u0027"},{"line_number":382,"context_line":"         \u0027Default false, Available only for microversion \u003e\u003d 2.23.\u0027)"},{"line_number":383,"context_line":"def do_quota_show(cs, args):"},{"line_number":384,"context_line":"    \"\"\"List the quotas for a tenant/user.\"\"\""},{"line_number":385,"context_line":"    project \u003d args.tenant or cs.keystone_client.project_id"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_41715d75","line":382,"range":{"start_line":382,"start_character":25,"end_line":382,"end_character":34},"in_reply_to":"fa6399be_c91ce815","updated":"2016-10-14 03:46:28.000000000","message":"Done","commit_id":"5d937d00fec82bfa607924bbfca76f6f5c918f63"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"005736d97b99a87eb88fe4ff076146065d6ddd9d","unresolved":false,"context_lines":[{"line_number":378,"context_line":"    \u0027--detail\u0027,"},{"line_number":379,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":380,"context_line":"    help\u003d\u0027Optional flag to indicate whether to show quota in detail. \u0027"},{"line_number":381,"context_line":"         \u0027Default false, available only for microversion \u003e\u003d 2.23.\u0027)"},{"line_number":382,"context_line":"def do_quota_show(cs, args):"},{"line_number":383,"context_line":"    \"\"\"List the quotas for a tenant/user.\"\"\""},{"line_number":384,"context_line":"    project \u003d args.tenant or cs.keystone_client.project_id"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba5201f7_9907b41c","line":381,"range":{"start_line":381,"start_character":60,"end_line":381,"end_character":64},"updated":"2017-01-10 17:08:01.000000000","message":"2.24","commit_id":"318cadfc92dd0b4b6e7168251acbf9f98d911253"}]}
