)]}'
{"id":"openstack%2Fpython-manilaclient~404167","triplet_id":"openstack%2Fpython-manilaclient~master~I4474773837128ec5683a6da2655b055d28850ad4","project":"openstack/python-manilaclient","branch":"master","topic":"bug/1364800","hashtags":[],"change_id":"I4474773837128ec5683a6da2655b055d28850ad4","subject":"Configures coverage tool","status":"MERGED","created":"2016-11-29 11:44:45.000000000","updated":"2016-12-05 12:45:24.000000000","submitted":"2016-12-05 12:45:24.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"89f690e4cdd38c142ddd1df08f88a0b27cb655d3","_number":404167,"virtual_id_number":404167,"owner":{"_account_id":23512,"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","username":"alexander.pugachev"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},{"value":2,"date":"2016-12-05 12:45:24.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},{"value":0,"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"all":[{"value":2,"date":"2016-12-05 12:08:32.000000000","_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-12-05 10:27:49.000000000","_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},{"value":2,"date":"2016-12-02 19:33:31.000000000","_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"all":[{"value":1,"date":"2016-12-05 12:08:32.000000000","_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},{"value":0,"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-12-02 19:33:31.000000000","updated_by":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"reviewer":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"state":"REVIEWER"},{"updated":"2016-12-05 10:27:49.000000000","updated_by":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"reviewer":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"state":"REVIEWER"},{"updated":"2016-12-05 12:08:32.000000000","updated_by":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"reviewer":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"state":"REVIEWER"},{"updated":"2016-12-05 12:45:24.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"a386c33a9bb34beb643d2a91a5a87eba8bdb1f1e","author":{"_account_id":23512,"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","username":"alexander.pugachev"},"date":"2016-11-29 11:44:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"686aa1d6e3fce1d27c9fe1eb1c7c1b80ccbcfdb4","author":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"date":"2016-11-29 11:44:57.000000000","message":"Patch Set 1:\n\nThank you for your first contribution to OpenStack.\n\n    Your patch will now be tested automatically by OpenStack testing frameworks\n    and once the automatic tests pass, it will be reviewed by other friendly\n    developers. They will give you feedback and may require you to refine it.\n\n    People seldom get their patch approved on the first try, so don\u0027t be\n    concerned if requested to make corrections. Feel free to modify your patch\n    and resubmit a new change-set.\n\n    Patches usually take 3 to 7 days to be reviewed so be patient and be\n    available on IRC to ask and answer questions about your work. Also it\n    takes generally at least a couple of weeks for cores to get around to\n    reviewing code. The more you participate in the community the more\n    rewarding it is for you. You may also notice that the more you get to know\n    people and get to be known, the faster your patches will be reviewed and\n    eventually approved. Get to know others and become known by doing code\n    reviews: anybody can do it, and it\u0027s a great way to learn the code base.\n\n    Thanks again for supporting OpenStack, we look forward to working with you.\n\n    IRC: https://wiki.openstack.org/wiki/IRC\n    Workflow: http://docs.openstack.org/infra/manual/developers.html\n    Commit Messages: https://wiki.openstack.org/wiki/GitCommitMessages","accounts_in_message":[],"_revision_number":1},{"id":"9bef8542065c26ee8f608037293e97a5a7554d51","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-29 12:20:30.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-manilaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/67/404167/1/check/gate-python-manilaclient-docs-ubuntu-xenial/97580b2//doc/build/html/ : SUCCESS in 2m 07s\n- gate-python-manilaclient-pep8-ubuntu-xenial http://logs.openstack.org/67/404167/1/check/gate-python-manilaclient-pep8-ubuntu-xenial/26f0807/ : SUCCESS in 2m 27s\n- gate-python-manilaclient-python27-ubuntu-xenial http://logs.openstack.org/67/404167/1/check/gate-python-manilaclient-python27-ubuntu-xenial/c6a843f/ : SUCCESS in 4m 44s\n- gate-python-manilaclient-python34 http://logs.openstack.org/67/404167/1/check/gate-python-manilaclient-python34/01d157e/ : SUCCESS in 3m 05s\n- gate-python-manilaclient-python35-nv http://logs.openstack.org/67/404167/1/check/gate-python-manilaclient-python35-nv/5674a02/ : SUCCESS in 4m 39s (non-voting)\n- gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial http://logs.openstack.org/67/404167/1/check/gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial/30e5a9d/ : SUCCESS in 33m 20s","accounts_in_message":[],"_revision_number":1},{"id":"64b7a54200f5c7aa7db6a480a8b33b12694063a3","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2016-11-29 12:55:24.000000000","message":"Patch Set 1:\n\nThanks for your contribution! Could you explain how this works? Why not use the \"cover\" testenv like other projects, so invoking it would be similar to invoking coverage checks on openstack/manila:\n\n tox -e cover","accounts_in_message":[],"_revision_number":1},{"id":"ad10d22b6d5090704d769d587828af00bf83df8e","author":{"_account_id":23512,"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","username":"alexander.pugachev"},"date":"2016-11-29 14:55:32.000000000","message":"Patch Set 1:\n\nIt is still invoked as \"tox -e coverage\". The way it works is almost the same. Purpose of the change is to make coverage report more informative.\n\nThis line: \"omit \u003d manilaclient/tests/*\" instructs coverage tool to omit everything under manila/tests/. Resulting code coverage report is smaller, easier to read. And less time to run.\n\nThis line: \"branch \u003d true\" asks coverage turn on branch coverage. Detailed documentation for this feature is here: https://coverage.readthedocs.io/en/coverage-4.2/branch.html . In short, coverage pays attention to branching and checks that both branches of an \"if\" operator are visited during testing.\n\nSection name just is just a way of passing this values to coverage, it is documented here: https://coverage.readthedocs.io/en/coverage-4.2/config.html#configuration-files . It says: \n\n\u003e\u003e\u003e Coverage.py will read settings from a setup.cfg file if no other configuration file is used. In this case, the section names have “coverage:” prefixed, so the [run] options described below will be found in the [coverage:run] section of setup.cfg.\n\nBranching option decreased reported coverage from 73% to 71%. Omitting tests decreased the number of files the coverage reports about from 130 to 68.","accounts_in_message":[],"_revision_number":1},{"id":"e734aec123f98aa91146c9daede67dbf2d92bb65","author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"date":"2016-11-30 14:02:19.000000000","message":"Patch Set 1:\n\nThis seems like a good idea but when I ran \u0027tox -ecover\u0027 I realized\nthat I don\u0027t really understand how this works in openstack/python-manilaclient.  Afterwards there are a bunch of .coverage.* files\naround but there is no cover directory with the overall coverage\nreport as in openstack/manila.","accounts_in_message":[],"_revision_number":1},{"id":"be261f88bc30041f922634d8c0c2dc1947911919","author":{"_account_id":23512,"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","username":"alexander.pugachev"},"date":"2016-11-30 16:33:14.000000000","message":"Patch Set 1:\n\n\"too -e cover\" generates bunch of HTML in directory \"cover\". It creates it as well.\nYou can open file://\u003cpath to sources\u003e/cover/index.html in a browser.","accounts_in_message":[],"_revision_number":1},{"id":"68aca2b4456eab50d49e7cdc652bfbd2ffa55cef","author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"date":"2016-11-30 16:55:32.000000000","message":"Patch Set 1:\n\n\u003e \"too -e cover\" generates bunch of HTML in directory \"cover\". It creates it as well.\n\nYeah, that\u0027s what I was expecting and it\u0027s what happens for openstack/manila but (for me) not with openstack/python-manilaclient.\n\nDoesn\u0027t have anything to do with your patch though.","accounts_in_message":[],"_revision_number":1},{"id":"3bfd5f8a8300a98f1f25e7a2bb38379b9eef9d78","author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"date":"2016-12-02 19:33:31.000000000","message":"Patch Set 1: Code-Review+2\n\nAlexander,\n\nThis is  a nice improvement, and sorry for the delay as I got my\ndevelopment environment sorted after an OS upgrade (and apparently\nsome mixup of system and pip installed packages).\n\nIf the other reviewers also like this change, you may want to look\nat a similar improvement for openstack/manila.","accounts_in_message":[],"_revision_number":1},{"id":"64eadad50e88f9ae43504b9599e014a362058e82","author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"date":"2016-12-05 10:27:49.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"45c847542e00557dae7a4291836b2c87e4b5dea0","author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"date":"2016-12-05 12:08:32.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"05be60d573b9eaca8565a86298a027cbadb79b17","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-05 12:08:42.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"1ee12b949685112e2ed10afb0444174f2e8520ec","date":"2016-12-05 12:45:24.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"a395e8bb0ca56f5420836bc036acea993d652977","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-05 12:45:24.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-manilaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/67/404167/1/gate/gate-python-manilaclient-docs-ubuntu-xenial/662c3c3//doc/build/html/ : SUCCESS in 3m 29s\n- gate-python-manilaclient-pep8-ubuntu-xenial http://logs.openstack.org/67/404167/1/gate/gate-python-manilaclient-pep8-ubuntu-xenial/79e961f/ : SUCCESS in 3m 49s\n- gate-python-manilaclient-python27-ubuntu-xenial http://logs.openstack.org/67/404167/1/gate/gate-python-manilaclient-python27-ubuntu-xenial/0abb886/ : SUCCESS in 5m 15s\n- gate-python-manilaclient-python34 http://logs.openstack.org/67/404167/1/gate/gate-python-manilaclient-python34/4dd8bef/ : SUCCESS in 4m 06s\n- gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial http://logs.openstack.org/67/404167/1/gate/gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial/d0c300a/ : SUCCESS in 35m 19s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a6d071e0966ee835549e7f2335a5852b1c54b997","revisions":{"a6d071e0966ee835549e7f2335a5852b1c54b997":{"kind":"REWORK","_number":1,"created":"2016-11-29 11:44:45.000000000","uploader":{"_account_id":23512,"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","username":"alexander.pugachev"},"ref":"refs/changes/67/404167/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/67/404167/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/67/404167/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/67/404167/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/67/404167/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/67/404167/1"}}},"commit":{"parents":[{"commit":"e94a70931fcd8d5c08abe16b901be203a71989bb","subject":"Show team and repo badges on README","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/e94a70931fcd8d5c08abe16b901be203a71989bb"}]}],"author":{"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","date":"2016-11-29 11:28:07.000000000","tz":0},"committer":{"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","date":"2016-11-29 11:32:56.000000000","tz":0},"subject":"Configures coverage tool","message":"Configures coverage tool\n\nSection \"coverage:run\" is translated to section \"run\" of coverage config.\nExcluding tests itself from coverage, adding branches to have wide picture.\n\nChange-Id: I4474773837128ec5683a6da2655b055d28850ad4\nPartial-Bug: #1364800\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/a6d071e0966ee835549e7f2335a5852b1c54b997"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/a6d071e0966ee835549e7f2335a5852b1c54b997"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
