)]}'
{"manilaclient/tests/functional/client.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c07244f7b1b575346f09d95670a032281552e876","unresolved":false,"context_lines":[{"line_number":714,"context_line":"                        \"build_timeout\": self.build_timeout})"},{"line_number":715,"context_line":"                raise tempest_lib_exc.TimeoutException(message)"},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"    def wait_for_migration_status(self, share_id, dest_host, status_to_wait,"},{"line_number":718,"context_line":"                                  microversion\u003dNone):"},{"line_number":719,"context_line":"        \"\"\"Waits for a share to migrate to a certain host.\"\"\""},{"line_number":720,"context_line":"        statuses \u003d ((status_to_wait,)"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_7294f736","line":717,"range":{"start_line":717,"start_character":17,"end_line":717,"end_character":33},"updated":"2017-01-20 00:07:21.000000000","message":"nit: task_state is more explicit than migration_status","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"18a7d69504fb41007a33ca255731f88f503090c9","unresolved":false,"context_lines":[{"line_number":714,"context_line":"                        \"build_timeout\": self.build_timeout})"},{"line_number":715,"context_line":"                raise tempest_lib_exc.TimeoutException(message)"},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"    def wait_for_migration_status(self, share_id, dest_host, status_to_wait,"},{"line_number":718,"context_line":"                                  microversion\u003dNone):"},{"line_number":719,"context_line":"        \"\"\"Waits for a share to migrate to a certain host.\"\"\""},{"line_number":720,"context_line":"        statuses \u003d ((status_to_wait,)"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_3f421c3f","line":717,"range":{"start_line":717,"start_character":17,"end_line":717,"end_character":33},"in_reply_to":"5a3905b3_7294f736","updated":"2017-01-20 11:54:07.000000000","message":"Done","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"}],"manilaclient/tests/functional/test_shares.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"038feb46c6c21800040674da2cf94a60e32a3d6d","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        self.assertTrue(get.get(\u0027export_locations\u0027, []) \u003e 0)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"@ddt.ddt"},{"line_number":97,"context_line":"class SharesTestMigration(base.BaseTestCase):"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a57fde8_44220cbb","line":96,"updated":"2017-01-12 10:50:09.000000000","message":"Before, we were only resetting share state to migration-related ones. Now you run migration itself here. So, need to add config option \"run_migration_tests\" similar to ones we already have [1].\n\n[1] https://github.com/openstack/python-manilaclient/blob/6f8f7d8c/manilaclient/config.py#L146","commit_id":"128b66c3dd5d326db6377f27c2ba42e92aceb185"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"216bccb2fa9425536ece8182882a737cd406c3c3","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        self.assertTrue(get.get(\u0027export_locations\u0027, []) \u003e 0)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"@ddt.ddt"},{"line_number":97,"context_line":"class SharesTestMigration(base.BaseTestCase):"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a3c09a3_b20d4640","line":96,"in_reply_to":"9a57fde8_44220cbb","updated":"2017-01-16 16:16:07.000000000","message":"Done","commit_id":"128b66c3dd5d326db6377f27c2ba42e92aceb185"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"038feb46c6c21800040674da2cf94a60e32a3d6d","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            neutron_net_id\u003dcls.old_share_net[\u0027neutron_net_id\u0027],"},{"line_number":118,"context_line":"            neutron_subnet_id\u003dcls.old_share_net[\u0027neutron_subnet_id\u0027])"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    @utils.skip_if_microversion_not_supported(\u00272.22\u0027)"},{"line_number":121,"context_line":"    @ddt.data(\u0027migration_error\u0027, \u0027migration_success\u0027, \u0027None\u0027)"},{"line_number":122,"context_line":"    def test_reset_task_state(self, state):"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a57fde8_c467dc23","line":120,"range":{"start_line":120,"start_character":47,"end_line":120,"end_character":51},"updated":"2017-01-12 10:50:09.000000000","message":"2.22?","commit_id":"128b66c3dd5d326db6377f27c2ba42e92aceb185"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"216bccb2fa9425536ece8182882a737cd406c3c3","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            neutron_net_id\u003dcls.old_share_net[\u0027neutron_net_id\u0027],"},{"line_number":118,"context_line":"            neutron_subnet_id\u003dcls.old_share_net[\u0027neutron_subnet_id\u0027])"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    @utils.skip_if_microversion_not_supported(\u00272.22\u0027)"},{"line_number":121,"context_line":"    @ddt.data(\u0027migration_error\u0027, \u0027migration_success\u0027, \u0027None\u0027)"},{"line_number":122,"context_line":"    def test_reset_task_state(self, state):"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a3c09a3_0c2c41aa","line":120,"range":{"start_line":120,"start_character":47,"end_line":120,"end_character":51},"in_reply_to":"9a57fde8_c467dc23","updated":"2017-01-16 16:16:07.000000000","message":"yes. Reset-task-state API hasn\u0027t changed","commit_id":"128b66c3dd5d326db6377f27c2ba42e92aceb185"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c07244f7b1b575346f09d95670a032281552e876","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        super(SharesTestMigration, cls).setUpClass()"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        cls.old_type \u003d cls.create_share_type("},{"line_number":105,"context_line":"            data_utils.rand_name(\u0027autotest_share_name\u0027),"},{"line_number":106,"context_line":"            driver_handles_share_servers\u003dTrue)"},{"line_number":107,"context_line":"        cls.new_type \u003d cls.create_share_type("},{"line_number":108,"context_line":"            data_utils.rand_name(\u0027autotest_share_name\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_d2f84b7f","line":105,"range":{"start_line":105,"start_character":49,"end_line":105,"end_character":53},"updated":"2017-01-20 00:07:21.000000000","message":"type\n\nalso, what\u0027s autotest?","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"18a7d69504fb41007a33ca255731f88f503090c9","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        super(SharesTestMigration, cls).setUpClass()"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        cls.old_type \u003d cls.create_share_type("},{"line_number":105,"context_line":"            data_utils.rand_name(\u0027autotest_share_name\u0027),"},{"line_number":106,"context_line":"            driver_handles_share_servers\u003dTrue)"},{"line_number":107,"context_line":"        cls.new_type \u003d cls.create_share_type("},{"line_number":108,"context_line":"            data_utils.rand_name(\u0027autotest_share_name\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_7f4ca470","line":105,"range":{"start_line":105,"start_character":49,"end_line":105,"end_character":53},"in_reply_to":"5a3905b3_d2f84b7f","updated":"2017-01-20 11:54:07.000000000","message":"Done","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c07244f7b1b575346f09d95670a032281552e876","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            data_utils.rand_name(\u0027autotest_share_name\u0027),"},{"line_number":106,"context_line":"            driver_handles_share_servers\u003dTrue)"},{"line_number":107,"context_line":"        cls.new_type \u003d cls.create_share_type("},{"line_number":108,"context_line":"            data_utils.rand_name(\u0027autotest_share_name\u0027),"},{"line_number":109,"context_line":"            driver_handles_share_servers\u003dTrue)"},{"line_number":110,"context_line":"        cls.error_type \u003d cls.create_share_type("},{"line_number":111,"context_line":"            data_utils.rand_name(\u0027autotest_share_name\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_f2f54783","line":108,"range":{"start_line":108,"start_character":49,"end_line":108,"end_character":53},"updated":"2017-01-20 00:07:21.000000000","message":"type","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"18a7d69504fb41007a33ca255731f88f503090c9","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            data_utils.rand_name(\u0027autotest_share_name\u0027),"},{"line_number":106,"context_line":"            driver_handles_share_servers\u003dTrue)"},{"line_number":107,"context_line":"        cls.new_type \u003d cls.create_share_type("},{"line_number":108,"context_line":"            data_utils.rand_name(\u0027autotest_share_name\u0027),"},{"line_number":109,"context_line":"            driver_handles_share_servers\u003dTrue)"},{"line_number":110,"context_line":"        cls.error_type \u003d cls.create_share_type("},{"line_number":111,"context_line":"            data_utils.rand_name(\u0027autotest_share_name\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_9f47904a","line":108,"range":{"start_line":108,"start_character":49,"end_line":108,"end_character":53},"in_reply_to":"5a3905b3_f2f54783","updated":"2017-01-20 11:54:07.000000000","message":"Done","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c07244f7b1b575346f09d95670a032281552e876","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            data_utils.rand_name(\u0027autotest_share_name\u0027),"},{"line_number":109,"context_line":"            driver_handles_share_servers\u003dTrue)"},{"line_number":110,"context_line":"        cls.error_type \u003d cls.create_share_type("},{"line_number":111,"context_line":"            data_utils.rand_name(\u0027autotest_share_name\u0027),"},{"line_number":112,"context_line":"            driver_handles_share_servers\u003dTrue,"},{"line_number":113,"context_line":"            extra_specs\u003d{\u0027cause_error\u0027: \u0027no_valid_host\u0027})"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_72307757","line":111,"range":{"start_line":111,"start_character":49,"end_line":111,"end_character":53},"updated":"2017-01-20 00:07:21.000000000","message":"type","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"18a7d69504fb41007a33ca255731f88f503090c9","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            data_utils.rand_name(\u0027autotest_share_name\u0027),"},{"line_number":109,"context_line":"            driver_handles_share_servers\u003dTrue)"},{"line_number":110,"context_line":"        cls.error_type \u003d cls.create_share_type("},{"line_number":111,"context_line":"            data_utils.rand_name(\u0027autotest_share_name\u0027),"},{"line_number":112,"context_line":"            driver_handles_share_servers\u003dTrue,"},{"line_number":113,"context_line":"            extra_specs\u003d{\u0027cause_error\u0027: \u0027no_valid_host\u0027})"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_bf744c9c","line":111,"range":{"start_line":111,"start_character":49,"end_line":111,"end_character":53},"in_reply_to":"5a3905b3_72307757","updated":"2017-01-20 11:54:07.000000000","message":"Done","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c07244f7b1b575346f09d95670a032281552e876","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        share \u003d self.user_client.get_share(share[\u0027id\u0027])"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        self.admin_client.reset_task_state(share[\u0027id\u0027], state)"},{"line_number":136,"context_line":"        share \u003d self.admin_client.get_share(share[\u0027id\u0027])"},{"line_number":137,"context_line":"        self.assertEqual(state, share[\u0027task_state\u0027])"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    @utils.skip_if_microversion_not_supported(\u00272.28\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_cd134a5b","line":136,"range":{"start_line":136,"start_character":21,"end_line":136,"end_character":33},"updated":"2017-01-20 00:07:21.000000000","message":"you should/could use the user_client for this.","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"18a7d69504fb41007a33ca255731f88f503090c9","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        share \u003d self.user_client.get_share(share[\u0027id\u0027])"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        self.admin_client.reset_task_state(share[\u0027id\u0027], state)"},{"line_number":136,"context_line":"        share \u003d self.admin_client.get_share(share[\u0027id\u0027])"},{"line_number":137,"context_line":"        self.assertEqual(state, share[\u0027task_state\u0027])"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    @utils.skip_if_microversion_not_supported(\u00272.28\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_3f977c91","line":136,"range":{"start_line":136,"start_character":21,"end_line":136,"end_character":33},"in_reply_to":"5a3905b3_cd134a5b","updated":"2017-01-20 11:54:07.000000000","message":"Done","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c07244f7b1b575346f09d95670a032281552e876","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                        constants.TASK_STATE_DATA_COPYING_COMPLETED)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        self.admin_client.migration_start("},{"line_number":175,"context_line":"            share[\u0027id\u0027], dest_pool, True, False, True, True, False,"},{"line_number":176,"context_line":"            self.new_share_net[\u0027id\u0027], new_type[\u0027ID\u0027])"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        share \u003d self.admin_client.wait_for_migration_status("}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_0d4c726f","line":175,"range":{"start_line":175,"start_character":36,"end_line":175,"end_character":67},"updated":"2017-01-20 00:07:21.000000000","message":"can you make these kwargs?","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"18a7d69504fb41007a33ca255731f88f503090c9","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                        constants.TASK_STATE_DATA_COPYING_COMPLETED)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        self.admin_client.migration_start("},{"line_number":175,"context_line":"            share[\u0027id\u0027], dest_pool, True, False, True, True, False,"},{"line_number":176,"context_line":"            self.new_share_net[\u0027id\u0027], new_type[\u0027ID\u0027])"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        share \u003d self.admin_client.wait_for_migration_status("}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_ff41740c","line":175,"range":{"start_line":175,"start_character":36,"end_line":175,"end_character":67},"in_reply_to":"5a3905b3_0d4c726f","updated":"2017-01-20 11:54:07.000000000","message":"Done","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c07244f7b1b575346f09d95670a032281552e876","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        self.assertEqual(self.old_type[\u0027ID\u0027], share[\u0027share_type\u0027])"},{"line_number":186,"context_line":"        self.assertEqual(self.old_share_net[\u0027id\u0027], share[\u0027share_network_id\u0027])"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        if test_type \u003d\u003d \u0027success\u0027:"},{"line_number":189,"context_line":"            self.admin_client.migration_complete(share[\u0027id\u0027])"},{"line_number":190,"context_line":"            statuses \u003d constants.TASK_STATE_MIGRATION_SUCCESS"},{"line_number":191,"context_line":"        elif test_type \u003d\u003d \u0027cancel\u0027:"},{"line_number":192,"context_line":"            self.admin_client.migration_cancel(share[\u0027id\u0027])"},{"line_number":193,"context_line":"            statuses \u003d constants.TASK_STATE_MIGRATION_CANCELLED"},{"line_number":194,"context_line":"        else:"},{"line_number":195,"context_line":"            # Error scenario is complete"},{"line_number":196,"context_line":"            self.assertEqual(statuses, progress[\u0027task_state\u0027])"},{"line_number":197,"context_line":"            return"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        share \u003d self.admin_client.wait_for_migration_status("},{"line_number":200,"context_line":"            share[\u0027id\u0027], dest_pool, statuses)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        progress \u003d self.admin_client.migration_get_progress(share[\u0027id\u0027])"},{"line_number":203,"context_line":"        self.assertEqual(statuses, progress[\u0027task_state\u0027])"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        if test_type \u003d\u003d \u0027success\u0027:"},{"line_number":206,"context_line":"            self.assertEqual(dest_pool, share[\u0027host\u0027])"},{"line_number":207,"context_line":"            self.assertEqual(new_type[\u0027ID\u0027], share[\u0027share_type\u0027])"},{"line_number":208,"context_line":"            self.assertEqual(self.new_share_net[\u0027id\u0027],"},{"line_number":209,"context_line":"                             share[\u0027share_network_id\u0027])"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        else:"},{"line_number":212,"context_line":"            self.assertEqual(source_pool, share[\u0027host\u0027])"},{"line_number":213,"context_line":"            self.assertEqual(self.old_type[\u0027ID\u0027], share[\u0027share_type\u0027])"},{"line_number":214,"context_line":"            self.assertEqual(self.old_share_net[\u0027id\u0027],"},{"line_number":215,"context_line":"                             share[\u0027share_network_id\u0027])"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"class NFSSharesReadWriteTest(SharesReadWriteBase):"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_4de91a1a","line":215,"range":{"start_line":188,"start_character":0,"end_line":215,"end_character":55},"updated":"2017-01-20 00:07:21.000000000","message":"Avoid the return in the test:\n\n         if test_type \u003d\u003d \u0027error\u0027:\n            self.assertEqual(statuses, progress[\u0027task_state\u0027])\n\n         else:\n            if test_type \u003d\u003d \u0027success\u0027:\n\n               self.admin_client.migration_complete(share[\u0027id\u0027])\n               statuses \u003d constants.TASK_STATE_MIGRATION_SUCCESS\n            else test_type \u003d\u003d \u0027cancel\u0027:\n               self.admin_client.migration_cancel(share[\u0027id\u0027])\n               statuses \u003d constants.TASK_STATE_MIGRATION_CANCELLED\n\n\n            share \u003d self.admin_client.wait_for_migration_status(\n                 share[\u0027id\u0027], dest_pool, statuses)\n\n            progress \u003d self.admin_client.migration_get_progress(share[\u0027id\u0027])\n            self.assertEqual(statuses, progress[\u0027task_state\u0027])\n\n            if test_type \u003d\u003d \u0027success\u0027:\n                self.assertEqual(dest_pool, share[\u0027host\u0027])\n                self.assertEqual(new_type[\u0027ID\u0027], share[\u0027share_type\u0027])\n                self.assertEqual(self.new_share_net[\u0027id\u0027],\n                             share[\u0027share_network_id\u0027])\n\n            else:\n               self.assertEqual(source_pool, share[\u0027host\u0027])\n               self.assertEqual(self.old_type[\u0027ID\u0027], share[\u0027share_type\u0027])\n            self.assertEqual(self.old_share_net[\u0027id\u0027],\n                             share[\u0027share_network_id\u0027])","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"18a7d69504fb41007a33ca255731f88f503090c9","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        self.assertEqual(self.old_type[\u0027ID\u0027], share[\u0027share_type\u0027])"},{"line_number":186,"context_line":"        self.assertEqual(self.old_share_net[\u0027id\u0027], share[\u0027share_network_id\u0027])"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        if test_type \u003d\u003d \u0027success\u0027:"},{"line_number":189,"context_line":"            self.admin_client.migration_complete(share[\u0027id\u0027])"},{"line_number":190,"context_line":"            statuses \u003d constants.TASK_STATE_MIGRATION_SUCCESS"},{"line_number":191,"context_line":"        elif test_type \u003d\u003d \u0027cancel\u0027:"},{"line_number":192,"context_line":"            self.admin_client.migration_cancel(share[\u0027id\u0027])"},{"line_number":193,"context_line":"            statuses \u003d constants.TASK_STATE_MIGRATION_CANCELLED"},{"line_number":194,"context_line":"        else:"},{"line_number":195,"context_line":"            # Error scenario is complete"},{"line_number":196,"context_line":"            self.assertEqual(statuses, progress[\u0027task_state\u0027])"},{"line_number":197,"context_line":"            return"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        share \u003d self.admin_client.wait_for_migration_status("},{"line_number":200,"context_line":"            share[\u0027id\u0027], dest_pool, statuses)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        progress \u003d self.admin_client.migration_get_progress(share[\u0027id\u0027])"},{"line_number":203,"context_line":"        self.assertEqual(statuses, progress[\u0027task_state\u0027])"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        if test_type \u003d\u003d \u0027success\u0027:"},{"line_number":206,"context_line":"            self.assertEqual(dest_pool, share[\u0027host\u0027])"},{"line_number":207,"context_line":"            self.assertEqual(new_type[\u0027ID\u0027], share[\u0027share_type\u0027])"},{"line_number":208,"context_line":"            self.assertEqual(self.new_share_net[\u0027id\u0027],"},{"line_number":209,"context_line":"                             share[\u0027share_network_id\u0027])"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        else:"},{"line_number":212,"context_line":"            self.assertEqual(source_pool, share[\u0027host\u0027])"},{"line_number":213,"context_line":"            self.assertEqual(self.old_type[\u0027ID\u0027], share[\u0027share_type\u0027])"},{"line_number":214,"context_line":"            self.assertEqual(self.old_share_net[\u0027id\u0027],"},{"line_number":215,"context_line":"                             share[\u0027share_network_id\u0027])"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"class NFSSharesReadWriteTest(SharesReadWriteBase):"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_5ff44886","line":215,"range":{"start_line":188,"start_character":0,"end_line":215,"end_character":55},"in_reply_to":"5a3905b3_4de91a1a","updated":"2017-01-20 11:54:07.000000000","message":"Done","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"}],"manilaclient/tests/functional/utils.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c07244f7b1b575346f09d95670a032281552e876","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    extra_specs \u003d {}"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    # convert extra-specs in provided type to dict format"},{"line_number":127,"context_line":"    pair \u003d [x.strip() for x in share_type[\u0027required_extra_specs\u0027].split(\u0027:\u0027)]"},{"line_number":128,"context_line":"    if len(pair) \u003d\u003d 2:"},{"line_number":129,"context_line":"        value \u003d (True if six.text_type(pair[1]).lower() \u003d\u003d \u0027true\u0027"},{"line_number":130,"context_line":"                 else False if six.text_type(pair[1]).lower() \u003d\u003d \u0027false\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_8d41420e","line":127,"range":{"start_line":127,"start_character":4,"end_line":127,"end_character":77},"updated":"2017-01-20 00:07:21.000000000","message":"why bother? just get the dhss value.. there are no other required_extra_specs","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"18a7d69504fb41007a33ca255731f88f503090c9","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    extra_specs \u003d {}"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    # convert extra-specs in provided type to dict format"},{"line_number":127,"context_line":"    pair \u003d [x.strip() for x in share_type[\u0027required_extra_specs\u0027].split(\u0027:\u0027)]"},{"line_number":128,"context_line":"    if len(pair) \u003d\u003d 2:"},{"line_number":129,"context_line":"        value \u003d (True if six.text_type(pair[1]).lower() \u003d\u003d \u0027true\u0027"},{"line_number":130,"context_line":"                 else False if six.text_type(pair[1]).lower() \u003d\u003d \u0027false\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_ff5a5482","line":127,"range":{"start_line":127,"start_character":4,"end_line":127,"end_character":77},"in_reply_to":"5a3905b3_8d41420e","updated":"2017-01-20 11:54:07.000000000","message":"indeed, there is no way to get them, the output is messed up, I am doing this only for dhss","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c07244f7b1b575346f09d95670a032281552e876","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    # convert extra-specs in provided type to dict format"},{"line_number":127,"context_line":"    pair \u003d [x.strip() for x in share_type[\u0027required_extra_specs\u0027].split(\u0027:\u0027)]"},{"line_number":128,"context_line":"    if len(pair) \u003d\u003d 2:"},{"line_number":129,"context_line":"        value \u003d (True if six.text_type(pair[1]).lower() \u003d\u003d \u0027true\u0027"},{"line_number":130,"context_line":"                 else False if six.text_type(pair[1]).lower() \u003d\u003d \u0027false\u0027"},{"line_number":131,"context_line":"                 else pair[1])"},{"line_number":132,"context_line":"        extra_specs[pair[0]] \u003d value"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    selected_pool \u003d next("},{"line_number":135,"context_line":"        (x for x in pools if (x[\u0027Name\u0027] !\u003d share[\u0027host\u0027] and all("}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_4d2cba4a","line":132,"range":{"start_line":128,"start_character":0,"end_line":132,"end_character":36},"updated":"2017-01-20 00:07:21.000000000","message":"seems like a wonky way of saying:\n\n  dhss \u003d \u0027driver_handles_share_servers\u0027\n  extra_specs[dhss] \u003d share_type[\u0027required_extra_specs\u0027][dhss]","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"18a7d69504fb41007a33ca255731f88f503090c9","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    # convert extra-specs in provided type to dict format"},{"line_number":127,"context_line":"    pair \u003d [x.strip() for x in share_type[\u0027required_extra_specs\u0027].split(\u0027:\u0027)]"},{"line_number":128,"context_line":"    if len(pair) \u003d\u003d 2:"},{"line_number":129,"context_line":"        value \u003d (True if six.text_type(pair[1]).lower() \u003d\u003d \u0027true\u0027"},{"line_number":130,"context_line":"                 else False if six.text_type(pair[1]).lower() \u003d\u003d \u0027false\u0027"},{"line_number":131,"context_line":"                 else pair[1])"},{"line_number":132,"context_line":"        extra_specs[pair[0]] \u003d value"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    selected_pool \u003d next("},{"line_number":135,"context_line":"        (x for x in pools if (x[\u0027Name\u0027] !\u003d share[\u0027host\u0027] and all("}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_5f69a824","line":132,"range":{"start_line":128,"start_character":0,"end_line":132,"end_character":36},"in_reply_to":"5a3905b3_4d2cba4a","updated":"2017-01-20 11:54:07.000000000","message":"not really, the output parsed is really messed up","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c07244f7b1b575346f09d95670a032281552e876","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    selected_pool \u003d next("},{"line_number":135,"context_line":"        (x for x in pools if (x[\u0027Name\u0027] !\u003d share[\u0027host\u0027] and all("},{"line_number":136,"context_line":"            y in ast.literal_eval(x[\u0027Capabilities\u0027]).items() for y in"},{"line_number":137,"context_line":"            extra_specs.items()))),"},{"line_number":138,"context_line":"        None)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    return selected_pool[\u0027Name\u0027]"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_2d012eaf","line":137,"range":{"start_line":136,"start_character":65,"end_line":137,"end_character":31},"updated":"2017-01-20 00:07:21.000000000","message":"you\u0027ll only have one key..","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"18a7d69504fb41007a33ca255731f88f503090c9","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    selected_pool \u003d next("},{"line_number":135,"context_line":"        (x for x in pools if (x[\u0027Name\u0027] !\u003d share[\u0027host\u0027] and all("},{"line_number":136,"context_line":"            y in ast.literal_eval(x[\u0027Capabilities\u0027]).items() for y in"},{"line_number":137,"context_line":"            extra_specs.items()))),"},{"line_number":138,"context_line":"        None)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    return selected_pool[\u0027Name\u0027]"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_9f4a30ab","line":137,"range":{"start_line":136,"start_character":65,"end_line":137,"end_character":31},"in_reply_to":"5a3905b3_2d012eaf","updated":"2017-01-20 11:54:07.000000000","message":"future proof code :P","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"}],"manilaclient/tests/unit/v2/test_shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c07244f7b1b575346f09d95670a032281552e876","unresolved":false,"context_lines":[{"line_number":561,"context_line":"        with mock.patch.object(manager, \"_action\","},{"line_number":562,"context_line":"                               mock.Mock(return_value\u003d\"fake\")):"},{"line_number":563,"context_line":"            result \u003d manager.migration_start("},{"line_number":564,"context_line":"                share, host, True, True, True, False, True)"},{"line_number":565,"context_line":"            manager._action.assert_called_once_with("},{"line_number":566,"context_line":"                \u0027migration_start\u0027, share, {"},{"line_number":567,"context_line":"                    \"host\": host,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_ad2b5e2f","line":564,"range":{"start_line":564,"start_character":28,"end_line":564,"end_character":58},"updated":"2017-01-20 00:07:21.000000000","message":"please make em kwargs..","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"18a7d69504fb41007a33ca255731f88f503090c9","unresolved":false,"context_lines":[{"line_number":561,"context_line":"        with mock.patch.object(manager, \"_action\","},{"line_number":562,"context_line":"                               mock.Mock(return_value\u003d\"fake\")):"},{"line_number":563,"context_line":"            result \u003d manager.migration_start("},{"line_number":564,"context_line":"                share, host, True, True, True, False, True)"},{"line_number":565,"context_line":"            manager._action.assert_called_once_with("},{"line_number":566,"context_line":"                \u0027migration_start\u0027, share, {"},{"line_number":567,"context_line":"                    \"host\": host,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_52927fa0","line":564,"range":{"start_line":564,"start_character":28,"end_line":564,"end_character":58},"in_reply_to":"5a3905b3_ad2b5e2f","updated":"2017-01-20 11:54:07.000000000","message":"Done","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"}],"manilaclient/tests/unit/v2/test_shell.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"75e3678d75213ee6c121443b84b03172384865fd","unresolved":false,"context_lines":[{"line_number":1949,"context_line":"    def test_migration_start(self):"},{"line_number":1950,"context_line":"        command \u003d (\"migration-start --force-host-assisted-migration True \""},{"line_number":1951,"context_line":"                   \"--new-share-network 1111 --new-share-type 1 1234 \""},{"line_number":1952,"context_line":"                   \"host@backend#pool writable\u003dFalse nondisruptive\u003dTrue \""},{"line_number":1953,"context_line":"                   \"preserve-metadata\u003dFalse preserve-snapshots\u003dTrue\")"},{"line_number":1954,"context_line":"        self.run_command(command)"},{"line_number":1955,"context_line":"        expected \u003d {\u0027migration_start\u0027: {"},{"line_number":1956,"context_line":"            \u0027host\u0027: \u0027host@backend#pool\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_d7ee1a21","line":1953,"range":{"start_line":1952,"start_character":38,"end_line":1953,"end_character":67},"updated":"2016-12-12 06:11:27.000000000","message":"should cover the situation that these parameters passed by the -- ways, such as \"--writable False\"","commit_id":"f3f081bada600a3978866005241bc20d5ab00fa3"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"75e3678d75213ee6c121443b84b03172384865fd","unresolved":false,"context_lines":[{"line_number":739,"context_line":"    options \u003d _extract_key_value_options(args, \u0027options\u0027)"},{"line_number":740,"context_line":"    _validate_migration_options(options)"},{"line_number":741,"context_line":"    share.migration_start(args.host, args.force_host_assisted_migration,"},{"line_number":742,"context_line":"                          options[\u0027preserve-metadata\u0027], options[\u0027writable\u0027],"},{"line_number":743,"context_line":"                          options[\u0027nondisruptive\u0027],"},{"line_number":744,"context_line":"                          options[\u0027preserve-snapshots\u0027], new_share_net_id,"},{"line_number":745,"context_line":"                          new_share_type_id)"},{"line_number":746,"context_line":""},{"line_number":747,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_d787fa5e","line":744,"range":{"start_line":742,"start_character":26,"end_line":744,"end_character":55},"updated":"2016-12-12 06:11:27.000000000","message":"does this mean the parameters passed by --preserve-metadata or --nondisruptive will never be used?\nwhat\u0027s the relationship between parameter \"options\" and the individual parameter \"--preserve-metadata, --preserve-snapshots, --writable, --nondisruptive\"?","commit_id":"f3f081bada600a3978866005241bc20d5ab00fa3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c07244f7b1b575346f09d95670a032281552e876","unresolved":false,"context_lines":[{"line_number":681,"context_line":"    choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":682,"context_line":"    required\u003dTrue,"},{"line_number":683,"context_line":"    help\u003d\"Enforces migration to preserve all file metadata when moving its \""},{"line_number":684,"context_line":"         \"contents. If set so, this will prevent the use of the Data Service \""},{"line_number":685,"context_line":"         \"for migration.\")"},{"line_number":686,"context_line":"@cliutils.arg("},{"line_number":687,"context_line":"    \u0027--preserve-snapshots\u0027,"},{"line_number":688,"context_line":"    \u0027--preserve_snapshots\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_4da11aa9","line":685,"range":{"start_line":684,"start_character":20,"end_line":685,"end_character":24},"updated":"2017-01-20 00:07:21.000000000","message":"Abstract this information away... the API refers to this as \"host assisted migration\", let\u0027s treat it likewise here:\n\nIf set to True, host assisted migration will not be attempted.","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"18a7d69504fb41007a33ca255731f88f503090c9","unresolved":false,"context_lines":[{"line_number":681,"context_line":"    choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":682,"context_line":"    required\u003dTrue,"},{"line_number":683,"context_line":"    help\u003d\"Enforces migration to preserve all file metadata when moving its \""},{"line_number":684,"context_line":"         \"contents. If set so, this will prevent the use of the Data Service \""},{"line_number":685,"context_line":"         \"for migration.\")"},{"line_number":686,"context_line":"@cliutils.arg("},{"line_number":687,"context_line":"    \u0027--preserve-snapshots\u0027,"},{"line_number":688,"context_line":"    \u0027--preserve_snapshots\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_32fa53be","line":685,"range":{"start_line":684,"start_character":20,"end_line":685,"end_character":24},"in_reply_to":"5a3905b3_4da11aa9","updated":"2017-01-20 11:54:07.000000000","message":"Done","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c07244f7b1b575346f09d95670a032281552e876","unresolved":false,"context_lines":[{"line_number":690,"context_line":"    metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":691,"context_line":"    choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":692,"context_line":"    required\u003dTrue,"},{"line_number":693,"context_line":"    help\u003d\"Enforces migration to move all existing share snapshots to the \""},{"line_number":694,"context_line":"         \"destination. If set so, this will prevent the use of the \""},{"line_number":695,"context_line":"         \"Data Service for migration.\")"},{"line_number":696,"context_line":"@cliutils.arg("}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_8d8222ff","line":693,"range":{"start_line":693,"start_character":29,"end_line":693,"end_character":65},"updated":"2017-01-20 00:07:21.000000000","message":"of the share snapshots","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"18a7d69504fb41007a33ca255731f88f503090c9","unresolved":false,"context_lines":[{"line_number":690,"context_line":"    metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":691,"context_line":"    choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":692,"context_line":"    required\u003dTrue,"},{"line_number":693,"context_line":"    help\u003d\"Enforces migration to move all existing share snapshots to the \""},{"line_number":694,"context_line":"         \"destination. If set so, this will prevent the use of the \""},{"line_number":695,"context_line":"         \"Data Service for migration.\")"},{"line_number":696,"context_line":"@cliutils.arg("}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_f29feb00","line":693,"range":{"start_line":693,"start_character":29,"end_line":693,"end_character":65},"in_reply_to":"5a3905b3_8d8222ff","updated":"2017-01-20 11:54:07.000000000","message":"Done","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c07244f7b1b575346f09d95670a032281552e876","unresolved":false,"context_lines":[{"line_number":691,"context_line":"    choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":692,"context_line":"    required\u003dTrue,"},{"line_number":693,"context_line":"    help\u003d\"Enforces migration to move all existing share snapshots to the \""},{"line_number":694,"context_line":"         \"destination. If set so, this will prevent the use of the \""},{"line_number":695,"context_line":"         \"Data Service for migration.\")"},{"line_number":696,"context_line":"@cliutils.arg("},{"line_number":697,"context_line":"    \u0027--writable\u0027,"},{"line_number":698,"context_line":"    metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_8dab0289","line":695,"range":{"start_line":694,"start_character":23,"end_line":695,"end_character":37},"updated":"2017-01-20 00:07:21.000000000","message":"same","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"18a7d69504fb41007a33ca255731f88f503090c9","unresolved":false,"context_lines":[{"line_number":691,"context_line":"    choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":692,"context_line":"    required\u003dTrue,"},{"line_number":693,"context_line":"    help\u003d\"Enforces migration to move all existing share snapshots to the \""},{"line_number":694,"context_line":"         \"destination. If set so, this will prevent the use of the \""},{"line_number":695,"context_line":"         \"Data Service for migration.\")"},{"line_number":696,"context_line":"@cliutils.arg("},{"line_number":697,"context_line":"    \u0027--writable\u0027,"},{"line_number":698,"context_line":"    metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_3221734e","line":695,"range":{"start_line":694,"start_character":23,"end_line":695,"end_character":37},"in_reply_to":"5a3905b3_8dab0289","updated":"2017-01-20 11:54:07.000000000","message":"Done","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c07244f7b1b575346f09d95670a032281552e876","unresolved":false,"context_lines":[{"line_number":699,"context_line":"    choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":700,"context_line":"    required\u003dTrue,"},{"line_number":701,"context_line":"    help\u003d\"Enforces migration to keep the share writable while contents are \""},{"line_number":702,"context_line":"         \"being moved. If set so, this will prevent the use of the \""},{"line_number":703,"context_line":"         \"Data Service for migration.\")"},{"line_number":704,"context_line":"@cliutils.arg("},{"line_number":705,"context_line":"    \u0027--nondisruptive\u0027,"},{"line_number":706,"context_line":"    metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_adb0bef5","line":703,"range":{"start_line":702,"start_character":23,"end_line":703,"end_character":37},"updated":"2017-01-20 00:07:21.000000000","message":"same","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"18a7d69504fb41007a33ca255731f88f503090c9","unresolved":false,"context_lines":[{"line_number":699,"context_line":"    choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":700,"context_line":"    required\u003dTrue,"},{"line_number":701,"context_line":"    help\u003d\"Enforces migration to keep the share writable while contents are \""},{"line_number":702,"context_line":"         \"being moved. If set so, this will prevent the use of the \""},{"line_number":703,"context_line":"         \"Data Service for migration.\")"},{"line_number":704,"context_line":"@cliutils.arg("},{"line_number":705,"context_line":"    \u0027--nondisruptive\u0027,"},{"line_number":706,"context_line":"    metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_d2d66f26","line":703,"range":{"start_line":702,"start_character":23,"end_line":703,"end_character":37},"in_reply_to":"5a3905b3_adb0bef5","updated":"2017-01-20 11:54:07.000000000","message":"Done","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c07244f7b1b575346f09d95670a032281552e876","unresolved":false,"context_lines":[{"line_number":706,"context_line":"    metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":707,"context_line":"    choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":708,"context_line":"    required\u003dTrue,"},{"line_number":709,"context_line":"    help\u003d\"Enforces migration to be nondisruptive, thus not disconnecting any \""},{"line_number":710,"context_line":"         \"connected clients. If set so, this will prevent the use of the \""},{"line_number":711,"context_line":"         \"Data Service for migration.\")"},{"line_number":712,"context_line":"@cliutils.arg("},{"line_number":713,"context_line":"    \u0027--new_share_network\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_ad9efe53","line":710,"range":{"start_line":709,"start_character":48,"end_line":710,"end_character":27},"updated":"2017-01-20 00:07:21.000000000","message":"writable also doesn\u0027t disconnect clients. we can remove this.","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"18a7d69504fb41007a33ca255731f88f503090c9","unresolved":false,"context_lines":[{"line_number":706,"context_line":"    metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":707,"context_line":"    choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":708,"context_line":"    required\u003dTrue,"},{"line_number":709,"context_line":"    help\u003d\"Enforces migration to be nondisruptive, thus not disconnecting any \""},{"line_number":710,"context_line":"         \"connected clients. If set so, this will prevent the use of the \""},{"line_number":711,"context_line":"         \"Data Service for migration.\")"},{"line_number":712,"context_line":"@cliutils.arg("},{"line_number":713,"context_line":"    \u0027--new_share_network\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_327893c4","line":710,"range":{"start_line":709,"start_character":48,"end_line":710,"end_character":27},"in_reply_to":"5a3905b3_ad9efe53","updated":"2017-01-20 11:54:07.000000000","message":"Done","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c07244f7b1b575346f09d95670a032281552e876","unresolved":false,"context_lines":[{"line_number":715,"context_line":"    metavar\u003d\u0027\u003cnew_share_network\u003e\u0027,"},{"line_number":716,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":717,"context_line":"    required\u003dFalse,"},{"line_number":718,"context_line":"    help\u003d\u0027Input the new share network where the share should be migrated to \u0027"},{"line_number":719,"context_line":"         \u0027if you would like to change it. Default\u003dNone.\u0027,"},{"line_number":720,"context_line":"    default\u003dNone)"},{"line_number":721,"context_line":"@cliutils.arg("},{"line_number":722,"context_line":"    \u0027--new_share_type\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_2dabee75","line":719,"range":{"start_line":718,"start_character":10,"end_line":719,"end_character":55},"updated":"2017-01-20 00:07:21.000000000","message":"Specify the new share network for the share. Default\u003dNone (retaining the share within the same share network).","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c07244f7b1b575346f09d95670a032281552e876","unresolved":false,"context_lines":[{"line_number":715,"context_line":"    metavar\u003d\u0027\u003cnew_share_network\u003e\u0027,"},{"line_number":716,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":717,"context_line":"    required\u003dFalse,"},{"line_number":718,"context_line":"    help\u003d\u0027Input the new share network where the share should be migrated to \u0027"},{"line_number":719,"context_line":"         \u0027if you would like to change it. Default\u003dNone.\u0027,"},{"line_number":720,"context_line":"    default\u003dNone)"},{"line_number":721,"context_line":"@cliutils.arg("},{"line_number":722,"context_line":"    \u0027--new_share_type\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_ad88bee8","line":719,"range":{"start_line":718,"start_character":10,"end_line":719,"end_character":55},"updated":"2017-01-20 00:07:21.000000000","message":"Specify the new share network for the share. Do not specify this parameter if the migrating share has to be retained within its current share network.","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"18a7d69504fb41007a33ca255731f88f503090c9","unresolved":false,"context_lines":[{"line_number":715,"context_line":"    metavar\u003d\u0027\u003cnew_share_network\u003e\u0027,"},{"line_number":716,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":717,"context_line":"    required\u003dFalse,"},{"line_number":718,"context_line":"    help\u003d\u0027Input the new share network where the share should be migrated to \u0027"},{"line_number":719,"context_line":"         \u0027if you would like to change it. Default\u003dNone.\u0027,"},{"line_number":720,"context_line":"    default\u003dNone)"},{"line_number":721,"context_line":"@cliutils.arg("},{"line_number":722,"context_line":"    \u0027--new_share_type\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_525a7f51","line":719,"range":{"start_line":718,"start_character":10,"end_line":719,"end_character":55},"in_reply_to":"5a3905b3_2dabee75","updated":"2017-01-20 11:54:07.000000000","message":"Done","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"18a7d69504fb41007a33ca255731f88f503090c9","unresolved":false,"context_lines":[{"line_number":715,"context_line":"    metavar\u003d\u0027\u003cnew_share_network\u003e\u0027,"},{"line_number":716,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":717,"context_line":"    required\u003dFalse,"},{"line_number":718,"context_line":"    help\u003d\u0027Input the new share network where the share should be migrated to \u0027"},{"line_number":719,"context_line":"         \u0027if you would like to change it. Default\u003dNone.\u0027,"},{"line_number":720,"context_line":"    default\u003dNone)"},{"line_number":721,"context_line":"@cliutils.arg("},{"line_number":722,"context_line":"    \u0027--new_share_type\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_325fb342","line":719,"range":{"start_line":718,"start_character":10,"end_line":719,"end_character":55},"in_reply_to":"5a3905b3_ad88bee8","updated":"2017-01-20 11:54:07.000000000","message":"Done","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c07244f7b1b575346f09d95670a032281552e876","unresolved":false,"context_lines":[{"line_number":724,"context_line":"    metavar\u003d\u0027\u003cnew_share_type\u003e\u0027,"},{"line_number":725,"context_line":"    required\u003dFalse,"},{"line_number":726,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":727,"context_line":"    help\u003d\u0027Input the new share type which the migrating share will be set to \u0027"},{"line_number":728,"context_line":"         \u0027if you would like to change the type. Default\u003dNone.\u0027,"},{"line_number":729,"context_line":"    default\u003dNone)"},{"line_number":730,"context_line":"def do_migration_start(cs, args):"},{"line_number":731,"context_line":"    \"\"\"Migrates share to a new host (Admin only, Experimental).\"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_6dbb36c5","line":728,"range":{"start_line":727,"start_character":10,"end_line":728,"end_character":61},"updated":"2017-01-20 00:07:21.000000000","message":"Specify the new share type for the share. Default\u003dNone (will retain the share with the same type).","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c07244f7b1b575346f09d95670a032281552e876","unresolved":false,"context_lines":[{"line_number":724,"context_line":"    metavar\u003d\u0027\u003cnew_share_type\u003e\u0027,"},{"line_number":725,"context_line":"    required\u003dFalse,"},{"line_number":726,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":727,"context_line":"    help\u003d\u0027Input the new share type which the migrating share will be set to \u0027"},{"line_number":728,"context_line":"         \u0027if you would like to change the type. Default\u003dNone.\u0027,"},{"line_number":729,"context_line":"    default\u003dNone)"},{"line_number":730,"context_line":"def do_migration_start(cs, args):"},{"line_number":731,"context_line":"    \"\"\"Migrates share to a new host (Admin only, Experimental).\"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_8d8302cc","line":728,"range":{"start_line":727,"start_character":10,"end_line":728,"end_character":60},"updated":"2017-01-20 00:07:21.000000000","message":"Specify the new share type for the share. Do not specify this parameter if the migrating share has to be retained with its current share type.","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"18a7d69504fb41007a33ca255731f88f503090c9","unresolved":false,"context_lines":[{"line_number":724,"context_line":"    metavar\u003d\u0027\u003cnew_share_type\u003e\u0027,"},{"line_number":725,"context_line":"    required\u003dFalse,"},{"line_number":726,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":727,"context_line":"    help\u003d\u0027Input the new share type which the migrating share will be set to \u0027"},{"line_number":728,"context_line":"         \u0027if you would like to change the type. Default\u003dNone.\u0027,"},{"line_number":729,"context_line":"    default\u003dNone)"},{"line_number":730,"context_line":"def do_migration_start(cs, args):"},{"line_number":731,"context_line":"    \"\"\"Migrates share to a new host (Admin only, Experimental).\"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_320df33e","line":728,"range":{"start_line":727,"start_character":10,"end_line":728,"end_character":61},"in_reply_to":"5a3905b3_6dbb36c5","updated":"2017-01-20 11:54:07.000000000","message":"Done","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"18a7d69504fb41007a33ca255731f88f503090c9","unresolved":false,"context_lines":[{"line_number":724,"context_line":"    metavar\u003d\u0027\u003cnew_share_type\u003e\u0027,"},{"line_number":725,"context_line":"    required\u003dFalse,"},{"line_number":726,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":727,"context_line":"    help\u003d\u0027Input the new share type which the migrating share will be set to \u0027"},{"line_number":728,"context_line":"         \u0027if you would like to change the type. Default\u003dNone.\u0027,"},{"line_number":729,"context_line":"    default\u003dNone)"},{"line_number":730,"context_line":"def do_migration_start(cs, args):"},{"line_number":731,"context_line":"    \"\"\"Migrates share to a new host (Admin only, Experimental).\"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_5208bf2d","line":728,"range":{"start_line":727,"start_character":10,"end_line":728,"end_character":60},"in_reply_to":"5a3905b3_8d8302cc","updated":"2017-01-20 11:54:07.000000000","message":"Done","commit_id":"f5ab662d9c84f992b76b1729294e63c2ec83591a"}]}