)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"9299818548c00e57295f525a8156d7bc2292e54b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     yanjun.fu \u003cyanjun.fu@easystack.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-13 18:23:36 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix bug 1647781 that \u003cis\u003e true or false can\u0027t use"},{"line_number":8,"context_line":"All boolean extra specs in manila can accept \u003cis\u003e operator to match extra-specs."},{"line_number":9,"context_line":"However, the DHSS value and snapshot_support cannot be set to \u003cis\u003e True or \u003cis\u003e False."},{"line_number":10,"context_line":"The most direct way is to modify oslo.utils.strutils.py,but it would create a bad"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a6eadb0_39317ea3","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":15},"updated":"2016-12-13 10:50:43.000000000","message":"no need to state this in the title, it is included in \"Closes-bug\"","commit_id":"c46952009684cd7c619e3b81c76ebcd33ec01bc6"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"9299818548c00e57295f525a8156d7bc2292e54b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     yanjun.fu \u003cyanjun.fu@easystack.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-13 18:23:36 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix bug 1647781 that \u003cis\u003e true or false can\u0027t use"},{"line_number":8,"context_line":"All boolean extra specs in manila can accept \u003cis\u003e operator to match extra-specs."},{"line_number":9,"context_line":"However, the DHSS value and snapshot_support cannot be set to \u003cis\u003e True or \u003cis\u003e False."},{"line_number":10,"context_line":"The most direct way is to modify oslo.utils.strutils.py,but it would create a bad"},{"line_number":11,"context_line":"impression,so i just change manila-client"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a6eadb0_99f9b2cb","line":8,"range":{"start_line":7,"start_character":46,"end_line":8,"end_character":3},"updated":"2016-12-13 10:50:43.000000000","message":"You need to skip a line between the commit message title and commit message description","commit_id":"c46952009684cd7c619e3b81c76ebcd33ec01bc6"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"9299818548c00e57295f525a8156d7bc2292e54b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-12-13 18:23:36 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix bug 1647781 that \u003cis\u003e true or false can\u0027t use"},{"line_number":8,"context_line":"All boolean extra specs in manila can accept \u003cis\u003e operator to match extra-specs."},{"line_number":9,"context_line":"However, the DHSS value and snapshot_support cannot be set to \u003cis\u003e True or \u003cis\u003e False."},{"line_number":10,"context_line":"The most direct way is to modify oslo.utils.strutils.py,but it would create a bad"},{"line_number":11,"context_line":"impression,so i just change manila-client"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Id610aeafc2a17a835a632bdd0379b2a1b51ce1db"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a6eadb0_79b056f5","line":10,"range":{"start_line":8,"start_character":68,"end_line":10,"end_character":81},"updated":"2016-12-13 10:50:43.000000000","message":"don\u0027t go beyond 79 chars. For the commit message you shouldn\u0027t go beyond 69.","commit_id":"c46952009684cd7c619e3b81c76ebcd33ec01bc6"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"9299818548c00e57295f525a8156d7bc2292e54b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix bug 1647781 that \u003cis\u003e true or false can\u0027t use"},{"line_number":8,"context_line":"All boolean extra specs in manila can accept \u003cis\u003e operator to match extra-specs."},{"line_number":9,"context_line":"However, the DHSS value and snapshot_support cannot be set to \u003cis\u003e True or \u003cis\u003e False."},{"line_number":10,"context_line":"The most direct way is to modify oslo.utils.strutils.py,but it would create a bad"},{"line_number":11,"context_line":"impression,so i just change manila-client"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Id610aeafc2a17a835a632bdd0379b2a1b51ce1db"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a6eadb0_19884222","line":10,"range":{"start_line":10,"start_character":55,"end_line":10,"end_character":57},"updated":"2016-12-13 10:50:43.000000000","message":"space after comma","commit_id":"c46952009684cd7c619e3b81c76ebcd33ec01bc6"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"9299818548c00e57295f525a8156d7bc2292e54b","unresolved":false,"context_lines":[{"line_number":8,"context_line":"All boolean extra specs in manila can accept \u003cis\u003e operator to match extra-specs."},{"line_number":9,"context_line":"However, the DHSS value and snapshot_support cannot be set to \u003cis\u003e True or \u003cis\u003e False."},{"line_number":10,"context_line":"The most direct way is to modify oslo.utils.strutils.py,but it would create a bad"},{"line_number":11,"context_line":"impression,so i just change manila-client"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Id610aeafc2a17a835a632bdd0379b2a1b51ce1db"},{"line_number":14,"context_line":"Close-Bug: #1647781"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a6eadb0_b9790e32","line":11,"range":{"start_line":11,"start_character":40,"end_line":11,"end_character":41},"updated":"2016-12-13 10:50:43.000000000","message":"period","commit_id":"c46952009684cd7c619e3b81c76ebcd33ec01bc6"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"9299818548c00e57295f525a8156d7bc2292e54b","unresolved":false,"context_lines":[{"line_number":8,"context_line":"All boolean extra specs in manila can accept \u003cis\u003e operator to match extra-specs."},{"line_number":9,"context_line":"However, the DHSS value and snapshot_support cannot be set to \u003cis\u003e True or \u003cis\u003e False."},{"line_number":10,"context_line":"The most direct way is to modify oslo.utils.strutils.py,but it would create a bad"},{"line_number":11,"context_line":"impression,so i just change manila-client"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Id610aeafc2a17a835a632bdd0379b2a1b51ce1db"},{"line_number":14,"context_line":"Close-Bug: #1647781"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a6eadb0_7987760f","line":11,"range":{"start_line":11,"start_character":10,"end_line":11,"end_character":11},"updated":"2016-12-13 10:50:43.000000000","message":"space after comma","commit_id":"c46952009684cd7c619e3b81c76ebcd33ec01bc6"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"9299818548c00e57295f525a8156d7bc2292e54b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"impression,so i just change manila-client"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Id610aeafc2a17a835a632bdd0379b2a1b51ce1db"},{"line_number":14,"context_line":"Close-Bug: #1647781"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a6eadb0_b9e4ae0d","line":14,"range":{"start_line":14,"start_character":1,"end_line":14,"end_character":9},"updated":"2016-12-13 10:50:43.000000000","message":"the correct is \"Closes-Bug\", so launchpad will post to the bug entry automatically","commit_id":"c46952009684cd7c619e3b81c76ebcd33ec01bc6"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"9f5f8a123302a6cee42d1b93b47aed30ec385d67","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix manila share-type that \u003cis\u003e true or false can\u0027t use"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"All boolean extra specs in manila can accept \u003cis\u003e operator to match extra-specs."},{"line_number":10,"context_line":" However, the DHSS value and snapshot_support cannot be set to \u003cis\u003e True or \u003cis\u003e False."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id610aeafc2a17a835a632bdd0379b2a1b51ce1db"},{"line_number":13,"context_line":"Closes-Bug: #1647781"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a6eadb0_e7d1f8ce","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":87},"updated":"2016-12-14 04:42:28.000000000","message":"line length can\u0027t exceed 72 charactors.","commit_id":"201faaa8f7d10e0973f6894aacfc775c2916bb91"},{"author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"change_message_id":"db9319c7b3e5de91bdd4a57126c676f915ee416a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix manila share-type that \u003cis\u003e true or false can\u0027t use"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"All boolean extra specs in manila can accept \u003cis\u003e operator to match extra-specs."},{"line_number":10,"context_line":" However, the DHSS value and snapshot_support cannot be set to \u003cis\u003e True or \u003cis\u003e False."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id610aeafc2a17a835a632bdd0379b2a1b51ce1db"},{"line_number":13,"context_line":"Closes-Bug: #1647781"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1a6eadb0_146a8eb3","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":4},"updated":"2016-12-14 11:24:30.000000000","message":"This space should be removed.","commit_id":"873d09b4237431240dc02211157704433e6cf60d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1c75276acf2302161d43f2ef28df6926f21e57ae","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     yanjun.fu \u003cyanjun.fu@easystack.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-14 20:06:10 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix manila share-type that \u003cis\u003e true or false can\u0027t use"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"All boolean extra specs in manila can accept \u003cis\u003e operator"},{"line_number":10,"context_line":"to match extra-specs. However, the DHSS value and snapshot_support"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1a6eadb0_c5b80678","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":55},"updated":"2016-12-16 13:30:34.000000000","message":"suggest saying:\n\nAllow use of \u003cis\u003e True and \u003cis\u003e False with DHSS and snapshot support","commit_id":"090f811d50d7e2dc84d69b4bdec13b09175f7c78"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1c75276acf2302161d43f2ef28df6926f21e57ae","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix manila share-type that \u003cis\u003e true or false can\u0027t use"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"All boolean extra specs in manila can accept \u003cis\u003e operator"},{"line_number":10,"context_line":"to match extra-specs. However, the DHSS value and snapshot_support"},{"line_number":11,"context_line":"cannot be set to \u003cis\u003e True or \u003cis\u003e False."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Id610aeafc2a17a835a632bdd0379b2a1b51ce1db"},{"line_number":14,"context_line":"Closes-Bug: #1647781"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1a6eadb0_457cf6b4","line":11,"range":{"start_line":10,"start_character":22,"end_line":11,"end_character":41},"updated":"2016-12-16 13:30:34.000000000","message":"Required extra-specs \u0027driver_handles_share_servers\u0027 and \u0027snapshot_support\u0027\nmust also support this format.","commit_id":"090f811d50d7e2dc84d69b4bdec13b09175f7c78"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"9299818548c00e57295f525a8156d7bc2292e54b","unresolved":false,"context_lines":[{"line_number":271,"context_line":"            else:"},{"line_number":272,"context_line":"                key \u003d option"},{"line_number":273,"context_line":"                value \u003d None"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"            if key not in result_dict:"},{"line_number":276,"context_line":"                result_dict[key] \u003d value"},{"line_number":277,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_39bb3ec6","side":"PARENT","line":274,"updated":"2016-12-13 10:50:43.000000000","message":"no need to remove this line","commit_id":"7778b8ba78ebb025768bcb080f989c59b36c0397"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"9299818548c00e57295f525a8156d7bc2292e54b","unresolved":false,"context_lines":[{"line_number":2868,"context_line":"    \u0027spec_driver_handles_share_servers\u0027,"},{"line_number":2869,"context_line":"    metavar\u003d\u0027\u003cspec_driver_handles_share_servers\u003e\u0027,"},{"line_number":2870,"context_line":"    type\u003dstr,"},{"line_number":2871,"context_line":"    help\u003d\"Required extra specification.Valid values are \""},{"line_number":2872,"context_line":"         \"\u0027true\u0027/\u00271\u0027/\u0027\u003cis\u003e true\u0027 and \u0027false\u0027/\u00270\u0027/\u0027\u003cis\u003e false\u0027\")"},{"line_number":2873,"context_line":"@cliutils.arg("},{"line_number":2874,"context_line":"    \u0027--snapshot_support\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_99ca924e","line":2871,"range":{"start_line":2871,"start_character":38,"end_line":2871,"end_character":40},"updated":"2016-12-13 10:50:43.000000000","message":"space after period","commit_id":"c46952009684cd7c619e3b81c76ebcd33ec01bc6"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"9299818548c00e57295f525a8156d7bc2292e54b","unresolved":false,"context_lines":[{"line_number":2876,"context_line":"    metavar\u003d\u0027\u003csnapshot_support\u003e\u0027,"},{"line_number":2877,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":2878,"context_line":"    help\u003d\"Boolean extra spec that used for filtering of back ends by their\""},{"line_number":2879,"context_line":"         \"capability to create share snapshots. (Default is True).Valid\""},{"line_number":2880,"context_line":"         \"values are \u0027true\u0027/\u00271\u0027/\u0027\u003cis\u003e true\u0027 and \u0027false\u0027/\u00270\u0027/\u0027\u003cis\u003e false\u0027\")"},{"line_number":2881,"context_line":"@cliutils.arg("},{"line_number":2882,"context_line":"    \u0027--extra-specs\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_99d1b2fe","line":2879,"range":{"start_line":2879,"start_character":65,"end_line":2879,"end_character":67},"updated":"2016-12-13 10:50:43.000000000","message":"space after period","commit_id":"c46952009684cd7c619e3b81c76ebcd33ec01bc6"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"9299818548c00e57295f525a8156d7bc2292e54b","unresolved":false,"context_lines":[{"line_number":2902,"context_line":"        \"name\": args.name,"},{"line_number":2903,"context_line":"        \"is_public\": strutils.bool_from_string(args.is_public, default\u003dTrue),"},{"line_number":2904,"context_line":"    }"},{"line_number":2905,"context_line":"    if (args.spec_driver_handles_share_servers.strip().lower().\\"},{"line_number":2906,"context_line":"                                          find(\u0027\u003cis\u003e\u0027) \u003d\u003d -1):"},{"line_number":2907,"context_line":"        spec_driver_handles_share_servers \u003d ("},{"line_number":2908,"context_line":"                           args.spec_driver_handles_share_servers)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_d9208afa","line":2905,"range":{"start_line":2905,"start_character":62,"end_line":2905,"end_character":64},"updated":"2016-12-13 10:50:43.000000000","message":"don\u0027t use backlashes, surround your statement in parenthesis instead","commit_id":"c46952009684cd7c619e3b81c76ebcd33ec01bc6"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"9299818548c00e57295f525a8156d7bc2292e54b","unresolved":false,"context_lines":[{"line_number":2902,"context_line":"        \"name\": args.name,"},{"line_number":2903,"context_line":"        \"is_public\": strutils.bool_from_string(args.is_public, default\u003dTrue),"},{"line_number":2904,"context_line":"    }"},{"line_number":2905,"context_line":"    if (args.spec_driver_handles_share_servers.strip().lower().\\"},{"line_number":2906,"context_line":"                                          find(\u0027\u003cis\u003e\u0027) \u003d\u003d -1):"},{"line_number":2907,"context_line":"        spec_driver_handles_share_servers \u003d ("},{"line_number":2908,"context_line":"                           args.spec_driver_handles_share_servers)"},{"line_number":2909,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_3965fe44","line":2906,"range":{"start_line":2905,"start_character":9,"end_line":2906,"end_character":62},"updated":"2016-12-13 10:50:43.000000000","message":"you could have used \"not in\" here","commit_id":"c46952009684cd7c619e3b81c76ebcd33ec01bc6"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"9299818548c00e57295f525a8156d7bc2292e54b","unresolved":false,"context_lines":[{"line_number":2908,"context_line":"                           args.spec_driver_handles_share_servers)"},{"line_number":2909,"context_line":"    else:"},{"line_number":2910,"context_line":"        spec_driver_handles_share_servers \u003d ("},{"line_number":2911,"context_line":"                           args.spec_driver_handles_share_servers.trip()\\"},{"line_number":2912,"context_line":"                           .lower().split(\u0027\u003cis\u003e\u0027)[1])"},{"line_number":2913,"context_line":"    try:"},{"line_number":2914,"context_line":"        kwargs[\u0027spec_driver_handles_share_servers\u0027] \u003d ("}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_9902923d","line":2911,"range":{"start_line":2911,"start_character":65,"end_line":2911,"end_character":67},"updated":"2016-12-13 10:50:43.000000000","message":"I am unfamiliar with \"trip\", shouldn\u0027t this be \"strip()\"?","commit_id":"c46952009684cd7c619e3b81c76ebcd33ec01bc6"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"9299818548c00e57295f525a8156d7bc2292e54b","unresolved":false,"context_lines":[{"line_number":2908,"context_line":"                           args.spec_driver_handles_share_servers)"},{"line_number":2909,"context_line":"    else:"},{"line_number":2910,"context_line":"        spec_driver_handles_share_servers \u003d ("},{"line_number":2911,"context_line":"                           args.spec_driver_handles_share_servers.trip()\\"},{"line_number":2912,"context_line":"                           .lower().split(\u0027\u003cis\u003e\u0027)[1])"},{"line_number":2913,"context_line":"    try:"},{"line_number":2914,"context_line":"        kwargs[\u0027spec_driver_handles_share_servers\u0027] \u003d ("}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_59839acc","line":2911,"range":{"start_line":2911,"start_character":71,"end_line":2911,"end_character":73},"updated":"2016-12-13 10:50:43.000000000","message":"same as above","commit_id":"c46952009684cd7c619e3b81c76ebcd33ec01bc6"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"9299818548c00e57295f525a8156d7bc2292e54b","unresolved":false,"context_lines":[{"line_number":2932,"context_line":""},{"line_number":2933,"context_line":"    try:"},{"line_number":2934,"context_line":"        if args.snapshot_support:"},{"line_number":2935,"context_line":"            if args.snapshot_support.strip().lower().find(\u0027\u003cis\u003e\u0027) \u003d\u003d -1:"},{"line_number":2936,"context_line":"                snapshot_support \u003d args.snapshot_support"},{"line_number":2937,"context_line":"            else:"},{"line_number":2938,"context_line":"                snapshot_support \u003d ("}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_79bbf672","line":2935,"range":{"start_line":2935,"start_character":15,"end_line":2935,"end_character":71},"updated":"2016-12-13 10:50:43.000000000","message":"could use \"not in\"","commit_id":"c46952009684cd7c619e3b81c76ebcd33ec01bc6"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"9f5f8a123302a6cee42d1b93b47aed30ec385d67","unresolved":false,"context_lines":[{"line_number":2869,"context_line":"    \u0027spec_driver_handles_share_servers\u0027,"},{"line_number":2870,"context_line":"    metavar\u003d\u0027\u003cspec_driver_handles_share_servers\u003e\u0027,"},{"line_number":2871,"context_line":"    type\u003dstr,"},{"line_number":2872,"context_line":"    help\u003d\"Required extra specification. Valid values are \""},{"line_number":2873,"context_line":"         \"\u0027true\u0027/\u00271\u0027/\u0027\u003cis\u003e true\u0027 and \u0027false\u0027/\u00270\u0027/\u0027\u003cis\u003e false\u0027\")"},{"line_number":2874,"context_line":"@cliutils.arg("},{"line_number":2875,"context_line":"    \u0027--snapshot_support\u0027,"},{"line_number":2876,"context_line":"    \u0027--snapshot-support\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_624cf670","line":2873,"range":{"start_line":2872,"start_character":9,"end_line":2873,"end_character":61},"updated":"2016-12-14 04:42:28.000000000","message":"I don\u0027t see the value allowing to specifiy this argument by \u0027\u003cis\u003e\u0027 form , this\u0027s a positional argument.","commit_id":"201faaa8f7d10e0973f6894aacfc775c2916bb91"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"9f5f8a123302a6cee42d1b93b47aed30ec385d67","unresolved":false,"context_lines":[{"line_number":2876,"context_line":"    \u0027--snapshot-support\u0027,"},{"line_number":2877,"context_line":"    metavar\u003d\u0027\u003csnapshot_support\u003e\u0027,"},{"line_number":2878,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":2879,"context_line":"    help\u003d\"Boolean extra spec that used for filtering of back ends by their\""},{"line_number":2880,"context_line":"         \"capability to create share snapshots. (Default is True). Valid\""},{"line_number":2881,"context_line":"         \"values are \u0027true\u0027/\u00271\u0027/\u0027\u003cis\u003e true\u0027 and \u0027false\u0027/\u00270\u0027/\u0027\u003cis\u003e false\u0027\")"},{"line_number":2882,"context_line":"@cliutils.arg("}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_87f8444b","line":2879,"range":{"start_line":2879,"start_character":69,"end_line":2879,"end_character":74},"updated":"2016-12-14 04:42:28.000000000","message":"add a space behind","commit_id":"201faaa8f7d10e0973f6894aacfc775c2916bb91"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"9f5f8a123302a6cee42d1b93b47aed30ec385d67","unresolved":false,"context_lines":[{"line_number":2877,"context_line":"    metavar\u003d\u0027\u003csnapshot_support\u003e\u0027,"},{"line_number":2878,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":2879,"context_line":"    help\u003d\"Boolean extra spec that used for filtering of back ends by their\""},{"line_number":2880,"context_line":"         \"capability to create share snapshots. (Default is True). Valid\""},{"line_number":2881,"context_line":"         \"values are \u0027true\u0027/\u00271\u0027/\u0027\u003cis\u003e true\u0027 and \u0027false\u0027/\u00270\u0027/\u0027\u003cis\u003e false\u0027\")"},{"line_number":2882,"context_line":"@cliutils.arg("},{"line_number":2883,"context_line":"    \u0027--extra-specs\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_47fe2c39","line":2880,"range":{"start_line":2880,"start_character":67,"end_line":2880,"end_character":72},"updated":"2016-12-14 04:42:28.000000000","message":"ditto","commit_id":"201faaa8f7d10e0973f6894aacfc775c2916bb91"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"9f5f8a123302a6cee42d1b93b47aed30ec385d67","unresolved":false,"context_lines":[{"line_number":2878,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":2879,"context_line":"    help\u003d\"Boolean extra spec that used for filtering of back ends by their\""},{"line_number":2880,"context_line":"         \"capability to create share snapshots. (Default is True). Valid\""},{"line_number":2881,"context_line":"         \"values are \u0027true\u0027/\u00271\u0027/\u0027\u003cis\u003e true\u0027 and \u0027false\u0027/\u00270\u0027/\u0027\u003cis\u003e false\u0027\")"},{"line_number":2882,"context_line":"@cliutils.arg("},{"line_number":2883,"context_line":"    \u0027--extra-specs\u0027,"},{"line_number":2884,"context_line":"    \u0027--extra_specs\u0027,  # alias"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_e79f3801","line":2881,"range":{"start_line":2881,"start_character":66,"end_line":2881,"end_character":71},"updated":"2016-12-14 04:42:28.000000000","message":"tail with a comma","commit_id":"201faaa8f7d10e0973f6894aacfc775c2916bb91"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"9f5f8a123302a6cee42d1b93b47aed30ec385d67","unresolved":false,"context_lines":[{"line_number":2903,"context_line":"        \"name\": args.name,"},{"line_number":2904,"context_line":"        \"is_public\": strutils.bool_from_string(args.is_public, default\u003dTrue),"},{"line_number":2905,"context_line":"    }"},{"line_number":2906,"context_line":"    temp \u003d args.spec_driver_handles_share_servers"},{"line_number":2907,"context_line":"    if temp.strip().lower().find(\u0027\u003cis\u003e\u0027) is not True:"},{"line_number":2908,"context_line":"        spec_driver_handles_share_servers \u003d temp"},{"line_number":2909,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_4721ccb3","line":2906,"range":{"start_line":2906,"start_character":11,"end_line":2906,"end_character":49},"updated":"2016-12-14 04:42:28.000000000","message":"maybe should check if args.spec_driver_handles_share_servers is None first.","commit_id":"201faaa8f7d10e0973f6894aacfc775c2916bb91"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"9f5f8a123302a6cee42d1b93b47aed30ec385d67","unresolved":false,"context_lines":[{"line_number":2904,"context_line":"        \"is_public\": strutils.bool_from_string(args.is_public, default\u003dTrue),"},{"line_number":2905,"context_line":"    }"},{"line_number":2906,"context_line":"    temp \u003d args.spec_driver_handles_share_servers"},{"line_number":2907,"context_line":"    if temp.strip().lower().find(\u0027\u003cis\u003e\u0027) is not True:"},{"line_number":2908,"context_line":"        spec_driver_handles_share_servers \u003d temp"},{"line_number":2909,"context_line":"    else:"},{"line_number":2910,"context_line":"        spec_driver_handles_share_servers \u003d ("}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_62bf96fb","line":2907,"range":{"start_line":2907,"start_character":28,"end_line":2907,"end_character":40},"updated":"2016-12-14 04:42:28.000000000","message":"the return value of find method is the index, not boolean.","commit_id":"201faaa8f7d10e0973f6894aacfc775c2916bb91"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"9f5f8a123302a6cee42d1b93b47aed30ec385d67","unresolved":false,"context_lines":[{"line_number":2908,"context_line":"        spec_driver_handles_share_servers \u003d temp"},{"line_number":2909,"context_line":"    else:"},{"line_number":2910,"context_line":"        spec_driver_handles_share_servers \u003d ("},{"line_number":2911,"context_line":"                           temp.strip().lower().split(\u0027\u003cis\u003e\u0027)[1])"},{"line_number":2912,"context_line":"    try:"},{"line_number":2913,"context_line":"        kwargs[\u0027spec_driver_handles_share_servers\u0027] \u003d ("},{"line_number":2914,"context_line":"            strutils.bool_from_string("}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_42ab7ad6","line":2911,"range":{"start_line":2911,"start_character":48,"end_line":2911,"end_character":61},"updated":"2016-12-14 04:42:28.000000000","message":"splitting by \u0027\u003cis\u003e\u0027 will make the member indexed by 1 include a space, like \u0027 True\u0027.","commit_id":"201faaa8f7d10e0973f6894aacfc775c2916bb91"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"9f5f8a123302a6cee42d1b93b47aed30ec385d67","unresolved":false,"context_lines":[{"line_number":2931,"context_line":""},{"line_number":2932,"context_line":"    try:"},{"line_number":2933,"context_line":"        if args.snapshot_support:"},{"line_number":2934,"context_line":"            if args.snapshot_support.strip().lower().find(\u0027\u003cis\u003e\u0027) is not True:"},{"line_number":2935,"context_line":"                snapshot_support \u003d args.snapshot_support"},{"line_number":2936,"context_line":"            else:"},{"line_number":2937,"context_line":"                snapshot_support \u003d ("}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_a237eeae","line":2934,"range":{"start_line":2934,"start_character":53,"end_line":2934,"end_character":65},"updated":"2016-12-14 04:42:28.000000000","message":"ditto","commit_id":"201faaa8f7d10e0973f6894aacfc775c2916bb91"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"9f5f8a123302a6cee42d1b93b47aed30ec385d67","unresolved":false,"context_lines":[{"line_number":2935,"context_line":"                snapshot_support \u003d args.snapshot_support"},{"line_number":2936,"context_line":"            else:"},{"line_number":2937,"context_line":"                snapshot_support \u003d ("},{"line_number":2938,"context_line":"                   args.snapshot_support.strip().lower().split(\u0027\u003cis\u003e\u0027)[1])"},{"line_number":2939,"context_line":"            kwargs[\u0027spec_snapshot_support\u0027] \u003d strutils.bool_from_string("},{"line_number":2940,"context_line":"                snapshot_support, strict\u003dTrue)"},{"line_number":2941,"context_line":"        elif \u0027snapshot_support\u0027 in kwargs[\u0027extra_specs\u0027]:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_82b59232","line":2938,"range":{"start_line":2938,"start_character":57,"end_line":2938,"end_character":69},"updated":"2016-12-14 04:42:28.000000000","message":"ditto","commit_id":"201faaa8f7d10e0973f6894aacfc775c2916bb91"},{"author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"change_message_id":"db9319c7b3e5de91bdd4a57126c676f915ee416a","unresolved":false,"context_lines":[{"line_number":2876,"context_line":"    \u0027--snapshot-support\u0027,"},{"line_number":2877,"context_line":"    metavar\u003d\u0027\u003csnapshot_support\u003e\u0027,"},{"line_number":2878,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":2879,"context_line":"    help\u003d\"Boolean extra spec that used for filtering of back ends by their\""},{"line_number":2880,"context_line":"         \"capability to create share snapshots. (Default is True). Valid\""},{"line_number":2881,"context_line":"         \"values are \u0027true\u0027/\u00271\u0027/\u0027\u003cis\u003e true\u0027 and \u0027false\u0027/\u00270\u0027/\u0027\u003cis\u003e false\u0027\")"},{"line_number":2882,"context_line":"@cliutils.arg("}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6eadb0_748d827a","line":2879,"range":{"start_line":2879,"start_character":70,"end_line":2879,"end_character":75},"updated":"2016-12-14 11:24:30.000000000","message":"a space is required here.","commit_id":"873d09b4237431240dc02211157704433e6cf60d"},{"author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"change_message_id":"db9319c7b3e5de91bdd4a57126c676f915ee416a","unresolved":false,"context_lines":[{"line_number":2877,"context_line":"    metavar\u003d\u0027\u003csnapshot_support\u003e\u0027,"},{"line_number":2878,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":2879,"context_line":"    help\u003d\"Boolean extra spec that used for filtering of back ends by their\""},{"line_number":2880,"context_line":"         \"capability to create share snapshots. (Default is True). Valid\""},{"line_number":2881,"context_line":"         \"values are \u0027true\u0027/\u00271\u0027/\u0027\u003cis\u003e true\u0027 and \u0027false\u0027/\u00270\u0027/\u0027\u003cis\u003e false\u0027\")"},{"line_number":2882,"context_line":"@cliutils.arg("},{"line_number":2883,"context_line":"    \u0027--extra-specs\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6eadb0_f4cef2b2","line":2880,"range":{"start_line":2880,"start_character":70,"end_line":2880,"end_character":73},"updated":"2016-12-14 11:24:30.000000000","message":"same here","commit_id":"873d09b4237431240dc02211157704433e6cf60d"},{"author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"change_message_id":"db9319c7b3e5de91bdd4a57126c676f915ee416a","unresolved":false,"context_lines":[{"line_number":2903,"context_line":"        \"name\": args.name,"},{"line_number":2904,"context_line":"        \"is_public\": strutils.bool_from_string(args.is_public, default\u003dTrue),"},{"line_number":2905,"context_line":"    }"},{"line_number":2906,"context_line":"    temp_1 \u003d args.spec_driver_handles_share_servers"},{"line_number":2907,"context_line":"    if \u0027\u003cis\u003e\u0027 not in temp_1.strip().lower():"},{"line_number":2908,"context_line":"        spec_driver_handles_share_servers \u003d temp_1"},{"line_number":2909,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6eadb0_f45c32ef","line":2906,"range":{"start_line":2906,"start_character":4,"end_line":2906,"end_character":10},"updated":"2016-12-14 11:24:30.000000000","message":"I think its better to use args.spec_driver_handles_share_servers directly instead of using temp_1 here.","commit_id":"873d09b4237431240dc02211157704433e6cf60d"},{"author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"change_message_id":"db9319c7b3e5de91bdd4a57126c676f915ee416a","unresolved":false,"context_lines":[{"line_number":2931,"context_line":""},{"line_number":2932,"context_line":"    try:"},{"line_number":2933,"context_line":"        if args.snapshot_support:"},{"line_number":2934,"context_line":"            temp_2 \u003d args.snapshot_support"},{"line_number":2935,"context_line":"            if \u0027\u003cis\u003e\u0027 not in temp_2.strip().lower():"},{"line_number":2936,"context_line":"                snapshot_support \u003d temp_2"},{"line_number":2937,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6eadb0_541c0612","line":2934,"range":{"start_line":2934,"start_character":12,"end_line":2934,"end_character":18},"updated":"2016-12-14 11:24:30.000000000","message":"same here.","commit_id":"873d09b4237431240dc02211157704433e6cf60d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1c75276acf2302161d43f2ef28df6926f21e57ae","unresolved":false,"context_lines":[{"line_number":2903,"context_line":"        \"name\": args.name,"},{"line_number":2904,"context_line":"        \"is_public\": strutils.bool_from_string(args.is_public, default\u003dTrue),"},{"line_number":2905,"context_line":"    }"},{"line_number":2906,"context_line":"    temp_1 \u003d args.spec_driver_handles_share_servers"},{"line_number":2907,"context_line":"    if \u0027\u003cis\u003e\u0027 not in temp_1.strip().lower():"},{"line_number":2908,"context_line":"        spec_driver_handles_share_servers \u003d temp_1"},{"line_number":2909,"context_line":"    else:"},{"line_number":2910,"context_line":"        spec_driver_handles_share_servers \u003d ("},{"line_number":2911,"context_line":"            temp_1.strip().lower().split(\u0027\u003cis\u003e\u0027)[1])"},{"line_number":2912,"context_line":"    try:"},{"line_number":2913,"context_line":"        kwargs[\u0027spec_driver_handles_share_servers\u0027] \u003d ("},{"line_number":2914,"context_line":"            strutils.bool_from_string("}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6eadb0_00c3cc89","line":2911,"range":{"start_line":2906,"start_character":0,"end_line":2911,"end_character":52},"updated":"2016-12-16 13:30:34.000000000","message":"Following the validation on the server side is probably better:\n\n\n    dhss \u003d args.spec_driver_handles_share_servers\n    match \u003d re.match(r\u0027^\u003cis\u003e\\s*(?P\u003cvalue\u003eTrue|False)$\u0027,\n                   extra_spec_value.strip(), re.IGNORECASE)\n\n    dhss \u003d match.group(\u0027value\u0027) if match else dhss\n    try:\n         kwargs[\u0027spec_driver_handles_share_servers\u0027] \u003d (\n            strutils.bool_from_string(\n                dhss, strict\u003dTrue))\n    ...","commit_id":"090f811d50d7e2dc84d69b4bdec13b09175f7c78"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1c75276acf2302161d43f2ef28df6926f21e57ae","unresolved":false,"context_lines":[{"line_number":2931,"context_line":""},{"line_number":2932,"context_line":"    try:"},{"line_number":2933,"context_line":"        if args.snapshot_support:"},{"line_number":2934,"context_line":"            temp_2 \u003d args.snapshot_support"},{"line_number":2935,"context_line":"            if \u0027\u003cis\u003e\u0027 not in temp_2.strip().lower():"},{"line_number":2936,"context_line":"                snapshot_support \u003d temp_2"},{"line_number":2937,"context_line":"            else:"},{"line_number":2938,"context_line":"                snapshot_support \u003d temp_2.strip().lower().split(\u0027\u003cis\u003e\u0027)[1]"},{"line_number":2939,"context_line":"            kwargs[\u0027spec_snapshot_support\u0027] \u003d strutils.bool_from_string("},{"line_number":2940,"context_line":"                snapshot_support, strict\u003dTrue)"},{"line_number":2941,"context_line":"        elif \u0027snapshot_support\u0027 in kwargs[\u0027extra_specs\u0027]:"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6eadb0_a0405808","line":2938,"range":{"start_line":2934,"start_character":11,"end_line":2938,"end_character":74},"updated":"2016-12-16 13:30:34.000000000","message":"same as above","commit_id":"090f811d50d7e2dc84d69b4bdec13b09175f7c78"}],"releasenotes/notes/slug-manila-type-059a1d686582e281.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1c75276acf2302161d43f2ef28df6926f21e57ae","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Fix manila type-create that \u0027\u003cis\u003e true\u0027 or \u0027\u003cis\u003efalse\u0027 can\u0027t use"},{"line_number":4,"context_line":"    manila type-create test \u0027\u003cis\u003e False\u0027"},{"line_number":5,"context_line":"    manila type-create test \u0027\u003cIs\u003e 1\u0027 --snapshot-support \u0027\u003cis\u003e False\u0027"},{"line_number":6,"context_line":"fixes:"},{"line_number":7,"context_line":"  - bug 1647781"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1a6eadb0_8ba1a648","line":7,"range":{"start_line":2,"start_character":0,"end_line":7,"end_character":15},"updated":"2016-12-16 13:30:34.000000000","message":"must be:\n\nfixes:\n   - Values of required boolean extra-specs now support use of \u0027\u003cis\u003e True\u0027\n      and \u0027\u003cis\u003e False\u0027.","commit_id":"090f811d50d7e2dc84d69b4bdec13b09175f7c78"}]}