)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"05855dda2e2f98492533d93b7402a90011c715ad","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     yanjun.fu \u003cyanjun.fu@easystack.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-28 10:12:50 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix value of extra_spec replication_type is not valid in CI"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"fix dispaly a fault in gate-manilaclient-dsvm-neutron-functional-"},{"line_number":10,"context_line":"ubuntu-xenial when we commit code to reviews in manila-client"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da4df55a_3c5d7c47","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":59},"updated":"2016-12-28 02:20:06.000000000","message":"Fix \"replication_type\" extra-spec values in tests","commit_id":"89c54954d250aa8431b8a14a49e8c9a0a5533603"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"05855dda2e2f98492533d93b7402a90011c715ad","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix value of extra_spec replication_type is not valid in CI"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"fix dispaly a fault in gate-manilaclient-dsvm-neutron-functional-"},{"line_number":10,"context_line":"ubuntu-xenial when we commit code to reviews in manila-client"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I30bf3a7f2ce7dbafbcdbe5ea95b09acb1dbb4ff9"},{"line_number":13,"context_line":"Closes-Bug: #1652730"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da4df55a_bc37acfd","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":61},"updated":"2016-12-28 02:20:06.000000000","message":"Invalid values cannot be included in the replication_type extra-spec.\nFix tests that supply invalid values to this extra-spec.","commit_id":"89c54954d250aa8431b8a14a49e8c9a0a5533603"}],"manilaclient/tests/functional/test_share_types.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d4646d1a3b50b87430d3655370140a29cae0d51c","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        (False, False, None),"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        (False, True, None, {\u0027snapshot_support\u0027: False,"},{"line_number":90,"context_line":"                             \u0027replication_type\u0027: \u0027fake_repl_type\u0027}, \"2.6\"),"},{"line_number":91,"context_line":"        (False, False, None, {\u0027snapshot_support\u0027: True,"},{"line_number":92,"context_line":"                              \u0027replication_type\u0027: \u0027fake_repl_type\u0027}, \"2.7\"),"},{"line_number":93,"context_line":"        (False, False, None, {\u0027snapshot_support\u0027: False,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da4df55a_71c3b489","line":90,"range":{"start_line":90,"start_character":50,"end_line":90,"end_character":64},"updated":"2016-12-27 17:45:42.000000000","message":"This change: \n\nhttps://github.com/openstack/manila/commit/72fc6f41d02898df22f7b85d0777e3803f79a869\n\nchecks against replication_type key being valid. Could you please change these to valid replication_types:\n\nhttps://github.com/openstack/manila/blob/0d6db35/manila/common/constants.py#L195\n\n\u0027dr\u0027, \u0027readable\u0027, \u0027writable\u0027?","commit_id":"1d7fa5b5ed785284d01f066c87dabb78499b680e"}]}
