)]}'
{"id":"openstack%2Fpython-manilaclient~430348","triplet_id":"openstack%2Fpython-manilaclient~master~I0c4a2a1cce98dbf78dd30850951466cd01491cfc","project":"openstack/python-manilaclient","branch":"master","topic":"bug/1596829","hashtags":[],"change_id":"I0c4a2a1cce98dbf78dd30850951466cd01491cfc","subject":"Handle log message interpolation by the logger","status":"MERGED","created":"2017-02-07 16:36:06.000000000","updated":"2017-02-08 11:16:27.000000000","submitted":"2017-02-08 11:16:27.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"aca647138ab96d19fe2da93fb1eddb88b7eecc2a","_number":430348,"virtual_id_number":430348,"owner":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"value":2,"date":"2017-02-08 11:16:27.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},{"value":0,"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"all":[{"value":2,"date":"2017-02-08 03:26:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2017-02-07 17:03:21.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},{"value":2,"date":"2017-02-08 10:14:33.000000000","_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"all":[{"value":0,"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},{"value":1,"date":"2017-02-08 10:14:33.000000000","_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-02-07 17:03:21.000000000","updated_by":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"reviewer":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"state":"REVIEWER"},{"updated":"2017-02-08 03:26:57.000000000","updated_by":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"reviewer":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"state":"REVIEWER"},{"updated":"2017-02-08 10:14:33.000000000","updated_by":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"reviewer":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"state":"REVIEWER"},{"updated":"2017-02-08 11:16:27.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"6ff6495dd01266f61834b258eef97900958a641c","author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"date":"2017-02-07 16:36:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"333ad0320c69b27525ca383f1da283810e2077a1","author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"date":"2017-02-07 17:03:21.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"ccacfc464c1a2b4a78410a6924ae5844cbadc384","author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"date":"2017-02-07 17:16:58.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"5de4ec9cb0c33911039b981b9a1ec0bdf06da64b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-07 17:44:11.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-manilaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/48/430348/1/check/gate-python-manilaclient-docs-ubuntu-xenial/b5aaac9//doc/build/html/ : SUCCESS in 2m 41s\n- gate-python-manilaclient-pep8-ubuntu-xenial http://logs.openstack.org/48/430348/1/check/gate-python-manilaclient-pep8-ubuntu-xenial/52188af/ : SUCCESS in 3m 00s\n- gate-python-manilaclient-python27-ubuntu-xenial http://logs.openstack.org/48/430348/1/check/gate-python-manilaclient-python27-ubuntu-xenial/b61e90d/ : SUCCESS in 3m 28s\n- gate-python-manilaclient-python35 http://logs.openstack.org/48/430348/1/check/gate-python-manilaclient-python35/bad59da/ : SUCCESS in 3m 51s\n- gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial http://logs.openstack.org/48/430348/1/check/gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial/f9a1196/ : FAILURE in 1h 07m 12s","accounts_in_message":[],"_revision_number":1},{"id":"72dc9918cfb1d93c5d665766ea87c434e2b447d5","author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"date":"2017-02-07 18:02:41.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"5f5bc47ff6cfdfcd02eec43464ebb5c63fabde27","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-07 18:43:04.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-manilaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/48/430348/1/check/gate-python-manilaclient-docs-ubuntu-xenial/e5e753f//doc/build/html/ : SUCCESS in 2m 40s\n- gate-python-manilaclient-pep8-ubuntu-xenial http://logs.openstack.org/48/430348/1/check/gate-python-manilaclient-pep8-ubuntu-xenial/2a82f83/ : SUCCESS in 2m 35s\n- gate-python-manilaclient-python27-ubuntu-xenial http://logs.openstack.org/48/430348/1/check/gate-python-manilaclient-python27-ubuntu-xenial/d5ee474/ : SUCCESS in 5m 41s\n- gate-python-manilaclient-python35 http://logs.openstack.org/48/430348/1/check/gate-python-manilaclient-python35/bc2dec5/ : SUCCESS in 2m 58s\n- gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial http://logs.openstack.org/48/430348/1/check/gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial/4306efe/ : SUCCESS in 37m 12s","accounts_in_message":[],"_revision_number":1},{"id":"affb6cb331bd0722457047f01d22a5fc427b1710","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2017-02-08 03:26:57.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"beb8bdf6eb2700f53169f7d77a49e576ab05713b","author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"date":"2017-02-08 10:14:33.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"e828f740aec279fe8e690d5006a04a79d32e8eaa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-08 10:14:44.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"adab7c95c9679c03e9d46cf2daf3a3e9ce0feb93","date":"2017-02-08 11:16:27.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"e482f28f19906d9b0079d28cac2b950a497fb43e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-08 11:16:27.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-manilaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/48/430348/1/gate/gate-python-manilaclient-docs-ubuntu-xenial/338d0d9//doc/build/html/ : SUCCESS in 1m 51s\n- gate-python-manilaclient-pep8-ubuntu-xenial http://logs.openstack.org/48/430348/1/gate/gate-python-manilaclient-pep8-ubuntu-xenial/e2ff5ca/ : SUCCESS in 2m 17s\n- gate-python-manilaclient-python27-ubuntu-xenial http://logs.openstack.org/48/430348/1/gate/gate-python-manilaclient-python27-ubuntu-xenial/03b7404/ : SUCCESS in 4m 40s\n- gate-python-manilaclient-python35 http://logs.openstack.org/48/430348/1/gate/gate-python-manilaclient-python35/6dababb/ : SUCCESS in 4m 23s\n- gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial http://logs.openstack.org/48/430348/1/gate/gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial/ef1f1ac/ : SUCCESS in 1h 00m 03s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"8d67ca5cf470b1a0e339cd519aa2ad1a6b044292","revisions":{"8d67ca5cf470b1a0e339cd519aa2ad1a6b044292":{"kind":"REWORK","_number":1,"created":"2017-02-07 16:36:06.000000000","uploader":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"ref":"refs/changes/48/430348/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/48/430348/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/48/430348/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/48/430348/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/48/430348/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/48/430348/1"}}},"commit":{"parents":[{"commit":"56776ce009da63001388d05e084baee3dd832198","subject":"Missing parenthesis in help text","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/56776ce009da63001388d05e084baee3dd832198"}]}],"author":{"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","date":"2017-02-07 16:32:27.000000000","tz":60},"committer":{"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","date":"2017-02-07 16:36:04.000000000","tz":60},"subject":"Handle log message interpolation by the logger","message":"Handle log message interpolation by the logger\n\nAccording to OpenStack Guideline[1], logged string message should be\ninterpolated by the logger.\n\n[1]: http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages\nCloses-Bug: #1596829\n\nChange-Id: I0c4a2a1cce98dbf78dd30850951466cd01491cfc\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/8d67ca5cf470b1a0e339cd519aa2ad1a6b044292"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/8d67ca5cf470b1a0e339cd519aa2ad1a6b044292"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}