)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3c607d2dd6bc2388cdf9555de62297efd830efa4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     liusheng \u003cliusheng@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-10 11:14:12 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use more specific asserts in tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Instead of assertTrue and assertFalse use more specific asserts."},{"line_number":10,"context_line":"They are compatible with Python 2.7[1] and 3.4[2]"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa31d9ce_6a818c8f","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":34},"updated":"2017-02-10 03:21:46.000000000","message":"Fix assertions in tests","commit_id":"43ecb1aabbf402d523f02f52d4588593a66a981d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3c607d2dd6bc2388cdf9555de62297efd830efa4","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Instead of assertTrue and assertFalse use more specific asserts."},{"line_number":10,"context_line":"They are compatible with Python 2.7[1] and 3.4[2]"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1]: https://docs.python.org/2.7/library/unittest.html"},{"line_number":13,"context_line":"[2]: https://docs.python.org/3.4/library/unittest.html"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa31d9ce_6a2fcca1","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":0},"updated":"2017-02-10 03:21:46.000000000","message":"Also remove test for export locations in the share API because:\n* export locations were removed from the GET /shares/{id}\n  API in version 2.9.\n* The point of the test doesn\u0027t seem to be to validate *all*\n  fields in the  API response.","commit_id":"43ecb1aabbf402d523f02f52d4588593a66a981d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"61804c792d34ad6a54f6f7ed455e02f5786a066c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"* export locations were removed from the GET /shares/{id}"},{"line_number":14,"context_line":"  API in version 2.9."},{"line_number":15,"context_line":"* The point of the test doesn\u0027t seem to be to validate *all*"},{"line_number":16,"context_line":"  fields in the  API response."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1]: https://docs.python.org/2.7/library/unittest.html"},{"line_number":19,"context_line":"[2]: https://docs.python.org/3.4/library/unittest.html"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa31d9ce_f33649b3","line":16,"range":{"start_line":16,"start_character":15,"end_line":16,"end_character":16},"updated":"2017-02-10 10:32:09.000000000","message":"extra space","commit_id":"d1e1b95ee1ef599ed2800317dcc81887a1886e3c"}],"manilaclient/tests/functional/test_shares.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ca8c8622ca4164f61e465936e11d905382c72d6d","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        self.assertEqual(self.description, get[\u0027description\u0027])"},{"line_number":92,"context_line":"        self.assertEqual(\u00271\u0027, get[\u0027size\u0027])"},{"line_number":93,"context_line":"        self.assertEqual(self.protocol.upper(), get[\u0027share_proto\u0027])"},{"line_number":94,"context_line":"        self.assertGreater(get.get(\u0027export_locations\u0027, []), 0)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_b7176da1","line":94,"range":{"start_line":94,"start_character":8,"end_line":94,"end_character":62},"updated":"2017-02-09 14:13:04.000000000","message":"This always returns True. Looks like we have bug here. It would be strange to fix approach for assertion not fixing real value of this assertion.","commit_id":"5898a8f4c0a6c17034c5f4d97b9b689addcadc4d"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"7f7c9ec0f0841cd0d118237ee19e7558538a4f42","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        self.assertEqual(self.description, get[\u0027description\u0027])"},{"line_number":92,"context_line":"        self.assertEqual(\u00271\u0027, get[\u0027size\u0027])"},{"line_number":93,"context_line":"        self.assertEqual(self.protocol.upper(), get[\u0027share_proto\u0027])"},{"line_number":94,"context_line":"        self.assertGreater(get.get(\u0027export_locations\u0027, []), 0)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_2a530a6e","line":94,"range":{"start_line":94,"start_character":8,"end_line":94,"end_character":62},"in_reply_to":"1a430d35_b7176da1","updated":"2017-02-09 17:43:50.000000000","message":"Looks like it is missing len().","commit_id":"5898a8f4c0a6c17034c5f4d97b9b689addcadc4d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"27030c1558a42b74f728d03b4bdae89f2fa83961","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        self.assertEqual(self.description, get[\u0027description\u0027])"},{"line_number":92,"context_line":"        self.assertEqual(\u00271\u0027, get[\u0027size\u0027])"},{"line_number":93,"context_line":"        self.assertEqual(self.protocol.upper(), get[\u0027share_proto\u0027])"},{"line_number":94,"context_line":"        self.assertGreater(len(get.get(\u0027export_locations\u0027, [])), 0)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_4a3cc82f","line":94,"range":{"start_line":94,"start_character":0,"end_line":94,"end_character":67},"updated":"2017-02-10 03:10:47.000000000","message":"This was a bug.. \n\nWe need to remove this check... \n\nUntil microversion 2.9 this test made sense, however, after export locations were split out into their own API, we shouldn\u0027t have this key in the return value at all... so, the len here will always be 0. \n\nIf anything, we need to test the micro versions (very little value doing that), or\n\n self.assertFalse(hasattr(shares, \u0027export_locations\u0027))","commit_id":"d022957e88570ec7bcefe1f9382920ba1e689af5"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"f81175fdaf772072b59fdcc273a4c1bf46afe2a4","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        self.assertEqual(self.description, get[\u0027description\u0027])"},{"line_number":92,"context_line":"        self.assertEqual(\u00271\u0027, get[\u0027size\u0027])"},{"line_number":93,"context_line":"        self.assertEqual(self.protocol.upper(), get[\u0027share_proto\u0027])"},{"line_number":94,"context_line":"        self.assertGreater(len(get.get(\u0027export_locations\u0027, [])), 0)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_2a54f452","line":94,"range":{"start_line":94,"start_character":0,"end_line":94,"end_character":67},"in_reply_to":"fa31d9ce_4a3cc82f","updated":"2017-02-10 03:13:35.000000000","message":"seems this change expose the bug. :P\n\nthanks, done.","commit_id":"d022957e88570ec7bcefe1f9382920ba1e689af5"}]}