)]}'
{"id":"openstack%2Fpython-manilaclient~431249","triplet_id":"openstack%2Fpython-manilaclient~master~Ie5e23c544ed7415518a0e6551f5ffdbc2ee5a3e2","project":"openstack/python-manilaclient","branch":"master","topic":"specific-asserts","hashtags":[],"change_id":"Ie5e23c544ed7415518a0e6551f5ffdbc2ee5a3e2","subject":"Use more specific asserts and fix an assertion in tests","status":"MERGED","created":"2017-02-09 02:02:26.000000000","updated":"2017-02-10 11:12:51.000000000","submitted":"2017-02-10 11:12:51.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e87f636c909fd7f70e632d0d304c17c4f7bac5de","_number":431249,"virtual_id_number":431249,"owner":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},{"value":0,"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"value":2,"date":"2017-02-10 11:12:51.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},{"value":0,"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},{"value":0,"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"all":[{"value":0,"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},{"value":2,"date":"2017-02-10 04:00:58.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},{"value":2,"date":"2017-02-10 10:32:09.000000000","_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},{"value":0,"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"all":[{"value":0,"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},{"value":0,"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},{"value":1,"date":"2017-02-10 10:32:09.000000000","_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},{"value":0,"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-02-09 14:13:04.000000000","updated_by":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"reviewer":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"state":"REVIEWER"},{"updated":"2017-02-09 17:43:50.000000000","updated_by":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"reviewer":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"state":"REVIEWER"},{"updated":"2017-02-10 04:00:58.000000000","updated_by":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"reviewer":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"state":"REVIEWER"},{"updated":"2017-02-10 10:32:09.000000000","updated_by":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"reviewer":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"state":"REVIEWER"},{"updated":"2017-02-10 11:12:51.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"e2027b53af59fc7a8d7a6ed0ff4f3cfc4ba6bf05","author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"date":"2017-02-09 02:02:26.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4c5e8153a5f56fd3819a0f051fb844613a0cee7f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-09 02:43:29.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-manilaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/49/431249/1/check/gate-python-manilaclient-docs-ubuntu-xenial/79c8a86//doc/build/html/ : SUCCESS in 1m 48s\n- gate-python-manilaclient-pep8-ubuntu-xenial http://logs.openstack.org/49/431249/1/check/gate-python-manilaclient-pep8-ubuntu-xenial/a9e9995/ : SUCCESS in 4m 26s\n- gate-python-manilaclient-python27-ubuntu-xenial http://logs.openstack.org/49/431249/1/check/gate-python-manilaclient-python27-ubuntu-xenial/5ea95c3/ : SUCCESS in 3m 13s\n- gate-python-manilaclient-python35 http://logs.openstack.org/49/431249/1/check/gate-python-manilaclient-python35/274e31b/ : SUCCESS in 5m 21s\n- gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial http://logs.openstack.org/49/431249/1/check/gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial/a26b6d4/ : FAILURE in 40m 47s","accounts_in_message":[],"_revision_number":1},{"id":"76356aa497a6c215ae674894da4684cdfeea8f7b","author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"date":"2017-02-09 02:54:03.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"60d30870c677ea3b5e5596f8256c958ced1f8a52","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-09 03:31:00.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-manilaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/49/431249/2/check/gate-python-manilaclient-docs-ubuntu-xenial/0896e37//doc/build/html/ : SUCCESS in 2m 07s\n- gate-python-manilaclient-pep8-ubuntu-xenial http://logs.openstack.org/49/431249/2/check/gate-python-manilaclient-pep8-ubuntu-xenial/a2c6b78/ : SUCCESS in 3m 09s\n- gate-python-manilaclient-python27-ubuntu-xenial http://logs.openstack.org/49/431249/2/check/gate-python-manilaclient-python27-ubuntu-xenial/c478036/ : SUCCESS in 4m 50s\n- gate-python-manilaclient-python35 http://logs.openstack.org/49/431249/2/check/gate-python-manilaclient-python35/1353b91/ : SUCCESS in 2m 54s\n- gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial http://logs.openstack.org/49/431249/2/check/gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial/b8958cd/ : SUCCESS in 36m 18s","accounts_in_message":[],"_revision_number":2},{"id":"c10d970a2ec27274f654d946dfdca8c0f1b9ed0b","author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"date":"2017-02-09 10:33:31.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"ca8c8622ca4164f61e465936e11d905382c72d6d","author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"date":"2017-02-09 14:13:04.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"7f7c9ec0f0841cd0d118237ee19e7558538a4f42","author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"date":"2017-02-09 17:43:50.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)\n\nCould say unrelated or separate bug, but what shall we do about that bogus test Valeriy found?","accounts_in_message":[],"_revision_number":2},{"id":"d4985c3d6efec2742070f0bdd353fcba323a8bb6","author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"date":"2017-02-10 01:57:12.000000000","message":"Patch Set 2:\n\nHi, thanks for your comments, done.","accounts_in_message":[],"_revision_number":2},{"id":"a398ef933a75778398f1d301f75255ed246045e4","author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"date":"2017-02-10 01:58:41.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"ddb1d4dc0f1eb952f2b1433462d6d3b10cab3d48","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2017-02-10 02:00:17.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"19642116712bb70f30143b11fbe3e7b6d585c35f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-10 03:02:35.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-manilaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/49/431249/3/check/gate-python-manilaclient-docs-ubuntu-xenial/7593f44//doc/build/html/ : SUCCESS in 3m 33s\n- gate-python-manilaclient-pep8-ubuntu-xenial http://logs.openstack.org/49/431249/3/check/gate-python-manilaclient-pep8-ubuntu-xenial/ab4750b/ : SUCCESS in 2m 30s\n- gate-python-manilaclient-python27-ubuntu-xenial http://logs.openstack.org/49/431249/3/check/gate-python-manilaclient-python27-ubuntu-xenial/a48e67f/ : SUCCESS in 4m 12s\n- gate-python-manilaclient-python35 http://logs.openstack.org/49/431249/3/check/gate-python-manilaclient-python35/58a0ca5/ : SUCCESS in 3m 01s\n- gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial http://logs.openstack.org/49/431249/3/check/gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial/0681149/ : FAILURE in 1h 01m 22s","accounts_in_message":[],"_revision_number":3},{"id":"27030c1558a42b74f728d03b4bdae89f2fa83961","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2017-02-10 03:10:47.000000000","message":"Patch Set 3: Code-Review-1\n\n(1 comment)\n\nThanks for fixing these, i guess you\u0027re going to have to help us resolve that bad test :)","accounts_in_message":[],"_revision_number":3},{"id":"f81175fdaf772072b59fdcc273a4c1bf46afe2a4","author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"date":"2017-02-10 03:13:35.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"d9b369ec8bd102fe5fd1d227550d2a9839e2dc21","author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"date":"2017-02-10 03:16:32.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"3c607d2dd6bc2388cdf9555de62297efd830efa4","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2017-02-10 03:21:46.000000000","message":"Patch Set 4:\n\n(2 comments)\n\nPlease fix the commit message with the change you just made...","accounts_in_message":[],"_revision_number":4},{"id":"05f650004d83e7824a38492eea8cec9382fba8b0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-10 03:53:50.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-manilaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/49/431249/4/check/gate-python-manilaclient-docs-ubuntu-xenial/063e219//doc/build/html/ : SUCCESS in 1m 50s\n- gate-python-manilaclient-pep8-ubuntu-xenial http://logs.openstack.org/49/431249/4/check/gate-python-manilaclient-pep8-ubuntu-xenial/1aff08c/ : SUCCESS in 2m 24s\n- gate-python-manilaclient-python27-ubuntu-xenial http://logs.openstack.org/49/431249/4/check/gate-python-manilaclient-python27-ubuntu-xenial/9eb1faa/ : SUCCESS in 5m 05s\n- gate-python-manilaclient-python35 http://logs.openstack.org/49/431249/4/check/gate-python-manilaclient-python35/4e04eeb/ : SUCCESS in 3m 00s\n- gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial http://logs.openstack.org/49/431249/4/check/gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial/4c05b6b/ : SUCCESS in 37m 06s","accounts_in_message":[],"_revision_number":4},{"id":"2e12bfdee354e6ac40436a9d52e5d1bcf43057fe","author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"date":"2017-02-10 03:58:34.000000000","message":"Uploaded patch set 5: Commit message was updated.","accounts_in_message":[],"_revision_number":5},{"id":"7c0568539adcc31bac4d72801053a100d1cd8614","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2017-02-10 04:00:58.000000000","message":"Patch Set 5: Code-Review+2\n\nThank you...","accounts_in_message":[],"_revision_number":5},{"id":"8269c6dedafacd18b7e1b048a2b630875bc89d08","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-10 04:37:57.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-manilaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/49/431249/5/check/gate-python-manilaclient-docs-ubuntu-xenial/bd1b177//doc/build/html/ : SUCCESS in 5m 25s\n- gate-python-manilaclient-pep8-ubuntu-xenial http://logs.openstack.org/49/431249/5/check/gate-python-manilaclient-pep8-ubuntu-xenial/1ddaf1b/ : SUCCESS in 2m 27s\n- gate-python-manilaclient-python27-ubuntu-xenial http://logs.openstack.org/49/431249/5/check/gate-python-manilaclient-python27-ubuntu-xenial/4fd3710/ : SUCCESS in 5m 05s\n- gate-python-manilaclient-python35 http://logs.openstack.org/49/431249/5/check/gate-python-manilaclient-python35/0b27649/ : SUCCESS in 2m 51s\n- gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial http://logs.openstack.org/49/431249/5/check/gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial/5eda33b/ : SUCCESS in 39m 05s","accounts_in_message":[],"_revision_number":5},{"id":"61804c792d34ad6a54f6f7ed455e02f5786a066c","author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"date":"2017-02-10 10:32:09.000000000","message":"Patch Set 5: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"42a278f88de1677a02751997f9d52d778a8d4746","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-10 10:32:19.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":5},{"id":"023d53483e9c80bc0c49cb6f0a49807a53399791","date":"2017-02-10 11:12:51.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":5},{"id":"251a9f728bd2eaffcdd6c6e2371d46404647449e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-10 11:12:51.000000000","message":"Patch Set 5: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-manilaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/49/431249/5/gate/gate-python-manilaclient-docs-ubuntu-xenial/ff62954//doc/build/html/ : SUCCESS in 2m 37s\n- gate-python-manilaclient-pep8-ubuntu-xenial http://logs.openstack.org/49/431249/5/gate/gate-python-manilaclient-pep8-ubuntu-xenial/3a5006d/ : SUCCESS in 2m 36s\n- gate-python-manilaclient-python27-ubuntu-xenial http://logs.openstack.org/49/431249/5/gate/gate-python-manilaclient-python27-ubuntu-xenial/a755f8d/ : SUCCESS in 3m 05s\n- gate-python-manilaclient-python35 http://logs.openstack.org/49/431249/5/gate/gate-python-manilaclient-python35/bc8bf27/ : SUCCESS in 2m 54s\n- gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial http://logs.openstack.org/49/431249/5/gate/gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial/cde6d4b/ : SUCCESS in 39m 46s","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"d1e1b95ee1ef599ed2800317dcc81887a1886e3c","revisions":{"4903489f5957b54d22fda8a13a736c5df5bdd929":{"kind":"REWORK","_number":1,"created":"2017-02-09 02:02:26.000000000","uploader":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"ref":"refs/changes/49/431249/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/49/431249/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/49/431249/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/49/431249/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/49/431249/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/49/431249/1"}}},"commit":{"parents":[{"commit":"ba180d91a4ecc6c9c2d18f36c945f1345d595a9d","subject":"Merge \"Remove support for py34\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/ba180d91a4ecc6c9c2d18f36c945f1345d595a9d"}]}],"author":{"name":"liusheng","email":"liusheng@huawei.com","date":"2017-02-09 01:50:48.000000000","tz":480},"committer":{"name":"liusheng","email":"liusheng@huawei.com","date":"2017-02-09 01:52:01.000000000","tz":480},"subject":"Use more specific asserts in tests","message":"Use more specific asserts in tests\n\nInstead of assertTrue and assertFalse use more specific asserts.\nThey are compatible with Python 2.7[1] and 3.4[2]\n\n[1]: https://docs.python.org/2.7/library/unittest.html\n[2]: https://docs.python.org/3.4/library/unittest.html\n\nChange-Id: Ie5e23c544ed7415518a0e6551f5ffdbc2ee5a3e2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/4903489f5957b54d22fda8a13a736c5df5bdd929"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/4903489f5957b54d22fda8a13a736c5df5bdd929"}]},"branch":"refs/heads/master"},"5898a8f4c0a6c17034c5f4d97b9b689addcadc4d":{"kind":"REWORK","_number":2,"created":"2017-02-09 02:54:03.000000000","uploader":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"ref":"refs/changes/49/431249/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/49/431249/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/49/431249/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/49/431249/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/49/431249/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/49/431249/2"}}},"commit":{"parents":[{"commit":"ba180d91a4ecc6c9c2d18f36c945f1345d595a9d","subject":"Merge \"Remove support for py34\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/ba180d91a4ecc6c9c2d18f36c945f1345d595a9d"}]}],"author":{"name":"liusheng","email":"liusheng@huawei.com","date":"2017-02-09 01:50:48.000000000","tz":480},"committer":{"name":"liusheng","email":"liusheng@huawei.com","date":"2017-02-09 02:52:05.000000000","tz":480},"subject":"Use more specific asserts in tests","message":"Use more specific asserts in tests\n\nInstead of assertTrue and assertFalse use more specific asserts.\nThey are compatible with Python 2.7[1] and 3.4[2]\n\n[1]: https://docs.python.org/2.7/library/unittest.html\n[2]: https://docs.python.org/3.4/library/unittest.html\n\nChange-Id: Ie5e23c544ed7415518a0e6551f5ffdbc2ee5a3e2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/5898a8f4c0a6c17034c5f4d97b9b689addcadc4d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/5898a8f4c0a6c17034c5f4d97b9b689addcadc4d"}]},"branch":"refs/heads/master"},"d022957e88570ec7bcefe1f9382920ba1e689af5":{"kind":"REWORK","_number":3,"created":"2017-02-10 01:58:41.000000000","uploader":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"ref":"refs/changes/49/431249/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/49/431249/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/49/431249/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/49/431249/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/49/431249/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/49/431249/3"}}},"commit":{"parents":[{"commit":"ba180d91a4ecc6c9c2d18f36c945f1345d595a9d","subject":"Merge \"Remove support for py34\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/ba180d91a4ecc6c9c2d18f36c945f1345d595a9d"}]}],"author":{"name":"liusheng","email":"liusheng@huawei.com","date":"2017-02-09 01:50:48.000000000","tz":480},"committer":{"name":"liusheng","email":"liusheng@huawei.com","date":"2017-02-10 01:58:01.000000000","tz":480},"subject":"Use more specific asserts in tests","message":"Use more specific asserts in tests\n\nInstead of assertTrue and assertFalse use more specific asserts.\nThey are compatible with Python 2.7[1] and 3.4[2]\n\n[1]: https://docs.python.org/2.7/library/unittest.html\n[2]: https://docs.python.org/3.4/library/unittest.html\n\nChange-Id: Ie5e23c544ed7415518a0e6551f5ffdbc2ee5a3e2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/d022957e88570ec7bcefe1f9382920ba1e689af5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/d022957e88570ec7bcefe1f9382920ba1e689af5"}]},"branch":"refs/heads/master"},"43ecb1aabbf402d523f02f52d4588593a66a981d":{"kind":"REWORK","_number":4,"created":"2017-02-10 03:16:32.000000000","uploader":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"ref":"refs/changes/49/431249/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/49/431249/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/49/431249/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/49/431249/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/49/431249/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/49/431249/4"}}},"commit":{"parents":[{"commit":"ba180d91a4ecc6c9c2d18f36c945f1345d595a9d","subject":"Merge \"Remove support for py34\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/ba180d91a4ecc6c9c2d18f36c945f1345d595a9d"}]}],"author":{"name":"liusheng","email":"liusheng@huawei.com","date":"2017-02-09 01:50:48.000000000","tz":480},"committer":{"name":"liusheng","email":"liusheng@huawei.com","date":"2017-02-10 03:14:12.000000000","tz":480},"subject":"Use more specific asserts in tests","message":"Use more specific asserts in tests\n\nInstead of assertTrue and assertFalse use more specific asserts.\nThey are compatible with Python 2.7[1] and 3.4[2]\n\n[1]: https://docs.python.org/2.7/library/unittest.html\n[2]: https://docs.python.org/3.4/library/unittest.html\n\nChange-Id: Ie5e23c544ed7415518a0e6551f5ffdbc2ee5a3e2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/43ecb1aabbf402d523f02f52d4588593a66a981d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/43ecb1aabbf402d523f02f52d4588593a66a981d"}]},"branch":"refs/heads/master"},"d1e1b95ee1ef599ed2800317dcc81887a1886e3c":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2017-02-10 03:58:34.000000000","uploader":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"ref":"refs/changes/49/431249/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/49/431249/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/49/431249/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/49/431249/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/49/431249/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/49/431249/5"}}},"commit":{"parents":[{"commit":"ba180d91a4ecc6c9c2d18f36c945f1345d595a9d","subject":"Merge \"Remove support for py34\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/ba180d91a4ecc6c9c2d18f36c945f1345d595a9d"}]}],"author":{"name":"liusheng","email":"liusheng@huawei.com","date":"2017-02-09 01:50:48.000000000","tz":480},"committer":{"name":"liusheng","email":"liusheng@huawei.com","date":"2017-02-10 03:55:27.000000000","tz":480},"subject":"Use more specific asserts and fix an assertion in tests","message":"Use more specific asserts and fix an assertion in tests\n\nInstead of assertTrue and assertFalse use more specific asserts.\nThey are compatible with Python 2.7[1] and 3.4[2]\n\nAlso remove test for export locations in the share API because:\n* export locations were removed from the GET /shares/{id}\n  API in version 2.9.\n* The point of the test doesn\u0027t seem to be to validate *all*\n  fields in the  API response.\n\n[1]: https://docs.python.org/2.7/library/unittest.html\n[2]: https://docs.python.org/3.4/library/unittest.html\n\nChange-Id: Ie5e23c544ed7415518a0e6551f5ffdbc2ee5a3e2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/d1e1b95ee1ef599ed2800317dcc81887a1886e3c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/d1e1b95ee1ef599ed2800317dcc81887a1886e3c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}