)]}'
{"id":"openstack%2Fpython-manilaclient~434140","triplet_id":"openstack%2Fpython-manilaclient~master~I37c6235d30edc3afc5c5e2c88d710b6c60f49311","project":"openstack/python-manilaclient","branch":"master","topic":"bug/1664877","hashtags":[],"change_id":"I37c6235d30edc3afc5c5e2c88d710b6c60f49311","subject":"Raise TypeError in manilaclient/common/httpclient.py","status":"MERGED","created":"2017-02-15 08:39:14.000000000","updated":"2017-03-28 20:16:52.000000000","submitted":"2017-03-28 20:16:52.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"dfe8cb1e2e74afa7f7232edbcd6259d3685bd070","_number":434140,"virtual_id_number":434140,"owner":{"_account_id":22036,"name":"dengshaolin","email":"drngsl@qq.com","username":"dengshaolin"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":0,"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},{"value":2,"date":"2017-03-28 20:16:52.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},{"value":0,"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"value":0,"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"recommended":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"all":[{"value":1,"date":"2017-03-25 19:50:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":2,"date":"2017-03-27 15:03:41.000000000","_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},{"value":2,"date":"2017-03-28 19:09:49.000000000","_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"value":1,"date":"2017-03-27 15:07:09.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"all":[{"value":0,"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":0,"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},{"value":1,"date":"2017-03-28 19:10:01.000000000","_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"value":0,"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-02-15 11:01:44.000000000","updated_by":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"reviewer":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"state":"REVIEWER"},{"updated":"2017-03-25 19:50:55.000000000","updated_by":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"reviewer":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"state":"REVIEWER"},{"updated":"2017-03-27 15:03:41.000000000","updated_by":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"reviewer":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"state":"REVIEWER"},{"updated":"2017-03-27 15:07:09.000000000","updated_by":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"reviewer":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"state":"REVIEWER"},{"updated":"2017-03-28 19:10:01.000000000","updated_by":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"reviewer":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"state":"REVIEWER"},{"updated":"2017-03-28 20:16:52.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"faa5adb8f334eedff4c09b182d659dffb1e6a7dc","author":{"_account_id":22036,"name":"dengshaolin","email":"drngsl@qq.com","username":"dengshaolin"},"date":"2017-02-15 08:39:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b5eaa3db3b28c90c846acc5c21558a2baed8c3c5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-15 09:26:23.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-manilaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/40/434140/1/check/gate-python-manilaclient-docs-ubuntu-xenial/c79bc93//doc/build/html/ : SUCCESS in 2m 57s\n- gate-python-manilaclient-pep8-ubuntu-xenial http://logs.openstack.org/40/434140/1/check/gate-python-manilaclient-pep8-ubuntu-xenial/993a037/ : SUCCESS in 4m 09s\n- gate-python-manilaclient-python27-ubuntu-xenial http://logs.openstack.org/40/434140/1/check/gate-python-manilaclient-python27-ubuntu-xenial/140037d/ : SUCCESS in 3m 04s\n- gate-python-manilaclient-python35 http://logs.openstack.org/40/434140/1/check/gate-python-manilaclient-python35/a777aa4/ : SUCCESS in 3m 41s\n- gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial http://logs.openstack.org/40/434140/1/check/gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial/4274646/ : SUCCESS in 46m 12s","accounts_in_message":[],"_revision_number":1},{"id":"7642f0dbbe7d5788d80ee7e5724dc73984b2a4d4","author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"date":"2017-02-15 11:01:44.000000000","message":"Patch Set 1: Code-Review-1\n\nCould you please add a unit test in manilaclient/tests/common/test_httpclient.py to validate the bug being captured and fixed?","accounts_in_message":[],"_revision_number":1},{"id":"f22f3cb2bd059d6dade96ae9b23ade7424ffa4df","author":{"_account_id":22036,"name":"dengshaolin","email":"drngsl@qq.com","username":"dengshaolin"},"date":"2017-02-16 04:00:00.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"5637960632fc73778b872edea22211015bf67211","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-16 04:35:30.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-manilaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/40/434140/2/check/gate-python-manilaclient-docs-ubuntu-xenial/f577939//doc/build/html/ : SUCCESS in 3m 38s\n- gate-python-manilaclient-pep8-ubuntu-xenial http://logs.openstack.org/40/434140/2/check/gate-python-manilaclient-pep8-ubuntu-xenial/dd364de/ : SUCCESS in 2m 21s\n- gate-python-manilaclient-python27-ubuntu-xenial http://logs.openstack.org/40/434140/2/check/gate-python-manilaclient-python27-ubuntu-xenial/46b4c97/ : SUCCESS in 3m 03s\n- gate-python-manilaclient-python35 http://logs.openstack.org/40/434140/2/check/gate-python-manilaclient-python35/78b8c4f/ : SUCCESS in 2m 55s\n- gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial http://logs.openstack.org/40/434140/2/check/gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial/aa2df13/ : SUCCESS in 34m 42s","accounts_in_message":[],"_revision_number":2},{"id":"9c77f643d3eba007c8fcde1c67d7dfeea73caa52","author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"date":"2017-03-25 19:50:55.000000000","message":"Patch Set 2: Code-Review+1\n\nWe have this error at py35 gate as well.","accounts_in_message":[],"_revision_number":2},{"id":"5a1967d892ec265c4c0fbc1f5aed5875a84ccb59","author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"date":"2017-03-27 15:03:41.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"9161e866ef75f99a78340ea30ff3e23bd24d78c2","author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"date":"2017-03-27 15:07:09.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"886b08e4850d90beb2b249fff184c98166cc1075","author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"date":"2017-03-27 15:10:58.000000000","message":"Patch Set 2: Code-Review-1\n\nThis looks like a good fix but it should have a \"fixes\" release note.","accounts_in_message":[],"_revision_number":2},{"id":"c503c524700399f24dce75748515ed11c7ea7886","author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"date":"2017-03-28 19:06:22.000000000","message":"Patch Set 2:\n\n\u003e This looks like a good fix but it should have a \"fixes\" release\n \u003e note.\n\nI added the release note in a follow-up patch: https://review.openstack.org/#/c/450934/ .","accounts_in_message":[],"_revision_number":2},{"id":"dbb50582190c2d6807ffb34be04e994bf087e5b0","author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"date":"2017-03-28 19:09:49.000000000","message":"Patch Set 2: Code-Review+2\n\nThanks.","accounts_in_message":[],"_revision_number":2},{"id":"f62f1dfccd605ed5ab2dc3beeda914d9c8af8771","author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"date":"2017-03-28 19:10:01.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"0b719de7e37e5a373439bb618ec1f0e8bede1de1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-28 19:10:11.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"a97cb83a61cc7eb2057fb7aa454250e8b2422f2a","date":"2017-03-28 20:16:52.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"2c91539dc16bae53271136a2654e20431f073049","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-28 20:16:52.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-manilaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/40/434140/2/gate/gate-python-manilaclient-docs-ubuntu-xenial/6cc49ba//doc/build/html/ : SUCCESS in 2m 53s\n- gate-python-manilaclient-pep8-ubuntu-xenial http://logs.openstack.org/40/434140/2/gate/gate-python-manilaclient-pep8-ubuntu-xenial/22bd6a0/ : SUCCESS in 4m 31s\n- gate-python-manilaclient-python27-ubuntu-xenial http://logs.openstack.org/40/434140/2/gate/gate-python-manilaclient-python27-ubuntu-xenial/834cf25/ : SUCCESS in 3m 30s\n- gate-python-manilaclient-python35 http://logs.openstack.org/40/434140/2/gate/gate-python-manilaclient-python35/bce3651/ : SUCCESS in 4m 49s\n- gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial http://logs.openstack.org/40/434140/2/gate/gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial/ef352eb/ : SUCCESS in 1h 05m 38s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"788001fcaf20600b8d50a86cf86884b5946710f9","revisions":{"996c31ffd353d91aaca4dd4f93e0c5f68010dfe9":{"kind":"REWORK","_number":1,"created":"2017-02-15 08:39:14.000000000","uploader":{"_account_id":22036,"name":"dengshaolin","email":"drngsl@qq.com","username":"dengshaolin"},"ref":"refs/changes/40/434140/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/40/434140/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/40/434140/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/40/434140/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/40/434140/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/40/434140/1"}}},"commit":{"parents":[{"commit":"7f95f10286f3e784acab1d9d8bfb9ca36486a170","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/7f95f10286f3e784acab1d9d8bfb9ca36486a170"}]}],"author":{"name":"drngsl","email":"drngsl@qq.com","date":"2017-02-15 08:24:42.000000000","tz":-300},"committer":{"name":"drngsl","email":"drngsl@qq.com","date":"2017-02-15 08:29:55.000000000","tz":-300},"subject":"Raise TypeError in manilaclient/common/httpclient.py","message":"Raise TypeError in manilaclient/common/httpclient.py\n\nobject \u0027HTTPClient\u0027 property \u0027retries\u0027 is None for default,\nwhen code \u0027if attempts \u003e self.retries:\u0027 is executed at some time,\nTypeError will raise.\n\nChange-Id: I37c6235d30edc3afc5c5e2c88d710b6c60f49311\nCloses-Bug: #1664877\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/996c31ffd353d91aaca4dd4f93e0c5f68010dfe9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/996c31ffd353d91aaca4dd4f93e0c5f68010dfe9"}]},"branch":"refs/heads/master"},"788001fcaf20600b8d50a86cf86884b5946710f9":{"kind":"REWORK","_number":2,"created":"2017-02-16 04:00:00.000000000","uploader":{"_account_id":22036,"name":"dengshaolin","email":"drngsl@qq.com","username":"dengshaolin"},"ref":"refs/changes/40/434140/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/40/434140/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/40/434140/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/40/434140/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/40/434140/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/40/434140/2"}}},"commit":{"parents":[{"commit":"7f95f10286f3e784acab1d9d8bfb9ca36486a170","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/7f95f10286f3e784acab1d9d8bfb9ca36486a170"}]}],"author":{"name":"drngsl","email":"drngsl@qq.com","date":"2017-02-15 08:24:42.000000000","tz":-300},"committer":{"name":"drngsl","email":"drngsl@qq.com","date":"2017-02-16 03:50:28.000000000","tz":-300},"subject":"Raise TypeError in manilaclient/common/httpclient.py","message":"Raise TypeError in manilaclient/common/httpclient.py\n\nobject \u0027HTTPClient\u0027 property \u0027retries\u0027 is None for default,\nwhen code \u0027if attempts \u003e self.retries:\u0027 is executed at some time,\nTypeError will raise.\n\nChange-Id: I37c6235d30edc3afc5c5e2c88d710b6c60f49311\nCloses-Bug: #1664877\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/788001fcaf20600b8d50a86cf86884b5946710f9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/788001fcaf20600b8d50a86cf86884b5946710f9"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}