)]}'
{"manilaclient/tests/functional/test_quotas.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9af78ca5e3f2d28ac51e20c696625817c190a77f","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        # Verify share type quotas after reset"},{"line_number":110,"context_line":"        self._verify_current_st_quotas_equal_to(p_quotas)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @utils.skip_if_microversion_not_supported(\"2.33\")"},{"line_number":113,"context_line":"    def test_read_share_type_quotas_with_too_old_microversion(self):"},{"line_number":114,"context_line":"        cmd \u003d \u0027quota-show --tenant-id %s --share-type %s\u0027 % ("},{"line_number":115,"context_line":"            self.project_id, self.st_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f013ff3_e58e3326","line":112,"range":{"start_line":112,"start_character":3,"end_line":112,"end_character":53},"updated":"2017-05-15 12:07:18.000000000","message":"In code line 38, We added @utils.skip_if_microversion_not_supported(\"2.34\"), so we will skip this test if the version is equal to 2.33. In other words, this client version is always \u003e\u003d 2.34 when we run this test, we can not test the client version 2.33.Why we need to add @utils.skip_if_microversion_not_supported(\"2.33\"). Did I missing something?","commit_id":"4ecf33da6549cb5ee132de03d872fba944d4cf72"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"3d8f2283338df379c2599ef2b73a2a048ff0a9a2","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        # Verify share type quotas after reset"},{"line_number":110,"context_line":"        self._verify_current_st_quotas_equal_to(p_quotas)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @utils.skip_if_microversion_not_supported(\"2.33\")"},{"line_number":113,"context_line":"    def test_read_share_type_quotas_with_too_old_microversion(self):"},{"line_number":114,"context_line":"        cmd \u003d \u0027quota-show --tenant-id %s --share-type %s\u0027 % ("},{"line_number":115,"context_line":"            self.project_id, self.st_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff0f0b1f_06807b45","line":112,"range":{"start_line":112,"start_character":3,"end_line":112,"end_character":53},"in_reply_to":"1f013ff3_e58e3326","updated":"2017-05-23 12:16:44.000000000","message":"It is useful in case 2.34 is minimal microversion.","commit_id":"4ecf33da6549cb5ee132de03d872fba944d4cf72"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b31e02d725b55e1276726604d5a0689024575f2e","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        # Verify share type quotas after reset"},{"line_number":110,"context_line":"        self._verify_current_st_quotas_equal_to(p_quotas)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @utils.skip_if_microversion_not_supported(\"2.33\")"},{"line_number":113,"context_line":"    def test_read_share_type_quotas_with_too_old_microversion(self):"},{"line_number":114,"context_line":"        cmd \u003d \u0027quota-show --tenant-id %s --share-type %s\u0027 % ("},{"line_number":115,"context_line":"            self.project_id, self.st_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"df140735_5f4b1158","line":112,"range":{"start_line":112,"start_character":3,"end_line":112,"end_character":53},"in_reply_to":"df140735_eaeb73d9","updated":"2017-06-01 12:08:47.000000000","message":"zhongjun\n\nIf your server does not support 2.33 microversion then this test is not applicable, because it will just fail. So, this test is executed only when both microversions are supported - 2.33 and 2.34. It is so by design - to test border case.","commit_id":"4ecf33da6549cb5ee132de03d872fba944d4cf72"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"57b60baa6be99f90b68f35d33554146019d6a344","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        # Verify share type quotas after reset"},{"line_number":110,"context_line":"        self._verify_current_st_quotas_equal_to(p_quotas)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @utils.skip_if_microversion_not_supported(\"2.33\")"},{"line_number":113,"context_line":"    def test_read_share_type_quotas_with_too_old_microversion(self):"},{"line_number":114,"context_line":"        cmd \u003d \u0027quota-show --tenant-id %s --share-type %s\u0027 % ("},{"line_number":115,"context_line":"            self.project_id, self.st_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"df140735_eaeb73d9","line":112,"range":{"start_line":112,"start_character":3,"end_line":112,"end_character":53},"in_reply_to":"ff0f0b1f_06807b45","updated":"2017-05-31 02:59:08.000000000","message":"When I set the minimal microversion to 2.34 in my \nenviroment, I can not into \ntest_read_share_type_quotas_with_too_old_microversion test,\n this test always be skipped.\nCould you tell me how to enter into this test and we can \nrun self.assertRaises(exceptions.CommandFailed, \nself.admin_client.manila, cmd, microversion\u003d\u00272.33\u0027?","commit_id":"4ecf33da6549cb5ee132de03d872fba944d4cf72"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9af78ca5e3f2d28ac51e20c696625817c190a77f","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            self.admin_client.manila,"},{"line_number":119,"context_line":"            cmd, microversion\u003d\u00272.33\u0027)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    @utils.skip_if_microversion_not_supported(\"2.33\")"},{"line_number":122,"context_line":"    def test_update_share_type_quotas_with_too_old_microversion(self):"},{"line_number":123,"context_line":"        cmd \u003d \u0027quota-update --tenant-id %s --share-type %s --shares %s\u0027 % ("},{"line_number":124,"context_line":"            self.project_id, self.st_id, \u00270\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f013ff3_65a2239d","line":121,"range":{"start_line":121,"start_character":4,"end_line":121,"end_character":53},"updated":"2017-05-15 12:07:18.000000000","message":"above","commit_id":"4ecf33da6549cb5ee132de03d872fba944d4cf72"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9af78ca5e3f2d28ac51e20c696625817c190a77f","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            self.admin_client.manila,"},{"line_number":128,"context_line":"            cmd, microversion\u003d\u00272.33\u0027)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    @utils.skip_if_microversion_not_supported(\"2.33\")"},{"line_number":131,"context_line":"    def test_delete_share_type_quotas_with_too_old_microversion(self):"},{"line_number":132,"context_line":"        cmd \u003d \u0027quota-delete --tenant-id %s --share-type %s\u0027 % ("},{"line_number":133,"context_line":"            self.project_id, self.st_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f013ff3_459f2750","line":130,"range":{"start_line":130,"start_character":3,"end_line":130,"end_character":53},"updated":"2017-05-15 12:07:18.000000000","message":"above","commit_id":"4ecf33da6549cb5ee132de03d872fba944d4cf72"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2085260a24a3623efbe1ec314d77e501cf9c7988","unresolved":false,"context_lines":[{"line_number":394,"context_line":""},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"@cliutils.arg("},{"line_number":397,"context_line":"    \u0027--tenant-id\u0027,"},{"line_number":398,"context_line":"    metavar\u003d\u0027\u003ctenant-id\u003e\u0027,"},{"line_number":399,"context_line":"    default\u003dNone,"},{"line_number":400,"context_line":"    help\u003d\u0027ID of tenant to list the quotas for.\u0027)"}],"source_content_type":"text/x-python","patch_set":17,"id":"ff346bd7_e8593afe","line":397,"range":{"start_line":397,"start_character":5,"end_line":397,"end_character":17},"updated":"2017-07-24 23:51:13.000000000","message":"why change this?\nif you need another alias, you can add it","commit_id":"6f3418ff796901c6c9af7fd382c17c51abde61d1"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"cf9b93c8db7ccf6268ca2dbb952967f6ee4ea548","unresolved":false,"context_lines":[{"line_number":394,"context_line":""},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"@cliutils.arg("},{"line_number":397,"context_line":"    \u0027--tenant-id\u0027,"},{"line_number":398,"context_line":"    metavar\u003d\u0027\u003ctenant-id\u003e\u0027,"},{"line_number":399,"context_line":"    default\u003dNone,"},{"line_number":400,"context_line":"    help\u003d\u0027ID of tenant to list the quotas for.\u0027)"}],"source_content_type":"text/x-python","patch_set":17,"id":"ff346bd7_964ccc42","line":397,"range":{"start_line":397,"start_character":5,"end_line":397,"end_character":17},"in_reply_to":"ff346bd7_e8593afe","updated":"2017-07-26 15:11:11.000000000","message":"It is done so, because just \"tenant\" can be understood as \"either name or ID\". But it is big mistake. API will consider name and ID of single tenant as 2 different tenant IDs.\n\nAlso, there is no harm to rename (extend its name) that option, because manilaclient will pick it using even short variant. Same in other places.","commit_id":"6f3418ff796901c6c9af7fd382c17c51abde61d1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2085260a24a3623efbe1ec314d77e501cf9c7988","unresolved":false,"context_lines":[{"line_number":399,"context_line":"    default\u003dNone,"},{"line_number":400,"context_line":"    help\u003d\u0027ID of tenant to list the quotas for.\u0027)"},{"line_number":401,"context_line":"@cliutils.arg("},{"line_number":402,"context_line":"    \u0027--user-id\u0027,"},{"line_number":403,"context_line":"    metavar\u003d\u0027\u003cuser-id\u003e\u0027,"},{"line_number":404,"context_line":"    default\u003dNone,"},{"line_number":405,"context_line":"    help\u003d\"ID of user to list the quotas for. Optional. \""}],"source_content_type":"text/x-python","patch_set":17,"id":"ff346bd7_c85e76e5","line":402,"range":{"start_line":402,"start_character":5,"end_line":402,"end_character":14},"updated":"2017-07-24 23:51:13.000000000","message":"same","commit_id":"6f3418ff796901c6c9af7fd382c17c51abde61d1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2085260a24a3623efbe1ec314d77e501cf9c7988","unresolved":false,"context_lines":[{"line_number":438,"context_line":""},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"@cliutils.arg("},{"line_number":441,"context_line":"    \u0027--tenant-id\u0027,"},{"line_number":442,"context_line":"    metavar\u003d\u0027\u003ctenant-id\u003e\u0027,"},{"line_number":443,"context_line":"    default\u003dNone,"},{"line_number":444,"context_line":"    help\u003d\u0027ID of tenant to list the default quotas for.\u0027)"}],"source_content_type":"text/x-python","patch_set":17,"id":"ff346bd7_080a3ed1","line":441,"range":{"start_line":441,"start_character":4,"end_line":441,"end_character":17},"updated":"2017-07-24 23:51:13.000000000","message":"same","commit_id":"6f3418ff796901c6c9af7fd382c17c51abde61d1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2085260a24a3623efbe1ec314d77e501cf9c7988","unresolved":false,"context_lines":[{"line_number":449,"context_line":""},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"@cliutils.arg("},{"line_number":452,"context_line":"    \u0027tenant_id\u0027,"},{"line_number":453,"context_line":"    metavar\u003d\u0027\u003ctenant_id\u003e\u0027,"},{"line_number":454,"context_line":"    help\u003d\u0027UUID of tenant to set the quotas for.\u0027)"},{"line_number":455,"context_line":"@cliutils.arg("}],"source_content_type":"text/x-python","patch_set":17,"id":"ff346bd7_e80edae3","line":452,"range":{"start_line":452,"start_character":4,"end_line":452,"end_character":16},"updated":"2017-07-24 23:51:13.000000000","message":"same","commit_id":"6f3418ff796901c6c9af7fd382c17c51abde61d1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2085260a24a3623efbe1ec314d77e501cf9c7988","unresolved":false,"context_lines":[{"line_number":453,"context_line":"    metavar\u003d\u0027\u003ctenant_id\u003e\u0027,"},{"line_number":454,"context_line":"    help\u003d\u0027UUID of tenant to set the quotas for.\u0027)"},{"line_number":455,"context_line":"@cliutils.arg("},{"line_number":456,"context_line":"    \u0027--user-id\u0027,"},{"line_number":457,"context_line":"    metavar\u003d\u0027\u003cuser-id\u003e\u0027,"},{"line_number":458,"context_line":"    default\u003dNone,"},{"line_number":459,"context_line":"    help\u003d\"ID of a user to set the quotas for. Optional. \""}],"source_content_type":"text/x-python","patch_set":17,"id":"ff346bd7_c813160d","line":456,"range":{"start_line":456,"start_character":5,"end_line":456,"end_character":16},"updated":"2017-07-24 23:51:13.000000000","message":"same","commit_id":"6f3418ff796901c6c9af7fd382c17c51abde61d1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2085260a24a3623efbe1ec314d77e501cf9c7988","unresolved":false,"context_lines":[{"line_number":532,"context_line":""},{"line_number":533,"context_line":""},{"line_number":534,"context_line":"@cliutils.arg("},{"line_number":535,"context_line":"    \u0027--tenant-id\u0027,"},{"line_number":536,"context_line":"    metavar\u003d\u0027\u003ctenant-id\u003e\u0027,"},{"line_number":537,"context_line":"    help\u003d\u0027ID of tenant to delete quota for.\u0027)"},{"line_number":538,"context_line":"@cliutils.arg("}],"source_content_type":"text/x-python","patch_set":17,"id":"ff346bd7_8dae402c","line":535,"range":{"start_line":535,"start_character":5,"end_line":535,"end_character":18},"updated":"2017-07-24 23:51:13.000000000","message":"same","commit_id":"6f3418ff796901c6c9af7fd382c17c51abde61d1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2085260a24a3623efbe1ec314d77e501cf9c7988","unresolved":false,"context_lines":[{"line_number":536,"context_line":"    metavar\u003d\u0027\u003ctenant-id\u003e\u0027,"},{"line_number":537,"context_line":"    help\u003d\u0027ID of tenant to delete quota for.\u0027)"},{"line_number":538,"context_line":"@cliutils.arg("},{"line_number":539,"context_line":"    \u0027--user-id\u0027,"},{"line_number":540,"context_line":"    metavar\u003d\u0027\u003cuser-id\u003e\u0027,"},{"line_number":541,"context_line":"    help\u003d\"ID of user to delete quota for. Optional.\""},{"line_number":542,"context_line":"         \"Mutually exclusive with \u0027--share-type\u0027.\")"}],"source_content_type":"text/x-python","patch_set":17,"id":"ff346bd7_6802eab6","line":539,"range":{"start_line":539,"start_character":5,"end_line":539,"end_character":16},"updated":"2017-07-24 23:51:13.000000000","message":"same","commit_id":"6f3418ff796901c6c9af7fd382c17c51abde61d1"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"9a1b510368a6f228b8828381d38eae1cc4320da9","unresolved":false,"context_lines":[{"line_number":433,"context_line":"        \"user_id\": args.user_id,"},{"line_number":434,"context_line":"        \"detail\": args.detail,"},{"line_number":435,"context_line":"    }"},{"line_number":436,"context_line":"    if args.share_type is not None:"},{"line_number":437,"context_line":"        if cs.api_version \u003c api_versions.APIVersion(\"2.39\"):"},{"line_number":438,"context_line":"            raise exceptions.CommandError("},{"line_number":439,"context_line":"                \"\u0027share type\u0027 quotas are available only starting with \""}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_ccec0091","line":436,"range":{"start_line":436,"start_character":23,"end_line":436,"end_character":34},"updated":"2017-07-26 17:14:48.000000000","message":"+1","commit_id":"8045f4d24e33c3690b3a5301a93bb7b4470de42e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"94377a39d2c22be5b0797550c0beea22e1a9ed41","unresolved":false,"context_lines":[{"line_number":433,"context_line":"        \"user_id\": args.user_id,"},{"line_number":434,"context_line":"        \"detail\": args.detail,"},{"line_number":435,"context_line":"    }"},{"line_number":436,"context_line":"    if args.share_type is not None:"},{"line_number":437,"context_line":"        if cs.api_version \u003c api_versions.APIVersion(\"2.39\"):"},{"line_number":438,"context_line":"            raise exceptions.CommandError("},{"line_number":439,"context_line":"                \"\u0027share type\u0027 quotas are available only starting with \""}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_4c7b70bd","line":436,"range":{"start_line":436,"start_character":23,"end_line":436,"end_character":34},"in_reply_to":"ff346bd7_ccec0091","updated":"2017-07-26 17:16:32.000000000","message":"All credits go to Goutham ! )))","commit_id":"8045f4d24e33c3690b3a5301a93bb7b4470de42e"}]}