)]}'
{"manilaclient/tests/unit/v2/test_share_instances.py":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"5c4b9493755a59b6afecc903de69a8ddb2d1267d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    @ddt.data((\u0027id\u0027, \u0027b4991315-eb7d-43ec-979e-5715d4399827\u0027),"},{"line_number":45,"context_line":"              (\u0027path\u0027, \u0027//0.0.0.0/fake_path\u0027))"},{"line_number":46,"context_line":"    @ddt.unpack"},{"line_number":47,"context_line":"    def test_list_by_export_location(self, type, value):"},{"line_number":48,"context_line":"        cs.share_instances.list(export_location\u003dvalue)"},{"line_number":49,"context_line":"        cs.assert_called("},{"line_number":50,"context_line":"            \u0027GET\u0027, \u0027/share_instances?export_location_\u0027 + type + \u0027\u003d\u0027 + value)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_040597c2","line":47,"range":{"start_line":47,"start_character":43,"end_line":47,"end_character":47},"updated":"2017-06-30 09:25:06.000000000","message":"ditto","commit_id":"bc2ba0c155a314cc14b2c6c453e444ac7c778e35"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"65293a05467d288c89b5e10c581fbed214416259","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    @ddt.data((\u0027id\u0027, \u0027b4991315-eb7d-43ec-979e-5715d4399827\u0027),"},{"line_number":45,"context_line":"              (\u0027path\u0027, \u0027//0.0.0.0/fake_path\u0027))"},{"line_number":46,"context_line":"    @ddt.unpack"},{"line_number":47,"context_line":"    def test_list_by_export_location(self, type, value):"},{"line_number":48,"context_line":"        cs.share_instances.list(export_location\u003dvalue)"},{"line_number":49,"context_line":"        cs.assert_called("},{"line_number":50,"context_line":"            \u0027GET\u0027, \u0027/share_instances?export_location_\u0027 + type + \u0027\u003d\u0027 + value)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_1d1145ad","line":47,"range":{"start_line":47,"start_character":43,"end_line":47,"end_character":47},"in_reply_to":"3f1d235d_040597c2","updated":"2017-07-03 03:45:41.000000000","message":"Done","commit_id":"bc2ba0c155a314cc14b2c6c453e444ac7c778e35"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"65293a05467d288c89b5e10c581fbed214416259","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    @ddt.data((\u0027id\u0027, \u0027b4991315-eb7d-43ec-979e-5715d4399827\u0027),"},{"line_number":45,"context_line":"              (\u0027path\u0027, \u0027//0.0.0.0/fake_path\u0027))"},{"line_number":46,"context_line":"    @ddt.unpack"},{"line_number":47,"context_line":"    def test_list_by_export_location(self, type, value):"},{"line_number":48,"context_line":"        cs.share_instances.list(export_location\u003dvalue)"},{"line_number":49,"context_line":"        cs.assert_called("},{"line_number":50,"context_line":"            \u0027GET\u0027, \u0027/share_instances?export_location_\u0027 + type + \u0027\u003d\u0027 + value)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_dd398d3f","line":47,"range":{"start_line":47,"start_character":43,"end_line":47,"end_character":47},"in_reply_to":"3f1d235d_040597c2","updated":"2017-07-03 03:45:41.000000000","message":"Done","commit_id":"bc2ba0c155a314cc14b2c6c453e444ac7c778e35"}],"manilaclient/tests/unit/v2/test_shares.py":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"5c4b9493755a59b6afecc903de69a8ddb2d1267d","unresolved":false,"context_lines":[{"line_number":302,"context_line":"              (\u0027path\u0027, \u0027fake_path\u0027, False),"},{"line_number":303,"context_line":"              (\u0027path\u0027, \u0027fake_path\u0027, True))"},{"line_number":304,"context_line":"    @ddt.unpack"},{"line_number":305,"context_line":"    def test_list_shares_index_with_export_location(self, type,"},{"line_number":306,"context_line":"                                                    value, detailed):"},{"line_number":307,"context_line":"        search_opts \u003d {"},{"line_number":308,"context_line":"            \u0027export_location\u0027: value,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_a45ee3e3","line":305,"range":{"start_line":305,"start_character":58,"end_line":305,"end_character":62},"updated":"2017-06-30 09:25:06.000000000","message":"ditto","commit_id":"bc2ba0c155a314cc14b2c6c453e444ac7c778e35"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"65293a05467d288c89b5e10c581fbed214416259","unresolved":false,"context_lines":[{"line_number":302,"context_line":"              (\u0027path\u0027, \u0027fake_path\u0027, False),"},{"line_number":303,"context_line":"              (\u0027path\u0027, \u0027fake_path\u0027, True))"},{"line_number":304,"context_line":"    @ddt.unpack"},{"line_number":305,"context_line":"    def test_list_shares_index_with_export_location(self, type,"},{"line_number":306,"context_line":"                                                    value, detailed):"},{"line_number":307,"context_line":"        search_opts \u003d {"},{"line_number":308,"context_line":"            \u0027export_location\u0027: value,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_9d4315b0","line":305,"range":{"start_line":305,"start_character":58,"end_line":305,"end_character":62},"in_reply_to":"3f1d235d_a45ee3e3","updated":"2017-07-03 03:45:41.000000000","message":"Done","commit_id":"bc2ba0c155a314cc14b2c6c453e444ac7c778e35"}],"manilaclient/tests/unit/v2/test_shell.py":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"5c4b9493755a59b6afecc903de69a8ddb2d1267d","unresolved":false,"context_lines":[{"line_number":325,"context_line":"    @ddt.data((\u0027id\u0027, \u0027b4991315-eb7d-43ec-979e-5715d4399827\u0027),"},{"line_number":326,"context_line":"              (\u0027path\u0027, \u0027fake_path\u0027))"},{"line_number":327,"context_line":"    @ddt.unpack"},{"line_number":328,"context_line":"    def test_list_filter_by_export_location(self, type, value):"},{"line_number":329,"context_line":"        for separator in self.separators:"},{"line_number":330,"context_line":"            self.run_command(\u0027list --export_location\u0027 + separator + value)"},{"line_number":331,"context_line":"            self.assert_called("}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_a445c319","line":328,"range":{"start_line":328,"start_character":8,"end_line":328,"end_character":17},"updated":"2017-06-30 09:25:06.000000000","message":"test_share_list_xxx","commit_id":"bc2ba0c155a314cc14b2c6c453e444ac7c778e35"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"5c4b9493755a59b6afecc903de69a8ddb2d1267d","unresolved":false,"context_lines":[{"line_number":325,"context_line":"    @ddt.data((\u0027id\u0027, \u0027b4991315-eb7d-43ec-979e-5715d4399827\u0027),"},{"line_number":326,"context_line":"              (\u0027path\u0027, \u0027fake_path\u0027))"},{"line_number":327,"context_line":"    @ddt.unpack"},{"line_number":328,"context_line":"    def test_list_filter_by_export_location(self, type, value):"},{"line_number":329,"context_line":"        for separator in self.separators:"},{"line_number":330,"context_line":"            self.run_command(\u0027list --export_location\u0027 + separator + value)"},{"line_number":331,"context_line":"            self.assert_called("}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_248e5378","line":328,"range":{"start_line":328,"start_character":50,"end_line":328,"end_character":54},"updated":"2017-06-30 09:25:06.000000000","message":"use \u0027filter_type\u0027 instead","commit_id":"bc2ba0c155a314cc14b2c6c453e444ac7c778e35"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"65293a05467d288c89b5e10c581fbed214416259","unresolved":false,"context_lines":[{"line_number":325,"context_line":"    @ddt.data((\u0027id\u0027, \u0027b4991315-eb7d-43ec-979e-5715d4399827\u0027),"},{"line_number":326,"context_line":"              (\u0027path\u0027, \u0027fake_path\u0027))"},{"line_number":327,"context_line":"    @ddt.unpack"},{"line_number":328,"context_line":"    def test_list_filter_by_export_location(self, type, value):"},{"line_number":329,"context_line":"        for separator in self.separators:"},{"line_number":330,"context_line":"            self.run_command(\u0027list --export_location\u0027 + separator + value)"},{"line_number":331,"context_line":"            self.assert_called("}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_3d352147","line":328,"range":{"start_line":328,"start_character":50,"end_line":328,"end_character":54},"in_reply_to":"3f1d235d_248e5378","updated":"2017-07-03 03:45:41.000000000","message":"Done","commit_id":"bc2ba0c155a314cc14b2c6c453e444ac7c778e35"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"65293a05467d288c89b5e10c581fbed214416259","unresolved":false,"context_lines":[{"line_number":325,"context_line":"    @ddt.data((\u0027id\u0027, \u0027b4991315-eb7d-43ec-979e-5715d4399827\u0027),"},{"line_number":326,"context_line":"              (\u0027path\u0027, \u0027fake_path\u0027))"},{"line_number":327,"context_line":"    @ddt.unpack"},{"line_number":328,"context_line":"    def test_list_filter_by_export_location(self, type, value):"},{"line_number":329,"context_line":"        for separator in self.separators:"},{"line_number":330,"context_line":"            self.run_command(\u0027list --export_location\u0027 + separator + value)"},{"line_number":331,"context_line":"            self.assert_called("}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_5d2e9dfa","line":328,"range":{"start_line":328,"start_character":8,"end_line":328,"end_character":17},"in_reply_to":"3f1d235d_a445c319","updated":"2017-07-03 03:45:41.000000000","message":"Done","commit_id":"bc2ba0c155a314cc14b2c6c453e444ac7c778e35"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"5c4b9493755a59b6afecc903de69a8ddb2d1267d","unresolved":false,"context_lines":[{"line_number":376,"context_line":"    @ddt.data((\u0027id\u0027, \u0027b4991315-eb7d-43ec-979e-5715d4399827\u0027),"},{"line_number":377,"context_line":"              (\u0027path\u0027, \u0027fake_path\u0027))"},{"line_number":378,"context_line":"    @ddt.unpack"},{"line_number":379,"context_line":"    def test_share_instance_list_filter_by_export_location(self, type, value):"},{"line_number":380,"context_line":"        for separator in self.separators:"},{"line_number":381,"context_line":"            self.run_command(\u0027share-instance-list --export_location\u0027 +"},{"line_number":382,"context_line":"                             separator + value)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_44bf0ffb","line":379,"range":{"start_line":379,"start_character":65,"end_line":379,"end_character":69},"updated":"2017-06-30 09:25:06.000000000","message":"ditto","commit_id":"bc2ba0c155a314cc14b2c6c453e444ac7c778e35"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"65293a05467d288c89b5e10c581fbed214416259","unresolved":false,"context_lines":[{"line_number":376,"context_line":"    @ddt.data((\u0027id\u0027, \u0027b4991315-eb7d-43ec-979e-5715d4399827\u0027),"},{"line_number":377,"context_line":"              (\u0027path\u0027, \u0027fake_path\u0027))"},{"line_number":378,"context_line":"    @ddt.unpack"},{"line_number":379,"context_line":"    def test_share_instance_list_filter_by_export_location(self, type, value):"},{"line_number":380,"context_line":"        for separator in self.separators:"},{"line_number":381,"context_line":"            self.run_command(\u0027share-instance-list --export_location\u0027 +"},{"line_number":382,"context_line":"                             separator + value)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_fd27a911","line":379,"range":{"start_line":379,"start_character":65,"end_line":379,"end_character":69},"in_reply_to":"3f1d235d_44bf0ffb","updated":"2017-07-03 03:45:41.000000000","message":"Done","commit_id":"bc2ba0c155a314cc14b2c6c453e444ac7c778e35"}],"manilaclient/v2/share_instances.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cca7fea51f20a6692db5d89fdb933cc20ba2c7b7","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        \"\"\"List all share instances.\"\"\""},{"line_number":52,"context_line":"        path \u003d \u0027/share_instances\u0027"},{"line_number":53,"context_line":"        if export_location:"},{"line_number":54,"context_line":"            if (\u0027\\/\u0027 or \u0027\\\\\u0027) in export_location:"},{"line_number":55,"context_line":"                path +\u003d \u0027?export_location_path\u003d\u0027 + export_location"},{"line_number":56,"context_line":"            else:"},{"line_number":57,"context_line":"                path +\u003d \u0027?export_location_id\u003d\u0027 + export_location"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f1d235d_9eda21e7","line":54,"range":{"start_line":54,"start_character":10,"end_line":54,"end_character":49},"updated":"2017-06-30 00:18:05.000000000","message":"same comment here as in https://review.openstack.org/#/c/468277/9/manilaclient/v2/shares.py","commit_id":"46d9a3ebf86d81b4f36b7586da2b332f67121ce8"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"50eb197b9a0d465da2436a35e81549cdf88a26f2","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        \"\"\"List all share instances.\"\"\""},{"line_number":52,"context_line":"        path \u003d \u0027/share_instances\u0027"},{"line_number":53,"context_line":"        if export_location:"},{"line_number":54,"context_line":"            if (\u0027\\/\u0027 or \u0027\\\\\u0027) in export_location:"},{"line_number":55,"context_line":"                path +\u003d \u0027?export_location_path\u003d\u0027 + export_location"},{"line_number":56,"context_line":"            else:"},{"line_number":57,"context_line":"                path +\u003d \u0027?export_location_id\u003d\u0027 + export_location"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f1d235d_c26c370a","line":54,"range":{"start_line":54,"start_character":10,"end_line":54,"end_character":49},"in_reply_to":"3f1d235d_9eda21e7","updated":"2017-06-30 07:08:50.000000000","message":"Done","commit_id":"46d9a3ebf86d81b4f36b7586da2b332f67121ce8"}],"manilaclient/v2/shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cca7fea51f20a6692db5d89fdb933cc20ba2c7b7","unresolved":false,"context_lines":[{"line_number":375,"context_line":""},{"line_number":376,"context_line":"        export_location \u003d search_opts.pop(\u0027export_location\u0027, None)"},{"line_number":377,"context_line":"        if export_location:"},{"line_number":378,"context_line":"            if (\u0027\\/\u0027 or \u0027\\\\\u0027) in export_location:"},{"line_number":379,"context_line":"                search_opts[\u0027export_location_path\u0027] \u003d export_location"},{"line_number":380,"context_line":"            else:"},{"line_number":381,"context_line":"                search_opts[\u0027export_location_id\u0027] \u003d export_location"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f1d235d_5e4fe9bc","line":378,"range":{"start_line":378,"start_character":12,"end_line":378,"end_character":49},"updated":"2017-06-30 00:18:05.000000000","message":"why don\u0027t we use oslo_utils.uuidutils.is_uuid_like for this.. because iirc in some cases, like maprfs, the export_location is not a string like this.","commit_id":"46d9a3ebf86d81b4f36b7586da2b332f67121ce8"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"50eb197b9a0d465da2436a35e81549cdf88a26f2","unresolved":false,"context_lines":[{"line_number":375,"context_line":""},{"line_number":376,"context_line":"        export_location \u003d search_opts.pop(\u0027export_location\u0027, None)"},{"line_number":377,"context_line":"        if export_location:"},{"line_number":378,"context_line":"            if (\u0027\\/\u0027 or \u0027\\\\\u0027) in export_location:"},{"line_number":379,"context_line":"                search_opts[\u0027export_location_path\u0027] \u003d export_location"},{"line_number":380,"context_line":"            else:"},{"line_number":381,"context_line":"                search_opts[\u0027export_location_id\u0027] \u003d export_location"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f1d235d_e2673325","line":378,"range":{"start_line":378,"start_character":12,"end_line":378,"end_character":49},"in_reply_to":"3f1d235d_5e4fe9bc","updated":"2017-06-30 07:08:50.000000000","message":"Done","commit_id":"46d9a3ebf86d81b4f36b7586da2b332f67121ce8"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cca7fea51f20a6692db5d89fdb933cc20ba2c7b7","unresolved":false,"context_lines":[{"line_number":1562,"context_line":"        \u0027is_public\u0027: args.public,"},{"line_number":1563,"context_line":"    }"},{"line_number":1564,"context_line":""},{"line_number":1565,"context_line":"    if cs.api_version.matches(api_versions.APIVersion(\"2.35\"),"},{"line_number":1566,"context_line":"                              api_versions.APIVersion()):"},{"line_number":1567,"context_line":"        search_opts[\u0027export_location\u0027] \u003d args.export_location"},{"line_number":1568,"context_line":""},{"line_number":1569,"context_line":"    if share_group:"},{"line_number":1570,"context_line":"        search_opts[\u0027share_group_id\u0027] \u003d share_group.id"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f201791_3147b74e","line":1567,"range":{"start_line":1565,"start_character":0,"end_line":1567,"end_character":61},"updated":"2017-06-30 00:18:05.000000000","message":"this should be done in the library: https://review.openstack.org/#/c/468277/9/manilaclient/v2/shares.py","commit_id":"46d9a3ebf86d81b4f36b7586da2b332f67121ce8"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"50eb197b9a0d465da2436a35e81549cdf88a26f2","unresolved":false,"context_lines":[{"line_number":1562,"context_line":"        \u0027is_public\u0027: args.public,"},{"line_number":1563,"context_line":"    }"},{"line_number":1564,"context_line":""},{"line_number":1565,"context_line":"    if cs.api_version.matches(api_versions.APIVersion(\"2.35\"),"},{"line_number":1566,"context_line":"                              api_versions.APIVersion()):"},{"line_number":1567,"context_line":"        search_opts[\u0027export_location\u0027] \u003d args.export_location"},{"line_number":1568,"context_line":""},{"line_number":1569,"context_line":"    if share_group:"},{"line_number":1570,"context_line":"        search_opts[\u0027share_group_id\u0027] \u003d share_group.id"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f1d235d_7812b25a","line":1567,"range":{"start_line":1565,"start_character":0,"end_line":1567,"end_character":61},"in_reply_to":"5f201791_3147b74e","updated":"2017-06-30 07:08:50.000000000","message":"Done","commit_id":"46d9a3ebf86d81b4f36b7586da2b332f67121ce8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cca7fea51f20a6692db5d89fdb933cc20ba2c7b7","unresolved":false,"context_lines":[{"line_number":1625,"context_line":"    if share:"},{"line_number":1626,"context_line":"        instances \u003d cs.shares.list_instances(share)"},{"line_number":1627,"context_line":"    else:"},{"line_number":1628,"context_line":"        if cs.api_version.matches("},{"line_number":1629,"context_line":"                api_versions.APIVersion(\"2.35\"), api_versions.APIVersion()):"},{"line_number":1630,"context_line":"            instances \u003d cs.share_instances.list(args.export_location)"},{"line_number":1631,"context_line":"        else:"},{"line_number":1632,"context_line":"            instances \u003d cs.share_instances.list()"},{"line_number":1633,"context_line":""},{"line_number":1634,"context_line":"    cliutils.print_list(instances, list_of_keys)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f1d235d_7e698523","line":1631,"range":{"start_line":1628,"start_character":0,"end_line":1631,"end_character":13},"updated":"2017-06-30 00:18:05.000000000","message":"same comment as above..","commit_id":"46d9a3ebf86d81b4f36b7586da2b332f67121ce8"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"50eb197b9a0d465da2436a35e81549cdf88a26f2","unresolved":false,"context_lines":[{"line_number":1625,"context_line":"    if share:"},{"line_number":1626,"context_line":"        instances \u003d cs.shares.list_instances(share)"},{"line_number":1627,"context_line":"    else:"},{"line_number":1628,"context_line":"        if cs.api_version.matches("},{"line_number":1629,"context_line":"                api_versions.APIVersion(\"2.35\"), api_versions.APIVersion()):"},{"line_number":1630,"context_line":"            instances \u003d cs.share_instances.list(args.export_location)"},{"line_number":1631,"context_line":"        else:"},{"line_number":1632,"context_line":"            instances \u003d cs.share_instances.list()"},{"line_number":1633,"context_line":""},{"line_number":1634,"context_line":"    cliutils.print_list(instances, list_of_keys)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f1d235d_d803060d","line":1631,"range":{"start_line":1628,"start_character":0,"end_line":1631,"end_character":13},"in_reply_to":"3f1d235d_7e698523","updated":"2017-06-30 07:08:50.000000000","message":"Done","commit_id":"46d9a3ebf86d81b4f36b7586da2b332f67121ce8"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"5c4b9493755a59b6afecc903de69a8ddb2d1267d","unresolved":false,"context_lines":[{"line_number":1511,"context_line":"@cliutils.arg("},{"line_number":1512,"context_line":"    \u0027--export_location\u0027,"},{"line_number":1513,"context_line":"    metavar\u003d\u0027\u003cexport_location\u003e\u0027,"},{"line_number":1514,"context_line":"    type\u003dstr,"},{"line_number":1515,"context_line":"    default\u003dNone,"},{"line_number":1516,"context_line":"    help\u003d\u0027ID or path of the share export location. \u0027"},{"line_number":1517,"context_line":"         \u0027Available only for microversion \u003e\u003d 2.35.\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_e9f4b65d","line":1514,"range":{"start_line":1514,"start_character":9,"end_line":1514,"end_character":12},"updated":"2017-06-30 09:25:06.000000000","message":"six.text_type","commit_id":"bc2ba0c155a314cc14b2c6c453e444ac7c778e35"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"65293a05467d288c89b5e10c581fbed214416259","unresolved":false,"context_lines":[{"line_number":1511,"context_line":"@cliutils.arg("},{"line_number":1512,"context_line":"    \u0027--export_location\u0027,"},{"line_number":1513,"context_line":"    metavar\u003d\u0027\u003cexport_location\u003e\u0027,"},{"line_number":1514,"context_line":"    type\u003dstr,"},{"line_number":1515,"context_line":"    default\u003dNone,"},{"line_number":1516,"context_line":"    help\u003d\u0027ID or path of the share export location. \u0027"},{"line_number":1517,"context_line":"         \u0027Available only for microversion \u003e\u003d 2.35.\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_3d83e1ce","line":1514,"range":{"start_line":1514,"start_character":9,"end_line":1514,"end_character":12},"in_reply_to":"3f1d235d_e9f4b65d","updated":"2017-07-03 03:45:41.000000000","message":"What this means?","commit_id":"bc2ba0c155a314cc14b2c6c453e444ac7c778e35"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"5c4b9493755a59b6afecc903de69a8ddb2d1267d","unresolved":false,"context_lines":[{"line_number":1514,"context_line":"    type\u003dstr,"},{"line_number":1515,"context_line":"    default\u003dNone,"},{"line_number":1516,"context_line":"    help\u003d\u0027ID or path of the share export location. \u0027"},{"line_number":1517,"context_line":"         \u0027Available only for microversion \u003e\u003d 2.35.\u0027)"},{"line_number":1518,"context_line":"@cliutils.service_type(\u0027sharev2\u0027)"},{"line_number":1519,"context_line":"def do_list(cs, args):"},{"line_number":1520,"context_line":"    \"\"\"List NAS shares with filters.\"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_e9503635","line":1517,"range":{"start_line":1517,"start_character":28,"end_line":1517,"end_character":50},"updated":"2017-06-30 09:25:06.000000000","message":"Can we use \u0027start_version\u0027 here? Just like what we did in cinderclient [1]\n[1]: https://github.com/openstack/python-cinderclient/blob/master/cinderclient/v3/shell.py#L233","commit_id":"bc2ba0c155a314cc14b2c6c453e444ac7c778e35"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"5c4b9493755a59b6afecc903de69a8ddb2d1267d","unresolved":false,"context_lines":[{"line_number":1605,"context_line":"@cliutils.arg("},{"line_number":1606,"context_line":"    \u0027--export_location\u0027,"},{"line_number":1607,"context_line":"    metavar\u003d\u0027\u003cexport_location\u003e\u0027,"},{"line_number":1608,"context_line":"    type\u003dstr,"},{"line_number":1609,"context_line":"    default\u003dNone,"},{"line_number":1610,"context_line":"    help\u003d\u0027ID or path of the share export location. \u0027"},{"line_number":1611,"context_line":"         \u0027Available only for microversion \u003e\u003d 2.35.\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_695c264b","line":1608,"range":{"start_line":1608,"start_character":4,"end_line":1608,"end_character":13},"updated":"2017-06-30 09:25:06.000000000","message":"ditto","commit_id":"bc2ba0c155a314cc14b2c6c453e444ac7c778e35"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"65293a05467d288c89b5e10c581fbed214416259","unresolved":false,"context_lines":[{"line_number":1605,"context_line":"@cliutils.arg("},{"line_number":1606,"context_line":"    \u0027--export_location\u0027,"},{"line_number":1607,"context_line":"    metavar\u003d\u0027\u003cexport_location\u003e\u0027,"},{"line_number":1608,"context_line":"    type\u003dstr,"},{"line_number":1609,"context_line":"    default\u003dNone,"},{"line_number":1610,"context_line":"    help\u003d\u0027ID or path of the share export location. \u0027"},{"line_number":1611,"context_line":"         \u0027Available only for microversion \u003e\u003d 2.35.\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_7d627940","line":1608,"range":{"start_line":1608,"start_character":4,"end_line":1608,"end_character":13},"in_reply_to":"3f1d235d_695c264b","updated":"2017-07-03 03:45:41.000000000","message":"?","commit_id":"bc2ba0c155a314cc14b2c6c453e444ac7c778e35"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e1a7a2d80acf9c365eadcff389b5fb66b70483d9","unresolved":false,"context_lines":[{"line_number":1568,"context_line":"        \u0027is_public\u0027: args.public,"},{"line_number":1569,"context_line":"    }"},{"line_number":1570,"context_line":""},{"line_number":1571,"context_line":"    if cs.api_version.matches(api_versions.APIVersion(\"2.35\"),"},{"line_number":1572,"context_line":"                              api_versions.APIVersion()):"},{"line_number":1573,"context_line":"        search_opts[\u0027export_location\u0027] \u003d args.export_location"},{"line_number":1574,"context_line":""},{"line_number":1575,"context_line":"    if share_group:"},{"line_number":1576,"context_line":"        search_opts[\u0027share_group_id\u0027] \u003d share_group.id"}],"source_content_type":"text/x-python","patch_set":17,"id":"ff346bd7_195a4182","line":1573,"range":{"start_line":1571,"start_character":0,"end_line":1573,"end_character":61},"updated":"2017-07-26 22:23:16.000000000","message":"I think throwing an error in the client is better than ignoring the filter. Can you please change this to the way suggested on https://review.openstack.org/#/c/474428/15/manilaclient/v2/shell.py@4207","commit_id":"1782fb5fd22d226aced8be7b84f9c28a57064f02"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e1a7a2d80acf9c365eadcff389b5fb66b70483d9","unresolved":false,"context_lines":[{"line_number":1632,"context_line":"    if share:"},{"line_number":1633,"context_line":"        instances \u003d cs.shares.list_instances(share)"},{"line_number":1634,"context_line":"    else:"},{"line_number":1635,"context_line":"        if cs.api_version.matches("},{"line_number":1636,"context_line":"                api_versions.APIVersion(\"2.35\"), api_versions.APIVersion()):"},{"line_number":1637,"context_line":"            instances \u003d cs.share_instances.list(args.export_location)"},{"line_number":1638,"context_line":"        else:"},{"line_number":1639,"context_line":"            instances \u003d cs.share_instances.list()"},{"line_number":1640,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"ff346bd7_994d11c6","line":1637,"range":{"start_line":1635,"start_character":5,"end_line":1637,"end_character":69},"updated":"2017-07-26 22:23:16.000000000","message":"same","commit_id":"1782fb5fd22d226aced8be7b84f9c28a57064f02"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"81796c88de3ad30b56c60a7657f3830925793073","unresolved":false,"context_lines":[{"line_number":1573,"context_line":"        search_opts[\u0027export_location\u0027] \u003d args.export_location"},{"line_number":1574,"context_line":"    elif args.export_location:"},{"line_number":1575,"context_line":"        raise exceptions.CommandError("},{"line_number":1576,"context_line":"            \"Pattern based filtering (export_location) is only \""},{"line_number":1577,"context_line":"            \"available with manila API version \u003e\u003d 2.35\")"},{"line_number":1578,"context_line":""},{"line_number":1579,"context_line":"    if share_group:"}],"source_content_type":"text/x-python","patch_set":18,"id":"ff346bd7_2f2a3a2b","line":1576,"range":{"start_line":1576,"start_character":13,"end_line":1576,"end_character":54},"updated":"2017-07-27 14:02:07.000000000","message":"Filtering by export location","commit_id":"be6b4c14b4cc8115ae8afa7d7e0a51bc2f0dcc37"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"81796c88de3ad30b56c60a7657f3830925793073","unresolved":false,"context_lines":[{"line_number":1618,"context_line":"    type\u003dstr,"},{"line_number":1619,"context_line":"    default\u003dNone,"},{"line_number":1620,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":1621,"context_line":"    help\u003d\u0027ID or path of the share export location. \u0027"},{"line_number":1622,"context_line":"         \u0027Available only for microversion \u003e\u003d 2.35.\u0027)"},{"line_number":1623,"context_line":"@api_versions.wraps(\"2.3\")"},{"line_number":1624,"context_line":"def do_share_instance_list(cs, args):"}],"source_content_type":"text/x-python","patch_set":18,"id":"ff346bd7_8f2fe63d","line":1621,"range":{"start_line":1621,"start_character":34,"end_line":1621,"end_character":40},"updated":"2017-07-27 14:02:07.000000000","message":"instance export location","commit_id":"be6b4c14b4cc8115ae8afa7d7e0a51bc2f0dcc37"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"81796c88de3ad30b56c60a7657f3830925793073","unresolved":false,"context_lines":[{"line_number":1642,"context_line":"        else:"},{"line_number":1643,"context_line":"            if args.export_location:"},{"line_number":1644,"context_line":"                raise exceptions.CommandError("},{"line_number":1645,"context_line":"                    \"Pattern based filtering (export_location) is only \""},{"line_number":1646,"context_line":"                    \"available with manila API version \u003e\u003d 2.35\")"},{"line_number":1647,"context_line":"            instances \u003d cs.share_instances.list()"},{"line_number":1648,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"ff346bd7_ef1f9205","line":1645,"range":{"start_line":1645,"start_character":21,"end_line":1645,"end_character":62},"updated":"2017-07-27 14:02:07.000000000","message":"Filtering by export location","commit_id":"be6b4c14b4cc8115ae8afa7d7e0a51bc2f0dcc37"}],"releasenotes/notes/add-export-location-filter-4cf3114doe40k598.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cca7fea51f20a6692db5d89fdb933cc20ba2c7b7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Share and share instance list API will accept new query string parameter"},{"line_number":4,"context_line":"    \u0027export_location\u0027. It can pass path and id of export_location to"},{"line_number":5,"context_line":"    retrieve shares filtered."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5f201791_f61ed56e","line":5,"range":{"start_line":3,"start_character":4,"end_line":5,"end_character":29},"updated":"2017-06-30 00:18:05.000000000","message":"Shares and share instances can now be filtered with their export location IDs or paths.","commit_id":"46d9a3ebf86d81b4f36b7586da2b332f67121ce8"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"50eb197b9a0d465da2436a35e81549cdf88a26f2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Share and share instance list API will accept new query string parameter"},{"line_number":4,"context_line":"    \u0027export_location\u0027. It can pass path and id of export_location to"},{"line_number":5,"context_line":"    retrieve shares filtered."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f1d235d_42fdc738","line":5,"range":{"start_line":3,"start_character":4,"end_line":5,"end_character":29},"in_reply_to":"5f201791_f61ed56e","updated":"2017-06-30 07:08:50.000000000","message":"Done","commit_id":"46d9a3ebf86d81b4f36b7586da2b332f67121ce8"}]}