)]}'
{"id":"openstack%2Fpython-manilaclient~485016","triplet_id":"openstack%2Fpython-manilaclient~master~I8f9b580ad653e32290e5c4be8a639cf7d168d9ec","project":"openstack/python-manilaclient","branch":"master","topic":"fix-tox","hashtags":[],"change_id":"I8f9b580ad653e32290e5c4be8a639cf7d168d9ec","subject":"Enable some off-by-default checks","status":"MERGED","created":"2017-07-19 03:00:17.000000000","updated":"2017-07-20 19:22:37.000000000","submitted":"2017-07-20 19:22:37.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9bf28c0031beb00d1bf18a8f16add3f40cbf0e85","_number":485016,"virtual_id_number":485016,"owner":{"_account_id":25388,"name":"liuyamin","email":"liuyamin@fiberhome.com","username":"liuyamin"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"value":2,"date":"2017-07-20 19:22:37.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"all":[{"value":2,"date":"2017-07-20 12:00:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-07-20 09:26:17.000000000","_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"all":[{"value":1,"date":"2017-07-20 18:17:08.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-07-20 09:26:17.000000000","updated_by":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"reviewer":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"state":"REVIEWER"},{"updated":"2017-07-20 18:17:08.000000000","updated_by":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"reviewer":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"state":"REVIEWER"},{"updated":"2017-07-20 19:22:37.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"290f9b92593c532882b2276c2a1f3d96f930a453","author":{"_account_id":25388,"name":"liuyamin","email":"liuyamin@fiberhome.com","username":"liuyamin"},"date":"2017-07-19 03:00:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1fdff8699da142949f995567342bc628cf0447b3","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2017-07-19 03:01:38.000000000","message":"Patch Set 1: Code-Review-1\n\nWhy not \"enable [H904] Delay string interpolations at logging calls\" as well?","accounts_in_message":[],"_revision_number":1},{"id":"c0d7d7d41d3637688c749d4668c84fd173b15bb0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-19 04:09:11.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-manilaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/16/485016/1/check/gate-python-manilaclient-docs-ubuntu-xenial/3daa8bc//doc/build/html/ : SUCCESS in 5m 01s\n- gate-python-manilaclient-pep8-ubuntu-xenial http://logs.openstack.org/16/485016/1/check/gate-python-manilaclient-pep8-ubuntu-xenial/7c0aa23/ : SUCCESS in 5m 21s\n- gate-python-manilaclient-python27-ubuntu-xenial http://logs.openstack.org/16/485016/1/check/gate-python-manilaclient-python27-ubuntu-xenial/2a270ad/ : SUCCESS in 5m 55s\n- gate-python-manilaclient-python35 http://logs.openstack.org/16/485016/1/check/gate-python-manilaclient-python35/9bc541f/ : SUCCESS in 5m 20s\n- gate-python-manilaclient-releasenotes http://docs-draft.openstack.org/16/485016/1/check/gate-python-manilaclient-releasenotes/fc78596//releasenotes/build/html/ : SUCCESS in 2m 51s\n- gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial http://logs.openstack.org/16/485016/1/check/gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial/b8c03ae/ : SUCCESS in 59m 39s","accounts_in_message":[],"_revision_number":1},{"id":"281e78e4edfeaadfc4e921ba2a4e42ca5c230941","author":{"_account_id":25388,"name":"liuyamin","email":"liuyamin@fiberhome.com","username":"liuyamin"},"date":"2017-07-20 03:23:21.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"7654dc412e3ce20b2c51fbc8f5aa98c8d22822fe","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2017-07-20 03:58:36.000000000","message":"Patch Set 2: Code-Review+1\n\nThanks","accounts_in_message":[],"_revision_number":2},{"id":"3be92b6df46d8b18ea33c85dd36957efa6b9b5ab","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-20 04:28:12.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-manilaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/16/485016/2/check/gate-python-manilaclient-docs-ubuntu-xenial/9202876//doc/build/html/ : SUCCESS in 3m 39s\n- gate-python-manilaclient-pep8-ubuntu-xenial http://logs.openstack.org/16/485016/2/check/gate-python-manilaclient-pep8-ubuntu-xenial/b032955/ : SUCCESS in 4m 55s\n- gate-python-manilaclient-python27-ubuntu-xenial http://logs.openstack.org/16/485016/2/check/gate-python-manilaclient-python27-ubuntu-xenial/53d6b66/ : SUCCESS in 7m 56s\n- gate-python-manilaclient-python35 http://logs.openstack.org/16/485016/2/check/gate-python-manilaclient-python35/57eea43/ : SUCCESS in 3m 39s\n- gate-python-manilaclient-releasenotes http://docs-draft.openstack.org/16/485016/2/check/gate-python-manilaclient-releasenotes/4c037cd//releasenotes/build/html/ : SUCCESS in 2m 05s\n- gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial http://logs.openstack.org/16/485016/2/check/gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial/75c12f7/ : SUCCESS in 1h 01m 04s","accounts_in_message":[],"_revision_number":2},{"id":"7f2d694357f05269af36a2fbec7c0ebc7d2c3441","author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"date":"2017-07-20 09:26:17.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"465b8de478ff15bc283e7a057dd775c128801290","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2017-07-20 12:00:11.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"7bdcd98e990a905f6ab861e1cf9893dad4dfce7d","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2017-07-20 18:17:08.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"0e3ffa9b9c2ae8a8b8670cd8117a6b45acff220e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-20 18:17:18.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"a043f7d83cee2aa9bd2722dad1ef3f7656d7763d","date":"2017-07-20 19:22:37.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"95680a7d56efb083cade6d9d8e8081cb0f81f773","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-20 19:22:37.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-manilaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/16/485016/2/gate/gate-python-manilaclient-docs-ubuntu-xenial/ca74501//doc/build/html/ : SUCCESS in 3m 31s\n- gate-python-manilaclient-pep8-ubuntu-xenial http://logs.openstack.org/16/485016/2/gate/gate-python-manilaclient-pep8-ubuntu-xenial/10d9976/ : SUCCESS in 3m 50s\n- gate-python-manilaclient-python27-ubuntu-xenial http://logs.openstack.org/16/485016/2/gate/gate-python-manilaclient-python27-ubuntu-xenial/fa392e4/ : SUCCESS in 5m 55s\n- gate-python-manilaclient-python35 http://logs.openstack.org/16/485016/2/gate/gate-python-manilaclient-python35/533c07e/ : SUCCESS in 6m 42s\n- gate-python-manilaclient-releasenotes http://docs-draft.openstack.org/16/485016/2/gate/gate-python-manilaclient-releasenotes/cee6290//releasenotes/build/html/ : SUCCESS in 2m 35s\n- gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial http://logs.openstack.org/16/485016/2/gate/gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial/ea0aa23/ : SUCCESS in 1h 02m 41s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"34d5767a040d9de17f3b1ddb7d428c52b64e7fb4","revisions":{"e299eecbc23a683b0d81c872aeb476237168fd16":{"kind":"REWORK","_number":1,"created":"2017-07-19 03:00:17.000000000","uploader":{"_account_id":25388,"name":"liuyamin","email":"liuyamin@fiberhome.com","username":"liuyamin"},"ref":"refs/changes/16/485016/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/16/485016/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/16/485016/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/16/485016/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/16/485016/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/16/485016/1"}}},"commit":{"parents":[{"commit":"ce2f74b89b38c5cf6735fd8bb4877734c7dac2ae","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/ce2f74b89b38c5cf6735fd8bb4877734c7dac2ae"}]}],"author":{"name":"e","email":"liuyamin@fiberhome.com","date":"2017-07-19 02:48:43.000000000","tz":480},"committer":{"name":"e","email":"liuyamin@fiberhome.com","date":"2017-07-19 02:54:06.000000000","tz":480},"subject":"Enable some off-by-default checks","message":"Enable some off-by-default checks\n\nSome of the available checks are disabled by default, like:\n[H106] Don’t put vim configuration in source files\n[H203] Use assertIs(Not)None to check for None\n\nSee:\nhttps://docs.openstack.org/hacking/latest/user/usage.html#enabling-off-by-default-checks\n\nChange-Id: I8f9b580ad653e32290e5c4be8a639cf7d168d9ec\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/e299eecbc23a683b0d81c872aeb476237168fd16"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/e299eecbc23a683b0d81c872aeb476237168fd16"}]},"branch":"refs/heads/master"},"34d5767a040d9de17f3b1ddb7d428c52b64e7fb4":{"kind":"REWORK","_number":2,"created":"2017-07-20 03:23:21.000000000","uploader":{"_account_id":25388,"name":"liuyamin","email":"liuyamin@fiberhome.com","username":"liuyamin"},"ref":"refs/changes/16/485016/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/16/485016/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/16/485016/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/16/485016/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/16/485016/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/16/485016/2"}}},"commit":{"parents":[{"commit":"ce2f74b89b38c5cf6735fd8bb4877734c7dac2ae","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/ce2f74b89b38c5cf6735fd8bb4877734c7dac2ae"}]}],"author":{"name":"e","email":"liuyamin@fiberhome.com","date":"2017-07-19 02:48:43.000000000","tz":480},"committer":{"name":"liuyamin","email":"liuyamin@fiberhome.com","date":"2017-07-20 03:22:42.000000000","tz":480},"subject":"Enable some off-by-default checks","message":"Enable some off-by-default checks\n\nSome of the available checks are disabled by default, like:\n[H106] Don’t put vim configuration in source files\n[H203] Use assertIs(Not)None to check for None\n\nSee:\nhttps://docs.openstack.org/hacking/latest/user/usage.html#enabling-off-by-default-checks\n\nChange-Id: I8f9b580ad653e32290e5c4be8a639cf7d168d9ec\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/34d5767a040d9de17f3b1ddb7d428c52b64e7fb4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/34d5767a040d9de17f3b1ddb7d428c52b64e7fb4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}