)]}'
{"id":"openstack%2Fpython-manilaclient~495769","triplet_id":"openstack%2Fpython-manilaclient~master~I929b65d0807a60a84842fa78c5324e290bde0520","project":"openstack/python-manilaclient","branch":"master","topic":"bug/1712002","hashtags":[],"change_id":"I929b65d0807a60a84842fa78c5324e290bde0520","subject":"Fix unicode value filters for share list","status":"ABANDONED","created":"2017-08-21 08:59:11.000000000","updated":"2017-10-09 08:29:44.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e679a378491604abd341b600f72669be81dd9761","_number":495769,"virtual_id_number":495769,"owner":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2017-08-25 07:54:23.000000000","_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},{"value":1,"date":"2017-08-25 07:36:07.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":26567,"name":"kaufmann.smith","email":"kaufmann.smith@yahoo.com"},{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},{"value":-1,"date":"2017-09-19 15:37:05.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2017-08-28 13:56:14.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":26567,"name":"kaufmann.smith","email":"kaufmann.smith@yahoo.com"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"value":2,"date":"2017-09-13 09:16:18.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"value":1,"date":"2017-09-13 08:42:18.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},{"value":2,"date":"2017-09-25 13:12:55.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":26567,"name":"kaufmann.smith","email":"kaufmann.smith@yahoo.com"},{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},{"_account_id":26567,"name":"kaufmann.smith","email":"kaufmann.smith@yahoo.com"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-08-22 07:14:22.000000000","updated_by":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"reviewer":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"state":"REVIEWER"},{"updated":"2017-08-25 07:36:07.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-08-28 13:56:14.000000000","updated_by":{"_account_id":26567,"name":"kaufmann.smith","email":"kaufmann.smith@yahoo.com"},"reviewer":{"_account_id":26567,"name":"kaufmann.smith","email":"kaufmann.smith@yahoo.com"},"state":"REVIEWER"},{"updated":"2017-09-13 08:42:18.000000000","updated_by":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"reviewer":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"state":"REVIEWER"},{"updated":"2017-09-13 09:16:18.000000000","updated_by":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"reviewer":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"state":"REVIEWER"},{"updated":"2017-09-19 15:37:05.000000000","updated_by":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"reviewer":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"state":"REVIEWER"},{"updated":"2017-09-25 13:12:55.000000000","updated_by":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"reviewer":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"state":"REVIEWER"}],"messages":[{"id":"81f33421c5a1a0bf718b6806133cd2d13e674d2f","author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"date":"2017-08-21 08:59:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"da17fa210309b16dfe2c9d01342afbb087bd42c5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-08-21 09:58:46.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-manilaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/69/495769/1/check/gate-python-manilaclient-docs-ubuntu-xenial/d3e729d//doc/build/html/ : SUCCESS in 3m 19s\n- gate-python-manilaclient-pep8-ubuntu-xenial http://logs.openstack.org/69/495769/1/check/gate-python-manilaclient-pep8-ubuntu-xenial/5a08ade/ : SUCCESS in 4m 04s\n- gate-python-manilaclient-python27-ubuntu-xenial http://logs.openstack.org/69/495769/1/check/gate-python-manilaclient-python27-ubuntu-xenial/e9fdabe/ : FAILURE in 5m 40s\n- gate-python-manilaclient-python35 http://logs.openstack.org/69/495769/1/check/gate-python-manilaclient-python35/d354248/ : FAILURE in 5m 53s\n- gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial http://logs.openstack.org/69/495769/1/check/gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial/21ec8bd/ : FAILURE in 57m 32s\n- gate-rally-dsvm-manila-multibackend http://logs.openstack.org/69/495769/1/check/gate-rally-dsvm-manila-multibackend/b33e04c/ : SUCCESS in 16m 23s (non-voting)\n- gate-rally-dsvm-manila-multibackend-no-ss http://logs.openstack.org/69/495769/1/check/gate-rally-dsvm-manila-multibackend-no-ss/9145772/ : SUCCESS in 17m 22s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"ffe1ef3b5c93169e9ed00a4c542f2bac73233197","author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"date":"2017-08-21 11:25:49.000000000","message":"Patch Set 1: Workflow-1\n\nIt is not done, and will be finish later on.","accounts_in_message":[],"_revision_number":1},{"id":"18a96b41450b2726dbc4a75532fafccf938e1edd","author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"date":"2017-08-22 06:04:31.000000000","message":"Patch Set 1: -Workflow","accounts_in_message":[],"_revision_number":1},{"id":"16fc7381543d1fa4d9fd4402519214db326b30c7","author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"date":"2017-08-22 06:05:09.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"57fd57de2585fbbcb5c6643f2b8654cc43835c1c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-08-22 07:14:03.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-manilaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/69/495769/2/check/gate-python-manilaclient-docs-ubuntu-xenial/c773a0d//doc/build/html/ : SUCCESS in 2m 51s\n- gate-python-manilaclient-pep8-ubuntu-xenial http://logs.openstack.org/69/495769/2/check/gate-python-manilaclient-pep8-ubuntu-xenial/1e54632/ : SUCCESS in 3m 32s\n- gate-python-manilaclient-python27-ubuntu-xenial http://logs.openstack.org/69/495769/2/check/gate-python-manilaclient-python27-ubuntu-xenial/09191c5/ : SUCCESS in 5m 52s\n- gate-python-manilaclient-python35 http://logs.openstack.org/69/495769/2/check/gate-python-manilaclient-python35/f8a8c28/ : FAILURE in 6m 00s\n- gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial http://logs.openstack.org/69/495769/2/check/gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial/bf002c0/ : FAILURE in 1h 07m 42s\n- gate-rally-dsvm-manila-multibackend http://logs.openstack.org/69/495769/2/check/gate-rally-dsvm-manila-multibackend/0d8fee3/ : SUCCESS in 18m 26s (non-voting)\n- gate-rally-dsvm-manila-multibackend-no-ss http://logs.openstack.org/69/495769/2/check/gate-rally-dsvm-manila-multibackend-no-ss/e222e16/ : SUCCESS in 17m 02s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"d8afbc152215f6495bf73696685865dc03c9b576","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2017-08-22 07:14:22.000000000","message":"Patch Set 2:\n\nI noticed jenkins failed, I think you hit bug(s):\n\n- gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial: https://bugs.launchpad.net/bugs/1686542\n- gate-python-manilaclient-python35: unrecognized error\n\nSome of the tests failed in a way that we did not understand. Please help us classify these issues so that they can be part of Elastic Recheck http://status.openstack.org/elastic-recheck/\nFor more details on this and other bugs, please see http://status.openstack.org/elastic-recheck/","accounts_in_message":[],"_revision_number":2},{"id":"d5e5d444b1713d30cf8eb4f1115ed70a487b7a27","author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"date":"2017-08-22 09:54:02.000000000","message":"Patch Set 2: Code-Review-1\n\nWe still have the following problem, even if we use six instead of str. Because we still need to change unicode_key_value_to_string too. Please see https://github.com/openstack/python-cinderclient/commit/797d932d0f564221a9d126d1ca49de36870c62b6\nand https://github.com/openstack/python-cinderclient/blob/master/cinderclient/utils.py#L167\n\n  File \"/usr/local/lib/python2.7/dist-packages/manilaclient/v2/shell.py\", line 1701, in do_list\n    sort_dir\u003dargs.sort_dir,\n  File \"/usr/local/lib/python2.7/dist-packages/manilaclient/api_versions.py\", line 399, in substitution\n    return method.func(obj, *args, **kwargs)\n  File \"/usr/local/lib/python2.7/dist-packages/manilaclient/v2/shares.py\", line 337, in list\n    sort_key\u003dsort_key, sort_dir\u003dsort_dir)\n  File \"/usr/local/lib/python2.7/dist-packages/manilaclient/v2/shares.py\", line 403, in do_list\n    sorted([(k, v) for (k, v) in list(search_opts.items()) if v]))\n  File \"/usr/lib/python2.7/urllib.py\", line 1343, in urlencode\n    v \u003d quote_plus(str(v))\nUnicodeEncodeError: \u0027ascii\u0027 codec can\u0027t encode character u\u0027\\u91cc\u0027 in position 0: ordinal not in range(128)\nERROR:","accounts_in_message":[],"_revision_number":2},{"id":"4d7b51ab5d7cd6b5497d9bb960199d44dfebd7a2","author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"date":"2017-08-22 10:17:33.000000000","message":"Patch Set 2:\n\n\u003e We still have the following problem, even if we use six instead of\n \u003e str. Because we still need to change unicode_key_value_to_string\n \u003e too. Please see https://github.com/openstack/python-cinderclient/commit/797d932d0f564221a9d126d1ca49de36870c62b6\n \u003e and https://github.com/openstack/python-cinderclient/blob/master/cinderclient/utils.py#L167\n \u003e \n \u003e File \"/usr/local/lib/python2.7/dist-packages/manilaclient/v2/shell.py\",\n \u003e line 1701, in do_list\n \u003e sort_dir\u003dargs.sort_dir,\n \u003e File \"/usr/local/lib/python2.7/dist-packages/manilaclient/api_versions.py\",\n \u003e line 399, in substitution\n \u003e return method.func(obj, *args, **kwargs)\n \u003e File \"/usr/local/lib/python2.7/dist-packages/manilaclient/v2/shares.py\",\n \u003e line 337, in list\n \u003e sort_key\u003dsort_key, sort_dir\u003dsort_dir)\n \u003e File \"/usr/local/lib/python2.7/dist-packages/manilaclient/v2/shares.py\",\n \u003e line 403, in do_list\n \u003e sorted([(k, v) for (k, v) in list(search_opts.items()) if v]))\n \u003e File \"/usr/lib/python2.7/urllib.py\", line 1343, in urlencode\n \u003e v \u003d quote_plus(str(v))\n \u003e UnicodeEncodeError: \u0027ascii\u0027 codec can\u0027t encode character u\u0027\\u91cc\u0027\n \u003e in position 0: ordinal not in range(128)\n \u003e ERROR:\n\n@zhongjun -\nI followed the cinderclient solution to fix this, it still failed.\nDo you mean that the same bug is existed in cinderclient as well?","accounts_in_message":[],"_revision_number":2},{"id":"564185606ac96a640ce3f3a512aa1747be1de73f","author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"date":"2017-08-22 11:46:09.000000000","message":"Patch Set 2:\n\nHi junbo.li, The cinder already fixed the same bug.\nWhat is your problem now?\nAfter I tested it is work. Maybe you could pay attention on the parameter format when you use unicode_key_value_to_string function. The correct format is dict,\nBut our query_string(https://github.com/openstack/python-manilaclient/blob/master/manilaclient/v2/shares.py#L403) is a list.\n\np query_params\n{\u0027name\u0027: u\u0027\\u6d4b\\u8bd5\u0027}\n\np query_string\n[(\u0027name\u0027, u\u0027\\u6d4b\\u8bd5\u0027)]","accounts_in_message":[],"_revision_number":2},{"id":"1b2b9a376579fc58234a57cbb7d6b41c2d8256f1","author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"date":"2017-08-23 08:54:46.000000000","message":"Patch Set 2:\n\n\u003e Hi junbo.li, The cinder already fixed the same bug.\n \u003e What is your problem now?\n \u003e After I tested it is work. Maybe you could pay attention on the\n \u003e parameter format when you use unicode_key_value_to_string function.\n \u003e The correct format is dict,\n \u003e But our query_string(https://github.com/openstack/python-manilaclient/blob/master/manilaclient/v2/shares.py#L403)\n \u003e is a list.\n \u003e \n \u003e p query_params\n \u003e {\u0027name\u0027: u\u0027\\u6d4b\\u8bd5\u0027}\n \u003e \n \u003e p query_string\n \u003e [(\u0027name\u0027, u\u0027\\u6d4b\\u8bd5\u0027)]\n\nHi zhongjun,\nI double checked the query_params and query_string, both were the same format.\nThe problem now is it works good when filter query by unicode name or description in PY2, but things get different when we come to PY3, the UT will fail.\nCan you give me any assistants, Thanks.","accounts_in_message":[],"_revision_number":2},{"id":"9415526cc9f4a3ba7ec666b710345f7aa1421635","author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"date":"2017-08-24 09:28:15.000000000","message":"Patch Set 2:\n\nthings get different when we come to PY3, the UT will fail.\nCan you give me any assistants, Thanks.\n\nCould you give me your error info?","accounts_in_message":[],"_revision_number":2},{"id":"0c594951f1dc1d1d9162be1ab9c297a1ec028ee2","author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"date":"2017-08-24 09:34:59.000000000","message":"Patch Set 2:\n\n\u003e things get different when we come to PY3, the UT will fail.\n \u003e Can you give me any assistants, Thanks.\n \u003e \n \u003e Could you give me your error info?\n\nThis is the PY3 error message:\nmanilaclient.tests.unit.v2.test_shell.ShellTest.test_list_filter_by_inexact_unicode_description\n-----------------------------------------------------------------------------------------------\nCaptured traceback:\n~~~~~~~~~~~~~~~~~~~\n     b\u0027Traceback (most recent call last):\u0027\n     b\u0027  File \"/home/jenkins/workspace/gate-python-manilaclient-python35/manilaclient/tests/unit/v2/test_shell.py\", line 278, in test_list_filter_by_inexact_unicode_description\u0027\n     b\"    \u0027/shares/detail?description%7E\u003d%5Cu674e\u0027)\"\n     b\u0027  File \"/home/jenkins/workspace/gate-python-manilaclient-python35/manilaclient/tests/unit/v2/test_shell.py\", line 106, in assert_called\u0027\n     b\u0027    return self.shell.cs.assert_called(method, url, body, **kwargs)\u0027\n     b\u0027  File \"/home/jenkins/workspace/gate-python-manilaclient-python35/manilaclient/tests/unit/fakes.py\", line 49, in assert_called\u0027\n     b\u0027    expected + called)\u0027\n     b\u0027AssertionError: Expected GET /shares/detail?description%7E\u003d%5Cu674e; got GET /shares/detail?description%7E\u003d%E6%9D%8E\u0027\n     b\u0027\u0027 \nFor details, refer to:\nhttp://logs.openstack.org/69/495769/2/check/gate-python-manilaclient-python35/f8a8c28/console.html","accounts_in_message":[],"_revision_number":2},{"id":"977c1895d88df5ac8bca1f4e7d54a78c2a47e31b","author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"date":"2017-08-24 11:54:56.000000000","message":"Patch Set 2:\n\nHi, you could change the except value when \"if six.PY2:\" is false.","accounts_in_message":[],"_revision_number":2},{"id":"f01b343b3739b75ff39e43f94f2e606464bc6b73","author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"date":"2017-08-25 06:26:33.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"50d932a654c76e47f381d565f321b1681a84b915","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-08-25 07:36:07.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-manilaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/69/495769/3/check/gate-python-manilaclient-docs-ubuntu-xenial/01d44e4//doc/build/html/ : SUCCESS in 3m 18s\n- gate-python-manilaclient-pep8-ubuntu-xenial http://logs.openstack.org/69/495769/3/check/gate-python-manilaclient-pep8-ubuntu-xenial/b32c8c3/ : SUCCESS in 4m 13s\n- gate-python-manilaclient-python27-ubuntu-xenial http://logs.openstack.org/69/495769/3/check/gate-python-manilaclient-python27-ubuntu-xenial/7d80152/ : SUCCESS in 5m 16s\n- gate-python-manilaclient-python35 http://logs.openstack.org/69/495769/3/check/gate-python-manilaclient-python35/eac64aa/ : SUCCESS in 4m 46s\n- gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial http://logs.openstack.org/69/495769/3/check/gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial/989539c/ : SUCCESS in 1h 05m 36s\n- gate-rally-dsvm-manila-multibackend http://logs.openstack.org/69/495769/3/check/gate-rally-dsvm-manila-multibackend/f414edd/ : SUCCESS in 19m 41s (non-voting)\n- gate-rally-dsvm-manila-multibackend-no-ss http://logs.openstack.org/69/495769/3/check/gate-rally-dsvm-manila-multibackend-no-ss/96b766c/ : SUCCESS in 16m 49s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"57a3f3bf21277718bc3542b1e320f741c70aa069","author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"date":"2017-08-25 07:54:23.000000000","message":"Patch Set 3:\n\n\u003e Hi, you could change the except value when \"if six.PY2:\" is false.\nIt turned out to be the unit test problems, So I update the UT, it works OK, Thank zhongjun.","accounts_in_message":[],"_revision_number":3},{"id":"d50a37161e8dc43a82aaf042ccd2179ecf91bdc1","author":{"_account_id":26567,"name":"kaufmann.smith","email":"kaufmann.smith@yahoo.com"},"date":"2017-08-28 13:56:14.000000000","message":"Patch Set 3: Code-Review+1\n\nThis works for me, Thanks.","accounts_in_message":[],"_revision_number":3},{"id":"dee7bd546d93501411788f81d3314822aa3720e2","author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"date":"2017-09-13 08:42:18.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"07686c6d42502d77566575be830bc8d9e6f81f59","author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"date":"2017-09-13 09:16:18.000000000","message":"Patch Set 3: Code-Review+2\n\nThanks for the fix!","accounts_in_message":[],"_revision_number":3},{"id":"85c33b19e798f857adfd60ab1b7360b9d2fac29f","author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"date":"2017-09-19 14:46:26.000000000","message":"Patch Set 3:\n\nWould be great to see functional test for it.","accounts_in_message":[],"_revision_number":3},{"id":"2be04baa7c9f86f22e8e586fc1df8d7f6fa13067","author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"date":"2017-09-19 15:37:05.000000000","message":"Patch Set 3: Code-Review-1\n\nAlso, this commit and 3 other [1], [2] and [3] are, de-facto, the same bug, just spreaded among various code lines. And bug should have been named something like \"\u0027List\u0027 command filters do not accept unicode symbols\"...\n\n[1] https://review.openstack.org/#/c/497753/\n[2] https://review.openstack.org/#/c/497758/\n[3] https://review.openstack.org/#/c/497743/","accounts_in_message":[],"_revision_number":3},{"id":"e4e869f22f09f67d203fca446dbe704dbe9df74d","author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"date":"2017-09-25 13:12:55.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"fb1ebc0011519f37c3bd87a49377f82e0a7707a6","author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"date":"2017-10-09 08:29:44.000000000","message":"Abandoned\n\nMerge this patch to https://review.openstack.org/#/c/497758/","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"389238c7467fc1c196f17bb896c99a8a0c2c3996","revisions":{"04a383da6b605f4b7f7cc8b0abaa1f093f467c9f":{"kind":"REWORK","_number":1,"created":"2017-08-21 08:59:11.000000000","uploader":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"ref":"refs/changes/69/495769/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/69/495769/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/69/495769/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/69/495769/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/69/495769/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/69/495769/1"}}},"commit":{"parents":[{"commit":"72331f014282e5051201a7877223b04bb6d99ba3","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/72331f014282e5051201a7877223b04bb6d99ba3"}]}],"author":{"name":"junboli","email":"junbo85.li@gmail.com","date":"2017-08-21 08:50:56.000000000","tz":480},"committer":{"name":"junboli","email":"junbo85.li@gmail.com","date":"2017-08-21 08:50:56.000000000","tz":480},"subject":"Fix unicode value filters for share list","message":"Fix unicode value filters for share list\n\nWhen using the share name or description to filter the share list,\nif the name or description is unicode value it may fail. This change\nis to fix them.\n\nChange-Id: I929b65d0807a60a84842fa78c5324e290bde0520\nCloses-bug: #1712002\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/04a383da6b605f4b7f7cc8b0abaa1f093f467c9f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/04a383da6b605f4b7f7cc8b0abaa1f093f467c9f"}]},"branch":"refs/heads/master"},"3eb839ac655fb527008ab048b05f39fec8073b09":{"kind":"REWORK","_number":2,"created":"2017-08-22 06:05:09.000000000","uploader":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"ref":"refs/changes/69/495769/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/69/495769/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/69/495769/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/69/495769/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/69/495769/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/69/495769/2"}}},"commit":{"parents":[{"commit":"72331f014282e5051201a7877223b04bb6d99ba3","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/72331f014282e5051201a7877223b04bb6d99ba3"}]}],"author":{"name":"junboli","email":"junbo85.li@gmail.com","date":"2017-08-21 08:50:56.000000000","tz":480},"committer":{"name":"junboli","email":"junbo85.li@gmail.com","date":"2017-08-22 06:04:42.000000000","tz":480},"subject":"Fix unicode value filters for share list","message":"Fix unicode value filters for share list\n\nWhen using the share name or description to filter the share list,\nif the name or description is unicode value it may fail. This change\nis to fix them.\n\nChange-Id: I929b65d0807a60a84842fa78c5324e290bde0520\nCloses-bug: #1712002\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/3eb839ac655fb527008ab048b05f39fec8073b09"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/3eb839ac655fb527008ab048b05f39fec8073b09"}]},"branch":"refs/heads/master"},"389238c7467fc1c196f17bb896c99a8a0c2c3996":{"kind":"REWORK","_number":3,"created":"2017-08-25 06:26:33.000000000","uploader":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"ref":"refs/changes/69/495769/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/69/495769/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/69/495769/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/69/495769/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/69/495769/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/69/495769/3"}}},"commit":{"parents":[{"commit":"767cfa6723fc2db3b8e896bc250581f42afea89c","subject":"Add license to doc/source/conf.py","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/767cfa6723fc2db3b8e896bc250581f42afea89c"}]}],"author":{"name":"junboli","email":"junbo85.li@gmail.com","date":"2017-08-25 06:24:57.000000000","tz":480},"committer":{"name":"junboli","email":"junbo85.li@gmail.com","date":"2017-08-25 06:24:57.000000000","tz":480},"subject":"Fix unicode value filters for share list","message":"Fix unicode value filters for share list\n\nWhen using the share name or description to filter the share list,\nif the name or description is unicode value it may fail. This change\nis to fix them.\n\nChange-Id: I929b65d0807a60a84842fa78c5324e290bde0520\nCloses-bug: #1712002\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/389238c7467fc1c196f17bb896c99a8a0c2c3996"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/389238c7467fc1c196f17bb896c99a8a0c2c3996"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
