)]}'
{"manilaclient/tests/functional/test_share_networks.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"8f50e749372c5c6574cbaac3450480dcba187319","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            filters\u003dfilters)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        self.assertGreater(len(share_networks), 0)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @ddt.data(\u0027name\u0027)"},{"line_number":176,"context_line":"    def test_list_share_networks_by_unicode_name_inexact(self, option):"},{"line_number":177,"context_line":"        self.create_share_network("},{"line_number":178,"context_line":"            name\u003du\u0027测试名字\u0027,"},{"line_number":179,"context_line":"            description\u003d\u0027fake_description_inexact\u0027,"},{"line_number":180,"context_line":"            neutron_net_id\u003d\u0027fake_neutron_net_id\u0027,"},{"line_number":181,"context_line":"            neutron_subnet_id\u003d\u0027fake_neutron_subnet_id\u0027,"},{"line_number":182,"context_line":"        )"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        filters \u003d {option + \u0027~\u0027: u\u0027测试\u0027}"},{"line_number":185,"context_line":"        share_networks \u003d self.admin_client.list_share_networks("},{"line_number":186,"context_line":"            filters\u003dfilters)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        self.assertGreater(len(share_networks), 0)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    @ddt.data(\u0027description\u0027)"},{"line_number":191,"context_line":"    def test_list_share_networks_by_unicode_description_inexact(self, option):"},{"line_number":192,"context_line":"        self.create_share_network("},{"line_number":193,"context_line":"            name\u003ddata_utils.rand_name(\u0027autotest_inexact\u0027),"},{"line_number":194,"context_line":"            description\u003du\u0027测试描述\u0027,"},{"line_number":195,"context_line":"            neutron_net_id\u003d\u0027fake_neutron_net_id\u0027,"},{"line_number":196,"context_line":"            neutron_subnet_id\u003d\u0027fake_neutron_subnet_id\u0027,"},{"line_number":197,"context_line":"        )"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        filters \u003d {option + \u0027~\u0027: u\u0027测试\u0027}"},{"line_number":200,"context_line":"        share_networks \u003d self.admin_client.list_share_networks("},{"line_number":201,"context_line":"            filters\u003dfilters)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        self.assertGreater(len(share_networks), 0)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f485f77_7eb76388","line":203,"range":{"start_line":174,"start_character":0,"end_line":203,"end_character":50},"updated":"2017-11-10 06:37:46.000000000","message":"If you only have one option value, then you don\u0027t have to use ddt. Maybe you could change it to:\n|def test_list_share_networks_by_unicode_name_inexact(self):\n|    filters \u003d {\u0027name\u0027 + \u0027~\u0027: u\u0027测试\u0027}\nIf you want to use ddt in your test and make your test more simple, you could change it to :\n|@ddt.data({\u0027option\u0027: {\u0027name\u0027: \"...\", \u0027description\u0027: \".\"},\n|           \u0027filter\u0027: \u0027name~\u0027},\n|           {\u0027option\u0027: {description\u0027: \"xxx\"},\n|            \u0027filter\u0027: \u0027description~\u0027},)\n|@ddt.unpack\n|def test_list_shares_by_unicode(self, option, filter):\n|    self.create_share_network(..., **option)\n|    filters \u003d {filter: option.get(filter.rstrip(\u0027~\u0027))}\n|... \nor |    filters \u003d {filter: u\u0027测试\u0027}","commit_id":"c62b58ae469c7c334c3fe889ba615dadfcd11913"},{"author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"change_message_id":"9005041373070f5a1be3252eecfa0e22616e87bb","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            filters\u003dfilters)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        self.assertGreater(len(share_networks), 0)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @ddt.data(\u0027name\u0027)"},{"line_number":176,"context_line":"    def test_list_share_networks_by_unicode_name_inexact(self, option):"},{"line_number":177,"context_line":"        self.create_share_network("},{"line_number":178,"context_line":"            name\u003du\u0027测试名字\u0027,"},{"line_number":179,"context_line":"            description\u003d\u0027fake_description_inexact\u0027,"},{"line_number":180,"context_line":"            neutron_net_id\u003d\u0027fake_neutron_net_id\u0027,"},{"line_number":181,"context_line":"            neutron_subnet_id\u003d\u0027fake_neutron_subnet_id\u0027,"},{"line_number":182,"context_line":"        )"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        filters \u003d {option + \u0027~\u0027: u\u0027测试\u0027}"},{"line_number":185,"context_line":"        share_networks \u003d self.admin_client.list_share_networks("},{"line_number":186,"context_line":"            filters\u003dfilters)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        self.assertGreater(len(share_networks), 0)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    @ddt.data(\u0027description\u0027)"},{"line_number":191,"context_line":"    def test_list_share_networks_by_unicode_description_inexact(self, option):"},{"line_number":192,"context_line":"        self.create_share_network("},{"line_number":193,"context_line":"            name\u003ddata_utils.rand_name(\u0027autotest_inexact\u0027),"},{"line_number":194,"context_line":"            description\u003du\u0027测试描述\u0027,"},{"line_number":195,"context_line":"            neutron_net_id\u003d\u0027fake_neutron_net_id\u0027,"},{"line_number":196,"context_line":"            neutron_subnet_id\u003d\u0027fake_neutron_subnet_id\u0027,"},{"line_number":197,"context_line":"        )"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        filters \u003d {option + \u0027~\u0027: u\u0027测试\u0027}"},{"line_number":200,"context_line":"        share_networks \u003d self.admin_client.list_share_networks("},{"line_number":201,"context_line":"            filters\u003dfilters)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        self.assertGreater(len(share_networks), 0)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f485f77_ef903f98","line":203,"range":{"start_line":174,"start_character":0,"end_line":203,"end_character":50},"in_reply_to":"1f485f77_7eb76388","updated":"2017-11-10 09:26:21.000000000","message":"Thanks for your comments, updates have been uploaded.","commit_id":"c62b58ae469c7c334c3fe889ba615dadfcd11913"}],"manilaclient/tests/functional/test_shares_listing.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"8f50e749372c5c6574cbaac3450480dcba187319","unresolved":false,"context_lines":[{"line_number":320,"context_line":"        self.assertTrue("},{"line_number":321,"context_line":"            any(self.private_share[\u0027id\u0027] \u003d\u003d s[\u0027ID\u0027] for s in shares))"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    @ddt.data(\u0027name\u0027)"},{"line_number":324,"context_line":"    def test_list_shares_by_unicode_name_inexact(self, option):"},{"line_number":325,"context_line":"        self.create_share("},{"line_number":326,"context_line":"            name\u003du\u0027测试名字\u0027,"},{"line_number":327,"context_line":"            description\u003d\"\","},{"line_number":328,"context_line":"            public\u003dFalse,"},{"line_number":329,"context_line":"            cleanup_in_class\u003dTrue,"},{"line_number":330,"context_line":"            client\u003dself.get_user_client(),"},{"line_number":331,"context_line":"            wait_for_creation\u003dFalse)"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        filters \u003d {option + \u0027~\u0027: u\u0027测试\u0027}"},{"line_number":334,"context_line":"        shares \u003d self.user_client.list_shares(filters\u003dfilters)"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        self.assertGreater(len(shares), 0)"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    @ddt.data(\u0027description\u0027)"},{"line_number":339,"context_line":"    def test_list_shares_by_unicode_description_inexact(self, option):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f485f77_7e34034b","line":336,"range":{"start_line":323,"start_character":0,"end_line":336,"end_character":42},"updated":"2017-11-10 06:37:46.000000000","message":"If you only have one option value, then you don\u0027t have to use ddt. Maybe you could change it to:\n|def test_list_shares_by_unicode_name_inexact(self):\n|    filters \u003d {\u0027name\u0027 + \u0027~\u0027: u\u0027测试\u0027}\nIf you want to use ddt in your test and make your test more simple, you could change it to :\n|@ddt.data({\u0027option\u0027: {\u0027name\u0027: \"...\", \u0027description\u0027: \".\"},\n|           \u0027filter\u0027: \u0027name~\u0027},\n|           {\u0027option\u0027: {description\u0027: \"xxx\"},\n|            \u0027filter\u0027: \u0027description~\u0027},)\n|@ddt.unpack\n|def test_list_shares_by_unicode(self, option, filter):\n|    self.create_share(..., **option)\n|    filters \u003d {filter: option.get(filter.rstrip(\u0027~\u0027))}\n|... \nor |    filters \u003d {filter: u\u0027测试\u0027}","commit_id":"c62b58ae469c7c334c3fe889ba615dadfcd11913"},{"author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"change_message_id":"9005041373070f5a1be3252eecfa0e22616e87bb","unresolved":false,"context_lines":[{"line_number":320,"context_line":"        self.assertTrue("},{"line_number":321,"context_line":"            any(self.private_share[\u0027id\u0027] \u003d\u003d s[\u0027ID\u0027] for s in shares))"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    @ddt.data(\u0027name\u0027)"},{"line_number":324,"context_line":"    def test_list_shares_by_unicode_name_inexact(self, option):"},{"line_number":325,"context_line":"        self.create_share("},{"line_number":326,"context_line":"            name\u003du\u0027测试名字\u0027,"},{"line_number":327,"context_line":"            description\u003d\"\","},{"line_number":328,"context_line":"            public\u003dFalse,"},{"line_number":329,"context_line":"            cleanup_in_class\u003dTrue,"},{"line_number":330,"context_line":"            client\u003dself.get_user_client(),"},{"line_number":331,"context_line":"            wait_for_creation\u003dFalse)"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        filters \u003d {option + \u0027~\u0027: u\u0027测试\u0027}"},{"line_number":334,"context_line":"        shares \u003d self.user_client.list_shares(filters\u003dfilters)"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        self.assertGreater(len(shares), 0)"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    @ddt.data(\u0027description\u0027)"},{"line_number":339,"context_line":"    def test_list_shares_by_unicode_description_inexact(self, option):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f485f77_8fed4b27","line":336,"range":{"start_line":323,"start_character":0,"end_line":336,"end_character":42},"in_reply_to":"1f485f77_7e34034b","updated":"2017-11-10 09:26:21.000000000","message":"Thanks zhongjun, updates have been uploaded.","commit_id":"c62b58ae469c7c334c3fe889ba615dadfcd11913"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"8f50e749372c5c6574cbaac3450480dcba187319","unresolved":false,"context_lines":[{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        self.assertGreater(len(shares), 0)"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    @ddt.data(\u0027description\u0027)"},{"line_number":339,"context_line":"    def test_list_shares_by_unicode_description_inexact(self, option):"},{"line_number":340,"context_line":"        self.create_share("},{"line_number":341,"context_line":"            name\u003ddata_utils.rand_name(\u0027autotest_inexact\u0027),"},{"line_number":342,"context_line":"            description\u003du\u0027测试描述\u0027,"},{"line_number":343,"context_line":"            public\u003dFalse,"},{"line_number":344,"context_line":"            cleanup_in_class\u003dTrue,"},{"line_number":345,"context_line":"            client\u003dself.get_user_client(),"},{"line_number":346,"context_line":"            wait_for_creation\u003dFalse)"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"        filters \u003d {option + \u0027~\u0027: u\u0027测试\u0027}"},{"line_number":349,"context_line":"        shares \u003d self.user_client.list_shares(filters\u003dfilters)"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        self.assertGreater(len(shares), 0)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f485f77_fe9113f3","line":351,"range":{"start_line":338,"start_character":4,"end_line":351,"end_character":42},"updated":"2017-11-10 06:37:46.000000000","message":"above","commit_id":"c62b58ae469c7c334c3fe889ba615dadfcd11913"}]}
