)]}'
{"id":"openstack%2Fpython-manilaclient~516804","triplet_id":"openstack%2Fpython-manilaclient~master~Ib863c60a4698cbae01654bd8eea159b04d531569","project":"openstack/python-manilaclient","branch":"master","hashtags":[],"change_id":"Ib863c60a4698cbae01654bd8eea159b04d531569","subject":"Compare API call body in assertions with respect to values","status":"MERGED","created":"2017-11-01 01:16:05.000000000","updated":"2017-11-25 09:21:18.000000000","submitted":"2017-11-25 09:21:18.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"516804-1511601678000-9a9506ce","meta_rev_id":"62da13b3d3a53d6610368935ba1b1dc0b0627146","_number":516804,"virtual_id_number":516804,"owner":{"_account_id":23512,"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","username":"alexander.pugachev"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":25747,"name":"Debo Zhang","email":"zhangdebo@inspur.com","username":"zhangdebo"},{"value":0,"_account_id":23512,"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","username":"alexander.pugachev"},{"value":0,"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"value":0,"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},{"value":2,"date":"2017-11-25 09:21:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"all":[{"value":0,"_account_id":25747,"name":"Debo Zhang","email":"zhangdebo@inspur.com","username":"zhangdebo"},{"value":0,"_account_id":23512,"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","username":"alexander.pugachev"},{"value":2,"date":"2017-11-24 12:44:48.000000000","_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"value":2,"date":"2017-11-25 08:22:28.000000000","_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"all":[{"value":0,"_account_id":25747,"name":"Debo Zhang","email":"zhangdebo@inspur.com","username":"zhangdebo"},{"value":0,"_account_id":23512,"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","username":"alexander.pugachev"},{"value":0,"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"value":1,"date":"2017-11-25 08:23:02.000000000","_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23512,"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","username":"alexander.pugachev"},{"_account_id":25747,"name":"Debo Zhang","email":"zhangdebo@inspur.com","username":"zhangdebo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-11-09 01:53:02.000000000","updated_by":{"_account_id":25747,"name":"Debo Zhang","email":"zhangdebo@inspur.com","username":"zhangdebo"},"reviewer":{"_account_id":25747,"name":"Debo Zhang","email":"zhangdebo@inspur.com","username":"zhangdebo"},"state":"REVIEWER"},{"updated":"2017-11-24 12:44:48.000000000","updated_by":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"reviewer":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"state":"REVIEWER"},{"updated":"2017-11-25 08:23:02.000000000","updated_by":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"reviewer":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"state":"REVIEWER"},{"updated":"2017-11-25 09:21:17.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"eb61823f45c3bf55617566c38eaf202ac5c093cf","author":{"_account_id":23512,"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","username":"alexander.pugachev"},"date":"2017-11-01 01:16:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7310ed5d17fdb7f2edabf6a464105e1be6f0383c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-01 01:48:37.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- build-openstack-sphinx-docs http://logs.openstack.org/04/516804/1/check/build-openstack-sphinx-docs/04bd500/html/ : SUCCESS in 3m 25s\n- openstack-tox-pep8 http://logs.openstack.org/04/516804/1/check/openstack-tox-pep8/6ddb632/ : SUCCESS in 3m 45s\n- openstack-tox-py27 http://logs.openstack.org/04/516804/1/check/openstack-tox-py27/3cf0b48/ : SUCCESS in 7m 29s\n- openstack-tox-py35 http://logs.openstack.org/04/516804/1/check/openstack-tox-py35/d5a8510/ : SUCCESS in 5m 58s\n- legacy-manilaclient-dsvm-neutron-functional http://logs.openstack.org/04/516804/1/check/legacy-manilaclient-dsvm-neutron-functional/0f2448d/ : FAILURE in 30m 41s\n- rally-dsvm-manila-multibackend http://logs.openstack.org/04/516804/1/check/rally-dsvm-manila-multibackend/094ca3b/ : SUCCESS in 18m 32s (non-voting)\n- rally-dsvm-manila-multibackend-no-ss http://logs.openstack.org/04/516804/1/check/rally-dsvm-manila-multibackend-no-ss/dd2420d/ : SUCCESS in 18m 53s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"7c3fd5b6e86638301fd7017ffe2ad03441ed8b55","author":{"_account_id":23512,"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","username":"alexander.pugachev"},"date":"2017-11-03 19:59:45.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"662282f5df97d3e0c50ebd638cc83066e8271e17","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-03 21:12:05.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- build-openstack-sphinx-docs http://logs.openstack.org/04/516804/1/check/build-openstack-sphinx-docs/f88b7fc/html/ : SUCCESS in 3m 43s\n- openstack-tox-pep8 http://logs.openstack.org/04/516804/1/check/openstack-tox-pep8/fe30bca/ : SUCCESS in 4m 03s\n- openstack-tox-py27 http://logs.openstack.org/04/516804/1/check/openstack-tox-py27/437bacf/ : SUCCESS in 11m 31s\n- openstack-tox-py35 http://logs.openstack.org/04/516804/1/check/openstack-tox-py35/a1e15d2/ : SUCCESS in 5m 53s\n- legacy-manilaclient-dsvm-neutron-functional http://logs.openstack.org/04/516804/1/check/legacy-manilaclient-dsvm-neutron-functional/43184c9/ : FAILURE in 1h 11m 15s\n- rally-dsvm-manila-multibackend http://logs.openstack.org/04/516804/1/check/rally-dsvm-manila-multibackend/2fb568f/ : SUCCESS in 24m 31s (non-voting)\n- rally-dsvm-manila-multibackend-no-ss http://logs.openstack.org/04/516804/1/check/rally-dsvm-manila-multibackend-no-ss/c48d389/ : SUCCESS in 19m 25s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"16d969914e8178378003e5a756b0a2d92aff55c9","author":{"_account_id":23512,"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","username":"alexander.pugachev"},"date":"2017-11-03 22:41:12.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"e50be692f71a47976e9f8d67596d3730763fd82b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-03 23:47:35.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/04/516804/1/check/build-openstack-sphinx-docs/1344a89/html/ : SUCCESS in 4m 09s\n- openstack-tox-pep8 http://logs.openstack.org/04/516804/1/check/openstack-tox-pep8/694b0ee/ : SUCCESS in 5m 03s\n- openstack-tox-py27 http://logs.openstack.org/04/516804/1/check/openstack-tox-py27/1aea00b/ : SUCCESS in 7m 53s\n- openstack-tox-py35 http://logs.openstack.org/04/516804/1/check/openstack-tox-py35/a141b8f/ : SUCCESS in 6m 28s\n- legacy-manilaclient-dsvm-neutron-functional http://logs.openstack.org/04/516804/1/check/legacy-manilaclient-dsvm-neutron-functional/2cadae4/ : SUCCESS in 1h 03m 01s\n- rally-dsvm-manila-multibackend http://logs.openstack.org/04/516804/1/check/rally-dsvm-manila-multibackend/d7a21aa/ : SUCCESS in 21m 37s (non-voting)\n- rally-dsvm-manila-multibackend-no-ss http://logs.openstack.org/04/516804/1/check/rally-dsvm-manila-multibackend-no-ss/f3bc8f5/ : SUCCESS in 17m 09s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"e554a2a4372974b88033548b480fb9a04f6984e4","author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"date":"2017-11-07 02:58:57.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"eec0491fb7bf012d9a014b70d5715003b25ed085","author":{"_account_id":23512,"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","username":"alexander.pugachev"},"date":"2017-11-07 12:13:12.000000000","message":"Patch Set 2: Published edit on patch set 1.","accounts_in_message":[],"_revision_number":2},{"id":"410892e2c6518ce7ff898b01df442e11f7c7d9d0","author":{"_account_id":23512,"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","username":"alexander.pugachev"},"date":"2017-11-07 12:13:51.000000000","message":"Patch Set 2:\n\n(2 comments)\n\nRight, sorted() produces \u003clist\u003e values in Python 3 too.","accounts_in_message":[],"_revision_number":2},{"id":"c372c1ba8b109c0e42c866610395feac33ce0b53","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-07 13:29:02.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/04/516804/2/check/build-openstack-sphinx-docs/e8ccedb/html/ : SUCCESS in 3m 51s\n- openstack-tox-pep8 http://logs.openstack.org/04/516804/2/check/openstack-tox-pep8/df80e17/ : SUCCESS in 3m 53s\n- openstack-tox-py27 http://logs.openstack.org/04/516804/2/check/openstack-tox-py27/637b9d6/ : SUCCESS in 5m 57s\n- openstack-tox-py35 http://logs.openstack.org/04/516804/2/check/openstack-tox-py35/d72fe20/ : SUCCESS in 5m 45s\n- legacy-manilaclient-dsvm-neutron-functional http://logs.openstack.org/04/516804/2/check/legacy-manilaclient-dsvm-neutron-functional/63e4fc9/ : SUCCESS in 1h 08m 12s\n- rally-dsvm-manila-multibackend http://logs.openstack.org/04/516804/2/check/rally-dsvm-manila-multibackend/40190b6/ : SUCCESS in 18m 31s (non-voting)\n- rally-dsvm-manila-multibackend-no-ss http://logs.openstack.org/04/516804/2/check/rally-dsvm-manila-multibackend-no-ss/f825058/ : SUCCESS in 18m 03s (non-voting)\n- manilaclient-dsvm-neutron-functional http://logs.openstack.org/04/516804/2/check/manilaclient-dsvm-neutron-functional/2dfd449/ : SUCCESS in 59m 16s","accounts_in_message":[],"_revision_number":2},{"id":"9254dc771c0b05e0b99163a9d55a713e450a5862","author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"date":"2017-11-09 01:48:05.000000000","message":"Patch Set 2: Code-Review+1\n\nThanks","accounts_in_message":[],"_revision_number":2},{"id":"96348a3c7c33fe0f28ca32920fb8acd8964d8d82","author":{"_account_id":25747,"name":"Debo Zhang","email":"zhangdebo@inspur.com","username":"zhangdebo"},"date":"2017-11-09 01:53:02.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"a5285a8026eec36fbcbd9249e0fc4aafdbd6801f","author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"date":"2017-11-21 16:52:51.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)\n\nPlease see my python question about dictionary comparison inline.  I\u0027m not a python expert so I might be wrong ...\n\nThe -1 is for the commit message which should explain why the content of the tests had to change.  I find myself wondering about all the reductions in expected extra specs.  Were the original tests just that much wrong?\n\nSpeaking of which, shouldn\u0027t this have its own bug beyond helping to improve test coverage?  It seems like you found an important bug in the way we were testing that reveals that a number of our tests were just written wrong and passing only because we were not comparing dictionaries correctly.","accounts_in_message":[],"_revision_number":2},{"id":"9ecd887f33d31d5465f130a4995739da2d4c4fed","author":{"_account_id":23512,"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","username":"alexander.pugachev"},"date":"2017-11-22 11:15:24.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"c5dc5943706ef1cf3b46ac72a8072761b440e9ab","author":{"_account_id":23512,"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","username":"alexander.pugachev"},"date":"2017-11-22 11:23:00.000000000","message":"Patch Set 2:\n\nAs I understand, the tests had been comparing to wrong specs. To make the tests pass I had not only collapse the expected values, but have the dicts\u0027 values corrected, too.\n\nFor example.\n\nSee line 2049 of original file for example, the description of the group was wrong, maybe copy-pasted from somewhere. \n\nThe line 2623 is more interesting, it shows that the value used by in the assert was the top-level key of expected dict. The key \u0027preserve-metadata\u0027 of internal dict had to be written with underscore.\n\nAnd so on.\n\nYou are right, I had to create a separate bug for this in the first place.","accounts_in_message":[],"_revision_number":2},{"id":"5b64017daeea6b0259135c130b9b0b14dfbc5986","author":{"_account_id":23512,"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","username":"alexander.pugachev"},"date":"2017-11-23 12:39:39.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"0325e5f12fd9e2221d1b685c2f2bd8b5c37a9c24","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-23 13:46:01.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/04/516804/3/check/build-openstack-sphinx-docs/9ad1465/html/ : SUCCESS in 4m 04s\n- openstack-tox-pep8 http://logs.openstack.org/04/516804/3/check/openstack-tox-pep8/96c36b9/ : SUCCESS in 4m 46s\n- openstack-tox-py27 http://logs.openstack.org/04/516804/3/check/openstack-tox-py27/ed7772c/ : SUCCESS in 7m 17s\n- openstack-tox-py35 http://logs.openstack.org/04/516804/3/check/openstack-tox-py35/e937ace/ : SUCCESS in 5m 27s\n- manilaclient-dsvm-neutron-functional http://logs.openstack.org/04/516804/3/check/manilaclient-dsvm-neutron-functional/aa65704/ : SUCCESS in 1h 05m 08s\n- rally-dsvm-manila-multibackend http://logs.openstack.org/04/516804/3/check/rally-dsvm-manila-multibackend/25f86ac/ : SUCCESS in 16m 02s (non-voting)\n- rally-dsvm-manila-multibackend-no-ss http://logs.openstack.org/04/516804/3/check/rally-dsvm-manila-multibackend-no-ss/bcc381c/ : SUCCESS in 16m 27s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"5466827139506a93bf4fb4ab4154ed03eafc38f9","author":{"_account_id":23512,"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","username":"alexander.pugachev"},"date":"2017-11-24 10:21:13.000000000","message":"Patch Set 4: Commit message was updated.","accounts_in_message":[],"_revision_number":4},{"id":"547bf9aa72d303bf5d82c5a5183a6eae0748cb0c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-24 11:21:08.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/04/516804/4/check/build-openstack-sphinx-docs/f35e0ed/html/ : SUCCESS in 2m 58s\n- openstack-tox-pep8 http://logs.openstack.org/04/516804/4/check/openstack-tox-pep8/3c5fa63/ : SUCCESS in 3m 53s\n- openstack-tox-py27 http://logs.openstack.org/04/516804/4/check/openstack-tox-py27/d8550c4/ : SUCCESS in 5m 44s\n- openstack-tox-py35 http://logs.openstack.org/04/516804/4/check/openstack-tox-py35/c7241e7/ : SUCCESS in 5m 22s\n- manilaclient-dsvm-neutron-functional http://logs.openstack.org/04/516804/4/check/manilaclient-dsvm-neutron-functional/a912033/ : SUCCESS in 52m 24s\n- rally-dsvm-manila-multibackend http://logs.openstack.org/04/516804/4/check/rally-dsvm-manila-multibackend/17ffead/ : SUCCESS in 20m 30s (non-voting)\n- rally-dsvm-manila-multibackend-no-ss http://logs.openstack.org/04/516804/4/check/rally-dsvm-manila-multibackend-no-ss/f40087d/ : SUCCESS in 15m 08s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"b67796ace0951bb29e0af9f6e2342aca80627eb9","author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"date":"2017-11-24 12:44:48.000000000","message":"Patch Set 4: Code-Review+2\n\nThanks!  This is a really good fix.","accounts_in_message":[],"_revision_number":4},{"id":"dc350bde21e1de8c325711f805fb8eb75bdce693","author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"date":"2017-11-25 08:22:28.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"13baafeda4046464c8490a6442d6b6d16dada100","author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"date":"2017-11-25 08:23:02.000000000","message":"Patch Set 4: Workflow+1","accounts_in_message":[],"_revision_number":4},{"id":"264999d619eeee9e0f2ad47335f806102c2d74bc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-25 08:23:13.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":4},{"id":"4c183aa88d23f6bc8ff53737f6a9801e37096a3b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-25 09:21:17.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/04/516804/4/gate/build-openstack-sphinx-docs/36a413d/html/ : SUCCESS in 4m 50s\n- openstack-tox-pep8 http://logs.openstack.org/04/516804/4/gate/openstack-tox-pep8/b4424cf/ : SUCCESS in 4m 45s\n- openstack-tox-py27 http://logs.openstack.org/04/516804/4/gate/openstack-tox-py27/3f6fe76/ : SUCCESS in 6m 13s\n- openstack-tox-py35 http://logs.openstack.org/04/516804/4/gate/openstack-tox-py35/2ae416d/ : SUCCESS in 5m 57s\n- manilaclient-dsvm-neutron-functional http://logs.openstack.org/04/516804/4/gate/manilaclient-dsvm-neutron-functional/8d46662/ : SUCCESS in 56m 34s","accounts_in_message":[],"_revision_number":4},{"id":"62da13b3d3a53d6610368935ba1b1dc0b0627146","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-25 09:21:18.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"434af1132c8ad804acad683e6d376139761de9a3","revisions":{"b21cf5e02c57bb1be36456e79b8989563656cd37":{"kind":"REWORK","_number":1,"created":"2017-11-01 01:16:05.000000000","uploader":{"_account_id":23512,"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","username":"alexander.pugachev"},"ref":"refs/changes/04/516804/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/04/516804/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/04/516804/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/04/516804/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/04/516804/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/04/516804/1"}}},"commit":{"parents":[{"commit":"d80a7cef71587821ab69577db4d05cb85a3b4405","subject":"Merge \"Add MAPRFS protocol in create help\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/d80a7cef71587821ab69577db4d05cb85a3b4405"}]}],"author":{"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","date":"2017-11-01 01:12:25.000000000","tz":0},"committer":{"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","date":"2017-11-01 01:12:25.000000000","tz":0},"subject":"Compare API call parameters with respect to values","message":"Compare API call parameters with respect to values\n\nBefore this change we compared only keys of expected and actual\nparameters dictionaries for an API call.\n\nPartial-Bug: #1364800\n\nChange-Id: Ib863c60a4698cbae01654bd8eea159b04d531569\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/b21cf5e02c57bb1be36456e79b8989563656cd37"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/b21cf5e02c57bb1be36456e79b8989563656cd37"}]},"branch":"refs/heads/master"},"d5269db0701b463bf67a48bc35b7ae69849bd131":{"kind":"REWORK","_number":2,"created":"2017-11-07 12:13:12.000000000","uploader":{"_account_id":23512,"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","username":"alexander.pugachev"},"ref":"refs/changes/04/516804/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/04/516804/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/04/516804/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/04/516804/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/04/516804/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/04/516804/2"}}},"commit":{"parents":[{"commit":"d80a7cef71587821ab69577db4d05cb85a3b4405","subject":"Merge \"Add MAPRFS protocol in create help\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/d80a7cef71587821ab69577db4d05cb85a3b4405"}]}],"author":{"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","date":"2017-11-01 01:12:25.000000000","tz":0},"committer":{"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","date":"2017-11-07 12:13:00.000000000","tz":0},"subject":"Compare API call parameters with respect to values","message":"Compare API call parameters with respect to values\n\nBefore this change we compared only keys of expected and actual\nparameters dictionaries for an API call.\n\nPartial-Bug: #1364800\n\nChange-Id: Ib863c60a4698cbae01654bd8eea159b04d531569\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/d5269db0701b463bf67a48bc35b7ae69849bd131"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/d5269db0701b463bf67a48bc35b7ae69849bd131"}]},"branch":"refs/heads/master"},"d16e1fb83736059157524328f718f8df10eb0c59":{"kind":"REWORK","_number":3,"created":"2017-11-23 12:39:39.000000000","uploader":{"_account_id":23512,"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","username":"alexander.pugachev"},"ref":"refs/changes/04/516804/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/04/516804/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/04/516804/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/04/516804/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/04/516804/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/04/516804/3"}}},"commit":{"parents":[{"commit":"d80a7cef71587821ab69577db4d05cb85a3b4405","subject":"Merge \"Add MAPRFS protocol in create help\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/d80a7cef71587821ab69577db4d05cb85a3b4405"}]}],"author":{"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","date":"2017-11-01 01:12:25.000000000","tz":0},"committer":{"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","date":"2017-11-23 12:34:41.000000000","tz":0},"subject":"Compare API call parameters with respect to values","message":"Compare API call parameters with respect to values\n\nFakeClient compares dictionaries of actual and body in a wrong way.\nIt takes into account only top-level keys of the dictionaries,\nleaving behind everything else.\n\nChanges to the test_shell.py file fix tests which had wrong expected\nvalues. Before this change expected values were not used properly,\nthat\u0027s why the tests were passing.\n\nBug: #1364800\n\nChange-Id: Ib863c60a4698cbae01654bd8eea159b04d531569\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/d16e1fb83736059157524328f718f8df10eb0c59"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/d16e1fb83736059157524328f718f8df10eb0c59"}]},"branch":"refs/heads/master"},"434af1132c8ad804acad683e6d376139761de9a3":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2017-11-24 10:21:13.000000000","uploader":{"_account_id":23512,"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","username":"alexander.pugachev"},"ref":"refs/changes/04/516804/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/04/516804/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/04/516804/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/04/516804/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/04/516804/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/04/516804/4"}}},"commit":{"parents":[{"commit":"d80a7cef71587821ab69577db4d05cb85a3b4405","subject":"Merge \"Add MAPRFS protocol in create help\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/d80a7cef71587821ab69577db4d05cb85a3b4405"}]}],"author":{"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","date":"2017-11-01 01:12:25.000000000","tz":0},"committer":{"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","date":"2017-11-24 10:21:11.000000000","tz":0},"subject":"Compare API call body in assertions with respect to values","message":"Compare API call body in assertions with respect to values\n\nFakeClient.assert_called() compares dictionaries of actual and body \nin a wrong way. It takes into account only top-level keys of the dict,\nleaving behind everything else.\n\nChanges to the test_shell.py file fix tests which had wrong expected\nvalues. Before this change expected values were not used properly,\nthat\u0027s why the tests were passing.\n\nCloses-Bug: #1734115\n\nChange-Id: Ib863c60a4698cbae01654bd8eea159b04d531569\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/434af1132c8ad804acad683e6d376139761de9a3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/434af1132c8ad804acad683e6d376139761de9a3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}