)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23512,"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","username":"alexander.pugachev"},"change_message_id":"84223ac131cdd8e1b9c6a80e4d9751effb9de888","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added \u0027description\u0027 in share type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This fix add attr \u0027description\u0027 in list/create share"},{"line_number":10,"context_line":"type."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I39705acbfca812b66d73fbd2fee228a7a85bc2d7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f96bb07_f18babbc","line":9,"range":{"start_line":9,"start_character":9,"end_line":9,"end_character":13},"updated":"2018-01-18 15:23:09.000000000","message":"adds","commit_id":"f2d2ad0ffa710ad771cfafffedfd8ce0fd4ad33b"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ca52958473f47742ec6a63dbb01744d07212c881","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added \u0027description\u0027 in share type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This fix add attr \u0027description\u0027 in list/create share"},{"line_number":10,"context_line":"type."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I39705acbfca812b66d73fbd2fee228a7a85bc2d7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f96bb07_93757934","line":9,"range":{"start_line":9,"start_character":9,"end_line":9,"end_character":13},"in_reply_to":"7f96bb07_f18babbc","updated":"2018-01-19 03:52:46.000000000","message":"Done","commit_id":"f2d2ad0ffa710ad771cfafffedfd8ce0fd4ad33b"}],"manilaclient/tests/functional/client.py":[{"author":{"_account_id":23512,"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","username":"alexander.pugachev"},"change_message_id":"84223ac131cdd8e1b9c6a80e4d9751effb9de888","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            \u0027name\u0027: name, \u0027dhss\u0027: dhss, \u0027is_public\u0027: is_public}"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        if description is not None:"},{"line_number":206,"context_line":"            if not isinstance(description, six.string_types):"},{"line_number":207,"context_line":"                description \u003d six.text_type(description)"},{"line_number":208,"context_line":"            cmd +\u003d \" --description \" + description"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        if snapshot_support is not None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_3467c1eb","line":207,"range":{"start_line":206,"start_character":19,"end_line":207,"end_character":43},"updated":"2018-01-18 15:23:09.000000000","message":"do we need to received numbers of booleans here?","commit_id":"f2d2ad0ffa710ad771cfafffedfd8ce0fd4ad33b"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ca52958473f47742ec6a63dbb01744d07212c881","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            \u0027name\u0027: name, \u0027dhss\u0027: dhss, \u0027is_public\u0027: is_public}"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        if description is not None:"},{"line_number":206,"context_line":"            if not isinstance(description, six.string_types):"},{"line_number":207,"context_line":"                description \u003d six.text_type(description)"},{"line_number":208,"context_line":"            cmd +\u003d \" --description \" + description"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        if snapshot_support is not None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_53913146","line":207,"range":{"start_line":206,"start_character":19,"end_line":207,"end_character":43},"in_reply_to":"7f96bb07_3467c1eb","updated":"2018-01-19 03:52:46.000000000","message":"Done","commit_id":"f2d2ad0ffa710ad771cfafffedfd8ce0fd4ad33b"}],"manilaclient/tests/unit/v2/test_types.py":[{"author":{"_account_id":23512,"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","username":"alexander.pugachev"},"change_message_id":"84223ac131cdd8e1b9c6a80e4d9751effb9de888","unresolved":false,"context_lines":[{"line_number":376,"context_line":"        manager \u003d self._get_share_types_manager(microversion)"},{"line_number":377,"context_line":"        self.mock_object(manager, \u0027_create\u0027, mock.Mock(return_value\u003d\"fake\"))"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        dec \u003d \u0027test description\u0027"},{"line_number":380,"context_line":"        if (api_versions.APIVersion(microversion) \u003e\u003d"},{"line_number":381,"context_line":"                api_versions.APIVersion(\"2.41\")):"},{"line_number":382,"context_line":"            result \u003d manager.create(\u0027test-type-3\u0027, dhss, description\u003ddec)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_740a2920","line":379,"range":{"start_line":379,"start_character":8,"end_line":379,"end_character":12},"updated":"2018-01-18 15:23:09.000000000","message":"this name is misleading","commit_id":"f2d2ad0ffa710ad771cfafffedfd8ce0fd4ad33b"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ca52958473f47742ec6a63dbb01744d07212c881","unresolved":false,"context_lines":[{"line_number":376,"context_line":"        manager \u003d self._get_share_types_manager(microversion)"},{"line_number":377,"context_line":"        self.mock_object(manager, \u0027_create\u0027, mock.Mock(return_value\u003d\"fake\"))"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        dec \u003d \u0027test description\u0027"},{"line_number":380,"context_line":"        if (api_versions.APIVersion(microversion) \u003e\u003d"},{"line_number":381,"context_line":"                api_versions.APIVersion(\"2.41\")):"},{"line_number":382,"context_line":"            result \u003d manager.create(\u0027test-type-3\u0027, dhss, description\u003ddec)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_7389cd72","line":379,"range":{"start_line":379,"start_character":8,"end_line":379,"end_character":12},"in_reply_to":"7f96bb07_740a2920","updated":"2018-01-19 03:52:46.000000000","message":"Done","commit_id":"f2d2ad0ffa710ad771cfafffedfd8ce0fd4ad33b"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":23512,"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","username":"alexander.pugachev"},"change_message_id":"84223ac131cdd8e1b9c6a80e4d9751effb9de888","unresolved":false,"context_lines":[{"line_number":3648,"context_line":"        default \u003d None"},{"line_number":3649,"context_line":""},{"line_number":3650,"context_line":"    stypes \u003d cs.share_types.list(show_all\u003dargs.all)"},{"line_number":3651,"context_line":"    show_des \u003d False"},{"line_number":3652,"context_line":"    if cs.api_version.matches(api_versions.APIVersion(\"2.41\"),"},{"line_number":3653,"context_line":"                              api_versions.APIVersion()):"},{"line_number":3654,"context_line":"        show_des \u003d True"},{"line_number":3655,"context_line":"    _print_share_type_list(stypes, default_share_type\u003ddefault,"},{"line_number":3656,"context_line":"                           columns\u003dargs.columns, description\u003dshow_des)"},{"line_number":3657,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_312273ba","line":3654,"range":{"start_line":3651,"start_character":4,"end_line":3654,"end_character":23},"updated":"2018-01-18 15:23:09.000000000","message":"maybe we could simply assign show_description the return value of call to .matches()?","commit_id":"f2d2ad0ffa710ad771cfafffedfd8ce0fd4ad33b"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ca52958473f47742ec6a63dbb01744d07212c881","unresolved":false,"context_lines":[{"line_number":3648,"context_line":"        default \u003d None"},{"line_number":3649,"context_line":""},{"line_number":3650,"context_line":"    stypes \u003d cs.share_types.list(show_all\u003dargs.all)"},{"line_number":3651,"context_line":"    show_des \u003d False"},{"line_number":3652,"context_line":"    if cs.api_version.matches(api_versions.APIVersion(\"2.41\"),"},{"line_number":3653,"context_line":"                              api_versions.APIVersion()):"},{"line_number":3654,"context_line":"        show_des \u003d True"},{"line_number":3655,"context_line":"    _print_share_type_list(stypes, default_share_type\u003ddefault,"},{"line_number":3656,"context_line":"                           columns\u003dargs.columns, description\u003dshow_des)"},{"line_number":3657,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_1382c900","line":3654,"range":{"start_line":3651,"start_character":4,"end_line":3654,"end_character":23},"in_reply_to":"7f96bb07_312273ba","updated":"2018-01-19 03:52:46.000000000","message":"Done","commit_id":"f2d2ad0ffa710ad771cfafffedfd8ce0fd4ad33b"},{"author":{"_account_id":23512,"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","username":"alexander.pugachev"},"change_message_id":"84223ac131cdd8e1b9c6a80e4d9751effb9de888","unresolved":false,"context_lines":[{"line_number":3759,"context_line":"                              api_versions.APIVersion()):"},{"line_number":3760,"context_line":"        show_des \u003d True"},{"line_number":3761,"context_line":"        kwargs[\u0027description\u0027] \u003d getattr(args, \u0027description\u0027)"},{"line_number":3762,"context_line":"    elif getattr(args, \u0027description\u0027):"},{"line_number":3763,"context_line":"        raise exceptions.CommandError("},{"line_number":3764,"context_line":"            \"Pattern based option (description)\""},{"line_number":3765,"context_line":"            \" is only available with manila API version \u003e\u003d 2.41\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_11109756","line":3762,"range":{"start_line":3762,"start_character":9,"end_line":3762,"end_character":17},"updated":"2018-01-18 15:23:09.000000000","message":"hasattr()?","commit_id":"f2d2ad0ffa710ad771cfafffedfd8ce0fd4ad33b"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ca52958473f47742ec6a63dbb01744d07212c881","unresolved":false,"context_lines":[{"line_number":3759,"context_line":"                              api_versions.APIVersion()):"},{"line_number":3760,"context_line":"        show_des \u003d True"},{"line_number":3761,"context_line":"        kwargs[\u0027description\u0027] \u003d getattr(args, \u0027description\u0027)"},{"line_number":3762,"context_line":"    elif getattr(args, \u0027description\u0027):"},{"line_number":3763,"context_line":"        raise exceptions.CommandError("},{"line_number":3764,"context_line":"            \"Pattern based option (description)\""},{"line_number":3765,"context_line":"            \" is only available with manila API version \u003e\u003d 2.41\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_335b45f6","line":3762,"range":{"start_line":3762,"start_character":9,"end_line":3762,"end_character":17},"in_reply_to":"7f96bb07_11109756","updated":"2018-01-19 03:52:46.000000000","message":"Since we added description in do_type_create (code line 3682), we always have the attr  named \u0027description\u0027. So the hasattr(args, \u0027description\u0027)  will always be true.","commit_id":"f2d2ad0ffa710ad771cfafffedfd8ce0fd4ad33b"}]}