)]}'
{"manilaclient/base.py":[{"author":{"_account_id":23512,"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","username":"alexander.pugachev"},"change_message_id":"6efd5573a21e175f6914f57aa18c2e5ad5f180cb","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            with self.completion_cache(\u0027uuid\u0027, obj_class, mode\u003d\"w\"):"},{"line_number":77,"context_line":"                resource \u003d [obj_class(self, res, loaded\u003dTrue)"},{"line_number":78,"context_line":"                            for res in data if res]"},{"line_number":79,"context_line":"                if \"count\" in body:"},{"line_number":80,"context_line":"                    return resource, body[\"count\"]"},{"line_number":81,"context_line":"                else:"},{"line_number":82,"context_line":"                    return resource"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7f96bb07_540ccd92","line":80,"range":{"start_line":79,"start_character":19,"end_line":80,"end_character":50},"updated":"2018-01-18 15:42:51.000000000","message":"Looks like they usually use double quotes around here.","commit_id":"0f918c047eb749bbaacb93625e28d5f4d599cf04"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b8845183e0c95667ca4f6c28c0951cd93df24675","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            with self.completion_cache(\u0027uuid\u0027, obj_class, mode\u003d\"w\"):"},{"line_number":77,"context_line":"                resource \u003d [obj_class(self, res, loaded\u003dTrue)"},{"line_number":78,"context_line":"                            for res in data if res]"},{"line_number":79,"context_line":"                if \"count\" in body:"},{"line_number":80,"context_line":"                    return resource, body[\"count\"]"},{"line_number":81,"context_line":"                else:"},{"line_number":82,"context_line":"                    return resource"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7f96bb07_6ca1c095","line":80,"range":{"start_line":79,"start_character":19,"end_line":80,"end_character":50},"in_reply_to":"7f96bb07_32fed86b","updated":"2018-01-22 02:26:19.000000000","message":"Done","commit_id":"0f918c047eb749bbaacb93625e28d5f4d599cf04"},{"author":{"_account_id":23512,"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","username":"alexander.pugachev"},"change_message_id":"d10e15c7240fac5b634e3249846ad1d59a4c82a8","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            with self.completion_cache(\u0027uuid\u0027, obj_class, mode\u003d\"w\"):"},{"line_number":77,"context_line":"                resource \u003d [obj_class(self, res, loaded\u003dTrue)"},{"line_number":78,"context_line":"                            for res in data if res]"},{"line_number":79,"context_line":"                if \"count\" in body:"},{"line_number":80,"context_line":"                    return resource, body[\"count\"]"},{"line_number":81,"context_line":"                else:"},{"line_number":82,"context_line":"                    return resource"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7f96bb07_32fed86b","line":80,"range":{"start_line":79,"start_character":19,"end_line":80,"end_character":50},"in_reply_to":"7f96bb07_540ccd92","updated":"2018-01-19 10:28:21.000000000","message":"It\u0027s rather about style. If we observe the rest of the code in this file, we see that usually authors use single quote symbol for quoting string literals: \u0027, not \".\nIt\u0027s not critical at all, just if you submit another patchset, maybe it\u0027s worth changing from \"count\" to \u0027count\u0027 for consistency?","commit_id":"0f918c047eb749bbaacb93625e28d5f4d599cf04"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"f6ba87e5320c5f91ecc63f90619a092e9263d5ed","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            with self.completion_cache(\u0027uuid\u0027, obj_class, mode\u003d\"w\"):"},{"line_number":77,"context_line":"                resource \u003d [obj_class(self, res, loaded\u003dTrue)"},{"line_number":78,"context_line":"                            for res in data if res]"},{"line_number":79,"context_line":"                if \"count\" in body:"},{"line_number":80,"context_line":"                    return resource, body[\"count\"]"},{"line_number":81,"context_line":"                else:"},{"line_number":82,"context_line":"                    return resource"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7f96bb07_330a651f","line":80,"range":{"start_line":79,"start_character":19,"end_line":80,"end_character":50},"in_reply_to":"7f96bb07_540ccd92","updated":"2018-01-19 03:23:10.000000000","message":"Sorry, what do you mean about use double quotes around here? How to do it?","commit_id":"0f918c047eb749bbaacb93625e28d5f4d599cf04"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"f07afb7b978eda5cfe0956f3a91ce30b670ae7a4","unresolved":false,"context_lines":[{"line_number":1633,"context_line":"    metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":1634,"context_line":"    choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":1635,"context_line":"    default\u003dFalse,"},{"line_number":1636,"context_line":"    help\u003d\u0027Display total number of shares to return.\u0027"},{"line_number":1637,"context_line":"         \u0027Available only for microversion \u003e\u003d 2.42.\u0027)"},{"line_number":1638,"context_line":"@cliutils.service_type(\u0027sharev2\u0027)"},{"line_number":1639,"context_line":"def do_list(cs, args):"},{"line_number":1640,"context_line":"    \"\"\"List NAS shares with filters.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_cdb83f12","line":1637,"range":{"start_line":1636,"start_character":9,"end_line":1637,"end_character":52},"updated":"2017-12-12 12:33:14.000000000","message":"Space needed between these sentences.","commit_id":"7c6bfaeee0da7f5f94aae2a6a5210059ff8dfd26"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"fb5ff7b50dafb24e6c5b194b5a6612ec502fbeac","unresolved":false,"context_lines":[{"line_number":1633,"context_line":"    metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":1634,"context_line":"    choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":1635,"context_line":"    default\u003dFalse,"},{"line_number":1636,"context_line":"    help\u003d\u0027Display total number of shares to return.\u0027"},{"line_number":1637,"context_line":"         \u0027Available only for microversion \u003e\u003d 2.42.\u0027)"},{"line_number":1638,"context_line":"@cliutils.service_type(\u0027sharev2\u0027)"},{"line_number":1639,"context_line":"def do_list(cs, args):"},{"line_number":1640,"context_line":"    \"\"\"List NAS shares with filters.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_b66bbe83","line":1637,"range":{"start_line":1636,"start_character":9,"end_line":1637,"end_character":52},"in_reply_to":"df87a7cf_cdb83f12","updated":"2017-12-13 01:52:59.000000000","message":"Done","commit_id":"7c6bfaeee0da7f5f94aae2a6a5210059ff8dfd26"},{"author":{"_account_id":23512,"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","username":"alexander.pugachev"},"change_message_id":"6efd5573a21e175f6914f57aa18c2e5ad5f180cb","unresolved":false,"context_lines":[{"line_number":1734,"context_line":"            setattr(share, \u0027export_locations\u0027, els)"},{"line_number":1735,"context_line":"            setattr(share, \u0027export_location\u0027, els[0] if els else None)"},{"line_number":1736,"context_line":"    cliutils.print_list(shares, list_of_keys)"},{"line_number":1737,"context_line":"    if total_count:"},{"line_number":1738,"context_line":"        print(\"Shares in total: %s\" % total_count)"},{"line_number":1739,"context_line":""},{"line_number":1740,"context_line":""},{"line_number":1741,"context_line":"@cliutils.arg("}],"source_content_type":"text/x-python","patch_set":4,"id":"7f96bb07_54b60d8c","line":1738,"range":{"start_line":1737,"start_character":4,"end_line":1738,"end_character":50},"updated":"2018-01-18 15:42:51.000000000","message":"If count is not requested, it will print \"Shares in total: None\" which is strange.","commit_id":"0f918c047eb749bbaacb93625e28d5f4d599cf04"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b8845183e0c95667ca4f6c28c0951cd93df24675","unresolved":false,"context_lines":[{"line_number":1734,"context_line":"            setattr(share, \u0027export_locations\u0027, els)"},{"line_number":1735,"context_line":"            setattr(share, \u0027export_location\u0027, els[0] if els else None)"},{"line_number":1736,"context_line":"    cliutils.print_list(shares, list_of_keys)"},{"line_number":1737,"context_line":"    if total_count:"},{"line_number":1738,"context_line":"        print(\"Shares in total: %s\" % total_count)"},{"line_number":1739,"context_line":""},{"line_number":1740,"context_line":""},{"line_number":1741,"context_line":"@cliutils.arg("}],"source_content_type":"text/x-python","patch_set":4,"id":"7f96bb07_ac97c83a","line":1738,"range":{"start_line":1737,"start_character":4,"end_line":1738,"end_character":50},"in_reply_to":"7f96bb07_1972dc7d","updated":"2018-01-22 02:26:19.000000000","message":"Done","commit_id":"0f918c047eb749bbaacb93625e28d5f4d599cf04"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"83f306e3d4d70369f11e28d85a083f5ed343bfb1","unresolved":false,"context_lines":[{"line_number":1734,"context_line":"            setattr(share, \u0027export_locations\u0027, els)"},{"line_number":1735,"context_line":"            setattr(share, \u0027export_location\u0027, els[0] if els else None)"},{"line_number":1736,"context_line":"    cliutils.print_list(shares, list_of_keys)"},{"line_number":1737,"context_line":"    if total_count:"},{"line_number":1738,"context_line":"        print(\"Shares in total: %s\" % total_count)"},{"line_number":1739,"context_line":""},{"line_number":1740,"context_line":""},{"line_number":1741,"context_line":"@cliutils.arg("}],"source_content_type":"text/x-python","patch_set":4,"id":"7f96bb07_1972dc7d","line":1738,"range":{"start_line":1737,"start_character":4,"end_line":1738,"end_character":50},"in_reply_to":"7f96bb07_528604de","updated":"2018-01-19 15:23:03.000000000","message":"I think this is a good point.","commit_id":"0f918c047eb749bbaacb93625e28d5f4d599cf04"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"f6ba87e5320c5f91ecc63f90619a092e9263d5ed","unresolved":false,"context_lines":[{"line_number":1734,"context_line":"            setattr(share, \u0027export_locations\u0027, els)"},{"line_number":1735,"context_line":"            setattr(share, \u0027export_location\u0027, els[0] if els else None)"},{"line_number":1736,"context_line":"    cliutils.print_list(shares, list_of_keys)"},{"line_number":1737,"context_line":"    if total_count:"},{"line_number":1738,"context_line":"        print(\"Shares in total: %s\" % total_count)"},{"line_number":1739,"context_line":""},{"line_number":1740,"context_line":""},{"line_number":1741,"context_line":"@cliutils.arg("}],"source_content_type":"text/x-python","patch_set":4,"id":"7f96bb07_781f6c6b","line":1738,"range":{"start_line":1737,"start_character":4,"end_line":1738,"end_character":50},"in_reply_to":"7f96bb07_54b60d8c","updated":"2018-01-19 03:23:10.000000000","message":"If count is not requested, the total_count will be None, so if the total_count is None, it will not print \"Shares in total: None\". It will never be happened. or may I will be missing something?","commit_id":"0f918c047eb749bbaacb93625e28d5f4d599cf04"},{"author":{"_account_id":23512,"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","username":"alexander.pugachev"},"change_message_id":"d10e15c7240fac5b634e3249846ad1d59a4c82a8","unresolved":false,"context_lines":[{"line_number":1734,"context_line":"            setattr(share, \u0027export_locations\u0027, els)"},{"line_number":1735,"context_line":"            setattr(share, \u0027export_location\u0027, els[0] if els else None)"},{"line_number":1736,"context_line":"    cliutils.print_list(shares, list_of_keys)"},{"line_number":1737,"context_line":"    if total_count:"},{"line_number":1738,"context_line":"        print(\"Shares in total: %s\" % total_count)"},{"line_number":1739,"context_line":""},{"line_number":1740,"context_line":""},{"line_number":1741,"context_line":"@cliutils.arg("}],"source_content_type":"text/x-python","patch_set":4,"id":"7f96bb07_528604de","line":1738,"range":{"start_line":1737,"start_character":4,"end_line":1738,"end_character":50},"in_reply_to":"7f96bb07_781f6c6b","updated":"2018-01-19 10:28:21.000000000","message":"I\u0027m sorry, you are right. It will not print if total_count is None.\n\nThe only other thing I can see here is: if count is requested, and total_count resulted in 0 (zero), then it will not print.\n\nMaybe check for \"total_count is not None\" instead?","commit_id":"0f918c047eb749bbaacb93625e28d5f4d599cf04"}]}