)]}'
{"manilaclient/tests/unit/v2/test_shell.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"752aa891babce5621c9ba6d415b9a9c197d95ca8","unresolved":false,"context_lines":[{"line_number":512,"context_line":"    def test_type_list(self):"},{"line_number":513,"context_line":"        self.run_command(\u0027type-list\u0027)"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/types/default\u0027)"},{"line_number":516,"context_line":"        cliutils.print_list.assert_called_once_with("},{"line_number":517,"context_line":"            mock.ANY,"},{"line_number":518,"context_line":"            [\u0027ID\u0027, \u0027Name\u0027, \u0027visibility\u0027, \u0027is_default\u0027, \u0027required_extra_specs\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_94e3cf3a","line":515,"range":{"start_line":515,"start_character":8,"end_line":515,"end_character":51},"updated":"2018-07-25 18:33:56.000000000","message":"/types/default should only be called if microversion \u003c\u003d 2.45..\n\nand only if there are no columns, or if columns specify \"is_default\"\n\nCan you please add ddt and pass version information, and test that the conditionals in your code are working as intended?","commit_id":"9c56fbf7e76cf159260a71e590754d912c820079"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"714e87b7334621055b618289a523c0e920966772","unresolved":false,"context_lines":[{"line_number":512,"context_line":"    def test_type_list(self):"},{"line_number":513,"context_line":"        self.run_command(\u0027type-list\u0027)"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/types/default\u0027)"},{"line_number":516,"context_line":"        cliutils.print_list.assert_called_once_with("},{"line_number":517,"context_line":"            mock.ANY,"},{"line_number":518,"context_line":"            [\u0027ID\u0027, \u0027Name\u0027, \u0027visibility\u0027, \u0027is_default\u0027, \u0027required_extra_specs\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_ec5a54f3","line":515,"range":{"start_line":515,"start_character":8,"end_line":515,"end_character":51},"in_reply_to":"5f7c97a3_94e3cf3a","updated":"2018-07-27 00:09:17.000000000","message":"Done","commit_id":"9c56fbf7e76cf159260a71e590754d912c820079"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"752aa891babce5621c9ba6d415b9a9c197d95ca8","unresolved":false,"context_lines":[{"line_number":2441,"context_line":""},{"line_number":2442,"context_line":"        self.run_command(\u0027share-group-type-list\u0027)"},{"line_number":2443,"context_line":""},{"line_number":2444,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/share-group-types/default\u0027)"},{"line_number":2445,"context_line":"        shell_v2._print_share_group_type_list.assert_called_once_with("},{"line_number":2446,"context_line":"            mock.ANY, default_share_group_type\u003dmock.ANY, columns\u003dmock.ANY)"},{"line_number":2447,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_f4b4831f","line":2444,"range":{"start_line":2444,"start_character":0,"end_line":2444,"end_character":63},"updated":"2018-07-25 18:33:56.000000000","message":"same","commit_id":"9c56fbf7e76cf159260a71e590754d912c820079"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"714e87b7334621055b618289a523c0e920966772","unresolved":false,"context_lines":[{"line_number":2441,"context_line":""},{"line_number":2442,"context_line":"        self.run_command(\u0027share-group-type-list\u0027)"},{"line_number":2443,"context_line":""},{"line_number":2444,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/share-group-types/default\u0027)"},{"line_number":2445,"context_line":"        shell_v2._print_share_group_type_list.assert_called_once_with("},{"line_number":2446,"context_line":"            mock.ANY, default_share_group_type\u003dmock.ANY, columns\u003dmock.ANY)"},{"line_number":2447,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_0c5eb0e7","line":2444,"range":{"start_line":2444,"start_character":0,"end_line":2444,"end_character":63},"in_reply_to":"5f7c97a3_f4b4831f","updated":"2018-07-27 00:09:17.000000000","message":"Done","commit_id":"9c56fbf7e76cf159260a71e590754d912c820079"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7862085c6a470e41c8a9495ba074c181aa1df8a1","unresolved":false,"context_lines":[{"line_number":3590,"context_line":"def _print_share_type(stype, default_share_type\u003dNone):"},{"line_number":3591,"context_line":""},{"line_number":3592,"context_line":"    def _is_default(share_type):"},{"line_number":3593,"context_line":"        type_dict \u003d share_type.__dict__"},{"line_number":3594,"context_line":"        if type_dict.get(\u0027name\u0027) \u003d\u003d \u0027default\u0027:"},{"line_number":3595,"context_line":"            return \u0027YES\u0027"},{"line_number":3596,"context_line":"        else:"},{"line_number":3597,"context_line":"            return \u0027-\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_dbdede3c","line":3594,"range":{"start_line":3593,"start_character":8,"end_line":3594,"end_character":45},"updated":"2018-01-18 06:37:33.000000000","message":"You can certainly have a share type that\u0027s called \"default\" but isn\u0027t the default share type, and you can also have a share type with a different name but being configured as the default share type, so this check is incorrect. What you need is to verify it against the default share type that manila knows about.","commit_id":"17d323ad62b203e00a37ca49b6d4d90a66d8ffee"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9ec49b55aaac6007814ae22a10b4bbfa098b5f80","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"def _print_type_show(stype, default_share_type\u003dNone):"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    is_default \u003d \u0027YES\u0027 if stype \u003d\u003d default_share_type else \u0027NO\u0027"},{"line_number":157,"context_line":"    stype_dict \u003d {"},{"line_number":158,"context_line":"        \u0027id\u0027: stype.id,"},{"line_number":159,"context_line":"        \u0027name\u0027: stype.name,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_132c31ff","line":156,"range":{"start_line":156,"start_character":4,"end_line":156,"end_character":63},"updated":"2018-07-19 23:21:39.000000000","message":"if hasattr(stype, \u0027is_default\u0027):\n   is_default \u003d \u0027YES\u0027 if stype.is_default else \u0027NO\u0027\n elif default_share_type:\n   is_default \u003d \u0027YES\u0027 if stype.id \u003d\u003d default_share_type.id else \u0027NO\u0027\n else:\n   is_default \u003d \u0027NO\u0027","commit_id":"f5f42f0d147a5a4eaa0d1d9e5b1527c8a2753826"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d3308df3bcc39e92f949a72fe131f8175b17c73a","unresolved":false,"context_lines":[{"line_number":3596,"context_line":"def _print_share_type_list(stypes, default_share_type\u003dNone, columns\u003dNone,"},{"line_number":3597,"context_line":"                           description\u003dFalse):"},{"line_number":3598,"context_line":""},{"line_number":3599,"context_line":"    def _is_default(share_type):"},{"line_number":3600,"context_line":"        if share_type \u003d\u003d default_share_type:"},{"line_number":3601,"context_line":"            return \u0027YES\u0027"},{"line_number":3602,"context_line":"        else:"},{"line_number":3603,"context_line":"            return \u0027-\u0027"},{"line_number":3604,"context_line":""},{"line_number":3605,"context_line":"    formatters \u003d {"},{"line_number":3606,"context_line":"        \u0027visibility\u0027: _is_share_type_public,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_588726b4","line":3603,"range":{"start_line":3599,"start_character":4,"end_line":3603,"end_character":22},"updated":"2018-07-19 22:57:10.000000000","message":"same comment as with _print_share_group_type_list","commit_id":"f5f42f0d147a5a4eaa0d1d9e5b1527c8a2753826"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d3308df3bcc39e92f949a72fe131f8175b17c73a","unresolved":false,"context_lines":[{"line_number":3632,"context_line":"def _print_share_type(stype, show_des\u003dFalse):"},{"line_number":3633,"context_line":""},{"line_number":3634,"context_line":"    def _is_default(share_type):"},{"line_number":3635,"context_line":"        share_type \u003d share_type.__dict__"},{"line_number":3636,"context_line":"        if share_type.get(\u0027is_default\u0027, False):"},{"line_number":3637,"context_line":"            return \u0027YES\u0027"},{"line_number":3638,"context_line":"        else:"},{"line_number":3639,"context_line":"            return \u0027-\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_2ab4551c","line":3636,"range":{"start_line":3635,"start_character":8,"end_line":3636,"end_character":47},"updated":"2018-07-19 22:57:10.000000000","message":"if has_attr(share_type, \u0027is_default\u0027):\n     return \u0027YES\u0027 if share_type.is_default else \u0027-\u0027\nreturn \u0027-\u0027","commit_id":"f5f42f0d147a5a4eaa0d1d9e5b1527c8a2753826"},{"author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"change_message_id":"f1ffa7b6a50139703f09f7a3dc219d201b3c1a60","unresolved":false,"context_lines":[{"line_number":3632,"context_line":"def _print_share_type(stype, show_des\u003dFalse):"},{"line_number":3633,"context_line":""},{"line_number":3634,"context_line":"    def _is_default(share_type):"},{"line_number":3635,"context_line":"        share_type \u003d share_type.__dict__"},{"line_number":3636,"context_line":"        if share_type.get(\u0027is_default\u0027, False):"},{"line_number":3637,"context_line":"            return \u0027YES\u0027"},{"line_number":3638,"context_line":"        else:"},{"line_number":3639,"context_line":"            return \u0027-\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_7ffcd10a","line":3636,"range":{"start_line":3635,"start_character":8,"end_line":3636,"end_character":47},"in_reply_to":"5f7c97a3_2ab4551c","updated":"2018-07-25 15:25:41.000000000","message":"Done","commit_id":"f5f42f0d147a5a4eaa0d1d9e5b1527c8a2753826"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d3308df3bcc39e92f949a72fe131f8175b17c73a","unresolved":false,"context_lines":[{"line_number":3708,"context_line":"            \u0027extra_specs\u0027: extra_specs"},{"line_number":3709,"context_line":"        }"},{"line_number":3710,"context_line":""},{"line_number":3711,"context_line":"    try:"},{"line_number":3712,"context_line":"        default \u003d cs.share_types.get()"},{"line_number":3713,"context_line":"    except exceptions.NotFound:"},{"line_number":3714,"context_line":"        default \u003d None"},{"line_number":3715,"context_line":""},{"line_number":3716,"context_line":"    share_types \u003d cs.share_types.list(show_all\u003dshow_all,"},{"line_number":3717,"context_line":"                                      search_opts\u003dsearch_opts)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_1300b1ff","line":3714,"range":{"start_line":3711,"start_character":4,"end_line":3714,"end_character":22},"updated":"2018-07-19 22:57:10.000000000","message":"Same comments here.. We don\u0027t need this extra call... See suggestions in do_share_group_type_list()\n\nhttps://review.openstack.org/#/c/535178/7/manilaclient/v2/shell.py@4052","commit_id":"f5f42f0d147a5a4eaa0d1d9e5b1527c8a2753826"},{"author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"change_message_id":"f1ffa7b6a50139703f09f7a3dc219d201b3c1a60","unresolved":false,"context_lines":[{"line_number":3708,"context_line":"            \u0027extra_specs\u0027: extra_specs"},{"line_number":3709,"context_line":"        }"},{"line_number":3710,"context_line":""},{"line_number":3711,"context_line":"    try:"},{"line_number":3712,"context_line":"        default \u003d cs.share_types.get()"},{"line_number":3713,"context_line":"    except exceptions.NotFound:"},{"line_number":3714,"context_line":"        default \u003d None"},{"line_number":3715,"context_line":""},{"line_number":3716,"context_line":"    share_types \u003d cs.share_types.list(show_all\u003dshow_all,"},{"line_number":3717,"context_line":"                                      search_opts\u003dsearch_opts)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_3f06591d","line":3714,"range":{"start_line":3711,"start_character":4,"end_line":3714,"end_character":22},"in_reply_to":"5f7c97a3_1300b1ff","updated":"2018-07-25 15:25:41.000000000","message":"Done","commit_id":"f5f42f0d147a5a4eaa0d1d9e5b1527c8a2753826"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9ec49b55aaac6007814ae22a10b4bbfa098b5f80","unresolved":false,"context_lines":[{"line_number":3728,"context_line":"def do_type_show(cs, args):"},{"line_number":3729,"context_line":"    \"\"\"Show share type details.\"\"\""},{"line_number":3730,"context_line":"    share_type \u003d cs.share_types.show(args.share_type)"},{"line_number":3731,"context_line":"    try:"},{"line_number":3732,"context_line":"        default \u003d cs.share_types.get()"},{"line_number":3733,"context_line":"    except exceptions.NotFound:"},{"line_number":3734,"context_line":"        default \u003d None"},{"line_number":3735,"context_line":"    _print_type_show(share_type, default_share_type\u003ddefault)"},{"line_number":3736,"context_line":""},{"line_number":3737,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_f38c152f","line":3734,"range":{"start_line":3731,"start_character":4,"end_line":3734,"end_character":22},"updated":"2018-07-19 23:21:39.000000000","message":"same issue here, you don\u0027t need this call in API version \u003e\u003d 2.45","commit_id":"f5f42f0d147a5a4eaa0d1d9e5b1527c8a2753826"},{"author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"change_message_id":"f1ffa7b6a50139703f09f7a3dc219d201b3c1a60","unresolved":false,"context_lines":[{"line_number":3728,"context_line":"def do_type_show(cs, args):"},{"line_number":3729,"context_line":"    \"\"\"Show share type details.\"\"\""},{"line_number":3730,"context_line":"    share_type \u003d cs.share_types.show(args.share_type)"},{"line_number":3731,"context_line":"    try:"},{"line_number":3732,"context_line":"        default \u003d cs.share_types.get()"},{"line_number":3733,"context_line":"    except exceptions.NotFound:"},{"line_number":3734,"context_line":"        default \u003d None"},{"line_number":3735,"context_line":"    _print_type_show(share_type, default_share_type\u003ddefault)"},{"line_number":3736,"context_line":""},{"line_number":3737,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_df0c053c","line":3734,"range":{"start_line":3731,"start_character":4,"end_line":3734,"end_character":22},"in_reply_to":"5f7c97a3_f38c152f","updated":"2018-07-25 15:25:41.000000000","message":"Done","commit_id":"f5f42f0d147a5a4eaa0d1d9e5b1527c8a2753826"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d3308df3bcc39e92f949a72fe131f8175b17c73a","unresolved":false,"context_lines":[{"line_number":3982,"context_line":"def _print_share_group_type_list(share_group_types,"},{"line_number":3983,"context_line":"                                 default_share_group_type\u003dNone, columns\u003dNone):"},{"line_number":3984,"context_line":""},{"line_number":3985,"context_line":"    def _is_default(share_group_types):"},{"line_number":3986,"context_line":"        if share_group_types \u003d\u003d default_share_group_type:"},{"line_number":3987,"context_line":"            return \u0027YES\u0027"},{"line_number":3988,"context_line":"        else:"},{"line_number":3989,"context_line":"            return \u0027-\u0027"},{"line_number":3990,"context_line":""},{"line_number":3991,"context_line":"    formatters \u003d {"},{"line_number":3992,"context_line":"        \u0027visibility\u0027: _is_share_type_public,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_b898ba19","line":3989,"range":{"start_line":3985,"start_character":4,"end_line":3989,"end_character":22},"updated":"2018-07-19 22:57:10.000000000","message":"def _is_default(share_group_type):\n     if hasattr(share_group_type, \u0027is_default\u0027):\n        return \u0027YES\u0027 if share_group_type[\u0027is_default\u0027] else \u0027-\u0027\n     elif default_share_group_type:\n        return \u0027YES\u0027 if share_group_type[\u0027id\u0027] \u003d\u003d default_share_group_type[\u0027id\u0027] else \u0027-\u0027\n     else:\n        return \u0027-\u0027\n\n\nIf you make the change suggested on line 4058","commit_id":"f5f42f0d147a5a4eaa0d1d9e5b1527c8a2753826"},{"author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"change_message_id":"f1ffa7b6a50139703f09f7a3dc219d201b3c1a60","unresolved":false,"context_lines":[{"line_number":3982,"context_line":"def _print_share_group_type_list(share_group_types,"},{"line_number":3983,"context_line":"                                 default_share_group_type\u003dNone, columns\u003dNone):"},{"line_number":3984,"context_line":""},{"line_number":3985,"context_line":"    def _is_default(share_group_types):"},{"line_number":3986,"context_line":"        if share_group_types \u003d\u003d default_share_group_type:"},{"line_number":3987,"context_line":"            return \u0027YES\u0027"},{"line_number":3988,"context_line":"        else:"},{"line_number":3989,"context_line":"            return \u0027-\u0027"},{"line_number":3990,"context_line":""},{"line_number":3991,"context_line":"    formatters \u003d {"},{"line_number":3992,"context_line":"        \u0027visibility\u0027: _is_share_type_public,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_5f2235a8","line":3989,"range":{"start_line":3985,"start_character":4,"end_line":3989,"end_character":22},"in_reply_to":"5f7c97a3_b898ba19","updated":"2018-07-25 15:25:41.000000000","message":"Done","commit_id":"f5f42f0d147a5a4eaa0d1d9e5b1527c8a2753826"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d3308df3bcc39e92f949a72fe131f8175b17c73a","unresolved":false,"context_lines":[{"line_number":4012,"context_line":"def _print_share_group_type(share_group_type):"},{"line_number":4013,"context_line":""},{"line_number":4014,"context_line":"    def _is_default(share_group_type):"},{"line_number":4015,"context_line":"        share_group_type \u003d share_group_type.__dict__"},{"line_number":4016,"context_line":"        if share_group_type.get(\u0027is_default\u0027, False):"},{"line_number":4017,"context_line":"            return \u0027YES\u0027"},{"line_number":4018,"context_line":"        else:"},{"line_number":4019,"context_line":"            return \u0027-\u0027"},{"line_number":4020,"context_line":""},{"line_number":4021,"context_line":"    share_group_type_dict \u003d {"},{"line_number":4022,"context_line":"        \u0027ID\u0027: share_group_type.id,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_6a8d6d33","line":4019,"range":{"start_line":4015,"start_character":8,"end_line":4019,"end_character":22},"updated":"2018-07-19 22:57:10.000000000","message":"if hasattr(share_group_type, \u0027is_default\u0027):\n    return \u0027YES\u0027 if share_group_type.is_default else \u0027-\u0027\nreturn \u0027-\u0027","commit_id":"f5f42f0d147a5a4eaa0d1d9e5b1527c8a2753826"},{"author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"change_message_id":"f1ffa7b6a50139703f09f7a3dc219d201b3c1a60","unresolved":false,"context_lines":[{"line_number":4012,"context_line":"def _print_share_group_type(share_group_type):"},{"line_number":4013,"context_line":""},{"line_number":4014,"context_line":"    def _is_default(share_group_type):"},{"line_number":4015,"context_line":"        share_group_type \u003d share_group_type.__dict__"},{"line_number":4016,"context_line":"        if share_group_type.get(\u0027is_default\u0027, False):"},{"line_number":4017,"context_line":"            return \u0027YES\u0027"},{"line_number":4018,"context_line":"        else:"},{"line_number":4019,"context_line":"            return \u0027-\u0027"},{"line_number":4020,"context_line":""},{"line_number":4021,"context_line":"    share_group_type_dict \u003d {"},{"line_number":4022,"context_line":"        \u0027ID\u0027: share_group_type.id,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_1f1cbd64","line":4019,"range":{"start_line":4015,"start_character":8,"end_line":4019,"end_character":22},"in_reply_to":"5f7c97a3_6a8d6d33","updated":"2018-07-25 15:25:41.000000000","message":"Done","commit_id":"f5f42f0d147a5a4eaa0d1d9e5b1527c8a2753826"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d3308df3bcc39e92f949a72fe131f8175b17c73a","unresolved":false,"context_lines":[{"line_number":4050,"context_line":"def do_share_group_type_list(cs, args):"},{"line_number":4051,"context_line":"    \"\"\"Print a list of available \u0027share group types\u0027.\"\"\""},{"line_number":4052,"context_line":""},{"line_number":4053,"context_line":"    try:"},{"line_number":4054,"context_line":"        default \u003d cs.share_group_types.get()"},{"line_number":4055,"context_line":"    except exceptions.NotFound:"},{"line_number":4056,"context_line":"        default \u003d None"},{"line_number":4057,"context_line":""},{"line_number":4058,"context_line":"    sg_types \u003d cs.share_group_types.list(show_all\u003dargs.all)"},{"line_number":4059,"context_line":"    _print_share_group_type_list("}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_8a556954","line":4056,"range":{"start_line":4053,"start_character":0,"end_line":4056,"end_character":22},"updated":"2018-07-19 22:57:10.000000000","message":"We can avoid a call to this from API v2.45, so how about as suggested below:","commit_id":"f5f42f0d147a5a4eaa0d1d9e5b1527c8a2753826"},{"author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"change_message_id":"f1ffa7b6a50139703f09f7a3dc219d201b3c1a60","unresolved":false,"context_lines":[{"line_number":4050,"context_line":"def do_share_group_type_list(cs, args):"},{"line_number":4051,"context_line":"    \"\"\"Print a list of available \u0027share group types\u0027.\"\"\""},{"line_number":4052,"context_line":""},{"line_number":4053,"context_line":"    try:"},{"line_number":4054,"context_line":"        default \u003d cs.share_group_types.get()"},{"line_number":4055,"context_line":"    except exceptions.NotFound:"},{"line_number":4056,"context_line":"        default \u003d None"},{"line_number":4057,"context_line":""},{"line_number":4058,"context_line":"    sg_types \u003d cs.share_group_types.list(show_all\u003dargs.all)"},{"line_number":4059,"context_line":"    _print_share_group_type_list("}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_3f1f395b","line":4056,"range":{"start_line":4053,"start_character":0,"end_line":4056,"end_character":22},"in_reply_to":"5f7c97a3_8a556954","updated":"2018-07-25 15:25:41.000000000","message":"Done","commit_id":"f5f42f0d147a5a4eaa0d1d9e5b1527c8a2753826"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d3308df3bcc39e92f949a72fe131f8175b17c73a","unresolved":false,"context_lines":[{"line_number":4055,"context_line":"    except exceptions.NotFound:"},{"line_number":4056,"context_line":"        default \u003d None"},{"line_number":4057,"context_line":""},{"line_number":4058,"context_line":"    sg_types \u003d cs.share_group_types.list(show_all\u003dargs.all)"},{"line_number":4059,"context_line":"    _print_share_group_type_list("},{"line_number":4060,"context_line":"        sg_types, default_share_group_type\u003ddefault, columns\u003dargs.columns)"},{"line_number":4061,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_8ab1e993","line":4058,"range":{"start_line":4058,"start_character":58,"end_line":4058,"end_character":59},"updated":"2018-07-19 22:57:10.000000000","message":"after this line:\n\n default\u003dNone\n if (sg_types and not hasattr(sg_types[0], \u0027is_default\u0027)):\n    if (columns and \u0027is_default\u0027 in columns) or columns is None:\n        default \u003d cs.share_group_types.get()","commit_id":"f5f42f0d147a5a4eaa0d1d9e5b1527c8a2753826"},{"author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"change_message_id":"f1ffa7b6a50139703f09f7a3dc219d201b3c1a60","unresolved":false,"context_lines":[{"line_number":4055,"context_line":"    except exceptions.NotFound:"},{"line_number":4056,"context_line":"        default \u003d None"},{"line_number":4057,"context_line":""},{"line_number":4058,"context_line":"    sg_types \u003d cs.share_group_types.list(show_all\u003dargs.all)"},{"line_number":4059,"context_line":"    _print_share_group_type_list("},{"line_number":4060,"context_line":"        sg_types, default_share_group_type\u003ddefault, columns\u003dargs.columns)"},{"line_number":4061,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_ff30e1ec","line":4058,"range":{"start_line":4058,"start_character":58,"end_line":4058,"end_character":59},"in_reply_to":"5f7c97a3_8ab1e993","updated":"2018-07-25 15:25:41.000000000","message":"Done","commit_id":"f5f42f0d147a5a4eaa0d1d9e5b1527c8a2753826"}],"releasenotes/notes/fix-is-default-empty-557844001e0401e2.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d3308df3bcc39e92f949a72fe131f8175b17c73a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fix is_default value empty when create a sahre type or"},{"line_number":4,"context_line":"    share group type."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f7c97a3_4a719176","line":3,"range":{"start_line":3,"start_character":45,"end_line":3,"end_character":50},"updated":"2018-07-19 22:57:10.000000000","message":"share","commit_id":"f5f42f0d147a5a4eaa0d1d9e5b1527c8a2753826"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"1100f0fdce2f155f4635291da6070c6d190cb4f2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fix is_default value empty when create a sahre type or"},{"line_number":4,"context_line":"    share group type."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f7c97a3_c5946f9b","line":3,"range":{"start_line":3,"start_character":45,"end_line":3,"end_character":50},"in_reply_to":"5f7c97a3_4a719176","updated":"2018-07-24 18:47:49.000000000","message":"Done","commit_id":"f5f42f0d147a5a4eaa0d1d9e5b1527c8a2753826"}]}
