)]}'
{"id":"openstack%2Fpython-manilaclient~539121","triplet_id":"openstack%2Fpython-manilaclient~master~If31aa24f74db73ab925f6568d3c8653228b6e9c6","project":"openstack/python-manilaclient","branch":"master","hashtags":[],"change_id":"If31aa24f74db73ab925f6568d3c8653228b6e9c6","subject":"Clean imports in code","status":"MERGED","created":"2018-01-30 07:32:51.000000000","updated":"2018-02-21 06:51:24.000000000","submitted":"2018-02-21 06:51:24.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"539121-1519195884607-40dcce11","meta_rev_id":"4a39cc27fcb646aa2165b1dedde378221800c92e","_number":539121,"virtual_id_number":539121,"owner":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},{"value":0,"date":"2018-01-31 09:38:52.000000000","_account_id":23512,"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","username":"alexander.pugachev"},{"value":0,"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"value":2,"date":"2018-02-21 06:51:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2018-02-21 04:46:10.000000000","_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"all":[{"value":2,"date":"2018-02-06 17:21:23.000000000","_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},{"value":0,"_account_id":23512,"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","username":"alexander.pugachev"},{"value":2,"date":"2018-01-31 11:22:58.000000000","_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"all":[{"value":1,"date":"2018-02-06 17:21:23.000000000","_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},{"value":0,"_account_id":23512,"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","username":"alexander.pugachev"},{"value":0,"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23512,"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","username":"alexander.pugachev"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-01-31 09:38:52.000000000","updated_by":{"_account_id":23512,"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","username":"alexander.pugachev"},"reviewer":{"_account_id":23512,"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","username":"alexander.pugachev"},"state":"REVIEWER"},{"updated":"2018-01-31 11:22:58.000000000","updated_by":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"reviewer":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"state":"REVIEWER"},{"updated":"2018-02-06 17:21:23.000000000","updated_by":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"reviewer":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"state":"REVIEWER"},{"updated":"2018-02-21 06:51:24.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"972f78844eedac1a49afbfbb5f9ce9e1c4820bd1","author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"date":"2018-01-30 07:32:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f854d85d3b355f5df4a0e4ddc9584ba8cabfedb8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-30 08:55:57.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- build-openstack-sphinx-docs http://logs.openstack.org/21/539121/1/check/build-openstack-sphinx-docs/2cc1112/html/ : SUCCESS in 8m 36s\n- openstack-tox-pep8 http://logs.openstack.org/21/539121/1/check/openstack-tox-pep8/88b03e2/ : SUCCESS in 4m 58s\n- manilaclient-dsvm-neutron-functional http://logs.openstack.org/21/539121/1/check/manilaclient-dsvm-neutron-functional/df72e2a/ : FAILURE in 17m 37s","accounts_in_message":[],"_revision_number":1},{"id":"0a643d00b790e48b5c9c27daa8250fdb5d2d97d0","author":{"_account_id":23512,"name":"Alexander Pugachev","email":"alexander.pugachev@workday.com","username":"alexander.pugachev"},"date":"2018-01-31 09:38:52.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"b34fe53c981596f4b532086e2665a576a2db3c2e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-31 10:49:46.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/21/539121/1/check/build-openstack-sphinx-docs/41af32e/html/ : SUCCESS in 5m 18s\n- openstack-tox-pep8 http://logs.openstack.org/21/539121/1/check/openstack-tox-pep8/e54ada1/ : SUCCESS in 4m 17s\n- manilaclient-dsvm-neutron-functional http://logs.openstack.org/21/539121/1/check/manilaclient-dsvm-neutron-functional/2d754c6/ : SUCCESS in 50m 18s","accounts_in_message":[],"_revision_number":1},{"id":"6e360c6f55953f14dce169ae7e30ce054237a6b4","author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"date":"2018-01-31 11:22:58.000000000","message":"Patch Set 1: Code-Review+2\n\nLGTM, thanks!","accounts_in_message":[],"_revision_number":1},{"id":"f71ab5d907871bfcf005ce4c6fd29249b967ad95","author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"date":"2018-02-06 17:21:23.000000000","message":"Patch Set 1: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"3d41abbbd35c3e1f6bd50687022cb656a6394295","author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"date":"2018-02-21 04:46:10.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"52c8926b69edf2f78cf9c8842f700ad995477d48","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-02-21 05:42:52.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/21/539121/1/check/build-openstack-sphinx-docs/72dd055/html/ : SUCCESS in 4m 55s\n- openstack-tox-pep8 http://logs.openstack.org/21/539121/1/check/openstack-tox-pep8/a2c26e2/ : SUCCESS in 4m 33s\n- manilaclient-dsvm-neutron-functional http://logs.openstack.org/21/539121/1/check/manilaclient-dsvm-neutron-functional/01db31e/ : SUCCESS in 54m 22s","accounts_in_message":[],"_revision_number":1},{"id":"b586e1b53f28e4ca81ceb337b149d0ad1ce026e2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-02-21 05:43:03.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"d8f7b75d501bbfc4e5e9e4b5e251c652419fd6fd","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-02-21 06:51:24.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/21/539121/1/gate/build-openstack-sphinx-docs/c6cbf3e/html/ : SUCCESS in 3m 13s\n- openstack-tox-pep8 http://logs.openstack.org/21/539121/1/gate/openstack-tox-pep8/b9aa2ff/ : SUCCESS in 3m 37s\n- manilaclient-dsvm-neutron-functional http://logs.openstack.org/21/539121/1/gate/manilaclient-dsvm-neutron-functional/fbc3b14/ : SUCCESS in 1h 07m 23s","accounts_in_message":[],"_revision_number":1},{"id":"4a39cc27fcb646aa2165b1dedde378221800c92e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-02-21 06:51:24.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"8415a4c4e128d844b1fd8a4a7d7d9378efb87d86","revisions":{"8415a4c4e128d844b1fd8a4a7d7d9378efb87d86":{"kind":"REWORK","_number":1,"created":"2018-01-30 07:32:51.000000000","uploader":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"ref":"refs/changes/21/539121/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/21/539121/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/21/539121/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/21/539121/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/21/539121/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/21/539121/1"}}},"commit":{"parents":[{"commit":"27c189f0f3e61590490380d6640628c11b5f7324","subject":"Merge \"Add show share type detail command\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/27c189f0f3e61590490380d6640628c11b5f7324"}]}],"author":{"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","date":"2018-01-30 07:29:56.000000000","tz":420},"committer":{"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","date":"2018-01-30 07:31:18.000000000","tz":420},"subject":"Clean imports in code","message":"Clean imports in code\n\nIn some part in the code we import objects. In the Openstack style guidelines\nthey recommend to import only modules. [1]: \"Do not import objects, only modules\".\n\n[1] https://docs.openstack.org/hacking/0.10.3/\n\nChange-Id: If31aa24f74db73ab925f6568d3c8653228b6e9c6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/8415a4c4e128d844b1fd8a4a7d7d9378efb87d86"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/8415a4c4e128d844b1fd8a4a7d7d9378efb87d86"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}