)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4f38bdb10fe61e185d0a641de2998165c51b7ed3","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now only share have metadata property."},{"line_number":10,"context_line":"We should support it for access rule as well."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I41b2882ecd16ed03bece05a7a77a387c9077bf5c"},{"line_number":13,"context_line":"bp: metadata-for-access-rule"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_b922bb53","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":0},"updated":"2018-07-12 03:09:02.000000000","message":"There should be a Depends-On here, to be able to test this against the server patch in the gate","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d859e73d6cf5a7a71f406d242efdba5601edaf0e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now only share have metadata property."},{"line_number":10,"context_line":"We should support it for access rule as well."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I41b2882ecd16ed03bece05a7a77a387c9077bf5c"},{"line_number":13,"context_line":"bp: metadata-for-access-rule"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_edd4db4d","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":0},"in_reply_to":"5f7c97a3_b922bb53","updated":"2018-07-12 14:38:44.000000000","message":"Done","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"}],"manilaclient/config.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4bf590f2d67caf72d60600d7551e30f0cbced220","unresolved":false,"context_lines":[{"line_number":28,"context_line":"auth_opts \u003d ["},{"line_number":29,"context_line":"    # Options for user with \u0027member\u0027 role."},{"line_number":30,"context_line":"    cfg.StrOpt(\"username\","},{"line_number":31,"context_line":"               default\u003d\"demo\","},{"line_number":32,"context_line":"               help\u003d\"This should be the username of a user WITHOUT \""},{"line_number":33,"context_line":"                    \"administrative privileges.\"),"},{"line_number":34,"context_line":"    cfg.StrOpt(\"tenant_name\","}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_dab48e83","line":31,"range":{"start_line":31,"start_character":24,"end_line":31,"end_character":28},"updated":"2018-07-19 22:18:08.000000000","message":"Why are these changes necessary?","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7c61e07d2987ab8a057ba8475ce66ecabad663f0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"auth_opts \u003d ["},{"line_number":29,"context_line":"    # Options for user with \u0027member\u0027 role."},{"line_number":30,"context_line":"    cfg.StrOpt(\"username\","},{"line_number":31,"context_line":"               default\u003d\"demo\","},{"line_number":32,"context_line":"               help\u003d\"This should be the username of a user WITHOUT \""},{"line_number":33,"context_line":"                    \"administrative privileges.\"),"},{"line_number":34,"context_line":"    cfg.StrOpt(\"tenant_name\","}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_d4f0de68","line":31,"range":{"start_line":31,"start_character":24,"end_line":31,"end_character":28},"in_reply_to":"5f7c97a3_dab48e83","updated":"2018-07-20 09:15:32.000000000","message":"Sorry it\u0027s a submit error. Done","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4bf590f2d67caf72d60600d7551e30f0cbced220","unresolved":false,"context_lines":[{"line_number":131,"context_line":"               help\u003d\"Timeout in seconds to wait for a share to become \""},{"line_number":132,"context_line":"                    \"available.\"),"},{"line_number":133,"context_line":"    cfg.DictOpt(\u0027access_types_mapping\u0027,"},{"line_number":134,"context_line":"                default\u003d{\u0027nfs\u0027: \u0027ip\u0027, \u0027cifs\u0027: \u0027user\u0027},"},{"line_number":135,"context_line":"                help\u003d\"Dict contains access types mapping to share \""},{"line_number":136,"context_line":"                     \"protocol. It will be used to create access rules \""},{"line_number":137,"context_line":"                     \"for shares. Format: \u0027\u003cprotocol\u003e: \u003ctype1\u003e \u003ctype2\u003e\u0027,...\""}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_9aaa9617","line":134,"range":{"start_line":134,"start_character":46,"end_line":134,"end_character":52},"updated":"2018-07-19 22:18:08.000000000","message":"unrelated to this patch?","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7c61e07d2987ab8a057ba8475ce66ecabad663f0","unresolved":false,"context_lines":[{"line_number":131,"context_line":"               help\u003d\"Timeout in seconds to wait for a share to become \""},{"line_number":132,"context_line":"                    \"available.\"),"},{"line_number":133,"context_line":"    cfg.DictOpt(\u0027access_types_mapping\u0027,"},{"line_number":134,"context_line":"                default\u003d{\u0027nfs\u0027: \u0027ip\u0027, \u0027cifs\u0027: \u0027user\u0027},"},{"line_number":135,"context_line":"                help\u003d\"Dict contains access types mapping to share \""},{"line_number":136,"context_line":"                     \"protocol. It will be used to create access rules \""},{"line_number":137,"context_line":"                     \"for shares. Format: \u0027\u003cprotocol\u003e: \u003ctype1\u003e \u003ctype2\u003e\u0027,...\""}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_74e30aa1","line":134,"range":{"start_line":134,"start_character":46,"end_line":134,"end_character":52},"in_reply_to":"5f7c97a3_9aaa9617","updated":"2018-07-20 09:15:32.000000000","message":"Sorry it\u0027s a submit error. Done","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"}],"manilaclient/tests/functional/test_share_access.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4bf590f2d67caf72d60600d7551e30f0cbced220","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        return access"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @ddt.data(\"1.0\", \"2.0\", \"2.6\", \"2.7\", \"2.21\", \"2.33\", \"2.44\", \"2.45\")"},{"line_number":81,"context_line":"    def test_create_list_access_rule_for_share(self, microversion):"},{"line_number":82,"context_line":"        self.skip_if_microversion_not_supported(microversion)"},{"line_number":83,"context_line":"        access \u003d self._test_create_list_access_rule_for_share("}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_5dbab8b9","line":80,"range":{"start_line":80,"start_character":72,"end_line":80,"end_character":73},"updated":"2018-07-19 22:18:08.000000000","message":"also add  api_versions.MAX_VERSION\n\nyou can use *set() to condense the list if  api_versions.MAX_VERSION is 2.45","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7c61e07d2987ab8a057ba8475ce66ecabad663f0","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        return access"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @ddt.data(\"1.0\", \"2.0\", \"2.6\", \"2.7\", \"2.21\", \"2.33\", \"2.44\", \"2.45\")"},{"line_number":81,"context_line":"    def test_create_list_access_rule_for_share(self, microversion):"},{"line_number":82,"context_line":"        self.skip_if_microversion_not_supported(microversion)"},{"line_number":83,"context_line":"        access \u003d self._test_create_list_access_rule_for_share("}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_1475f6c8","line":80,"range":{"start_line":80,"start_character":72,"end_line":80,"end_character":73},"in_reply_to":"5f7c97a3_5dbab8b9","updated":"2018-07-20 09:15:32.000000000","message":"Done","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4bf590f2d67caf72d60600d7551e30f0cbced220","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        if (api_versions.APIVersion(microversion) \u003e\u003d"},{"line_number":96,"context_line":"                api_versions.APIVersion(\"2.45\")):"},{"line_number":97,"context_line":"            self.assertTrue("},{"line_number":98,"context_line":"                all((\u0027access_key\u0027 and \u0027created_at\u0027 and"},{"line_number":99,"context_line":"                     \u0027updated_at\u0027 and \u0027metadata\u0027) in a for a in access_list))"},{"line_number":100,"context_line":"        elif (api_versions.APIVersion(microversion) \u003e\u003d"},{"line_number":101,"context_line":"                api_versions.APIVersion(\"2.33\")):"},{"line_number":102,"context_line":"            self.assertTrue("}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_fd7384b2","line":99,"range":{"start_line":98,"start_character":20,"end_line":99,"end_character":54},"updated":"2018-07-19 22:18:08.000000000","message":"This is wrong.. \n\nTry running this in python, it only returns the last key:\n\n \u003e\u003e\u003e (\u0027access_key\u0027 and \u0027created_at\u0027 and\n...                      \u0027updated_at\u0027 and \u0027metadata\u0027)\n\u0027metadata\u0027","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7c61e07d2987ab8a057ba8475ce66ecabad663f0","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        if (api_versions.APIVersion(microversion) \u003e\u003d"},{"line_number":96,"context_line":"                api_versions.APIVersion(\"2.45\")):"},{"line_number":97,"context_line":"            self.assertTrue("},{"line_number":98,"context_line":"                all((\u0027access_key\u0027 and \u0027created_at\u0027 and"},{"line_number":99,"context_line":"                     \u0027updated_at\u0027 and \u0027metadata\u0027) in a for a in access_list))"},{"line_number":100,"context_line":"        elif (api_versions.APIVersion(microversion) \u003e\u003d"},{"line_number":101,"context_line":"                api_versions.APIVersion(\"2.33\")):"},{"line_number":102,"context_line":"            self.assertTrue("}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_b72524b0","line":99,"range":{"start_line":98,"start_character":20,"end_line":99,"end_character":54},"in_reply_to":"5f7c97a3_fd7384b2","updated":"2018-07-20 09:15:32.000000000","message":"Done","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4bf590f2d67caf72d60600d7551e30f0cbced220","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        elif (api_versions.APIVersion(microversion) \u003e\u003d"},{"line_number":101,"context_line":"                api_versions.APIVersion(\"2.33\")):"},{"line_number":102,"context_line":"            self.assertTrue("},{"line_number":103,"context_line":"                all((\u0027access_key\u0027 and \u0027created_at\u0027 and \u0027updated_at\u0027)"},{"line_number":104,"context_line":"                    in a for a in access_list))"},{"line_number":105,"context_line":"        elif (api_versions.APIVersion(microversion) \u003e\u003d"},{"line_number":106,"context_line":"                api_versions.APIVersion(\"2.21\")):"},{"line_number":107,"context_line":"            self.assertTrue(all(\u0027access_key\u0027 in a for a in access_list))"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_9d8db036","line":104,"range":{"start_line":103,"start_character":19,"end_line":104,"end_character":46},"updated":"2018-07-19 22:18:08.000000000","message":"this was wrong as well.. \n\n all(all(key in access for key in (\u0027access_key\u0027, \u0027created_at\u0027, \u0027updated_at\u0027))\n    for access in access_list)\n\nor just:\n\n for access in access_list:\n    self.assertTrue(all(key in access for key in \n                   (\u0027access_key\u0027, \u0027created_at\u0027, \u0027updated_at\u0027))","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7c61e07d2987ab8a057ba8475ce66ecabad663f0","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        elif (api_versions.APIVersion(microversion) \u003e\u003d"},{"line_number":101,"context_line":"                api_versions.APIVersion(\"2.33\")):"},{"line_number":102,"context_line":"            self.assertTrue("},{"line_number":103,"context_line":"                all((\u0027access_key\u0027 and \u0027created_at\u0027 and \u0027updated_at\u0027)"},{"line_number":104,"context_line":"                    in a for a in access_list))"},{"line_number":105,"context_line":"        elif (api_versions.APIVersion(microversion) \u003e\u003d"},{"line_number":106,"context_line":"                api_versions.APIVersion(\"2.21\")):"},{"line_number":107,"context_line":"            self.assertTrue(all(\u0027access_key\u0027 in a for a in access_list))"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_17117850","line":104,"range":{"start_line":103,"start_character":19,"end_line":104,"end_character":46},"in_reply_to":"5f7c97a3_9d8db036","updated":"2018-07-20 09:15:32.000000000","message":"Done","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4bf590f2d67caf72d60600d7551e30f0cbced220","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        self.assertRaises(tempest_lib_exc.NotFound,"},{"line_number":162,"context_line":"                          self.user_client.get_access, share_id, access[\u0027id\u0027])"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    @ddt.data(\"2.45\", api_versions.MAX_VERSION)"},{"line_number":165,"context_line":"    def test_create_list_access_rule_with_metadata(self, microversion):"},{"line_number":166,"context_line":"        self.skip_if_microversion_not_supported(microversion)"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_fd8ce42e","line":164,"range":{"start_line":164,"start_character":14,"end_line":164,"end_character":46},"updated":"2018-07-19 22:18:08.000000000","message":"*set(\"2.45\", api_versions.MAX_VERSION)","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7c61e07d2987ab8a057ba8475ce66ecabad663f0","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        self.assertRaises(tempest_lib_exc.NotFound,"},{"line_number":162,"context_line":"                          self.user_client.get_access, share_id, access[\u0027id\u0027])"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    @ddt.data(\"2.45\", api_versions.MAX_VERSION)"},{"line_number":165,"context_line":"    def test_create_list_access_rule_with_metadata(self, microversion):"},{"line_number":166,"context_line":"        self.skip_if_microversion_not_supported(microversion)"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_573930cc","line":164,"range":{"start_line":164,"start_character":14,"end_line":164,"end_character":46},"in_reply_to":"5f7c97a3_fd8ce42e","updated":"2018-07-20 09:15:32.000000000","message":"Done","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4bf590f2d67caf72d60600d7551e30f0cbced220","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        md1 \u003d {\"key1\": \"value1\", \"key2\": \"value2\"}"},{"line_number":169,"context_line":"        md2 \u003d {\"key3\": \"value3\", \"key4\": \"value4\"}"},{"line_number":170,"context_line":"        self._test_create_list_access_rule_for_share("},{"line_number":171,"context_line":"            metadata\u003dmd1, microversion\u003dmicroversion)"},{"line_number":172,"context_line":"        access \u003d self._test_create_list_access_rule_for_share("},{"line_number":173,"context_line":"            metadata\u003dmd2, microversion\u003dmicroversion)"},{"line_number":174,"context_line":"        access_list \u003d self.user_client.list_access("}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_3dd49ce9","line":171,"range":{"start_line":171,"start_character":12,"end_line":171,"end_character":26},"updated":"2018-07-19 22:18:08.000000000","message":"this is an unknown key for _test_create_list_access_rule_for_share","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7c61e07d2987ab8a057ba8475ce66ecabad663f0","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        md1 \u003d {\"key1\": \"value1\", \"key2\": \"value2\"}"},{"line_number":169,"context_line":"        md2 \u003d {\"key3\": \"value3\", \"key4\": \"value4\"}"},{"line_number":170,"context_line":"        self._test_create_list_access_rule_for_share("},{"line_number":171,"context_line":"            metadata\u003dmd1, microversion\u003dmicroversion)"},{"line_number":172,"context_line":"        access \u003d self._test_create_list_access_rule_for_share("},{"line_number":173,"context_line":"            metadata\u003dmd2, microversion\u003dmicroversion)"},{"line_number":174,"context_line":"        access_list \u003d self.user_client.list_access("}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_976ca8cf","line":171,"range":{"start_line":171,"start_character":12,"end_line":171,"end_character":26},"in_reply_to":"5f7c97a3_3dd49ce9","updated":"2018-07-20 09:15:32.000000000","message":"Done","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4bf590f2d67caf72d60600d7551e30f0cbced220","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        access_list \u003d self.user_client.list_access("},{"line_number":175,"context_line":"            self.share[\u0027id\u0027], metadata\u003d{\"key4\": \"value4\"},"},{"line_number":176,"context_line":"            microversion\u003dmicroversion"},{"line_number":177,"context_line":"        )"},{"line_number":178,"context_line":"        self.assertEqual(1, len(access_list))"},{"line_number":179,"context_line":"        # Verify share metadata"},{"line_number":180,"context_line":"        metadata \u003d ast.literal_eval(access_list[0][\u0027metadata\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_bdabcc6e","line":177,"range":{"start_line":177,"start_character":8,"end_line":177,"end_character":9},"updated":"2018-07-19 22:18:08.000000000","message":"pull to previous line","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7c61e07d2987ab8a057ba8475ce66ecabad663f0","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        access_list \u003d self.user_client.list_access("},{"line_number":175,"context_line":"            self.share[\u0027id\u0027], metadata\u003d{\"key4\": \"value4\"},"},{"line_number":176,"context_line":"            microversion\u003dmicroversion"},{"line_number":177,"context_line":"        )"},{"line_number":178,"context_line":"        self.assertEqual(1, len(access_list))"},{"line_number":179,"context_line":"        # Verify share metadata"},{"line_number":180,"context_line":"        metadata \u003d ast.literal_eval(access_list[0][\u0027metadata\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_3767d4ec","line":177,"range":{"start_line":177,"start_character":8,"end_line":177,"end_character":9},"in_reply_to":"5f7c97a3_bdabcc6e","updated":"2018-07-20 09:15:32.000000000","message":"Done","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4bf590f2d67caf72d60600d7551e30f0cbced220","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        self.user_client.wait_for_access_rule_deletion(access[\u0027share_id\u0027],"},{"line_number":190,"context_line":"                                                       access[\u0027id\u0027])"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    @ddt.data(\"2.45\", api_versions.MAX_VERSION)"},{"line_number":193,"context_line":"    def test_create_update_show_access_rule_with_metadata(self, microversion):"},{"line_number":194,"context_line":"        self.skip_if_microversion_not_supported(microversion)"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_5dcf1853","line":192,"range":{"start_line":192,"start_character":13,"end_line":192,"end_character":47},"updated":"2018-07-19 22:18:08.000000000","message":"*set","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7c61e07d2987ab8a057ba8475ce66ecabad663f0","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        self.user_client.wait_for_access_rule_deletion(access[\u0027share_id\u0027],"},{"line_number":190,"context_line":"                                                       access[\u0027id\u0027])"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    @ddt.data(\"2.45\", api_versions.MAX_VERSION)"},{"line_number":193,"context_line":"    def test_create_update_show_access_rule_with_metadata(self, microversion):"},{"line_number":194,"context_line":"        self.skip_if_microversion_not_supported(microversion)"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_f75cfc1a","line":192,"range":{"start_line":192,"start_character":13,"end_line":192,"end_character":47},"in_reply_to":"5f7c97a3_5dcf1853","updated":"2018-07-20 09:15:32.000000000","message":"Done","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4bf590f2d67caf72d60600d7551e30f0cbced220","unresolved":false,"context_lines":[{"line_number":217,"context_line":"            ast.literal_eval(get_access[\u0027metadata\u0027]))"},{"line_number":218,"context_line":"        self.assertEqual(access[\u0027id\u0027], get_access[\u0027id\u0027])"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    @ddt.data(\"2.45\", api_versions.MAX_VERSION)"},{"line_number":221,"context_line":"    def test_delete_access_rule_metadata(self, microversion):"},{"line_number":222,"context_line":"        self.skip_if_microversion_not_supported(microversion)"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_1d076083","line":220,"range":{"start_line":220,"start_character":14,"end_line":220,"end_character":47},"updated":"2018-07-19 22:18:08.000000000","message":"*set","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7c61e07d2987ab8a057ba8475ce66ecabad663f0","unresolved":false,"context_lines":[{"line_number":217,"context_line":"            ast.literal_eval(get_access[\u0027metadata\u0027]))"},{"line_number":218,"context_line":"        self.assertEqual(access[\u0027id\u0027], get_access[\u0027id\u0027])"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    @ddt.data(\"2.45\", api_versions.MAX_VERSION)"},{"line_number":221,"context_line":"    def test_delete_access_rule_metadata(self, microversion):"},{"line_number":222,"context_line":"        self.skip_if_microversion_not_supported(microversion)"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_b798c4cb","line":220,"range":{"start_line":220,"start_character":14,"end_line":220,"end_character":47},"in_reply_to":"5f7c97a3_1d076083","updated":"2018-07-20 09:15:32.000000000","message":"Done","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5845c7bd61f0a1957fa93b0ed80d573c9681219f","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            microversion\u003dmicroversion)"},{"line_number":178,"context_line":"        self.assertEqual(1, len(access_list))"},{"line_number":179,"context_line":"        # Verify share metadata"},{"line_number":180,"context_line":"        get_access \u003d self.user_client.access_show("},{"line_number":181,"context_line":"            access_list[0][\u0027id\u0027], microversion\u003dmicroversion)"},{"line_number":182,"context_line":"        metadata \u003d ast.literal_eval(get_access[\u0027metadata\u0027])"},{"line_number":183,"context_line":"        self.assertEqual(2, len(metadata))"},{"line_number":184,"context_line":"        self.assertIn(\u0027key3\u0027, metadata)"}],"source_content_type":"text/x-python","patch_set":11,"id":"5f7c97a3_c2d32e01","line":181,"range":{"start_line":180,"start_character":8,"end_line":181,"end_character":60},"updated":"2018-07-20 16:38:57.000000000","message":"This is good, but wouldn\u0027t list_access also give you these metadata items?, i.e, with:\n\n manila access-list --columns id,metadata\n\nfor instance..","commit_id":"1aa12eb2f805ee6c65ba8b9787f4859c6e27ecd7"}],"manilaclient/tests/functional/test_share_access_metadata.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"7cf98f23de243934d5803da18158c7b87cbcdc43","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"@ddt.ddt"},{"line_number":28,"context_line":"class ShareAccessMetadataBase(base.BaseTestCase):"},{"line_number":29,"context_line":"    protocol \u003d None"},{"line_number":30,"context_line":"    access_level \u003d None"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_b932200e","line":29,"range":{"start_line":28,"start_character":0,"end_line":29,"end_character":19},"updated":"2018-07-18 21:35:37.000000000","message":"So this file is basically a copy of test_share_access.py with the actual test cases there removed and replaced with the new share_access_metadata test cases.\n\nIs there a way to just add these new test cases to the other file since you\u0027ve copied all the class setup and stuff from there anyways?","commit_id":"79995d92420028ab60002a110599d02ece93f554"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c77ae3167808c1604d720cc3a97bb2b1f05cb094","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"@ddt.ddt"},{"line_number":28,"context_line":"class ShareAccessMetadataBase(base.BaseTestCase):"},{"line_number":29,"context_line":"    protocol \u003d None"},{"line_number":30,"context_line":"    access_level \u003d None"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_7b20e9f8","line":29,"range":{"start_line":28,"start_character":0,"end_line":29,"end_character":19},"in_reply_to":"5f7c97a3_b932200e","updated":"2018-07-19 14:47:24.000000000","message":"Done","commit_id":"79995d92420028ab60002a110599d02ece93f554"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"7cf98f23de243934d5803da18158c7b87cbcdc43","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            cls.protocol, \u0027\u0027).split(\u0027 \u0027)"},{"line_number":47,"context_line":"        if not cls.access_types:"},{"line_number":48,"context_line":"            raise cls.skipException(\"No access levels were provided for %s \""},{"line_number":49,"context_line":"                                    \"share access tests.\" % cls.protoco)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        cls.share \u003d cls.create_share(share_protocol\u003dcls.protocol,"},{"line_number":52,"context_line":"                                     public\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_19aeb42e","line":49,"range":{"start_line":49,"start_character":37,"end_line":49,"end_character":54},"updated":"2018-07-18 21:35:37.000000000","message":"share access metadata tests?","commit_id":"79995d92420028ab60002a110599d02ece93f554"}],"manilaclient/tests/unit/v2/fakes.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4bf590f2d67caf72d60600d7551e30f0cbced220","unresolved":false,"context_lines":[{"line_number":535,"context_line":"        return (200, {}, {\u0027metadata\u0027: {\u0027key1\u0027: \u0027v1\u0027, \u0027key2\u0027: \u0027v2\u0027}})"},{"line_number":536,"context_line":""},{"line_number":537,"context_line":"    def delete_share_access_rules_9999_metadata_key1(self, **kw):"},{"line_number":538,"context_line":"        return (202, {}, None)"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"    def get_shares_2222(self, **kw):"},{"line_number":541,"context_line":"        share \u003d {\u0027share\u0027: {\u0027id\u0027: 2222, \u0027name\u0027: \u0027sharename\u0027}}"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_ddfc8872","line":538,"range":{"start_line":538,"start_character":16,"end_line":538,"end_character":19},"updated":"2018-07-19 22:18:08.000000000","message":"This API returns 200 and not 202","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7c61e07d2987ab8a057ba8475ce66ecabad663f0","unresolved":false,"context_lines":[{"line_number":535,"context_line":"        return (200, {}, {\u0027metadata\u0027: {\u0027key1\u0027: \u0027v1\u0027, \u0027key2\u0027: \u0027v2\u0027}})"},{"line_number":536,"context_line":""},{"line_number":537,"context_line":"    def delete_share_access_rules_9999_metadata_key1(self, **kw):"},{"line_number":538,"context_line":"        return (202, {}, None)"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"    def get_shares_2222(self, **kw):"},{"line_number":541,"context_line":"        share \u003d {\u0027share\u0027: {\u0027id\u0027: 2222, \u0027name\u0027: \u0027sharename\u0027}}"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_f78abc62","line":538,"range":{"start_line":538,"start_character":16,"end_line":538,"end_character":19},"in_reply_to":"5f7c97a3_ddfc8872","updated":"2018-07-20 09:15:32.000000000","message":"Done","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"}],"manilaclient/tests/unit/v2/test_shell.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4f38bdb10fe61e185d0a641de2998165c51b7ed3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5f7c97a3_c2221c55","updated":"2018-07-12 03:09:02.000000000","message":"Missing tests for set and unset metadata","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d859e73d6cf5a7a71f406d242efdba5601edaf0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5f7c97a3_6dd20b5e","in_reply_to":"5f7c97a3_c2221c55","updated":"2018-07-12 14:38:44.000000000","message":"Done","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4f38bdb10fe61e185d0a641de2998165c51b7ed3","unresolved":false,"context_lines":[{"line_number":1715,"context_line":"        }"},{"line_number":1716,"context_line":""},{"line_number":1717,"context_line":"        self.run_command("},{"line_number":1718,"context_line":"            \"access-allow 2222 ip 10.0.0.6 --metadata key1\u003dv1\","},{"line_number":1719,"context_line":"            version\u003d\"2.45\")"},{"line_number":1720,"context_line":"        self.assert_called(\"POST\", \"/shares/2222/action\", body\u003dexpected)"},{"line_number":1721,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_2260b0a4","line":1718,"range":{"start_line":1718,"start_character":61,"end_line":1718,"end_character":62},"updated":"2018-07-12 03:09:02.000000000","message":"supply key2\u003dv2 as well","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d859e73d6cf5a7a71f406d242efdba5601edaf0e","unresolved":false,"context_lines":[{"line_number":1715,"context_line":"        }"},{"line_number":1716,"context_line":""},{"line_number":1717,"context_line":"        self.run_command("},{"line_number":1718,"context_line":"            \"access-allow 2222 ip 10.0.0.6 --metadata key1\u003dv1\","},{"line_number":1719,"context_line":"            version\u003d\"2.45\")"},{"line_number":1720,"context_line":"        self.assert_called(\"POST\", \"/shares/2222/action\", body\u003dexpected)"},{"line_number":1721,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_47a4d1a3","line":1718,"range":{"start_line":1718,"start_character":61,"end_line":1718,"end_character":62},"in_reply_to":"5f7c97a3_2260b0a4","updated":"2018-07-12 14:38:44.000000000","message":"Done","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4f38bdb10fe61e185d0a641de2998165c51b7ed3","unresolved":false,"context_lines":[{"line_number":1719,"context_line":"            version\u003d\"2.45\")"},{"line_number":1720,"context_line":"        self.assert_called(\"POST\", \"/shares/2222/action\", body\u003dexpected)"},{"line_number":1721,"context_line":""},{"line_number":1722,"context_line":"    @ddt.data(\"1.0\", \"2.0\", \"2.43\")"},{"line_number":1723,"context_line":"    def test_allow_access_with_metadata_not_support_version(self, version):"},{"line_number":1724,"context_line":"        for separator in self.separators:"},{"line_number":1725,"context_line":"            self.assertRaises("}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_826e6495","line":1722,"range":{"start_line":1722,"start_character":32,"end_line":1722,"end_character":33},"updated":"2018-07-12 03:09:02.000000000","message":"2.44","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d859e73d6cf5a7a71f406d242efdba5601edaf0e","unresolved":false,"context_lines":[{"line_number":1719,"context_line":"            version\u003d\"2.45\")"},{"line_number":1720,"context_line":"        self.assert_called(\"POST\", \"/shares/2222/action\", body\u003dexpected)"},{"line_number":1721,"context_line":""},{"line_number":1722,"context_line":"    @ddt.data(\"1.0\", \"2.0\", \"2.43\")"},{"line_number":1723,"context_line":"    def test_allow_access_with_metadata_not_support_version(self, version):"},{"line_number":1724,"context_line":"        for separator in self.separators:"},{"line_number":1725,"context_line":"            self.assertRaises("}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_e7b2bde8","line":1722,"range":{"start_line":1722,"start_character":32,"end_line":1722,"end_character":33},"in_reply_to":"5f7c97a3_826e6495","updated":"2018-07-12 14:38:44.000000000","message":"Done","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4f38bdb10fe61e185d0a641de2998165c51b7ed3","unresolved":false,"context_lines":[{"line_number":1721,"context_line":""},{"line_number":1722,"context_line":"    @ddt.data(\"1.0\", \"2.0\", \"2.43\")"},{"line_number":1723,"context_line":"    def test_allow_access_with_metadata_not_support_version(self, version):"},{"line_number":1724,"context_line":"        for separator in self.separators:"},{"line_number":1725,"context_line":"            self.assertRaises("},{"line_number":1726,"context_line":"                exceptions.CommandError,"},{"line_number":1727,"context_line":"                self.run_command,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_020014b1","line":1724,"range":{"start_line":1724,"start_character":12,"end_line":1724,"end_character":21},"updated":"2018-07-12 03:09:02.000000000","message":"you haven\u0027t used this below..","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d859e73d6cf5a7a71f406d242efdba5601edaf0e","unresolved":false,"context_lines":[{"line_number":1721,"context_line":""},{"line_number":1722,"context_line":"    @ddt.data(\"1.0\", \"2.0\", \"2.43\")"},{"line_number":1723,"context_line":"    def test_allow_access_with_metadata_not_support_version(self, version):"},{"line_number":1724,"context_line":"        for separator in self.separators:"},{"line_number":1725,"context_line":"            self.assertRaises("},{"line_number":1726,"context_line":"                exceptions.CommandError,"},{"line_number":1727,"context_line":"                self.run_command,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_a7acc588","line":1724,"range":{"start_line":1724,"start_character":12,"end_line":1724,"end_character":21},"in_reply_to":"5f7c97a3_020014b1","updated":"2018-07-12 14:38:44.000000000","message":"Done","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4f38bdb10fe61e185d0a641de2998165c51b7ed3","unresolved":false,"context_lines":[{"line_number":1731,"context_line":""},{"line_number":1732,"context_line":"    @mock.patch.object(cliutils, \u0027print_list\u0027, mock.Mock())"},{"line_number":1733,"context_line":"    def test_access_list(self):"},{"line_number":1734,"context_line":"        self.run_command(\"access-list 1111\", version\u003d\"2.44\")"},{"line_number":1735,"context_line":"        cliutils.print_list.assert_called_with("},{"line_number":1736,"context_line":"            mock.ANY,"},{"line_number":1737,"context_line":"            [\u0027id\u0027, \u0027access_type\u0027, \u0027access_to\u0027, \u0027access_level\u0027, \u0027state\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_82f3c4e8","line":1734,"range":{"start_line":1734,"start_character":43,"end_line":1734,"end_character":59},"updated":"2018-07-12 03:09:02.000000000","message":"perhaps use ddt and see if metadata is being returned for version 2.45","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d859e73d6cf5a7a71f406d242efdba5601edaf0e","unresolved":false,"context_lines":[{"line_number":1731,"context_line":""},{"line_number":1732,"context_line":"    @mock.patch.object(cliutils, \u0027print_list\u0027, mock.Mock())"},{"line_number":1733,"context_line":"    def test_access_list(self):"},{"line_number":1734,"context_line":"        self.run_command(\"access-list 1111\", version\u003d\"2.44\")"},{"line_number":1735,"context_line":"        cliutils.print_list.assert_called_with("},{"line_number":1736,"context_line":"            mock.ANY,"},{"line_number":1737,"context_line":"            [\u0027id\u0027, \u0027access_type\u0027, \u0027access_to\u0027, \u0027access_level\u0027, \u0027state\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_671f8d71","line":1734,"range":{"start_line":1734,"start_character":43,"end_line":1734,"end_character":59},"in_reply_to":"5f7c97a3_82f3c4e8","updated":"2018-07-12 14:38:44.000000000","message":"Done","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4f38bdb10fe61e185d0a641de2998165c51b7ed3","unresolved":false,"context_lines":[{"line_number":1740,"context_line":"    @mock.patch.object(cliutils, \u0027print_list\u0027, mock.Mock())"},{"line_number":1741,"context_line":"    def test_access_list_select_column(self):"},{"line_number":1742,"context_line":"        self.run_command(\"access-list 1111 --columns id,access_type\","},{"line_number":1743,"context_line":"                         version\u003d\"2.44\")"},{"line_number":1744,"context_line":"        cliutils.print_list.assert_called_with("},{"line_number":1745,"context_line":"            mock.ANY,"},{"line_number":1746,"context_line":"            [\u0027Id\u0027, \u0027Access_Type\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_62fa28bb","line":1743,"range":{"start_line":1743,"start_character":25,"end_line":1743,"end_character":39},"updated":"2018-07-12 03:09:02.000000000","message":"same","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d859e73d6cf5a7a71f406d242efdba5601edaf0e","unresolved":false,"context_lines":[{"line_number":1740,"context_line":"    @mock.patch.object(cliutils, \u0027print_list\u0027, mock.Mock())"},{"line_number":1741,"context_line":"    def test_access_list_select_column(self):"},{"line_number":1742,"context_line":"        self.run_command(\"access-list 1111 --columns id,access_type\","},{"line_number":1743,"context_line":"                         version\u003d\"2.44\")"},{"line_number":1744,"context_line":"        cliutils.print_list.assert_called_with("},{"line_number":1745,"context_line":"            mock.ANY,"},{"line_number":1746,"context_line":"            [\u0027Id\u0027, \u0027Access_Type\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_871c297c","line":1743,"range":{"start_line":1743,"start_character":25,"end_line":1743,"end_character":39},"in_reply_to":"5f7c97a3_62fa28bb","updated":"2018-07-12 14:38:44.000000000","message":"Done","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4bf590f2d67caf72d60600d7551e30f0cbced220","unresolved":false,"context_lines":[{"line_number":1748,"context_line":"        )"},{"line_number":1749,"context_line":""},{"line_number":1750,"context_line":"    @mock.patch.object(cliutils, \u0027print_list\u0027, mock.Mock())"},{"line_number":1751,"context_line":"    @ddt.data(\"2.44\", \"2.45\")"},{"line_number":1752,"context_line":"    def test_access_list(self, version):"},{"line_number":1753,"context_line":"        self.run_command(\"access-list 1111\", version\u003dversion)"},{"line_number":1754,"context_line":"        if version \u003d\u003d \"2.45\":"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_1d2c40ff","line":1751,"range":{"start_line":1751,"start_character":14,"end_line":1751,"end_character":29},"updated":"2018-07-19 22:18:08.000000000","message":"*set + latest microversion","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7c61e07d2987ab8a057ba8475ce66ecabad663f0","unresolved":false,"context_lines":[{"line_number":1748,"context_line":"        )"},{"line_number":1749,"context_line":""},{"line_number":1750,"context_line":"    @mock.patch.object(cliutils, \u0027print_list\u0027, mock.Mock())"},{"line_number":1751,"context_line":"    @ddt.data(\"2.44\", \"2.45\")"},{"line_number":1752,"context_line":"    def test_access_list(self, version):"},{"line_number":1753,"context_line":"        self.run_command(\"access-list 1111\", version\u003dversion)"},{"line_number":1754,"context_line":"        if version \u003d\u003d \"2.45\":"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_d7e9c018","line":1751,"range":{"start_line":1751,"start_character":14,"end_line":1751,"end_character":29},"in_reply_to":"5f7c97a3_1d2c40ff","updated":"2018-07-20 09:15:32.000000000","message":"Done","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4bf590f2d67caf72d60600d7551e30f0cbced220","unresolved":false,"context_lines":[{"line_number":1751,"context_line":"    @ddt.data(\"2.44\", \"2.45\")"},{"line_number":1752,"context_line":"    def test_access_list(self, version):"},{"line_number":1753,"context_line":"        self.run_command(\"access-list 1111\", version\u003dversion)"},{"line_number":1754,"context_line":"        if version \u003d\u003d \"2.45\":"},{"line_number":1755,"context_line":"            cliutils.print_list.assert_called_with("},{"line_number":1756,"context_line":"                mock.ANY,"},{"line_number":1757,"context_line":"                [\u0027id\u0027, \u0027access_type\u0027, \u0027access_to\u0027, \u0027access_level\u0027, \u0027state\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_bd2e6cf6","line":1754,"range":{"start_line":1754,"start_character":19,"end_line":1754,"end_character":20},"updated":"2018-07-19 22:18:08.000000000","message":"\u003e","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7c61e07d2987ab8a057ba8475ce66ecabad663f0","unresolved":false,"context_lines":[{"line_number":1751,"context_line":"    @ddt.data(\"2.44\", \"2.45\")"},{"line_number":1752,"context_line":"    def test_access_list(self, version):"},{"line_number":1753,"context_line":"        self.run_command(\"access-list 1111\", version\u003dversion)"},{"line_number":1754,"context_line":"        if version \u003d\u003d \"2.45\":"},{"line_number":1755,"context_line":"            cliutils.print_list.assert_called_with("},{"line_number":1756,"context_line":"                mock.ANY,"},{"line_number":1757,"context_line":"                [\u0027id\u0027, \u0027access_type\u0027, \u0027access_to\u0027, \u0027access_level\u0027, \u0027state\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_37da7478","line":1754,"range":{"start_line":1754,"start_character":19,"end_line":1754,"end_character":20},"in_reply_to":"5f7c97a3_bd2e6cf6","updated":"2018-07-20 09:15:32.000000000","message":"Done","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4bf590f2d67caf72d60600d7551e30f0cbced220","unresolved":false,"context_lines":[{"line_number":1763,"context_line":"                 \u0027access_key\u0027, \u0027created_at\u0027, \u0027updated_at\u0027])"},{"line_number":1764,"context_line":""},{"line_number":1765,"context_line":"    @mock.patch.object(cliutils, \u0027print_list\u0027, mock.Mock())"},{"line_number":1766,"context_line":"    @ddt.data(\"2.44\", \"2.45\")"},{"line_number":1767,"context_line":"    def test_access_list_select_column(self, version):"},{"line_number":1768,"context_line":"        self.run_command(\"access-list 1111 --columns id,access_type\","},{"line_number":1769,"context_line":"                         version\u003dversion)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_9d4e10c0","line":1766,"range":{"start_line":1766,"start_character":28,"end_line":1766,"end_character":29},"updated":"2018-07-19 22:18:08.000000000","message":"add latest version, we might break something that we wouldn\u0027t know if the tests didn\u0027t run for the latest version\n\nuse *set()","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7c61e07d2987ab8a057ba8475ce66ecabad663f0","unresolved":false,"context_lines":[{"line_number":1763,"context_line":"                 \u0027access_key\u0027, \u0027created_at\u0027, \u0027updated_at\u0027])"},{"line_number":1764,"context_line":""},{"line_number":1765,"context_line":"    @mock.patch.object(cliutils, \u0027print_list\u0027, mock.Mock())"},{"line_number":1766,"context_line":"    @ddt.data(\"2.44\", \"2.45\")"},{"line_number":1767,"context_line":"    def test_access_list_select_column(self, version):"},{"line_number":1768,"context_line":"        self.run_command(\"access-list 1111 --columns id,access_type\","},{"line_number":1769,"context_line":"                         version\u003dversion)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_37c3548c","line":1766,"range":{"start_line":1766,"start_character":28,"end_line":1766,"end_character":29},"in_reply_to":"5f7c97a3_9d4e10c0","updated":"2018-07-20 09:15:32.000000000","message":"Done","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"}],"manilaclient/v2/share_access_rules.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4f38bdb10fe61e185d0a641de2998165c51b7ed3","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        url \u003d RESOURCE_PATH % share_access_rule_id"},{"line_number":64,"context_line":"        return self._get(url, RESOURCE_NAME)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @api_versions.wraps(\"2.45\")"},{"line_number":67,"context_line":"    def delete(self, share_access_rule):"},{"line_number":68,"context_line":"        \"\"\"Delete a share access rule."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        :param share_access_rule: share access rule to be deleted."},{"line_number":71,"context_line":"        \"\"\""},{"line_number":72,"context_line":"        self._delete(RESOURCE_PATH % common_base.getid(share_access_rule))"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @api_versions.wraps(\"2.45\")"},{"line_number":75,"context_line":"    def set_metadata(self, access, metadata):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_d95bf783","line":72,"range":{"start_line":66,"start_character":0,"end_line":72,"end_character":74},"updated":"2018-07-12 03:09:02.000000000","message":"This isn\u0027t implemented against the /share-access-rules on the server patch","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d859e73d6cf5a7a71f406d242efdba5601edaf0e","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        url \u003d RESOURCE_PATH % share_access_rule_id"},{"line_number":64,"context_line":"        return self._get(url, RESOURCE_NAME)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @api_versions.wraps(\"2.45\")"},{"line_number":67,"context_line":"    def delete(self, share_access_rule):"},{"line_number":68,"context_line":"        \"\"\"Delete a share access rule."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        :param share_access_rule: share access rule to be deleted."},{"line_number":71,"context_line":"        \"\"\""},{"line_number":72,"context_line":"        self._delete(RESOURCE_PATH % common_base.getid(share_access_rule))"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @api_versions.wraps(\"2.45\")"},{"line_number":75,"context_line":"    def set_metadata(self, access, metadata):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_07bc99d9","line":72,"range":{"start_line":66,"start_character":0,"end_line":72,"end_character":74},"in_reply_to":"5f7c97a3_d95bf783","updated":"2018-07-12 14:38:44.000000000","message":"Done","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4f38bdb10fe61e185d0a641de2998165c51b7ed3","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            if resp is not None:"},{"line_number":98,"context_line":"                return resp"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    @api_versions.wraps(\"2.45\")  # noqa"},{"line_number":101,"context_line":"    def access_list(self, share, search_opts):"},{"line_number":102,"context_line":"        query_string \u003d \"\""},{"line_number":103,"context_line":"        if search_opts:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_c23bfc98","line":100,"range":{"start_line":100,"start_character":32,"end_line":100,"end_character":39},"updated":"2018-07-12 03:09:02.000000000","message":"is this necessary","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d859e73d6cf5a7a71f406d242efdba5601edaf0e","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            if resp is not None:"},{"line_number":98,"context_line":"                return resp"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    @api_versions.wraps(\"2.45\")  # noqa"},{"line_number":101,"context_line":"    def access_list(self, share, search_opts):"},{"line_number":102,"context_line":"        query_string \u003d \"\""},{"line_number":103,"context_line":"        if search_opts:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_87de693a","line":100,"range":{"start_line":100,"start_character":32,"end_line":100,"end_character":39},"in_reply_to":"5f7c97a3_c23bfc98","updated":"2018-07-12 14:38:44.000000000","message":"Done","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4bf590f2d67caf72d60600d7551e30f0cbced220","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from manilaclient import utils"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"RESOURCES_PATH \u003d \u0027/share-access-rules\u0027"},{"line_number":29,"context_line":"RESOURCE_PATH \u003d \u0027/share-access-rules/%s\u0027"},{"line_number":30,"context_line":"RESOURCES_NAME \u003d \u0027share_access_rules\u0027"},{"line_number":31,"context_line":"RESOURCE_NAME \u003d \u0027access\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_5dd958ee","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":38},"updated":"2018-07-19 22:18:08.000000000","message":"unused","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7c61e07d2987ab8a057ba8475ce66ecabad663f0","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from manilaclient import utils"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"RESOURCES_PATH \u003d \u0027/share-access-rules\u0027"},{"line_number":29,"context_line":"RESOURCE_PATH \u003d \u0027/share-access-rules/%s\u0027"},{"line_number":30,"context_line":"RESOURCES_NAME \u003d \u0027share_access_rules\u0027"},{"line_number":31,"context_line":"RESOURCE_NAME \u003d \u0027access\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_77530cdf","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":38},"in_reply_to":"5f7c97a3_5dd958ee","updated":"2018-07-20 09:15:32.000000000","message":"Done","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4bf590f2d67caf72d60600d7551e30f0cbced220","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"RESOURCES_PATH \u003d \u0027/share-access-rules\u0027"},{"line_number":29,"context_line":"RESOURCE_PATH \u003d \u0027/share-access-rules/%s\u0027"},{"line_number":30,"context_line":"RESOURCES_NAME \u003d \u0027share_access_rules\u0027"},{"line_number":31,"context_line":"RESOURCE_NAME \u003d \u0027access\u0027"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"RESOURCEES_METADATA_PATH \u003d \u0027/share-access-rules/%s/metadata\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_7d01b438","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":37},"updated":"2018-07-19 22:18:08.000000000","message":"unused","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7c61e07d2987ab8a057ba8475ce66ecabad663f0","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"RESOURCES_PATH \u003d \u0027/share-access-rules\u0027"},{"line_number":29,"context_line":"RESOURCE_PATH \u003d \u0027/share-access-rules/%s\u0027"},{"line_number":30,"context_line":"RESOURCES_NAME \u003d \u0027share_access_rules\u0027"},{"line_number":31,"context_line":"RESOURCE_NAME \u003d \u0027access\u0027"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"RESOURCEES_METADATA_PATH \u003d \u0027/share-access-rules/%s/metadata\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_9756e8cc","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":37},"in_reply_to":"5f7c97a3_7d01b438","updated":"2018-07-20 09:15:32.000000000","message":"Done","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4bf590f2d67caf72d60600d7551e30f0cbced220","unresolved":false,"context_lines":[{"line_number":30,"context_line":"RESOURCES_NAME \u003d \u0027share_access_rules\u0027"},{"line_number":31,"context_line":"RESOURCE_NAME \u003d \u0027access\u0027"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"RESOURCEES_METADATA_PATH \u003d \u0027/share-access-rules/%s/metadata\u0027"},{"line_number":34,"context_line":"RESOURCE_METADATA_PATH \u003d \u0027/share-access-rules/%s/metadata/%s\u0027"},{"line_number":35,"context_line":"RESOURCE_LIST_PATH \u003d \u0027/share-access-rules?share_id\u003d%s\u0027"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_7dd8d4ee","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":10},"updated":"2018-07-19 22:18:08.000000000","message":"RESOURCES","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7c61e07d2987ab8a057ba8475ce66ecabad663f0","unresolved":false,"context_lines":[{"line_number":30,"context_line":"RESOURCES_NAME \u003d \u0027share_access_rules\u0027"},{"line_number":31,"context_line":"RESOURCE_NAME \u003d \u0027access\u0027"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"RESOURCEES_METADATA_PATH \u003d \u0027/share-access-rules/%s/metadata\u0027"},{"line_number":34,"context_line":"RESOURCE_METADATA_PATH \u003d \u0027/share-access-rules/%s/metadata/%s\u0027"},{"line_number":35,"context_line":"RESOURCE_LIST_PATH \u003d \u0027/share-access-rules?share_id\u003d%s\u0027"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_f7663cbc","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":10},"in_reply_to":"5f7c97a3_7dd8d4ee","updated":"2018-07-20 09:15:32.000000000","message":"Done","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4bf590f2d67caf72d60600d7551e30f0cbced220","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        \"\"\"Get a specific share access rule."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        :param share_access_rule: either instance of ShareAccessRule, or text"},{"line_number":59,"context_line":"           with UUID, or \u0027default\u0027"},{"line_number":60,"context_line":"        :rtype: :class:`ShareAccessRule`"},{"line_number":61,"context_line":"        \"\"\""},{"line_number":62,"context_line":"        share_access_rule_id \u003d common_base.getid(share_access_rule)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_5d44f89e","line":59,"range":{"start_line":59,"start_character":20,"end_line":59,"end_character":34},"updated":"2018-07-19 22:18:08.000000000","message":"?","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7c61e07d2987ab8a057ba8475ce66ecabad663f0","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        \"\"\"Get a specific share access rule."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        :param share_access_rule: either instance of ShareAccessRule, or text"},{"line_number":59,"context_line":"           with UUID, or \u0027default\u0027"},{"line_number":60,"context_line":"        :rtype: :class:`ShareAccessRule`"},{"line_number":61,"context_line":"        \"\"\""},{"line_number":62,"context_line":"        share_access_rule_id \u003d common_base.getid(share_access_rule)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_37f6f4d9","line":59,"range":{"start_line":59,"start_character":20,"end_line":59,"end_character":34},"in_reply_to":"5f7c97a3_5d44f89e","updated":"2018-07-20 09:15:32.000000000","message":"Done","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4bf590f2d67caf72d60600d7551e30f0cbced220","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @api_versions.wraps(\"2.45\")"},{"line_number":67,"context_line":"    def set_metadata(self, access, metadata):"},{"line_number":68,"context_line":"        \"\"\"Set or update metadata for share."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        :param share_access_rule: either share access rule object or"},{"line_number":71,"context_line":"            text with its ID."}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_bdcaec15","line":68,"range":{"start_line":68,"start_character":43,"end_line":68,"end_character":44},"updated":"2018-07-19 22:18:08.000000000","message":"access rule","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7c61e07d2987ab8a057ba8475ce66ecabad663f0","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @api_versions.wraps(\"2.45\")"},{"line_number":67,"context_line":"    def set_metadata(self, access, metadata):"},{"line_number":68,"context_line":"        \"\"\"Set or update metadata for share."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        :param share_access_rule: either share access rule object or"},{"line_number":71,"context_line":"            text with its ID."}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_f7fb9cbb","line":68,"range":{"start_line":68,"start_character":43,"end_line":68,"end_character":44},"in_reply_to":"5f7c97a3_bdcaec15","updated":"2018-07-20 09:15:32.000000000","message":"Done","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4bf590f2d67caf72d60600d7551e30f0cbced220","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        for k in keys:"},{"line_number":87,"context_line":"            url \u003d RESOURCE_METADATA_PATH % (common_base.getid(access), k)"},{"line_number":88,"context_line":"            resp \u003d self._delete(url)"},{"line_number":89,"context_line":"            if resp is not None:"},{"line_number":90,"context_line":"                return resp"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @api_versions.wraps(\"2.45\")"},{"line_number":93,"context_line":"    def access_list(self, share, search_opts):"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_5da07836","line":90,"range":{"start_line":89,"start_character":12,"end_line":90,"end_character":27},"updated":"2018-07-19 22:18:08.000000000","message":"? Won\u0027t this stop the loop from running?","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7c61e07d2987ab8a057ba8475ce66ecabad663f0","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        for k in keys:"},{"line_number":87,"context_line":"            url \u003d RESOURCE_METADATA_PATH % (common_base.getid(access), k)"},{"line_number":88,"context_line":"            resp \u003d self._delete(url)"},{"line_number":89,"context_line":"            if resp is not None:"},{"line_number":90,"context_line":"                return resp"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @api_versions.wraps(\"2.45\")"},{"line_number":93,"context_line":"    def access_list(self, share, search_opts):"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_055dbe14","line":90,"range":{"start_line":89,"start_character":12,"end_line":90,"end_character":27},"in_reply_to":"5f7c97a3_5da07836","updated":"2018-07-20 09:15:32.000000000","message":"Done","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"}],"manilaclient/v2/shares.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"7cf98f23de243934d5803da18158c7b87cbcdc43","unresolved":false,"context_lines":[{"line_number":509,"context_line":"    def _do_allow(self, share, access_type, access, access_level, action_name,"},{"line_number":510,"context_line":"                  metadata\u003dNone):"},{"line_number":511,"context_line":"        \"\"\"Allow access to a share."},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"        :param share: either share object or text with its ID."},{"line_number":514,"context_line":"        :param access_type: string that represents access type (\u0027ip\u0027,\u0027domain\u0027)"},{"line_number":515,"context_line":"        :param access: string that represents access (\u0027127.0.0.1\u0027)"},{"line_number":516,"context_line":"        :param access_level: string that represents access level (\u0027rw\u0027, \u0027ro\u0027)"},{"line_number":517,"context_line":"        \"\"\""},{"line_number":518,"context_line":"        access_params \u003d {"},{"line_number":519,"context_line":"            \u0027access_type\u0027: access_type,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_7f41eca6","line":516,"range":{"start_line":512,"start_character":0,"end_line":516,"end_character":77},"updated":"2018-07-18 21:35:37.000000000","message":"Add metadata doc string.","commit_id":"8b85e4ce34d13c0d1cdcdfb09457d33cc6de2a71"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c77ae3167808c1604d720cc3a97bb2b1f05cb094","unresolved":false,"context_lines":[{"line_number":509,"context_line":"    def _do_allow(self, share, access_type, access, access_level, action_name,"},{"line_number":510,"context_line":"                  metadata\u003dNone):"},{"line_number":511,"context_line":"        \"\"\"Allow access to a share."},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"        :param share: either share object or text with its ID."},{"line_number":514,"context_line":"        :param access_type: string that represents access type (\u0027ip\u0027,\u0027domain\u0027)"},{"line_number":515,"context_line":"        :param access: string that represents access (\u0027127.0.0.1\u0027)"},{"line_number":516,"context_line":"        :param access_level: string that represents access level (\u0027rw\u0027, \u0027ro\u0027)"},{"line_number":517,"context_line":"        \"\"\""},{"line_number":518,"context_line":"        access_params \u003d {"},{"line_number":519,"context_line":"            \u0027access_type\u0027: access_type,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_9b50650b","line":516,"range":{"start_line":512,"start_character":0,"end_line":516,"end_character":77},"in_reply_to":"5f7c97a3_7f41eca6","updated":"2018-07-19 14:47:24.000000000","message":"Done","commit_id":"8b85e4ce34d13c0d1cdcdfb09457d33cc6de2a71"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4f38bdb10fe61e185d0a641de2998165c51b7ed3","unresolved":false,"context_lines":[{"line_number":1307,"context_line":"    type\u003dstr,"},{"line_number":1308,"context_line":"    nargs\u003d\u0027*\u0027,"},{"line_number":1309,"context_line":"    metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":1310,"context_line":"    help\u003d\u0027Filters results by a metadata key and value. OPTIONAL: \u0027"},{"line_number":1311,"context_line":"         \u0027Default\u003dNone. Available only for microversion \u003e\u003d 2.45.\u0027,"},{"line_number":1312,"context_line":"    default\u003dNone)"},{"line_number":1313,"context_line":"def do_access_allow(cs, args):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_9919ff24","line":1310,"range":{"start_line":1310,"start_character":10,"end_line":1310,"end_character":39},"updated":"2018-07-12 03:09:02.000000000","message":"Comma separated list of key\u003dvalue pairs of metadata items","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d859e73d6cf5a7a71f406d242efdba5601edaf0e","unresolved":false,"context_lines":[{"line_number":1307,"context_line":"    type\u003dstr,"},{"line_number":1308,"context_line":"    nargs\u003d\u0027*\u0027,"},{"line_number":1309,"context_line":"    metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":1310,"context_line":"    help\u003d\u0027Filters results by a metadata key and value. OPTIONAL: \u0027"},{"line_number":1311,"context_line":"         \u0027Default\u003dNone. Available only for microversion \u003e\u003d 2.45.\u0027,"},{"line_number":1312,"context_line":"    default\u003dNone)"},{"line_number":1313,"context_line":"def do_access_allow(cs, args):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_c77d416e","line":1310,"range":{"start_line":1310,"start_character":10,"end_line":1310,"end_character":39},"in_reply_to":"5f7c97a3_9919ff24","updated":"2018-07-12 14:38:44.000000000","message":"Done","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bc6abf25cb45101ec065fd6631d79bced8e416d0","unresolved":false,"context_lines":[{"line_number":1307,"context_line":"    type\u003dstr,"},{"line_number":1308,"context_line":"    nargs\u003d\u0027*\u0027,"},{"line_number":1309,"context_line":"    metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":1310,"context_line":"    help\u003d\u0027Filters results by a metadata key and value. OPTIONAL: \u0027"},{"line_number":1311,"context_line":"         \u0027Default\u003dNone. Available only for microversion \u003e\u003d 2.45.\u0027,"},{"line_number":1312,"context_line":"    default\u003dNone)"},{"line_number":1313,"context_line":"def do_access_allow(cs, args):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_c8223b55","line":1310,"range":{"start_line":1310,"start_character":10,"end_line":1310,"end_character":39},"in_reply_to":"5f7c97a3_9919ff24","updated":"2018-07-12 05:55:18.000000000","message":"Sorry, this is \"Space Separated list\", not comma separated","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d859e73d6cf5a7a71f406d242efdba5601edaf0e","unresolved":false,"context_lines":[{"line_number":1307,"context_line":"    type\u003dstr,"},{"line_number":1308,"context_line":"    nargs\u003d\u0027*\u0027,"},{"line_number":1309,"context_line":"    metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":1310,"context_line":"    help\u003d\u0027Filters results by a metadata key and value. OPTIONAL: \u0027"},{"line_number":1311,"context_line":"         \u0027Default\u003dNone. Available only for microversion \u003e\u003d 2.45.\u0027,"},{"line_number":1312,"context_line":"    default\u003dNone)"},{"line_number":1313,"context_line":"def do_access_allow(cs, args):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_67922da3","line":1310,"range":{"start_line":1310,"start_character":10,"end_line":1310,"end_character":39},"in_reply_to":"5f7c97a3_c8223b55","updated":"2018-07-12 14:38:44.000000000","message":"Done","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4f38bdb10fe61e185d0a641de2998165c51b7ed3","unresolved":false,"context_lines":[{"line_number":1311,"context_line":"         \u0027Default\u003dNone. Available only for microversion \u003e\u003d 2.45.\u0027,"},{"line_number":1312,"context_line":"    default\u003dNone)"},{"line_number":1313,"context_line":"def do_access_allow(cs, args):"},{"line_number":1314,"context_line":"    \"\"\"Allow access to the share.\"\"\""},{"line_number":1315,"context_line":"    access_metadata \u003d None"},{"line_number":1316,"context_line":"    if cs.api_version.matches(api_versions.APIVersion(\"2.45\"),"},{"line_number":1317,"context_line":"                              api_versions.APIVersion()):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_19a16fa9","line":1314,"range":{"start_line":1314,"start_character":23,"end_line":1314,"end_character":26},"updated":"2018-07-12 03:09:02.000000000","message":"can you please fix this to \"a given \"","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d859e73d6cf5a7a71f406d242efdba5601edaf0e","unresolved":false,"context_lines":[{"line_number":1311,"context_line":"         \u0027Default\u003dNone. Available only for microversion \u003e\u003d 2.45.\u0027,"},{"line_number":1312,"context_line":"    default\u003dNone)"},{"line_number":1313,"context_line":"def do_access_allow(cs, args):"},{"line_number":1314,"context_line":"    \"\"\"Allow access to the share.\"\"\""},{"line_number":1315,"context_line":"    access_metadata \u003d None"},{"line_number":1316,"context_line":"    if cs.api_version.matches(api_versions.APIVersion(\"2.45\"),"},{"line_number":1317,"context_line":"                              api_versions.APIVersion()):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_67d78d52","line":1314,"range":{"start_line":1314,"start_character":23,"end_line":1314,"end_character":26},"in_reply_to":"5f7c97a3_19a16fa9","updated":"2018-07-12 14:38:44.000000000","message":"Done","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4f38bdb10fe61e185d0a641de2998165c51b7ed3","unresolved":false,"context_lines":[{"line_number":1318,"context_line":"        access_metadata \u003d _extract_metadata(args)"},{"line_number":1319,"context_line":"    elif getattr(args, \u0027metadata\u0027):"},{"line_number":1320,"context_line":"        raise exceptions.CommandError("},{"line_number":1321,"context_line":"            \"Access rule\u0027s metadata s only available with manila\""},{"line_number":1322,"context_line":"            \"API version \u003e\u003d 2.45\")"},{"line_number":1323,"context_line":""},{"line_number":1324,"context_line":"    share \u003d _find_share(cs, args.share)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_19bc0fda","line":1321,"range":{"start_line":1321,"start_character":13,"end_line":1321,"end_character":37},"updated":"2018-07-12 03:09:02.000000000","message":"Adding metadata to access rules is supported only beyond API version 2.45","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d859e73d6cf5a7a71f406d242efdba5601edaf0e","unresolved":false,"context_lines":[{"line_number":1318,"context_line":"        access_metadata \u003d _extract_metadata(args)"},{"line_number":1319,"context_line":"    elif getattr(args, \u0027metadata\u0027):"},{"line_number":1320,"context_line":"        raise exceptions.CommandError("},{"line_number":1321,"context_line":"            \"Access rule\u0027s metadata s only available with manila\""},{"line_number":1322,"context_line":"            \"API version \u003e\u003d 2.45\")"},{"line_number":1323,"context_line":""},{"line_number":1324,"context_line":"    share \u003d _find_share(cs, args.share)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_0737b9b1","line":1321,"range":{"start_line":1321,"start_character":13,"end_line":1321,"end_character":37},"in_reply_to":"5f7c97a3_19bc0fda","updated":"2018-07-12 14:38:44.000000000","message":"Done","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4f38bdb10fe61e185d0a641de2998165c51b7ed3","unresolved":false,"context_lines":[{"line_number":1327,"context_line":"    cliutils.print_dict(access)"},{"line_number":1328,"context_line":""},{"line_number":1329,"context_line":""},{"line_number":1330,"context_line":"@api_versions.wraps(\"2.45\")  # noqa"},{"line_number":1331,"context_line":"@cliutils.arg("},{"line_number":1332,"context_line":"    \u0027access_id\u0027,"},{"line_number":1333,"context_line":"    metavar\u003d\u0027\u003caccess_id\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_798f432f","line":1330,"range":{"start_line":1330,"start_character":29,"end_line":1330,"end_character":35},"updated":"2018-07-12 03:09:02.000000000","message":"why is this required?","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d859e73d6cf5a7a71f406d242efdba5601edaf0e","unresolved":false,"context_lines":[{"line_number":1327,"context_line":"    cliutils.print_dict(access)"},{"line_number":1328,"context_line":""},{"line_number":1329,"context_line":""},{"line_number":1330,"context_line":"@api_versions.wraps(\"2.45\")  # noqa"},{"line_number":1331,"context_line":"@cliutils.arg("},{"line_number":1332,"context_line":"    \u0027access_id\u0027,"},{"line_number":1333,"context_line":"    metavar\u003d\u0027\u003caccess_id\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_c740e109","line":1330,"range":{"start_line":1330,"start_character":29,"end_line":1330,"end_character":35},"in_reply_to":"5f7c97a3_798f432f","updated":"2018-07-12 14:38:44.000000000","message":"Done","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4f38bdb10fe61e185d0a641de2998165c51b7ed3","unresolved":false,"context_lines":[{"line_number":1331,"context_line":"@cliutils.arg("},{"line_number":1332,"context_line":"    \u0027access_id\u0027,"},{"line_number":1333,"context_line":"    metavar\u003d\u0027\u003caccess_id\u003e\u0027,"},{"line_number":1334,"context_line":"    help\u003d\u0027ID of the NAS share access.\u0027)"},{"line_number":1335,"context_line":"def do_access_show(cs, args):"},{"line_number":1336,"context_line":"    \"\"\"Show details about a NAS share access.\"\"\""},{"line_number":1337,"context_line":"    access \u003d cs.share_access_rules.get(args.access_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_f984b310","line":1334,"range":{"start_line":1334,"start_character":30,"end_line":1334,"end_character":36},"updated":"2018-07-12 03:09:02.000000000","message":"access rule","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d859e73d6cf5a7a71f406d242efdba5601edaf0e","unresolved":false,"context_lines":[{"line_number":1331,"context_line":"@cliutils.arg("},{"line_number":1332,"context_line":"    \u0027access_id\u0027,"},{"line_number":1333,"context_line":"    metavar\u003d\u0027\u003caccess_id\u003e\u0027,"},{"line_number":1334,"context_line":"    help\u003d\u0027ID of the NAS share access.\u0027)"},{"line_number":1335,"context_line":"def do_access_show(cs, args):"},{"line_number":1336,"context_line":"    \"\"\"Show details about a NAS share access.\"\"\""},{"line_number":1337,"context_line":"    access \u003d cs.share_access_rules.get(args.access_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_274f5536","line":1334,"range":{"start_line":1334,"start_character":30,"end_line":1334,"end_character":36},"in_reply_to":"5f7c97a3_f984b310","updated":"2018-07-12 14:38:44.000000000","message":"Done","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4f38bdb10fe61e185d0a641de2998165c51b7ed3","unresolved":false,"context_lines":[{"line_number":1333,"context_line":"    metavar\u003d\u0027\u003caccess_id\u003e\u0027,"},{"line_number":1334,"context_line":"    help\u003d\u0027ID of the NAS share access.\u0027)"},{"line_number":1335,"context_line":"def do_access_show(cs, args):"},{"line_number":1336,"context_line":"    \"\"\"Show details about a NAS share access.\"\"\""},{"line_number":1337,"context_line":"    access \u003d cs.share_access_rules.get(args.access_id)"},{"line_number":1338,"context_line":"    cliutils.print_dict(access)"},{"line_number":1339,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_b97e3b19","line":1336,"range":{"start_line":1336,"start_character":38,"end_line":1336,"end_character":44},"updated":"2018-07-12 03:09:02.000000000","message":"access rule","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d859e73d6cf5a7a71f406d242efdba5601edaf0e","unresolved":false,"context_lines":[{"line_number":1333,"context_line":"    metavar\u003d\u0027\u003caccess_id\u003e\u0027,"},{"line_number":1334,"context_line":"    help\u003d\u0027ID of the NAS share access.\u0027)"},{"line_number":1335,"context_line":"def do_access_show(cs, args):"},{"line_number":1336,"context_line":"    \"\"\"Show details about a NAS share access.\"\"\""},{"line_number":1337,"context_line":"    access \u003d cs.share_access_rules.get(args.access_id)"},{"line_number":1338,"context_line":"    cliutils.print_dict(access)"},{"line_number":1339,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_076019a4","line":1336,"range":{"start_line":1336,"start_character":38,"end_line":1336,"end_character":44},"in_reply_to":"5f7c97a3_b97e3b19","updated":"2018-07-12 14:38:44.000000000","message":"Done","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4f38bdb10fe61e185d0a641de2998165c51b7ed3","unresolved":false,"context_lines":[{"line_number":1342,"context_line":"@cliutils.arg("},{"line_number":1343,"context_line":"    \u0027access_id\u0027,"},{"line_number":1344,"context_line":"    metavar\u003d\u0027\u003caccess_id\u003e\u0027,"},{"line_number":1345,"context_line":"    help\u003d\u0027ID of the NAS share access.\u0027)"},{"line_number":1346,"context_line":"@cliutils.arg("},{"line_number":1347,"context_line":"    \u0027action\u0027,"},{"line_number":1348,"context_line":"    metavar\u003d\u0027\u003caction\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_7978a32b","line":1345,"range":{"start_line":1345,"start_character":30,"end_line":1345,"end_character":36},"updated":"2018-07-12 03:09:02.000000000","message":"access rule","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d859e73d6cf5a7a71f406d242efdba5601edaf0e","unresolved":false,"context_lines":[{"line_number":1342,"context_line":"@cliutils.arg("},{"line_number":1343,"context_line":"    \u0027access_id\u0027,"},{"line_number":1344,"context_line":"    metavar\u003d\u0027\u003caccess_id\u003e\u0027,"},{"line_number":1345,"context_line":"    help\u003d\u0027ID of the NAS share access.\u0027)"},{"line_number":1346,"context_line":"@cliutils.arg("},{"line_number":1347,"context_line":"    \u0027action\u0027,"},{"line_number":1348,"context_line":"    metavar\u003d\u0027\u003caction\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_876bc984","line":1345,"range":{"start_line":1345,"start_character":30,"end_line":1345,"end_character":36},"in_reply_to":"5f7c97a3_7978a32b","updated":"2018-07-12 14:38:44.000000000","message":"Done","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4f38bdb10fe61e185d0a641de2998165c51b7ed3","unresolved":false,"context_lines":[{"line_number":1353,"context_line":"    metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":1354,"context_line":"    nargs\u003d\u0027+\u0027,"},{"line_number":1355,"context_line":"    default\u003d[],"},{"line_number":1356,"context_line":"    help\u003d\u0027Metadata to set or unset (key is only necessary on unset).\u0027)"},{"line_number":1357,"context_line":"def do_access_metadata(cs, args):"},{"line_number":1358,"context_line":"    \"\"\"Set or delete metadata on a share access.\"\"\""},{"line_number":1359,"context_line":"    share_access \u003d cs.share_access_rules.get(args.access_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_b9939b4e","line":1356,"range":{"start_line":1356,"start_character":10,"end_line":1356,"end_character":18},"updated":"2018-07-12 03:09:02.000000000","message":"Comma separated key\u003dvalue pairs of metadata items","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4f38bdb10fe61e185d0a641de2998165c51b7ed3","unresolved":false,"context_lines":[{"line_number":1353,"context_line":"    metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":1354,"context_line":"    nargs\u003d\u0027+\u0027,"},{"line_number":1355,"context_line":"    default\u003d[],"},{"line_number":1356,"context_line":"    help\u003d\u0027Metadata to set or unset (key is only necessary on unset).\u0027)"},{"line_number":1357,"context_line":"def do_access_metadata(cs, args):"},{"line_number":1358,"context_line":"    \"\"\"Set or delete metadata on a share access.\"\"\""},{"line_number":1359,"context_line":"    share_access \u003d cs.share_access_rules.get(args.access_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_799d0357","line":1356,"range":{"start_line":1356,"start_character":36,"end_line":1356,"end_character":60},"updated":"2018-07-12 03:09:02.000000000","message":"only key is necessary to unset","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d859e73d6cf5a7a71f406d242efdba5601edaf0e","unresolved":false,"context_lines":[{"line_number":1353,"context_line":"    metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":1354,"context_line":"    nargs\u003d\u0027+\u0027,"},{"line_number":1355,"context_line":"    default\u003d[],"},{"line_number":1356,"context_line":"    help\u003d\u0027Metadata to set or unset (key is only necessary on unset).\u0027)"},{"line_number":1357,"context_line":"def do_access_metadata(cs, args):"},{"line_number":1358,"context_line":"    \"\"\"Set or delete metadata on a share access.\"\"\""},{"line_number":1359,"context_line":"    share_access \u003d cs.share_access_rules.get(args.access_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_070579c1","line":1356,"range":{"start_line":1356,"start_character":36,"end_line":1356,"end_character":60},"in_reply_to":"5f7c97a3_799d0357","updated":"2018-07-12 14:38:44.000000000","message":"Done","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d859e73d6cf5a7a71f406d242efdba5601edaf0e","unresolved":false,"context_lines":[{"line_number":1353,"context_line":"    metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":1354,"context_line":"    nargs\u003d\u0027+\u0027,"},{"line_number":1355,"context_line":"    default\u003d[],"},{"line_number":1356,"context_line":"    help\u003d\u0027Metadata to set or unset (key is only necessary on unset).\u0027)"},{"line_number":1357,"context_line":"def do_access_metadata(cs, args):"},{"line_number":1358,"context_line":"    \"\"\"Set or delete metadata on a share access.\"\"\""},{"line_number":1359,"context_line":"    share_access \u003d cs.share_access_rules.get(args.access_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_e7287d37","line":1356,"range":{"start_line":1356,"start_character":10,"end_line":1356,"end_character":18},"in_reply_to":"5f7c97a3_881c4315","updated":"2018-07-12 14:38:44.000000000","message":"Done","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d859e73d6cf5a7a71f406d242efdba5601edaf0e","unresolved":false,"context_lines":[{"line_number":1353,"context_line":"    metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":1354,"context_line":"    nargs\u003d\u0027+\u0027,"},{"line_number":1355,"context_line":"    default\u003d[],"},{"line_number":1356,"context_line":"    help\u003d\u0027Metadata to set or unset (key is only necessary on unset).\u0027)"},{"line_number":1357,"context_line":"def do_access_metadata(cs, args):"},{"line_number":1358,"context_line":"    \"\"\"Set or delete metadata on a share access.\"\"\""},{"line_number":1359,"context_line":"    share_access \u003d cs.share_access_rules.get(args.access_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_67f30dea","line":1356,"range":{"start_line":1356,"start_character":10,"end_line":1356,"end_character":18},"in_reply_to":"5f7c97a3_b9939b4e","updated":"2018-07-12 14:38:44.000000000","message":"Done","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bc6abf25cb45101ec065fd6631d79bced8e416d0","unresolved":false,"context_lines":[{"line_number":1353,"context_line":"    metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":1354,"context_line":"    nargs\u003d\u0027+\u0027,"},{"line_number":1355,"context_line":"    default\u003d[],"},{"line_number":1356,"context_line":"    help\u003d\u0027Metadata to set or unset (key is only necessary on unset).\u0027)"},{"line_number":1357,"context_line":"def do_access_metadata(cs, args):"},{"line_number":1358,"context_line":"    \"\"\"Set or delete metadata on a share access.\"\"\""},{"line_number":1359,"context_line":"    share_access \u003d cs.share_access_rules.get(args.access_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_881c4315","line":1356,"range":{"start_line":1356,"start_character":10,"end_line":1356,"end_character":18},"in_reply_to":"5f7c97a3_b9939b4e","updated":"2018-07-12 05:55:18.000000000","message":"Space Separated","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4f38bdb10fe61e185d0a641de2998165c51b7ed3","unresolved":false,"context_lines":[{"line_number":1355,"context_line":"    default\u003d[],"},{"line_number":1356,"context_line":"    help\u003d\u0027Metadata to set or unset (key is only necessary on unset).\u0027)"},{"line_number":1357,"context_line":"def do_access_metadata(cs, args):"},{"line_number":1358,"context_line":"    \"\"\"Set or delete metadata on a share access.\"\"\""},{"line_number":1359,"context_line":"    share_access \u003d cs.share_access_rules.get(args.access_id)"},{"line_number":1360,"context_line":"    metadata \u003d _extract_metadata(args)"},{"line_number":1361,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_596fe75f","line":1358,"range":{"start_line":1358,"start_character":41,"end_line":1358,"end_character":47},"updated":"2018-07-12 03:09:02.000000000","message":"access rule","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d859e73d6cf5a7a71f406d242efdba5601edaf0e","unresolved":false,"context_lines":[{"line_number":1355,"context_line":"    default\u003d[],"},{"line_number":1356,"context_line":"    help\u003d\u0027Metadata to set or unset (key is only necessary on unset).\u0027)"},{"line_number":1357,"context_line":"def do_access_metadata(cs, args):"},{"line_number":1358,"context_line":"    \"\"\"Set or delete metadata on a share access.\"\"\""},{"line_number":1359,"context_line":"    share_access \u003d cs.share_access_rules.get(args.access_id)"},{"line_number":1360,"context_line":"    metadata \u003d _extract_metadata(args)"},{"line_number":1361,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_072ed941","line":1358,"range":{"start_line":1358,"start_character":41,"end_line":1358,"end_character":47},"in_reply_to":"5f7c97a3_596fe75f","updated":"2018-07-12 14:38:44.000000000","message":"Done","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4f38bdb10fe61e185d0a641de2998165c51b7ed3","unresolved":false,"context_lines":[{"line_number":1511,"context_line":""},{"line_number":1512,"context_line":"    if args.columns is not None:"},{"line_number":1513,"context_line":"        list_of_keys \u003d _split_columns(columns\u003dargs.columns)"},{"line_number":1514,"context_line":""},{"line_number":1515,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":1516,"context_line":"    if cs.api_version \u003c api_versions.APIVersion(\"2.45\"):"},{"line_number":1517,"context_line":"        access_list \u003d share.access_list()"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_79c6634d","line":1514,"range":{"start_line":1514,"start_character":0,"end_line":1514,"end_character":0},"updated":"2018-07-12 03:09:02.000000000","message":"command error on using metadata to filter if API version is less than 2.45?","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d859e73d6cf5a7a71f406d242efdba5601edaf0e","unresolved":false,"context_lines":[{"line_number":1511,"context_line":""},{"line_number":1512,"context_line":"    if args.columns is not None:"},{"line_number":1513,"context_line":"        list_of_keys \u003d _split_columns(columns\u003dargs.columns)"},{"line_number":1514,"context_line":""},{"line_number":1515,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":1516,"context_line":"    if cs.api_version \u003c api_versions.APIVersion(\"2.45\"):"},{"line_number":1517,"context_line":"        access_list \u003d share.access_list()"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_87198924","line":1514,"range":{"start_line":1514,"start_character":0,"end_line":1514,"end_character":0},"in_reply_to":"5f7c97a3_79c6634d","updated":"2018-07-12 14:38:44.000000000","message":"Done","commit_id":"931f240c5127198968659e7d804cd74bb383d7eb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4bf590f2d67caf72d60600d7551e30f0cbced220","unresolved":false,"context_lines":[{"line_number":1339,"context_line":"    cliutils.print_dict(view_data)"},{"line_number":1340,"context_line":""},{"line_number":1341,"context_line":""},{"line_number":1342,"context_line":"@api_versions.wraps(\"2.45\")  # noqa"},{"line_number":1343,"context_line":"@cliutils.arg("},{"line_number":1344,"context_line":"    \u0027access_id\u0027,"},{"line_number":1345,"context_line":"    metavar\u003d\u0027\u003caccess_id\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_3844aa47","line":1342,"range":{"start_line":1342,"start_character":29,"end_line":1342,"end_character":35},"updated":"2018-07-19 22:18:08.000000000","message":"not required if its not a redefinition of the method","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7c61e07d2987ab8a057ba8475ce66ecabad663f0","unresolved":false,"context_lines":[{"line_number":1339,"context_line":"    cliutils.print_dict(view_data)"},{"line_number":1340,"context_line":""},{"line_number":1341,"context_line":""},{"line_number":1342,"context_line":"@api_versions.wraps(\"2.45\")  # noqa"},{"line_number":1343,"context_line":"@cliutils.arg("},{"line_number":1344,"context_line":"    \u0027access_id\u0027,"},{"line_number":1345,"context_line":"    metavar\u003d\u0027\u003caccess_id\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_f7e95ce3","line":1342,"range":{"start_line":1342,"start_character":29,"end_line":1342,"end_character":35},"in_reply_to":"5f7c97a3_3844aa47","updated":"2018-07-20 09:15:32.000000000","message":"Done","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a9a58a63aec6103c3a1c292e5d9b6a4ba90d1733","unresolved":false,"context_lines":[{"line_number":1354,"context_line":"    metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":1355,"context_line":"    nargs\u003d\u0027+\u0027,"},{"line_number":1356,"context_line":"    default\u003d[],"},{"line_number":1357,"context_line":"    help\u003d\u0027Comma separated key\u003dvalue pairs of metadata items to set or unset \u0027"},{"line_number":1358,"context_line":"         \u0027(only key is necessary to unset).\u0027)"},{"line_number":1359,"context_line":"def do_access_metadata(cs, args):"},{"line_number":1360,"context_line":"    \"\"\"Set or delete metadata on a share access rule.\"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_d8e336d6","line":1357,"range":{"start_line":1357,"start_character":10,"end_line":1357,"end_character":25},"updated":"2018-07-19 22:41:15.000000000","message":"Space separated","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7c61e07d2987ab8a057ba8475ce66ecabad663f0","unresolved":false,"context_lines":[{"line_number":1354,"context_line":"    metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":1355,"context_line":"    nargs\u003d\u0027+\u0027,"},{"line_number":1356,"context_line":"    default\u003d[],"},{"line_number":1357,"context_line":"    help\u003d\u0027Comma separated key\u003dvalue pairs of metadata items to set or unset \u0027"},{"line_number":1358,"context_line":"         \u0027(only key is necessary to unset).\u0027)"},{"line_number":1359,"context_line":"def do_access_metadata(cs, args):"},{"line_number":1360,"context_line":"    \"\"\"Set or delete metadata on a share access rule.\"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_b7b9a4ec","line":1357,"range":{"start_line":1357,"start_character":10,"end_line":1357,"end_character":25},"in_reply_to":"5f7c97a3_d8e336d6","updated":"2018-07-20 09:15:32.000000000","message":"Done","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a9a58a63aec6103c3a1c292e5d9b6a4ba90d1733","unresolved":false,"context_lines":[{"line_number":1354,"context_line":"    metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":1355,"context_line":"    nargs\u003d\u0027+\u0027,"},{"line_number":1356,"context_line":"    default\u003d[],"},{"line_number":1357,"context_line":"    help\u003d\u0027Comma separated key\u003dvalue pairs of metadata items to set or unset \u0027"},{"line_number":1358,"context_line":"         \u0027(only key is necessary to unset).\u0027)"},{"line_number":1359,"context_line":"def do_access_metadata(cs, args):"},{"line_number":1360,"context_line":"    \"\"\"Set or delete metadata on a share access rule.\"\"\""},{"line_number":1361,"context_line":"    share_access \u003d cs.share_access_rules.get(args.access_id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_f8039274","line":1358,"range":{"start_line":1357,"start_character":66,"end_line":1358,"end_character":42},"updated":"2018-07-19 22:41:15.000000000","message":". To unset only keys are required.","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7c61e07d2987ab8a057ba8475ce66ecabad663f0","unresolved":false,"context_lines":[{"line_number":1354,"context_line":"    metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":1355,"context_line":"    nargs\u003d\u0027+\u0027,"},{"line_number":1356,"context_line":"    default\u003d[],"},{"line_number":1357,"context_line":"    help\u003d\u0027Comma separated key\u003dvalue pairs of metadata items to set or unset \u0027"},{"line_number":1358,"context_line":"         \u0027(only key is necessary to unset).\u0027)"},{"line_number":1359,"context_line":"def do_access_metadata(cs, args):"},{"line_number":1360,"context_line":"    \"\"\"Set or delete metadata on a share access rule.\"\"\""},{"line_number":1361,"context_line":"    share_access \u003d cs.share_access_rules.get(args.access_id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_97b26804","line":1358,"range":{"start_line":1357,"start_character":66,"end_line":1358,"end_character":42},"in_reply_to":"5f7c97a3_f8039274","updated":"2018-07-20 09:15:32.000000000","message":"Done","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4bf590f2d67caf72d60600d7551e30f0cbced220","unresolved":false,"context_lines":[{"line_number":1515,"context_line":"    if cs.api_version \u003c api_versions.APIVersion(\"2.45\"):"},{"line_number":1516,"context_line":"        if getattr(args, \u0027metadata\u0027):"},{"line_number":1517,"context_line":"            raise exceptions.CommandError("},{"line_number":1518,"context_line":"                \"Adding metadata to access rules is supported only beyond \""},{"line_number":1519,"context_line":"                \"API version 2.45\")"},{"line_number":1520,"context_line":"        access_list \u003d share.access_list()"},{"line_number":1521,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_b8775a8e","line":1518,"range":{"start_line":1518,"start_character":17,"end_line":1518,"end_character":48},"updated":"2018-07-19 22:18:08.000000000","message":"Filtering access rules by metadata","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7c61e07d2987ab8a057ba8475ce66ecabad663f0","unresolved":false,"context_lines":[{"line_number":1515,"context_line":"    if cs.api_version \u003c api_versions.APIVersion(\"2.45\"):"},{"line_number":1516,"context_line":"        if getattr(args, \u0027metadata\u0027):"},{"line_number":1517,"context_line":"            raise exceptions.CommandError("},{"line_number":1518,"context_line":"                \"Adding metadata to access rules is supported only beyond \""},{"line_number":1519,"context_line":"                \"API version 2.45\")"},{"line_number":1520,"context_line":"        access_list \u003d share.access_list()"},{"line_number":1521,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_8550ee0a","line":1518,"range":{"start_line":1518,"start_character":17,"end_line":1518,"end_character":48},"in_reply_to":"5f7c97a3_b8775a8e","updated":"2018-07-20 09:15:32.000000000","message":"Done","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4bf590f2d67caf72d60600d7551e30f0cbced220","unresolved":false,"context_lines":[{"line_number":1521,"context_line":"    else:"},{"line_number":1522,"context_line":"        access_list \u003d cs.share_access_rules.access_list("},{"line_number":1523,"context_line":"            share, {\u0027metadata\u0027: _extract_metadata(args)})"},{"line_number":1524,"context_line":"        list_of_keys.append(\u0027metadata\u0027)"},{"line_number":1525,"context_line":"    if args.columns is not None:"},{"line_number":1526,"context_line":"        list_of_keys \u003d _split_columns(columns\u003dargs.columns)"},{"line_number":1527,"context_line":"    cliutils.print_list(access_list, list_of_keys)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_f8e6324a","line":1524,"range":{"start_line":1524,"start_character":8,"end_line":1524,"end_character":39},"updated":"2018-07-19 22:18:08.000000000","message":"We don\u0027t need metadata in the list unless it has been requested in \"columns\" -  this can exceed screen dimensions if long... so remove.","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7c61e07d2987ab8a057ba8475ce66ecabad663f0","unresolved":false,"context_lines":[{"line_number":1521,"context_line":"    else:"},{"line_number":1522,"context_line":"        access_list \u003d cs.share_access_rules.access_list("},{"line_number":1523,"context_line":"            share, {\u0027metadata\u0027: _extract_metadata(args)})"},{"line_number":1524,"context_line":"        list_of_keys.append(\u0027metadata\u0027)"},{"line_number":1525,"context_line":"    if args.columns is not None:"},{"line_number":1526,"context_line":"        list_of_keys \u003d _split_columns(columns\u003dargs.columns)"},{"line_number":1527,"context_line":"    cliutils.print_list(access_list, list_of_keys)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_453e56b9","line":1524,"range":{"start_line":1524,"start_character":8,"end_line":1524,"end_character":39},"in_reply_to":"5f7c97a3_f8e6324a","updated":"2018-07-20 09:15:32.000000000","message":"Done","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"}],"releasenotes/notes/add-metadata-for-share-access-rule-11a6b36c0f4c87c2.yaml":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"7cf98f23de243934d5803da18158c7b87cbcdc43","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Metadata can be added to share access rules as key value pairs."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5f7c97a3_f96bb818","line":3,"range":{"start_line":3,"start_character":51,"end_line":3,"end_character":60},"updated":"2018-07-18 21:35:37.000000000","message":"key\u003dvalue (to be consistent with the manila release note).","commit_id":"79995d92420028ab60002a110599d02ece93f554"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4bf590f2d67caf72d60600d7551e30f0cbced220","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Metadata can be added to share access rules as key\u003dvalue pairs, and also"},{"line_number":4,"context_line":"    introduced the GET /share-access-rules API with API version 2.45."},{"line_number":5,"context_line":"    The prior API to retrieve access rules of a given share,"},{"line_number":6,"context_line":"    POST /shares/{share-id}/action {\u0027access-list: null} has been"},{"line_number":7,"context_line":"    removed in API version 2.45."},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - The API GET /share-access-rules?share_id\u003d{share-id} replaces"},{"line_number":10,"context_line":"    POST /shares/{share-id}/action with body {\u0027access_list\u0027: null} in"},{"line_number":11,"context_line":"    API version 2.45. The new API supports access rule metadata and is expected"},{"line_number":12,"context_line":"    to support sorting, filtering and pagination features along with newer"},{"line_number":13,"context_line":"    fields to interact with access rules in future versions. The API request"},{"line_number":14,"context_line":"    header \u0027X-OpenStack-Manila-API-Version\u0027 can be set to 2.44 to"},{"line_number":15,"context_line":"    continue using the prior API to retrieve access rules, but no new features"},{"line_number":16,"context_line":"    will be added to that API."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5f7c97a3_5a107ef4","line":16,"range":{"start_line":3,"start_character":4,"end_line":16,"end_character":30},"updated":"2018-07-19 22:18:08.000000000","message":"Added support to create share access rule metadata, update existing share access rule metadata and delete share access rule metadata. Also added a new shell command to show details of a share access rule.","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7c61e07d2987ab8a057ba8475ce66ecabad663f0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Metadata can be added to share access rules as key\u003dvalue pairs, and also"},{"line_number":4,"context_line":"    introduced the GET /share-access-rules API with API version 2.45."},{"line_number":5,"context_line":"    The prior API to retrieve access rules of a given share,"},{"line_number":6,"context_line":"    POST /shares/{share-id}/action {\u0027access-list: null} has been"},{"line_number":7,"context_line":"    removed in API version 2.45."},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - The API GET /share-access-rules?share_id\u003d{share-id} replaces"},{"line_number":10,"context_line":"    POST /shares/{share-id}/action with body {\u0027access_list\u0027: null} in"},{"line_number":11,"context_line":"    API version 2.45. The new API supports access rule metadata and is expected"},{"line_number":12,"context_line":"    to support sorting, filtering and pagination features along with newer"},{"line_number":13,"context_line":"    fields to interact with access rules in future versions. The API request"},{"line_number":14,"context_line":"    header \u0027X-OpenStack-Manila-API-Version\u0027 can be set to 2.44 to"},{"line_number":15,"context_line":"    continue using the prior API to retrieve access rules, but no new features"},{"line_number":16,"context_line":"    will be added to that API."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5f7c97a3_0544de46","line":16,"range":{"start_line":3,"start_character":4,"end_line":16,"end_character":30},"in_reply_to":"5f7c97a3_5a107ef4","updated":"2018-07-20 09:15:32.000000000","message":"Done","commit_id":"565d571ddcdda1bc9dd6d8f63cf485e6a3f0e358"}]}