)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"5dcd54e013e5c15c78fbf2c8bbe21bd12f276b25","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     sriram ramakrishnan \u003csramakr@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-12-27 15:55:48 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix for bug 1802059"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Return the correct is_default value instead of a function object"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f769fc5_7b7397b2","line":7,"updated":"2019-01-02 09:07:35.000000000","message":"The first line should be a short explanation. Something like \"Return the correct is_default value instead of a function\"","commit_id":"037e6ee72024e85965d04dbbfc0af13a702439ad"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"5dcd54e013e5c15c78fbf2c8bbe21bd12f276b25","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Return the correct is_default value instead of a function object"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Related-Bug: 1802059"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4df0afdb9188043150fc505d55fd26a1bcb4654e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f769fc5_3b651fe2","line":11,"updated":"2019-01-02 09:07:35.000000000","message":"This should be:\n\nCloses-Bug: #1802059","commit_id":"037e6ee72024e85965d04dbbfc0af13a702439ad"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1f80eefc864bed6393968b81d8542fb38c2fa473","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Return the correct is_default value instead of a function object"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Related-Bug: 1802059"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4df0afdb9188043150fc505d55fd26a1bcb4654e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dfd5e7cf_b72dd547","line":11,"in_reply_to":"1f769fc5_3b651fe2","updated":"2019-01-07 20:55:49.000000000","message":"+1\n\nSriram: here\u0027s a good reference to learn how to structure your commit messages https://wiki.openstack.org/wiki/GitCommitMessages\n\nAlso, please add a release note for this bug fix, instructions from the main project (manila) are here: \n\nhttps://docs.openstack.org/manila/latest/contributor/adding_release_notes.html\n\nInstall reno from pip and you\u0027ll need to be in the top directory (python-manilaclient) and execute \u0027reno\u0027 to create your release note. Make sure to reference the bug ID in the name that your choose for your file. \n\nSee examples here: https://github.com/openstack/python-manilaclient/tree/master/releasenotes/notes","commit_id":"037e6ee72024e85965d04dbbfc0af13a702439ad"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6fc1368e7ec98433ce08b43356b3b981c0052977","unresolved":false,"context_lines":[{"line_number":4106,"context_line":"def _print_share_group_type(share_group_type, default_share_type\u003dNone):"},{"line_number":4107,"context_line":""},{"line_number":4108,"context_line":"    def _is_default(share_group_type):"},{"line_number":4109,"context_line":"        if hasattr(share_group_type, \u0027is_default\u0027):"},{"line_number":4110,"context_line":"            return \u0027YES\u0027 if share_group_type.is_default else \u0027-\u0027"},{"line_number":4111,"context_line":"        return \u0027-\u0027"},{"line_number":4112,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dfd5e7cf_d73bb999","line":4109,"range":{"start_line":4109,"start_character":0,"end_line":4109,"end_character":51},"updated":"2019-01-07 20:52:00.000000000","message":"This hasattr will try to refresh the share_group_type, \n\nso the failure here (http://logs.openstack.org/68/627568/2/check/openstack-tox-lower-constraints/6307fa8/job-output.txt.gz#_2018-12-27_21_04_25_598566) is legitimate\n\nI would suggest changing the assert in the test here: https://github.com/openstack/python-manilaclient/blob/80ec291/manilaclient/tests/unit/v2/test_shell.py#L2531\n\nto ``assert_called_anytime``","commit_id":"037e6ee72024e85965d04dbbfc0af13a702439ad"}]}