)]}'
{"manilaclient/common/constants.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2088091542d1024307ad7f36dd06ce6c6eaccc89","unresolved":false,"context_lines":[{"line_number":91,"context_line":"STATUS_ERROR \u003d \u0027error\u0027"},{"line_number":92,"context_line":"STATUS_ACTIVE \u003d \u0027active\u0027"},{"line_number":93,"context_line":"STATUS_MANAGE_ERROR \u003d \u0027manage_error\u0027"},{"line_number":94,"context_line":"STATUS_INACTIVE \u003d \u0027inactive\u0027"},{"line_number":95,"context_line":"STATUS_DELETING \u003d \u0027deleting\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_e53f541f","line":94,"range":{"start_line":94,"start_character":0,"end_line":94,"end_character":28},"updated":"2019-03-01 08:10:31.000000000","message":"remove","commit_id":"b79dda78e52d04b4be0b0574c29b49e8b5ab074d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"dc6a42afea9626d216dd8d70a26b4bea75aeee65","unresolved":false,"context_lines":[{"line_number":91,"context_line":"STATUS_ERROR \u003d \u0027error\u0027"},{"line_number":92,"context_line":"STATUS_ACTIVE \u003d \u0027active\u0027"},{"line_number":93,"context_line":"STATUS_MANAGE_ERROR \u003d \u0027manage_error\u0027"},{"line_number":94,"context_line":"STATUS_INACTIVE \u003d \u0027inactive\u0027"},{"line_number":95,"context_line":"STATUS_DELETING \u003d \u0027deleting\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_387d726c","line":94,"range":{"start_line":94,"start_character":0,"end_line":94,"end_character":28},"in_reply_to":"9fdfeff1_e53f541f","updated":"2019-03-01 18:38:57.000000000","message":"Done","commit_id":"b79dda78e52d04b4be0b0574c29b49e8b5ab074d"}],"manilaclient/config.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"34c7ea1b24ca0db5af44900c6d6330a637fdd79f","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    cfg.BoolOpt(\"run_manage_tests\","},{"line_number":182,"context_line":"                default\u003dFalse,"},{"line_number":183,"context_line":"                help\u003d\"Defines whether to run manage/unmanage tests or \""},{"line_number":184,"context_line":"                     \"not. Disable this feature if used driver does not \""},{"line_number":185,"context_line":"                     \"support it.\"),"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_64f6d992","line":184,"range":{"start_line":184,"start_character":48,"end_line":184,"end_character":62},"updated":"2019-03-06 15:04:07.000000000","message":"nit: this isn\u0027t really idiomatic English.  I\u0027d just say \"Disable this feature if the driver does not support it.\"  It\u0027s clear that \"the driver\" is one you are using, not some other driver defined in the codebase.","commit_id":"a18725346f078bd7a93463605ef5b24e5102485d"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"15ae78e910923bb0f30e2928f3e31be79fb71c5d","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    cfg.BoolOpt(\"run_manage_tests\","},{"line_number":182,"context_line":"                default\u003dFalse,"},{"line_number":183,"context_line":"                help\u003d\"Defines whether to run manage/unmanage tests or \""},{"line_number":184,"context_line":"                     \"not. Disable this feature if used driver does not \""},{"line_number":185,"context_line":"                     \"support it.\"),"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_5dae102f","line":184,"range":{"start_line":184,"start_character":48,"end_line":184,"end_character":62},"in_reply_to":"5fc1f717_64f6d992","updated":"2019-03-06 16:35:59.000000000","message":"Oh I see that you are matching Valeriy\u0027s style in the previous r help messages.  I can live with the consistency.","commit_id":"a18725346f078bd7a93463605ef5b24e5102485d"}],"manilaclient/tests/functional/test_share_servers.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"66a07e79cf57898e0365fc3955caa8dc026a4918","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        expected_keys \u003d ("},{"line_number":131,"context_line":"            \u0027id\u0027, \u0027host\u0027, \u0027status\u0027, \u0027created_at\u0027, \u0027updated_at\u0027,"},{"line_number":132,"context_line":"            \u0027share_network_id\u0027, \u0027share_network_name\u0027, \u0027project_id\u0027,"},{"line_number":133,"context_line":"        )"},{"line_number":134,"context_line":"        for key in expected_keys:"},{"line_number":135,"context_line":"            self.assertIn(key, server)"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_764c6176","line":133,"range":{"start_line":133,"start_character":0,"end_line":133,"end_character":9},"updated":"2019-03-06 00:23:33.000000000","message":"Test presence of new keys with micro version","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f0f001c71dedd392790aae490ecb05cf3e483a20","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        expected_keys \u003d ("},{"line_number":131,"context_line":"            \u0027id\u0027, \u0027host\u0027, \u0027status\u0027, \u0027created_at\u0027, \u0027updated_at\u0027,"},{"line_number":132,"context_line":"            \u0027share_network_id\u0027, \u0027share_network_name\u0027, \u0027project_id\u0027,"},{"line_number":133,"context_line":"        )"},{"line_number":134,"context_line":"        for key in expected_keys:"},{"line_number":135,"context_line":"            self.assertIn(key, server)"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_c450f235","line":133,"range":{"start_line":133,"start_character":0,"end_line":133,"end_character":9},"in_reply_to":"5fc1f717_764c6176","updated":"2019-03-06 14:03:59.000000000","message":"Done","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"66a07e79cf57898e0365fc3955caa8dc026a4918","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        self._delete_share_and_share_server(self.share[\u0027id\u0027], share_server_id)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def test_manage_and_unmanage_share_server(self):"},{"line_number":140,"context_line":"        share, share_network \u003d self._create_share_and_share_network()"},{"line_number":141,"context_line":"        share_server_id \u003d self.client.get_share("},{"line_number":142,"context_line":"            self.share[\u0027id\u0027])[\u0027share_server_id\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_36cb39a6","line":139,"range":{"start_line":139,"start_character":0,"end_line":139,"end_character":52},"updated":"2019-03-06 00:23:33.000000000","message":"We need to skip these tests based on a flag.","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f0f001c71dedd392790aae490ecb05cf3e483a20","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        self._delete_share_and_share_server(self.share[\u0027id\u0027], share_server_id)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def test_manage_and_unmanage_share_server(self):"},{"line_number":140,"context_line":"        share, share_network \u003d self._create_share_and_share_network()"},{"line_number":141,"context_line":"        share_server_id \u003d self.client.get_share("},{"line_number":142,"context_line":"            self.share[\u0027id\u0027])[\u0027share_server_id\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_af9fbfb2","line":139,"range":{"start_line":139,"start_character":0,"end_line":139,"end_character":52},"in_reply_to":"5fc1f717_36cb39a6","updated":"2019-03-06 14:03:59.000000000","message":"Done","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"66a07e79cf57898e0365fc3955caa8dc026a4918","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        export_location \u003d self.client.list_share_export_locations("},{"line_number":146,"context_line":"            self.share[\u0027id\u0027])[0][\u0027Path\u0027]"},{"line_number":147,"context_line":"        share_host \u003d share[\u0027host\u0027]"},{"line_number":148,"context_line":"        identifier \u003d server[\u0027id\u0027]"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        self.assertEqual(server[\u0027is_auto_deletable\u0027], \u0027True\u0027)"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_d65f550c","line":148,"range":{"start_line":148,"start_character":20,"end_line":148,"end_character":33},"updated":"2019-03-06 00:23:33.000000000","message":"server[\u0027identifier\u0027]?","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f0f001c71dedd392790aae490ecb05cf3e483a20","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        export_location \u003d self.client.list_share_export_locations("},{"line_number":146,"context_line":"            self.share[\u0027id\u0027])[0][\u0027Path\u0027]"},{"line_number":147,"context_line":"        share_host \u003d share[\u0027host\u0027]"},{"line_number":148,"context_line":"        identifier \u003d server[\u0027id\u0027]"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        self.assertEqual(server[\u0027is_auto_deletable\u0027], \u0027True\u0027)"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_e4588e57","line":148,"range":{"start_line":148,"start_character":20,"end_line":148,"end_character":33},"in_reply_to":"5fc1f717_d65f550c","updated":"2019-03-06 14:03:59.000000000","message":"Done","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"66a07e79cf57898e0365fc3955caa8dc026a4918","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        share_host \u003d share[\u0027host\u0027]"},{"line_number":148,"context_line":"        identifier \u003d server[\u0027id\u0027]"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        self.assertEqual(server[\u0027is_auto_deletable\u0027], \u0027True\u0027)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        # Unmanages share"},{"line_number":153,"context_line":"        self.client.unmanage_share(share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_76754198","line":150,"range":{"start_line":150,"start_character":8,"end_line":150,"end_character":61},"updated":"2019-03-06 00:23:33.000000000","message":"prefer the use of assertIs over assertEqual for booleans\n\nalso, the order of parameters is self.assertXYZ(expected, actual)","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f0f001c71dedd392790aae490ecb05cf3e483a20","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        share_host \u003d share[\u0027host\u0027]"},{"line_number":148,"context_line":"        identifier \u003d server[\u0027id\u0027]"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        self.assertEqual(server[\u0027is_auto_deletable\u0027], \u0027True\u0027)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        # Unmanages share"},{"line_number":153,"context_line":"        self.client.unmanage_share(share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_242456c6","line":150,"range":{"start_line":150,"start_character":8,"end_line":150,"end_character":61},"in_reply_to":"5fc1f717_76754198","updated":"2019-03-06 14:03:59.000000000","message":"That is a string","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"66a07e79cf57898e0365fc3955caa8dc026a4918","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        self.client.wait_for_share_deletion(share[\u0027id\u0027])"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        server \u003d self.client.get_share_server(share_server_id)"},{"line_number":157,"context_line":"        self.assertEqual(server[\u0027is_auto_deletable\u0027], \u0027False\u0027)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        # Unmanages share server"},{"line_number":160,"context_line":"        self.client.unmanage_server(share_server_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_5674c599","line":157,"range":{"start_line":157,"start_character":0,"end_line":157,"end_character":62},"updated":"2019-03-06 00:23:33.000000000","message":"same","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f0f001c71dedd392790aae490ecb05cf3e483a20","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        self.client.wait_for_share_deletion(share[\u0027id\u0027])"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        server \u003d self.client.get_share_server(share_server_id)"},{"line_number":157,"context_line":"        self.assertEqual(server[\u0027is_auto_deletable\u0027], \u0027False\u0027)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        # Unmanages share server"},{"line_number":160,"context_line":"        self.client.unmanage_server(share_server_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_442162b4","line":157,"range":{"start_line":157,"start_character":0,"end_line":157,"end_character":62},"in_reply_to":"5fc1f717_5674c599","updated":"2019-03-06 14:03:59.000000000","message":"same as above","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"66a07e79cf57898e0365fc3955caa8dc026a4918","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            resource_type\u003d\u0027share_server\u0027)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        managed_server \u003d self.client.get_share_server(managed_share_server_id)"},{"line_number":171,"context_line":"        self.assertEqual(managed_server[\u0027is_auto_deletable\u0027], \u0027False\u0027)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        # Manage share"},{"line_number":174,"context_line":"        managed_share_id \u003d self.client.manage_share("}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_96ed4d27","line":171,"range":{"start_line":171,"start_character":0,"end_line":171,"end_character":70},"updated":"2019-03-06 00:23:33.000000000","message":"same","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f0f001c71dedd392790aae490ecb05cf3e483a20","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            resource_type\u003d\u0027share_server\u0027)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        managed_server \u003d self.client.get_share_server(managed_share_server_id)"},{"line_number":171,"context_line":"        self.assertEqual(managed_server[\u0027is_auto_deletable\u0027], \u0027False\u0027)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        # Manage share"},{"line_number":174,"context_line":"        managed_share_id \u003d self.client.manage_share("}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_042b5a94","line":171,"range":{"start_line":171,"start_character":0,"end_line":171,"end_character":70},"in_reply_to":"5fc1f717_96ed4d27","updated":"2019-03-06 14:03:59.000000000","message":"same as above","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"}],"manilaclient/tests/unit/v2/fakes.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"66a07e79cf57898e0365fc3955caa8dc026a4918","unresolved":false,"context_lines":[{"line_number":447,"context_line":"        assert len(list(body)) \u003d\u003d 1"},{"line_number":448,"context_line":"        action \u003d list(body)[0]"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"        if action in (\u0027os-reset_status\u0027, \u0027reset_status\u0027):"},{"line_number":451,"context_line":"            assert \u0027status\u0027 in body.get("},{"line_number":452,"context_line":"                \u0027reset_status\u0027, body.get(\u0027os-reset_status\u0027))"},{"line_number":453,"context_line":"            _body \u003d {"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_b66c099d","line":450,"range":{"start_line":450,"start_character":22,"end_line":450,"end_character":39},"updated":"2019-03-06 00:23:33.000000000","message":"copy-paste error?","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f0f001c71dedd392790aae490ecb05cf3e483a20","unresolved":false,"context_lines":[{"line_number":447,"context_line":"        assert len(list(body)) \u003d\u003d 1"},{"line_number":448,"context_line":"        action \u003d list(body)[0]"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"        if action in (\u0027os-reset_status\u0027, \u0027reset_status\u0027):"},{"line_number":451,"context_line":"            assert \u0027status\u0027 in body.get("},{"line_number":452,"context_line":"                \u0027reset_status\u0027, body.get(\u0027os-reset_status\u0027))"},{"line_number":453,"context_line":"            _body \u003d {"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_e47f2ea9","line":450,"range":{"start_line":450,"start_character":22,"end_line":450,"end_character":39},"in_reply_to":"5fc1f717_b66c099d","updated":"2019-03-06 14:03:59.000000000","message":"Done","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"}],"manilaclient/tests/unit/v2/test_shares.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"858a6034bd4e8135b87ebf17bc48b0b1f2e5471e","unresolved":false,"context_lines":[{"line_number":195,"context_line":"                               mock.Mock(return_value\u003d\"fake\")):"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"            if (version \u003e\u003d api_versions.APIVersion(\u00272.8\u0027)"},{"line_number":198,"context_line":"                    and version !\u003d api_versions.APIVersion(\u00272.49\u0027)):"},{"line_number":199,"context_line":"                result \u003d manager.manage("},{"line_number":200,"context_line":"                    service_host, protocol, export_path, driver_options,"},{"line_number":201,"context_line":"                    share_type, name, description, is_public)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_5f74a036","line":198,"range":{"start_line":198,"start_character":31,"end_line":198,"end_character":35},"updated":"2019-03-05 17:06:19.000000000","message":"\u003c","commit_id":"d97c18dbf2a2ab6aba510aac0d75dd0c26e29568"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"7d8ab71a485f0a41309a471dc25bb1852cd7e6c4","unresolved":false,"context_lines":[{"line_number":195,"context_line":"                               mock.Mock(return_value\u003d\"fake\")):"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"            if (version \u003e\u003d api_versions.APIVersion(\u00272.8\u0027)"},{"line_number":198,"context_line":"                    and version !\u003d api_versions.APIVersion(\u00272.49\u0027)):"},{"line_number":199,"context_line":"                result \u003d manager.manage("},{"line_number":200,"context_line":"                    service_host, protocol, export_path, driver_options,"},{"line_number":201,"context_line":"                    share_type, name, description, is_public)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5fc1f717_4dd2f936","line":198,"range":{"start_line":198,"start_character":31,"end_line":198,"end_character":35},"in_reply_to":"9fdfeff1_5f74a036","updated":"2019-03-05 17:33:42.000000000","message":"Done","commit_id":"d97c18dbf2a2ab6aba510aac0d75dd0c26e29568"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"858a6034bd4e8135b87ebf17bc48b0b1f2e5471e","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                result \u003d manager.manage("},{"line_number":200,"context_line":"                    service_host, protocol, export_path, driver_options,"},{"line_number":201,"context_line":"                    share_type, name, description, is_public)"},{"line_number":202,"context_line":"            elif version \u003d\u003d api_versions.APIVersion(\u00272.49\u0027):"},{"line_number":203,"context_line":"                result \u003d manager.manage("},{"line_number":204,"context_line":"                    service_host, protocol, export_path, driver_options,"},{"line_number":205,"context_line":"                    share_type, name, description, is_public, share_server_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_5f7d80b0","line":202,"range":{"start_line":202,"start_character":25,"end_line":202,"end_character":28},"updated":"2019-03-05 17:06:19.000000000","message":"\u003e\u003d","commit_id":"d97c18dbf2a2ab6aba510aac0d75dd0c26e29568"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"7d8ab71a485f0a41309a471dc25bb1852cd7e6c4","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                result \u003d manager.manage("},{"line_number":200,"context_line":"                    service_host, protocol, export_path, driver_options,"},{"line_number":201,"context_line":"                    share_type, name, description, is_public)"},{"line_number":202,"context_line":"            elif version \u003d\u003d api_versions.APIVersion(\u00272.49\u0027):"},{"line_number":203,"context_line":"                result \u003d manager.manage("},{"line_number":204,"context_line":"                    service_host, protocol, export_path, driver_options,"},{"line_number":205,"context_line":"                    share_type, name, description, is_public, share_server_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5fc1f717_2d744d99","line":202,"range":{"start_line":202,"start_character":25,"end_line":202,"end_character":28},"in_reply_to":"9fdfeff1_5f7d80b0","updated":"2019-03-05 17:33:42.000000000","message":"Done","commit_id":"d97c18dbf2a2ab6aba510aac0d75dd0c26e29568"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"858a6034bd4e8135b87ebf17bc48b0b1f2e5471e","unresolved":false,"context_lines":[{"line_number":203,"context_line":"                result \u003d manager.manage("},{"line_number":204,"context_line":"                    service_host, protocol, export_path, driver_options,"},{"line_number":205,"context_line":"                    share_type, name, description, is_public, share_server_id)"},{"line_number":206,"context_line":"            else:"},{"line_number":207,"context_line":"                result \u003d manager.manage("},{"line_number":208,"context_line":"                    service_host, protocol, export_path, driver_options,"},{"line_number":209,"context_line":"                    share_type, name, description)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"            self.assertEqual(manager._create.return_value, result)"},{"line_number":212,"context_line":"            manager._create.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_bf07cc1d","line":209,"range":{"start_line":206,"start_character":0,"end_line":209,"end_character":50},"updated":"2019-03-05 17:06:19.000000000","message":"It would be clearer to put this branch at the beginning with a condition \u003c 2.8.","commit_id":"d97c18dbf2a2ab6aba510aac0d75dd0c26e29568"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"7d8ab71a485f0a41309a471dc25bb1852cd7e6c4","unresolved":false,"context_lines":[{"line_number":203,"context_line":"                result \u003d manager.manage("},{"line_number":204,"context_line":"                    service_host, protocol, export_path, driver_options,"},{"line_number":205,"context_line":"                    share_type, name, description, is_public, share_server_id)"},{"line_number":206,"context_line":"            else:"},{"line_number":207,"context_line":"                result \u003d manager.manage("},{"line_number":208,"context_line":"                    service_host, protocol, export_path, driver_options,"},{"line_number":209,"context_line":"                    share_type, name, description)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"            self.assertEqual(manager._create.return_value, result)"},{"line_number":212,"context_line":"            manager._create.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":6,"id":"5fc1f717_6dd7b525","line":209,"range":{"start_line":206,"start_character":0,"end_line":209,"end_character":50},"in_reply_to":"9fdfeff1_bf07cc1d","updated":"2019-03-05 17:33:42.000000000","message":"Done","commit_id":"d97c18dbf2a2ab6aba510aac0d75dd0c26e29568"}],"manilaclient/v2/share_servers.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2088091542d1024307ad7f36dd06ce6c6eaccc89","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        query_string \u003d self._build_query_string(search_opts)"},{"line_number":97,"context_line":"        return self._list(RESOURCES_PATH + query_string, RESOURCES_NAME)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    @api_versions.wraps(\"2.49\")  # noqa"},{"line_number":100,"context_line":"    def manage(self, host, share_network_id, identifier, driver_options\u003dNone):"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        driver_options \u003d driver_options if driver_options else {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_65e604ea","line":99,"range":{"start_line":99,"start_character":33,"end_line":99,"end_character":39},"updated":"2019-03-01 08:10:31.000000000","message":"not necessary","commit_id":"b79dda78e52d04b4be0b0574c29b49e8b5ab074d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"dc6a42afea9626d216dd8d70a26b4bea75aeee65","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        query_string \u003d self._build_query_string(search_opts)"},{"line_number":97,"context_line":"        return self._list(RESOURCES_PATH + query_string, RESOURCES_NAME)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    @api_versions.wraps(\"2.49\")  # noqa"},{"line_number":100,"context_line":"    def manage(self, host, share_network_id, identifier, driver_options\u003dNone):"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        driver_options \u003d driver_options if driver_options else {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_18c8aea5","line":99,"range":{"start_line":99,"start_character":33,"end_line":99,"end_character":39},"in_reply_to":"9fdfeff1_65e604ea","updated":"2019-03-01 18:38:57.000000000","message":"Done","commit_id":"b79dda78e52d04b4be0b0574c29b49e8b5ab074d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2088091542d1024307ad7f36dd06ce6c6eaccc89","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        return self._create(resource_path, {\u0027share_server\u0027: body},"},{"line_number":112,"context_line":"                            \u0027share_server\u0027)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    @api_versions.wraps(\"2.49\")  # noqa"},{"line_number":115,"context_line":"    def unmanage(self, share_server, **kwargs):"},{"line_number":116,"context_line":"        return self._action(\"unmanage\", share_server)"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_e5d194f9","line":114,"range":{"start_line":114,"start_character":33,"end_line":114,"end_character":38},"updated":"2019-03-01 08:10:31.000000000","message":"not necessary","commit_id":"b79dda78e52d04b4be0b0574c29b49e8b5ab074d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"dc6a42afea9626d216dd8d70a26b4bea75aeee65","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        return self._create(resource_path, {\u0027share_server\u0027: body},"},{"line_number":112,"context_line":"                            \u0027share_server\u0027)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    @api_versions.wraps(\"2.49\")  # noqa"},{"line_number":115,"context_line":"    def unmanage(self, share_server, **kwargs):"},{"line_number":116,"context_line":"        return self._action(\"unmanage\", share_server)"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_38cb32a4","line":114,"range":{"start_line":114,"start_character":33,"end_line":114,"end_character":38},"in_reply_to":"9fdfeff1_e5d194f9","updated":"2019-03-01 18:38:57.000000000","message":"Done","commit_id":"b79dda78e52d04b4be0b0574c29b49e8b5ab074d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2088091542d1024307ad7f36dd06ce6c6eaccc89","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    def unmanage(self, share_server, **kwargs):"},{"line_number":116,"context_line":"        return self._action(\"unmanage\", share_server)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def reset_state(self, share_server, state, **kwargs):"},{"line_number":119,"context_line":"        \"\"\"Update the provided share instance with the provided state."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        :param share_server: either share_server object or text with its ID."}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_a5094c95","line":118,"range":{"start_line":118,"start_character":8,"end_line":118,"end_character":19},"updated":"2019-03-01 08:10:31.000000000","message":"version wrapper?","commit_id":"b79dda78e52d04b4be0b0574c29b49e8b5ab074d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"dc6a42afea9626d216dd8d70a26b4bea75aeee65","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    def unmanage(self, share_server, **kwargs):"},{"line_number":116,"context_line":"        return self._action(\"unmanage\", share_server)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def reset_state(self, share_server, state, **kwargs):"},{"line_number":119,"context_line":"        \"\"\"Update the provided share instance with the provided state."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        :param share_server: either share_server object or text with its ID."}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_d8c5468f","line":118,"range":{"start_line":118,"start_character":8,"end_line":118,"end_character":19},"in_reply_to":"9fdfeff1_a5094c95","updated":"2019-03-01 18:38:57.000000000","message":"Done","commit_id":"b79dda78e52d04b4be0b0574c29b49e8b5ab074d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2088091542d1024307ad7f36dd06ce6c6eaccc89","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        return self._action(\"unmanage\", share_server)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def reset_state(self, share_server, state, **kwargs):"},{"line_number":119,"context_line":"        \"\"\"Update the provided share instance with the provided state."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        :param share_server: either share_server object or text with its ID."},{"line_number":122,"context_line":"        :param state: text with new state to set for share."}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_45fc2071","line":119,"range":{"start_line":119,"start_character":37,"end_line":119,"end_character":45},"updated":"2019-03-01 08:10:31.000000000","message":"server","commit_id":"b79dda78e52d04b4be0b0574c29b49e8b5ab074d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"dc6a42afea9626d216dd8d70a26b4bea75aeee65","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        return self._action(\"unmanage\", share_server)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def reset_state(self, share_server, state, **kwargs):"},{"line_number":119,"context_line":"        \"\"\"Update the provided share instance with the provided state."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        :param share_server: either share_server object or text with its ID."},{"line_number":122,"context_line":"        :param state: text with new state to set for share."}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_b8b64224","line":119,"range":{"start_line":119,"start_character":37,"end_line":119,"end_character":45},"in_reply_to":"9fdfeff1_45fc2071","updated":"2019-03-01 18:38:57.000000000","message":"Done","commit_id":"b79dda78e52d04b4be0b0574c29b49e8b5ab074d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2088091542d1024307ad7f36dd06ce6c6eaccc89","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        return self._action(\"reset_status\", share_server, {\"status\": state})"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def _action(self, action, share_server, info\u003dNone, **kwargs):"},{"line_number":127,"context_line":"        \"\"\"Perform a share \u0027action\u0027."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        :param action: text with action name."},{"line_number":130,"context_line":"        :param share_server: either share_server object or text with its ID."}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_05fa9873","line":127,"range":{"start_line":127,"start_character":21,"end_line":127,"end_character":26},"updated":"2019-03-01 08:10:31.000000000","message":"share server","commit_id":"b79dda78e52d04b4be0b0574c29b49e8b5ab074d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"dc6a42afea9626d216dd8d70a26b4bea75aeee65","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        return self._action(\"reset_status\", share_server, {\"status\": state})"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def _action(self, action, share_server, info\u003dNone, **kwargs):"},{"line_number":127,"context_line":"        \"\"\"Perform a share \u0027action\u0027."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        :param action: text with action name."},{"line_number":130,"context_line":"        :param share_server: either share_server object or text with its ID."}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_d84a2625","line":127,"range":{"start_line":127,"start_character":21,"end_line":127,"end_character":26},"in_reply_to":"9fdfeff1_05fa9873","updated":"2019-03-01 18:38:57.000000000","message":"Done","commit_id":"b79dda78e52d04b4be0b0574c29b49e8b5ab074d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"66a07e79cf57898e0365fc3955caa8dc026a4918","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    @api_versions.wraps(\"2.49\")"},{"line_number":100,"context_line":"    def manage(self, host, share_network_id, identifier, driver_options\u003dNone):"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        driver_options \u003d driver_options if driver_options else {}"},{"line_number":103,"context_line":"        body \u003d {"},{"line_number":104,"context_line":"            \u0027host\u0027: host,"},{"line_number":105,"context_line":"            \u0027share_network_id\u0027: share_network_id,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_96d78d24","line":102,"range":{"start_line":102,"start_character":25,"end_line":102,"end_character":65},"updated":"2019-03-06 00:23:33.000000000","message":"driver_options or {}","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f0f001c71dedd392790aae490ecb05cf3e483a20","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    @api_versions.wraps(\"2.49\")"},{"line_number":100,"context_line":"    def manage(self, host, share_network_id, identifier, driver_options\u003dNone):"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        driver_options \u003d driver_options if driver_options else {}"},{"line_number":103,"context_line":"        body \u003d {"},{"line_number":104,"context_line":"            \u0027host\u0027: host,"},{"line_number":105,"context_line":"            \u0027share_network_id\u0027: share_network_id,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_e4e3aea3","line":102,"range":{"start_line":102,"start_character":25,"end_line":102,"end_character":65},"in_reply_to":"5fc1f717_96d78d24","updated":"2019-03-06 14:03:59.000000000","message":"Done","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"66a07e79cf57898e0365fc3955caa8dc026a4918","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                            \u0027share_server\u0027)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    @api_versions.wraps(\"2.49\")"},{"line_number":115,"context_line":"    def unmanage(self, share_server, force\u003dFalse, **kwargs):"},{"line_number":116,"context_line":"        return self._action(\"unmanage\", share_server, {\u0027force\u0027: force})"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    @api_versions.wraps(\"2.49\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_36dc9945","line":115,"range":{"start_line":115,"start_character":52,"end_line":115,"end_character":58},"updated":"2019-03-06 00:23:33.000000000","message":"?","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f0f001c71dedd392790aae490ecb05cf3e483a20","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                            \u0027share_server\u0027)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    @api_versions.wraps(\"2.49\")"},{"line_number":115,"context_line":"    def unmanage(self, share_server, force\u003dFalse, **kwargs):"},{"line_number":116,"context_line":"        return self._action(\"unmanage\", share_server, {\u0027force\u0027: force})"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    @api_versions.wraps(\"2.49\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_c4f4725e","line":115,"range":{"start_line":115,"start_character":52,"end_line":115,"end_character":58},"in_reply_to":"5fc1f717_36dc9945","updated":"2019-03-06 14:03:59.000000000","message":"Done","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"66a07e79cf57898e0365fc3955caa8dc026a4918","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        return self._action(\"unmanage\", share_server, {\u0027force\u0027: force})"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    @api_versions.wraps(\"2.49\")"},{"line_number":119,"context_line":"    def reset_state(self, share_server, state, **kwargs):"},{"line_number":120,"context_line":"        \"\"\"Update the provided share server with the provided state."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        :param share_server: either share_server object or text with its ID."}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_56e125fe","line":119,"range":{"start_line":119,"start_character":49,"end_line":119,"end_character":55},"updated":"2019-03-06 00:23:33.000000000","message":"?","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f0f001c71dedd392790aae490ecb05cf3e483a20","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        return self._action(\"unmanage\", share_server, {\u0027force\u0027: force})"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    @api_versions.wraps(\"2.49\")"},{"line_number":119,"context_line":"    def reset_state(self, share_server, state, **kwargs):"},{"line_number":120,"context_line":"        \"\"\"Update the provided share server with the provided state."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        :param share_server: either share_server object or text with its ID."}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_64e9fe7e","line":119,"range":{"start_line":119,"start_character":49,"end_line":119,"end_character":55},"in_reply_to":"5fc1f717_56e125fe","updated":"2019-03-06 14:03:59.000000000","message":"Done","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"66a07e79cf57898e0365fc3955caa8dc026a4918","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        \"\"\""},{"line_number":125,"context_line":"        return self._action(\"reset_status\", share_server, {\"status\": state})"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def _action(self, action, share_server, info\u003dNone, **kwargs):"},{"line_number":128,"context_line":"        \"\"\"Perform a share server \u0027action\u0027."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        :param action: text with action name."}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_f6e5b10b","line":127,"range":{"start_line":127,"start_character":57,"end_line":127,"end_character":63},"updated":"2019-03-06 00:23:33.000000000","message":"?","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f0f001c71dedd392790aae490ecb05cf3e483a20","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        \"\"\""},{"line_number":125,"context_line":"        return self._action(\"reset_status\", share_server, {\"status\": state})"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def _action(self, action, share_server, info\u003dNone, **kwargs):"},{"line_number":128,"context_line":"        \"\"\"Perform a share server \u0027action\u0027."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        :param action: text with action name."}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_44008235","line":127,"range":{"start_line":127,"start_character":57,"end_line":127,"end_character":63},"in_reply_to":"5fc1f717_f6e5b10b","updated":"2019-03-06 14:03:59.000000000","message":"Done","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"66a07e79cf57898e0365fc3955caa8dc026a4918","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        \"\"\""},{"line_number":135,"context_line":"        body \u003d {action: info}"},{"line_number":136,"context_line":"        self.run_hooks(\u0027modify_body_for_action\u0027, body, **kwargs)"},{"line_number":137,"context_line":"        url \u003d \u0027/share-servers/%s/action\u0027 % common_base.getid(share_server)"},{"line_number":138,"context_line":"        return self.api.client.post(url, body\u003dbody)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_b6ef29e8","line":137,"range":{"start_line":137,"start_character":14,"end_line":137,"end_character":40},"updated":"2019-03-06 00:23:33.000000000","message":"put this along with the other constants perhaps?","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f0f001c71dedd392790aae490ecb05cf3e483a20","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        \"\"\""},{"line_number":135,"context_line":"        body \u003d {action: info}"},{"line_number":136,"context_line":"        self.run_hooks(\u0027modify_body_for_action\u0027, body, **kwargs)"},{"line_number":137,"context_line":"        url \u003d \u0027/share-servers/%s/action\u0027 % common_base.getid(share_server)"},{"line_number":138,"context_line":"        return self.api.client.post(url, body\u003dbody)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_44ae422f","line":137,"range":{"start_line":137,"start_character":14,"end_line":137,"end_character":40},"in_reply_to":"5fc1f717_b6ef29e8","updated":"2019-03-06 14:03:59.000000000","message":"Done","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"}],"manilaclient/v2/shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"66a07e79cf57898e0365fc3955caa8dc026a4918","unresolved":false,"context_lines":[{"line_number":252,"context_line":"        share_server_id \u003d None"},{"line_number":253,"context_line":"        return self._do_manage("},{"line_number":254,"context_line":"            service_host, protocol, export_path, driver_options, share_type,"},{"line_number":255,"context_line":"            name, description, is_public, share_server_id,"},{"line_number":256,"context_line":"            resource_path\u003d\"/os-share-manage\")"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    @api_versions.wraps(\"2.7\", \"2.7\")  # noqa"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_56ba85de","line":255,"range":{"start_line":255,"start_character":42,"end_line":255,"end_character":58},"updated":"2019-03-06 00:23:33.000000000","message":"since it is a kwarg, don\u0027t pass it here.","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f0f001c71dedd392790aae490ecb05cf3e483a20","unresolved":false,"context_lines":[{"line_number":252,"context_line":"        share_server_id \u003d None"},{"line_number":253,"context_line":"        return self._do_manage("},{"line_number":254,"context_line":"            service_host, protocol, export_path, driver_options, share_type,"},{"line_number":255,"context_line":"            name, description, is_public, share_server_id,"},{"line_number":256,"context_line":"            resource_path\u003d\"/os-share-manage\")"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    @api_versions.wraps(\"2.7\", \"2.7\")  # noqa"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_39832a07","line":255,"range":{"start_line":255,"start_character":42,"end_line":255,"end_character":58},"in_reply_to":"5fc1f717_56ba85de","updated":"2019-03-06 14:03:59.000000000","message":"Done","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"66a07e79cf57898e0365fc3955caa8dc026a4918","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        share_server_id \u003d None"},{"line_number":263,"context_line":"        return self._do_manage("},{"line_number":264,"context_line":"            service_host, protocol, export_path, driver_options, share_type,"},{"line_number":265,"context_line":"            name, description, is_public, share_server_id,"},{"line_number":266,"context_line":"            resource_path\u003d\"/shares/manage\")"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    @api_versions.wraps(\"2.8\", \"2.48\")  # noqa"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_16ccfd87","line":265,"range":{"start_line":265,"start_character":42,"end_line":265,"end_character":57},"updated":"2019-03-06 00:23:33.000000000","message":"same","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f0f001c71dedd392790aae490ecb05cf3e483a20","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        share_server_id \u003d None"},{"line_number":263,"context_line":"        return self._do_manage("},{"line_number":264,"context_line":"            service_host, protocol, export_path, driver_options, share_type,"},{"line_number":265,"context_line":"            name, description, is_public, share_server_id,"},{"line_number":266,"context_line":"            resource_path\u003d\"/shares/manage\")"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    @api_versions.wraps(\"2.8\", \"2.48\")  # noqa"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_5988761e","line":265,"range":{"start_line":265,"start_character":42,"end_line":265,"end_character":57},"in_reply_to":"5fc1f717_16ccfd87","updated":"2019-03-06 14:03:59.000000000","message":"Done","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"66a07e79cf57898e0365fc3955caa8dc026a4918","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        share_server_id \u003d None"},{"line_number":272,"context_line":"        return self._do_manage("},{"line_number":273,"context_line":"            service_host, protocol, export_path, driver_options, share_type,"},{"line_number":274,"context_line":"            name, description, is_public, share_server_id,"},{"line_number":275,"context_line":"            resource_path\u003d\"/shares/manage\")"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    @api_versions.wraps(\"2.49\")  # noqa"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_b6c88974","line":274,"range":{"start_line":274,"start_character":42,"end_line":274,"end_character":57},"updated":"2019-03-06 00:23:33.000000000","message":"same","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f0f001c71dedd392790aae490ecb05cf3e483a20","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        share_server_id \u003d None"},{"line_number":272,"context_line":"        return self._do_manage("},{"line_number":273,"context_line":"            service_host, protocol, export_path, driver_options, share_type,"},{"line_number":274,"context_line":"            name, description, is_public, share_server_id,"},{"line_number":275,"context_line":"            resource_path\u003d\"/shares/manage\")"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    @api_versions.wraps(\"2.49\")  # noqa"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_f97cc221","line":274,"range":{"start_line":274,"start_character":42,"end_line":274,"end_character":57},"in_reply_to":"5fc1f717_b6c88974","updated":"2019-03-06 14:03:59.000000000","message":"Done","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"66a07e79cf57898e0365fc3955caa8dc026a4918","unresolved":false,"context_lines":[{"line_number":279,"context_line":"               share_type\u003dNone, name\u003dNone, description\u003dNone, is_public\u003dFalse,"},{"line_number":280,"context_line":"               share_server_id\u003dNone):"},{"line_number":281,"context_line":"        return self._do_manage("},{"line_number":282,"context_line":"            service_host, protocol, export_path, driver_options, share_type,"},{"line_number":283,"context_line":"            name, description, is_public, share_server_id,"},{"line_number":284,"context_line":"            resource_path\u003d\"/shares/manage\")"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    @api_versions.wraps(\"1.0\", \"2.6\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_36aa5985","line":283,"range":{"start_line":282,"start_character":65,"end_line":283,"end_character":58},"updated":"2019-03-06 00:23:33.000000000","message":"always pass kwargs as kwargs. It\u0027d be awesome to fix the inconsistencies above as well..","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f0f001c71dedd392790aae490ecb05cf3e483a20","unresolved":false,"context_lines":[{"line_number":279,"context_line":"               share_type\u003dNone, name\u003dNone, description\u003dNone, is_public\u003dFalse,"},{"line_number":280,"context_line":"               share_server_id\u003dNone):"},{"line_number":281,"context_line":"        return self._do_manage("},{"line_number":282,"context_line":"            service_host, protocol, export_path, driver_options, share_type,"},{"line_number":283,"context_line":"            name, description, is_public, share_server_id,"},{"line_number":284,"context_line":"            resource_path\u003d\"/shares/manage\")"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    @api_versions.wraps(\"1.0\", \"2.6\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_24da16e9","line":283,"range":{"start_line":282,"start_character":65,"end_line":283,"end_character":58},"in_reply_to":"5fc1f717_36aa5985","updated":"2019-03-06 14:03:59.000000000","message":"Done","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2088091542d1024307ad7f36dd06ce6c6eaccc89","unresolved":false,"context_lines":[{"line_number":1174,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":1175,"context_line":"    help\u003d\"Share server associated with share when using a share type with \""},{"line_number":1176,"context_line":"         \"\u0027driver_handles_share_servers\u0027 extra_spec enabled. Available only \""},{"line_number":1177,"context_line":"         \"for microversion \u003e\u003d 2.8.(Default\u003dNone)\")"},{"line_number":1178,"context_line":"@cliutils.arg("},{"line_number":1179,"context_line":"    \u0027--driver_options\u0027, \u0027--driver-options\u0027,"},{"line_number":1180,"context_line":"    type\u003dstr,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_0595b83f","line":1177,"range":{"start_line":1177,"start_character":29,"end_line":1177,"end_character":30},"updated":"2019-03-01 08:10:31.000000000","message":"2.49","commit_id":"b79dda78e52d04b4be0b0574c29b49e8b5ab074d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"dc6a42afea9626d216dd8d70a26b4bea75aeee65","unresolved":false,"context_lines":[{"line_number":1174,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":1175,"context_line":"    help\u003d\"Share server associated with share when using a share type with \""},{"line_number":1176,"context_line":"         \"\u0027driver_handles_share_servers\u0027 extra_spec enabled. Available only \""},{"line_number":1177,"context_line":"         \"for microversion \u003e\u003d 2.8.(Default\u003dNone)\")"},{"line_number":1178,"context_line":"@cliutils.arg("},{"line_number":1179,"context_line":"    \u0027--driver_options\u0027, \u0027--driver-options\u0027,"},{"line_number":1180,"context_line":"    type\u003dstr,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_f86e0a94","line":1177,"range":{"start_line":1177,"start_character":29,"end_line":1177,"end_character":30},"in_reply_to":"9fdfeff1_0595b83f","updated":"2019-03-01 18:38:57.000000000","message":"Done","commit_id":"b79dda78e52d04b4be0b0574c29b49e8b5ab074d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2088091542d1024307ad7f36dd06ce6c6eaccc89","unresolved":false,"context_lines":[{"line_number":1134,"context_line":"    _print_share(cs, share)"},{"line_number":1135,"context_line":""},{"line_number":1136,"context_line":""},{"line_number":1137,"context_line":"@api_versions.wraps(\"2.49\")  # noqa"},{"line_number":1138,"context_line":"@cliutils.arg("},{"line_number":1139,"context_line":"    \u0027service_host\u0027,"},{"line_number":1140,"context_line":"    metavar\u003d\u0027\u003cservice_host\u003e\u0027,"},{"line_number":1141,"context_line":"    type\u003dstr,"},{"line_number":1142,"context_line":"    help\u003d\u0027manage-share service host: some.host@driver#pool.\u0027)"},{"line_number":1143,"context_line":"@cliutils.arg("},{"line_number":1144,"context_line":"    \u0027protocol\u0027,"},{"line_number":1145,"context_line":"    metavar\u003d\u0027\u003cprotocol\u003e\u0027,"},{"line_number":1146,"context_line":"    type\u003dstr,"},{"line_number":1147,"context_line":"    help\u003d\u0027Protocol of the share to manage, such as NFS or CIFS.\u0027)"},{"line_number":1148,"context_line":"@cliutils.arg("},{"line_number":1149,"context_line":"    \u0027export_path\u0027,"},{"line_number":1150,"context_line":"    metavar\u003d\u0027\u003cexport_path\u003e\u0027,"},{"line_number":1151,"context_line":"    type\u003dstr,"},{"line_number":1152,"context_line":"    help\u003d\u0027Share export path, NFS share such as: 10.0.0.1:/example_path, \u0027"},{"line_number":1153,"context_line":"         \u0027CIFS share such as: \\\\\\\\10.0.0.1\\\\example_cifs_share.\u0027)"},{"line_number":1154,"context_line":"@cliutils.arg("},{"line_number":1155,"context_line":"    \u0027--name\u0027,"},{"line_number":1156,"context_line":"    metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":1157,"context_line":"    help\u003d\u0027Optional share name. (Default\u003dNone)\u0027,"},{"line_number":1158,"context_line":"    default\u003dNone)"},{"line_number":1159,"context_line":"@cliutils.arg("},{"line_number":1160,"context_line":"    \u0027--description\u0027,"},{"line_number":1161,"context_line":"    metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":1162,"context_line":"    help\u003d\u0027Optional share description. (Default\u003dNone)\u0027,"},{"line_number":1163,"context_line":"    default\u003dNone)"},{"line_number":1164,"context_line":"@cliutils.arg("},{"line_number":1165,"context_line":"    \u0027--share_type\u0027, \u0027--share-type\u0027,"},{"line_number":1166,"context_line":"    metavar\u003d\u0027\u003cshare-type\u003e\u0027,"},{"line_number":1167,"context_line":"    default\u003dNone,"},{"line_number":1168,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":1169,"context_line":"    help\u003d\u0027Optional share type assigned to share. (Default\u003dNone)\u0027)"},{"line_number":1170,"context_line":"@cliutils.arg("},{"line_number":1171,"context_line":"    \u0027--share_server_id\u0027, \u0027--share-server-id\u0027,"},{"line_number":1172,"context_line":"    metavar\u003d\u0027\u003cshare-server-id\u003e\u0027,"},{"line_number":1173,"context_line":"    default\u003dNone,"},{"line_number":1174,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":1175,"context_line":"    help\u003d\"Share server associated with share when using a share type with \""},{"line_number":1176,"context_line":"         \"\u0027driver_handles_share_servers\u0027 extra_spec enabled. Available only \""},{"line_number":1177,"context_line":"         \"for microversion \u003e\u003d 2.8.(Default\u003dNone)\")"},{"line_number":1178,"context_line":"@cliutils.arg("},{"line_number":1179,"context_line":"    \u0027--driver_options\u0027, \u0027--driver-options\u0027,"},{"line_number":1180,"context_line":"    type\u003dstr,"},{"line_number":1181,"context_line":"    nargs\u003d\u0027*\u0027,"},{"line_number":1182,"context_line":"    metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":1183,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":1184,"context_line":"    help\u003d\u0027Driver option key\u003dvalue pairs (Optional, Default\u003dNone).\u0027,"},{"line_number":1185,"context_line":"    default\u003dNone)"},{"line_number":1186,"context_line":"@cliutils.arg("},{"line_number":1187,"context_line":"    \u0027--public\u0027,"},{"line_number":1188,"context_line":"    dest\u003d\u0027public\u0027,"},{"line_number":1189,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":1190,"context_line":"    default\u003dFalse,"},{"line_number":1191,"context_line":"    help\u003d\"Level of visibility for share. Defines whether other tenants are \""},{"line_number":1192,"context_line":"         \"able to see it or not. Available only for microversion \u003e\u003d 2.8.\")"},{"line_number":1193,"context_line":"def do_manage(cs, args):"},{"line_number":1194,"context_line":"    \"\"\"Manage share not handled by Manila (Admin only).\"\"\""},{"line_number":1195,"context_line":"    driver_options \u003d _extract_key_value_options(args, \u0027driver_options\u0027)"},{"line_number":1196,"context_line":""},{"line_number":1197,"context_line":"    share \u003d cs.shares.manage("},{"line_number":1198,"context_line":"        args.service_host, args.protocol, args.export_path,"},{"line_number":1199,"context_line":"        driver_options\u003ddriver_options, share_type\u003dargs.share_type,"},{"line_number":1200,"context_line":"        name\u003dargs.name, description\u003dargs.description,"},{"line_number":1201,"context_line":"        share_server_id\u003dargs.share_server_id, is_public\u003dargs.public,"},{"line_number":1202,"context_line":"    )"},{"line_number":1203,"context_line":""},{"line_number":1204,"context_line":"    _print_share(cs, share)"},{"line_number":1205,"context_line":""},{"line_number":1206,"context_line":""},{"line_number":1207,"context_line":"@api_versions.wraps(\"2.49\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_65aa8484","line":1204,"range":{"start_line":1137,"start_character":0,"end_line":1204,"end_character":27},"updated":"2019-03-01 08:10:31.000000000","message":"This is just a copy of the method above... it\u0027s not reasonable to duplicate this when you\u0027re only adding a new option, can you just add a version check inline instead?","commit_id":"b79dda78e52d04b4be0b0574c29b49e8b5ab074d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"dc6a42afea9626d216dd8d70a26b4bea75aeee65","unresolved":false,"context_lines":[{"line_number":1134,"context_line":"    _print_share(cs, share)"},{"line_number":1135,"context_line":""},{"line_number":1136,"context_line":""},{"line_number":1137,"context_line":"@api_versions.wraps(\"2.49\")  # noqa"},{"line_number":1138,"context_line":"@cliutils.arg("},{"line_number":1139,"context_line":"    \u0027service_host\u0027,"},{"line_number":1140,"context_line":"    metavar\u003d\u0027\u003cservice_host\u003e\u0027,"},{"line_number":1141,"context_line":"    type\u003dstr,"},{"line_number":1142,"context_line":"    help\u003d\u0027manage-share service host: some.host@driver#pool.\u0027)"},{"line_number":1143,"context_line":"@cliutils.arg("},{"line_number":1144,"context_line":"    \u0027protocol\u0027,"},{"line_number":1145,"context_line":"    metavar\u003d\u0027\u003cprotocol\u003e\u0027,"},{"line_number":1146,"context_line":"    type\u003dstr,"},{"line_number":1147,"context_line":"    help\u003d\u0027Protocol of the share to manage, such as NFS or CIFS.\u0027)"},{"line_number":1148,"context_line":"@cliutils.arg("},{"line_number":1149,"context_line":"    \u0027export_path\u0027,"},{"line_number":1150,"context_line":"    metavar\u003d\u0027\u003cexport_path\u003e\u0027,"},{"line_number":1151,"context_line":"    type\u003dstr,"},{"line_number":1152,"context_line":"    help\u003d\u0027Share export path, NFS share such as: 10.0.0.1:/example_path, \u0027"},{"line_number":1153,"context_line":"         \u0027CIFS share such as: \\\\\\\\10.0.0.1\\\\example_cifs_share.\u0027)"},{"line_number":1154,"context_line":"@cliutils.arg("},{"line_number":1155,"context_line":"    \u0027--name\u0027,"},{"line_number":1156,"context_line":"    metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":1157,"context_line":"    help\u003d\u0027Optional share name. (Default\u003dNone)\u0027,"},{"line_number":1158,"context_line":"    default\u003dNone)"},{"line_number":1159,"context_line":"@cliutils.arg("},{"line_number":1160,"context_line":"    \u0027--description\u0027,"},{"line_number":1161,"context_line":"    metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":1162,"context_line":"    help\u003d\u0027Optional share description. (Default\u003dNone)\u0027,"},{"line_number":1163,"context_line":"    default\u003dNone)"},{"line_number":1164,"context_line":"@cliutils.arg("},{"line_number":1165,"context_line":"    \u0027--share_type\u0027, \u0027--share-type\u0027,"},{"line_number":1166,"context_line":"    metavar\u003d\u0027\u003cshare-type\u003e\u0027,"},{"line_number":1167,"context_line":"    default\u003dNone,"},{"line_number":1168,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":1169,"context_line":"    help\u003d\u0027Optional share type assigned to share. (Default\u003dNone)\u0027)"},{"line_number":1170,"context_line":"@cliutils.arg("},{"line_number":1171,"context_line":"    \u0027--share_server_id\u0027, \u0027--share-server-id\u0027,"},{"line_number":1172,"context_line":"    metavar\u003d\u0027\u003cshare-server-id\u003e\u0027,"},{"line_number":1173,"context_line":"    default\u003dNone,"},{"line_number":1174,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":1175,"context_line":"    help\u003d\"Share server associated with share when using a share type with \""},{"line_number":1176,"context_line":"         \"\u0027driver_handles_share_servers\u0027 extra_spec enabled. Available only \""},{"line_number":1177,"context_line":"         \"for microversion \u003e\u003d 2.8.(Default\u003dNone)\")"},{"line_number":1178,"context_line":"@cliutils.arg("},{"line_number":1179,"context_line":"    \u0027--driver_options\u0027, \u0027--driver-options\u0027,"},{"line_number":1180,"context_line":"    type\u003dstr,"},{"line_number":1181,"context_line":"    nargs\u003d\u0027*\u0027,"},{"line_number":1182,"context_line":"    metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":1183,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":1184,"context_line":"    help\u003d\u0027Driver option key\u003dvalue pairs (Optional, Default\u003dNone).\u0027,"},{"line_number":1185,"context_line":"    default\u003dNone)"},{"line_number":1186,"context_line":"@cliutils.arg("},{"line_number":1187,"context_line":"    \u0027--public\u0027,"},{"line_number":1188,"context_line":"    dest\u003d\u0027public\u0027,"},{"line_number":1189,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":1190,"context_line":"    default\u003dFalse,"},{"line_number":1191,"context_line":"    help\u003d\"Level of visibility for share. Defines whether other tenants are \""},{"line_number":1192,"context_line":"         \"able to see it or not. Available only for microversion \u003e\u003d 2.8.\")"},{"line_number":1193,"context_line":"def do_manage(cs, args):"},{"line_number":1194,"context_line":"    \"\"\"Manage share not handled by Manila (Admin only).\"\"\""},{"line_number":1195,"context_line":"    driver_options \u003d _extract_key_value_options(args, \u0027driver_options\u0027)"},{"line_number":1196,"context_line":""},{"line_number":1197,"context_line":"    share \u003d cs.shares.manage("},{"line_number":1198,"context_line":"        args.service_host, args.protocol, args.export_path,"},{"line_number":1199,"context_line":"        driver_options\u003ddriver_options, share_type\u003dargs.share_type,"},{"line_number":1200,"context_line":"        name\u003dargs.name, description\u003dargs.description,"},{"line_number":1201,"context_line":"        share_server_id\u003dargs.share_server_id, is_public\u003dargs.public,"},{"line_number":1202,"context_line":"    )"},{"line_number":1203,"context_line":""},{"line_number":1204,"context_line":"    _print_share(cs, share)"},{"line_number":1205,"context_line":""},{"line_number":1206,"context_line":""},{"line_number":1207,"context_line":"@api_versions.wraps(\"2.49\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_38133267","line":1204,"range":{"start_line":1137,"start_character":0,"end_line":1204,"end_character":27},"in_reply_to":"9fdfeff1_65aa8484","updated":"2019-03-01 18:38:57.000000000","message":"Done","commit_id":"b79dda78e52d04b4be0b0574c29b49e8b5ab074d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2088091542d1024307ad7f36dd06ce6c6eaccc89","unresolved":false,"context_lines":[{"line_number":1209,"context_line":"    \u0027host\u0027,"},{"line_number":1210,"context_line":"    metavar\u003d\u0027\u003chost\u003e\u0027,"},{"line_number":1211,"context_line":"    type\u003dstr,"},{"line_number":1212,"context_line":"    help\u003d\u0027Backend name as \"\u003cnode_hostname\u003e@\u003cbackend_stanza\u003e\".\u0027)"},{"line_number":1213,"context_line":"@cliutils.arg("},{"line_number":1214,"context_line":"    \u0027share_network\u0027,"},{"line_number":1215,"context_line":"    metavar\u003d\u0027\u003cshare_network\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_45950031","line":1212,"range":{"start_line":1212,"start_character":52,"end_line":1212,"end_character":58},"updated":"2019-03-01 08:10:31.000000000","message":"name","commit_id":"b79dda78e52d04b4be0b0574c29b49e8b5ab074d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"dc6a42afea9626d216dd8d70a26b4bea75aeee65","unresolved":false,"context_lines":[{"line_number":1209,"context_line":"    \u0027host\u0027,"},{"line_number":1210,"context_line":"    metavar\u003d\u0027\u003chost\u003e\u0027,"},{"line_number":1211,"context_line":"    type\u003dstr,"},{"line_number":1212,"context_line":"    help\u003d\u0027Backend name as \"\u003cnode_hostname\u003e@\u003cbackend_stanza\u003e\".\u0027)"},{"line_number":1213,"context_line":"@cliutils.arg("},{"line_number":1214,"context_line":"    \u0027share_network\u0027,"},{"line_number":1215,"context_line":"    metavar\u003d\u0027\u003cshare_network\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_b86402b4","line":1212,"range":{"start_line":1212,"start_character":52,"end_line":1212,"end_character":58},"in_reply_to":"9fdfeff1_45950031","updated":"2019-03-01 18:38:57.000000000","message":"Done","commit_id":"b79dda78e52d04b4be0b0574c29b49e8b5ab074d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2088091542d1024307ad7f36dd06ce6c6eaccc89","unresolved":false,"context_lines":[{"line_number":1251,"context_line":"    metavar\u003d\u0027\u003cstate\u003e\u0027,"},{"line_number":1252,"context_line":"    default\u003dconstants.STATUS_ACTIVE,"},{"line_number":1253,"context_line":"    help\u003d(\u0027Indicate which state to assign the share server. Options include \u0027"},{"line_number":1254,"context_line":"          \u0027active, inactive, error, creating, deleting, managing, unmanaging, \u0027"},{"line_number":1255,"context_line":"          \u0027manage_error and unmanage_error. If no state is provided, active \u0027"},{"line_number":1256,"context_line":"          \u0027will be used.\u0027))"},{"line_number":1257,"context_line":"@api_versions.wraps(\"2.49\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_65b124e0","line":1254,"range":{"start_line":1254,"start_character":19,"end_line":1254,"end_character":27},"updated":"2019-03-01 08:10:31.000000000","message":"remove","commit_id":"b79dda78e52d04b4be0b0574c29b49e8b5ab074d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"dc6a42afea9626d216dd8d70a26b4bea75aeee65","unresolved":false,"context_lines":[{"line_number":1251,"context_line":"    metavar\u003d\u0027\u003cstate\u003e\u0027,"},{"line_number":1252,"context_line":"    default\u003dconstants.STATUS_ACTIVE,"},{"line_number":1253,"context_line":"    help\u003d(\u0027Indicate which state to assign the share server. Options include \u0027"},{"line_number":1254,"context_line":"          \u0027active, inactive, error, creating, deleting, managing, unmanaging, \u0027"},{"line_number":1255,"context_line":"          \u0027manage_error and unmanage_error. If no state is provided, active \u0027"},{"line_number":1256,"context_line":"          \u0027will be used.\u0027))"},{"line_number":1257,"context_line":"@api_versions.wraps(\"2.49\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_180bced4","line":1254,"range":{"start_line":1254,"start_character":19,"end_line":1254,"end_character":27},"in_reply_to":"9fdfeff1_65b124e0","updated":"2019-03-01 18:38:57.000000000","message":"Done","commit_id":"b79dda78e52d04b4be0b0574c29b49e8b5ab074d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2088091542d1024307ad7f36dd06ce6c6eaccc89","unresolved":false,"context_lines":[{"line_number":1318,"context_line":"@cliutils.arg("},{"line_number":1319,"context_line":"    \u0027share_server\u0027,"},{"line_number":1320,"context_line":"    metavar\u003d\u0027\u003cshare_server\u003e\u0027,"},{"line_number":1321,"context_line":"    help\u003d\u0027Name or ID of the share sherver(s).\u0027)"},{"line_number":1322,"context_line":"def do_share_server_unmanage(cs, args):"},{"line_number":1323,"context_line":"    \"\"\"Unmanage share server (Admin only).\"\"\""},{"line_number":1324,"context_line":"    cs.share_servers.unmanage(args.share_server)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_45ae6081","line":1321,"range":{"start_line":1321,"start_character":10,"end_line":1321,"end_character":14},"updated":"2019-03-01 08:10:31.000000000","message":"Share servers don\u0027t have a name","commit_id":"b79dda78e52d04b4be0b0574c29b49e8b5ab074d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"dc6a42afea9626d216dd8d70a26b4bea75aeee65","unresolved":false,"context_lines":[{"line_number":1318,"context_line":"@cliutils.arg("},{"line_number":1319,"context_line":"    \u0027share_server\u0027,"},{"line_number":1320,"context_line":"    metavar\u003d\u0027\u003cshare_server\u003e\u0027,"},{"line_number":1321,"context_line":"    help\u003d\u0027Name or ID of the share sherver(s).\u0027)"},{"line_number":1322,"context_line":"def do_share_server_unmanage(cs, args):"},{"line_number":1323,"context_line":"    \"\"\"Unmanage share server (Admin only).\"\"\""},{"line_number":1324,"context_line":"    cs.share_servers.unmanage(args.share_server)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_3827b265","line":1321,"range":{"start_line":1321,"start_character":10,"end_line":1321,"end_character":14},"in_reply_to":"9fdfeff1_45ae6081","updated":"2019-03-01 18:38:57.000000000","message":"Done","commit_id":"b79dda78e52d04b4be0b0574c29b49e8b5ab074d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2088091542d1024307ad7f36dd06ce6c6eaccc89","unresolved":false,"context_lines":[{"line_number":1321,"context_line":"    help\u003d\u0027Name or ID of the share sherver(s).\u0027)"},{"line_number":1322,"context_line":"def do_share_server_unmanage(cs, args):"},{"line_number":1323,"context_line":"    \"\"\"Unmanage share server (Admin only).\"\"\""},{"line_number":1324,"context_line":"    cs.share_servers.unmanage(args.share_server)"},{"line_number":1325,"context_line":""},{"line_number":1326,"context_line":""},{"line_number":1327,"context_line":"@api_versions.wraps(\"2.12\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_85b8c8c7","line":1324,"range":{"start_line":1324,"start_character":0,"end_line":1324,"end_character":48},"updated":"2019-03-01 08:10:31.000000000","message":"please support a loop here, so you can unmanage multiple at a time","commit_id":"b79dda78e52d04b4be0b0574c29b49e8b5ab074d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"dc6a42afea9626d216dd8d70a26b4bea75aeee65","unresolved":false,"context_lines":[{"line_number":1321,"context_line":"    help\u003d\u0027Name or ID of the share sherver(s).\u0027)"},{"line_number":1322,"context_line":"def do_share_server_unmanage(cs, args):"},{"line_number":1323,"context_line":"    \"\"\"Unmanage share server (Admin only).\"\"\""},{"line_number":1324,"context_line":"    cs.share_servers.unmanage(args.share_server)"},{"line_number":1325,"context_line":""},{"line_number":1326,"context_line":""},{"line_number":1327,"context_line":"@api_versions.wraps(\"2.12\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_988edece","line":1324,"range":{"start_line":1324,"start_character":0,"end_line":1324,"end_character":48},"in_reply_to":"9fdfeff1_85b8c8c7","updated":"2019-03-01 18:38:57.000000000","message":"Done","commit_id":"b79dda78e52d04b4be0b0574c29b49e8b5ab074d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"973b41de4a18754f2e8380fd4f19c0152fd1d471","unresolved":false,"context_lines":[{"line_number":1139,"context_line":"            name\u003dargs.name, description\u003dargs.description,"},{"line_number":1140,"context_line":"            is_public\u003dargs.public, share_server_id\u003dargs.share_server_id)"},{"line_number":1141,"context_line":"    else:"},{"line_number":1142,"context_line":"        share \u003d cs.shares.manage("},{"line_number":1143,"context_line":"            args.service_host, args.protocol, args.export_path,"},{"line_number":1144,"context_line":"            driver_options\u003ddriver_options, share_type\u003dargs.share_type,"},{"line_number":1145,"context_line":"            name\u003dargs.name, description\u003dargs.description,"},{"line_number":1146,"context_line":"            is_public\u003dargs.public)"},{"line_number":1147,"context_line":"    _print_share(cs, share)"},{"line_number":1148,"context_line":""},{"line_number":1149,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_6af216e6","line":1146,"range":{"start_line":1142,"start_character":8,"end_line":1146,"end_character":34},"updated":"2019-03-05 01:08:14.000000000","message":"shouldn\u0027t you raise an error here about share_server_id not supported with API version \u003c 2.49","commit_id":"3a62b1ddc019eab249b8ce89b15e0621af2fcc07"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"dd524b11e9bc348ef36b0d26feaf32088be68919","unresolved":false,"context_lines":[{"line_number":1139,"context_line":"            name\u003dargs.name, description\u003dargs.description,"},{"line_number":1140,"context_line":"            is_public\u003dargs.public, share_server_id\u003dargs.share_server_id)"},{"line_number":1141,"context_line":"    else:"},{"line_number":1142,"context_line":"        share \u003d cs.shares.manage("},{"line_number":1143,"context_line":"            args.service_host, args.protocol, args.export_path,"},{"line_number":1144,"context_line":"            driver_options\u003ddriver_options, share_type\u003dargs.share_type,"},{"line_number":1145,"context_line":"            name\u003dargs.name, description\u003dargs.description,"},{"line_number":1146,"context_line":"            is_public\u003dargs.public)"},{"line_number":1147,"context_line":"    _print_share(cs, share)"},{"line_number":1148,"context_line":""},{"line_number":1149,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_ed64e023","line":1146,"range":{"start_line":1142,"start_character":8,"end_line":1146,"end_character":34},"in_reply_to":"9fdfeff1_6af216e6","updated":"2019-03-05 02:46:24.000000000","message":"Done","commit_id":"3a62b1ddc019eab249b8ce89b15e0621af2fcc07"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"973b41de4a18754f2e8380fd4f19c0152fd1d471","unresolved":false,"context_lines":[{"line_number":1269,"context_line":"    action\u003d\"store_true\","},{"line_number":1270,"context_line":"    required\u003dFalse,"},{"line_number":1271,"context_line":"    default\u003dFalse,"},{"line_number":1272,"context_line":"    help\u003d\"Enforces the unmanage share server operation, even if the driver\""},{"line_number":1273,"context_line":"         \" does not support it.\")"},{"line_number":1274,"context_line":"def do_share_server_unmanage(cs, args):"},{"line_number":1275,"context_line":"    \"\"\"Unmanage share server (Admin only).\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_ea2fe63b","line":1272,"range":{"start_line":1272,"start_character":68,"end_line":1272,"end_character":74},"updated":"2019-03-05 01:08:14.000000000","message":"back-end driver","commit_id":"3a62b1ddc019eab249b8ce89b15e0621af2fcc07"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"858a6034bd4e8135b87ebf17bc48b0b1f2e5471e","unresolved":false,"context_lines":[{"line_number":1139,"context_line":"            name\u003dargs.name, description\u003dargs.description,"},{"line_number":1140,"context_line":"            is_public\u003dargs.public, share_server_id\u003dargs.share_server_id)"},{"line_number":1141,"context_line":"    else:"},{"line_number":1142,"context_line":"        if args.share_server_id:"},{"line_number":1143,"context_line":"            raise exceptions.CommandError(\"Invalid parameter \""},{"line_number":1144,"context_line":"                                          \"--share_server_id specified.\")"},{"line_number":1145,"context_line":"        share \u003d cs.shares.manage("},{"line_number":1146,"context_line":"            args.service_host, args.protocol, args.export_path,"},{"line_number":1147,"context_line":"            driver_options\u003ddriver_options, share_type\u003dargs.share_type,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_ff10f402","line":1144,"range":{"start_line":1142,"start_character":0,"end_line":1144,"end_character":73},"updated":"2019-03-05 17:06:19.000000000","message":"Better to explain that it\u0027s not supported at \u003c 2.49 since they might not otherwise realize their problem is running with an old client.","commit_id":"d97c18dbf2a2ab6aba510aac0d75dd0c26e29568"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"7d8ab71a485f0a41309a471dc25bb1852cd7e6c4","unresolved":false,"context_lines":[{"line_number":1139,"context_line":"            name\u003dargs.name, description\u003dargs.description,"},{"line_number":1140,"context_line":"            is_public\u003dargs.public, share_server_id\u003dargs.share_server_id)"},{"line_number":1141,"context_line":"    else:"},{"line_number":1142,"context_line":"        if args.share_server_id:"},{"line_number":1143,"context_line":"            raise exceptions.CommandError(\"Invalid parameter \""},{"line_number":1144,"context_line":"                                          \"--share_server_id specified.\")"},{"line_number":1145,"context_line":"        share \u003d cs.shares.manage("},{"line_number":1146,"context_line":"            args.service_host, args.protocol, args.export_path,"},{"line_number":1147,"context_line":"            driver_options\u003ddriver_options, share_type\u003dargs.share_type,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5fc1f717_2dba0dde","line":1144,"range":{"start_line":1142,"start_character":0,"end_line":1144,"end_character":73},"in_reply_to":"9fdfeff1_ff10f402","updated":"2019-03-05 17:33:42.000000000","message":"Done","commit_id":"d97c18dbf2a2ab6aba510aac0d75dd0c26e29568"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"858a6034bd4e8135b87ebf17bc48b0b1f2e5471e","unresolved":false,"context_lines":[{"line_number":1272,"context_line":"    action\u003d\"store_true\","},{"line_number":1273,"context_line":"    required\u003dFalse,"},{"line_number":1274,"context_line":"    default\u003dFalse,"},{"line_number":1275,"context_line":"    help\u003d\"Enforces the unmanage share server operation, even if the driver\""},{"line_number":1276,"context_line":"         \" does not support it.\")"},{"line_number":1277,"context_line":"def do_share_server_unmanage(cs, args):"},{"line_number":1278,"context_line":"    \"\"\"Unmanage share server (Admin only).\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_9ff528cf","line":1275,"range":{"start_line":1275,"start_character":67,"end_line":1275,"end_character":75},"updated":"2019-03-05 17:06:19.000000000","message":"back-end driver?\n\nSee gouthamr\u0027s remark previous PS.","commit_id":"d97c18dbf2a2ab6aba510aac0d75dd0c26e29568"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"7d8ab71a485f0a41309a471dc25bb1852cd7e6c4","unresolved":false,"context_lines":[{"line_number":1272,"context_line":"    action\u003d\"store_true\","},{"line_number":1273,"context_line":"    required\u003dFalse,"},{"line_number":1274,"context_line":"    default\u003dFalse,"},{"line_number":1275,"context_line":"    help\u003d\"Enforces the unmanage share server operation, even if the driver\""},{"line_number":1276,"context_line":"         \" does not support it.\")"},{"line_number":1277,"context_line":"def do_share_server_unmanage(cs, args):"},{"line_number":1278,"context_line":"    \"\"\"Unmanage share server (Admin only).\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"5fc1f717_0daab184","line":1275,"range":{"start_line":1275,"start_character":67,"end_line":1275,"end_character":75},"in_reply_to":"9fdfeff1_9ff528cf","updated":"2019-03-05 17:33:42.000000000","message":"Thanks! I missed it.","commit_id":"d97c18dbf2a2ab6aba510aac0d75dd0c26e29568"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"66a07e79cf57898e0365fc3955caa8dc026a4918","unresolved":false,"context_lines":[{"line_number":1126,"context_line":"    default\u003dNone,"},{"line_number":1127,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":1128,"context_line":"    help\u003d\"Share server associated with share when using a share type with \""},{"line_number":1129,"context_line":"         \"\u0027driver_handles_share_servers\u0027 extra_spec enabled. Available only \""},{"line_number":1130,"context_line":"         \"for microversion \u003e\u003d 2.49. (Default\u003dNone)\")"},{"line_number":1131,"context_line":"def do_manage(cs, args):"},{"line_number":1132,"context_line":"    \"\"\"Manage share not handled by Manila (Admin only).\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_b69de967","line":1129,"range":{"start_line":1129,"start_character":52,"end_line":1129,"end_character":59},"updated":"2019-03-06 00:23:33.000000000","message":"set to True","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f0f001c71dedd392790aae490ecb05cf3e483a20","unresolved":false,"context_lines":[{"line_number":1126,"context_line":"    default\u003dNone,"},{"line_number":1127,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":1128,"context_line":"    help\u003d\"Share server associated with share when using a share type with \""},{"line_number":1129,"context_line":"         \"\u0027driver_handles_share_servers\u0027 extra_spec enabled. Available only \""},{"line_number":1130,"context_line":"         \"for microversion \u003e\u003d 2.49. (Default\u003dNone)\")"},{"line_number":1131,"context_line":"def do_manage(cs, args):"},{"line_number":1132,"context_line":"    \"\"\"Manage share not handled by Manila (Admin only).\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_39dc8a45","line":1129,"range":{"start_line":1129,"start_character":52,"end_line":1129,"end_character":59},"in_reply_to":"5fc1f717_b69de967","updated":"2019-03-06 14:03:59.000000000","message":"Done","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"66a07e79cf57898e0365fc3955caa8dc026a4918","unresolved":false,"context_lines":[{"line_number":1131,"context_line":"def do_manage(cs, args):"},{"line_number":1132,"context_line":"    \"\"\"Manage share not handled by Manila (Admin only).\"\"\""},{"line_number":1133,"context_line":"    driver_options \u003d _extract_key_value_options(args, \u0027driver_options\u0027)"},{"line_number":1134,"context_line":"    if cs.api_version.matches(api_versions.APIVersion(\"2.49\"),"},{"line_number":1135,"context_line":"                              api_versions.APIVersion()):"},{"line_number":1136,"context_line":"        share \u003d cs.shares.manage("},{"line_number":1137,"context_line":"            args.service_host, args.protocol, args.export_path,"},{"line_number":1138,"context_line":"            driver_options\u003ddriver_options, share_type\u003dargs.share_type,"},{"line_number":1139,"context_line":"            name\u003dargs.name, description\u003dargs.description,"},{"line_number":1140,"context_line":"            is_public\u003dargs.public, share_server_id\u003dargs.share_server_id)"},{"line_number":1141,"context_line":"    else:"},{"line_number":1142,"context_line":"        if args.share_server_id:"},{"line_number":1143,"context_line":"            raise exceptions.CommandError(\"Invalid parameter \""},{"line_number":1144,"context_line":"                                          \"--share_server_id specified. This\""},{"line_number":1145,"context_line":"                                          \" parameter is only supported on\""},{"line_number":1146,"context_line":"                                          \" microversion 2.49 or newer.\")"},{"line_number":1147,"context_line":"        share \u003d cs.shares.manage("},{"line_number":1148,"context_line":"            args.service_host, args.protocol, args.export_path,"},{"line_number":1149,"context_line":"            driver_options\u003ddriver_options, share_type\u003dargs.share_type,"},{"line_number":1150,"context_line":"            name\u003dargs.name, description\u003dargs.description,"},{"line_number":1151,"context_line":"            is_public\u003dargs.public)"},{"line_number":1152,"context_line":"    _print_share(cs, share)"},{"line_number":1153,"context_line":""},{"line_number":1154,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_365b3988","line":1151,"range":{"start_line":1134,"start_character":0,"end_line":1151,"end_character":34},"updated":"2019-03-06 00:23:33.000000000","message":"nit: isn\u0027t this better written like this:\n\n  if (args.share_server_id is not None and not cs.api_version.matches(api_versions.APIVersion(\"2.49\"),\n                 api_versions.APIVersion())):\n\n   raise error\n\n  share \u003d cs.shares.manage(\n            args.service_host, args.protocol, args.export_path,\n            driver_options\u003ddriver_options, share_type\u003dargs.share_type,\n            name\u003dargs.name, description\u003dargs.description,\n            is_public\u003dargs.public, share_server_id\u003dargs.share_server_id)","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f0f001c71dedd392790aae490ecb05cf3e483a20","unresolved":false,"context_lines":[{"line_number":1131,"context_line":"def do_manage(cs, args):"},{"line_number":1132,"context_line":"    \"\"\"Manage share not handled by Manila (Admin only).\"\"\""},{"line_number":1133,"context_line":"    driver_options \u003d _extract_key_value_options(args, \u0027driver_options\u0027)"},{"line_number":1134,"context_line":"    if cs.api_version.matches(api_versions.APIVersion(\"2.49\"),"},{"line_number":1135,"context_line":"                              api_versions.APIVersion()):"},{"line_number":1136,"context_line":"        share \u003d cs.shares.manage("},{"line_number":1137,"context_line":"            args.service_host, args.protocol, args.export_path,"},{"line_number":1138,"context_line":"            driver_options\u003ddriver_options, share_type\u003dargs.share_type,"},{"line_number":1139,"context_line":"            name\u003dargs.name, description\u003dargs.description,"},{"line_number":1140,"context_line":"            is_public\u003dargs.public, share_server_id\u003dargs.share_server_id)"},{"line_number":1141,"context_line":"    else:"},{"line_number":1142,"context_line":"        if args.share_server_id:"},{"line_number":1143,"context_line":"            raise exceptions.CommandError(\"Invalid parameter \""},{"line_number":1144,"context_line":"                                          \"--share_server_id specified. This\""},{"line_number":1145,"context_line":"                                          \" parameter is only supported on\""},{"line_number":1146,"context_line":"                                          \" microversion 2.49 or newer.\")"},{"line_number":1147,"context_line":"        share \u003d cs.shares.manage("},{"line_number":1148,"context_line":"            args.service_host, args.protocol, args.export_path,"},{"line_number":1149,"context_line":"            driver_options\u003ddriver_options, share_type\u003dargs.share_type,"},{"line_number":1150,"context_line":"            name\u003dargs.name, description\u003dargs.description,"},{"line_number":1151,"context_line":"            is_public\u003dargs.public)"},{"line_number":1152,"context_line":"    _print_share(cs, share)"},{"line_number":1153,"context_line":""},{"line_number":1154,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_6f455717","line":1151,"range":{"start_line":1134,"start_character":0,"end_line":1151,"end_character":34},"in_reply_to":"5fc1f717_365b3988","updated":"2019-03-06 14:03:59.000000000","message":"If do that, I get the following error, as it seems I would need to add **kwargs in v2/shares in manage methods:\n\nmanilaclient.tests.unit.v2.test_shell.ShellTest.test_manage_4\n-------------------------------------------------------------\n\nCaptured traceback:\n~~~~~~~~~~~~~~~~~~~\n    b\u0027Traceback (most recent call last):\u0027\n    b\u0027  File \"/home/ganso/manila/python-manilaclient/.tox/py3/lib/python3.5/site-packages/ddt.py\", line 145, in wrapper\u0027\n    b\u0027    return func(self, *args, **kwargs)\u0027\n    b\u0027  File \"/home/ganso/manila/python-manilaclient/manilaclient/tests/unit/v2/test_shell.py\", line 707, in test_manage\u0027\n    b\u0027    + cmd_args)\u0027\n    b\u0027  File \"/home/ganso/manila/python-manilaclient/manilaclient/tests/unit/v2/test_shell.py\", line 105, in run_command\u0027\n    b\u0027    self.shell.main(args)\u0027\n    b\u0027  File \"/home/ganso/manila/python-manilaclient/manilaclient/shell.py\", line 571, in main\u0027\n    b\u0027    args.func(self.cs, args)\u0027\n    b\u0027  File \"/home/ganso/manila/python-manilaclient/manilaclient/v2/shell.py\", line 1145, in do_manage\u0027\n    b\u0027    is_public\u003dargs.public, share_server_id\u003dargs.share_server_id)\u0027\n    b\u0027  File \"/home/ganso/manila/python-manilaclient/manilaclient/api_versions.py\", line 399, in substitution\u0027\n    b\u0027    return method.func(obj, *args, **kwargs)\u0027\n    b\"TypeError: manage() got an unexpected keyword argument \u0027share_server_id\u0027\"\n    b\u0027\u0027","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"66a07e79cf57898e0365fc3955caa8dc026a4918","unresolved":false,"context_lines":[{"line_number":1166,"context_line":"    \u0027identifier\u0027,"},{"line_number":1167,"context_line":"    metavar\u003d\u0027\u003cidentifier\u003e\u0027,"},{"line_number":1168,"context_line":"    type\u003dstr,"},{"line_number":1169,"context_line":"    help\u003d\u0027a driver-specific share server identifier required by the driver to \u0027"},{"line_number":1170,"context_line":"         \u0027manage the share server.\u0027)"},{"line_number":1171,"context_line":"@cliutils.arg("},{"line_number":1172,"context_line":"    \u0027--driver_options\u0027, \u0027--driver-options\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_76c6a119","line":1169,"range":{"start_line":1169,"start_character":10,"end_line":1169,"end_character":11},"updated":"2019-03-06 00:23:33.000000000","message":"A","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f0f001c71dedd392790aae490ecb05cf3e483a20","unresolved":false,"context_lines":[{"line_number":1166,"context_line":"    \u0027identifier\u0027,"},{"line_number":1167,"context_line":"    metavar\u003d\u0027\u003cidentifier\u003e\u0027,"},{"line_number":1168,"context_line":"    type\u003dstr,"},{"line_number":1169,"context_line":"    help\u003d\u0027a driver-specific share server identifier required by the driver to \u0027"},{"line_number":1170,"context_line":"         \u0027manage the share server.\u0027)"},{"line_number":1171,"context_line":"@cliutils.arg("},{"line_number":1172,"context_line":"    \u0027--driver_options\u0027, \u0027--driver-options\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_19cc2e88","line":1169,"range":{"start_line":1169,"start_character":10,"end_line":1169,"end_character":11},"in_reply_to":"5fc1f717_76c6a119","updated":"2019-03-06 14:03:59.000000000","message":"Done","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"66a07e79cf57898e0365fc3955caa8dc026a4918","unresolved":false,"context_lines":[{"line_number":1175,"context_line":"    metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":1176,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":1177,"context_line":"    help\u003d\u0027One or more driver-specific key\u003dvalue pairs that may be necessary to\u0027"},{"line_number":1178,"context_line":"         \u0027 manage the share server(Optional, Default\u003dNone).\u0027,"},{"line_number":1179,"context_line":"    default\u003dNone)"},{"line_number":1180,"context_line":"def do_share_server_manage(cs, args):"},{"line_number":1181,"context_line":"    \"\"\"Manage share server not handled by Manila (Admin only).\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_56d5a5b8","line":1178,"range":{"start_line":1178,"start_character":34,"end_line":1178,"end_character":35},"updated":"2019-03-06 00:23:33.000000000","message":"nit: space","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f0f001c71dedd392790aae490ecb05cf3e483a20","unresolved":false,"context_lines":[{"line_number":1175,"context_line":"    metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":1176,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":1177,"context_line":"    help\u003d\u0027One or more driver-specific key\u003dvalue pairs that may be necessary to\u0027"},{"line_number":1178,"context_line":"         \u0027 manage the share server(Optional, Default\u003dNone).\u0027,"},{"line_number":1179,"context_line":"    default\u003dNone)"},{"line_number":1180,"context_line":"def do_share_server_manage(cs, args):"},{"line_number":1181,"context_line":"    \"\"\"Manage share server not handled by Manila (Admin only).\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_b9c87a74","line":1178,"range":{"start_line":1178,"start_character":34,"end_line":1178,"end_character":35},"in_reply_to":"5fc1f717_56d5a5b8","updated":"2019-03-06 14:03:59.000000000","message":"Done","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"66a07e79cf57898e0365fc3955caa8dc026a4918","unresolved":false,"context_lines":[{"line_number":1278,"context_line":"         \"driver does not support it.\")"},{"line_number":1279,"context_line":"def do_share_server_unmanage(cs, args):"},{"line_number":1280,"context_line":"    \"\"\"Unmanage share server (Admin only).\"\"\""},{"line_number":1281,"context_line":"    for server in args.share_server:"},{"line_number":1282,"context_line":"        cs.share_servers.unmanage(server, args.force)"},{"line_number":1283,"context_line":""},{"line_number":1284,"context_line":""},{"line_number":1285,"context_line":"@api_versions.wraps(\"2.12\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_1685ddad","line":1282,"range":{"start_line":1281,"start_character":4,"end_line":1282,"end_character":53},"updated":"2019-03-06 00:23:33.000000000","message":"Don\u0027t assume there\u0027re no errors, what if we provide invalid IDs? this loop will bail out on the first invalid ID in the list.., match the loop on the snapshot-umanage below..","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f0f001c71dedd392790aae490ecb05cf3e483a20","unresolved":false,"context_lines":[{"line_number":1278,"context_line":"         \"driver does not support it.\")"},{"line_number":1279,"context_line":"def do_share_server_unmanage(cs, args):"},{"line_number":1280,"context_line":"    \"\"\"Unmanage share server (Admin only).\"\"\""},{"line_number":1281,"context_line":"    for server in args.share_server:"},{"line_number":1282,"context_line":"        cs.share_servers.unmanage(server, args.force)"},{"line_number":1283,"context_line":""},{"line_number":1284,"context_line":""},{"line_number":1285,"context_line":"@api_versions.wraps(\"2.12\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_39aa4a85","line":1282,"range":{"start_line":1281,"start_character":4,"end_line":1282,"end_character":53},"in_reply_to":"5fc1f717_1685ddad","updated":"2019-03-06 14:03:59.000000000","message":"Done","commit_id":"76f6eca24a66074599241195a932abb0211da3dd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e9e6ccbbdcdb59aa8b3018c2f7003b0cf2893d42","unresolved":false,"context_lines":[{"line_number":1288,"context_line":"            print(\"Unmanage for share server %s failed: %s\" % (server, e),"},{"line_number":1289,"context_line":"                  file\u003dsys.stderr)"},{"line_number":1290,"context_line":""},{"line_number":1291,"context_line":"        if failure_count \u003d\u003d len(args.share_server):"},{"line_number":1292,"context_line":"            raise exceptions.CommandError(\"Unable to unmanage any of the \""},{"line_number":1293,"context_line":"                                          \"specified share servers.\")"},{"line_number":1294,"context_line":""},{"line_number":1295,"context_line":""},{"line_number":1296,"context_line":"@api_versions.wraps(\"2.12\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_7d0e6ce6","line":1293,"range":{"start_line":1291,"start_character":0,"end_line":1293,"end_character":69},"updated":"2019-03-06 16:17:30.000000000","message":"wrong indent","commit_id":"a18725346f078bd7a93463605ef5b24e5102485d"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"07061d7af289d77c39550e059abe145079f2dc8b","unresolved":false,"context_lines":[{"line_number":1288,"context_line":"            print(\"Unmanage for share server %s failed: %s\" % (server, e),"},{"line_number":1289,"context_line":"                  file\u003dsys.stderr)"},{"line_number":1290,"context_line":""},{"line_number":1291,"context_line":"        if failure_count \u003d\u003d len(args.share_server):"},{"line_number":1292,"context_line":"            raise exceptions.CommandError(\"Unable to unmanage any of the \""},{"line_number":1293,"context_line":"                                          \"specified share servers.\")"},{"line_number":1294,"context_line":""},{"line_number":1295,"context_line":""},{"line_number":1296,"context_line":"@api_versions.wraps(\"2.12\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_f8626ad8","line":1293,"range":{"start_line":1291,"start_character":0,"end_line":1293,"end_character":69},"in_reply_to":"5fc1f717_7d0e6ce6","updated":"2019-03-06 16:45:42.000000000","message":"It\u0027s better style to move the indent to the left and will involve fewer checks but this is not actually incorrect logic.","commit_id":"a18725346f078bd7a93463605ef5b24e5102485d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ede4e4fff38b2417b56f684228d6d627fc803437","unresolved":false,"context_lines":[{"line_number":1288,"context_line":"            print(\"Unmanage for share server %s failed: %s\" % (server, e),"},{"line_number":1289,"context_line":"                  file\u003dsys.stderr)"},{"line_number":1290,"context_line":""},{"line_number":1291,"context_line":"        if failure_count \u003d\u003d len(args.share_server):"},{"line_number":1292,"context_line":"            raise exceptions.CommandError(\"Unable to unmanage any of the \""},{"line_number":1293,"context_line":"                                          \"specified share servers.\")"},{"line_number":1294,"context_line":""},{"line_number":1295,"context_line":""},{"line_number":1296,"context_line":"@api_versions.wraps(\"2.12\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_bd2db447","line":1293,"range":{"start_line":1291,"start_character":0,"end_line":1293,"end_character":69},"in_reply_to":"5fc1f717_7d0e6ce6","updated":"2019-03-06 16:18:29.000000000","message":"Please add a unit test for this; testing should have caught this faster than eyeballs in a review.","commit_id":"a18725346f078bd7a93463605ef5b24e5102485d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"01a01711162a3a21ad5891d51100ebfc54e1d956","unresolved":false,"context_lines":[{"line_number":1288,"context_line":"            print(\"Unmanage for share server %s failed: %s\" % (server, e),"},{"line_number":1289,"context_line":"                  file\u003dsys.stderr)"},{"line_number":1290,"context_line":""},{"line_number":1291,"context_line":"        if failure_count \u003d\u003d len(args.share_server):"},{"line_number":1292,"context_line":"            raise exceptions.CommandError(\"Unable to unmanage any of the \""},{"line_number":1293,"context_line":"                                          \"specified share servers.\")"},{"line_number":1294,"context_line":""},{"line_number":1295,"context_line":""},{"line_number":1296,"context_line":"@api_versions.wraps(\"2.12\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_9874869b","line":1293,"range":{"start_line":1291,"start_character":0,"end_line":1293,"end_character":69},"in_reply_to":"5fc1f717_bd2db447","updated":"2019-03-06 16:45:12.000000000","message":"Ignore the comment about the failure, guess you can;t fail because there\u0027s a condition here that checks for the length of the share server. Could you please add a unit test?","commit_id":"a18725346f078bd7a93463605ef5b24e5102485d"}],"releasenotes/notes/manage-unmanage-share-servers-8c7b27a1fe80e5fa.yaml":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"858a6034bd4e8135b87ebf17bc48b0b1f2e5471e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added CLI commands to manage and unmanage share servers."},{"line_number":4,"context_line":"  - Updated CLI command for managing shares to accept"},{"line_number":5,"context_line":"    share_server_id parameter."},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fdfeff1_bfd6ec52","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":21},"updated":"2019-03-05 17:06:19.000000000","message":"nit: ``share_server_id``","commit_id":"d97c18dbf2a2ab6aba510aac0d75dd0c26e29568"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"7d8ab71a485f0a41309a471dc25bb1852cd7e6c4","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added CLI commands to manage and unmanage share servers."},{"line_number":4,"context_line":"  - Updated CLI command for managing shares to accept"},{"line_number":5,"context_line":"    share_server_id parameter."},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5fc1f717_cde5890c","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":21},"in_reply_to":"9fdfeff1_bfd6ec52","updated":"2019-03-05 17:33:42.000000000","message":"Done","commit_id":"d97c18dbf2a2ab6aba510aac0d75dd0c26e29568"}]}