)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29958,"name":"Soledad Kuczala","email":"sol.kuczala@gmail.com","username":"SolKuczala"},"change_message_id":"4c389daeac3587b1e84dae2fea2c0884d46e91ed","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add an OSC plugin for manila, the subcommand"},{"line_number":10,"context_line":"chosen is \"share\". Add initials commands parser"},{"line_number":11,"context_line":"for creating, deleteing, listing and showing shares."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also initializes basic unit testing structure for"},{"line_number":14,"context_line":"the added commands."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"3fa7e38b_7c12ef0b","line":11,"updated":"2019-10-02 10:04:28.000000000","message":"Hi all, As soon as I get my new laptop I\u0027m going to return to this project","commit_id":"b98485ec9c02d5f114fbca85c590f7998444cae6"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"acf0f51b877b2093429c504627ea19b8bb990762","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add an OSC plugin for manila, the subcommand"},{"line_number":10,"context_line":"chosen is \"share\". Add initials commands parser"},{"line_number":11,"context_line":"for creating, deleteing, listing and showing shares."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also initializes basic unit testing structure for"},{"line_number":14,"context_line":"the added commands."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"3fa7e38b_dfc3d537","line":11,"in_reply_to":"3fa7e38b_7c12ef0b","updated":"2019-10-02 11:19:38.000000000","message":"Hurray!","commit_id":"b98485ec9c02d5f114fbca85c590f7998444cae6"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"5613db849b3cb2ed99d40c6ba4f4675dc6bcb015","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[OSC] Init OpenStack Client implementation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add an OSC plugin for manila, the subcommand"},{"line_number":10,"context_line":"chosen is \"share\". Add initials commands parser"},{"line_number":11,"context_line":"for create, delete, list and show shares."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also initializes basic unit testing structure for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":30,"id":"3fa7e38b_cf8407b4","line":10,"range":{"start_line":10,"start_character":23,"end_line":10,"end_character":40},"updated":"2019-11-20 14:13:40.000000000","message":"initial commands","commit_id":"be8e0dc12097ac540dd6048e8d36f51c780c053f"}],"manilaclient/common/cliutils.py":[{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"5613db849b3cb2ed99d40c6ba4f4675dc6bcb015","unresolved":false,"context_lines":[{"line_number":271,"context_line":"    sys.exit(1)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"def _transform_export_locations_to_string_view(export_locations):"},{"line_number":275,"context_line":"    export_locations_string_view \u003d \u0027\u0027"},{"line_number":276,"context_line":"    replica_export_location_ignored_keys \u003d ("},{"line_number":277,"context_line":"        \u0027replica_state\u0027, \u0027availability_zone\u0027, \u0027share_replica_id\u0027)"}],"source_content_type":"text/x-python","patch_set":30,"id":"3fa7e38b_1e130f03","line":274,"range":{"start_line":274,"start_character":4,"end_line":274,"end_character":5},"updated":"2019-11-20 14:13:40.000000000","message":"This leading underscore should be removed, because this method is not \"private\" anymore.","commit_id":"be8e0dc12097ac540dd6048e8d36f51c780c053f"}],"manilaclient/osc/v2/share.py":[{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"6b934c0d658020d04e85b0d5e4a8e2e5932d68c7","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        parser.add_argument("},{"line_number":45,"context_line":"            \u0027--snapshot\u0027,"},{"line_number":46,"context_line":"            metavar\u003d\u0027\u003cshare-network-id\u003e\u0027,"},{"line_number":47,"context_line":"            help\u003d_(\u0027Filter shares created\u0027),"},{"line_number":48,"context_line":"        )"},{"line_number":49,"context_line":"        parser.add_argument("},{"line_number":50,"context_line":"            \u0027--public\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_2e0b18d6","line":47,"range":{"start_line":47,"start_character":20,"end_line":47,"end_character":41},"updated":"2019-06-13 17:50:29.000000000","message":"This message seems incomplete","commit_id":"56ccb19f94c480ead210b574b270ec30b932aa5e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4de210e233876b8e6a5e8c509e7f9ffd8316a4d6","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        parser.add_argument("},{"line_number":45,"context_line":"            \u0027--snapshot\u0027,"},{"line_number":46,"context_line":"            metavar\u003d\u0027\u003cshare-network-id\u003e\u0027,"},{"line_number":47,"context_line":"            help\u003d_(\u0027Filter shares by snapshot name or id\u0027),"},{"line_number":48,"context_line":"        )"},{"line_number":49,"context_line":"        parser.add_argument("},{"line_number":50,"context_line":"            \u0027--public\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_a225a1ad","line":47,"range":{"start_line":47,"start_character":34,"end_line":47,"end_character":56},"updated":"2019-06-18 03:38:06.000000000","message":"Great, thanks Sol!","commit_id":"8abb4ad7d848c25637197bfd5c6550cd1de61d49"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a8e3977ed7be0709e5113cc560777862550b24c5","unresolved":false,"context_lines":[{"line_number":148,"context_line":"            oscutils.env(\u0027ALL_PROJECTS\u0027) or"},{"line_number":149,"context_line":"            bool(parsed_args.project) or"},{"line_number":150,"context_line":"            parsed_args.all_projects)"},{"line_number":151,"context_line":"        share_type \u003d ("},{"line_number":152,"context_line":"            cliutils.find_resource(share_client.share_types,"},{"line_number":153,"context_line":"                                   parsed_args.share_type)"},{"line_number":154,"context_line":"            if parsed_args.share_type else empty_obj)"},{"line_number":155,"context_line":"        snapshot \u003d ("},{"line_number":156,"context_line":"            cliutils.find_resource(share_client.share_snapshots,"},{"line_number":157,"context_line":"                                   parsed_args.snapshot)"},{"line_number":158,"context_line":"            if parsed_args.snapshot else empty_obj)"},{"line_number":159,"context_line":"        share_network \u003d ("},{"line_number":160,"context_line":"            cliutils.find_resource(share_client.share_networks,"},{"line_number":161,"context_line":"                                   parsed_args.share_network)"},{"line_number":162,"context_line":"            if parsed_args.share_network else empty_obj)"},{"line_number":163,"context_line":"        share_group \u003d ("},{"line_number":164,"context_line":"            cliutils.find_resource(share_client.share_groups,"},{"line_number":165,"context_line":"                                   parsed_args.share_group)"},{"line_number":166,"context_line":"            if parsed_args.share_group else empty_obj)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        search_opts \u003d {"},{"line_number":169,"context_line":"            \u0027offset\u0027: parsed_args.marker,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7faddb67_f6514c37","line":166,"range":{"start_line":151,"start_character":0,"end_line":166,"end_character":54},"updated":"2019-07-18 17:35:41.000000000","message":"See how these are input and parsed...","commit_id":"d9508f5851644ff471075c920cd225f23cd9b376"},{"author":{"_account_id":29958,"name":"Soledad Kuczala","email":"sol.kuczala@gmail.com","username":"SolKuczala"},"change_message_id":"b693b132cc459581a1a851f3e5bdb092b1ac91b4","unresolved":false,"context_lines":[{"line_number":148,"context_line":"            oscutils.env(\u0027ALL_PROJECTS\u0027) or"},{"line_number":149,"context_line":"            bool(parsed_args.project) or"},{"line_number":150,"context_line":"            parsed_args.all_projects)"},{"line_number":151,"context_line":"        share_type \u003d ("},{"line_number":152,"context_line":"            cliutils.find_resource(share_client.share_types,"},{"line_number":153,"context_line":"                                   parsed_args.share_type)"},{"line_number":154,"context_line":"            if parsed_args.share_type else empty_obj)"},{"line_number":155,"context_line":"        snapshot \u003d ("},{"line_number":156,"context_line":"            cliutils.find_resource(share_client.share_snapshots,"},{"line_number":157,"context_line":"                                   parsed_args.snapshot)"},{"line_number":158,"context_line":"            if parsed_args.snapshot else empty_obj)"},{"line_number":159,"context_line":"        share_network \u003d ("},{"line_number":160,"context_line":"            cliutils.find_resource(share_client.share_networks,"},{"line_number":161,"context_line":"                                   parsed_args.share_network)"},{"line_number":162,"context_line":"            if parsed_args.share_network else empty_obj)"},{"line_number":163,"context_line":"        share_group \u003d ("},{"line_number":164,"context_line":"            cliutils.find_resource(share_client.share_groups,"},{"line_number":165,"context_line":"                                   parsed_args.share_group)"},{"line_number":166,"context_line":"            if parsed_args.share_group else empty_obj)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        search_opts \u003d {"},{"line_number":169,"context_line":"            \u0027offset\u0027: parsed_args.marker,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7faddb67_31984e73","line":166,"range":{"start_line":151,"start_character":0,"end_line":166,"end_character":54},"in_reply_to":"7faddb67_f6514c37","updated":"2019-07-18 18:03:17.000000000","message":".. oh, ok sorry, I said nothing. Problem solved then :)","commit_id":"d9508f5851644ff471075c920cd225f23cd9b376"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a9f979a31a6b3d67dddb7ac34eb2b602bfc55bc4","unresolved":false,"context_lines":[{"line_number":359,"context_line":"            metavar\u003d\"\u003cshare\u003e\","},{"line_number":360,"context_line":"            help\u003d_(\"Name or ID of the share to delete\")"},{"line_number":361,"context_line":"        )"},{"line_number":362,"context_line":"        parser.add_argument("},{"line_number":363,"context_line":"            \"--share-group\","},{"line_number":364,"context_line":"            metavar\u003d\"\u003cshare-group\u003e\","},{"line_number":365,"context_line":"            default\u003dNone,"},{"line_number":366,"context_line":"            help\u003d_(\"Name or ID of the share to delete\")"},{"line_number":367,"context_line":"        )"},{"line_number":368,"context_line":"        return parser"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_9dc5690d","line":367,"range":{"start_line":362,"start_character":0,"end_line":367,"end_character":9},"updated":"2019-07-22 21:23:43.000000000","message":"you\u0027ll add another argument here:\n\n parser.add_argument(\n            \"--force\",\n            metavar\u003d\"\u003cforce\u003e\",\n            default\u003dNone,\n            help\u003d_(\"Attempt to force the share deletion (Privileged users only)\")\n        )","commit_id":"58dc519f84dbd99655d6345298371c648e086c91"},{"author":{"_account_id":29958,"name":"Soledad Kuczala","email":"sol.kuczala@gmail.com","username":"SolKuczala"},"change_message_id":"7b0ea49adfd0eb2b97317c420aaec2294718f1b7","unresolved":false,"context_lines":[{"line_number":367,"context_line":"        )"},{"line_number":368,"context_line":"        return parser"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    def take_action(self, parsed_args):"},{"line_number":371,"context_line":"        #do I need to show the succesful delete and warnings?"},{"line_number":372,"context_line":"        self.log.debug(\"take_action(%s)\", parsed_args)"},{"line_number":373,"context_line":"        share_client \u003d self.app.client_manager.share"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_77c0e5e1","line":370,"updated":"2019-07-19 19:52:48.000000000","message":"Manila doesn\u0027t print the deleted share. I saw that Ironic prints it and also the warnings if a failure occurs. Should I do the same?","commit_id":"58dc519f84dbd99655d6345298371c648e086c91"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a9f979a31a6b3d67dddb7ac34eb2b602bfc55bc4","unresolved":false,"context_lines":[{"line_number":386,"context_line":"            share_group_id \u003d share_group.id"},{"line_number":387,"context_line":"        else:"},{"line_number":388,"context_line":"            share_group_id \u003d share_group"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"        share_client.shares.delete(share, share_group_id)"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"#don\u0027t know how to set the command on setup.cfg --force"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_9deec989","line":389,"range":{"start_line":389,"start_character":0,"end_line":389,"end_character":0},"updated":"2019-07-22 21:23:43.000000000","message":"if \"force\" has been provided and is True, call share_client.shares.force_delete instead of share_client.shares.delete","commit_id":"58dc519f84dbd99655d6345298371c648e086c91"},{"author":{"_account_id":29958,"name":"Soledad Kuczala","email":"sol.kuczala@gmail.com","username":"SolKuczala"},"change_message_id":"7b0ea49adfd0eb2b97317c420aaec2294718f1b7","unresolved":false,"context_lines":[{"line_number":427,"context_line":"#    def take_action(self, parsed_args):"},{"line_number":428,"context_line":"#        self.log.debug(\"take_action(%s)\", parsed_args)"},{"line_number":429,"context_line":"#        print(self.app.client_manager)"},{"line_number":430,"context_line":"#        share_client \u003d self.app.client_manager.shell"},{"line_number":431,"context_line":"#        data \u003d share_client.shell.do_show(parsed_args.share)"},{"line_number":432,"context_line":"#        return data"},{"line_number":433,"context_line":"        "}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_1a6758eb","line":430,"updated":"2019-07-19 19:52:48.000000000","message":"I didn\u0027t find the function for \u0027show\u0027 in shares.py. I found it in shell.py. Should I set share_client to point to shell.py?","commit_id":"58dc519f84dbd99655d6345298371c648e086c91"},{"author":{"_account_id":29958,"name":"Soledad Kuczala","email":"sol.kuczala@gmail.com","username":"SolKuczala"},"change_message_id":"7b0ea49adfd0eb2b97317c420aaec2294718f1b7","unresolved":false,"context_lines":[{"line_number":431,"context_line":"#        data \u003d share_client.shell.do_show(parsed_args.share)"},{"line_number":432,"context_line":"#        return data"},{"line_number":433,"context_line":"        "},{"line_number":434,"context_line":"class UpdateShare(command.Command):"},{"line_number":435,"context_line":"    \"\"\"Rename a share.\"\"\""},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    log \u003d logging.getLogger(__name__ + \".UpdateShare\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_3aca54a0","line":434,"updated":"2019-07-19 19:52:48.000000000","message":"It\u0027s passing the function but it\u0027s not overwriting the properties of the share.","commit_id":"58dc519f84dbd99655d6345298371c648e086c91"},{"author":{"_account_id":29958,"name":"Soledad Kuczala","email":"sol.kuczala@gmail.com","username":"SolKuczala"},"change_message_id":"c103abc4522b46fd32d2555c8c32438d7523338f","unresolved":false,"context_lines":[{"line_number":344,"context_line":"        printable_share.pop(\u0027links\u0027, None)"},{"line_number":345,"context_line":"        printable_share.pop(\u0027volume_type\u0027, None)"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"        return self.dict2columns(printable_share)"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"class DeleteShare(command.Command):"}],"source_content_type":"text/x-python","patch_set":15,"id":"7faddb67_bafe9dac","line":347,"updated":"2019-07-31 18:24:09.000000000","message":"It returns the share information in a different order than manila.","commit_id":"c6b132f475fd43f0c0f28c4705c46b2042268ed7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c8615a77cdadd6955b83e7291824fecc5ecf6afc","unresolved":false,"context_lines":[{"line_number":344,"context_line":"        printable_share.pop(\u0027links\u0027, None)"},{"line_number":345,"context_line":"        printable_share.pop(\u0027volume_type\u0027, None)"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"        return self.dict2columns(printable_share)"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"class DeleteShare(command.Command):"}],"source_content_type":"text/x-python","patch_set":15,"id":"7faddb67_fab17590","line":347,"in_reply_to":"7faddb67_bafe9dac","updated":"2019-07-31 18:33:52.000000000","message":"That should be fine","commit_id":"c6b132f475fd43f0c0f28c4705c46b2042268ed7"},{"author":{"_account_id":29958,"name":"Soledad Kuczala","email":"sol.kuczala@gmail.com","username":"SolKuczala"},"change_message_id":"c103abc4522b46fd32d2555c8c32438d7523338f","unresolved":false,"context_lines":[{"line_number":393,"context_line":""},{"line_number":394,"context_line":"        if parsed_args.force:"},{"line_number":395,"context_line":"            share_client.shares.force_delete(share)"},{"line_number":396,"context_line":"            print(\u0027Share necessarily removed successfully\u0027)"},{"line_number":397,"context_line":"        else:"},{"line_number":398,"context_line":"            share_client.shares.delete(share, share_group_id)"},{"line_number":399,"context_line":"            print(\u0027Share successfully removed\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"7faddb67_dafb59bb","line":396,"updated":"2019-07-31 18:24:09.000000000","message":"I add this, not sure if it\u0027s right or if fits.","commit_id":"c6b132f475fd43f0c0f28c4705c46b2042268ed7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c8615a77cdadd6955b83e7291824fecc5ecf6afc","unresolved":false,"context_lines":[{"line_number":393,"context_line":""},{"line_number":394,"context_line":"        if parsed_args.force:"},{"line_number":395,"context_line":"            share_client.shares.force_delete(share)"},{"line_number":396,"context_line":"            print(\u0027Share necessarily removed successfully\u0027)"},{"line_number":397,"context_line":"        else:"},{"line_number":398,"context_line":"            share_client.shares.delete(share, share_group_id)"},{"line_number":399,"context_line":"            print(\u0027Share successfully removed\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"7faddb67_1a7491ce","line":396,"in_reply_to":"7faddb67_dafb59bb","updated":"2019-07-31 18:33:52.000000000","message":"\"Share deleted successfully\" is sufficient..","commit_id":"c6b132f475fd43f0c0f28c4705c46b2042268ed7"},{"author":{"_account_id":29958,"name":"Soledad Kuczala","email":"sol.kuczala@gmail.com","username":"SolKuczala"},"change_message_id":"c103abc4522b46fd32d2555c8c32438d7523338f","unresolved":false,"context_lines":[{"line_number":424,"context_line":"        data \u003d share_client.shares.get(share)._info"},{"line_number":425,"context_line":"        data.pop(\"links\", None)"},{"line_number":426,"context_line":"        data.pop(\"volume_type\", None)"},{"line_number":427,"context_line":"        return self.dict2columns(data)"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"class SetShareProperties(command.Command):"}],"source_content_type":"text/x-python","patch_set":15,"id":"7faddb67_5a29a934","line":427,"updated":"2019-07-31 18:24:09.000000000","message":"The same thing as in Create.","commit_id":"c6b132f475fd43f0c0f28c4705c46b2042268ed7"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4e239b21e65298505bfedd3a47b4bb1f5b64ddac","unresolved":false,"context_lines":[{"line_number":182,"context_line":"            \u0027share_type_id\u0027: share_type.id,"},{"line_number":183,"context_line":"            \u0027snapshot_id\u0027: snapshot.id,"},{"line_number":184,"context_line":"            \u0027share_group_id\u0027: share_group.id,"},{"line_number":185,"context_line":"            \u0027project_id\u0027: project_id           "},{"line_number":186,"context_line":"        }"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        # TODO(gouthamr): Add support for ~name, ~description, export_location"}],"source_content_type":"text/x-python","patch_set":16,"id":"7faddb67_faf91cc7","line":185,"range":{"start_line":185,"start_character":36,"end_line":185,"end_character":47},"updated":"2019-08-06 20:23:42.000000000","message":"Please remove the trailing whitespace.","commit_id":"a6da0cae4e548a4e7ea46c832f532bc0706bd589"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4e239b21e65298505bfedd3a47b4bb1f5b64ddac","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                \u0027Share Network ID\u0027, \u0027Share Server ID\u0027, \u0027Share Type ID\u0027,"},{"line_number":206,"context_line":"                \u0027Share Group ID\u0027, \u0027Host\u0027, \u0027User ID\u0027, \u0027Project ID\u0027,"},{"line_number":207,"context_line":"                \u0027Access Rules Status\u0027, \u0027Source Snapshot ID\u0027,"},{"line_number":208,"context_line":"                \u0027Supports Creating Snapshots\u0027,\u0027Supports Cloning Snapshots\u0027,"},{"line_number":209,"context_line":"                \u0027Supports Mounting snapshots\u0027,\u0027Supports Reverting to Snapshot\u0027,"},{"line_number":210,"context_line":"                \u0027Migration Task Status\u0027,\u0027Source Share Group Snapshot Member ID\u0027,"},{"line_number":211,"context_line":"                \u0027Replication Type\u0027, \u0027Has Replicas\u0027,\u0027Created At\u0027, \u0027Properties\u0027"}],"source_content_type":"text/x-python","patch_set":16,"id":"7faddb67_ba18841d","line":208,"range":{"start_line":208,"start_character":44,"end_line":208,"end_character":47},"updated":"2019-08-06 20:23:42.000000000","message":"Please add a whitespace after \u0027,\u0027.","commit_id":"a6da0cae4e548a4e7ea46c832f532bc0706bd589"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4e239b21e65298505bfedd3a47b4bb1f5b64ddac","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                \u0027Share Group ID\u0027, \u0027Host\u0027, \u0027User ID\u0027, \u0027Project ID\u0027,"},{"line_number":207,"context_line":"                \u0027Access Rules Status\u0027, \u0027Source Snapshot ID\u0027,"},{"line_number":208,"context_line":"                \u0027Supports Creating Snapshots\u0027,\u0027Supports Cloning Snapshots\u0027,"},{"line_number":209,"context_line":"                \u0027Supports Mounting snapshots\u0027,\u0027Supports Reverting to Snapshot\u0027,"},{"line_number":210,"context_line":"                \u0027Migration Task Status\u0027,\u0027Source Share Group Snapshot Member ID\u0027,"},{"line_number":211,"context_line":"                \u0027Replication Type\u0027, \u0027Has Replicas\u0027,\u0027Created At\u0027, \u0027Properties\u0027"},{"line_number":212,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":16,"id":"7faddb67_7ad44c20","line":209,"range":{"start_line":209,"start_character":44,"end_line":209,"end_character":48},"updated":"2019-08-06 20:23:42.000000000","message":"Please add a whitespace after \u0027,\u0027.","commit_id":"a6da0cae4e548a4e7ea46c832f532bc0706bd589"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4e239b21e65298505bfedd3a47b4bb1f5b64ddac","unresolved":false,"context_lines":[{"line_number":207,"context_line":"                \u0027Access Rules Status\u0027, \u0027Source Snapshot ID\u0027,"},{"line_number":208,"context_line":"                \u0027Supports Creating Snapshots\u0027,\u0027Supports Cloning Snapshots\u0027,"},{"line_number":209,"context_line":"                \u0027Supports Mounting snapshots\u0027,\u0027Supports Reverting to Snapshot\u0027,"},{"line_number":210,"context_line":"                \u0027Migration Task Status\u0027,\u0027Source Share Group Snapshot Member ID\u0027,"},{"line_number":211,"context_line":"                \u0027Replication Type\u0027, \u0027Has Replicas\u0027,\u0027Created At\u0027, \u0027Properties\u0027"},{"line_number":212,"context_line":"            )"},{"line_number":213,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":16,"id":"7faddb67_5addd03e","line":210,"range":{"start_line":210,"start_character":37,"end_line":210,"end_character":42},"updated":"2019-08-06 20:23:42.000000000","message":"Please add a whitespace after \u0027,\u0027 and split de line because the line too long (80 \u003e 79 characters)","commit_id":"a6da0cae4e548a4e7ea46c832f532bc0706bd589"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4e239b21e65298505bfedd3a47b4bb1f5b64ddac","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                \u0027Supports Creating Snapshots\u0027,\u0027Supports Cloning Snapshots\u0027,"},{"line_number":209,"context_line":"                \u0027Supports Mounting snapshots\u0027,\u0027Supports Reverting to Snapshot\u0027,"},{"line_number":210,"context_line":"                \u0027Migration Task Status\u0027,\u0027Source Share Group Snapshot Member ID\u0027,"},{"line_number":211,"context_line":"                \u0027Replication Type\u0027, \u0027Has Replicas\u0027,\u0027Created At\u0027, \u0027Properties\u0027"},{"line_number":212,"context_line":"            )"},{"line_number":213,"context_line":"        else:"},{"line_number":214,"context_line":"            columns \u003d (\"id\", \"name\", \"size\", \"share_proto\", \"status\","}],"source_content_type":"text/x-python","patch_set":16,"id":"7faddb67_fae7dc10","line":211,"range":{"start_line":211,"start_character":47,"end_line":211,"end_character":54},"updated":"2019-08-06 20:23:42.000000000","message":"Please add a whitespace after \u0027,\u0027.","commit_id":"a6da0cae4e548a4e7ea46c832f532bc0706bd589"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4e239b21e65298505bfedd3a47b4bb1f5b64ddac","unresolved":false,"context_lines":[{"line_number":212,"context_line":"            )"},{"line_number":213,"context_line":"        else:"},{"line_number":214,"context_line":"            columns \u003d (\"id\", \"name\", \"size\", \"share_proto\", \"status\","},{"line_number":215,"context_line":"            \"is_public\", \"share_type_name\", \"availability_zone\")"},{"line_number":216,"context_line":"            column_headers \u003d (\u0027ID\u0027, \u0027Name\u0027, \u0027Size\u0027, \u0027Share Protocol\u0027, \u0027Status\u0027,"},{"line_number":217,"context_line":"            \u0027Public\u0027, \u0027Share Type Name\u0027, \u0027Availability Zone\u0027)"},{"line_number":218,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"7faddb67_9aa588b7","line":215,"range":{"start_line":215,"start_character":12,"end_line":215,"end_character":64},"updated":"2019-08-06 20:23:42.000000000","message":"Continuation line under-indented for visual indent.","commit_id":"a6da0cae4e548a4e7ea46c832f532bc0706bd589"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4e239b21e65298505bfedd3a47b4bb1f5b64ddac","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            columns \u003d (\"id\", \"name\", \"size\", \"share_proto\", \"status\","},{"line_number":215,"context_line":"            \"is_public\", \"share_type_name\", \"availability_zone\")"},{"line_number":216,"context_line":"            column_headers \u003d (\u0027ID\u0027, \u0027Name\u0027, \u0027Size\u0027, \u0027Share Protocol\u0027, \u0027Status\u0027,"},{"line_number":217,"context_line":"            \u0027Public\u0027, \u0027Share Type Name\u0027, \u0027Availability Zone\u0027)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        data \u003d share_client.shares.list(search_opts\u003dsearch_opts)"},{"line_number":220,"context_line":"        data \u003d oscutils.sort_items(data, parsed_args.sort, str)"}],"source_content_type":"text/x-python","patch_set":16,"id":"7faddb67_3aa8148a","line":217,"range":{"start_line":217,"start_character":12,"end_line":217,"end_character":61},"updated":"2019-08-06 20:23:42.000000000","message":"Continuation line under-indented for visual indent.","commit_id":"a6da0cae4e548a4e7ea46c832f532bc0706bd589"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4e239b21e65298505bfedd3a47b4bb1f5b64ddac","unresolved":false,"context_lines":[{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        data \u003d share_client.shares.list(search_opts\u003dsearch_opts)"},{"line_number":220,"context_line":"        data \u003d oscutils.sort_items(data, parsed_args.sort, str)"},{"line_number":221,"context_line":"        "},{"line_number":222,"context_line":"        return (column_headers,(oscutils.get_item_properties"},{"line_number":223,"context_line":"                (s, columns, formatters\u003d{\u0027metadata\u0027: oscutils.format_dict"},{"line_number":224,"context_line":"                                        },)for s in data))"}],"source_content_type":"text/x-python","patch_set":16,"id":"7faddb67_1a919852","line":221,"range":{"start_line":221,"start_character":0,"end_line":221,"end_character":8},"updated":"2019-08-06 20:23:42.000000000","message":"Blank line contains whitespace.","commit_id":"a6da0cae4e548a4e7ea46c832f532bc0706bd589"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4e239b21e65298505bfedd3a47b4bb1f5b64ddac","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        data \u003d share_client.shares.list(search_opts\u003dsearch_opts)"},{"line_number":220,"context_line":"        data \u003d oscutils.sort_items(data, parsed_args.sort, str)"},{"line_number":221,"context_line":"        "},{"line_number":222,"context_line":"        return (column_headers,(oscutils.get_item_properties"},{"line_number":223,"context_line":"                (s, columns, formatters\u003d{\u0027metadata\u0027: oscutils.format_dict"},{"line_number":224,"context_line":"                                        },)for s in data))"},{"line_number":225,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"7faddb67_fa7efc16","line":222,"range":{"start_line":222,"start_character":30,"end_line":222,"end_character":33},"updated":"2019-08-06 20:23:42.000000000","message":"missing whitespace after \u0027,\u0027","commit_id":"a6da0cae4e548a4e7ea46c832f532bc0706bd589"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4e239b21e65298505bfedd3a47b4bb1f5b64ddac","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        data \u003d oscutils.sort_items(data, parsed_args.sort, str)"},{"line_number":221,"context_line":"        "},{"line_number":222,"context_line":"        return (column_headers,(oscutils.get_item_properties"},{"line_number":223,"context_line":"                (s, columns, formatters\u003d{\u0027metadata\u0027: oscutils.format_dict"},{"line_number":224,"context_line":"                                        },)for s in data))"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"class CreateShare(command.ShowOne):"}],"source_content_type":"text/x-python","patch_set":16,"id":"7faddb67_1a7af822","line":224,"range":{"start_line":223,"start_character":16,"end_line":224,"end_character":58},"updated":"2019-08-06 20:23:42.000000000","message":"Closing bracket does not match visual indentation.","commit_id":"a6da0cae4e548a4e7ea46c832f532bc0706bd589"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4e239b21e65298505bfedd3a47b4bb1f5b64ddac","unresolved":false,"context_lines":[{"line_number":252,"context_line":"            \u0027--snapshot-id\u0027,"},{"line_number":253,"context_line":"            metavar\u003d\"\u003csnapshot-id\u003e\","},{"line_number":254,"context_line":"            default\u003dNone,"},{"line_number":255,"context_line":"            help\u003d_(\"Optional snapshot ID to create the share from.(Default\u003dNone)\")"},{"line_number":256,"context_line":"        )"},{"line_number":257,"context_line":"        parser.add_argument("},{"line_number":258,"context_line":"            \u0027--metadata\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"7faddb67_ba740437","line":255,"range":{"start_line":255,"start_character":0,"end_line":255,"end_character":82},"updated":"2019-08-06 20:23:42.000000000","message":"line too long (82 \u003e 79 characters)","commit_id":"a6da0cae4e548a4e7ea46c832f532bc0706bd589"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4e239b21e65298505bfedd3a47b4bb1f5b64ddac","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        parser.add_argument("},{"line_number":276,"context_line":"            \u0027--public\u0027,"},{"line_number":277,"context_line":"            default\u003dFalse,"},{"line_number":278,"context_line":"            help\u003d_(\u0027Level of visibility for share. Defines whether other tenants are able to see it or not.\u0027)"},{"line_number":279,"context_line":"        )"},{"line_number":280,"context_line":"        parser.add_argument("},{"line_number":281,"context_line":"            \u0027--share-type\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"7faddb67_7a90cc43","line":278,"range":{"start_line":278,"start_character":12,"end_line":278,"end_character":109},"updated":"2019-08-06 20:23:42.000000000","message":"line too long (109 \u003e 79 characters)","commit_id":"a6da0cae4e548a4e7ea46c832f532bc0706bd589"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4e239b21e65298505bfedd3a47b4bb1f5b64ddac","unresolved":false,"context_lines":[{"line_number":281,"context_line":"            \u0027--share-type\u0027,"},{"line_number":282,"context_line":"            metavar\u003d\u0027\u003cshare-type\u003e\u0027,"},{"line_number":283,"context_line":"            default\u003dNone,"},{"line_number":284,"context_line":"            help\u003d_(\u0027Optional share type. Use of optional volume type is deprecated. (Default\u003dDefault)\u0027)"},{"line_number":285,"context_line":"        )"},{"line_number":286,"context_line":"        parser.add_argument("},{"line_number":287,"context_line":"            \u0027--availability-zone\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"7faddb67_3a96d43f","line":284,"range":{"start_line":284,"start_character":12,"end_line":284,"end_character":103},"updated":"2019-08-06 20:23:42.000000000","message":"line too long (103 \u003e 79 characters)","commit_id":"a6da0cae4e548a4e7ea46c832f532bc0706bd589"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4e239b21e65298505bfedd3a47b4bb1f5b64ddac","unresolved":false,"context_lines":[{"line_number":293,"context_line":"            \u0027--share-group\u0027,"},{"line_number":294,"context_line":"            metavar\u003d\u0027\u003cshare-group\u003e\u0027,"},{"line_number":295,"context_line":"            default\u003dNone,"},{"line_number":296,"context_line":"            help\u003d_(\u0027Optional share group name or ID in which to create the share (Experimental, Default\u003dNone).\u0027)"},{"line_number":297,"context_line":"        )"},{"line_number":298,"context_line":"        return parser"},{"line_number":299,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"7faddb67_1a9f5850","line":296,"range":{"start_line":296,"start_character":12,"end_line":296,"end_character":112},"updated":"2019-08-06 20:23:42.000000000","message":"line too long (112 \u003e 79 characters)","commit_id":"a6da0cae4e548a4e7ea46c832f532bc0706bd589"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4e239b21e65298505bfedd3a47b4bb1f5b64ddac","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        return parser"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    def take_action(self, parsed_args):"},{"line_number":301,"context_line":"        #TODO(s0ru) :the table shows \u0027Field\u0027, \u0027Value\u0027"},{"line_number":302,"context_line":"        self.log.debug(\"take_action(%s)\", parsed_args)"},{"line_number":303,"context_line":"        empty_obj \u003d type(\u0027Empty\u0027, (object,), {\u0027id\u0027: None})"},{"line_number":304,"context_line":"        share_client \u003d self.app.client_manager.share"}],"source_content_type":"text/x-python","patch_set":16,"id":"7faddb67_7ab9acc9","line":301,"range":{"start_line":301,"start_character":8,"end_line":301,"end_character":53},"updated":"2019-08-06 20:23:42.000000000","message":"block comment should start with \u0027# \u0027","commit_id":"a6da0cae4e548a4e7ea46c832f532bc0706bd589"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4e239b21e65298505bfedd3a47b4bb1f5b64ddac","unresolved":false,"context_lines":[{"line_number":317,"context_line":"            if parsed_args.share_network else empty_obj)"},{"line_number":318,"context_line":"        share_group \u003d ("},{"line_number":319,"context_line":"            cliutils.find_resource(share_client.share_groups,"},{"line_number":320,"context_line":"                                    parsed_args.share_group)"},{"line_number":321,"context_line":"            if parsed_args.share_group else empty_obj)"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        parsed_args.share_metadata \u003d (parsed_args.metadata"}],"source_content_type":"text/x-python","patch_set":16,"id":"7faddb67_3aafb47d","line":320,"range":{"start_line":320,"start_character":35,"end_line":320,"end_character":36},"updated":"2019-08-06 20:23:42.000000000","message":"continuation line over-indented for visual indent","commit_id":"a6da0cae4e548a4e7ea46c832f532bc0706bd589"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4e239b21e65298505bfedd3a47b4bb1f5b64ddac","unresolved":false,"context_lines":[{"line_number":321,"context_line":"            if parsed_args.share_group else empty_obj)"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        parsed_args.share_metadata \u003d (parsed_args.metadata"},{"line_number":324,"context_line":"        if parsed_args.metadata is not None else dict())"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"        body \u003d {"},{"line_number":327,"context_line":"            \u0027share_proto\u0027: parsed_args.share_proto,"}],"source_content_type":"text/x-python","patch_set":16,"id":"7faddb67_bac2c432","line":324,"range":{"start_line":324,"start_character":8,"end_line":324,"end_character":56},"updated":"2019-08-06 20:23:42.000000000","message":"continuation line under-indented for visual indent","commit_id":"a6da0cae4e548a4e7ea46c832f532bc0706bd589"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4e239b21e65298505bfedd3a47b4bb1f5b64ddac","unresolved":false,"context_lines":[{"line_number":368,"context_line":"            \"--force\","},{"line_number":369,"context_line":"            default\u003dNone,"},{"line_number":370,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":371,"context_line":"            help\u003d_(\"Attempt to force the share deletion (Privileged users only)\")"},{"line_number":372,"context_line":"        )"},{"line_number":373,"context_line":"        return parser"},{"line_number":374,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"7faddb67_9ae108d3","line":371,"range":{"start_line":371,"start_character":12,"end_line":371,"end_character":81},"updated":"2019-08-06 20:23:42.000000000","message":"line too long (81 \u003e 79 characters)","commit_id":"a6da0cae4e548a4e7ea46c832f532bc0706bd589"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4e239b21e65298505bfedd3a47b4bb1f5b64ddac","unresolved":false,"context_lines":[{"line_number":379,"context_line":""},{"line_number":380,"context_line":"        share \u003d ("},{"line_number":381,"context_line":"            cliutils.find_resource(share_client.shares,"},{"line_number":382,"context_line":"                                    parsed_args.share)"},{"line_number":383,"context_line":"            if parsed_args.share else empty_obj)"},{"line_number":384,"context_line":"        share_group \u003d ("},{"line_number":385,"context_line":"            cliutils.find_resource(share_client.share_groups,"}],"source_content_type":"text/x-python","patch_set":16,"id":"7faddb67_bad724ee","line":382,"range":{"start_line":382,"start_character":35,"end_line":382,"end_character":36},"updated":"2019-08-06 20:23:42.000000000","message":"continuation line over-indented for visual indent","commit_id":"a6da0cae4e548a4e7ea46c832f532bc0706bd589"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4e239b21e65298505bfedd3a47b4bb1f5b64ddac","unresolved":false,"context_lines":[{"line_number":383,"context_line":"            if parsed_args.share else empty_obj)"},{"line_number":384,"context_line":"        share_group \u003d ("},{"line_number":385,"context_line":"            cliutils.find_resource(share_client.share_groups,"},{"line_number":386,"context_line":"                                    parsed_args.share_group)"},{"line_number":387,"context_line":"            if parsed_args.share_group else empty_obj)"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        if share_group:"}],"source_content_type":"text/x-python","patch_set":16,"id":"7faddb67_dad220fd","line":386,"range":{"start_line":386,"start_character":35,"end_line":386,"end_character":36},"updated":"2019-08-06 20:23:42.000000000","message":"continuation line over-indented for visual indent","commit_id":"a6da0cae4e548a4e7ea46c832f532bc0706bd589"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4e239b21e65298505bfedd3a47b4bb1f5b64ddac","unresolved":false,"context_lines":[{"line_number":418,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":419,"context_line":"        share \u003d ("},{"line_number":420,"context_line":"            cliutils.find_resource(share_client.shares,"},{"line_number":421,"context_line":"                                    parsed_args.share)"},{"line_number":422,"context_line":"            if parsed_args.share else empty_obj)"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        data \u003d share_client.shares.get(share)._info"}],"source_content_type":"text/x-python","patch_set":16,"id":"7faddb67_fafa7c72","line":421,"range":{"start_line":421,"start_character":35,"end_line":421,"end_character":36},"updated":"2019-08-06 20:23:42.000000000","message":"continuation line over-indented for visual indent","commit_id":"a6da0cae4e548a4e7ea46c832f532bc0706bd589"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4e239b21e65298505bfedd3a47b4bb1f5b64ddac","unresolved":false,"context_lines":[{"line_number":465,"context_line":""},{"line_number":466,"context_line":"        share \u003d ("},{"line_number":467,"context_line":"            cliutils.find_resource(share_client.shares,"},{"line_number":468,"context_line":"                                    parsed_args.share)"},{"line_number":469,"context_line":"            if parsed_args.share else empty_obj)"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        properties \u003d {}"}],"source_content_type":"text/x-python","patch_set":16,"id":"7faddb67_9a2fc8f4","line":468,"range":{"start_line":468,"start_character":35,"end_line":468,"end_character":36},"updated":"2019-08-06 20:23:42.000000000","message":"continuation line over-indented for visual indent","commit_id":"a6da0cae4e548a4e7ea46c832f532bc0706bd589"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4e239b21e65298505bfedd3a47b4bb1f5b64ddac","unresolved":false,"context_lines":[{"line_number":512,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":513,"context_line":"        empty_obj \u003d type(\u0027Empty\u0027, (object,), {\u0027id\u0027: None})"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"        share \u003d (cliutils.find_resource(share_client.shares,"},{"line_number":516,"context_line":"        parsed_args.share)"},{"line_number":517,"context_line":"        if parsed_args.share else empty_obj)"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"        properties \u003d {}"}],"source_content_type":"text/x-python","patch_set":16,"id":"7faddb67_5a35d043","line":516,"range":{"start_line":515,"start_character":16,"end_line":516,"end_character":26},"updated":"2019-08-06 20:23:42.000000000","message":"continuation line over-indented for visual indent","commit_id":"a6da0cae4e548a4e7ea46c832f532bc0706bd589"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"4fcb6339790cb8ad20468bda7f1e78485990287c","unresolved":false,"context_lines":[{"line_number":262,"context_line":"                share_group_id \u003d (share_group_id if parsed_args.share_group"},{"line_number":263,"context_line":"                                  else None)"},{"line_number":264,"context_line":"                if parsed_args.force:"},{"line_number":265,"context_line":"                    share_client.shares.force_delete(share_obj.name)"},{"line_number":266,"context_line":"                else:"},{"line_number":267,"context_line":"                    share_client.shares.delete(share_obj.name,"},{"line_number":268,"context_line":"                                               share_group_id)"}],"source_content_type":"text/x-python","patch_set":26,"id":"3fa7e38b_1f23185a","line":265,"range":{"start_line":265,"start_character":62,"end_line":265,"end_character":67},"updated":"2019-10-29 13:03:58.000000000","message":"let\u0027s remove this","commit_id":"1a07e52560089dd45d7930d99292b3bc5e049b50"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"4fcb6339790cb8ad20468bda7f1e78485990287c","unresolved":false,"context_lines":[{"line_number":264,"context_line":"                if parsed_args.force:"},{"line_number":265,"context_line":"                    share_client.shares.force_delete(share_obj.name)"},{"line_number":266,"context_line":"                else:"},{"line_number":267,"context_line":"                    share_client.shares.delete(share_obj.name,"},{"line_number":268,"context_line":"                                               share_group_id)"},{"line_number":269,"context_line":"            except Exception as e:"},{"line_number":270,"context_line":"                result +\u003d 1"}],"source_content_type":"text/x-python","patch_set":26,"id":"3fa7e38b_3f285431","line":267,"range":{"start_line":267,"start_character":56,"end_line":267,"end_character":61},"updated":"2019-10-29 13:03:58.000000000","message":"let\u0027s remove this","commit_id":"1a07e52560089dd45d7930d99292b3bc5e049b50"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"1802c2d69d2d2018e3bdf6b8d5c7c1b27dc8e16f","unresolved":false,"context_lines":[{"line_number":517,"context_line":"    def take_action(self, parsed_args):"},{"line_number":518,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"        data \u003d share_client.shares.get(parsed_args.share)._info"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"        # Special mapping for columns to make the output easier to read:"},{"line_number":523,"context_line":"        # \u0027metadata\u0027 --\u003e \u0027properties\u0027"}],"source_content_type":"text/x-python","patch_set":26,"id":"3fa7e38b_e23f83b2","line":520,"range":{"start_line":520,"start_character":8,"end_line":520,"end_character":63},"updated":"2019-10-29 13:48:06.000000000","message":"-        data \u003d share_client.shares.get(parsed_args.share)._info\n+        share_obj \u003d cliutils.find_resource(\n+            share_client.shares, parsed_args.share\n+        )\n+\n+        export_locations \u003d share_client.share_export_locations.list(share_obj)\n         export_locations \u003d https://github.com/openstack/python-manilaclient/blob/master/manilaclient/v2/shell.py#L70\n         # we can factor out to some utils module, method: _transform_export_locations_to_string_view\n\n+        data \u003d share_obj._info\n+        data[\u0027export_locations\u0027] \u003d export_locations","commit_id":"1a07e52560089dd45d7930d99292b3bc5e049b50"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"5613db849b3cb2ed99d40c6ba4f4675dc6bcb015","unresolved":false,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"class DeleteShare(command.Command):"},{"line_number":227,"context_line":"    \"\"\"Delete a share\"\"\""},{"line_number":228,"context_line":"    _description \u003d _(\"Delete a share\")"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":30,"id":"3fa7e38b_fe4953b7","line":227,"updated":"2019-11-20 14:13:40.000000000","message":"missing period (.) in the docstring","commit_id":"be8e0dc12097ac540dd6048e8d36f51c780c053f"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"5613db849b3cb2ed99d40c6ba4f4675dc6bcb015","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":256,"context_line":"        result \u003d 0"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        for i in parsed_args.shares:"},{"line_number":259,"context_line":"            try:"},{"line_number":260,"context_line":"                share_obj \u003d apiutils.find_resource("},{"line_number":261,"context_line":"                    share_client.shares, i"}],"source_content_type":"text/x-python","patch_set":30,"id":"3fa7e38b_9e837f03","line":258,"range":{"start_line":258,"start_character":12,"end_line":258,"end_character":13},"updated":"2019-11-20 14:13:40.000000000","message":"nit: naming it as \u0027share\u0027 is more explicit than just \u0027i\u0027 (which sounds like an \u0027i\u0027nteger value)","commit_id":"be8e0dc12097ac540dd6048e8d36f51c780c053f"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"5613db849b3cb2ed99d40c6ba4f4675dc6bcb015","unresolved":false,"context_lines":[{"line_number":263,"context_line":"                share_group_id \u003d (share_group_id if parsed_args.share_group"},{"line_number":264,"context_line":"                                  else None)"},{"line_number":265,"context_line":"                if parsed_args.force:"},{"line_number":266,"context_line":"                    share_client.shares.force_delete(share_obj)"},{"line_number":267,"context_line":"                else:"},{"line_number":268,"context_line":"                    share_client.shares.delete(share_obj,"},{"line_number":269,"context_line":"                                               share_group_id)"}],"source_content_type":"text/x-python","patch_set":30,"id":"3fa7e38b_fea633ac","line":266,"updated":"2019-11-20 14:13:40.000000000","message":"don\u0027t we need the share_group_id when forcing delete?","commit_id":"be8e0dc12097ac540dd6048e8d36f51c780c053f"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"7d1c4c7bd55a13c06a7a99cab6383940a403e1fb","unresolved":false,"context_lines":[{"line_number":263,"context_line":"                share_group_id \u003d (share_group_id if parsed_args.share_group"},{"line_number":264,"context_line":"                                  else None)"},{"line_number":265,"context_line":"                if parsed_args.force:"},{"line_number":266,"context_line":"                    share_client.shares.force_delete(share_obj)"},{"line_number":267,"context_line":"                else:"},{"line_number":268,"context_line":"                    share_client.shares.delete(share_obj,"},{"line_number":269,"context_line":"                                               share_group_id)"}],"source_content_type":"text/x-python","patch_set":30,"id":"3fa7e38b_5dbcb1da","line":266,"in_reply_to":"3fa7e38b_19f89048","updated":"2019-12-18 01:37:39.000000000","message":"Well, empirically, \u0027openstack share delete --force \u003cshare\u003e\u0027 is working, without throwing an exception in manila-api log, when \u003cshare\u003e was created as a member of a share-group.  Without the force, we see the exception.\n\nWith --force there is a POST with \u0027force-delete\u0027 in the body rather than a DELETE:\n\nDec 18 01:22:48 ubuntu-devstack devstack@m-api.service[37916]: INFO manila.api.openstack.wsgi [None req-253ab4d6-2d95-4d45-ac63-380076533678 None None] POST http://192.168.121.86/share/v2/466f57c1d3c243e0ad24eef812453e90/shares/d655a92f-b85e-4dc6-bc46-9a41e5978f66/action\nDec 18 01:22:48 ubuntu-devstack devstack@m-api.service[37916]: DEBUG manila.api.openstack.wsgi [None req-253ab4d6-2d95-4d45-ac63-380076533678 None None] Action body: b\u0027{\"force_delete\": null}\u0027 {{(pid\u003d37918) get_method /opt/stack/manila/manila/api/openstack/wsgi.py:913}}\nDec 18 01:22:48 ubuntu-devstack devstack@m-api.service[37916]: DEBUG manila.api.openstack.wsgi [None req-253ab4d6-2d95-4d45-ac63-380076533678 None None] Action: \u0027action\u0027, calling method: Controller.__getattribute__.\u003clocals\u003e.version_select, body: {\"force_delete\": null} {{(pid\u003d37918) _process_stack /opt/stack/manila/manila/api/openstack/wsgi.py:797}}\nDec 18 01:22:48 ubuntu-devstack devstack@m-api.service[37916]: INFO manila.api.openstack.wsgi [None req-253ab4d6-2d95-4d45-ac63-380076533678 None None] http://192.168.121.86/share/v2/466f57c1d3c243e0ad24eef812453e90/shares/d655a92f-b85e-4dc6-bc46-9a41e5978f66/action returned with HTTP 202","commit_id":"be8e0dc12097ac540dd6048e8d36f51c780c053f"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"4cbb354678f5d1eb05289a8ee1af7b6670535a1c","unresolved":false,"context_lines":[{"line_number":263,"context_line":"                share_group_id \u003d (share_group_id if parsed_args.share_group"},{"line_number":264,"context_line":"                                  else None)"},{"line_number":265,"context_line":"                if parsed_args.force:"},{"line_number":266,"context_line":"                    share_client.shares.force_delete(share_obj)"},{"line_number":267,"context_line":"                else:"},{"line_number":268,"context_line":"                    share_client.shares.delete(share_obj,"},{"line_number":269,"context_line":"                                               share_group_id)"}],"source_content_type":"text/x-python","patch_set":30,"id":"3fa7e38b_19f89048","line":266,"in_reply_to":"3fa7e38b_23a0b642","updated":"2019-12-17 21:21:06.000000000","message":"Maybe gouthamr could clarify this for us. Besides that, LGTM. :-)","commit_id":"be8e0dc12097ac540dd6048e8d36f51c780c053f"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"922256909b836e068fa9b66105a78689e0ef58a5","unresolved":false,"context_lines":[{"line_number":263,"context_line":"                share_group_id \u003d (share_group_id if parsed_args.share_group"},{"line_number":264,"context_line":"                                  else None)"},{"line_number":265,"context_line":"                if parsed_args.force:"},{"line_number":266,"context_line":"                    share_client.shares.force_delete(share_obj)"},{"line_number":267,"context_line":"                else:"},{"line_number":268,"context_line":"                    share_client.shares.delete(share_obj,"},{"line_number":269,"context_line":"                                               share_group_id)"}],"source_content_type":"text/x-python","patch_set":30,"id":"3fa7e38b_23a0b642","line":266,"in_reply_to":"3fa7e38b_64b60d28","updated":"2019-11-29 09:32:15.000000000","message":"the implementation here [0] is getting the share_group from the share. Do we need to do this change here?\n\n[0] https://github.com/openstack/manila/blob/master/manila/api/v1/shares.py#L84","commit_id":"be8e0dc12097ac540dd6048e8d36f51c780c053f"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"b2e602449bbdfea1a6d355bfc2bfa05218a9734d","unresolved":false,"context_lines":[{"line_number":263,"context_line":"                share_group_id \u003d (share_group_id if parsed_args.share_group"},{"line_number":264,"context_line":"                                  else None)"},{"line_number":265,"context_line":"                if parsed_args.force:"},{"line_number":266,"context_line":"                    share_client.shares.force_delete(share_obj)"},{"line_number":267,"context_line":"                else:"},{"line_number":268,"context_line":"                    share_client.shares.delete(share_obj,"},{"line_number":269,"context_line":"                                               share_group_id)"}],"source_content_type":"text/x-python","patch_set":30,"id":"3fa7e38b_64b60d28","line":266,"in_reply_to":"3fa7e38b_85f9e0c5","updated":"2019-11-22 14:12:19.000000000","message":"Hmm should we update the force_delete method to accept the share_group param?\nI suspect that if the share has a share_group_id, and it\u0027s not passed as a request param, it would raise an exception: https://github.com/openstack/manila/blob/master/manila/api/v1/shares.py#L84","commit_id":"be8e0dc12097ac540dd6048e8d36f51c780c053f"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"c9da9f4678f2203a9783c5bb26b0461a3fbd1476","unresolved":false,"context_lines":[{"line_number":263,"context_line":"                share_group_id \u003d (share_group_id if parsed_args.share_group"},{"line_number":264,"context_line":"                                  else None)"},{"line_number":265,"context_line":"                if parsed_args.force:"},{"line_number":266,"context_line":"                    share_client.shares.force_delete(share_obj)"},{"line_number":267,"context_line":"                else:"},{"line_number":268,"context_line":"                    share_client.shares.delete(share_obj,"},{"line_number":269,"context_line":"                                               share_group_id)"}],"source_content_type":"text/x-python","patch_set":30,"id":"3fa7e38b_85f9e0c5","line":266,"in_reply_to":"3fa7e38b_fea633ac","updated":"2019-11-21 09:48:21.000000000","message":"I don\u0027t see a way of passing the share_group param here https://github.com/openstack/python-manilaclient/blob/master/manilaclient/v2/shares.py#L75-L77. For delete share yes, but for force delete no.","commit_id":"be8e0dc12097ac540dd6048e8d36f51c780c053f"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"5613db849b3cb2ed99d40c6ba4f4675dc6bcb015","unresolved":false,"context_lines":[{"line_number":504,"context_line":""},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"class ShowShare(command.ShowOne):"},{"line_number":507,"context_line":"    _description \u003d _(\"Display share details\")"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"    def get_parser(self, prog_name):"},{"line_number":510,"context_line":"        parser \u003d super(ShowShare, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":30,"id":"3fa7e38b_59aa01d2","line":507,"updated":"2019-11-20 14:13:40.000000000","message":"missing docstring (not sure if we really need it, though)","commit_id":"be8e0dc12097ac540dd6048e8d36f51c780c053f"}],"manilaclient/tests/unit/osc/v2/test_share.py":[{"author":{"_account_id":29958,"name":"Soledad Kuczala","email":"sol.kuczala@gmail.com","username":"SolKuczala"},"change_message_id":"c103abc4522b46fd32d2555c8c32438d7523338f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2010 Jacob Kaplan-Moss"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2011 OpenStack Foundation"},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":15,"id":"7faddb67_9aa641c1","line":1,"updated":"2019-07-31 18:24:09.000000000","message":"It\u0027s a WIP, but I wanted to make sure if this is the right place or/and the right way.","commit_id":"c6b132f475fd43f0c0f28c4705c46b2042268ed7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2d9835f87c0f94a5b529e482622d4833fdc375cf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2010 Jacob Kaplan-Moss"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2011 OpenStack Foundation"},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":15,"id":"7faddb67_1a5d7146","line":1,"in_reply_to":"7faddb67_9aa641c1","updated":"2019-07-31 18:35:31.000000000","message":"It\u0027s in the right place, you can remove the two copy rights here however, and just preserve the apache license..","commit_id":"c6b132f475fd43f0c0f28c4705c46b2042268ed7"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4e239b21e65298505bfedd3a47b4bb1f5b64ddac","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from manilaclient import extension"},{"line_number":22,"context_line":"from manilaclient.tests.unit import utils"},{"line_number":23,"context_line":"from manilaclient.tests.unit.v2 import fakes"},{"line_number":24,"context_line":"from manilaclient.osc.v2 import share"},{"line_number":25,"context_line":"from manilaclient.v2 import shares"},{"line_number":26,"context_line":"extensions \u003d ["},{"line_number":27,"context_line":"    extension.Extension(\u0027share\u0027, share),"}],"source_content_type":"text/x-python","patch_set":16,"id":"7faddb67_5f9f0501","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":37},"updated":"2019-08-06 20:23:42.000000000","message":"imports not in alphabetical order (manilaclient.tests.unit.v2.fakes, manilaclient.osc.v2.share).\n\nMore info: https://www.python.org/dev/peps/pep-0008/#imports","commit_id":"a6da0cae4e548a4e7ea46c832f532bc0706bd589"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4e239b21e65298505bfedd3a47b4bb1f5b64ddac","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            }"},{"line_number":130,"context_line":"        }"},{"line_number":131,"context_line":"        cs.share.CreateShare(\u0027nfs\u0027, 1, is_public\u003dis_public,"},{"line_number":132,"context_line":"                         availability_zone\u003davailability_zone)"},{"line_number":133,"context_line":"        cs.assert_called(\u0027POST\u0027, \u0027/share\u0027, body)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    @ddt.data("}],"source_content_type":"text/x-python","patch_set":16,"id":"7faddb67_ffb27193","line":132,"range":{"start_line":132,"start_character":25,"end_line":132,"end_character":61},"updated":"2019-08-06 20:23:42.000000000","message":"Continuation line under-indented for visual indent.","commit_id":"a6da0cae4e548a4e7ea46c832f532bc0706bd589"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4e239b21e65298505bfedd3a47b4bb1f5b64ddac","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        data \u003d dict(foo\u003d\u0027bar\u0027, quuz\u003d\u0027foobar\u0027)"},{"line_number":158,"context_line":"        share \u003d cs.share.update(share, **data)"},{"line_number":159,"context_line":"        cs.assert_called(\u0027PUT\u0027, \u0027/share/1234\u0027, {\u0027share\u0027: data})"},{"line_number":160,"context_line":"    # Testcases for delete class"},{"line_number":161,"context_line":"    def test_delete_share(self):"},{"line_number":162,"context_line":"        share \u003d cs.share.get(\u00271234\u0027)"},{"line_number":163,"context_line":"        cs.share.delete(share)"}],"source_content_type":"text/x-python","patch_set":16,"id":"7faddb67_7a776ca1","line":160,"range":{"start_line":160,"start_character":0,"end_line":160,"end_character":32},"updated":"2019-08-06 20:23:42.000000000","message":"1. Please leave a blank line between tests. \n2. Add the comment as a docstring inside the test \u0027test_delete_share\u0027, more info https://www.python.org/dev/peps/pep-0257/#one-line-docstrings","commit_id":"a6da0cae4e548a4e7ea46c832f532bc0706bd589"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4e239b21e65298505bfedd3a47b4bb1f5b64ddac","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        cs.share.delete(share)"},{"line_number":164,"context_line":"        cs.assert_called(\u0027DELETE\u0027, \u0027/share/1234\u0027)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    "},{"line_number":167,"context_line":"    @ddt.data("},{"line_number":168,"context_line":"        (\"2.6\", \"os-force_delete\"),"},{"line_number":169,"context_line":"        (\"2.7\", \"force_delete\"),"}],"source_content_type":"text/x-python","patch_set":16,"id":"7faddb67_3aa254fd","line":166,"range":{"start_line":166,"start_character":0,"end_line":166,"end_character":4},"updated":"2019-08-06 20:23:42.000000000","message":"The blank line contains whitespace. Please remove all the line.","commit_id":"a6da0cae4e548a4e7ea46c832f532bc0706bd589"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4e239b21e65298505bfedd3a47b4bb1f5b64ddac","unresolved":false,"context_lines":[{"line_number":205,"context_line":"              (\u0027path\u0027, \u0027fake_path\u0027, True))"},{"line_number":206,"context_line":"    @ddt.unpack"},{"line_number":207,"context_line":"    def test_list_share_index_with_export_location(self, filter_type,"},{"line_number":208,"context_line":"                                                    value, detailed):"},{"line_number":209,"context_line":"        search_opts \u003d {"},{"line_number":210,"context_line":"            \u0027export_location\u0027: value,"},{"line_number":211,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":16,"id":"7faddb67_ba8e4476","line":208,"range":{"start_line":208,"start_character":51,"end_line":208,"end_character":52},"updated":"2019-08-06 20:23:42.000000000","message":"Continuation line over-indented for visual indent. Please align.","commit_id":"a6da0cae4e548a4e7ea46c832f532bc0706bd589"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4e239b21e65298505bfedd3a47b4bb1f5b64ddac","unresolved":false,"context_lines":[{"line_number":318,"context_line":"         \u0027microversion\u0027: \u00272.38\u0027},"},{"line_number":319,"context_line":"        {\u0027access_to\u0027: \u0027test group name\u0027, \u0027access_type\u0027: \u0027user\u0027,"},{"line_number":320,"context_line":"         \u0027action_name\u0027: \u0027allow_access\u0027, \u0027microversion\u0027: \u00272.38\u0027},"},{"line_number":321,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":16,"id":"7faddb67_3a3ed48a","line":321,"range":{"start_line":321,"start_character":5,"end_line":321,"end_character":5},"updated":"2019-08-06 20:23:42.000000000","message":"Please add a blank line at end of the file.","commit_id":"a6da0cae4e548a4e7ea46c832f532bc0706bd589"}],"setup.cfg":[{"author":{"_account_id":29958,"name":"Soledad Kuczala","email":"sol.kuczala@gmail.com","username":"SolKuczala"},"change_message_id":"7b0ea49adfd0eb2b97317c420aaec2294718f1b7","unresolved":false,"context_lines":[{"line_number":41,"context_line":"openstack.share.v2 \u003d"},{"line_number":42,"context_line":"    share_list \u003d manilaclient.osc.v2.share:ListShare"},{"line_number":43,"context_line":"    share_create \u003d manilaclient.osc.v2.share:CreateShare"},{"line_number":44,"context_line":"    share_delete \u003d  manilaclient.osc.v2.share:DeleteShare"},{"line_number":45,"context_line":"    share_show \u003d manilaclient.osc.v2.share:ShowShare"},{"line_number":46,"context_line":"    share_update \u003d manilaclient.osc.v2.share:UpdateShare"},{"line_number":47,"context_line":"[wheel]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"7faddb67_fa759c64","line":44,"updated":"2019-07-19 19:52:48.000000000","message":"I don\u0027t know how to add optional argument \u0027--force\u0027 to the delete command defined here.","commit_id":"58dc519f84dbd99655d6345298371c648e086c91"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a9f979a31a6b3d67dddb7ac34eb2b602bfc55bc4","unresolved":false,"context_lines":[{"line_number":41,"context_line":"openstack.share.v2 \u003d"},{"line_number":42,"context_line":"    share_list \u003d manilaclient.osc.v2.share:ListShare"},{"line_number":43,"context_line":"    share_create \u003d manilaclient.osc.v2.share:CreateShare"},{"line_number":44,"context_line":"    share_delete \u003d  manilaclient.osc.v2.share:DeleteShare"},{"line_number":45,"context_line":"    share_show \u003d manilaclient.osc.v2.share:ShowShare"},{"line_number":46,"context_line":"    share_update \u003d manilaclient.osc.v2.share:UpdateShare"},{"line_number":47,"context_line":"[wheel]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"7faddb67_7d5f4d72","line":44,"in_reply_to":"7faddb67_fa759c64","updated":"2019-07-22 21:23:43.000000000","message":"You don\u0027t need to; the share_delete controller must handle the optional argument.","commit_id":"58dc519f84dbd99655d6345298371c648e086c91"}]}