)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"02d16a43d058ace5154991755bc6c06d9e101d39","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Also renamed a few variables to make code more readable."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Added \"latest\" as a possible version name in api_versions"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"bp/switch-to-keystoneauth"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"5faad753_99aaf9cf","line":49,"range":{"start_line":49,"start_character":0,"end_line":49,"end_character":57},"updated":"2019-09-12 06:28:29.000000000","message":"\"latest\" isn\u0027t a valid Manila API microversion.","commit_id":"199acfc3c2eb4c9b0cb2204e5c9724548ee66d7b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e4cae8f42af15232d0edfaafb41229019d0d74d2","unresolved":true,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Added \"latest\" as a possible version name in api_versions"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"bp/switch-to-keystoneauth"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Change-Id: Ida8991ad04660bcd2cd8a34b7a45772b992c8056"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":37,"id":"d38746d8_d8761a04","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":2},"updated":"2021-02-11 01:57:45.000000000","message":"Implements:","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"636d9ff182b1ab8077e3ebbb65d05b6b92891449","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Added \"latest\" as a possible version name in api_versions"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"bp/switch-to-keystoneauth"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Change-Id: Ida8991ad04660bcd2cd8a34b7a45772b992c8056"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":37,"id":"59f55426_130f143b","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":2},"in_reply_to":"d38746d8_d8761a04","updated":"2022-07-08 14:37:58.000000000","message":"Done","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f32a5363934f98308eefe89bea1f9f5215a4db54","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":40,"id":"50f87f3b_23e0328a","updated":"2026-01-30 21:17:06.000000000","message":"LGTM, thanks for working on this change, Goutham. I would like to spend some time to do some peer testing on this, to help us ensure everything is in place","commit_id":"eb256137411313f3ac3fb640a9dcfb0cb17e5924"}],"manilaclient/common/httpclient.py":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@canonical.com","username":"toabctl"},"change_message_id":"3fa856228e23052bba13881cdc4f21848c251909","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        \u0027endpoint_url\u0027,"},{"line_number":53,"context_line":"        message\u003d\"Please use \u0027endpoint_override\u0027 instead\","},{"line_number":54,"context_line":"        removal_version\u003d\u00272.0.0\u0027)"},{"line_number":55,"context_line":"    def __init__(self, endpoint_override, token, user_agent, api_version,"},{"line_number":56,"context_line":"                 insecure\u003dFalse, cacert\u003dNone, timeout\u003dNone, retries\u003dNone,"},{"line_number":57,"context_line":"                 http_log_debug\u003dFalse, endpoint_url\u003dNone):"},{"line_number":58,"context_line":"        self.endpoint_url \u003d endpoint_url or endpoint_override"}],"source_content_type":"text/x-python","patch_set":8,"id":"ffb9cba7_9bab1bd5","line":55,"updated":"2019-04-23 06:57:25.000000000","message":"This changes the API (the positional args have now a different order)","commit_id":"640d08103831288e5eaf195215d1928b5585b6be"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e4cae8f42af15232d0edfaafb41229019d0d74d2","unresolved":true,"context_lines":[{"line_number":62,"context_line":"        \u0027endpoint_url\u0027,"},{"line_number":63,"context_line":"        message\u003d\"Please use \u0027endpoint_override\u0027 instead\","},{"line_number":64,"context_line":"        removal_version\u003d\u00272.0.0\u0027)"},{"line_number":65,"context_line":"    def __init__(self,"},{"line_number":66,"context_line":"                 endpoint_url\u003dNone,"},{"line_number":67,"context_line":"                 token\u003dNone,"},{"line_number":68,"context_line":"                 user_agent\u003dNone,"},{"line_number":69,"context_line":"                 api_version\u003dNone,"},{"line_number":70,"context_line":"                 insecure\u003dFalse,"},{"line_number":71,"context_line":"                 cacert\u003dNone,"},{"line_number":72,"context_line":"                 timeout\u003dNone,"},{"line_number":73,"context_line":"                 retries\u003dNone,"},{"line_number":74,"context_line":"                 http_log_debug\u003dFalse,"},{"line_number":75,"context_line":"                 endpoint_override\u003dNone):"},{"line_number":76,"context_line":"        self.endpoint_url \u003d endpoint_url or endpoint_override"},{"line_number":77,"context_line":"        self.base_url \u003d self._get_base_url(self.endpoint_url)"},{"line_number":78,"context_line":"        self.retries \u003d int(retries or 0)"}],"source_content_type":"text/x-python","patch_set":37,"id":"36f577e5_5f913170","line":75,"range":{"start_line":65,"start_character":4,"end_line":75,"end_character":41},"updated":"2021-02-11 01:57:45.000000000","message":"Noone should be using this class directly, no need to maintain deprecation","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"636d9ff182b1ab8077e3ebbb65d05b6b92891449","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        \u0027endpoint_url\u0027,"},{"line_number":63,"context_line":"        message\u003d\"Please use \u0027endpoint_override\u0027 instead\","},{"line_number":64,"context_line":"        removal_version\u003d\u00272.0.0\u0027)"},{"line_number":65,"context_line":"    def __init__(self,"},{"line_number":66,"context_line":"                 endpoint_url\u003dNone,"},{"line_number":67,"context_line":"                 token\u003dNone,"},{"line_number":68,"context_line":"                 user_agent\u003dNone,"},{"line_number":69,"context_line":"                 api_version\u003dNone,"},{"line_number":70,"context_line":"                 insecure\u003dFalse,"},{"line_number":71,"context_line":"                 cacert\u003dNone,"},{"line_number":72,"context_line":"                 timeout\u003dNone,"},{"line_number":73,"context_line":"                 retries\u003dNone,"},{"line_number":74,"context_line":"                 http_log_debug\u003dFalse,"},{"line_number":75,"context_line":"                 endpoint_override\u003dNone):"},{"line_number":76,"context_line":"        self.endpoint_url \u003d endpoint_url or endpoint_override"},{"line_number":77,"context_line":"        self.base_url \u003d self._get_base_url(self.endpoint_url)"},{"line_number":78,"context_line":"        self.retries \u003d int(retries or 0)"}],"source_content_type":"text/x-python","patch_set":37,"id":"abc81816_850ed643","line":75,"range":{"start_line":65,"start_character":4,"end_line":75,"end_character":41},"in_reply_to":"36f577e5_5f913170","updated":"2022-07-08 14:37:58.000000000","message":"Done","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"}],"manilaclient/v1/client.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e4cae8f42af15232d0edfaafb41229019d0d74d2","unresolved":true,"context_lines":[{"line_number":37,"context_line":"LEGACY_DEFAULT_SERVICE_TYPE \u003d constants.V1_SERVICE_TYPE"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def _load_session(auth\u003dNone,"},{"line_number":41,"context_line":"                  auth_token\u003dNone,"},{"line_number":42,"context_line":"                  auth_url\u003dNone,"},{"line_number":43,"context_line":"                  auth_type\u003dNone,"},{"line_number":44,"context_line":"                  cacert\u003dNone,"},{"line_number":45,"context_line":"                  cert\u003dNone,"},{"line_number":46,"context_line":"                  insecure\u003dFalse,"},{"line_number":47,"context_line":"                  password\u003dNone,"},{"line_number":48,"context_line":"                  project_domain_id\u003dNone,"},{"line_number":49,"context_line":"                  project_domain_name\u003dNone,"},{"line_number":50,"context_line":"                  project_id\u003dNone,"},{"line_number":51,"context_line":"                  project_name\u003dNone,"},{"line_number":52,"context_line":"                  timeout\u003dNone,"},{"line_number":53,"context_line":"                  user_agent\u003d\u0027python-manilaclient\u0027,"},{"line_number":54,"context_line":"                  user_domain_id\u003dNone,"},{"line_number":55,"context_line":"                  user_domain_name\u003dNone,"},{"line_number":56,"context_line":"                  user_id\u003dNone,"},{"line_number":57,"context_line":"                  username\u003dNone):"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    # NOTE(vkmc) auth is the auth plugin"},{"line_number":60,"context_line":"    if not auth and auth_token:"},{"line_number":61,"context_line":"        auth \u003d identity.Token(auth_url\u003dauth_url,"},{"line_number":62,"context_line":"                              token\u003dauth_token,"},{"line_number":63,"context_line":"                              project_id\u003dproject_id,"},{"line_number":64,"context_line":"                              project_name\u003dproject_name,"},{"line_number":65,"context_line":"                              project_domain_id\u003dproject_domain_id,"},{"line_number":66,"context_line":"                              project_domain_name\u003dproject_domain_name)"},{"line_number":67,"context_line":"    elif not auth:"},{"line_number":68,"context_line":"        auth \u003d identity.Password(username\u003dusername,"},{"line_number":69,"context_line":"                                 user_id\u003duser_id,"},{"line_number":70,"context_line":"                                 password\u003dpassword,"},{"line_number":71,"context_line":"                                 project_id\u003dproject_id,"},{"line_number":72,"context_line":"                                 project_name\u003dproject_name,"},{"line_number":73,"context_line":"                                 auth_url\u003dauth_url,"},{"line_number":74,"context_line":"                                 project_domain_id\u003dproject_domain_id,"},{"line_number":75,"context_line":"                                 project_domain_name\u003dproject_domain_name,"},{"line_number":76,"context_line":"                                 user_domain_id\u003duser_domain_id,"},{"line_number":77,"context_line":"                                 user_domain_name\u003duser_domain_name)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    session \u003d ksession.Session(auth\u003dauth,"},{"line_number":80,"context_line":"                               verify\u003d(cacert or not insecure),"},{"line_number":81,"context_line":"                               timeout\u003dtimeout,"},{"line_number":82,"context_line":"                               cert\u003dcert,"},{"line_number":83,"context_line":"                               user_agent\u003duser_agent)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    return session"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"def _get_endpoint(session,"},{"line_number":89,"context_line":"                  interface\u003dNone,"},{"line_number":90,"context_line":"                  region_name\u003dNone,"},{"line_number":91,"context_line":"                  service_name\u003dNone,"},{"line_number":92,"context_line":"                  service_type\u003dNone):"},{"line_number":93,"context_line":"    try:"},{"line_number":94,"context_line":"        # Trigger an auth error so that we can throw the exception"},{"line_number":95,"context_line":"        # we always have"},{"line_number":96,"context_line":"        endpoint \u003d session.get_endpoint("},{"line_number":97,"context_line":"            service_type\u003dservice_type,"},{"line_number":98,"context_line":"            service_name\u003dservice_name,"},{"line_number":99,"context_line":"            interface\u003dinterface,"},{"line_number":100,"context_line":"            region_name\u003dregion_name)"},{"line_number":101,"context_line":"    except catalog.EndpointNotFound:"},{"line_number":102,"context_line":"        service_type \u003d LEGACY_DEFAULT_SERVICE_TYPE"},{"line_number":103,"context_line":"        try:"},{"line_number":104,"context_line":"            endpoint \u003d session.get_endpoint("},{"line_number":105,"context_line":"                service_type\u003dservice_type,"},{"line_number":106,"context_line":"                service_name\u003dservice_name,"},{"line_number":107,"context_line":"                interface\u003dinterface,"},{"line_number":108,"context_line":"                region_name\u003dregion_name)"},{"line_number":109,"context_line":"        except Exception as e:"},{"line_number":110,"context_line":"            raise RuntimeError(str(e))"},{"line_number":111,"context_line":"    except Exception as e:"},{"line_number":112,"context_line":"        raise RuntimeError(str(e))"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    return endpoint"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"def _load_session_client(api_version\u003dNone,"},{"line_number":118,"context_line":"                         auth\u003dNone,"},{"line_number":119,"context_line":"                         auth_token\u003dNone,"},{"line_number":120,"context_line":"                         auth_type\u003dNone,"},{"line_number":121,"context_line":"                         auth_url\u003dNone,"},{"line_number":122,"context_line":"                         cacert\u003dNone,"},{"line_number":123,"context_line":"                         cert\u003dNone,"},{"line_number":124,"context_line":"                         endpoint_override\u003dNone,"},{"line_number":125,"context_line":"                         insecure\u003dNone,"},{"line_number":126,"context_line":"                         interface\u003dNone,"},{"line_number":127,"context_line":"                         password\u003dNone,"},{"line_number":128,"context_line":"                         project_domain_id\u003dNone,"},{"line_number":129,"context_line":"                         project_domain_name\u003dNone,"},{"line_number":130,"context_line":"                         project_id\u003dNone,"},{"line_number":131,"context_line":"                         project_name\u003dNone,"},{"line_number":132,"context_line":"                         region_name\u003dNone,"},{"line_number":133,"context_line":"                         retries\u003dNone,"},{"line_number":134,"context_line":"                         service_type\u003dNone,"},{"line_number":135,"context_line":"                         service_name\u003dNone,"},{"line_number":136,"context_line":"                         session\u003dNone,"},{"line_number":137,"context_line":"                         timeout\u003dNone,"},{"line_number":138,"context_line":"                         user_agent\u003dNone,"},{"line_number":139,"context_line":"                         user_domain_id\u003dNone,"},{"line_number":140,"context_line":"                         user_domain_name\u003dNone,"},{"line_number":141,"context_line":"                         user_id\u003dNone,"},{"line_number":142,"context_line":"                         username\u003dNone,"},{"line_number":143,"context_line":"                         **kwargs):"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    if not session:"},{"line_number":146,"context_line":"        session \u003d _load_session(auth\u003dauth,"},{"line_number":147,"context_line":"                                auth_token\u003dauth_token,"},{"line_number":148,"context_line":"                                auth_url\u003dauth_url,"},{"line_number":149,"context_line":"                                auth_type\u003dauth_type,"},{"line_number":150,"context_line":"                                cacert\u003dcacert,"},{"line_number":151,"context_line":"                                cert\u003dcert,"},{"line_number":152,"context_line":"                                insecure\u003dinsecure,"},{"line_number":153,"context_line":"                                password\u003dpassword,"},{"line_number":154,"context_line":"                                project_domain_id\u003dproject_domain_id,"},{"line_number":155,"context_line":"                                project_domain_name\u003dproject_domain_name,"},{"line_number":156,"context_line":"                                project_id\u003dproject_id,"},{"line_number":157,"context_line":"                                project_name\u003dproject_name,"},{"line_number":158,"context_line":"                                timeout\u003dtimeout,"},{"line_number":159,"context_line":"                                user_agent\u003duser_agent,"},{"line_number":160,"context_line":"                                user_domain_id\u003duser_domain_id,"},{"line_number":161,"context_line":"                                user_domain_name\u003duser_domain_name,"},{"line_number":162,"context_line":"                                user_id\u003duser_id,"},{"line_number":163,"context_line":"                                username\u003dusername)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    if not endpoint_override:"},{"line_number":166,"context_line":"        endpoint_override \u003d _get_endpoint("},{"line_number":167,"context_line":"            session,"},{"line_number":168,"context_line":"            service_type\u003dservice_type,"},{"line_number":169,"context_line":"            service_name\u003dservice_name,"},{"line_number":170,"context_line":"            interface\u003dinterface,"},{"line_number":171,"context_line":"            region_name\u003dregion_name,"},{"line_number":172,"context_line":"        )"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    return httpclient.SessionClient("},{"line_number":175,"context_line":"        session\u003dsession,"},{"line_number":176,"context_line":"        service_type\u003dservice_type,"},{"line_number":177,"context_line":"        service_name\u003dservice_name,"},{"line_number":178,"context_line":"        interface\u003dinterface,"},{"line_number":179,"context_line":"        region_name\u003dregion_name,"},{"line_number":180,"context_line":"        endpoint_override\u003dendpoint_override,"},{"line_number":181,"context_line":"        api_version\u003dapi_version,"},{"line_number":182,"context_line":"        user_agent\u003duser_agent,"},{"line_number":183,"context_line":"        retries\u003dretries)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"@removals.removed_class(\"Client\", message\u003d\"Please use \u0027v2.Client\u0027 instead\","}],"source_content_type":"text/x-python","patch_set":37,"id":"5b5000d8_5208f3d0","line":183,"range":{"start_line":40,"start_character":0,"end_line":183,"end_character":24},"updated":"2021-02-11 01:57:45.000000000","message":"This is same code that\u0027s in v2/client.py - refactor by moving it to http_client so you can reuse the code","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"636d9ff182b1ab8077e3ebbb65d05b6b92891449","unresolved":false,"context_lines":[{"line_number":37,"context_line":"LEGACY_DEFAULT_SERVICE_TYPE \u003d constants.V1_SERVICE_TYPE"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def _load_session(auth\u003dNone,"},{"line_number":41,"context_line":"                  auth_token\u003dNone,"},{"line_number":42,"context_line":"                  auth_url\u003dNone,"},{"line_number":43,"context_line":"                  auth_type\u003dNone,"},{"line_number":44,"context_line":"                  cacert\u003dNone,"},{"line_number":45,"context_line":"                  cert\u003dNone,"},{"line_number":46,"context_line":"                  insecure\u003dFalse,"},{"line_number":47,"context_line":"                  password\u003dNone,"},{"line_number":48,"context_line":"                  project_domain_id\u003dNone,"},{"line_number":49,"context_line":"                  project_domain_name\u003dNone,"},{"line_number":50,"context_line":"                  project_id\u003dNone,"},{"line_number":51,"context_line":"                  project_name\u003dNone,"},{"line_number":52,"context_line":"                  timeout\u003dNone,"},{"line_number":53,"context_line":"                  user_agent\u003d\u0027python-manilaclient\u0027,"},{"line_number":54,"context_line":"                  user_domain_id\u003dNone,"},{"line_number":55,"context_line":"                  user_domain_name\u003dNone,"},{"line_number":56,"context_line":"                  user_id\u003dNone,"},{"line_number":57,"context_line":"                  username\u003dNone):"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    # NOTE(vkmc) auth is the auth plugin"},{"line_number":60,"context_line":"    if not auth and auth_token:"},{"line_number":61,"context_line":"        auth \u003d identity.Token(auth_url\u003dauth_url,"},{"line_number":62,"context_line":"                              token\u003dauth_token,"},{"line_number":63,"context_line":"                              project_id\u003dproject_id,"},{"line_number":64,"context_line":"                              project_name\u003dproject_name,"},{"line_number":65,"context_line":"                              project_domain_id\u003dproject_domain_id,"},{"line_number":66,"context_line":"                              project_domain_name\u003dproject_domain_name)"},{"line_number":67,"context_line":"    elif not auth:"},{"line_number":68,"context_line":"        auth \u003d identity.Password(username\u003dusername,"},{"line_number":69,"context_line":"                                 user_id\u003duser_id,"},{"line_number":70,"context_line":"                                 password\u003dpassword,"},{"line_number":71,"context_line":"                                 project_id\u003dproject_id,"},{"line_number":72,"context_line":"                                 project_name\u003dproject_name,"},{"line_number":73,"context_line":"                                 auth_url\u003dauth_url,"},{"line_number":74,"context_line":"                                 project_domain_id\u003dproject_domain_id,"},{"line_number":75,"context_line":"                                 project_domain_name\u003dproject_domain_name,"},{"line_number":76,"context_line":"                                 user_domain_id\u003duser_domain_id,"},{"line_number":77,"context_line":"                                 user_domain_name\u003duser_domain_name)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    session \u003d ksession.Session(auth\u003dauth,"},{"line_number":80,"context_line":"                               verify\u003d(cacert or not insecure),"},{"line_number":81,"context_line":"                               timeout\u003dtimeout,"},{"line_number":82,"context_line":"                               cert\u003dcert,"},{"line_number":83,"context_line":"                               user_agent\u003duser_agent)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    return session"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"def _get_endpoint(session,"},{"line_number":89,"context_line":"                  interface\u003dNone,"},{"line_number":90,"context_line":"                  region_name\u003dNone,"},{"line_number":91,"context_line":"                  service_name\u003dNone,"},{"line_number":92,"context_line":"                  service_type\u003dNone):"},{"line_number":93,"context_line":"    try:"},{"line_number":94,"context_line":"        # Trigger an auth error so that we can throw the exception"},{"line_number":95,"context_line":"        # we always have"},{"line_number":96,"context_line":"        endpoint \u003d session.get_endpoint("},{"line_number":97,"context_line":"            service_type\u003dservice_type,"},{"line_number":98,"context_line":"            service_name\u003dservice_name,"},{"line_number":99,"context_line":"            interface\u003dinterface,"},{"line_number":100,"context_line":"            region_name\u003dregion_name)"},{"line_number":101,"context_line":"    except catalog.EndpointNotFound:"},{"line_number":102,"context_line":"        service_type \u003d LEGACY_DEFAULT_SERVICE_TYPE"},{"line_number":103,"context_line":"        try:"},{"line_number":104,"context_line":"            endpoint \u003d session.get_endpoint("},{"line_number":105,"context_line":"                service_type\u003dservice_type,"},{"line_number":106,"context_line":"                service_name\u003dservice_name,"},{"line_number":107,"context_line":"                interface\u003dinterface,"},{"line_number":108,"context_line":"                region_name\u003dregion_name)"},{"line_number":109,"context_line":"        except Exception as e:"},{"line_number":110,"context_line":"            raise RuntimeError(str(e))"},{"line_number":111,"context_line":"    except Exception as e:"},{"line_number":112,"context_line":"        raise RuntimeError(str(e))"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    return endpoint"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"def _load_session_client(api_version\u003dNone,"},{"line_number":118,"context_line":"                         auth\u003dNone,"},{"line_number":119,"context_line":"                         auth_token\u003dNone,"},{"line_number":120,"context_line":"                         auth_type\u003dNone,"},{"line_number":121,"context_line":"                         auth_url\u003dNone,"},{"line_number":122,"context_line":"                         cacert\u003dNone,"},{"line_number":123,"context_line":"                         cert\u003dNone,"},{"line_number":124,"context_line":"                         endpoint_override\u003dNone,"},{"line_number":125,"context_line":"                         insecure\u003dNone,"},{"line_number":126,"context_line":"                         interface\u003dNone,"},{"line_number":127,"context_line":"                         password\u003dNone,"},{"line_number":128,"context_line":"                         project_domain_id\u003dNone,"},{"line_number":129,"context_line":"                         project_domain_name\u003dNone,"},{"line_number":130,"context_line":"                         project_id\u003dNone,"},{"line_number":131,"context_line":"                         project_name\u003dNone,"},{"line_number":132,"context_line":"                         region_name\u003dNone,"},{"line_number":133,"context_line":"                         retries\u003dNone,"},{"line_number":134,"context_line":"                         service_type\u003dNone,"},{"line_number":135,"context_line":"                         service_name\u003dNone,"},{"line_number":136,"context_line":"                         session\u003dNone,"},{"line_number":137,"context_line":"                         timeout\u003dNone,"},{"line_number":138,"context_line":"                         user_agent\u003dNone,"},{"line_number":139,"context_line":"                         user_domain_id\u003dNone,"},{"line_number":140,"context_line":"                         user_domain_name\u003dNone,"},{"line_number":141,"context_line":"                         user_id\u003dNone,"},{"line_number":142,"context_line":"                         username\u003dNone,"},{"line_number":143,"context_line":"                         **kwargs):"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    if not session:"},{"line_number":146,"context_line":"        session \u003d _load_session(auth\u003dauth,"},{"line_number":147,"context_line":"                                auth_token\u003dauth_token,"},{"line_number":148,"context_line":"                                auth_url\u003dauth_url,"},{"line_number":149,"context_line":"                                auth_type\u003dauth_type,"},{"line_number":150,"context_line":"                                cacert\u003dcacert,"},{"line_number":151,"context_line":"                                cert\u003dcert,"},{"line_number":152,"context_line":"                                insecure\u003dinsecure,"},{"line_number":153,"context_line":"                                password\u003dpassword,"},{"line_number":154,"context_line":"                                project_domain_id\u003dproject_domain_id,"},{"line_number":155,"context_line":"                                project_domain_name\u003dproject_domain_name,"},{"line_number":156,"context_line":"                                project_id\u003dproject_id,"},{"line_number":157,"context_line":"                                project_name\u003dproject_name,"},{"line_number":158,"context_line":"                                timeout\u003dtimeout,"},{"line_number":159,"context_line":"                                user_agent\u003duser_agent,"},{"line_number":160,"context_line":"                                user_domain_id\u003duser_domain_id,"},{"line_number":161,"context_line":"                                user_domain_name\u003duser_domain_name,"},{"line_number":162,"context_line":"                                user_id\u003duser_id,"},{"line_number":163,"context_line":"                                username\u003dusername)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    if not endpoint_override:"},{"line_number":166,"context_line":"        endpoint_override \u003d _get_endpoint("},{"line_number":167,"context_line":"            session,"},{"line_number":168,"context_line":"            service_type\u003dservice_type,"},{"line_number":169,"context_line":"            service_name\u003dservice_name,"},{"line_number":170,"context_line":"            interface\u003dinterface,"},{"line_number":171,"context_line":"            region_name\u003dregion_name,"},{"line_number":172,"context_line":"        )"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    return httpclient.SessionClient("},{"line_number":175,"context_line":"        session\u003dsession,"},{"line_number":176,"context_line":"        service_type\u003dservice_type,"},{"line_number":177,"context_line":"        service_name\u003dservice_name,"},{"line_number":178,"context_line":"        interface\u003dinterface,"},{"line_number":179,"context_line":"        region_name\u003dregion_name,"},{"line_number":180,"context_line":"        endpoint_override\u003dendpoint_override,"},{"line_number":181,"context_line":"        api_version\u003dapi_version,"},{"line_number":182,"context_line":"        user_agent\u003duser_agent,"},{"line_number":183,"context_line":"        retries\u003dretries)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"@removals.removed_class(\"Client\", message\u003d\"Please use \u0027v2.Client\u0027 instead\","}],"source_content_type":"text/x-python","patch_set":37,"id":"10d633bc_171a75f8","line":183,"range":{"start_line":40,"start_character":0,"end_line":183,"end_character":24},"in_reply_to":"5b5000d8_5208f3d0","updated":"2022-07-08 14:37:58.000000000","message":"Done","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e4cae8f42af15232d0edfaafb41229019d0d74d2","unresolved":true,"context_lines":[{"line_number":189,"context_line":"    \"\"\"Top-level object to access the OpenStack Manila API."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    Create a client instance using the"},{"line_number":192,"context_line":"    keystoneauth1.session API::"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        \u003e\u003e\u003e from keystoneauth1.identity import v3"},{"line_number":195,"context_line":"        \u003e\u003e\u003e from keystoneauth1 import session as ks"}],"source_content_type":"text/x-python","patch_set":37,"id":"ceaa5ead_3d37a8c4","line":192,"range":{"start_line":192,"start_character":2,"end_line":192,"end_character":5},"updated":"2021-02-11 01:57:45.000000000","message":"the example without sessions is cool too :) Maybe we can keep it? I like the aspect of allowing our client to handle the sessions instead of me as the end user application needing to do it","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"d4a163b2725ca0e3e7d09f9fe095a3200364c7f5","unresolved":false,"context_lines":[{"line_number":189,"context_line":"    \"\"\"Top-level object to access the OpenStack Manila API."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    Create a client instance using the"},{"line_number":192,"context_line":"    keystoneauth1.session API::"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        \u003e\u003e\u003e from keystoneauth1.identity import v3"},{"line_number":195,"context_line":"        \u003e\u003e\u003e from keystoneauth1 import session as ks"}],"source_content_type":"text/x-python","patch_set":37,"id":"af6c66f5_d57fbe74","line":192,"range":{"start_line":192,"start_character":2,"end_line":192,"end_character":5},"in_reply_to":"ceaa5ead_3d37a8c4","updated":"2022-07-08 14:49:58.000000000","message":"Done","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e4cae8f42af15232d0edfaafb41229019d0d74d2","unresolved":true,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        \u003e\u003e\u003e authv3 \u003d v3.Password(**auth_params)"},{"line_number":209,"context_line":"        \u003e\u003e\u003e session \u003d ks.Session(auth\u003dauthv3)"},{"line_number":210,"context_line":"        \u003e\u003e\u003e manila \u003d client.Client(client_version\u003d\u00272\u0027, session\u003dsession)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    Then call methods on its managers::"},{"line_number":213,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"65307b17_89984676","line":210,"range":{"start_line":210,"start_character":50,"end_line":210,"end_character":53},"updated":"2021-02-11 01:57:45.000000000","message":"\u00271\u0027","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"636d9ff182b1ab8077e3ebbb65d05b6b92891449","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        \u003e\u003e\u003e authv3 \u003d v3.Password(**auth_params)"},{"line_number":209,"context_line":"        \u003e\u003e\u003e session \u003d ks.Session(auth\u003dauthv3)"},{"line_number":210,"context_line":"        \u003e\u003e\u003e manila \u003d client.Client(client_version\u003d\u00272\u0027, session\u003dsession)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    Then call methods on its managers::"},{"line_number":213,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"18b54f61_f9abdcde","line":210,"range":{"start_line":210,"start_character":50,"end_line":210,"end_character":53},"in_reply_to":"65307b17_89984676","updated":"2022-07-08 14:37:58.000000000","message":"Done","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e4cae8f42af15232d0edfaafb41229019d0d74d2","unresolved":true,"context_lines":[{"line_number":229,"context_line":"    @removals.removed_kwarg("},{"line_number":230,"context_line":"        \u0027api_key\u0027, message\u003d\"Please use \u0027password\u0027 instead\","},{"line_number":231,"context_line":"        removal_version\u003d\u00272.0.0\u0027)"},{"line_number":232,"context_line":"    @removals.removed_kwarg("},{"line_number":233,"context_line":"        \u0027input_auth_token\u0027, message\u003d\"Please use \u0027auth_token\u0027 instead\","},{"line_number":234,"context_line":"        removal_version\u003d\u00272.0.0\u0027)"},{"line_number":235,"context_line":"    @removals.removed_kwarg("},{"line_number":236,"context_line":"        \u0027endpoint_type\u0027, message\u003d\"Please use \u0027interface\u0027 instead\","},{"line_number":237,"context_line":"        removal_version\u003d\u00272.0.0\u0027)"},{"line_number":238,"context_line":"    @removals.removed_kwarg("},{"line_number":239,"context_line":"        \u0027service_catalog_url\u0027,"},{"line_number":240,"context_line":"        message\u003d\"Please use \u0027endpoint_override\u0027 instead\","},{"line_number":241,"context_line":"        removal_version\u003d\u00272.0.0\u0027)"},{"line_number":242,"context_line":"    def __init__(self,"},{"line_number":243,"context_line":"                 username\u003dNone,"},{"line_number":244,"context_line":"                 api_key\u003dNone,"}],"source_content_type":"text/x-python","patch_set":37,"id":"835b4b71_a152d4be","line":241,"range":{"start_line":232,"start_character":0,"end_line":241,"end_character":32},"updated":"2021-02-11 01:57:45.000000000","message":"same comments as in the next file, deprecations shouldn\u0027t be back-dated - let\u0027s set them to 2.5.0","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"636d9ff182b1ab8077e3ebbb65d05b6b92891449","unresolved":false,"context_lines":[{"line_number":229,"context_line":"    @removals.removed_kwarg("},{"line_number":230,"context_line":"        \u0027api_key\u0027, message\u003d\"Please use \u0027password\u0027 instead\","},{"line_number":231,"context_line":"        removal_version\u003d\u00272.0.0\u0027)"},{"line_number":232,"context_line":"    @removals.removed_kwarg("},{"line_number":233,"context_line":"        \u0027input_auth_token\u0027, message\u003d\"Please use \u0027auth_token\u0027 instead\","},{"line_number":234,"context_line":"        removal_version\u003d\u00272.0.0\u0027)"},{"line_number":235,"context_line":"    @removals.removed_kwarg("},{"line_number":236,"context_line":"        \u0027endpoint_type\u0027, message\u003d\"Please use \u0027interface\u0027 instead\","},{"line_number":237,"context_line":"        removal_version\u003d\u00272.0.0\u0027)"},{"line_number":238,"context_line":"    @removals.removed_kwarg("},{"line_number":239,"context_line":"        \u0027service_catalog_url\u0027,"},{"line_number":240,"context_line":"        message\u003d\"Please use \u0027endpoint_override\u0027 instead\","},{"line_number":241,"context_line":"        removal_version\u003d\u00272.0.0\u0027)"},{"line_number":242,"context_line":"    def __init__(self,"},{"line_number":243,"context_line":"                 username\u003dNone,"},{"line_number":244,"context_line":"                 api_key\u003dNone,"}],"source_content_type":"text/x-python","patch_set":37,"id":"29e60506_219f61bc","line":241,"range":{"start_line":232,"start_character":0,"end_line":241,"end_character":32},"in_reply_to":"835b4b71_a152d4be","updated":"2022-07-08 14:37:58.000000000","message":"Done","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e4cae8f42af15232d0edfaafb41229019d0d74d2","unresolved":true,"context_lines":[{"line_number":278,"context_line":"                 interface\u003dNone,"},{"line_number":279,"context_line":"                 **kwargs):"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"        # NOTE(vkmc) backwards compat for people using api_key"},{"line_number":282,"context_line":"        if not password:"},{"line_number":283,"context_line":"            password \u003d api_key"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        # NOTE(vkmc) backwards compat for people using tenant_id"},{"line_number":286,"context_line":"        if not project_id:"},{"line_number":287,"context_line":"            project_id \u003d tenant_id"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        # NOTE(vkmc) backwards compat for people using endpoint_type"},{"line_number":290,"context_line":"        if not interface:"},{"line_number":291,"context_line":"            interface \u003d endpoint_type"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        if not interface:"},{"line_number":294,"context_line":"            interface \u003d \u0027public\u0027"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        if not service_name:"},{"line_number":297,"context_line":"            service_name \u003d kwargs.get(\"share_service_name\", service_name)"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        # NOTE(vkmc) Backwards compat for people using input_auth_token"},{"line_number":300,"context_line":"        if input_auth_token:"},{"line_number":301,"context_line":"            auth_token \u003d input_auth_token"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        # NOTE(vkmc) Backwards compat for people using service_catalog_url"},{"line_number":304,"context_line":"        if not endpoint_override:"},{"line_number":305,"context_line":"            endpoint_override \u003d service_catalog_url"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        self.api_version \u003d api_version"}],"source_content_type":"text/x-python","patch_set":37,"id":"b26af9b2_b90e9adb","line":304,"range":{"start_line":281,"start_character":8,"end_line":304,"end_character":33},"updated":"2021-02-11 01:57:45.000000000","message":"please check substitution suggestions in v2/client.py","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"636d9ff182b1ab8077e3ebbb65d05b6b92891449","unresolved":false,"context_lines":[{"line_number":278,"context_line":"                 interface\u003dNone,"},{"line_number":279,"context_line":"                 **kwargs):"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"        # NOTE(vkmc) backwards compat for people using api_key"},{"line_number":282,"context_line":"        if not password:"},{"line_number":283,"context_line":"            password \u003d api_key"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        # NOTE(vkmc) backwards compat for people using tenant_id"},{"line_number":286,"context_line":"        if not project_id:"},{"line_number":287,"context_line":"            project_id \u003d tenant_id"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        # NOTE(vkmc) backwards compat for people using endpoint_type"},{"line_number":290,"context_line":"        if not interface:"},{"line_number":291,"context_line":"            interface \u003d endpoint_type"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        if not interface:"},{"line_number":294,"context_line":"            interface \u003d \u0027public\u0027"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        if not service_name:"},{"line_number":297,"context_line":"            service_name \u003d kwargs.get(\"share_service_name\", service_name)"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        # NOTE(vkmc) Backwards compat for people using input_auth_token"},{"line_number":300,"context_line":"        if input_auth_token:"},{"line_number":301,"context_line":"            auth_token \u003d input_auth_token"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        # NOTE(vkmc) Backwards compat for people using service_catalog_url"},{"line_number":304,"context_line":"        if not endpoint_override:"},{"line_number":305,"context_line":"            endpoint_override \u003d service_catalog_url"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        self.api_version \u003d api_version"}],"source_content_type":"text/x-python","patch_set":37,"id":"6b0d6dae_24baab80","line":304,"range":{"start_line":281,"start_character":8,"end_line":304,"end_character":33},"in_reply_to":"b26af9b2_b90e9adb","updated":"2022-07-08 14:37:58.000000000","message":"Done","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e4cae8f42af15232d0edfaafb41229019d0d74d2","unresolved":true,"context_lines":[{"line_number":311,"context_line":"                   \"provide \u0027auth_token\u0027 and \u0027endpoint_override\u0027.\")"},{"line_number":312,"context_line":"            raise exceptions.ClientException(msg)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        if endpoint_override and auth_token:"},{"line_number":315,"context_line":"            self.client \u003d httpclient.HTTPClient("},{"line_number":316,"context_line":"                api_version\u003dapi_version,"},{"line_number":317,"context_line":"                cacert\u003dcacert,"}],"source_content_type":"text/x-python","patch_set":37,"id":"a859773f_6ac91186","line":314,"range":{"start_line":314,"start_character":8,"end_line":314,"end_character":43},"updated":"2021-02-11 01:57:45.000000000","message":"if not session","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"636d9ff182b1ab8077e3ebbb65d05b6b92891449","unresolved":false,"context_lines":[{"line_number":311,"context_line":"                   \"provide \u0027auth_token\u0027 and \u0027endpoint_override\u0027.\")"},{"line_number":312,"context_line":"            raise exceptions.ClientException(msg)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        if endpoint_override and auth_token:"},{"line_number":315,"context_line":"            self.client \u003d httpclient.HTTPClient("},{"line_number":316,"context_line":"                api_version\u003dapi_version,"},{"line_number":317,"context_line":"                cacert\u003dcacert,"}],"source_content_type":"text/x-python","patch_set":37,"id":"323249d9_bbb5677c","line":314,"range":{"start_line":314,"start_character":8,"end_line":314,"end_character":43},"in_reply_to":"a859773f_6ac91186","updated":"2022-07-08 14:37:58.000000000","message":"Done","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"}],"manilaclient/v2/client.py":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"5669839773c336ef0f26387156ff8abc8390bbcc","unresolved":false,"context_lines":[{"line_number":162,"context_line":"                    service_type\u003dservice_type,"},{"line_number":163,"context_line":"                    service_name\u003dservice_name,"},{"line_number":164,"context_line":"                    region_name\u003dregion_name)"},{"line_number":165,"context_line":"            input_auth_token \u003d self.keystone_client.session.get_token(auth)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        if not input_auth_token:"},{"line_number":168,"context_line":"            raise RuntimeError(\"Not Authorized\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_84149ca1","line":165,"updated":"2019-03-25 17:42:54.000000000","message":"It would be better to avoid interacting with the token at all and instead use the session object as an abstraction for token management.","commit_id":"c0a903348b8040cefad6033d7f73b18cc723cd35"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@canonical.com","username":"toabctl"},"change_message_id":"3fa856228e23052bba13881cdc4f21848c251909","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        \u0027service_catalog_url\u0027,"},{"line_number":248,"context_line":"        message\u003d\"Please use \u0027endpoint_override\u0027 instead\","},{"line_number":249,"context_line":"        removal_version\u003d\u00272.0.0\u0027)"},{"line_number":250,"context_line":"    def __init__(self,"},{"line_number":251,"context_line":"                 api_key\u003dNone,"},{"line_number":252,"context_line":"                 api_version\u003dmanilaclient.API_MIN_VERSION,"},{"line_number":253,"context_line":"                 auth\u003dNone,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ffb9cba7_db82f34f","line":250,"updated":"2019-04-23 06:57:25.000000000","message":"This changes the API (different order or positional args)","commit_id":"640d08103831288e5eaf195215d1928b5585b6be"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"cf6e61c8ca0b2397bdb16ba972594df00ac471e9","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                  user_domain_id\u003dNone,"},{"line_number":70,"context_line":"                  user_domain_name\u003dNone,"},{"line_number":71,"context_line":"                  user_id\u003dNone,"},{"line_number":72,"context_line":"                  username\u003dNone):"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    # NOTE(vkmc) auth is the auth plugin"},{"line_number":75,"context_line":"    if not auth and auth_token:"}],"source_content_type":"text/x-python","patch_set":24,"id":"7faddb67_7a6cf607","line":72,"updated":"2019-07-25 21:54:02.000000000","message":"You shouldn\u0027t have to parse all of these options yourself here, keystoneauth provides a loading interface to do it for you: https://docs.openstack.org/keystoneauth/latest/api/keystoneauth1.loading.html#module-keystoneauth1.loading","commit_id":"dd76f3975fe4628b97433a29a9ddb4325f7c9309"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"caf5b2835db9981feea329eed894600ce01e10ad","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                  user_domain_id\u003dNone,"},{"line_number":70,"context_line":"                  user_domain_name\u003dNone,"},{"line_number":71,"context_line":"                  user_id\u003dNone,"},{"line_number":72,"context_line":"                  username\u003dNone):"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    # NOTE(vkmc) auth is the auth plugin"},{"line_number":75,"context_line":"    if not auth and auth_token:"}],"source_content_type":"text/x-python","patch_set":24,"id":"7faddb67_b8e668af","line":72,"in_reply_to":"7faddb67_7a6cf607","updated":"2019-08-20 21:37:58.000000000","message":"I see there is two ways of doing this, either using the loading module or using the session module as I did. I saw more occurrences in other clients of the session module usage and feels a bit more readable. Anything against this practice? I didn\u0027t see many examples of loading.","commit_id":"dd76f3975fe4628b97433a29a9ddb4325f7c9309"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"cf6e61c8ca0b2397bdb16ba972594df00ac471e9","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    except Exception as e:"},{"line_number":127,"context_line":"        raise RuntimeError(str(e))"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    return endpoint"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"def _load_session_client(api_version\u003dNone,"}],"source_content_type":"text/x-python","patch_set":24,"id":"7faddb67_3c243baf","line":129,"updated":"2019-07-25 21:54:02.000000000","message":"You shouldn\u0027t need to do all this, the keystoneauth Adapter or LegacyJsonAdapter should be able to figure out the endpoint for you.","commit_id":"dd76f3975fe4628b97433a29a9ddb4325f7c9309"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"caf5b2835db9981feea329eed894600ce01e10ad","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    except Exception as e:"},{"line_number":127,"context_line":"        raise RuntimeError(str(e))"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    return endpoint"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"def _load_session_client(api_version\u003dNone,"}],"source_content_type":"text/x-python","patch_set":24,"id":"7faddb67_d8b7a484","line":129,"in_reply_to":"7faddb67_3c243baf","updated":"2019-08-20 21:37:58.000000000","message":"By looking at the code, it seems it doesn\u0027t resolve it itself. We need to explicitly pass it in order to get the proper endpoint.","commit_id":"dd76f3975fe4628b97433a29a9ddb4325f7c9309"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"02d16a43d058ace5154991755bc6c06d9e101d39","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    Create an instance with your creds::"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        \u003e\u003e\u003e client \u003d Client(USERNAME, PASSWORD, PROJECT_ID, AUTH_URL)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    Or, alternatively, you can create a client instance using the"},{"line_number":209,"context_line":"    keystoneauth1.session API::"}],"source_content_type":"text/x-python","patch_set":25,"id":"5faad753_b95a55f0","line":206,"range":{"start_line":206,"start_character":12,"end_line":206,"end_character":69},"updated":"2019-09-12 06:28:29.000000000","message":"This was some v2 voodoo - keystone v2 is gone now, you can remove this..","commit_id":"199acfc3c2eb4c9b0cb2204e5c9724548ee66d7b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"02d16a43d058ace5154991755bc6c06d9e101d39","unresolved":false,"context_lines":[{"line_number":208,"context_line":"    Or, alternatively, you can create a client instance using the"},{"line_number":209,"context_line":"    keystoneauth1.session API::"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        \u003e\u003e\u003e from keystoneauth1 import session"},{"line_number":212,"context_line":"        \u003e\u003e\u003e from manilaclient import client"},{"line_number":213,"context_line":"        \u003e\u003e\u003e auth \u003d v2.Password(auth_url\u003dAUTH_URL,"},{"line_number":214,"context_line":"                               username\u003dUSERNAME,"},{"line_number":215,"context_line":"                               password\u003dPASSWORD,"},{"line_number":216,"context_line":"                               tenant_name\u003dPROJECT_ID)"},{"line_number":217,"context_line":"        \u003e\u003e\u003e sess \u003d session.Session(auth\u003dauth)"},{"line_number":218,"context_line":"        \u003e\u003e\u003e manila \u003d client.Client(VERSION, session\u003dsess)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    Then call methods on its managers::"},{"line_number":221,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"5faad753_e1600fa8","line":218,"range":{"start_line":211,"start_character":0,"end_line":218,"end_character":57},"updated":"2019-09-12 06:28:29.000000000","message":"Let\u0027s replace this with a keystonev3 equivalent:\n\n \n from keystoneauth1.identity import v3\n from keystoneauth1 import session as ks\n from manilaclient import client\n\n auth_params  \u003d {\n  \u0027auth_url\u0027 : OS_AUTH_URL,\n  \u0027username\u0027 : OS_USERNAME,\n  \u0027password\u0027 : OS_PASSWORD,\n  \u0027project_name\u0027 : OS_PROJECT_NAME,\n  \u0027project_domain_name\u0027 : OS_PROJECT_DOMAIN_NAME,\n  \u0027project_domain_id\u0027 : OS_PROJECT_DOMAIN_ID,\n  \u0027user_domain_name\u0027 : OS_USER_DOMAIN_NAME,\n  \u0027user_domain_id\u0027 : OS_USER_DOMAIN_ID,\n }\n\n authv3 \u003d v3.Password(**auth_params)\n session \u003d ks.Session(auth\u003dauthv3)\n manila \u003d client.Client(client_version\u003d\u00272\u0027, session\u003dsession)","commit_id":"199acfc3c2eb4c9b0cb2204e5c9724548ee66d7b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"02d16a43d058ace5154991755bc6c06d9e101d39","unresolved":false,"context_lines":[{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    Then call methods on its managers::"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        \u003e\u003e\u003e client.shares.list()"},{"line_number":223,"context_line":"        ..."},{"line_number":224,"context_line":"    \"\"\""},{"line_number":225,"context_line":"    @removals.removed_kwarg("}],"source_content_type":"text/x-python","patch_set":25,"id":"5faad753_0109abdb","line":222,"range":{"start_line":222,"start_character":12,"end_line":222,"end_character":32},"updated":"2019-09-12 06:28:29.000000000","message":"manila.shares.list()","commit_id":"199acfc3c2eb4c9b0cb2204e5c9724548ee66d7b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e4cae8f42af15232d0edfaafb41229019d0d74d2","unresolved":true,"context_lines":[{"line_number":187,"context_line":"            region_name\u003dregion_name,"},{"line_number":188,"context_line":"        )"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    return httpclient.SessionClient("},{"line_number":191,"context_line":"        session\u003dsession,"},{"line_number":192,"context_line":"        service_type\u003dservice_type,"},{"line_number":193,"context_line":"        service_name\u003dservice_name,"},{"line_number":194,"context_line":"        interface\u003dinterface,"},{"line_number":195,"context_line":"        region_name\u003dregion_name,"},{"line_number":196,"context_line":"        endpoint_override\u003dendpoint_override,"},{"line_number":197,"context_line":"        api_version\u003dapi_version,"},{"line_number":198,"context_line":"        user_agent\u003duser_agent,"},{"line_number":199,"context_line":"        retries\u003dretries)"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"class Client(object):"}],"source_content_type":"text/x-python","patch_set":37,"id":"6da1d084_8e0f3d13","line":199,"range":{"start_line":190,"start_character":0,"end_line":199,"end_character":24},"updated":"2021-02-11 01:57:45.000000000","message":"Moving this code (lines 56-199) into the http_client module will allow reuse and keep this file clean","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"636d9ff182b1ab8077e3ebbb65d05b6b92891449","unresolved":false,"context_lines":[{"line_number":187,"context_line":"            region_name\u003dregion_name,"},{"line_number":188,"context_line":"        )"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    return httpclient.SessionClient("},{"line_number":191,"context_line":"        session\u003dsession,"},{"line_number":192,"context_line":"        service_type\u003dservice_type,"},{"line_number":193,"context_line":"        service_name\u003dservice_name,"},{"line_number":194,"context_line":"        interface\u003dinterface,"},{"line_number":195,"context_line":"        region_name\u003dregion_name,"},{"line_number":196,"context_line":"        endpoint_override\u003dendpoint_override,"},{"line_number":197,"context_line":"        api_version\u003dapi_version,"},{"line_number":198,"context_line":"        user_agent\u003duser_agent,"},{"line_number":199,"context_line":"        retries\u003dretries)"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"class Client(object):"}],"source_content_type":"text/x-python","patch_set":37,"id":"496980a8_fbe35097","line":199,"range":{"start_line":190,"start_character":0,"end_line":199,"end_character":24},"in_reply_to":"6da1d084_8e0f3d13","updated":"2022-07-08 14:37:58.000000000","message":"Done","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e4cae8f42af15232d0edfaafb41229019d0d74d2","unresolved":true,"context_lines":[{"line_number":228,"context_line":"        \u003e\u003e\u003e manila.shares.list()"},{"line_number":229,"context_line":"        ..."},{"line_number":230,"context_line":"    \"\"\""},{"line_number":231,"context_line":"    @removals.removed_kwarg("},{"line_number":232,"context_line":"        \u0027share_service_name\u0027, message\u003d\"Please use \u0027service_name\u0027 instead\","},{"line_number":233,"context_line":"        removal_version\u003d\u00272.0.0\u0027)"},{"line_number":234,"context_line":"    @removals.removed_kwarg("},{"line_number":235,"context_line":"        \u0027proxy_tenant_id\u0027, message\u003d\"This is not used anywhere\","},{"line_number":236,"context_line":"        removal_version\u003d\u00272.0.0\u0027)"},{"line_number":237,"context_line":"    @removals.removed_kwarg("},{"line_number":238,"context_line":"        \u0027proxy_token\u0027, message\u003d\"This is not used anywhere\","},{"line_number":239,"context_line":"        removal_version\u003d\u00272.0.0\u0027)"},{"line_number":240,"context_line":"    @removals.removed_kwarg("},{"line_number":241,"context_line":"        \u0027os_cache\u0027, message\u003d\"Please use \u0027use_keyring\u0027 instead\","},{"line_number":242,"context_line":"        removal_version\u003d\u00272.0.0\u0027)"},{"line_number":243,"context_line":"    @removals.removed_kwarg("},{"line_number":244,"context_line":"        \u0027api_key\u0027, message\u003d\"Please use \u0027password\u0027 instead\","},{"line_number":245,"context_line":"        removal_version\u003d\u00272.0.0\u0027)"},{"line_number":246,"context_line":"    @removals.removed_kwarg("},{"line_number":247,"context_line":"        \u0027input_auth_token\u0027, message\u003d\"Please use \u0027auth_token\u0027 instead\","},{"line_number":248,"context_line":"        removal_version\u003d\u00272.0.0\u0027)"}],"source_content_type":"text/x-python","patch_set":37,"id":"489b6509_8b4ddd3d","line":245,"range":{"start_line":231,"start_character":0,"end_line":245,"end_character":32},"updated":"2021-02-11 01:57:45.000000000","message":"we could clean these up now","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"10af33d253e67d8d92cae398e2bf1fb6f093862d","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        \u003e\u003e\u003e manila.shares.list()"},{"line_number":229,"context_line":"        ..."},{"line_number":230,"context_line":"    \"\"\""},{"line_number":231,"context_line":"    @removals.removed_kwarg("},{"line_number":232,"context_line":"        \u0027share_service_name\u0027, message\u003d\"Please use \u0027service_name\u0027 instead\","},{"line_number":233,"context_line":"        removal_version\u003d\u00272.0.0\u0027)"},{"line_number":234,"context_line":"    @removals.removed_kwarg("},{"line_number":235,"context_line":"        \u0027proxy_tenant_id\u0027, message\u003d\"This is not used anywhere\","},{"line_number":236,"context_line":"        removal_version\u003d\u00272.0.0\u0027)"},{"line_number":237,"context_line":"    @removals.removed_kwarg("},{"line_number":238,"context_line":"        \u0027proxy_token\u0027, message\u003d\"This is not used anywhere\","},{"line_number":239,"context_line":"        removal_version\u003d\u00272.0.0\u0027)"},{"line_number":240,"context_line":"    @removals.removed_kwarg("},{"line_number":241,"context_line":"        \u0027os_cache\u0027, message\u003d\"Please use \u0027use_keyring\u0027 instead\","},{"line_number":242,"context_line":"        removal_version\u003d\u00272.0.0\u0027)"},{"line_number":243,"context_line":"    @removals.removed_kwarg("},{"line_number":244,"context_line":"        \u0027api_key\u0027, message\u003d\"Please use \u0027password\u0027 instead\","},{"line_number":245,"context_line":"        removal_version\u003d\u00272.0.0\u0027)"},{"line_number":246,"context_line":"    @removals.removed_kwarg("},{"line_number":247,"context_line":"        \u0027input_auth_token\u0027, message\u003d\"Please use \u0027auth_token\u0027 instead\","},{"line_number":248,"context_line":"        removal_version\u003d\u00272.0.0\u0027)"}],"source_content_type":"text/x-python","patch_set":37,"id":"db7e8096_0cd26ee6","line":245,"range":{"start_line":231,"start_character":0,"end_line":245,"end_character":32},"in_reply_to":"489b6509_8b4ddd3d","updated":"2021-03-01 18:41:47.000000000","message":"Done","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e4cae8f42af15232d0edfaafb41229019d0d74d2","unresolved":true,"context_lines":[{"line_number":245,"context_line":"        removal_version\u003d\u00272.0.0\u0027)"},{"line_number":246,"context_line":"    @removals.removed_kwarg("},{"line_number":247,"context_line":"        \u0027input_auth_token\u0027, message\u003d\"Please use \u0027auth_token\u0027 instead\","},{"line_number":248,"context_line":"        removal_version\u003d\u00272.0.0\u0027)"},{"line_number":249,"context_line":"    @removals.removed_kwarg("},{"line_number":250,"context_line":"        \u0027endpoint_type\u0027, message\u003d\"Please use \u0027interface\u0027 instead\","},{"line_number":251,"context_line":"        removal_version\u003d\u00272.0.0\u0027)"}],"source_content_type":"text/x-python","patch_set":37,"id":"37d9a816_f716ea19","line":248,"range":{"start_line":248,"start_character":25,"end_line":248,"end_character":30},"updated":"2021-02-11 01:57:45.000000000","message":"Can\u0027t deprecate from a previous version - the latest released version is 2.4.0, so this should either be 2.5.0 or 3.0.0 depending on whether this change deserves a major version bump","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"10af33d253e67d8d92cae398e2bf1fb6f093862d","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        removal_version\u003d\u00272.0.0\u0027)"},{"line_number":246,"context_line":"    @removals.removed_kwarg("},{"line_number":247,"context_line":"        \u0027input_auth_token\u0027, message\u003d\"Please use \u0027auth_token\u0027 instead\","},{"line_number":248,"context_line":"        removal_version\u003d\u00272.0.0\u0027)"},{"line_number":249,"context_line":"    @removals.removed_kwarg("},{"line_number":250,"context_line":"        \u0027endpoint_type\u0027, message\u003d\"Please use \u0027interface\u0027 instead\","},{"line_number":251,"context_line":"        removal_version\u003d\u00272.0.0\u0027)"}],"source_content_type":"text/x-python","patch_set":37,"id":"a9d4ac89_c2356ea6","line":248,"range":{"start_line":248,"start_character":25,"end_line":248,"end_character":30},"in_reply_to":"37d9a816_f716ea19","updated":"2021-03-01 18:41:47.000000000","message":"Done","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e4cae8f42af15232d0edfaafb41229019d0d74d2","unresolved":true,"context_lines":[{"line_number":255,"context_line":"        removal_version\u003d\u00272.0.0\u0027)"},{"line_number":256,"context_line":"    def __init__(self,"},{"line_number":257,"context_line":"                 username\u003dNone,"},{"line_number":258,"context_line":"                 api_key\u003dNone,"},{"line_number":259,"context_line":"                 project_id\u003dNone,"},{"line_number":260,"context_line":"                 auth_url\u003dNone,"},{"line_number":261,"context_line":"                 insecure\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":37,"id":"3c6feeb2_143faa24","line":258,"range":{"start_line":258,"start_character":0,"end_line":258,"end_character":30},"updated":"2021-02-11 01:57:45.000000000","message":"remove","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"10af33d253e67d8d92cae398e2bf1fb6f093862d","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        removal_version\u003d\u00272.0.0\u0027)"},{"line_number":256,"context_line":"    def __init__(self,"},{"line_number":257,"context_line":"                 username\u003dNone,"},{"line_number":258,"context_line":"                 api_key\u003dNone,"},{"line_number":259,"context_line":"                 project_id\u003dNone,"},{"line_number":260,"context_line":"                 auth_url\u003dNone,"},{"line_number":261,"context_line":"                 insecure\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":37,"id":"8508de09_7d27c9f6","line":258,"range":{"start_line":258,"start_character":0,"end_line":258,"end_character":30},"in_reply_to":"3c6feeb2_143faa24","updated":"2021-03-01 18:41:47.000000000","message":"Done","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e4cae8f42af15232d0edfaafb41229019d0d74d2","unresolved":true,"context_lines":[{"line_number":260,"context_line":"                 auth_url\u003dNone,"},{"line_number":261,"context_line":"                 insecure\u003dFalse,"},{"line_number":262,"context_line":"                 timeout\u003dNone,"},{"line_number":263,"context_line":"                 tenant_id\u003dNone,"},{"line_number":264,"context_line":"                 project_name\u003dNone,"},{"line_number":265,"context_line":"                 region_name\u003dNone,"},{"line_number":266,"context_line":"                 endpoint_type\u003d\u0027public\u0027,"}],"source_content_type":"text/x-python","patch_set":37,"id":"39960f3a_c97650da","line":263,"range":{"start_line":263,"start_character":17,"end_line":263,"end_character":26},"updated":"2021-02-11 01:57:45.000000000","message":"Can we deprecate this one? \"project_id\" replaces this, and \"project_name\" is unique, so callers can use that too instead","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"636d9ff182b1ab8077e3ebbb65d05b6b92891449","unresolved":false,"context_lines":[{"line_number":260,"context_line":"                 auth_url\u003dNone,"},{"line_number":261,"context_line":"                 insecure\u003dFalse,"},{"line_number":262,"context_line":"                 timeout\u003dNone,"},{"line_number":263,"context_line":"                 tenant_id\u003dNone,"},{"line_number":264,"context_line":"                 project_name\u003dNone,"},{"line_number":265,"context_line":"                 region_name\u003dNone,"},{"line_number":266,"context_line":"                 endpoint_type\u003d\u0027public\u0027,"}],"source_content_type":"text/x-python","patch_set":37,"id":"06db41f8_a23f6d31","line":263,"range":{"start_line":263,"start_character":17,"end_line":263,"end_character":26},"in_reply_to":"39960f3a_c97650da","updated":"2022-07-08 14:37:58.000000000","message":"Done","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e4cae8f42af15232d0edfaafb41229019d0d74d2","unresolved":true,"context_lines":[{"line_number":263,"context_line":"                 tenant_id\u003dNone,"},{"line_number":264,"context_line":"                 project_name\u003dNone,"},{"line_number":265,"context_line":"                 region_name\u003dNone,"},{"line_number":266,"context_line":"                 endpoint_type\u003d\u0027public\u0027,"},{"line_number":267,"context_line":"                 extensions\u003dNone,"},{"line_number":268,"context_line":"                 service_type\u003dDEFAULT_SERVICE_TYPE,"},{"line_number":269,"context_line":"                 service_name\u003dNone,"}],"source_content_type":"text/x-python","patch_set":37,"id":"cfdd8230_d998739b","line":266,"range":{"start_line":266,"start_character":0,"end_line":266,"end_character":40},"updated":"2021-02-11 01:57:45.000000000","message":"we can remove this from here.","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"636d9ff182b1ab8077e3ebbb65d05b6b92891449","unresolved":false,"context_lines":[{"line_number":263,"context_line":"                 tenant_id\u003dNone,"},{"line_number":264,"context_line":"                 project_name\u003dNone,"},{"line_number":265,"context_line":"                 region_name\u003dNone,"},{"line_number":266,"context_line":"                 endpoint_type\u003d\u0027public\u0027,"},{"line_number":267,"context_line":"                 extensions\u003dNone,"},{"line_number":268,"context_line":"                 service_type\u003dDEFAULT_SERVICE_TYPE,"},{"line_number":269,"context_line":"                 service_name\u003dNone,"}],"source_content_type":"text/x-python","patch_set":37,"id":"3cbe10d1_1c6b3fce","line":266,"range":{"start_line":266,"start_character":0,"end_line":266,"end_character":40},"in_reply_to":"cfdd8230_d998739b","updated":"2022-07-08 14:37:58.000000000","message":"Done","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e4cae8f42af15232d0edfaafb41229019d0d74d2","unresolved":true,"context_lines":[{"line_number":269,"context_line":"                 service_name\u003dNone,"},{"line_number":270,"context_line":"                 retries\u003dNone,"},{"line_number":271,"context_line":"                 http_log_debug\u003dFalse,"},{"line_number":272,"context_line":"                 input_auth_token\u003dNone,"},{"line_number":273,"context_line":"                 session\u003dNone,"},{"line_number":274,"context_line":"                 auth\u003dNone,"},{"line_number":275,"context_line":"                 cacert\u003dNone,"}],"source_content_type":"text/x-python","patch_set":37,"id":"57381b27_473e1d35","line":272,"range":{"start_line":272,"start_character":0,"end_line":272,"end_character":39},"updated":"2021-02-11 01:57:45.000000000","message":"we can remove this","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"636d9ff182b1ab8077e3ebbb65d05b6b92891449","unresolved":false,"context_lines":[{"line_number":269,"context_line":"                 service_name\u003dNone,"},{"line_number":270,"context_line":"                 retries\u003dNone,"},{"line_number":271,"context_line":"                 http_log_debug\u003dFalse,"},{"line_number":272,"context_line":"                 input_auth_token\u003dNone,"},{"line_number":273,"context_line":"                 session\u003dNone,"},{"line_number":274,"context_line":"                 auth\u003dNone,"},{"line_number":275,"context_line":"                 cacert\u003dNone,"}],"source_content_type":"text/x-python","patch_set":37,"id":"f89287a3_8db56ce7","line":272,"range":{"start_line":272,"start_character":0,"end_line":272,"end_character":39},"in_reply_to":"57381b27_473e1d35","updated":"2022-07-08 14:37:58.000000000","message":"Done","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e4cae8f42af15232d0edfaafb41229019d0d74d2","unresolved":true,"context_lines":[{"line_number":273,"context_line":"                 session\u003dNone,"},{"line_number":274,"context_line":"                 auth\u003dNone,"},{"line_number":275,"context_line":"                 cacert\u003dNone,"},{"line_number":276,"context_line":"                 service_catalog_url\u003dNone,"},{"line_number":277,"context_line":"                 user_agent\u003d\u0027python-manilaclient\u0027,"},{"line_number":278,"context_line":"                 use_keyring\u003dFalse,"},{"line_number":279,"context_line":"                 force_new_token\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":37,"id":"b32fe1c5_aef94dc7","line":276,"range":{"start_line":276,"start_character":0,"end_line":276,"end_character":42},"updated":"2021-02-11 01:57:45.000000000","message":"we can remove this from here","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"636d9ff182b1ab8077e3ebbb65d05b6b92891449","unresolved":false,"context_lines":[{"line_number":273,"context_line":"                 session\u003dNone,"},{"line_number":274,"context_line":"                 auth\u003dNone,"},{"line_number":275,"context_line":"                 cacert\u003dNone,"},{"line_number":276,"context_line":"                 service_catalog_url\u003dNone,"},{"line_number":277,"context_line":"                 user_agent\u003d\u0027python-manilaclient\u0027,"},{"line_number":278,"context_line":"                 use_keyring\u003dFalse,"},{"line_number":279,"context_line":"                 force_new_token\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":37,"id":"d194a0b5_f0867b72","line":276,"range":{"start_line":276,"start_character":0,"end_line":276,"end_character":42},"in_reply_to":"b32fe1c5_aef94dc7","updated":"2022-07-08 14:37:58.000000000","message":"Done","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e4cae8f42af15232d0edfaafb41229019d0d74d2","unresolved":true,"context_lines":[{"line_number":275,"context_line":"                 cacert\u003dNone,"},{"line_number":276,"context_line":"                 service_catalog_url\u003dNone,"},{"line_number":277,"context_line":"                 user_agent\u003d\u0027python-manilaclient\u0027,"},{"line_number":278,"context_line":"                 use_keyring\u003dFalse,"},{"line_number":279,"context_line":"                 force_new_token\u003dFalse,"},{"line_number":280,"context_line":"                 cached_token_lifetime\u003d300,"},{"line_number":281,"context_line":"                 api_version\u003dmanilaclient.API_MIN_VERSION,"},{"line_number":282,"context_line":"                 user_id\u003dNone,"},{"line_number":283,"context_line":"                 user_domain_id\u003dNone,"}],"source_content_type":"text/x-python","patch_set":37,"id":"8e3ae3d1_3ef3a9a6","line":280,"range":{"start_line":278,"start_character":0,"end_line":280,"end_character":43},"updated":"2021-02-11 01:57:45.000000000","message":"These three options are only relevant to keystoneclient - no need to carry them forward when we stop using keystoneclient. lets deprecate them - i.e., call out that they\u0027re not even used, like the removal on line 235 - we can drop it in a future release","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"636d9ff182b1ab8077e3ebbb65d05b6b92891449","unresolved":false,"context_lines":[{"line_number":275,"context_line":"                 cacert\u003dNone,"},{"line_number":276,"context_line":"                 service_catalog_url\u003dNone,"},{"line_number":277,"context_line":"                 user_agent\u003d\u0027python-manilaclient\u0027,"},{"line_number":278,"context_line":"                 use_keyring\u003dFalse,"},{"line_number":279,"context_line":"                 force_new_token\u003dFalse,"},{"line_number":280,"context_line":"                 cached_token_lifetime\u003d300,"},{"line_number":281,"context_line":"                 api_version\u003dmanilaclient.API_MIN_VERSION,"},{"line_number":282,"context_line":"                 user_id\u003dNone,"},{"line_number":283,"context_line":"                 user_domain_id\u003dNone,"}],"source_content_type":"text/x-python","patch_set":37,"id":"b0a3c05a_64fd5c57","line":280,"range":{"start_line":278,"start_character":0,"end_line":280,"end_character":43},"in_reply_to":"8e3ae3d1_3ef3a9a6","updated":"2022-07-08 14:37:58.000000000","message":"Done","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e4cae8f42af15232d0edfaafb41229019d0d74d2","unresolved":true,"context_lines":[{"line_number":289,"context_line":"                 auth_token\u003dNone,"},{"line_number":290,"context_line":"                 auth_type\u003d\u0027password\u0027,"},{"line_number":291,"context_line":"                 endpoint_override\u003dNone,"},{"line_number":292,"context_line":"                 interface\u003dNone,"},{"line_number":293,"context_line":"                 **kwargs):"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        # NOTE(vkmc) backwards compat for people using api_key"}],"source_content_type":"text/x-python","patch_set":37,"id":"71d9d7d0_51d2cfac","line":292,"range":{"start_line":292,"start_character":0,"end_line":292,"end_character":32},"updated":"2021-02-11 01:57:45.000000000","message":"interface\u003d\"public\"","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"636d9ff182b1ab8077e3ebbb65d05b6b92891449","unresolved":false,"context_lines":[{"line_number":289,"context_line":"                 auth_token\u003dNone,"},{"line_number":290,"context_line":"                 auth_type\u003d\u0027password\u0027,"},{"line_number":291,"context_line":"                 endpoint_override\u003dNone,"},{"line_number":292,"context_line":"                 interface\u003dNone,"},{"line_number":293,"context_line":"                 **kwargs):"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        # NOTE(vkmc) backwards compat for people using api_key"}],"source_content_type":"text/x-python","patch_set":37,"id":"ebb96b73_bc27568c","line":292,"range":{"start_line":292,"start_character":0,"end_line":292,"end_character":32},"in_reply_to":"71d9d7d0_51d2cfac","updated":"2022-07-08 14:37:58.000000000","message":"Done","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e4cae8f42af15232d0edfaafb41229019d0d74d2","unresolved":true,"context_lines":[{"line_number":292,"context_line":"                 interface\u003dNone,"},{"line_number":293,"context_line":"                 **kwargs):"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        # NOTE(vkmc) backwards compat for people using api_key"},{"line_number":296,"context_line":"        if not password:"},{"line_number":297,"context_line":"            password \u003d api_key"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        # NOTE(vkmc) backwards compat for people using tenant_id"},{"line_number":300,"context_line":"        if not project_id:"}],"source_content_type":"text/x-python","patch_set":37,"id":"8fc46dcc_68257c0e","line":297,"range":{"start_line":295,"start_character":8,"end_line":297,"end_character":30},"updated":"2021-02-11 01:57:45.000000000","message":"this was deprecated a while ago, lets remove it","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"636d9ff182b1ab8077e3ebbb65d05b6b92891449","unresolved":false,"context_lines":[{"line_number":292,"context_line":"                 interface\u003dNone,"},{"line_number":293,"context_line":"                 **kwargs):"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        # NOTE(vkmc) backwards compat for people using api_key"},{"line_number":296,"context_line":"        if not password:"},{"line_number":297,"context_line":"            password \u003d api_key"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        # NOTE(vkmc) backwards compat for people using tenant_id"},{"line_number":300,"context_line":"        if not project_id:"}],"source_content_type":"text/x-python","patch_set":37,"id":"9b6a0307_c532b5b9","line":297,"range":{"start_line":295,"start_character":8,"end_line":297,"end_character":30},"in_reply_to":"8fc46dcc_68257c0e","updated":"2022-07-08 14:37:58.000000000","message":"Done","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e4cae8f42af15232d0edfaafb41229019d0d74d2","unresolved":true,"context_lines":[{"line_number":296,"context_line":"        if not password:"},{"line_number":297,"context_line":"            password \u003d api_key"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        # NOTE(vkmc) backwards compat for people using tenant_id"},{"line_number":300,"context_line":"        if not project_id:"},{"line_number":301,"context_line":"            project_id \u003d tenant_id"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        # NOTE(vkmc) backwards compat for people using endpoint_type"},{"line_number":304,"context_line":"        if not interface:"}],"source_content_type":"text/x-python","patch_set":37,"id":"e6a6570e_1e49f6c8","line":301,"range":{"start_line":299,"start_character":0,"end_line":301,"end_character":34},"updated":"2021-02-11 01:57:45.000000000","message":"project_id \u003d kwargs.get(\"tenant_id\", project_id)","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"636d9ff182b1ab8077e3ebbb65d05b6b92891449","unresolved":false,"context_lines":[{"line_number":296,"context_line":"        if not password:"},{"line_number":297,"context_line":"            password \u003d api_key"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        # NOTE(vkmc) backwards compat for people using tenant_id"},{"line_number":300,"context_line":"        if not project_id:"},{"line_number":301,"context_line":"            project_id \u003d tenant_id"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        # NOTE(vkmc) backwards compat for people using endpoint_type"},{"line_number":304,"context_line":"        if not interface:"}],"source_content_type":"text/x-python","patch_set":37,"id":"15f32119_78355f82","line":301,"range":{"start_line":299,"start_character":0,"end_line":301,"end_character":34},"in_reply_to":"e6a6570e_1e49f6c8","updated":"2022-07-08 14:37:58.000000000","message":"Done","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e4cae8f42af15232d0edfaafb41229019d0d74d2","unresolved":true,"context_lines":[{"line_number":299,"context_line":"        # NOTE(vkmc) backwards compat for people using tenant_id"},{"line_number":300,"context_line":"        if not project_id:"},{"line_number":301,"context_line":"            project_id \u003d tenant_id"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        # NOTE(vkmc) backwards compat for people using endpoint_type"},{"line_number":304,"context_line":"        if not interface:"},{"line_number":305,"context_line":"            interface \u003d endpoint_type"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        if not interface:"},{"line_number":308,"context_line":"            interface \u003d \u0027public\u0027"}],"source_content_type":"text/x-python","patch_set":37,"id":"17ee1fe8_d74febe8","line":305,"range":{"start_line":302,"start_character":0,"end_line":305,"end_character":37},"updated":"2021-02-11 01:57:45.000000000","message":"interface \u003d kwargs.get(\"endpoint_type\", interface)","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"636d9ff182b1ab8077e3ebbb65d05b6b92891449","unresolved":false,"context_lines":[{"line_number":299,"context_line":"        # NOTE(vkmc) backwards compat for people using tenant_id"},{"line_number":300,"context_line":"        if not project_id:"},{"line_number":301,"context_line":"            project_id \u003d tenant_id"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        # NOTE(vkmc) backwards compat for people using endpoint_type"},{"line_number":304,"context_line":"        if not interface:"},{"line_number":305,"context_line":"            interface \u003d endpoint_type"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        if not interface:"},{"line_number":308,"context_line":"            interface \u003d \u0027public\u0027"}],"source_content_type":"text/x-python","patch_set":37,"id":"6182388b_59b272be","line":305,"range":{"start_line":302,"start_character":0,"end_line":305,"end_character":37},"in_reply_to":"17ee1fe8_d74febe8","updated":"2022-07-08 14:37:58.000000000","message":"Done","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e4cae8f42af15232d0edfaafb41229019d0d74d2","unresolved":true,"context_lines":[{"line_number":304,"context_line":"        if not interface:"},{"line_number":305,"context_line":"            interface \u003d endpoint_type"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        if not interface:"},{"line_number":308,"context_line":"            interface \u003d \u0027public\u0027"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        if not service_name:"},{"line_number":311,"context_line":"            service_name \u003d kwargs.get(\"share_service_name\", service_name)"}],"source_content_type":"text/x-python","patch_set":37,"id":"6e1a8e77_fd07c63e","line":308,"range":{"start_line":307,"start_character":0,"end_line":308,"end_character":32},"updated":"2021-02-11 01:57:45.000000000","message":"define default in signature","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"636d9ff182b1ab8077e3ebbb65d05b6b92891449","unresolved":false,"context_lines":[{"line_number":304,"context_line":"        if not interface:"},{"line_number":305,"context_line":"            interface \u003d endpoint_type"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        if not interface:"},{"line_number":308,"context_line":"            interface \u003d \u0027public\u0027"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        if not service_name:"},{"line_number":311,"context_line":"            service_name \u003d kwargs.get(\"share_service_name\", service_name)"}],"source_content_type":"text/x-python","patch_set":37,"id":"4a57a0e1_4cc6f8c8","line":308,"range":{"start_line":307,"start_character":0,"end_line":308,"end_character":32},"in_reply_to":"6e1a8e77_fd07c63e","updated":"2022-07-08 14:37:58.000000000","message":"Done","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e4cae8f42af15232d0edfaafb41229019d0d74d2","unresolved":true,"context_lines":[{"line_number":307,"context_line":"        if not interface:"},{"line_number":308,"context_line":"            interface \u003d \u0027public\u0027"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        if not service_name:"},{"line_number":311,"context_line":"            service_name \u003d kwargs.get(\"share_service_name\", service_name)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        # NOTE(vkmc) Backwards compat for people using input_auth_token"},{"line_number":314,"context_line":"        if input_auth_token:"}],"source_content_type":"text/x-python","patch_set":37,"id":"2d5fcbba_05026dd7","line":311,"range":{"start_line":310,"start_character":0,"end_line":311,"end_character":73},"updated":"2021-02-11 01:57:45.000000000","message":"we can drop support for share_service_name","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"636d9ff182b1ab8077e3ebbb65d05b6b92891449","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        if not interface:"},{"line_number":308,"context_line":"            interface \u003d \u0027public\u0027"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        if not service_name:"},{"line_number":311,"context_line":"            service_name \u003d kwargs.get(\"share_service_name\", service_name)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        # NOTE(vkmc) Backwards compat for people using input_auth_token"},{"line_number":314,"context_line":"        if input_auth_token:"}],"source_content_type":"text/x-python","patch_set":37,"id":"41b8456f_081e0d9a","line":311,"range":{"start_line":310,"start_character":0,"end_line":311,"end_character":73},"in_reply_to":"2d5fcbba_05026dd7","updated":"2022-07-08 14:37:58.000000000","message":"Done","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e4cae8f42af15232d0edfaafb41229019d0d74d2","unresolved":true,"context_lines":[{"line_number":310,"context_line":"        if not service_name:"},{"line_number":311,"context_line":"            service_name \u003d kwargs.get(\"share_service_name\", service_name)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        # NOTE(vkmc) Backwards compat for people using input_auth_token"},{"line_number":314,"context_line":"        if input_auth_token:"},{"line_number":315,"context_line":"            auth_token \u003d input_auth_token"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        # NOTE(vkmc) Backwards compat for people using service_catalog_url"},{"line_number":318,"context_line":"        if not endpoint_override:"}],"source_content_type":"text/x-python","patch_set":37,"id":"d9e933ac_4f358140","line":315,"range":{"start_line":313,"start_character":0,"end_line":315,"end_character":41},"updated":"2021-02-11 01:57:45.000000000","message":"auth_token \u003d kwargs.get(\"input_auth_token\", auth_token)","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"636d9ff182b1ab8077e3ebbb65d05b6b92891449","unresolved":false,"context_lines":[{"line_number":310,"context_line":"        if not service_name:"},{"line_number":311,"context_line":"            service_name \u003d kwargs.get(\"share_service_name\", service_name)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        # NOTE(vkmc) Backwards compat for people using input_auth_token"},{"line_number":314,"context_line":"        if input_auth_token:"},{"line_number":315,"context_line":"            auth_token \u003d input_auth_token"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        # NOTE(vkmc) Backwards compat for people using service_catalog_url"},{"line_number":318,"context_line":"        if not endpoint_override:"}],"source_content_type":"text/x-python","patch_set":37,"id":"9a21f183_bcbb8888","line":315,"range":{"start_line":313,"start_character":0,"end_line":315,"end_character":41},"in_reply_to":"d9e933ac_4f358140","updated":"2022-07-08 14:37:58.000000000","message":"Done","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e4cae8f42af15232d0edfaafb41229019d0d74d2","unresolved":true,"context_lines":[{"line_number":314,"context_line":"        if input_auth_token:"},{"line_number":315,"context_line":"            auth_token \u003d input_auth_token"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        # NOTE(vkmc) Backwards compat for people using service_catalog_url"},{"line_number":318,"context_line":"        if not endpoint_override:"},{"line_number":319,"context_line":"            endpoint_override \u003d service_catalog_url"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"        self.api_version \u003d api_version"},{"line_number":322,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"a3bbd4a4_5eee99c9","line":319,"range":{"start_line":317,"start_character":8,"end_line":319,"end_character":51},"updated":"2021-02-11 01:57:45.000000000","message":"endpoint_override \u003d kwargs.get(\"service_catalog_url\", endpoint_override)","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"636d9ff182b1ab8077e3ebbb65d05b6b92891449","unresolved":false,"context_lines":[{"line_number":314,"context_line":"        if input_auth_token:"},{"line_number":315,"context_line":"            auth_token \u003d input_auth_token"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        # NOTE(vkmc) Backwards compat for people using service_catalog_url"},{"line_number":318,"context_line":"        if not endpoint_override:"},{"line_number":319,"context_line":"            endpoint_override \u003d service_catalog_url"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"        self.api_version \u003d api_version"},{"line_number":322,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"0b0fa9e6_90905a97","line":319,"range":{"start_line":317,"start_character":8,"end_line":319,"end_character":51},"in_reply_to":"a3bbd4a4_5eee99c9","updated":"2022-07-08 14:37:58.000000000","message":"Done","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e4cae8f42af15232d0edfaafb41229019d0d74d2","unresolved":true,"context_lines":[{"line_number":325,"context_line":"                   \"provide \u0027auth_token\u0027 and \u0027endpoint_override\u0027.\")"},{"line_number":326,"context_line":"            raise exceptions.ClientException(msg)"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        if endpoint_override and auth_token:"},{"line_number":329,"context_line":"            self.client \u003d httpclient.HTTPClient("},{"line_number":330,"context_line":"                api_version\u003dapi_version,"},{"line_number":331,"context_line":"                cacert\u003dcacert,"}],"source_content_type":"text/x-python","patch_set":37,"id":"0856de67_fc59c961","line":328,"range":{"start_line":328,"start_character":8,"end_line":328,"end_character":44},"updated":"2021-02-11 01:57:45.000000000","message":"if not session:","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"636d9ff182b1ab8077e3ebbb65d05b6b92891449","unresolved":false,"context_lines":[{"line_number":325,"context_line":"                   \"provide \u0027auth_token\u0027 and \u0027endpoint_override\u0027.\")"},{"line_number":326,"context_line":"            raise exceptions.ClientException(msg)"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        if endpoint_override and auth_token:"},{"line_number":329,"context_line":"            self.client \u003d httpclient.HTTPClient("},{"line_number":330,"context_line":"                api_version\u003dapi_version,"},{"line_number":331,"context_line":"                cacert\u003dcacert,"}],"source_content_type":"text/x-python","patch_set":37,"id":"78e3536a_a78473df","line":328,"range":{"start_line":328,"start_character":8,"end_line":328,"end_character":44},"in_reply_to":"0856de67_fc59c961","updated":"2022-07-08 14:37:58.000000000","message":"Done","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e4cae8f42af15232d0edfaafb41229019d0d74d2","unresolved":true,"context_lines":[{"line_number":326,"context_line":"            raise exceptions.ClientException(msg)"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        if endpoint_override and auth_token:"},{"line_number":329,"context_line":"            self.client \u003d httpclient.HTTPClient("},{"line_number":330,"context_line":"                api_version\u003dapi_version,"},{"line_number":331,"context_line":"                cacert\u003dcacert,"},{"line_number":332,"context_line":"                endpoint_override\u003dendpoint_override,"},{"line_number":333,"context_line":"                http_log_debug\u003dhttp_log_debug,"},{"line_number":334,"context_line":"                insecure\u003dinsecure,"},{"line_number":335,"context_line":"                retries\u003dretries,"},{"line_number":336,"context_line":"                timeout\u003dtimeout,"},{"line_number":337,"context_line":"                token\u003dauth_token,"},{"line_number":338,"context_line":"                user_agent\u003duser_agent,"},{"line_number":339,"context_line":"                **kwargs"},{"line_number":340,"context_line":"            )"},{"line_number":341,"context_line":"        else:"},{"line_number":342,"context_line":"            self.client \u003d _load_session_client("},{"line_number":343,"context_line":"                api_version\u003dapi_version,"}],"source_content_type":"text/x-python","patch_set":37,"id":"71377fbd_dafc6377","line":340,"range":{"start_line":329,"start_character":26,"end_line":340,"end_character":13},"updated":"2021-02-11 01:57:45.000000000","message":"Want to ask if we really need this?\nthe session client can handle endpoint override and auth-token and this is an internal detail - if the user doesn\u0027t want to use a keystone session auth object, we can internally fetch one and return a session client anyway?\n\nI think cinder has preserved their http client because they support interacting with the service in a standalone manner (i.e., when the service is using noauth) - we must check.\nWe\u0027ve never supported the use of python-manilaclient sdk with noauth - to do that, we may need a way to fake out all this keystone interaction, like cinder\u0027s doing. \n\nSo i don\u0027t mind us keeping the HTTPClient around to figure out the noauth piece; but, we should default to the SessionClient since that\u0027s what most users will use manila with keystone.","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"636d9ff182b1ab8077e3ebbb65d05b6b92891449","unresolved":false,"context_lines":[{"line_number":326,"context_line":"            raise exceptions.ClientException(msg)"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        if endpoint_override and auth_token:"},{"line_number":329,"context_line":"            self.client \u003d httpclient.HTTPClient("},{"line_number":330,"context_line":"                api_version\u003dapi_version,"},{"line_number":331,"context_line":"                cacert\u003dcacert,"},{"line_number":332,"context_line":"                endpoint_override\u003dendpoint_override,"},{"line_number":333,"context_line":"                http_log_debug\u003dhttp_log_debug,"},{"line_number":334,"context_line":"                insecure\u003dinsecure,"},{"line_number":335,"context_line":"                retries\u003dretries,"},{"line_number":336,"context_line":"                timeout\u003dtimeout,"},{"line_number":337,"context_line":"                token\u003dauth_token,"},{"line_number":338,"context_line":"                user_agent\u003duser_agent,"},{"line_number":339,"context_line":"                **kwargs"},{"line_number":340,"context_line":"            )"},{"line_number":341,"context_line":"        else:"},{"line_number":342,"context_line":"            self.client \u003d _load_session_client("},{"line_number":343,"context_line":"                api_version\u003dapi_version,"}],"source_content_type":"text/x-python","patch_set":37,"id":"17d53e6a_a6317d9c","line":340,"range":{"start_line":329,"start_character":26,"end_line":340,"end_character":13},"in_reply_to":"71377fbd_dafc6377","updated":"2022-07-08 14:37:58.000000000","message":"Done","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"}],"manilaclient/v2/share_group_types.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"02d16a43d058ace5154991755bc6c06d9e101d39","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"5faad753_ae5c497e","updated":"2019-09-12 06:28:29.000000000","message":"nit: please revert whitespace change to this file","commit_id":"199acfc3c2eb4c9b0cb2204e5c9724548ee66d7b"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"02d16a43d058ace5154991755bc6c06d9e101d39","unresolved":false,"context_lines":[{"line_number":378,"context_line":"    cliutils.print_list(response, columns, field_labels\u003dcolumn_labels)"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"@api_versions.wraps(\"2.0\")"},{"line_number":382,"context_line":"def do_endpoints(cs, args):"},{"line_number":383,"context_line":"    \"\"\"Discover endpoints that get returned from the authenticate services.\"\"\""},{"line_number":384,"context_line":"    session \u003d cs.client.session"}],"source_content_type":"text/x-python","patch_set":25,"id":"5faad753_ae0e898a","line":381,"range":{"start_line":381,"start_character":0,"end_line":381,"end_character":26},"updated":"2019-09-12 06:28:29.000000000","message":"The version wrapper only applies to manila\u0027s versions - this command is for keystone..","commit_id":"199acfc3c2eb4c9b0cb2204e5c9724548ee66d7b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"02d16a43d058ace5154991755bc6c06d9e101d39","unresolved":false,"context_lines":[{"line_number":389,"context_line":"        cliutils.print_dict(endpoints[e][0], e)"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"@api_versions.wraps(\"2.0\")"},{"line_number":393,"context_line":"def do_credentials(cs, args):"},{"line_number":394,"context_line":"    \"\"\"Show user credentials returned from auth.\"\"\""},{"line_number":395,"context_line":"    session \u003d cs.client.session"}],"source_content_type":"text/x-python","patch_set":25,"id":"5faad753_6e2891e1","line":392,"range":{"start_line":392,"start_character":0,"end_line":392,"end_character":26},"updated":"2019-09-12 06:28:29.000000000","message":"same comment as above","commit_id":"199acfc3c2eb4c9b0cb2204e5c9724548ee66d7b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"02d16a43d058ace5154991755bc6c06d9e101d39","unresolved":false,"context_lines":[{"line_number":402,"context_line":"        \u0027expires\u0027: data[\u0027expires_at\u0027],"},{"line_number":403,"context_line":"        \u0027id\u0027: access._auth_token,"},{"line_number":404,"context_line":"        \u0027audit_ids\u0027: data[\u0027audit_ids\u0027],"},{"line_number":405,"context_line":"        \u0027project\u0027: data[\u0027project\u0027],"},{"line_number":406,"context_line":"    }"},{"line_number":407,"context_line":"    cliutils.print_dict(token_data, \"Token\")"},{"line_number":408,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"5faad753_793cddc7","line":405,"range":{"start_line":405,"start_character":9,"end_line":405,"end_character":16},"updated":"2019-09-12 06:28:29.000000000","message":"nice, thanks!","commit_id":"199acfc3c2eb4c9b0cb2204e5c9724548ee66d7b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"02d16a43d058ace5154991755bc6c06d9e101d39","unresolved":false,"context_lines":[{"line_number":463,"context_line":"@api_versions.wraps(\"1.0\")"},{"line_number":464,"context_line":"def do_quota_show(cs, args):"},{"line_number":465,"context_line":"    \"\"\"List the quotas for a tenant/user.\"\"\""},{"line_number":466,"context_line":"    if cs.api_version \u003c api_versions.APIVersion(\"2.0\"):"},{"line_number":467,"context_line":"        project \u003d args.tenant_id or cs.keystone_client.project_id"},{"line_number":468,"context_line":"    else:"},{"line_number":469,"context_line":"        project \u003d args.tenant_id or cs.client.session.get_project_id()"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"    kwargs \u003d {"},{"line_number":472,"context_line":"        \"tenant_id\": project,"}],"source_content_type":"text/x-python","patch_set":25,"id":"5faad753_796a9db3","line":469,"range":{"start_line":466,"start_character":4,"end_line":469,"end_character":70},"updated":"2019-09-12 06:28:29.000000000","message":"project \u003d args.tenant_id or cs.client.session.get_project_id()\n\n\ndon\u0027t need the rest..","commit_id":"199acfc3c2eb4c9b0cb2204e5c9724548ee66d7b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"02d16a43d058ace5154991755bc6c06d9e101d39","unresolved":false,"context_lines":[{"line_number":490,"context_line":"def do_quota_defaults(cs, args):"},{"line_number":491,"context_line":"    \"\"\"List the default quotas for a tenant.\"\"\""},{"line_number":492,"context_line":"    if cs.api_version \u003c api_versions.APIVersion(\"2.0\"):"},{"line_number":493,"context_line":"        project \u003d args.tenant_id or cs.keystone_client.project_id"},{"line_number":494,"context_line":"    else:"},{"line_number":495,"context_line":"        project \u003d args.tenant_id or cs.client.session.get_project_id()"},{"line_number":496,"context_line":"    _quota_set_pretty_show(cs.quotas.defaults(project))"}],"source_content_type":"text/x-python","patch_set":25,"id":"5faad753_cebbc56f","line":493,"range":{"start_line":493,"start_character":39,"end_line":493,"end_character":65},"updated":"2019-09-12 06:28:29.000000000","message":"You removed keystone_client though - \n\nthis condition itself is not necessary - it works well without it","commit_id":"199acfc3c2eb4c9b0cb2204e5c9724548ee66d7b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"02d16a43d058ace5154991755bc6c06d9e101d39","unresolved":false,"context_lines":[{"line_number":630,"context_line":""},{"line_number":631,"context_line":"    The quota will revert back to default (Admin only)."},{"line_number":632,"context_line":"    \"\"\""},{"line_number":633,"context_line":"    if cs.api_version \u003c api_versions.APIVersion(\"2.0\"):"},{"line_number":634,"context_line":"        project_id \u003d args.tenant_id or cs.keystone_client.project_id"},{"line_number":635,"context_line":"    else:"},{"line_number":636,"context_line":"        project_id \u003d args.tenant_id or cs.client.session.get_project_id()"},{"line_number":637,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"5faad753_8eadcd32","line":634,"range":{"start_line":633,"start_character":0,"end_line":634,"end_character":68},"updated":"2019-09-12 06:28:29.000000000","message":"same comment as above","commit_id":"199acfc3c2eb4c9b0cb2204e5c9724548ee66d7b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"02d16a43d058ace5154991755bc6c06d9e101d39","unresolved":false,"context_lines":[{"line_number":3921,"context_line":"        \u0027optional_extra_specs\u0027: _print_type_optional_extra_specs(stype),"},{"line_number":3922,"context_line":"    }"},{"line_number":3923,"context_line":"    if show_des:"},{"line_number":3924,"context_line":"        try:"},{"line_number":3925,"context_line":"            stype_dict[\u0027Description\u0027] \u003d stype.description"},{"line_number":3926,"context_line":"        except AttributeError:"},{"line_number":3927,"context_line":"            stype_dict[\u0027Description\u0027] \u003d None"},{"line_number":3928,"context_line":"    cliutils.print_dict(stype_dict)"},{"line_number":3929,"context_line":""},{"line_number":3930,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"5faad753_f928cd86","line":3927,"range":{"start_line":3924,"start_character":8,"end_line":3927,"end_character":44},"updated":"2019-09-12 06:28:29.000000000","message":"unrelated, bug fix?","commit_id":"199acfc3c2eb4c9b0cb2204e5c9724548ee66d7b"}],"releasenotes/notes/remove-keystoneclient-dependency-from-manilaclient-d3b7a69b4d3130f1.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"02d16a43d058ace5154991755bc6c06d9e101d39","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    The behaviour is the following"},{"line_number":21,"context_line":"    - If the user has an auth_token and the endpoint_url, they"},{"line_number":22,"context_line":"    can create an HTTPClient as we always did. This is the priority."},{"line_number":23,"context_line":"    - If one of them (auth_token or endpoint_url) are not provided,"},{"line_number":24,"context_line":"    then we proceed to create a Session (using Token or Password"},{"line_number":25,"context_line":"    authentication, depending on the provided parameters), get the"},{"line_number":26,"context_line":"    endpoint_url and then provide a SessionClient."}],"source_content_type":"text/x-yaml","patch_set":25,"id":"5faad753_6efad175","line":23,"range":{"start_line":23,"start_character":50,"end_line":23,"end_character":53},"updated":"2019-09-12 06:28:29.000000000","message":"is","commit_id":"199acfc3c2eb4c9b0cb2204e5c9724548ee66d7b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e4cae8f42af15232d0edfaafb41229019d0d74d2","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    to authenticate with keystone using keystoneauth components."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    The behaviour is the following"},{"line_number":21,"context_line":"    - If the user has an auth_token and the endpoint_url, they"},{"line_number":22,"context_line":"    can create an HTTPClient as we always did. This is the priority."},{"line_number":23,"context_line":"    - If one of them (auth_token or endpoint_url) are not provided,"},{"line_number":24,"context_line":"    then we proceed to create a Session (using Token or Password"},{"line_number":25,"context_line":"    authentication, depending on the provided parameters), get the"},{"line_number":26,"context_line":"    endpoint_url and then provide a SessionClient."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"other:"},{"line_number":29,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":37,"id":"6568aed1_4281b9ba","line":26,"range":{"start_line":21,"start_character":0,"end_line":26,"end_character":50},"updated":"2021-02-11 01:57:45.000000000","message":"HTTPClient was an internal client implementation, so this detail doesn\u0027t help consumers.. \n\nIt\u0027d be better to call out in an upgrade section that keystoneclient\u0027s usage has been replaced by keystoneauth","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"636d9ff182b1ab8077e3ebbb65d05b6b92891449","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    to authenticate with keystone using keystoneauth components."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    The behaviour is the following"},{"line_number":21,"context_line":"    - If the user has an auth_token and the endpoint_url, they"},{"line_number":22,"context_line":"    can create an HTTPClient as we always did. This is the priority."},{"line_number":23,"context_line":"    - If one of them (auth_token or endpoint_url) are not provided,"},{"line_number":24,"context_line":"    then we proceed to create a Session (using Token or Password"},{"line_number":25,"context_line":"    authentication, depending on the provided parameters), get the"},{"line_number":26,"context_line":"    endpoint_url and then provide a SessionClient."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"other:"},{"line_number":29,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":37,"id":"ca054e6d_577ccdea","line":26,"range":{"start_line":21,"start_character":0,"end_line":26,"end_character":50},"in_reply_to":"6568aed1_4281b9ba","updated":"2022-07-08 14:37:58.000000000","message":"Done","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e4cae8f42af15232d0edfaafb41229019d0d74d2","unresolved":true,"context_lines":[{"line_number":25,"context_line":"    authentication, depending on the provided parameters), get the"},{"line_number":26,"context_line":"    endpoint_url and then provide a SessionClient."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"other:"},{"line_number":29,"context_line":"  - |"},{"line_number":30,"context_line":"    Unit tests have been refactored to reflect the new implementation"},{"line_number":31,"context_line":"    - test_adapter_properties"},{"line_number":32,"context_line":"    - test_auth_via_token_invalid covered by test_auth_via_auth_token_invalid"},{"line_number":33,"context_line":"    - test_auth_via_token_and_session covered by"},{"line_number":34,"context_line":"    test_auth_via_token_and_session"},{"line_number":35,"context_line":"    - test_auth_via_token covered by test_auth_via_token,"},{"line_number":36,"context_line":"    test_init_via_auth_token_with_retries"},{"line_number":37,"context_line":"    - test_valid_region_name_v1, test_nonexistent_region_name,"},{"line_number":38,"context_line":"    test_regions_with_same_name need coverage. WIP."},{"line_number":39,"context_line":"    - test_client_init_no_session_no_auth_token_v3,"},{"line_number":40,"context_line":"    test_client_init_no_session_no_auth_token_v2,"},{"line_number":41,"context_line":"    test_client_init_no_session_no_auth_token_endpoint_not_found"},{"line_number":42,"context_line":"    covered by test_init_with_interface, test_init_with_legacy_service_type,"},{"line_number":43,"context_line":"    test_init_with_password, test_init_with_api_key"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    New unit tests"},{"line_number":46,"context_line":"    - test_init_with_session"}],"source_content_type":"text/x-yaml","patch_set":37,"id":"84a632dd_14d14810","line":46,"range":{"start_line":28,"start_character":0,"end_line":46,"end_character":28},"updated":"2021-02-11 01:57:45.000000000","message":"No need to add unit test changes in release notes.","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"636d9ff182b1ab8077e3ebbb65d05b6b92891449","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    authentication, depending on the provided parameters), get the"},{"line_number":26,"context_line":"    endpoint_url and then provide a SessionClient."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"other:"},{"line_number":29,"context_line":"  - |"},{"line_number":30,"context_line":"    Unit tests have been refactored to reflect the new implementation"},{"line_number":31,"context_line":"    - test_adapter_properties"},{"line_number":32,"context_line":"    - test_auth_via_token_invalid covered by test_auth_via_auth_token_invalid"},{"line_number":33,"context_line":"    - test_auth_via_token_and_session covered by"},{"line_number":34,"context_line":"    test_auth_via_token_and_session"},{"line_number":35,"context_line":"    - test_auth_via_token covered by test_auth_via_token,"},{"line_number":36,"context_line":"    test_init_via_auth_token_with_retries"},{"line_number":37,"context_line":"    - test_valid_region_name_v1, test_nonexistent_region_name,"},{"line_number":38,"context_line":"    test_regions_with_same_name need coverage. WIP."},{"line_number":39,"context_line":"    - test_client_init_no_session_no_auth_token_v3,"},{"line_number":40,"context_line":"    test_client_init_no_session_no_auth_token_v2,"},{"line_number":41,"context_line":"    test_client_init_no_session_no_auth_token_endpoint_not_found"},{"line_number":42,"context_line":"    covered by test_init_with_interface, test_init_with_legacy_service_type,"},{"line_number":43,"context_line":"    test_init_with_password, test_init_with_api_key"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    New unit tests"},{"line_number":46,"context_line":"    - test_init_with_session"}],"source_content_type":"text/x-yaml","patch_set":37,"id":"7eaf25db_1af4dac1","line":46,"range":{"start_line":28,"start_character":0,"end_line":46,"end_character":28},"in_reply_to":"84a632dd_14d14810","updated":"2022-07-08 14:37:58.000000000","message":"Done","commit_id":"f3fdf3831b8c441a6fddfa953dd7da515e5e6e1c"}]}