)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@canonical.com","username":"toabctl"},"change_message_id":"0cc9b9636bbff866c17f0e0aa19c42ad0e45421e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"and showing of shares when the `--count` param is used. This patch-set"},{"line_number":12,"context_line":"adds a fix for this case."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-bug: #bug/1822815"},{"line_number":15,"context_line":"Change-Id: I4e3ba86c38a58c8fa56b5fd23839551f4b6c2366"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_20c50f3d","line":14,"updated":"2019-07-07 08:10:36.000000000","message":"Wrong syntax: just use \"Closes-bug: #1822815\"","commit_id":"e5aa982bc6e21f7c810fe6eb96f8deda1e27805c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e9e73ea3d9a6705b11908a82ac53b55a6496fd0c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"and showing of shares when the `--count` param is used. This patch-set"},{"line_number":12,"context_line":"adds a fix for this case."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-bug: #bug/1822815"},{"line_number":15,"context_line":"Change-Id: I4e3ba86c38a58c8fa56b5fd23839551f4b6c2366"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7faddb67_5fcb2c49","line":14,"range":{"start_line":14,"start_character":12,"end_line":14,"end_character":17},"updated":"2019-07-25 21:34:02.000000000","message":"Remove, or replace with just \"#\"","commit_id":"9061705efb7820b4da9bc5fe3cbcce7933555401"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6d4c42bc5e6a724e19b813e8d5d24ccaab600d44","unresolved":false,"context_lines":[{"line_number":1850,"context_line":"    dest\u003d\u0027count\u0027,"},{"line_number":1851,"context_line":"    metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":1852,"context_line":"    choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":1853,"context_line":"    default\u003dFalse,"},{"line_number":1854,"context_line":"    help\u003d\u0027Display total number of shares to return. \u0027"},{"line_number":1855,"context_line":"         \u0027Available only for microversion \u003e\u003d 2.42.\u0027)"},{"line_number":1856,"context_line":"@cliutils.service_type(\u0027sharev2\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_1425a4c2","line":1853,"range":{"start_line":1853,"start_character":17,"end_line":1853,"end_character":18},"updated":"2019-07-08 23:37:07.000000000","message":"This is missing ``action\u003d\u0027store_true\u0027``","commit_id":"8d4a8e82ec3e3bf1bb583984868b9fde7f7653f8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e26ef0ecd76a33be56e50efacd292deee1b003d","unresolved":false,"context_lines":[{"line_number":1850,"context_line":"    dest\u003d\u0027count\u0027,"},{"line_number":1851,"context_line":"    metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":1852,"context_line":"    choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":1853,"context_line":"    default\u003dFalse,"},{"line_number":1854,"context_line":"    help\u003d\u0027Display total number of shares to return. \u0027"},{"line_number":1855,"context_line":"         \u0027Available only for microversion \u003e\u003d 2.42.\u0027)"},{"line_number":1856,"context_line":"@cliutils.service_type(\u0027sharev2\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_57223ea6","line":1853,"range":{"start_line":1853,"start_character":17,"end_line":1853,"end_character":18},"in_reply_to":"7faddb67_1425a4c2","updated":"2019-07-08 23:37:32.000000000","message":"Ignore this comment, for some reason we\u0027re using a metavar instead.","commit_id":"8d4a8e82ec3e3bf1bb583984868b9fde7f7653f8"},{"author":{"_account_id":29958,"name":"Soledad Kuczala","email":"sol.kuczala@gmail.com","username":"SolKuczala"},"change_message_id":"b805196852a0ba1a8a803ed047cabf472133067e","unresolved":false,"context_lines":[{"line_number":1850,"context_line":"    dest\u003d\u0027count\u0027,"},{"line_number":1851,"context_line":"    metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":1852,"context_line":"    choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":1853,"context_line":"    default\u003dFalse,"},{"line_number":1854,"context_line":"    help\u003d\u0027Display total number of shares to return. \u0027"},{"line_number":1855,"context_line":"         \u0027Available only for microversion \u003e\u003d 2.42.\u0027)"},{"line_number":1856,"context_line":"@cliutils.service_type(\u0027sharev2\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_9aae9296","line":1853,"range":{"start_line":1853,"start_character":17,"end_line":1853,"end_character":18},"in_reply_to":"7faddb67_57223ea6","updated":"2019-07-09 15:30:49.000000000","message":"oki","commit_id":"8d4a8e82ec3e3bf1bb583984868b9fde7f7653f8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6d4c42bc5e6a724e19b813e8d5d24ccaab600d44","unresolved":false,"context_lines":[{"line_number":1934,"context_line":"        try:"},{"line_number":1935,"context_line":"            shares, total_count \u003d cs.shares.list("},{"line_number":1936,"context_line":"                search_opts\u003dsearch_opts, sort_key\u003dargs.sort_key,"},{"line_number":1937,"context_line":"                sort_dir\u003dargs.sort_dir,"},{"line_number":1938,"context_line":"            )"},{"line_number":1939,"context_line":"        except ValueError:"},{"line_number":1940,"context_line":"            shares, total_count \u003d [], 0"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_f402480b","line":1937,"range":{"start_line":1937,"start_character":38,"end_line":1937,"end_character":39},"updated":"2019-07-08 23:37:07.000000000","message":"please remove this trailing comma","commit_id":"8d4a8e82ec3e3bf1bb583984868b9fde7f7653f8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e9e73ea3d9a6705b11908a82ac53b55a6496fd0c","unresolved":false,"context_lines":[{"line_number":1931,"context_line":"    total_count \u003d 0"},{"line_number":1932,"context_line":"    if strutils.bool_from_string(args.count, strict\u003dTrue):"},{"line_number":1933,"context_line":"        search_opts[\u0027with_count\u0027] \u003d args.count"},{"line_number":1934,"context_line":"        try:"},{"line_number":1935,"context_line":"            shares, total_count \u003d cs.shares.list("},{"line_number":1936,"context_line":"                search_opts\u003dsearch_opts, sort_key\u003dargs.sort_key,"},{"line_number":1937,"context_line":"                sort_dir\u003dargs.sort_dir,"},{"line_number":1938,"context_line":"            )"},{"line_number":1939,"context_line":"        except ValueError:"},{"line_number":1940,"context_line":"            shares, total_count \u003d [], 0"},{"line_number":1941,"context_line":"    else:"},{"line_number":1942,"context_line":"        shares \u003d cs.shares.list("},{"line_number":1943,"context_line":"            search_opts\u003dsearch_opts, sort_key\u003dargs.sort_key,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_3a88bec4","line":1940,"range":{"start_line":1934,"start_character":8,"end_line":1940,"end_character":39},"updated":"2019-07-25 21:34:02.000000000","message":"This exception handling is incorrect. It hides all the exceptions that the SDK can raise - See [1][2][3]\n\n[1] https://github.com/openstack/python-manilaclient/blob/07564879ae4bdcb73e856b3aedcb79e4420fa7eb/manilaclient/v2/shares.py#L392\n[2] https://github.com/openstack/python-manilaclient/blob/07564879ae4bdcb73e856b3aedcb79e4420fa7eb/manilaclient/v2/shares.py#L399\n\n\nI don\u0027t believe that this is the bug fix for the said bug. We have a problem in the API - when the query parameter \"with_count\u003dTrue\" is sent, there SHOULD always be a count returned by the API. The problem here is because of bad coding here: https://github.com/openstack/manila/blob/6dac83660dd650ad650739d7c141d5d6a9d84101/manila/api/views/shares.py#L182\n\n\nWhile you can defensively add a check here and make sure to impute a count value when the API does not return it, I would strongly suggest fixing the manila API. This shell is just one consumer of the API/python-manilaclient SDK - everyone else depending on the code must get the \"fix\" as well.","commit_id":"9061705efb7820b4da9bc5fe3cbcce7933555401"},{"author":{"_account_id":29958,"name":"Soledad Kuczala","email":"sol.kuczala@gmail.com","username":"SolKuczala"},"change_message_id":"917de0222e5cd4c0ebf2266ca7f15952170f4670","unresolved":false,"context_lines":[{"line_number":1931,"context_line":"    total_count \u003d 0"},{"line_number":1932,"context_line":"    if strutils.bool_from_string(args.count, strict\u003dTrue):"},{"line_number":1933,"context_line":"        search_opts[\u0027with_count\u0027] \u003d args.count"},{"line_number":1934,"context_line":"        try:"},{"line_number":1935,"context_line":"            shares, total_count \u003d cs.shares.list("},{"line_number":1936,"context_line":"                search_opts\u003dsearch_opts, sort_key\u003dargs.sort_key,"},{"line_number":1937,"context_line":"                sort_dir\u003dargs.sort_dir,"},{"line_number":1938,"context_line":"            )"},{"line_number":1939,"context_line":"        except ValueError:"},{"line_number":1940,"context_line":"            shares, total_count \u003d [], 0"},{"line_number":1941,"context_line":"    else:"},{"line_number":1942,"context_line":"        shares \u003d cs.shares.list("},{"line_number":1943,"context_line":"            search_opts\u003dsearch_opts, sort_key\u003dargs.sort_key,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_59725eaf","line":1940,"range":{"start_line":1934,"start_character":8,"end_line":1940,"end_character":39},"in_reply_to":"7faddb67_3a88bec4","updated":"2019-07-26 14:55:15.000000000","message":"So, it\u0027s better to reverse this, and modify the code in Manila\u0027s api, right? Could that be:\nif count \u003e\u003d 0:\n shares_dict[\u0027count\u0027] \u003d count\n?","commit_id":"9061705efb7820b4da9bc5fe3cbcce7933555401"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"83da11b8dbe7f035922402ebed1f72757fde7e2f","unresolved":false,"context_lines":[{"line_number":1931,"context_line":"    total_count \u003d 0"},{"line_number":1932,"context_line":"    if strutils.bool_from_string(args.count, strict\u003dTrue):"},{"line_number":1933,"context_line":"        search_opts[\u0027with_count\u0027] \u003d args.count"},{"line_number":1934,"context_line":"        try:"},{"line_number":1935,"context_line":"            shares, total_count \u003d cs.shares.list("},{"line_number":1936,"context_line":"                search_opts\u003dsearch_opts, sort_key\u003dargs.sort_key,"},{"line_number":1937,"context_line":"                sort_dir\u003dargs.sort_dir,"},{"line_number":1938,"context_line":"            )"},{"line_number":1939,"context_line":"        except ValueError:"},{"line_number":1940,"context_line":"            shares, total_count \u003d [], 0"},{"line_number":1941,"context_line":"    else:"},{"line_number":1942,"context_line":"        shares \u003d cs.shares.list("},{"line_number":1943,"context_line":"            search_opts\u003dsearch_opts, sort_key\u003dargs.sort_key,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_d98bae65","line":1940,"range":{"start_line":1934,"start_character":8,"end_line":1940,"end_character":39},"in_reply_to":"7faddb67_59725eaf","updated":"2019-07-26 15:01:58.000000000","message":"or simply \"if count is not None\", yes.","commit_id":"9061705efb7820b4da9bc5fe3cbcce7933555401"},{"author":{"_account_id":29958,"name":"Soledad Kuczala","email":"sol.kuczala@gmail.com","username":"SolKuczala"},"change_message_id":"9096103e8830cc5d4d5785d294bd4a79ee97b3df","unresolved":false,"context_lines":[{"line_number":1931,"context_line":"    total_count \u003d 0"},{"line_number":1932,"context_line":"    if strutils.bool_from_string(args.count, strict\u003dTrue):"},{"line_number":1933,"context_line":"        search_opts[\u0027with_count\u0027] \u003d args.count"},{"line_number":1934,"context_line":"        try:"},{"line_number":1935,"context_line":"            shares, total_count \u003d cs.shares.list("},{"line_number":1936,"context_line":"                search_opts\u003dsearch_opts, sort_key\u003dargs.sort_key,"},{"line_number":1937,"context_line":"                sort_dir\u003dargs.sort_dir,"},{"line_number":1938,"context_line":"            )"},{"line_number":1939,"context_line":"        except ValueError:"},{"line_number":1940,"context_line":"            shares, total_count \u003d [], 0"},{"line_number":1941,"context_line":"    else:"},{"line_number":1942,"context_line":"        shares \u003d cs.shares.list("},{"line_number":1943,"context_line":"            search_opts\u003dsearch_opts, sort_key\u003dargs.sort_key,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_595c9eec","line":1940,"range":{"start_line":1934,"start_character":8,"end_line":1940,"end_character":39},"in_reply_to":"7faddb67_d98bae65","updated":"2019-07-26 15:11:49.000000000","message":"Great!, I\u0027ll change it so","commit_id":"9061705efb7820b4da9bc5fe3cbcce7933555401"}],"releasenotes/notes/bug-667744-fix-25401bc71e3be50b.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e9e73ea3d9a6705b11908a82ac53b55a6496fd0c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - When doing `manila list --count True` without shares, the user gets an"},{"line_number":4,"context_line":"    error. This happens because there is no control of the retrieving and"},{"line_number":5,"context_line":"    showing of shares when the `--count` param, set to True, is used. This"},{"line_number":6,"context_line":"    patch-set adds a fix for this case."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_df087c92","line":6,"range":{"start_line":3,"start_character":4,"end_line":6,"end_character":39},"updated":"2019-07-25 21:34:02.000000000","message":"Hi, sorry, this is too detailed, and leaks a lot of lower-level implementation detail to end users or deployers. Please take a look at the \"Do\u0027s and Don\u0027ts\" section of the release notes documentation here: https://docs.openstack.org/manila/latest/contributor/adding_release_notes.html#dos-and-don-ts\n\n\nI suggest rewriting this like this:\n\n  `Launchpad bug 1822815 \u003chttps://bugs.launchpad.net/python-manilaclient/+bug/1822815\u003e`_\n   has been fixed. The user no longer gets an error if the list command has no\n   rows when executing `manila list --count True`.","commit_id":"9061705efb7820b4da9bc5fe3cbcce7933555401"},{"author":{"_account_id":29958,"name":"Soledad Kuczala","email":"sol.kuczala@gmail.com","username":"SolKuczala"},"change_message_id":"9096103e8830cc5d4d5785d294bd4a79ee97b3df","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - When doing `manila list --count True` without shares, the user gets an"},{"line_number":4,"context_line":"    error. This happens because there is no control of the retrieving and"},{"line_number":5,"context_line":"    showing of shares when the `--count` param, set to True, is used. This"},{"line_number":6,"context_line":"    patch-set adds a fix for this case."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_f9e54a0b","line":6,"range":{"start_line":3,"start_character":4,"end_line":6,"end_character":39},"in_reply_to":"7faddb67_19d70652","updated":"2019-07-26 15:11:49.000000000","message":"Oh, in Do\u0027s and Don\u0027ts says:\n\u0027Do not include code or links\u0027, the launchpad reference doesn\u0027t count as a link? Maybe I\u0027m misunderstanding...","commit_id":"9061705efb7820b4da9bc5fe3cbcce7933555401"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"b9f4c3346d0afee06604ab0d7b4c06147b987565","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - When doing `manila list --count True` without shares, the user gets an"},{"line_number":4,"context_line":"    error. This happens because there is no control of the retrieving and"},{"line_number":5,"context_line":"    showing of shares when the `--count` param, set to True, is used. This"},{"line_number":6,"context_line":"    patch-set adds a fix for this case."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_59433e14","line":6,"range":{"start_line":3,"start_character":4,"end_line":6,"end_character":39},"in_reply_to":"7faddb67_19d70652","updated":"2019-07-26 15:06:40.000000000","message":"The do and don\u0027t section of the reno docs states: Do not include code or links.","commit_id":"9061705efb7820b4da9bc5fe3cbcce7933555401"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"83da11b8dbe7f035922402ebed1f72757fde7e2f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - When doing `manila list --count True` without shares, the user gets an"},{"line_number":4,"context_line":"    error. This happens because there is no control of the retrieving and"},{"line_number":5,"context_line":"    showing of shares when the `--count` param, set to True, is used. This"},{"line_number":6,"context_line":"    patch-set adds a fix for this case."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_19d70652","line":6,"range":{"start_line":3,"start_character":4,"end_line":6,"end_character":39},"in_reply_to":"7faddb67_a64ecd93","updated":"2019-07-26 15:01:58.000000000","message":"Did you have a problem with the link? It\u0027s alright to not link, but linking makes it easier to click on the bug and get there rather than get to Launchpad and search for something.","commit_id":"9061705efb7820b4da9bc5fe3cbcce7933555401"},{"author":{"_account_id":29958,"name":"Soledad Kuczala","email":"sol.kuczala@gmail.com","username":"SolKuczala"},"change_message_id":"cd42b33783c053491dde79b113b7db3299449cd5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - When doing `manila list --count True` without shares, the user gets an"},{"line_number":4,"context_line":"    error. This happens because there is no control of the retrieving and"},{"line_number":5,"context_line":"    showing of shares when the `--count` param, set to True, is used. This"},{"line_number":6,"context_line":"    patch-set adds a fix for this case."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_19f4e686","line":6,"range":{"start_line":3,"start_character":4,"end_line":6,"end_character":39},"in_reply_to":"7faddb67_d9716e46","updated":"2019-07-26 15:43:44.000000000","message":"Oh ok! perfect, yes we can fix that :)","commit_id":"9061705efb7820b4da9bc5fe3cbcce7933555401"},{"author":{"_account_id":29958,"name":"Soledad Kuczala","email":"sol.kuczala@gmail.com","username":"SolKuczala"},"change_message_id":"917de0222e5cd4c0ebf2266ca7f15952170f4670","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - When doing `manila list --count True` without shares, the user gets an"},{"line_number":4,"context_line":"    error. This happens because there is no control of the retrieving and"},{"line_number":5,"context_line":"    showing of shares when the `--count` param, set to True, is used. This"},{"line_number":6,"context_line":"    patch-set adds a fix for this case."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_a64ecd93","line":6,"range":{"start_line":3,"start_character":4,"end_line":6,"end_character":39},"in_reply_to":"7faddb67_df087c92","updated":"2019-07-26 14:55:15.000000000","message":"Agree, but then I can\u0027t use the link, just the bug number, as the docs says. Can I? I left the edit just in case.","commit_id":"9061705efb7820b4da9bc5fe3cbcce7933555401"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3d5fb5a1547993a3650333aa095391a9623c915e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - When doing `manila list --count True` without shares, the user gets an"},{"line_number":4,"context_line":"    error. This happens because there is no control of the retrieving and"},{"line_number":5,"context_line":"    showing of shares when the `--count` param, set to True, is used. This"},{"line_number":6,"context_line":"    patch-set adds a fix for this case."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_d9716e46","line":6,"range":{"start_line":3,"start_character":4,"end_line":6,"end_character":39},"in_reply_to":"7faddb67_f9e54a0b","updated":"2019-07-26 15:17:33.000000000","message":"Ohh... okay, I see :) sorry. That instruction pertains to people putting code or documentation into release notes, dunno why it calls out links? The Reno tooling used to be a little different when we wrote those instructions, so I\u0027m not sure if that\u0027s the reason. \n\nWe have been including bug links where appropriate, see here: https://docs.openstack.org/releasenotes/manila/stein.html for example..\n\nWe can fix those instructions up. Thanks!","commit_id":"9061705efb7820b4da9bc5fe3cbcce7933555401"}]}