)]}' {"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"915399093897054697fec62b4ac812baf0260563","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit: haixin \u003chaixin@inspur.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-07-22 17:15:19 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add update share-type API to Share Types"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"urrently, only the name and description and public access of share-type"},{"line_number":10,"context_line":"is set when the share-type is created, and not allowed to be edited"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7faddb67_cdbd88b1","line":7,"range":{"start_line":7,"start_character":22,"end_line":7,"end_character":40},"updated":"2019-08-06 21:37:14.000000000","message":"to SDK and CLI","commit_id":"1fac60164e7b2c729a424d639a77de60669a407b"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"b34b9a444e7a125e238ffe4e9961f66888c44ebf","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit: haixin \u003chaixin@inspur.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-07-22 17:15:19 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add update share-type API to Share Types"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"urrently, only the name and description and public access of share-type"},{"line_number":10,"context_line":"is set when the share-type is created, and not allowed to be edited"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7faddb67_e944db49","line":7,"range":{"start_line":7,"start_character":22,"end_line":7,"end_character":40},"in_reply_to":"7faddb67_cdbd88b1","updated":"2019-08-08 07:28:36.000000000","message":"Done","commit_id":"1fac60164e7b2c729a424d639a77de60669a407b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"915399093897054697fec62b4ac812baf0260563","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add update share-type API to Share Types"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"urrently, only the name and description and public access of share-type"},{"line_number":10,"context_line":"is set when the share-type is created, and not allowed to be edited"},{"line_number":11,"context_line":"after the share-type is created. We can only set extra spec for share-type."},{"line_number":12,"context_line":"But not name or description or public access for share-type."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7faddb67_0dc88052","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":8},"updated":"2019-08-06 21:37:14.000000000","message":"Currently","commit_id":"1fac60164e7b2c729a424d639a77de60669a407b"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"b34b9a444e7a125e238ffe4e9961f66888c44ebf","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add update share-type API to Share Types"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"urrently, only the name and description and public access of share-type"},{"line_number":10,"context_line":"is set when the share-type is created, and not allowed to be edited"},{"line_number":11,"context_line":"after the share-type is created. We can only set extra spec for share-type."},{"line_number":12,"context_line":"But not name or description or public access for share-type."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7faddb67_8973e7b4","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":8},"in_reply_to":"7faddb67_0dc88052","updated":"2019-08-08 07:28:36.000000000","message":"Done","commit_id":"1fac60164e7b2c729a424d639a77de60669a407b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"915399093897054697fec62b4ac812baf0260563","unresolved":false,"context_lines":[{"line_number":10,"context_line":"is set when the share-type is created, and not allowed to be edited"},{"line_number":11,"context_line":"after the share-type is created. We can only set extra spec for share-type."},{"line_number":12,"context_line":"But not name or description or public access for share-type."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ia0df0d46e11d0438e16fc910fc377f9dd4e85521"},{"line_number":15,"context_line":"Implements: blueprint update-share-type-name-or-description"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7faddb67_edb2c493","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":0},"updated":"2019-08-06 21:37:14.000000000","message":"Depends-On: https://review.opendev.org/669651","commit_id":"1fac60164e7b2c729a424d639a77de60669a407b"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"b34b9a444e7a125e238ffe4e9961f66888c44ebf","unresolved":false,"context_lines":[{"line_number":10,"context_line":"is set when the share-type is created, and not allowed to be edited"},{"line_number":11,"context_line":"after the share-type is created. We can only set extra spec for share-type."},{"line_number":12,"context_line":"But not name or description or public access for share-type."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ia0df0d46e11d0438e16fc910fc377f9dd4e85521"},{"line_number":15,"context_line":"Implements: blueprint update-share-type-name-or-description"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7faddb67_69722bb0","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":0},"in_reply_to":"7faddb67_edb2c493","updated":"2019-08-08 07:28:36.000000000","message":"Done","commit_id":"1fac60164e7b2c729a424d639a77de60669a407b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"915399093897054697fec62b4ac812baf0260563","unresolved":false,"context_lines":[{"line_number":12,"context_line":"But not name or description or public access for share-type."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ia0df0d46e11d0438e16fc910fc377f9dd4e85521"},{"line_number":15,"context_line":"Implements: blueprint update-share-type-name-or-description"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7faddb67_6dded411","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":10},"updated":"2019-08-06 21:37:14.000000000","message":"Partially-Implements","commit_id":"1fac60164e7b2c729a424d639a77de60669a407b"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"b34b9a444e7a125e238ffe4e9961f66888c44ebf","unresolved":false,"context_lines":[{"line_number":12,"context_line":"But not name or description or public access for share-type."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ia0df0d46e11d0438e16fc910fc377f9dd4e85521"},{"line_number":15,"context_line":"Implements: blueprint update-share-type-name-or-description"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7faddb67_69a78b0d","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":10},"in_reply_to":"7faddb67_6dded411","updated":"2019-08-08 07:28:36.000000000","message":"Done","commit_id":"1fac60164e7b2c729a424d639a77de60669a407b"}],"manilaclient/tests/functional/test_share_types.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"771388aa6c78024b1b23ef1f1225d0de8cde4401","unresolved":false,"context_lines":[{"line_number":128,"context_line":" (\u0027name_updated_3\u0027, None, None),"},{"line_number":129,"context_line":" (None, \u0027description_updated\u0027, None),"},{"line_number":130,"context_line":" (None, None, True),"},{"line_number":131,"context_line":" (None, None, False),"},{"line_number":132,"context_line":" )"},{"line_number":133,"context_line":" @ddt.unpack"},{"line_number":134,"context_line":" def test_create_update_delete_share_type_2_50(self, new_name,"}],"source_content_type":"text/x-python","patch_set":12,"id":"7faddb67_26fee0ae","line":131,"range":{"start_line":131,"start_character":26,"end_line":131,"end_character":28},"updated":"2019-09-04 22:09:37.000000000","message":"Can you add another case where description is being updated to null/empty?","commit_id":"c18ef908cc912e681292d9f4ac701743bf4f1d14"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"4de2b6b6394c85680923daa62ab625793b6ee328","unresolved":false,"context_lines":[{"line_number":128,"context_line":" (\u0027name_updated_3\u0027, None, None),"},{"line_number":129,"context_line":" (None, \u0027description_updated\u0027, None),"},{"line_number":130,"context_line":" (None, None, True),"},{"line_number":131,"context_line":" (None, None, False),"},{"line_number":132,"context_line":" )"},{"line_number":133,"context_line":" @ddt.unpack"},{"line_number":134,"context_line":" def test_create_update_delete_share_type_2_50(self, new_name,"}],"source_content_type":"text/x-python","patch_set":12,"id":"7faddb67_62c6fa4b","line":131,"range":{"start_line":131,"start_character":26,"end_line":131,"end_character":28},"in_reply_to":"7faddb67_26fee0ae","updated":"2019-09-05 11:07:51.000000000","message":"Done","commit_id":"c18ef908cc912e681292d9f4ac701743bf4f1d14"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fcd9d1e866f605e6419831d1f5445ff53717aef3","unresolved":false,"context_lines":[{"line_number":129,"context_line":" (None, \u0027description_updated\u0027, None),"},{"line_number":130,"context_line":" (None, None, True),"},{"line_number":131,"context_line":" (None, None, False),"},{"line_number":132,"context_line":" (None, \"\", False),"},{"line_number":133,"context_line":" )"},{"line_number":134,"context_line":" @ddt.unpack"},{"line_number":135,"context_line":" def test_create_update_delete_share_type_2_50(self, new_name,"}],"source_content_type":"text/x-python","patch_set":13,"id":"7faddb67_82b44bf2","line":132,"range":{"start_line":132,"start_character":15,"end_line":132,"end_character":17},"updated":"2019-09-05 17:50:34.000000000","message":"This will need to be passed in as \"\u0027\u0027\" or \u0027\"\"\u0027 (enclose single quotes within double quotes, or enclose double quotes within single quotes)","commit_id":"484181177956b72094fd8fd0a33ec7b15961179c"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"4a7f112b61992bd93e3c59c388fae834124e4790","unresolved":false,"context_lines":[{"line_number":129,"context_line":" (None, \u0027description_updated\u0027, None),"},{"line_number":130,"context_line":" (None, None, True),"},{"line_number":131,"context_line":" (None, None, False),"},{"line_number":132,"context_line":" (None, \"\", False),"},{"line_number":133,"context_line":" )"},{"line_number":134,"context_line":" @ddt.unpack"},{"line_number":135,"context_line":" def test_create_update_delete_share_type_2_50(self, new_name,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5faad753_0e5b8f87","line":132,"range":{"start_line":132,"start_character":15,"end_line":132,"end_character":17},"in_reply_to":"7faddb67_82b44bf2","updated":"2019-09-06 01:17:42.000000000","message":"Done","commit_id":"484181177956b72094fd8fd0a33ec7b15961179c"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"43b37b32e21a52bc8a8ff5f4f1e277d5155f3db8","unresolved":false,"context_lines":[{"line_number":129,"context_line":" (None, \u0027description_updated\u0027, None),"},{"line_number":130,"context_line":" (None, None, True),"},{"line_number":131,"context_line":" (None, None, False),"},{"line_number":132,"context_line":" (None, \"\", False),"},{"line_number":133,"context_line":" )"},{"line_number":134,"context_line":" @ddt.unpack"},{"line_number":135,"context_line":" def test_create_update_delete_share_type_2_50(self, new_name,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5faad753_2e21a6a0","line":132,"range":{"start_line":132,"start_character":15,"end_line":132,"end_character":17},"in_reply_to":"7faddb67_82b44bf2","updated":"2019-09-06 07:29:41.000000000","message":"hi, Goutham Pacha Ravi, I have tried the modification method you proposed,and the result is the same error.\n i found \u0027\"\"\u0027 is not empty str,len(\u0027\"\"\u0027) is 2, this not mean to unset description, but mean to set description to \"\",it\u0027s type is str.\n From the error message(testtools.matchers._impl.MismatchError: \\\u0027\"\"\\\u0027 !\u003d \\\u0027\\\u0027\u0027), I found that DDT recognized \"\" as \"\\ \"\"\\ \", which in Python is a syntax error, I wonder if DDT does not recognize empty strings.\n Could you give me some more advice?","commit_id":"484181177956b72094fd8fd0a33ec7b15961179c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6865c0b5d570586ffd4c0e16d6871226ee3887f2","unresolved":false,"context_lines":[{"line_number":211,"context_line":" is_public\u003dTrue,"},{"line_number":212,"context_line":" microversion\u003dmicroversion)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":" # Verify type name"},{"line_number":215,"context_line":" self.assertEqual(new_name, st_updated[\u0027Name\u0027])"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":" # Verify type description"},{"line_number":218,"context_line":" self.assertEqual(new_description, st_updated[\u0027Description\u0027])"}],"source_content_type":"text/x-python","patch_set":18,"id":"5faad753_c3cbeea2","line":215,"range":{"start_line":214,"start_character":0,"end_line":215,"end_character":54},"updated":"2019-09-08 18:27:17.000000000","message":"This should fail!\nYou shouldn\u0027t be able to set the name of a share type to \"\"","commit_id":"d615a4b55f6f0e68c96534290aeb6d72b4b180ff"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"997e4f0fb796608bbead39bc7570da4eb5d7902e","unresolved":false,"context_lines":[{"line_number":211,"context_line":" is_public\u003dTrue,"},{"line_number":212,"context_line":" microversion\u003dmicroversion)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":" # Verify type name"},{"line_number":215,"context_line":" self.assertEqual(new_name, st_updated[\u0027Name\u0027])"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":" # Verify type description"},{"line_number":218,"context_line":" self.assertEqual(new_description, st_updated[\u0027Description\u0027])"}],"source_content_type":"text/x-python","patch_set":18,"id":"5faad753_fcbc84bc","line":215,"range":{"start_line":214,"start_character":0,"end_line":215,"end_character":54},"in_reply_to":"5faad753_c3cbeea2","updated":"2019-09-09 11:43:34.000000000","message":"Done","commit_id":"d615a4b55f6f0e68c96534290aeb6d72b4b180ff"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a0115e17854a20299a715d82bc8d6cad895d272b","unresolved":false,"context_lines":[{"line_number":183,"context_line":" list_all\u003dFalse, microversion\u003dmicroversion)"},{"line_number":184,"context_line":" self.assertFalse(any(st_id \u003d\u003d st[\u0027ID\u0027] for st in share_types))"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":" def test_unset_share_type_name_description_2_50(self):"},{"line_number":187,"context_line":" self.skip_if_microversion_not_supported(\u00272.50\u0027)"},{"line_number":188,"context_line":" microversion \u003d \u00272.50\u0027"},{"line_number":189,"context_line":" share_type_name \u003d data_utils.rand_name(\u0027share_type_update_test\u0027)"}],"source_content_type":"text/x-python","patch_set":19,"id":"5faad753_7dbf2dfb","line":186,"range":{"start_line":186,"start_character":30,"end_line":186,"end_character":35},"updated":"2019-09-09 14:23:43.000000000","message":"nit: remove, you\u0027re no longer unsetting the name here..","commit_id":"921183fb85a0fc871caa13eaf766eb0af51befa0"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"d4fa771ed49c2f238f3b4e3dc31d4ed57dcd91c1","unresolved":false,"context_lines":[{"line_number":183,"context_line":" list_all\u003dFalse, microversion\u003dmicroversion)"},{"line_number":184,"context_line":" self.assertFalse(any(st_id \u003d\u003d st[\u0027ID\u0027] for st in share_types))"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":" def test_unset_share_type_name_description_2_50(self):"},{"line_number":187,"context_line":" self.skip_if_microversion_not_supported(\u00272.50\u0027)"},{"line_number":188,"context_line":" microversion \u003d \u00272.50\u0027"},{"line_number":189,"context_line":" share_type_name \u003d data_utils.rand_name(\u0027share_type_update_test\u0027)"}],"source_content_type":"text/x-python","patch_set":19,"id":"5faad753_4a2e18a6","line":186,"range":{"start_line":186,"start_character":30,"end_line":186,"end_character":35},"in_reply_to":"5faad753_7dbf2dfb","updated":"2019-09-10 01:28:33.000000000","message":"Done","commit_id":"921183fb85a0fc871caa13eaf766eb0af51befa0"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"91fcdd781340d0067de36f206f0a4730942e0fa3","unresolved":false,"context_lines":[{"line_number":204,"context_line":" st_id \u003d share_type[\u0027ID\u0027]"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":" # Update share type"},{"line_number":207,"context_line":" new_description \u003d \"\""},{"line_number":208,"context_line":" st_updated \u003d self.update_share_type(st_id,"},{"line_number":209,"context_line":" description\u003dnew_description,"},{"line_number":210,"context_line":" microversion\u003dmicroversion)"}],"source_content_type":"text/x-python","patch_set":19,"id":"5faad753_f7dc9e47","line":207,"updated":"2019-09-09 13:09:40.000000000","message":"You set this to None now though.","commit_id":"921183fb85a0fc871caa13eaf766eb0af51befa0"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"d4fa771ed49c2f238f3b4e3dc31d4ed57dcd91c1","unresolved":false,"context_lines":[{"line_number":204,"context_line":" st_id \u003d share_type[\u0027ID\u0027]"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":" # Update share type"},{"line_number":207,"context_line":" new_description \u003d \"\""},{"line_number":208,"context_line":" st_updated \u003d self.update_share_type(st_id,"},{"line_number":209,"context_line":" description\u003dnew_description,"},{"line_number":210,"context_line":" microversion\u003dmicroversion)"}],"source_content_type":"text/x-python","patch_set":19,"id":"5faad753_a50fbf2c","line":207,"in_reply_to":"5faad753_1d463925","updated":"2019-09-10 01:28:33.000000000","message":"yes, i think this will work.","commit_id":"921183fb85a0fc871caa13eaf766eb0af51befa0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a0115e17854a20299a715d82bc8d6cad895d272b","unresolved":false,"context_lines":[{"line_number":204,"context_line":" st_id \u003d share_type[\u0027ID\u0027]"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":" # Update share type"},{"line_number":207,"context_line":" new_description \u003d \"\""},{"line_number":208,"context_line":" st_updated \u003d self.update_share_type(st_id,"},{"line_number":209,"context_line":" description\u003dnew_description,"},{"line_number":210,"context_line":" microversion\u003dmicroversion)"}],"source_content_type":"text/x-python","patch_set":19,"id":"5faad753_1d463925","line":207,"in_reply_to":"5faad753_f7dc9e47","updated":"2019-09-09 14:23:43.000000000","message":"This seems correct, line 213 needs to be changed to:\n\n self.assertIsNone(st_updated[\u0027Description\u0027])","commit_id":"921183fb85a0fc871caa13eaf766eb0af51befa0"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"d4fa771ed49c2f238f3b4e3dc31d4ed57dcd91c1","unresolved":false,"context_lines":[{"line_number":204,"context_line":" st_id \u003d share_type[\u0027ID\u0027]"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":" # Update share type"},{"line_number":207,"context_line":" new_description \u003d \"\""},{"line_number":208,"context_line":" st_updated \u003d self.update_share_type(st_id,"},{"line_number":209,"context_line":" description\u003dnew_description,"},{"line_number":210,"context_line":" microversion\u003dmicroversion)"}],"source_content_type":"text/x-python","patch_set":19,"id":"5faad753_8512c357","line":207,"in_reply_to":"5faad753_f7dc9e47","updated":"2019-09-10 01:28:33.000000000","message":"i think we set this to None is incorrect, because the server(manila) will not change share_type_description, keep the old description,but not unset it.only set it to empty str means to unset it.","commit_id":"921183fb85a0fc871caa13eaf766eb0af51befa0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dab182e4a0310c40176a31302685f363eedd792f","unresolved":false,"context_lines":[{"line_number":210,"context_line":" microversion\u003dmicroversion)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":" # Verify type description"},{"line_number":213,"context_line":" self.assertEqual(new_description, st_updated[\u0027Description\u0027])"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":" # Delete share type"},{"line_number":216,"context_line":" self.admin_client.delete_share_type(st_id, microversion\u003dmicroversion)"}],"source_content_type":"text/x-python","patch_set":24,"id":"5faad753_3049b88a","line":213,"range":{"start_line":213,"start_character":8,"end_line":213,"end_character":68},"updated":"2019-09-10 20:50:57.000000000","message":"As pointed out in the server patch - when you use the command line client, null values are set to the string \u0027None\u0027. See [1]\n\n[1] https://review.opendev.org/#/c/669651/21/manila/share/share_types.py@79","commit_id":"95f06266e25286af7901284bf9c44f0213d2f1cf"}],"manilaclient/tests/unit/v2/test_types.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"915399093897054697fec62b4ac812baf0260563","unresolved":false,"context_lines":[{"line_number":430,"context_line":" t.unset_keys([\u0027k\u0027])"},{"line_number":431,"context_line":" cs.assert_called(\u0027DELETE\u0027, \u0027/types/1/extra_specs/k\u0027)"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":" @ddt.data(\"2.24\", \"2.41\")"},{"line_number":434,"context_line":" def test_update(self, microversion):"},{"line_number":435,"context_line":" manager \u003d self._get_share_types_manager(microversion)"},{"line_number":436,"context_line":" self.mock_object(manager, \u0027_update\u0027, mock.Mock(return_value\u003d\"fake\"))"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_edd164fc","line":433,"range":{"start_line":433,"start_character":0,"end_line":433,"end_character":29},"updated":"2019-08-06 21:37:14.000000000","message":"The update API is only available in API version 2.50 and beyond","commit_id":"1fac60164e7b2c729a424d639a77de60669a407b"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"b34b9a444e7a125e238ffe4e9961f66888c44ebf","unresolved":false,"context_lines":[{"line_number":430,"context_line":" t.unset_keys([\u0027k\u0027])"},{"line_number":431,"context_line":" cs.assert_called(\u0027DELETE\u0027, \u0027/types/1/extra_specs/k\u0027)"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":" @ddt.data(\"2.24\", \"2.41\")"},{"line_number":434,"context_line":" def test_update(self, microversion):"},{"line_number":435,"context_line":" manager \u003d self._get_share_types_manager(microversion)"},{"line_number":436,"context_line":" self.mock_object(manager, \u0027_update\u0027, mock.Mock(return_value\u003d\"fake\"))"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_a8bee1d1","line":433,"range":{"start_line":433,"start_character":0,"end_line":433,"end_character":29},"in_reply_to":"7faddb67_edd164fc","updated":"2019-08-08 07:28:36.000000000","message":"Done","commit_id":"1fac60164e7b2c729a424d639a77de60669a407b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"915399093897054697fec62b4ac812baf0260563","unresolved":false,"context_lines":[{"line_number":445,"context_line":" is_public_key_name: is_public,"},{"line_number":446,"context_line":" }"},{"line_number":447,"context_line":" }"},{"line_number":448,"context_line":" if (api_versions.APIVersion(microversion) \u003e\u003d"},{"line_number":449,"context_line":" api_versions.APIVersion(\"2.41\")):"},{"line_number":450,"context_line":" result \u003d manager.update("},{"line_number":451,"context_line":" share_type, name, is_public, description)"},{"line_number":452,"context_line":" expected_body[\u0027share_type\u0027][\u0027description\u0027] \u003d description"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_cdd268fd","line":449,"range":{"start_line":448,"start_character":0,"end_line":449,"end_character":49},"updated":"2019-08-06 21:37:14.000000000","message":"This check is not required.","commit_id":"1fac60164e7b2c729a424d639a77de60669a407b"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"b34b9a444e7a125e238ffe4e9961f66888c44ebf","unresolved":false,"context_lines":[{"line_number":445,"context_line":" is_public_key_name: is_public,"},{"line_number":446,"context_line":" }"},{"line_number":447,"context_line":" }"},{"line_number":448,"context_line":" if (api_versions.APIVersion(microversion) \u003e\u003d"},{"line_number":449,"context_line":" api_versions.APIVersion(\"2.41\")):"},{"line_number":450,"context_line":" result \u003d manager.update("},{"line_number":451,"context_line":" share_type, name, is_public, description)"},{"line_number":452,"context_line":" expected_body[\u0027share_type\u0027][\u0027description\u0027] \u003d description"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_288f512f","line":449,"range":{"start_line":448,"start_character":0,"end_line":449,"end_character":49},"in_reply_to":"7faddb67_cdd268fd","updated":"2019-08-08 07:28:36.000000000","message":"Done","commit_id":"1fac60164e7b2c729a424d639a77de60669a407b"}],"manilaclient/v2/share_types.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"915399093897054697fec62b4ac812baf0260563","unresolved":false,"context_lines":[{"line_number":245,"context_line":" return self._do_create(name, extra_specs, is_public,"},{"line_number":246,"context_line":" description\u003ddescription)"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":" @api_versions.wraps(\"1.0\", \"2.40\") # noqa"},{"line_number":249,"context_line":" def update(self, share_type, name\u003dNone, is_public\u003dNone):"},{"line_number":250,"context_line":" return self._do_update(share_type, name, is_public)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":" @api_versions.wraps(\"2.41\") # noqa"},{"line_number":253,"context_line":" def update(self, share_type, name\u003dNone, is_public\u003dNone, description\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_cdeb48a1","line":250,"range":{"start_line":248,"start_character":0,"end_line":250,"end_character":59},"updated":"2019-08-06 21:37:14.000000000","message":"This API isn\u0027t available before API version 2.50","commit_id":"1fac60164e7b2c729a424d639a77de60669a407b"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"b34b9a444e7a125e238ffe4e9961f66888c44ebf","unresolved":false,"context_lines":[{"line_number":245,"context_line":" return self._do_create(name, extra_specs, is_public,"},{"line_number":246,"context_line":" description\u003ddescription)"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":" @api_versions.wraps(\"1.0\", \"2.40\") # noqa"},{"line_number":249,"context_line":" def update(self, share_type, name\u003dNone, is_public\u003dNone):"},{"line_number":250,"context_line":" return self._do_update(share_type, name, is_public)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":" @api_versions.wraps(\"2.41\") # noqa"},{"line_number":253,"context_line":" def update(self, share_type, name\u003dNone, is_public\u003dNone, description\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_a8910149","line":250,"range":{"start_line":248,"start_character":0,"end_line":250,"end_character":59},"in_reply_to":"7faddb67_cdeb48a1","updated":"2019-08-08 07:28:36.000000000","message":"Done","commit_id":"1fac60164e7b2c729a424d639a77de60669a407b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"915399093897054697fec62b4ac812baf0260563","unresolved":false,"context_lines":[{"line_number":249,"context_line":" def update(self, share_type, name\u003dNone, is_public\u003dNone):"},{"line_number":250,"context_line":" return self._do_update(share_type, name, is_public)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":" @api_versions.wraps(\"2.41\") # noqa"},{"line_number":253,"context_line":" def update(self, share_type, name\u003dNone, is_public\u003dNone, description\u003dNone):"},{"line_number":254,"context_line":" return self._do_update(share_type, name, is_public,"},{"line_number":255,"context_line":" description\u003ddescription)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_6d2c9401","line":252,"range":{"start_line":252,"start_character":27,"end_line":252,"end_character":29},"updated":"2019-08-06 21:37:14.000000000","message":"50","commit_id":"1fac60164e7b2c729a424d639a77de60669a407b"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"b34b9a444e7a125e238ffe4e9961f66888c44ebf","unresolved":false,"context_lines":[{"line_number":249,"context_line":" def update(self, share_type, name\u003dNone, is_public\u003dNone):"},{"line_number":250,"context_line":" return self._do_update(share_type, name, is_public)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":" @api_versions.wraps(\"2.41\") # noqa"},{"line_number":253,"context_line":" def update(self, share_type, name\u003dNone, is_public\u003dNone, description\u003dNone):"},{"line_number":254,"context_line":" return self._do_update(share_type, name, is_public,"},{"line_number":255,"context_line":" description\u003ddescription)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_48964d41","line":252,"range":{"start_line":252,"start_character":27,"end_line":252,"end_character":29},"in_reply_to":"7faddb67_6d2c9401","updated":"2019-08-08 07:28:36.000000000","message":"Done","commit_id":"1fac60164e7b2c729a424d639a77de60669a407b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"771388aa6c78024b1b23ef1f1225d0de8cde4401","unresolved":false,"context_lines":[{"line_number":100,"context_line":" \"/types/%s/extra_specs/%s\" % (common_base.getid(self), k))"},{"line_number":101,"context_line":" if resp is not None:"},{"line_number":102,"context_line":" return resp"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"class ShareTypeManager(base.ManagerWithFind):"},{"line_number":106,"context_line":" \"\"\"Manage :class:`ShareType` resources.\"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"7faddb67_e6a0c8a7","line":103,"range":{"start_line":103,"start_character":0,"end_line":103,"end_character":0},"updated":"2019-09-04 22:09:37.000000000","message":"An update is made on a single share type resource - so it\u0027s appropriate to add an \"update\" method to this resource class. \n\n def update(self, **kwargs):\n \"\"\"Update this share.\"\"\"\n self.manager.update(self, **kwargs)\n\n\nWith this, you can invoke ``share_type.update(values)`` with the SDK/Shell helper - see an example of this pattern in https://github.com/openstack/python-manilaclient/blob/07564879ae4bdcb73e856b3aedcb79e4420fa7eb/manilaclient/v2/shares.py","commit_id":"c18ef908cc912e681292d9f4ac701743bf4f1d14"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"4de2b6b6394c85680923daa62ab625793b6ee328","unresolved":false,"context_lines":[{"line_number":100,"context_line":" \"/types/%s/extra_specs/%s\" % (common_base.getid(self), k))"},{"line_number":101,"context_line":" if resp is not None:"},{"line_number":102,"context_line":" return resp"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"class ShareTypeManager(base.ManagerWithFind):"},{"line_number":106,"context_line":" \"\"\"Manage :class:`ShareType` resources.\"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"7faddb67_827e96e0","line":103,"range":{"start_line":103,"start_character":0,"end_line":103,"end_character":0},"in_reply_to":"7faddb67_e6a0c8a7","updated":"2019-09-05 11:07:51.000000000","message":"Done","commit_id":"c18ef908cc912e681292d9f4ac701743bf4f1d14"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6865c0b5d570586ffd4c0e16d6871226ee3887f2","unresolved":false,"context_lines":[{"line_number":183,"context_line":" \"share_type\": {}"},{"line_number":184,"context_line":" }"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":" if name or name \u003d\u003d \"\":"},{"line_number":187,"context_line":" body[\"share_type\"][\"name\"] \u003d name"},{"line_number":188,"context_line":" if is_public is not None:"},{"line_number":189,"context_line":" body[\"share_type\"][is_public_keyname] \u003d is_public"}],"source_content_type":"text/x-python","patch_set":18,"id":"5faad753_e3d06a53","line":186,"range":{"start_line":186,"start_character":19,"end_line":186,"end_character":29},"updated":"2019-09-08 18:27:17.000000000","message":"This isn\u0027t a valid name for a share type....","commit_id":"d615a4b55f6f0e68c96534290aeb6d72b4b180ff"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"997e4f0fb796608bbead39bc7570da4eb5d7902e","unresolved":false,"context_lines":[{"line_number":183,"context_line":" \"share_type\": {}"},{"line_number":184,"context_line":" }"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":" if name or name \u003d\u003d \"\":"},{"line_number":187,"context_line":" body[\"share_type\"][\"name\"] \u003d name"},{"line_number":188,"context_line":" if is_public is not None:"},{"line_number":189,"context_line":" body[\"share_type\"][is_public_keyname] \u003d is_public"}],"source_content_type":"text/x-python","patch_set":18,"id":"5faad753_dcdc281a","line":186,"range":{"start_line":186,"start_character":19,"end_line":186,"end_character":29},"in_reply_to":"5faad753_e3d06a53","updated":"2019-09-09 11:43:34.000000000","message":"Done","commit_id":"d615a4b55f6f0e68c96534290aeb6d72b4b180ff"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f4fae42b479de06592bd5470625eeb64605701df","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":" def update(self, **kwargs):"},{"line_number":105,"context_line":" \"\"\"Update this share type.\"\"\""},{"line_number":106,"context_line":" self.manager.update(self, **kwargs)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"class ShareTypeManager(base.ManagerWithFind):"}],"source_content_type":"text/x-python","patch_set":21,"id":"5faad753_cdfd413b","line":106,"range":{"start_line":106,"start_character":7,"end_line":106,"end_character":8},"updated":"2019-09-10 04:06:03.000000000","message":"you\u0027re missing a return here:\n\n return self.manager.update(self, **kwargs)","commit_id":"22da3e60fbf32dd16ee0791b170cb56c9778cb99"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f4fae42b479de06592bd5470625eeb64605701df","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":" def update(self, **kwargs):"},{"line_number":105,"context_line":" \"\"\"Update this share type.\"\"\""},{"line_number":106,"context_line":" share_type \u003d common_base.getid(self)"},{"line_number":107,"context_line":" self.manager.update(self, share_type, **kwargs)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"class ShareTypeManager(base.ManagerWithFind):"}],"source_content_type":"text/x-python","patch_set":22,"id":"5faad753_2d2095b0","line":107,"range":{"start_line":106,"start_character":7,"end_line":107,"end_character":55},"updated":"2019-09-10 04:06:03.000000000","message":"return self.manager.update(self, **kwargs)","commit_id":"824d248f16be2d56f2aacd001dc480cac95d5f34"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"625baa9f8f23175a516cc6a3fe70e45b409f3afc","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":" def update(self, **kwargs):"},{"line_number":105,"context_line":" \"\"\"Update this share type.\"\"\""},{"line_number":106,"context_line":" share_type \u003d common_base.getid(self)"},{"line_number":107,"context_line":" self.manager.update(self, share_type, **kwargs)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"class ShareTypeManager(base.ManagerWithFind):"}],"source_content_type":"text/x-python","patch_set":22,"id":"5faad753_53b81475","line":107,"range":{"start_line":106,"start_character":7,"end_line":107,"end_character":55},"in_reply_to":"5faad753_2d2095b0","updated":"2019-09-11 02:32:14.000000000","message":"Done","commit_id":"824d248f16be2d56f2aacd001dc480cac95d5f34"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"915399093897054697fec62b4ac812baf0260563","unresolved":false,"context_lines":[{"line_number":4139,"context_line":" \u0027--name\u0027,"},{"line_number":4140,"context_line":" metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":4141,"context_line":" type\u003dstr,"},{"line_number":4142,"context_line":" help\u003d\"Name of share type.\")"},{"line_number":4143,"context_line":"@cliutils.arg("},{"line_number":4144,"context_line":" \u0027--description\u0027,"},{"line_number":4145,"context_line":" metavar\u003d\u0027\u003cdescription\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_ed56445c","line":4142,"range":{"start_line":4142,"start_character":10,"end_line":4142,"end_character":14},"updated":"2019-08-06 21:37:14.000000000","message":"New name","commit_id":"1fac60164e7b2c729a424d639a77de60669a407b"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"b34b9a444e7a125e238ffe4e9961f66888c44ebf","unresolved":false,"context_lines":[{"line_number":4139,"context_line":" \u0027--name\u0027,"},{"line_number":4140,"context_line":" metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":4141,"context_line":" type\u003dstr,"},{"line_number":4142,"context_line":" help\u003d\"Name of share type.\")"},{"line_number":4143,"context_line":"@cliutils.arg("},{"line_number":4144,"context_line":" \u0027--description\u0027,"},{"line_number":4145,"context_line":" metavar\u003d\u0027\u003cdescription\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_c8a9dd7c","line":4142,"range":{"start_line":4142,"start_character":10,"end_line":4142,"end_character":14},"in_reply_to":"7faddb67_ed56445c","updated":"2019-08-08 07:28:36.000000000","message":"Done","commit_id":"1fac60164e7b2c729a424d639a77de60669a407b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"915399093897054697fec62b4ac812baf0260563","unresolved":false,"context_lines":[{"line_number":4145,"context_line":" metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":4146,"context_line":" type\u003dstr,"},{"line_number":4147,"context_line":" default\u003dNone,"},{"line_number":4148,"context_line":" help\u003d\u0027Filter results by description. \u0027"},{"line_number":4149,"context_line":" \u0027Available only for microversion \u003e\u003d 2.41.\u0027)"},{"line_number":4150,"context_line":"@cliutils.arg("},{"line_number":4151,"context_line":" \u0027--is-public\u0027,"},{"line_number":4152,"context_line":" \u0027--is_public\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_cd47c8a2","line":4149,"range":{"start_line":4148,"start_character":10,"end_line":4149,"end_character":49},"updated":"2019-08-06 21:37:14.000000000","message":"New description of the share type","commit_id":"1fac60164e7b2c729a424d639a77de60669a407b"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"b34b9a444e7a125e238ffe4e9961f66888c44ebf","unresolved":false,"context_lines":[{"line_number":4145,"context_line":" metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":4146,"context_line":" type\u003dstr,"},{"line_number":4147,"context_line":" default\u003dNone,"},{"line_number":4148,"context_line":" help\u003d\u0027Filter results by description. \u0027"},{"line_number":4149,"context_line":" \u0027Available only for microversion \u003e\u003d 2.41.\u0027)"},{"line_number":4150,"context_line":"@cliutils.arg("},{"line_number":4151,"context_line":" \u0027--is-public\u0027,"},{"line_number":4152,"context_line":" \u0027--is_public\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_e8bff9a7","line":4149,"range":{"start_line":4148,"start_character":10,"end_line":4149,"end_character":49},"in_reply_to":"7faddb67_cd47c8a2","updated":"2019-08-08 07:28:36.000000000","message":"Done","commit_id":"1fac60164e7b2c729a424d639a77de60669a407b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"915399093897054697fec62b4ac812baf0260563","unresolved":false,"context_lines":[{"line_number":4152,"context_line":" \u0027--is_public\u0027,"},{"line_number":4153,"context_line":" metavar\u003d\u0027\u003cis_public\u003e\u0027,"},{"line_number":4154,"context_line":" action\u003d\u0027single_alias\u0027,"},{"line_number":4155,"context_line":" help\u003d\"Make type accessible to the public (default true).\")"},{"line_number":4156,"context_line":"def do_type_update(cs, args):"},{"line_number":4157,"context_line":" \"\"\"Update share type name, description, and/or is_public. (Admin only).\"\"\""},{"line_number":4158,"context_line":" name \u003d getattr(args, \u0027name\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_ade12c9d","line":4155,"range":{"start_line":4155,"start_character":10,"end_line":4155,"end_character":59},"updated":"2019-08-06 21:37:14.000000000","message":"New visibility of the share type. If set to True, share type will be available to all projects in the cloud.","commit_id":"1fac60164e7b2c729a424d639a77de60669a407b"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"b34b9a444e7a125e238ffe4e9961f66888c44ebf","unresolved":false,"context_lines":[{"line_number":4152,"context_line":" \u0027--is_public\u0027,"},{"line_number":4153,"context_line":" metavar\u003d\u0027\u003cis_public\u003e\u0027,"},{"line_number":4154,"context_line":" action\u003d\u0027single_alias\u0027,"},{"line_number":4155,"context_line":" help\u003d\"Make type accessible to the public (default true).\")"},{"line_number":4156,"context_line":"def do_type_update(cs, args):"},{"line_number":4157,"context_line":" \"\"\"Update share type name, description, and/or is_public. (Admin only).\"\"\""},{"line_number":4158,"context_line":" name \u003d getattr(args, \u0027name\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_08ce155b","line":4155,"range":{"start_line":4155,"start_character":10,"end_line":4155,"end_character":59},"in_reply_to":"7faddb67_ade12c9d","updated":"2019-08-08 07:28:36.000000000","message":"Done","commit_id":"1fac60164e7b2c729a424d639a77de60669a407b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"915399093897054697fec62b4ac812baf0260563","unresolved":false,"context_lines":[{"line_number":4153,"context_line":" metavar\u003d\u0027\u003cis_public\u003e\u0027,"},{"line_number":4154,"context_line":" action\u003d\u0027single_alias\u0027,"},{"line_number":4155,"context_line":" help\u003d\"Make type accessible to the public (default true).\")"},{"line_number":4156,"context_line":"def do_type_update(cs, args):"},{"line_number":4157,"context_line":" \"\"\"Update share type name, description, and/or is_public. (Admin only).\"\"\""},{"line_number":4158,"context_line":" name \u003d getattr(args, \u0027name\u0027)"},{"line_number":4159,"context_line":" description \u003d getattr(args, \u0027description\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_4d9f5801","line":4156,"range":{"start_line":4156,"start_character":4,"end_line":4156,"end_character":18},"updated":"2019-08-06 21:37:14.000000000","message":"Min version decorator missing: @api_versions.wraps(\"2.50\")","commit_id":"1fac60164e7b2c729a424d639a77de60669a407b"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"b34b9a444e7a125e238ffe4e9961f66888c44ebf","unresolved":false,"context_lines":[{"line_number":4153,"context_line":" metavar\u003d\u0027\u003cis_public\u003e\u0027,"},{"line_number":4154,"context_line":" action\u003d\u0027single_alias\u0027,"},{"line_number":4155,"context_line":" help\u003d\"Make type accessible to the public (default true).\")"},{"line_number":4156,"context_line":"def do_type_update(cs, args):"},{"line_number":4157,"context_line":" \"\"\"Update share type name, description, and/or is_public. (Admin only).\"\"\""},{"line_number":4158,"context_line":" name \u003d getattr(args, \u0027name\u0027)"},{"line_number":4159,"context_line":" description \u003d getattr(args, \u0027description\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_28cbd14a","line":4156,"range":{"start_line":4156,"start_character":4,"end_line":4156,"end_character":18},"in_reply_to":"7faddb67_4d9f5801","updated":"2019-08-08 07:28:36.000000000","message":"Done","commit_id":"1fac60164e7b2c729a424d639a77de60669a407b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"915399093897054697fec62b4ac812baf0260563","unresolved":false,"context_lines":[{"line_number":4154,"context_line":" action\u003d\u0027single_alias\u0027,"},{"line_number":4155,"context_line":" help\u003d\"Make type accessible to the public (default true).\")"},{"line_number":4156,"context_line":"def do_type_update(cs, args):"},{"line_number":4157,"context_line":" \"\"\"Update share type name, description, and/or is_public. (Admin only).\"\"\""},{"line_number":4158,"context_line":" name \u003d getattr(args, \u0027name\u0027)"},{"line_number":4159,"context_line":" description \u003d getattr(args, \u0027description\u0027)"},{"line_number":4160,"context_line":" is_public \u003d getattr(args, \u0027is_public\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_8df4705c","line":4157,"range":{"start_line":4157,"start_character":51,"end_line":4157,"end_character":60},"updated":"2019-08-06 21:37:14.000000000","message":"visibility","commit_id":"1fac60164e7b2c729a424d639a77de60669a407b"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"b34b9a444e7a125e238ffe4e9961f66888c44ebf","unresolved":false,"context_lines":[{"line_number":4154,"context_line":" action\u003d\u0027single_alias\u0027,"},{"line_number":4155,"context_line":" help\u003d\"Make type accessible to the public (default true).\")"},{"line_number":4156,"context_line":"def do_type_update(cs, args):"},{"line_number":4157,"context_line":" \"\"\"Update share type name, description, and/or is_public. (Admin only).\"\"\""},{"line_number":4158,"context_line":" name \u003d getattr(args, \u0027name\u0027)"},{"line_number":4159,"context_line":" description \u003d getattr(args, \u0027description\u0027)"},{"line_number":4160,"context_line":" is_public \u003d getattr(args, \u0027is_public\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_8803e576","line":4157,"range":{"start_line":4157,"start_character":51,"end_line":4157,"end_character":60},"in_reply_to":"7faddb67_8df4705c","updated":"2019-08-08 07:28:36.000000000","message":"Done","commit_id":"1fac60164e7b2c729a424d639a77de60669a407b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"915399093897054697fec62b4ac812baf0260563","unresolved":false,"context_lines":[{"line_number":4169,"context_line":" default\u003dTrue)"},{"line_number":4170,"context_line":""},{"line_number":4171,"context_line":" show_des \u003d False"},{"line_number":4172,"context_line":" if cs.api_version.matches(api_versions.APIVersion(\"2.41\"),"},{"line_number":4173,"context_line":" api_versions.APIVersion()):"},{"line_number":4174,"context_line":" show_des \u003d True"},{"line_number":4175,"context_line":" kwargs[\u0027description\u0027] \u003d description"},{"line_number":4176,"context_line":" elif getattr(args, \u0027description\u0027):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_ed8964c9","line":4173,"range":{"start_line":4172,"start_character":0,"end_line":4173,"end_character":57},"updated":"2019-08-06 21:37:14.000000000","message":"not necessary.","commit_id":"1fac60164e7b2c729a424d639a77de60669a407b"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"b34b9a444e7a125e238ffe4e9961f66888c44ebf","unresolved":false,"context_lines":[{"line_number":4169,"context_line":" default\u003dTrue)"},{"line_number":4170,"context_line":""},{"line_number":4171,"context_line":" show_des \u003d False"},{"line_number":4172,"context_line":" if cs.api_version.matches(api_versions.APIVersion(\"2.41\"),"},{"line_number":4173,"context_line":" api_versions.APIVersion()):"},{"line_number":4174,"context_line":" show_des \u003d True"},{"line_number":4175,"context_line":" kwargs[\u0027description\u0027] \u003d description"},{"line_number":4176,"context_line":" elif getattr(args, \u0027description\u0027):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_8828c5ee","line":4173,"range":{"start_line":4172,"start_character":0,"end_line":4173,"end_character":57},"in_reply_to":"7faddb67_ed8964c9","updated":"2019-08-08 07:28:36.000000000","message":"Done","commit_id":"1fac60164e7b2c729a424d639a77de60669a407b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"915399093897054697fec62b4ac812baf0260563","unresolved":false,"context_lines":[{"line_number":4173,"context_line":" api_versions.APIVersion()):"},{"line_number":4174,"context_line":" show_des \u003d True"},{"line_number":4175,"context_line":" kwargs[\u0027description\u0027] \u003d description"},{"line_number":4176,"context_line":" elif getattr(args, \u0027description\u0027):"},{"line_number":4177,"context_line":" raise exceptions.CommandError("},{"line_number":4178,"context_line":" \"Pattern based option (description)\""},{"line_number":4179,"context_line":" \" is only available with manila API version \u003e\u003d 2.41\")"},{"line_number":4180,"context_line":""},{"line_number":4181,"context_line":" stype \u003d cs.share_types.update(**kwargs)"},{"line_number":4182,"context_line":" _print_share_type(stype, show_des\u003dshow_des)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_0d85e0ac","line":4179,"range":{"start_line":4176,"start_character":4,"end_line":4179,"end_character":65},"updated":"2019-08-06 21:37:14.000000000","message":"Not necessary","commit_id":"1fac60164e7b2c729a424d639a77de60669a407b"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"b34b9a444e7a125e238ffe4e9961f66888c44ebf","unresolved":false,"context_lines":[{"line_number":4173,"context_line":" api_versions.APIVersion()):"},{"line_number":4174,"context_line":" show_des \u003d True"},{"line_number":4175,"context_line":" kwargs[\u0027description\u0027] \u003d description"},{"line_number":4176,"context_line":" elif getattr(args, \u0027description\u0027):"},{"line_number":4177,"context_line":" raise exceptions.CommandError("},{"line_number":4178,"context_line":" \"Pattern based option (description)\""},{"line_number":4179,"context_line":" \" is only available with manila API version \u003e\u003d 2.41\")"},{"line_number":4180,"context_line":""},{"line_number":4181,"context_line":" stype \u003d cs.share_types.update(**kwargs)"},{"line_number":4182,"context_line":" _print_share_type(stype, show_des\u003dshow_des)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_a82d81fe","line":4179,"range":{"start_line":4176,"start_character":4,"end_line":4179,"end_character":65},"in_reply_to":"7faddb67_0d85e0ac","updated":"2019-08-08 07:28:36.000000000","message":"Done","commit_id":"1fac60164e7b2c729a424d639a77de60669a407b"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"0a996bc3c8256fb4e293f0bd1620771ea805d7d9","unresolved":false,"context_lines":[{"line_number":4148,"context_line":" help\u003d\"New description of share type.\")"},{"line_number":4149,"context_line":"@cliutils.arg("},{"line_number":4150,"context_line":" \u0027--is-public\u0027,"},{"line_number":4151,"context_line":" \u0027--is_public\u0027,"},{"line_number":4152,"context_line":" metavar\u003d\u0027\u003cis_public\u003e\u0027,"},{"line_number":4153,"context_line":" action\u003d\u0027single_alias\u0027,"},{"line_number":4154,"context_line":" help\u003d\"New visibility of the share type. If set to True, share type will\""}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_42178fef","line":4151,"range":{"start_line":4151,"start_character":4,"end_line":4151,"end_character":18},"updated":"2019-08-15 09:36:38.000000000","message":"Redundant, need to remove.","commit_id":"691e39640f352662e49ffb9b98caf418df763608"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"43db1f63452241970876316249481ce30a933e35","unresolved":false,"context_lines":[{"line_number":4148,"context_line":" help\u003d\"New description of share type.\")"},{"line_number":4149,"context_line":"@cliutils.arg("},{"line_number":4150,"context_line":" \u0027--is-public\u0027,"},{"line_number":4151,"context_line":" \u0027--is_public\u0027,"},{"line_number":4152,"context_line":" metavar\u003d\u0027\u003cis_public\u003e\u0027,"},{"line_number":4153,"context_line":" action\u003d\u0027single_alias\u0027,"},{"line_number":4154,"context_line":" help\u003d\"New visibility of the share type. If set to True, share type will\""}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_e200fb68","line":4151,"range":{"start_line":4151,"start_character":4,"end_line":4151,"end_character":18},"in_reply_to":"7faddb67_42178fef","updated":"2019-08-15 09:50:05.000000000","message":"sorry, it\u0027s ok, \u0027--is-public\u0027 and \u0027--is_public\u0027 all can be accepted.","commit_id":"691e39640f352662e49ffb9b98caf418df763608"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b689c44a2497a4f5cd6cba6fed991234d3b06292","unresolved":false,"context_lines":[{"line_number":4169,"context_line":" kwargs[\u0027is_public\u0027] \u003d strutils.bool_from_string(is_public,"},{"line_number":4170,"context_line":" default\u003dTrue)"},{"line_number":4171,"context_line":""},{"line_number":4172,"context_line":" kwargs[\u0027description\u0027] \u003d description"},{"line_number":4173,"context_line":" stype \u003d cs.share_types.update(**kwargs)"},{"line_number":4174,"context_line":" _print_share_type(stype, show_des\u003dTrue)"},{"line_number":4175,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"7faddb67_1f842db0","line":4172,"range":{"start_line":4172,"start_character":0,"end_line":4172,"end_character":39},"updated":"2019-08-21 20:54:55.000000000","message":"Any reason for not checking if a description was provided?","commit_id":"8b8e89870dbd94c45cc1756c9e2ad12cbdc3149c"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"84d6088ca4ed74db5948374e8b4f652c38b8e3fa","unresolved":false,"context_lines":[{"line_number":4169,"context_line":" kwargs[\u0027is_public\u0027] \u003d strutils.bool_from_string(is_public,"},{"line_number":4170,"context_line":" default\u003dTrue)"},{"line_number":4171,"context_line":""},{"line_number":4172,"context_line":" kwargs[\u0027description\u0027] \u003d description"},{"line_number":4173,"context_line":" stype \u003d cs.share_types.update(**kwargs)"},{"line_number":4174,"context_line":" _print_share_type(stype, show_des\u003dTrue)"},{"line_number":4175,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"7faddb67_6d6014a6","line":4172,"range":{"start_line":4172,"start_character":0,"end_line":4172,"end_character":39},"in_reply_to":"7faddb67_1f842db0","updated":"2019-08-22 02:38:12.000000000","message":"https://review.opendev.org/#/c/670750/11/manilaclient/v2/share_types.py@186. it will check description also. it does not matter whether check it here.","commit_id":"8b8e89870dbd94c45cc1756c9e2ad12cbdc3149c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"771388aa6c78024b1b23ef1f1225d0de8cde4401","unresolved":false,"context_lines":[{"line_number":4151,"context_line":" \u0027--is_public\u0027,"},{"line_number":4152,"context_line":" metavar\u003d\u0027\u003cis_public\u003e\u0027,"},{"line_number":4153,"context_line":" action\u003d\u0027single_alias\u0027,"},{"line_number":4154,"context_line":" help\u003d\"New visibility of the share type. If set to True, share type will\""},{"line_number":4155,"context_line":" \"be available to all projects in the cloud.\")"},{"line_number":4156,"context_line":"@api_versions.wraps(\"2.50\")"},{"line_number":4157,"context_line":"def do_type_update(cs, args):"}],"source_content_type":"text/x-python","patch_set":12,"id":"7faddb67_666cd835","line":4154,"range":{"start_line":4154,"start_character":74,"end_line":4154,"end_character":76},"updated":"2019-09-04 22:09:37.000000000","message":"missing space","commit_id":"c18ef908cc912e681292d9f4ac701743bf4f1d14"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"4de2b6b6394c85680923daa62ab625793b6ee328","unresolved":false,"context_lines":[{"line_number":4151,"context_line":" \u0027--is_public\u0027,"},{"line_number":4152,"context_line":" metavar\u003d\u0027\u003cis_public\u003e\u0027,"},{"line_number":4153,"context_line":" action\u003d\u0027single_alias\u0027,"},{"line_number":4154,"context_line":" help\u003d\"New visibility of the share type. If set to True, share type will\""},{"line_number":4155,"context_line":" \"be available to all projects in the cloud.\")"},{"line_number":4156,"context_line":"@api_versions.wraps(\"2.50\")"},{"line_number":4157,"context_line":"def do_type_update(cs, args):"}],"source_content_type":"text/x-python","patch_set":12,"id":"7faddb67_6267da52","line":4154,"range":{"start_line":4154,"start_character":74,"end_line":4154,"end_character":76},"in_reply_to":"7faddb67_666cd835","updated":"2019-09-05 11:07:51.000000000","message":"Done","commit_id":"c18ef908cc912e681292d9f4ac701743bf4f1d14"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6865c0b5d570586ffd4c0e16d6871226ee3887f2","unresolved":false,"context_lines":[{"line_number":4165,"context_line":" kwargs \u003d {\u0027share_type\u0027: args.id}"},{"line_number":4166,"context_line":" kwargs[\u0027name\u0027] \u003d name"},{"line_number":4167,"context_line":" if is_public:"},{"line_number":4168,"context_line":" kwargs[\u0027is_public\u0027] \u003d strutils.bool_from_string(is_public,"},{"line_number":4169,"context_line":" strict\u003dTrue)"},{"line_number":4170,"context_line":""},{"line_number":4171,"context_line":" kwargs[\u0027description\u0027] \u003d description"},{"line_number":4172,"context_line":" stype \u003d cs.share_types.update(**kwargs)"}],"source_content_type":"text/x-python","patch_set":18,"id":"5faad753_036026a5","line":4169,"range":{"start_line":4168,"start_character":8,"end_line":4169,"end_character":68},"updated":"2019-09-08 18:27:17.000000000","message":"try...except this error - you need to print a message that the \"is_public\" attribute has an unrecognized value, the error message from this method doesn\u0027t suffice: https://opendev.org/openstack/oslo.utils/src/commit/5ae7d21f98bc8e6237f600f4885f94e57a2c99b1/oslo_utils/strutils.py#L145\n\n if is_public:\n try:\n kwargs[\u0027is_public\u0027] \u003d strutils.bool_from_string(is_public,\n strict\u003dTrue)\n except ValueError as e:\n raise exceptions.CommandError(\"The value of \u0027is_public\u0027 is invalid: %s\", six.text_type(e))","commit_id":"d615a4b55f6f0e68c96534290aeb6d72b4b180ff"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"997e4f0fb796608bbead39bc7570da4eb5d7902e","unresolved":false,"context_lines":[{"line_number":4165,"context_line":" kwargs \u003d {\u0027share_type\u0027: args.id}"},{"line_number":4166,"context_line":" kwargs[\u0027name\u0027] \u003d name"},{"line_number":4167,"context_line":" if is_public:"},{"line_number":4168,"context_line":" kwargs[\u0027is_public\u0027] \u003d strutils.bool_from_string(is_public,"},{"line_number":4169,"context_line":" strict\u003dTrue)"},{"line_number":4170,"context_line":""},{"line_number":4171,"context_line":" kwargs[\u0027description\u0027] \u003d description"},{"line_number":4172,"context_line":" stype \u003d cs.share_types.update(**kwargs)"}],"source_content_type":"text/x-python","patch_set":18,"id":"5faad753_1c4880ca","line":4169,"range":{"start_line":4168,"start_character":8,"end_line":4169,"end_character":68},"in_reply_to":"5faad753_036026a5","updated":"2019-09-09 11:43:34.000000000","message":"Done","commit_id":"d615a4b55f6f0e68c96534290aeb6d72b4b180ff"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"798eb1c7ee0b5c79f9fdb3dd674803d5b670c23f","unresolved":false,"context_lines":[{"line_number":4173,"context_line":" \" invalid: %s\", six.text_type(e))"},{"line_number":4174,"context_line":""},{"line_number":4175,"context_line":" kwargs[\u0027description\u0027] \u003d description"},{"line_number":4176,"context_line":" stype \u003d cs.share_types.update(**kwargs)"},{"line_number":4177,"context_line":" _print_share_type(stype, show_des\u003dTrue)"},{"line_number":4178,"context_line":""},{"line_number":4179,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"5faad753_bd94c545","line":4176,"range":{"start_line":4176,"start_character":4,"end_line":4176,"end_character":43},"updated":"2019-09-09 14:29:04.000000000","message":"using the ShareType resource in the SDK makes things simpler and is more readable:\n\n stype \u003d _find_share_type(cs, args.id)\n stype \u003d stype.update(**kwargs)\n\n\nDoing this will also allow resolving the share type by either name or ID","commit_id":"921183fb85a0fc871caa13eaf766eb0af51befa0"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"d4fa771ed49c2f238f3b4e3dc31d4ed57dcd91c1","unresolved":false,"context_lines":[{"line_number":4173,"context_line":" \" invalid: %s\", six.text_type(e))"},{"line_number":4174,"context_line":""},{"line_number":4175,"context_line":" kwargs[\u0027description\u0027] \u003d description"},{"line_number":4176,"context_line":" stype \u003d cs.share_types.update(**kwargs)"},{"line_number":4177,"context_line":" _print_share_type(stype, show_des\u003dTrue)"},{"line_number":4178,"context_line":""},{"line_number":4179,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"5faad753_6547874d","line":4176,"range":{"start_line":4176,"start_character":4,"end_line":4176,"end_character":43},"in_reply_to":"5faad753_bd94c545","updated":"2019-09-10 01:28:33.000000000","message":"Done","commit_id":"921183fb85a0fc871caa13eaf766eb0af51befa0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cfe00b8bb02315be67444dce52193d6291e56388","unresolved":false,"context_lines":[{"line_number":4162,"context_line":" if name is None and description is None and is_public is None:"},{"line_number":4163,"context_line":" raise exceptions.CommandError(\u0027Specify a new type name, description, \u0027"},{"line_number":4164,"context_line":" \u0027is_public or a combination thereof\u0027)"},{"line_number":4165,"context_line":" kwargs \u003d {\u0027share_type\u0027: args.id}"},{"line_number":4166,"context_line":" kwargs[\u0027name\u0027] \u003d name"},{"line_number":4167,"context_line":" if is_public:"},{"line_number":4168,"context_line":" try:"}],"source_content_type":"text/x-python","patch_set":20,"id":"5faad753_6dcf6db0","line":4165,"range":{"start_line":4165,"start_character":13,"end_line":4165,"end_character":36},"updated":"2019-09-10 02:46:43.000000000","message":"set this to {}","commit_id":"7271d598c7b11f3ce4340f1913d9894da991ba7a"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"bc71b60d26ec4d5029bbe80ac73f6823666ad71b","unresolved":false,"context_lines":[{"line_number":4162,"context_line":" if name is None and description is None and is_public is None:"},{"line_number":4163,"context_line":" raise exceptions.CommandError(\u0027Specify a new type name, description, \u0027"},{"line_number":4164,"context_line":" \u0027is_public or a combination thereof\u0027)"},{"line_number":4165,"context_line":" kwargs \u003d {\u0027share_type\u0027: args.id}"},{"line_number":4166,"context_line":" kwargs[\u0027name\u0027] \u003d name"},{"line_number":4167,"context_line":" if is_public:"},{"line_number":4168,"context_line":" try:"}],"source_content_type":"text/x-python","patch_set":20,"id":"5faad753_6dae8d99","line":4165,"range":{"start_line":4165,"start_character":13,"end_line":4165,"end_character":36},"in_reply_to":"5faad753_6dcf6db0","updated":"2019-09-10 03:06:23.000000000","message":"Done","commit_id":"7271d598c7b11f3ce4340f1913d9894da991ba7a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f4fae42b479de06592bd5470625eeb64605701df","unresolved":false,"context_lines":[{"line_number":4159,"context_line":" name \u003d getattr(args, \u0027name\u0027)"},{"line_number":4160,"context_line":" description \u003d getattr(args, \u0027description\u0027)"},{"line_number":4161,"context_line":" is_public \u003d getattr(args, \u0027is_public\u0027)"},{"line_number":4162,"context_line":" if name is None and description is None and is_public is None:"},{"line_number":4163,"context_line":" raise exceptions.CommandError(\u0027Specify a new type name, description, \u0027"},{"line_number":4164,"context_line":" \u0027is_public or a combination thereof\u0027)"},{"line_number":4165,"context_line":" kwargs \u003d {}"},{"line_number":4166,"context_line":" kwargs[\u0027name\u0027] \u003d name"},{"line_number":4167,"context_line":" if is_public:"}],"source_content_type":"text/x-python","patch_set":21,"id":"5faad753_adc1e5e6","line":4164,"range":{"start_line":4162,"start_character":0,"end_line":4164,"end_character":75},"updated":"2019-09-10 04:06:03.000000000","message":"I get some unexpected behavior:\n\n\nI try updating the name with \"\", I thought I\u0027ll get an error saying \"Name can\u0027t be empty\", instead, I got this:\n\n stack@ostk-postgres:~/python-manilaclient$ manila type-update dhss_true --name \"\"\nERROR: Specify share type name, description, share_type_access:is_public or a combination thereof. \n(HTTP 400) (Request-ID: req-965ae81e-f9d1-4919-b616-a99a20f0491e)\n\n \n\nThen I tried updating name to \"\", and description to \"\": There were no errors!\n\n stack@ostk-postgres:~/python-manilaclient$ manila type-update dhss_true --name \"\" --description \"\"\n+----------------------+-------------------------------------------+\n| Property | Value |\n+----------------------+-------------------------------------------+\n| ID | 7d31e604-a688-43af-a467-3028b0040df8 |\n| Name | dhss_true |\n| Visibility | public |\n| is_default | - |\n| required_extra_specs | driver_handles_share_servers : True |\n| optional_extra_specs | snapshot_support : True |\n| | create_share_from_snapshot_support : True |\n| Description | None |\n+----------------------+-------------------------------------------+\n\n\n\nCan you please handle these errors properly?","commit_id":"22da3e60fbf32dd16ee0791b170cb56c9778cb99"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f4fae42b479de06592bd5470625eeb64605701df","unresolved":false,"context_lines":[{"line_number":4161,"context_line":" is_public \u003d getattr(args, \u0027is_public\u0027)"},{"line_number":4162,"context_line":" if name is None and description is None and is_public is None:"},{"line_number":4163,"context_line":" raise exceptions.CommandError(\u0027Specify a new type name, description, \u0027"},{"line_number":4164,"context_line":" \u0027is_public or a combination thereof\u0027)"},{"line_number":4165,"context_line":" kwargs \u003d {}"},{"line_number":4166,"context_line":" kwargs[\u0027name\u0027] \u003d name"},{"line_number":4167,"context_line":" if is_public:"}],"source_content_type":"text/x-python","patch_set":21,"id":"5faad753_4d3b91ea","line":4164,"range":{"start_line":4164,"start_character":74,"end_line":4164,"end_character":75},"updated":"2019-09-10 04:06:03.000000000","message":"I guess if you change it to:\n\n \n if not name and description is None and is_public is None:\n msg \u003d \"A description and/or non-empty name and/or boolean is_public must be supplied to update the respective attributes of the share type.\"\n raise exceptions.CommandError(msg)","commit_id":"22da3e60fbf32dd16ee0791b170cb56c9778cb99"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f4fae42b479de06592bd5470625eeb64605701df","unresolved":false,"context_lines":[{"line_number":4159,"context_line":" name \u003d getattr(args, \u0027name\u0027)"},{"line_number":4160,"context_line":" description \u003d getattr(args, \u0027description\u0027)"},{"line_number":4161,"context_line":" is_public \u003d getattr(args, \u0027is_public\u0027)"},{"line_number":4162,"context_line":" if name is None and description is None and is_public is None:"},{"line_number":4163,"context_line":" raise exceptions.CommandError(\u0027Specify a new type name, description, \u0027"},{"line_number":4164,"context_line":" \u0027is_public or a combination thereof\u0027)"},{"line_number":4165,"context_line":" kwargs \u003d {}"},{"line_number":4166,"context_line":" kwargs[\u0027name\u0027] \u003d name"},{"line_number":4167,"context_line":" if is_public:"}],"source_content_type":"text/x-python","patch_set":22,"id":"5faad753_4d14f14e","line":4164,"range":{"start_line":4162,"start_character":4,"end_line":4164,"end_character":75},"updated":"2019-09-10 04:06:03.000000000","message":"I get some unexpected behavior:\n\nI try updating the name with \"\", I thought I\u0027ll get an error saying \"Name can\u0027t be empty\", instead, I got this:\n\n\n stack@ostk-postgres:~/python-manilaclient$ manila type-update dhss_true --name \"\"\nERROR: Specify share type name, description, share_type_access:is_public or a combination thereof. \n(HTTP 400) (Request-ID: req-965ae81e-f9d1-4919-b616-a99a20f0491e)\n \n \n\n\nThen I tried updating name to \"\", and description to \"\": There were no errors!\n\n stack@ostk-postgres:~/python-manilaclient$ manila type-update dhss_true --name \"\" --description \"\"\n+----------------------+-------------------------------------------+\n| Property | Value |\n+----------------------+-------------------------------------------+\n| ID | 7d31e604-a688-43af-a467-3028b0040df8 |\n| Name | dhss_true |\n| Visibility | public |\n| is_default | - |\n| required_extra_specs | driver_handles_share_servers : True |\n| optional_extra_specs | snapshot_support : True |\n| | create_share_from_snapshot_support : True |\n| Description | None |\n+----------------------+-------------------------------------------+\n\n \n\nCan you please handle these errors properly?\nI guess if you change the condition and the error to, it\u0027ll make sense:\n \n\n\n if not name and description is None and is_public is None:\n msg \u003d \"A description and/or non-empty name and/or boolean is_public must be supplied to update the respective attributes of the share type.\"\n raise exceptions.CommandError(msg)","commit_id":"824d248f16be2d56f2aacd001dc480cac95d5f34"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dab182e4a0310c40176a31302685f363eedd792f","unresolved":false,"context_lines":[{"line_number":4160,"context_line":" description \u003d getattr(args, \u0027description\u0027)"},{"line_number":4161,"context_line":" is_public \u003d getattr(args, \u0027is_public\u0027)"},{"line_number":4162,"context_line":" if not name and description is None and is_public is None:"},{"line_number":4163,"context_line":" msg \u003d \"A description and/or non-empty name and/or boolean is_public \" \\"},{"line_number":4164,"context_line":" \"must be supplied to update the respective attributes of the \" \\"},{"line_number":4165,"context_line":" \"share type.\""},{"line_number":4166,"context_line":" raise exceptions.CommandError(msg)"}],"source_content_type":"text/x-python","patch_set":24,"id":"5faad753_30bbf872","line":4163,"range":{"start_line":4163,"start_character":78,"end_line":4163,"end_character":79},"updated":"2019-09-10 20:50:57.000000000","message":"Use () for long lines","commit_id":"95f06266e25286af7901284bf9c44f0213d2f1cf"}]}