)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a629c52366e8f45e34a63b89ad21c9081b579c8","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  parameter to share server list."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"API microverion has been bumped to 2.51."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Partially-implements: bp share-network-multiple-subnets"},{"line_number":16,"context_line":"Change-Id: I55c85285cbdc9aaf2c0bab2f12477212b32b799a"},{"line_number":17,"context_line":"Depends-On: Id8814a8b26c9b9dcb1fe71d0d7e9b79e8b8a9210"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"5faad753_5a448e1b","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":0},"updated":"2019-09-11 00:52:37.000000000","message":"Looks like you\u0027re closing bug: https://bugs.launchpad.net/manila/+bug/1588144 as well, \nCan you add python-manilaclient as an affected project, and mention this in your release note as a fix?","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3527c53a070cd4ed147edf1a56c30ee2a691a7f3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  parameter to share server list."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"API microverion has been bumped to 2.51."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Partially-implements: bp share-network-multiple-subnets"},{"line_number":16,"context_line":"Change-Id: I55c85285cbdc9aaf2c0bab2f12477212b32b799a"},{"line_number":17,"context_line":"Depends-On: Id8814a8b26c9b9dcb1fe71d0d7e9b79e8b8a9210"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"5faad753_1eb6e13f","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":0},"in_reply_to":"5faad753_5a448e1b","updated":"2019-09-12 14:58:01.000000000","message":"Good. Will do.","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"293db4e5b240b2f0d24c1e0a017e6879115c37ac","unresolved":false,"context_lines":[{"line_number":10,"context_line":"- Updated commands for share server manage and added a new"},{"line_number":11,"context_line":"  parameter to share server list."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"API microverion has been bumped to 2.51."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Partially-implements: bp share-network-multiple-subnets"},{"line_number":16,"context_line":"Change-Id: I55c85285cbdc9aaf2c0bab2f12477212b32b799a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"5faad753_57e42e3c","line":13,"range":{"start_line":13,"start_character":39,"end_line":13,"end_character":40},"updated":"2019-09-13 00:08:30.000000000","message":"Closes-Bug: #1588144","commit_id":"43f50f75c066ec6a432cbd5917d9fb7e4ec9405d"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4d2c4b1b1c56743227d4f0707d4656621ec2cf73","unresolved":false,"context_lines":[{"line_number":10,"context_line":"- Updated commands for share server manage and added a new"},{"line_number":11,"context_line":"  parameter to share server list."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"API microverion has been bumped to 2.51."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Partially-implements: bp share-network-multiple-subnets"},{"line_number":16,"context_line":"Change-Id: I55c85285cbdc9aaf2c0bab2f12477212b32b799a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"5faad753_77436ab0","line":13,"range":{"start_line":13,"start_character":39,"end_line":13,"end_character":40},"in_reply_to":"5faad753_57e42e3c","updated":"2019-09-13 00:16:36.000000000","message":"Ops, forgot to add before. Sorry.","commit_id":"43f50f75c066ec6a432cbd5917d9fb7e4ec9405d"}],"manilaclient/tests/functional/client.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a629c52366e8f45e34a63b89ad21c9081b579c8","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        return self.cmd_with_auth("},{"line_number":117,"context_line":"            \u0027manila\u0027, action, flags, params, fail_ok, merge_stderr)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def wait_for_resource_deletion(self, res_type, res_id, args\u003d{}, interval\u003d3,"},{"line_number":120,"context_line":"                                   timeout\u003d180, microversion\u003dNone):"},{"line_number":121,"context_line":"        \"\"\"Resource deletion waiter."},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_fa21ba4e","line":119,"range":{"start_line":119,"start_character":59,"end_line":119,"end_character":67},"updated":"2019-09-11 00:52:37.000000000","message":"Do not use mutable defaults [1]. Move to end of signature and rename it to kwargs:\n\n  def wait_for_resource_deletion(self, res_type, res_id, interval\u003d3,\n                                timeout\u003d180, microversion\u003dNone, **kwargs):\n\n[1] https://docs.python-guide.org/writing/gotchas/#mutable-default-arguments","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3527c53a070cd4ed147edf1a56c30ee2a691a7f3","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        return self.cmd_with_auth("},{"line_number":117,"context_line":"            \u0027manila\u0027, action, flags, params, fail_ok, merge_stderr)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def wait_for_resource_deletion(self, res_type, res_id, args\u003d{}, interval\u003d3,"},{"line_number":120,"context_line":"                                   timeout\u003d180, microversion\u003dNone):"},{"line_number":121,"context_line":"        \"\"\"Resource deletion waiter."},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_09d9c97d","line":119,"range":{"start_line":119,"start_character":59,"end_line":119,"end_character":67},"in_reply_to":"5faad753_fa21ba4e","updated":"2019-09-12 14:58:01.000000000","message":"Great concern. Thanks.","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a629c52366e8f45e34a63b89ad21c9081b579c8","unresolved":false,"context_lines":[{"line_number":590,"context_line":"            data[\u0027--availability_zone\u0027] \u003d availability_zone"},{"line_number":591,"context_line":"        cmd \u003d \u0027\u0027"},{"line_number":592,"context_line":"        for key, value in data.items():"},{"line_number":593,"context_line":"            cmd +\u003d \"%(k)s\u003d%(v)s \" % dict(k\u003dkey, v\u003dvalue)"},{"line_number":594,"context_line":"        return cmd"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"    def add_share_network_subnet(self, share_network,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_1ae29602","line":593,"range":{"start_line":593,"start_character":36,"end_line":593,"end_character":56},"updated":"2019-09-11 00:52:37.000000000","message":"{\u0027k\u0027: key, \u0027v\u0027: value} -\u003e much faster: https://doughellmann.com/blog/2012/11/12/the-performance-impact-of-using-dict-instead-of-in-cpython-2-7-2/  (same is true for python3)","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3527c53a070cd4ed147edf1a56c30ee2a691a7f3","unresolved":false,"context_lines":[{"line_number":590,"context_line":"            data[\u0027--availability_zone\u0027] \u003d availability_zone"},{"line_number":591,"context_line":"        cmd \u003d \u0027\u0027"},{"line_number":592,"context_line":"        for key, value in data.items():"},{"line_number":593,"context_line":"            cmd +\u003d \"%(k)s\u003d%(v)s \" % dict(k\u003dkey, v\u003dvalue)"},{"line_number":594,"context_line":"        return cmd"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"    def add_share_network_subnet(self, share_network,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_c9865114","line":593,"range":{"start_line":593,"start_character":36,"end_line":593,"end_character":56},"in_reply_to":"5faad753_1ae29602","updated":"2019-09-12 14:58:01.000000000","message":"Great concern, thanks :)","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a629c52366e8f45e34a63b89ad21c9081b579c8","unresolved":false,"context_lines":[{"line_number":602,"context_line":"            neutron_subnet_id\u003dneutron_subnet_id,"},{"line_number":603,"context_line":"            availability_zone\u003davailability_zone)"},{"line_number":604,"context_line":"        share_network_subnet_raw \u003d self.manila("},{"line_number":605,"context_line":"            \u0027share-network-subnet-add %(sn)s %(params)s\u0027 % dict("},{"line_number":606,"context_line":"                sn\u003dshare_network, params\u003dparams),"},{"line_number":607,"context_line":"            microversion\u003dmicroversion)"},{"line_number":608,"context_line":"        share_network_subnet \u003d output_parser.details(share_network_subnet_raw)"},{"line_number":609,"context_line":"        return share_network_subnet"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_daeb9ed9","line":606,"range":{"start_line":605,"start_character":59,"end_line":606,"end_character":48},"updated":"2019-09-11 00:52:37.000000000","message":"same as above - avoid the dict() constructor based initialization in general when possible.","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3527c53a070cd4ed147edf1a56c30ee2a691a7f3","unresolved":false,"context_lines":[{"line_number":602,"context_line":"            neutron_subnet_id\u003dneutron_subnet_id,"},{"line_number":603,"context_line":"            availability_zone\u003davailability_zone)"},{"line_number":604,"context_line":"        share_network_subnet_raw \u003d self.manila("},{"line_number":605,"context_line":"            \u0027share-network-subnet-add %(sn)s %(params)s\u0027 % dict("},{"line_number":606,"context_line":"                sn\u003dshare_network, params\u003dparams),"},{"line_number":607,"context_line":"            microversion\u003dmicroversion)"},{"line_number":608,"context_line":"        share_network_subnet \u003d output_parser.details(share_network_subnet_raw)"},{"line_number":609,"context_line":"        return share_network_subnet"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_c99bb163","line":606,"range":{"start_line":605,"start_character":59,"end_line":606,"end_character":48},"in_reply_to":"5faad753_daeb9ed9","updated":"2019-09-12 14:58:01.000000000","message":"Done","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"}],"manilaclient/tests/functional/test_share_network_subnets.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a629c52366e8f45e34a63b89ad21c9081b579c8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 NetApp"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_bac90279","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":16},"updated":"2019-09-11 00:52:37.000000000","message":"2019?","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3527c53a070cd4ed147edf1a56c30ee2a691a7f3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 NetApp"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_9e5731cb","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":16},"in_reply_to":"5faad753_bac90279","updated":"2019-09-12 14:58:01.000000000","message":"Copy and paste problem :p","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a629c52366e8f45e34a63b89ad21c9081b579c8","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        )"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def _get_default_subnet(self, share_network_id):"},{"line_number":43,"context_line":"        share_subnets \u003d self.admin_client.get_share_network_subnets("},{"line_number":44,"context_line":"            share_network_id)"},{"line_number":45,"context_line":"        return next(subnet for subnet in share_subnets"},{"line_number":46,"context_line":"                    if subnet[\u0027availability_zone\u0027] \u003d\u003d \u0027None\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_7a062a89","line":43,"range":{"start_line":43,"start_character":29,"end_line":43,"end_character":41},"updated":"2019-09-11 00:52:37.000000000","message":"why do you need the admin_client?","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3527c53a070cd4ed147edf1a56c30ee2a691a7f3","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        )"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def _get_default_subnet(self, share_network_id):"},{"line_number":43,"context_line":"        share_subnets \u003d self.admin_client.get_share_network_subnets("},{"line_number":44,"context_line":"            share_network_id)"},{"line_number":45,"context_line":"        return next(subnet for subnet in share_subnets"},{"line_number":46,"context_line":"                    if subnet[\u0027availability_zone\u0027] \u003d\u003d \u0027None\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_491ca1c0","line":43,"range":{"start_line":43,"start_character":29,"end_line":43,"end_character":41},"in_reply_to":"5faad753_7a062a89","updated":"2019-09-12 14:58:01.000000000","message":"There is no need to add the admin client. Changed to the user client.","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a629c52366e8f45e34a63b89ad21c9081b579c8","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def test_get_share_network_subnet(self):"},{"line_number":49,"context_line":"        default_subnet \u003d self._get_default_subnet(self.sn[\u0027id\u0027])"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        subnet \u003d self.admin_client.get_share_network_subnet("},{"line_number":52,"context_line":"            self.sn[\u0027id\u0027], default_subnet[\u0027id\u0027])"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        self.assertEqual(self.neutron_net_id, subnet[\u0027neutron_net_id\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_9a09a696","line":51,"range":{"start_line":51,"start_character":22,"end_line":51,"end_character":34},"updated":"2019-09-11 00:52:37.000000000","message":"why do you need the admin_client?","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3527c53a070cd4ed147edf1a56c30ee2a691a7f3","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def test_get_share_network_subnet(self):"},{"line_number":49,"context_line":"        default_subnet \u003d self._get_default_subnet(self.sn[\u0027id\u0027])"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        subnet \u003d self.admin_client.get_share_network_subnet("},{"line_number":52,"context_line":"            self.sn[\u0027id\u0027], default_subnet[\u0027id\u0027])"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        self.assertEqual(self.neutron_net_id, subnet[\u0027neutron_net_id\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_e97a2def","line":51,"range":{"start_line":51,"start_character":22,"end_line":51,"end_character":34},"in_reply_to":"5faad753_9a09a696","updated":"2019-09-12 14:58:01.000000000","message":"Done","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a629c52366e8f45e34a63b89ad21c9081b579c8","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    def test_get_invalid_share_network_subnet(self):"},{"line_number":58,"context_line":"        self.assertRaises("},{"line_number":59,"context_line":"            exceptions.CommandFailed,"},{"line_number":60,"context_line":"            self.admin_client.get_share_network_subnet,"},{"line_number":61,"context_line":"            self.sn[\u0027id\u0027], \u0027invalid_subnet_id\u0027)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def _get_availability_zone(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_3a00b267","line":60,"range":{"start_line":60,"start_character":17,"end_line":60,"end_character":29},"updated":"2019-09-11 00:52:37.000000000","message":"why do you need the admin_client?","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3527c53a070cd4ed147edf1a56c30ee2a691a7f3","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    def test_get_invalid_share_network_subnet(self):"},{"line_number":58,"context_line":"        self.assertRaises("},{"line_number":59,"context_line":"            exceptions.CommandFailed,"},{"line_number":60,"context_line":"            self.admin_client.get_share_network_subnet,"},{"line_number":61,"context_line":"            self.sn[\u0027id\u0027], \u0027invalid_subnet_id\u0027)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def _get_availability_zone(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_696e3d30","line":60,"range":{"start_line":60,"start_character":17,"end_line":60,"end_character":29},"in_reply_to":"5faad753_3a00b267","updated":"2019-09-12 14:58:01.000000000","message":"Done","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a629c52366e8f45e34a63b89ad21c9081b579c8","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            self.sn[\u0027id\u0027], \u0027invalid_subnet_id\u0027)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def _get_availability_zone(self):"},{"line_number":64,"context_line":"        availability_zones \u003d self.admin_client.list_availability_zones()"},{"line_number":65,"context_line":"        return availability_zones[0][\u0027Name\u0027]"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def test_add_share_network_subnet_to_share_network(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_5a032e74","line":64,"range":{"start_line":64,"start_character":34,"end_line":64,"end_character":46},"updated":"2019-09-11 00:52:37.000000000","message":"why do you need the admin_client?","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3527c53a070cd4ed147edf1a56c30ee2a691a7f3","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            self.sn[\u0027id\u0027], \u0027invalid_subnet_id\u0027)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def _get_availability_zone(self):"},{"line_number":64,"context_line":"        availability_zones \u003d self.admin_client.list_availability_zones()"},{"line_number":65,"context_line":"        return availability_zones[0][\u0027Name\u0027]"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def test_add_share_network_subnet_to_share_network(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_896b791c","line":64,"range":{"start_line":64,"start_character":34,"end_line":64,"end_character":46},"in_reply_to":"5faad753_5a032e74","updated":"2019-09-12 14:58:01.000000000","message":"Done","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a629c52366e8f45e34a63b89ad21c9081b579c8","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        self.assertRaises("},{"line_number":96,"context_line":"            exceptions.CommandFailed,"},{"line_number":97,"context_line":"            self.add_share_network_subnet,"},{"line_number":98,"context_line":"            \u0027invalid_subnet\u0027,"},{"line_number":99,"context_line":"            self.neutron_net_id,"},{"line_number":100,"context_line":"            self.neutron_subnet_id)"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_3ae752e7","line":98,"range":{"start_line":98,"start_character":13,"end_line":98,"end_character":27},"updated":"2019-09-11 00:52:37.000000000","message":"invalid_share_network","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3527c53a070cd4ed147edf1a56c30ee2a691a7f3","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        self.assertRaises("},{"line_number":96,"context_line":"            exceptions.CommandFailed,"},{"line_number":97,"context_line":"            self.add_share_network_subnet,"},{"line_number":98,"context_line":"            \u0027invalid_subnet\u0027,"},{"line_number":99,"context_line":"            self.neutron_net_id,"},{"line_number":100,"context_line":"            self.neutron_subnet_id)"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_2974c5fd","line":98,"range":{"start_line":98,"start_character":13,"end_line":98,"end_character":27},"in_reply_to":"5faad753_3ae752e7","updated":"2019-09-12 14:58:01.000000000","message":"Done","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a629c52366e8f45e34a63b89ad21c9081b579c8","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            neutron_net_id, neutron_subnet_id,"},{"line_number":110,"context_line":"            availability_zone,"},{"line_number":111,"context_line":"            cleanup_in_class\u003dFalse)"},{"line_number":112,"context_line":"        self.admin_client.delete_share_network_subnet("},{"line_number":113,"context_line":"            share_network_subnet\u003dsubnet[\u0027id\u0027],"},{"line_number":114,"context_line":"            share_network\u003dself.sn[\u0027id\u0027])"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_faf9ba7f","line":112,"range":{"start_line":112,"start_character":13,"end_line":112,"end_character":25},"updated":"2019-09-11 00:52:37.000000000","message":"why do you need the admin_client?","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3527c53a070cd4ed147edf1a56c30ee2a691a7f3","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            neutron_net_id, neutron_subnet_id,"},{"line_number":110,"context_line":"            availability_zone,"},{"line_number":111,"context_line":"            cleanup_in_class\u003dFalse)"},{"line_number":112,"context_line":"        self.admin_client.delete_share_network_subnet("},{"line_number":113,"context_line":"            share_network_subnet\u003dsubnet[\u0027id\u0027],"},{"line_number":114,"context_line":"            share_network\u003dself.sn[\u0027id\u0027])"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_e9630d41","line":112,"range":{"start_line":112,"start_character":13,"end_line":112,"end_character":25},"in_reply_to":"5faad753_faf9ba7f","updated":"2019-09-12 14:58:01.000000000","message":"Done","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a629c52366e8f45e34a63b89ad21c9081b579c8","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            share_network_subnet\u003dsubnet[\u0027id\u0027],"},{"line_number":114,"context_line":"            share_network\u003dself.sn[\u0027id\u0027])"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        self.admin_client.wait_for_share_network_subnet_deletion("},{"line_number":117,"context_line":"            share_network_subnet\u003dsubnet[\u0027id\u0027],"},{"line_number":118,"context_line":"            share_network\u003dself.sn[\u0027id\u0027])"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_1af5b683","line":116,"range":{"start_line":116,"start_character":13,"end_line":116,"end_character":25},"updated":"2019-09-11 00:52:37.000000000","message":"why do you need the admin_client?","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3527c53a070cd4ed147edf1a56c30ee2a691a7f3","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            share_network_subnet\u003dsubnet[\u0027id\u0027],"},{"line_number":114,"context_line":"            share_network\u003dself.sn[\u0027id\u0027])"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        self.admin_client.wait_for_share_network_subnet_deletion("},{"line_number":117,"context_line":"            share_network_subnet\u003dsubnet[\u0027id\u0027],"},{"line_number":118,"context_line":"            share_network\u003dself.sn[\u0027id\u0027])"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_69571d5a","line":116,"range":{"start_line":116,"start_character":13,"end_line":116,"end_character":25},"in_reply_to":"5faad753_1af5b683","updated":"2019-09-12 14:58:01.000000000","message":"Done","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a629c52366e8f45e34a63b89ad21c9081b579c8","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    def test_delete_invalid_share_network_subnet(self):"},{"line_number":121,"context_line":"        self.assertRaises("},{"line_number":122,"context_line":"            exceptions.NotFound,"},{"line_number":123,"context_line":"            self.admin_client.delete_share_network_subnet,"},{"line_number":124,"context_line":"            share_network_subnet\u003d\u0027invalid_subnet_id\u0027,"},{"line_number":125,"context_line":"            share_network\u003dself.sn[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_baf3429e","line":123,"range":{"start_line":123,"start_character":17,"end_line":123,"end_character":29},"updated":"2019-09-11 00:52:37.000000000","message":"why do you need the admin_client?","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3527c53a070cd4ed147edf1a56c30ee2a691a7f3","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    def test_delete_invalid_share_network_subnet(self):"},{"line_number":121,"context_line":"        self.assertRaises("},{"line_number":122,"context_line":"            exceptions.NotFound,"},{"line_number":123,"context_line":"            self.admin_client.delete_share_network_subnet,"},{"line_number":124,"context_line":"            share_network_subnet\u003d\u0027invalid_subnet_id\u0027,"},{"line_number":125,"context_line":"            share_network\u003dself.sn[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_8954d954","line":123,"range":{"start_line":123,"start_character":17,"end_line":123,"end_character":29},"in_reply_to":"5faad753_baf3429e","updated":"2019-09-12 14:58:01.000000000","message":"Done","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"}],"manilaclient/tests/functional/test_share_networks.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"47c717b5271083fe81e4d7e2564d10f4e8ad44fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7faddb67_9a46927b","updated":"2019-08-27 19:47:55.000000000","message":"One test that is missing is the ability to create a new share network in a specific availability-zone, not in the default one. Can you add it here?","commit_id":"cd357dc915ada4599a4eee2132a921e9b789c0b2"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"560d3f3dfda01e578b87ecd42b66c4e85d520145","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7faddb67_e389ccc6","in_reply_to":"7faddb67_9a46927b","updated":"2019-09-02 13:38:48.000000000","message":"Done. Added a new ddt case on test_create_delete to create a share network in a specific availability zone. Thanks for pointing that out.","commit_id":"cd357dc915ada4599a4eee2132a921e9b789c0b2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a629c52366e8f45e34a63b89ad21c9081b579c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"5faad753_9a1766a4","updated":"2019-09-11 00:52:37.000000000","message":"Weird that the admin_client is abused in this file; we ought to test this as if a regular tenant user is using these commands - where appropriate, can you please change to using a regular client?","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3527c53a070cd4ed147edf1a56c30ee2a691a7f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"5faad753_69b39d99","in_reply_to":"5faad753_9a1766a4","updated":"2019-09-12 14:58:01.000000000","message":"Surely. Done.","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a629c52366e8f45e34a63b89ad21c9081b579c8","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        )"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def _get_default_subnet(self, share_network_id):"},{"line_number":44,"context_line":"        share_subnets \u003d self.admin_client.get_share_network_subnets("},{"line_number":45,"context_line":"            share_network_id)"},{"line_number":46,"context_line":"        default_subnet \u003d None"},{"line_number":47,"context_line":"        for subnet in share_subnets:"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_7a2b8aea","line":44,"range":{"start_line":44,"start_character":29,"end_line":44,"end_character":41},"updated":"2019-09-11 00:52:37.000000000","message":"why do you need the admin_client?","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3527c53a070cd4ed147edf1a56c30ee2a691a7f3","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        )"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def _get_default_subnet(self, share_network_id):"},{"line_number":44,"context_line":"        share_subnets \u003d self.admin_client.get_share_network_subnets("},{"line_number":45,"context_line":"            share_network_id)"},{"line_number":46,"context_line":"        default_subnet \u003d None"},{"line_number":47,"context_line":"        for subnet in share_subnets:"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_497b41bd","line":44,"range":{"start_line":44,"start_character":29,"end_line":44,"end_character":41},"in_reply_to":"5faad753_7a2b8aea","updated":"2019-09-12 14:58:01.000000000","message":"Done","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a629c52366e8f45e34a63b89ad21c9081b579c8","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        default_subnet \u003d None"},{"line_number":47,"context_line":"        for subnet in share_subnets:"},{"line_number":48,"context_line":"            if subnet[\u0027availability_zone\u0027] \u003d\u003d \u0027None\u0027:"},{"line_number":49,"context_line":"                default_subnet \u003d subnet"},{"line_number":50,"context_line":"        default_subnet \u003d default_subnet if default_subnet else share_subnets[0]"},{"line_number":51,"context_line":"        return default_subnet"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_3a351247","line":49,"range":{"start_line":49,"start_character":17,"end_line":49,"end_character":39},"updated":"2019-09-11 00:52:37.000000000","message":"break, after this","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3527c53a070cd4ed147edf1a56c30ee2a691a7f3","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        default_subnet \u003d None"},{"line_number":47,"context_line":"        for subnet in share_subnets:"},{"line_number":48,"context_line":"            if subnet[\u0027availability_zone\u0027] \u003d\u003d \u0027None\u0027:"},{"line_number":49,"context_line":"                default_subnet \u003d subnet"},{"line_number":50,"context_line":"        default_subnet \u003d default_subnet if default_subnet else share_subnets[0]"},{"line_number":51,"context_line":"        return default_subnet"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_e94d4d9a","line":49,"range":{"start_line":49,"start_character":17,"end_line":49,"end_character":39},"in_reply_to":"5faad753_3a351247","updated":"2019-09-12 14:58:01.000000000","message":"Done","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a629c52366e8f45e34a63b89ad21c9081b579c8","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            [\u0027neutron_net_id\u0027, \u0027neutron_subnet_id\u0027, \u0027availability_zone\u0027]"},{"line_number":66,"context_line":"            if share_subnet_support else [])"},{"line_number":67,"context_line":"        if share_subnet_support:"},{"line_number":68,"context_line":"            az \u003d self.admin_client.list_availability_zones()[0]"},{"line_number":69,"context_line":"            net_data[\u0027availability_zone\u0027] \u003d az[\u0027Name\u0027]"},{"line_number":70,"context_line":"        sn \u003d self.create_share_network(cleanup_in_class\u003dFalse, **net_data)"},{"line_number":71,"context_line":"        default_subnet \u003d (self._get_default_subnet(sn[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_da439eae","line":68,"range":{"start_line":68,"start_character":22,"end_line":68,"end_character":34},"updated":"2019-09-11 00:52:37.000000000","message":"why do you need the admin client?","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3527c53a070cd4ed147edf1a56c30ee2a691a7f3","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            [\u0027neutron_net_id\u0027, \u0027neutron_subnet_id\u0027, \u0027availability_zone\u0027]"},{"line_number":66,"context_line":"            if share_subnet_support else [])"},{"line_number":67,"context_line":"        if share_subnet_support:"},{"line_number":68,"context_line":"            az \u003d self.admin_client.list_availability_zones()[0]"},{"line_number":69,"context_line":"            net_data[\u0027availability_zone\u0027] \u003d az[\u0027Name\u0027]"},{"line_number":70,"context_line":"        sn \u003d self.create_share_network(cleanup_in_class\u003dFalse, **net_data)"},{"line_number":71,"context_line":"        default_subnet \u003d (self._get_default_subnet(sn[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_c9489188","line":68,"range":{"start_line":68,"start_character":22,"end_line":68,"end_character":34},"in_reply_to":"5faad753_da439eae","updated":"2019-09-12 14:58:01.000000000","message":"Done","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a629c52366e8f45e34a63b89ad21c9081b579c8","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    def test_create_update_share_network(self, net_data):"},{"line_number":119,"context_line":"        if utils.share_network_subnet_support():"},{"line_number":120,"context_line":"            if net_data.get(\u0027neutron_net_id\u0027):"},{"line_number":121,"context_line":"                reason \u003d (\"Microversion \u003e\u003d 2.51 does not support updating \""},{"line_number":122,"context_line":"                          \"neutron network\")"},{"line_number":123,"context_line":"                raise self.skipException(reason)"},{"line_number":124,"context_line":"            if net_data.get(\u0027neutron_subnet_id\u0027):"},{"line_number":125,"context_line":"                reason \u003d (\"Microversion \u003e\u003d 2.51 does not support updating \""}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_7a794afa","line":122,"range":{"start_line":121,"start_character":25,"end_line":122,"end_character":44},"updated":"2019-09-11 00:52:37.000000000","message":"It still does though [1], as long as there are no shares (or share servers) created on the share network... \n\n[1] https://review.opendev.org/#/c/671043/16/manila/api/v2/share_networks.py@262","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3527c53a070cd4ed147edf1a56c30ee2a691a7f3","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    def test_create_update_share_network(self, net_data):"},{"line_number":119,"context_line":"        if utils.share_network_subnet_support():"},{"line_number":120,"context_line":"            if net_data.get(\u0027neutron_net_id\u0027):"},{"line_number":121,"context_line":"                reason \u003d (\"Microversion \u003e\u003d 2.51 does not support updating \""},{"line_number":122,"context_line":"                          \"neutron network\")"},{"line_number":123,"context_line":"                raise self.skipException(reason)"},{"line_number":124,"context_line":"            if net_data.get(\u0027neutron_subnet_id\u0027):"},{"line_number":125,"context_line":"                reason \u003d (\"Microversion \u003e\u003d 2.51 does not support updating \""}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_69263dd1","line":122,"range":{"start_line":121,"start_character":25,"end_line":122,"end_character":44},"in_reply_to":"5faad753_7a794afa","updated":"2019-09-12 14:58:01.000000000","message":"Removed.","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"}],"manilaclient/tests/functional/test_share_servers.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"47c717b5271083fe81e4d7e2564d10f4e8ad44fb","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        if utils.is_microversion_supported(\u00272.49\u0027):"},{"line_number":148,"context_line":"            expected_keys +\u003d (\u0027identifier\u0027, \u0027is_auto_deletable\u0027)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        for key in expected_keys:"},{"line_number":151,"context_line":"            self.assertIn(key, server)"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_1cf05ffd","line":149,"updated":"2019-08-27 19:47:55.000000000","message":"And in microversion 2.50 we\u0027re adding the \u0027share_network_subnet_id\u0027","commit_id":"cd357dc915ada4599a4eee2132a921e9b789c0b2"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"560d3f3dfda01e578b87ecd42b66c4e85d520145","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        if utils.is_microversion_supported(\u00272.49\u0027):"},{"line_number":148,"context_line":"            expected_keys +\u003d (\u0027identifier\u0027, \u0027is_auto_deletable\u0027)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        for key in expected_keys:"},{"line_number":151,"context_line":"            self.assertIn(key, server)"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_aaadf9ea","line":149,"in_reply_to":"7faddb67_1cf05ffd","updated":"2019-09-02 13:38:48.000000000","message":"You meant that we should add in this test a call for share_network_subnet_id?","commit_id":"cd357dc915ada4599a4eee2132a921e9b789c0b2"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b5b6b99ed9ddef7d81f37b528ba5d318a3ca6967","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        if utils.is_microversion_supported(\u00272.49\u0027):"},{"line_number":148,"context_line":"            expected_keys +\u003d (\u0027identifier\u0027, \u0027is_auto_deletable\u0027)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        for key in expected_keys:"},{"line_number":151,"context_line":"            self.assertIn(key, server)"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_2ff58583","line":149,"in_reply_to":"7faddb67_aaadf9ea","updated":"2019-09-02 17:05:22.000000000","message":"No, it\u0027s missing the share_network_subnet_id on the expected keys, for microversion 2.50:\nif utils.is_microversion_supported(\u00272.50\u0027):\n            expected_keys +\u003d (\u0027share_network_subnet_id\u0027)","commit_id":"cd357dc915ada4599a4eee2132a921e9b789c0b2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a629c52366e8f45e34a63b89ad21c9081b579c8","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            message \u003d \"Can run only with DHSS\u003dTrue mode\""},{"line_number":84,"context_line":"            raise cls.skipException(message)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def _get_default_subnet(self, share_network):"},{"line_number":87,"context_line":"        subnets \u003d self.client.get_share_network_subnets(share_network[\u0027id\u0027])"},{"line_number":88,"context_line":"        return next(subnet for subnet in subnets"},{"line_number":89,"context_line":"                    if subnet[\u0027availability_zone\u0027] \u003d\u003d \u0027None\u0027)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def _create_share_and_share_network(self):"},{"line_number":92,"context_line":"        name \u003d data_utils.rand_name(\u0027autotest_share_name\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_da715e0e","line":89,"range":{"start_line":86,"start_character":0,"end_line":89,"end_character":61},"updated":"2019-09-11 00:52:37.000000000","message":"has been repeated in sufficient number of places, should probably be in utils.py or base.py..","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3527c53a070cd4ed147edf1a56c30ee2a691a7f3","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            message \u003d \"Can run only with DHSS\u003dTrue mode\""},{"line_number":84,"context_line":"            raise cls.skipException(message)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def _get_default_subnet(self, share_network):"},{"line_number":87,"context_line":"        subnets \u003d self.client.get_share_network_subnets(share_network[\u0027id\u0027])"},{"line_number":88,"context_line":"        return next(subnet for subnet in subnets"},{"line_number":89,"context_line":"                    if subnet[\u0027availability_zone\u0027] \u003d\u003d \u0027None\u0027)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def _create_share_and_share_network(self):"},{"line_number":92,"context_line":"        name \u003d data_utils.rand_name(\u0027autotest_share_name\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_644c2442","line":89,"range":{"start_line":86,"start_character":0,"end_line":89,"end_character":61},"in_reply_to":"5faad753_da715e0e","updated":"2019-09-12 14:58:01.000000000","message":"Done","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"}],"manilaclient/tests/functional/utils.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a629c52366e8f45e34a63b89ad21c9081b579c8","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    return selected_pool[\u0027Name\u0027]"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"def share_network_subnet_support():"},{"line_number":144,"context_line":"    return is_microversion_supported(\u00272.51\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_1a3a9633","line":143,"range":{"start_line":143,"start_character":4,"end_line":143,"end_character":32},"updated":"2019-09-11 00:52:37.000000000","message":"nit: share_network_subnets_are_supported\n\nso the conditions elsewhere become:\n\n  if share_network_subnets_are_supported():\n    ...","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3527c53a070cd4ed147edf1a56c30ee2a691a7f3","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    return selected_pool[\u0027Name\u0027]"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"def share_network_subnet_support():"},{"line_number":144,"context_line":"    return is_microversion_supported(\u00272.51\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_64142445","line":143,"range":{"start_line":143,"start_character":4,"end_line":143,"end_character":32},"in_reply_to":"5faad753_1a3a9633","updated":"2019-09-12 14:58:01.000000000","message":"Done","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"293db4e5b240b2f0d24c1e0a017e6879115c37ac","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    return selected_pool[\u0027Name\u0027]"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"def share_networks_are_subnet_supported():"},{"line_number":144,"context_line":"    return is_microversion_supported(\u00272.51\u0027)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"5faad753_97238656","line":143,"range":{"start_line":143,"start_character":4,"end_line":143,"end_character":39},"updated":"2019-09-13 00:08:30.000000000","message":"now this makes little sense :)\n\nI meant \"share_network_subnets_are_supported\"","commit_id":"43f50f75c066ec6a432cbd5917d9fb7e4ec9405d"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4d2c4b1b1c56743227d4f0707d4656621ec2cf73","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    return selected_pool[\u0027Name\u0027]"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"def share_networks_are_subnet_supported():"},{"line_number":144,"context_line":"    return is_microversion_supported(\u00272.51\u0027)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"5faad753_371bb2d0","line":143,"range":{"start_line":143,"start_character":4,"end_line":143,"end_character":39},"in_reply_to":"5faad753_97238656","updated":"2019-09-13 00:16:36.000000000","message":"Haha. Sorry for this. Done.","commit_id":"43f50f75c066ec6a432cbd5917d9fb7e4ec9405d"}],"manilaclient/tests/unit/v2/test_shell.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a629c52366e8f45e34a63b89ad21c9081b579c8","unresolved":false,"context_lines":[{"line_number":778,"context_line":"               },"},{"line_number":779,"context_line":"               \u0027version\u0027: \u00272.51\u0027,"},{"line_number":780,"context_line":"               },"},{"line_number":781,"context_line":"              {\u0027driver_args\u0027: \u0027--driver_options opt1\u003dopt1 opt2\u003dopt2\u0027,"},{"line_number":782,"context_line":"               \u0027valid_params\u0027: {"},{"line_number":783,"context_line":"                   \u0027driver_options\u0027: {\u0027opt1\u0027: \u0027opt1\u0027, \u0027opt2\u0027: \u0027opt2\u0027},"},{"line_number":784,"context_line":"               },"},{"line_number":785,"context_line":"               \u0027version\u0027: \u00272.49\u0027,"},{"line_number":786,"context_line":"               },"},{"line_number":787,"context_line":"              {\u0027driver_args\u0027: \"\","},{"line_number":788,"context_line":"               \u0027valid_params\u0027: {"},{"line_number":789,"context_line":"                   \u0027driver_options\u0027: {}"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_fada1ae7","line":786,"range":{"start_line":781,"start_character":14,"end_line":786,"end_character":17},"updated":"2019-09-11 00:52:37.000000000","message":"Can you add another test case where version is 2.49, and share-network is being passed instead of a share network subnet?","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3527c53a070cd4ed147edf1a56c30ee2a691a7f3","unresolved":false,"context_lines":[{"line_number":778,"context_line":"               },"},{"line_number":779,"context_line":"               \u0027version\u0027: \u00272.51\u0027,"},{"line_number":780,"context_line":"               },"},{"line_number":781,"context_line":"              {\u0027driver_args\u0027: \u0027--driver_options opt1\u003dopt1 opt2\u003dopt2\u0027,"},{"line_number":782,"context_line":"               \u0027valid_params\u0027: {"},{"line_number":783,"context_line":"                   \u0027driver_options\u0027: {\u0027opt1\u0027: \u0027opt1\u0027, \u0027opt2\u0027: \u0027opt2\u0027},"},{"line_number":784,"context_line":"               },"},{"line_number":785,"context_line":"               \u0027version\u0027: \u00272.49\u0027,"},{"line_number":786,"context_line":"               },"},{"line_number":787,"context_line":"              {\u0027driver_args\u0027: \"\","},{"line_number":788,"context_line":"               \u0027valid_params\u0027: {"},{"line_number":789,"context_line":"                   \u0027driver_options\u0027: {}"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_ea63fb40","line":786,"range":{"start_line":781,"start_character":14,"end_line":786,"end_character":17},"in_reply_to":"5faad753_fada1ae7","updated":"2019-09-12 14:58:01.000000000","message":"Done","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a629c52366e8f45e34a63b89ad21c9081b579c8","unresolved":false,"context_lines":[{"line_number":1531,"context_line":"        {\u0027data\u0027: {\u0027--neutron_subnet_id\u0027: \u0027fake_neutron_subnet_id\u0027},"},{"line_number":1532,"context_line":"         \u0027version\u0027: \u00272.51\u0027,"},{"line_number":1533,"context_line":"         },"},{"line_number":1534,"context_line":"        {\u0027data\u0027: {"},{"line_number":1535,"context_line":"            \u0027--description\u0027: \u0027fake_description\u0027,"},{"line_number":1536,"context_line":"            \u0027--name\u0027: \u0027fake_name\u0027,"},{"line_number":1537,"context_line":"            \u0027--neutron_net_id\u0027: \u0027fake_neutron_net_id\u0027,"},{"line_number":1538,"context_line":"            \u0027--neutron_subnet_id\u0027: \u0027fake_neutron_subnet_id\u0027},"},{"line_number":1539,"context_line":"         \u0027version\u0027: \u00272.51\u0027,"},{"line_number":1540,"context_line":"         },"},{"line_number":1541,"context_line":"        {\u0027data\u0027: {\u0027--neutron_net_id\u0027: \u0027\"\"\u0027},"},{"line_number":1542,"context_line":"         \u0027version\u0027: \u00272.51\u0027,"},{"line_number":1543,"context_line":"         },"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_1ad616c5","line":1540,"range":{"start_line":1534,"start_character":8,"end_line":1540,"end_character":11},"updated":"2019-09-11 00:52:37.000000000","message":"this should be valid, as long as the share network isn\u0027t being used?","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3527c53a070cd4ed147edf1a56c30ee2a691a7f3","unresolved":false,"context_lines":[{"line_number":1531,"context_line":"        {\u0027data\u0027: {\u0027--neutron_subnet_id\u0027: \u0027fake_neutron_subnet_id\u0027},"},{"line_number":1532,"context_line":"         \u0027version\u0027: \u00272.51\u0027,"},{"line_number":1533,"context_line":"         },"},{"line_number":1534,"context_line":"        {\u0027data\u0027: {"},{"line_number":1535,"context_line":"            \u0027--description\u0027: \u0027fake_description\u0027,"},{"line_number":1536,"context_line":"            \u0027--name\u0027: \u0027fake_name\u0027,"},{"line_number":1537,"context_line":"            \u0027--neutron_net_id\u0027: \u0027fake_neutron_net_id\u0027,"},{"line_number":1538,"context_line":"            \u0027--neutron_subnet_id\u0027: \u0027fake_neutron_subnet_id\u0027},"},{"line_number":1539,"context_line":"         \u0027version\u0027: \u00272.51\u0027,"},{"line_number":1540,"context_line":"         },"},{"line_number":1541,"context_line":"        {\u0027data\u0027: {\u0027--neutron_net_id\u0027: \u0027\"\"\u0027},"},{"line_number":1542,"context_line":"         \u0027version\u0027: \u00272.51\u0027,"},{"line_number":1543,"context_line":"         },"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_af11955f","line":1540,"range":{"start_line":1534,"start_character":8,"end_line":1540,"end_character":11},"in_reply_to":"5faad753_1ad616c5","updated":"2019-09-12 14:58:01.000000000","message":"According to the changes that were done and the question you\u0027ve raised regarding the possibility of the API to do this operation, IMO this test does not make sense anymore.","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"}],"manilaclient/v2/share_network_subnets.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"10742189eb5cdf079d13f8721362709803f87dd3","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    resource_class \u003d ShareNetworkSubnet"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def create(self, neutron_net_id\u003dNone, neutron_subnet_id\u003dNone,"},{"line_number":43,"context_line":"               availability_zone\u003dNone, share_network_id\u003dNone):"},{"line_number":44,"context_line":"        \"\"\"Create share network subnet."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5faad753_5890dbed","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":65},"updated":"2019-09-13 06:01:07.000000000","message":"@api_versions.wraps(\"2.51\")","commit_id":"b7d0d0d1289c3a8d74e584e894f7921c3d195d74"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"10742189eb5cdf079d13f8721362709803f87dd3","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        return self._create(url, body, RESOURCE_NAME)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def get(self, share_network, share_network_subnet):"},{"line_number":67,"context_line":"        \"\"\"Get a share network subnet."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        :param policy: share network subnet to get."}],"source_content_type":"text/x-python","patch_set":14,"id":"5faad753_788d97d1","line":66,"range":{"start_line":66,"start_character":0,"end_line":66,"end_character":55},"updated":"2019-09-13 06:01:07.000000000","message":"@api_versions.wraps(\"2.51\")","commit_id":"b7d0d0d1289c3a8d74e584e894f7921c3d195d74"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"10742189eb5cdf079d13f8721362709803f87dd3","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        }"},{"line_number":79,"context_line":"        return self._get(url, \"share_network_subnet\")"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def delete(self, share_network, share_network_subnet):"},{"line_number":82,"context_line":"        \"\"\"Delete a share network subnet."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        :param share_network: share network that owns the subnet."}],"source_content_type":"text/x-python","patch_set":14,"id":"5faad753_18c023e1","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":58},"updated":"2019-09-13 06:01:07.000000000","message":"@api_versions.wraps(\"2.51\")","commit_id":"b7d0d0d1289c3a8d74e584e894f7921c3d195d74"}],"manilaclient/v2/share_networks.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a629c52366e8f45e34a63b89ad21c9081b579c8","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @api_versions.wraps(\"2.26\")  # noqa"},{"line_number":74,"context_line":"    def create(self, neutron_net_id\u003dNone, neutron_subnet_id\u003dNone,"},{"line_number":75,"context_line":"               name\u003dNone, description\u003dNone, availability_zone\u003dNone):"},{"line_number":76,"context_line":"        \"\"\"Create share network."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        :param neutron_net_id: ID of Neutron network"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_daf87e4a","line":75,"range":{"start_line":75,"start_character":43,"end_line":75,"end_character":66},"updated":"2019-09-11 00:52:37.000000000","message":"AZ should not be allowed until version 2.51\n\nYou\u0027ll need to dedupe common stuff between this method and the method above, and create  a new helper method and create version specific top level methods:\n\n    @api_versions.wraps(\u00271.0\u0027, \u00272.25\u0027)\n    def create(self, neutron_net_id\u003dNone, neutron_subnet_id\u003dNone,\n               nova_net_id\u003dNone, name\u003dNone, description\u003dNone):\n                return self._create(...)\n\n \n\n    @api_versions.wraps(\u00272.26\u0027, \u00272.50\u0027)  # noqa\n    def create(self, neutron_net_id\u003dNone, neutron_subnet_id\u003dNone,\n               name\u003dNone, description\u003dNone):\n                return self._create(...)\n\n \n\n    @api_versions.wraps(\u00272.51\u0027)  # noqa\n    def create(self, neutron_net_id\u003dNone, neutron_subnet_id\u003dNone,\n               name\u003dNone, description\u003dNone, availability_zone\u003dNone):\n                return self._create(...)","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3527c53a070cd4ed147edf1a56c30ee2a691a7f3","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @api_versions.wraps(\"2.26\")  # noqa"},{"line_number":74,"context_line":"    def create(self, neutron_net_id\u003dNone, neutron_subnet_id\u003dNone,"},{"line_number":75,"context_line":"               name\u003dNone, description\u003dNone, availability_zone\u003dNone):"},{"line_number":76,"context_line":"        \"\"\"Create share network."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        :param neutron_net_id: ID of Neutron network"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_ca439f12","line":75,"range":{"start_line":75,"start_character":43,"end_line":75,"end_character":66},"in_reply_to":"5faad753_daf87e4a","updated":"2019-09-12 14:58:01.000000000","message":"Done","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"32e209f4a6044f48cac783daa99c6087df90fe13","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def delete(self):"},{"line_number":37,"context_line":"        \"\"\"Delete this share network.\"\"\""},{"line_number":38,"context_line":"        self.manager.delete(self)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class ShareNetworkManager(base.ManagerWithFind):"},{"line_number":42,"context_line":"    \"\"\"Manage :class:`ShareNetwork` resources.\"\"\""}],"source_content_type":"text/x-python","patch_set":14,"id":"5faad753_18334316","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":0},"updated":"2019-09-13 06:09:01.000000000","message":"Needs a subnets method here that retrieves subnets of the share network.","commit_id":"b7d0d0d1289c3a8d74e584e894f7921c3d195d74"}],"manilaclient/v2/share_servers.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a629c52366e8f45e34a63b89ad21c9081b579c8","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        query_string \u003d self._build_query_string(search_opts)"},{"line_number":98,"context_line":"        return self._list(RESOURCES_PATH + query_string, RESOURCES_NAME)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    @api_versions.wraps(\"2.49\")"},{"line_number":101,"context_line":"    def manage(self, host, share_network_id, identifier, driver_options\u003dNone):"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        driver_options \u003d driver_options or {}"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_7a95cae3","line":100,"range":{"start_line":100,"start_character":24,"end_line":100,"end_character":30},"updated":"2019-09-11 00:52:37.000000000","message":"\"2.49\", \"2.50\"","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3527c53a070cd4ed147edf1a56c30ee2a691a7f3","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        query_string \u003d self._build_query_string(search_opts)"},{"line_number":98,"context_line":"        return self._list(RESOURCES_PATH + query_string, RESOURCES_NAME)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    @api_versions.wraps(\"2.49\")"},{"line_number":101,"context_line":"    def manage(self, host, share_network_id, identifier, driver_options\u003dNone):"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        driver_options \u003d driver_options or {}"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_099c690d","line":100,"range":{"start_line":100,"start_character":24,"end_line":100,"end_character":30},"in_reply_to":"5faad753_7a95cae3","updated":"2019-09-12 14:58:01.000000000","message":"Done","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a629c52366e8f45e34a63b89ad21c9081b579c8","unresolved":false,"context_lines":[{"line_number":2716,"context_line":"    metavar\u003d\u0027\u003cavailability_zone\u003e\u0027,"},{"line_number":2717,"context_line":"    default\u003dNone,"},{"line_number":2718,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":2719,"context_line":"    help\u003d\"Availability zone in which the default subnet should be created. \""},{"line_number":2720,"context_line":"         \"Share networks can have one or more subnets in different \""},{"line_number":2721,"context_line":"         \"availability zones when the driver is operating with \""},{"line_number":2722,"context_line":"         \"\u0027driver_handles_share_servers\u0027 extra_spec set to True. Available \""}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_ba9262f5","line":2719,"range":{"start_line":2719,"start_character":41,"end_line":2719,"end_character":48},"updated":"2019-09-11 00:52:37.000000000","message":"If an AZ is provided it\u0027s no longer the \"default\" subnet; remove","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3527c53a070cd4ed147edf1a56c30ee2a691a7f3","unresolved":false,"context_lines":[{"line_number":2716,"context_line":"    metavar\u003d\u0027\u003cavailability_zone\u003e\u0027,"},{"line_number":2717,"context_line":"    default\u003dNone,"},{"line_number":2718,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":2719,"context_line":"    help\u003d\"Availability zone in which the default subnet should be created. \""},{"line_number":2720,"context_line":"         \"Share networks can have one or more subnets in different \""},{"line_number":2721,"context_line":"         \"availability zones when the driver is operating with \""},{"line_number":2722,"context_line":"         \"\u0027driver_handles_share_servers\u0027 extra_spec set to True. Available \""}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_3e439db1","line":2719,"range":{"start_line":2719,"start_character":41,"end_line":2719,"end_character":48},"in_reply_to":"5faad753_ba9262f5","updated":"2019-09-12 14:58:01.000000000","message":"Done","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a629c52366e8f45e34a63b89ad21c9081b579c8","unresolved":false,"context_lines":[{"line_number":2828,"context_line":"    help\u003d\"Share network description.\")"},{"line_number":2829,"context_line":"def do_share_network_update(cs, args):"},{"line_number":2830,"context_line":"    \"\"\"Update share network data.\"\"\""},{"line_number":2831,"context_line":"    if cs.api_version \u003e\u003d api_versions.APIVersion(\"2.51\"):"},{"line_number":2832,"context_line":"        if getattr(args, \u0027neutron_net_id\u0027):"},{"line_number":2833,"context_line":"            raise exceptions.CommandError("},{"line_number":2834,"context_line":"                \"Neutron network option is deprecated for API version \u003e\u003d 2.51\")"},{"line_number":2835,"context_line":"        if getattr(args, \u0027neutron_subnet_id\u0027):"},{"line_number":2836,"context_line":"            raise exceptions.CommandError("},{"line_number":2837,"context_line":"                \"Neutron network subnet option is deprecated for API version \""},{"line_number":2838,"context_line":"                \"\u003e\u003d 2.51\")"},{"line_number":2839,"context_line":""},{"line_number":2840,"context_line":"    values \u003d {"},{"line_number":2841,"context_line":"        \u0027neutron_net_id\u0027: args.neutron_net_id,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_5abb2e71","line":2838,"range":{"start_line":2831,"start_character":0,"end_line":2838,"end_character":26},"updated":"2019-09-11 00:52:37.000000000","message":"The API allows it, why would we prevent it from the client?","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3527c53a070cd4ed147edf1a56c30ee2a691a7f3","unresolved":false,"context_lines":[{"line_number":2828,"context_line":"    help\u003d\"Share network description.\")"},{"line_number":2829,"context_line":"def do_share_network_update(cs, args):"},{"line_number":2830,"context_line":"    \"\"\"Update share network data.\"\"\""},{"line_number":2831,"context_line":"    if cs.api_version \u003e\u003d api_versions.APIVersion(\"2.51\"):"},{"line_number":2832,"context_line":"        if getattr(args, \u0027neutron_net_id\u0027):"},{"line_number":2833,"context_line":"            raise exceptions.CommandError("},{"line_number":2834,"context_line":"                \"Neutron network option is deprecated for API version \u003e\u003d 2.51\")"},{"line_number":2835,"context_line":"        if getattr(args, \u0027neutron_subnet_id\u0027):"},{"line_number":2836,"context_line":"            raise exceptions.CommandError("},{"line_number":2837,"context_line":"                \"Neutron network subnet option is deprecated for API version \""},{"line_number":2838,"context_line":"                \"\u003e\u003d 2.51\")"},{"line_number":2839,"context_line":""},{"line_number":2840,"context_line":"    values \u003d {"},{"line_number":2841,"context_line":"        \u0027neutron_net_id\u0027: args.neutron_net_id,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_c972d1ad","line":2838,"range":{"start_line":2831,"start_character":0,"end_line":2838,"end_character":26},"in_reply_to":"5faad753_5abb2e71","updated":"2019-09-12 14:58:01.000000000","message":"The API allows it to be updated only when handling with the default subnet, since we do not have an availability zone parameter here. In the future improvement we can add the availability zone parameter to make it possible for other subnets. Removed.","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a629c52366e8f45e34a63b89ad21c9081b579c8","unresolved":false,"context_lines":[{"line_number":3242,"context_line":"    metavar\u003d\u0027\u003cneutron-net-id\u003e\u0027,"},{"line_number":3243,"context_line":"    default\u003dNone,"},{"line_number":3244,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":3245,"context_line":"    help\u003d\"Neutron network ID. Used to set up network for share servers.\")"},{"line_number":3246,"context_line":"@cliutils.arg("},{"line_number":3247,"context_line":"    \u0027--neutron-subnet-id\u0027,"},{"line_number":3248,"context_line":"    \u0027--neutron-subnet_id\u0027, \u0027--neutron_subnet_id\u0027, \u0027--neutron_subnet-id\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_1a7296e4","line":3245,"range":{"start_line":3245,"start_character":70,"end_line":3245,"end_character":71},"updated":"2019-09-11 00:52:37.000000000","message":"(Optional, Default \u003d None)","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3527c53a070cd4ed147edf1a56c30ee2a691a7f3","unresolved":false,"context_lines":[{"line_number":3242,"context_line":"    metavar\u003d\u0027\u003cneutron-net-id\u003e\u0027,"},{"line_number":3243,"context_line":"    default\u003dNone,"},{"line_number":3244,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":3245,"context_line":"    help\u003d\"Neutron network ID. Used to set up network for share servers.\")"},{"line_number":3246,"context_line":"@cliutils.arg("},{"line_number":3247,"context_line":"    \u0027--neutron-subnet-id\u0027,"},{"line_number":3248,"context_line":"    \u0027--neutron-subnet_id\u0027, \u0027--neutron_subnet_id\u0027, \u0027--neutron_subnet-id\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_1e1fc1b7","line":3245,"range":{"start_line":3245,"start_character":70,"end_line":3245,"end_character":71},"in_reply_to":"5faad753_1a7296e4","updated":"2019-09-12 14:58:01.000000000","message":"Done","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a629c52366e8f45e34a63b89ad21c9081b579c8","unresolved":false,"context_lines":[{"line_number":3250,"context_line":"    default\u003dNone,"},{"line_number":3251,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":3252,"context_line":"    help\u003d\"Neutron subnet ID. Used to set up network for share servers. \""},{"line_number":3253,"context_line":"         \"This subnet should belong to specified neutron network.\")"},{"line_number":3254,"context_line":"@cliutils.arg("},{"line_number":3255,"context_line":"    \u0027--availability-zone\u0027,"},{"line_number":3256,"context_line":"    \u0027--availability_zone\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_ba80228d","line":3253,"range":{"start_line":3253,"start_character":64,"end_line":3253,"end_character":65},"updated":"2019-09-11 00:52:37.000000000","message":"(Optional, Default \u003d None)","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3527c53a070cd4ed147edf1a56c30ee2a691a7f3","unresolved":false,"context_lines":[{"line_number":3250,"context_line":"    default\u003dNone,"},{"line_number":3251,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":3252,"context_line":"    help\u003d\"Neutron subnet ID. Used to set up network for share servers. \""},{"line_number":3253,"context_line":"         \"This subnet should belong to specified neutron network.\")"},{"line_number":3254,"context_line":"@cliutils.arg("},{"line_number":3255,"context_line":"    \u0027--availability-zone\u0027,"},{"line_number":3256,"context_line":"    \u0027--availability_zone\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_3e1cfdbf","line":3253,"range":{"start_line":3253,"start_character":64,"end_line":3253,"end_character":65},"in_reply_to":"5faad753_ba80228d","updated":"2019-09-12 14:58:01.000000000","message":"Done","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a629c52366e8f45e34a63b89ad21c9081b579c8","unresolved":false,"context_lines":[{"line_number":3258,"context_line":"    default\u003dNone,"},{"line_number":3259,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":3260,"context_line":"    metavar\u003d\u0027\u003cavailability-zone\u003e\u0027,"},{"line_number":3261,"context_line":"    help\u003d\u0027Optional availability zone that the subnet should be created \u0027"},{"line_number":3262,"context_line":"         \u0027(Default\u003dNone). If None, the subnet will be considered default.\u0027)"},{"line_number":3263,"context_line":"def do_share_network_subnet_add(cs, args):"},{"line_number":3264,"context_line":"    \"\"\"Add a new subnet into a share network.\"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_3a46727e","line":3261,"range":{"start_line":3261,"start_character":53,"end_line":3261,"end_character":70},"updated":"2019-09-11 00:52:37.000000000","message":"is available within","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3527c53a070cd4ed147edf1a56c30ee2a691a7f3","unresolved":false,"context_lines":[{"line_number":3258,"context_line":"    default\u003dNone,"},{"line_number":3259,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":3260,"context_line":"    metavar\u003d\u0027\u003cavailability-zone\u003e\u0027,"},{"line_number":3261,"context_line":"    help\u003d\u0027Optional availability zone that the subnet should be created \u0027"},{"line_number":3262,"context_line":"         \u0027(Default\u003dNone). If None, the subnet will be considered default.\u0027)"},{"line_number":3263,"context_line":"def do_share_network_subnet_add(cs, args):"},{"line_number":3264,"context_line":"    \"\"\"Add a new subnet into a share network.\"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_dec84923","line":3261,"range":{"start_line":3261,"start_character":53,"end_line":3261,"end_character":70},"in_reply_to":"5faad753_3a46727e","updated":"2019-09-12 14:58:01.000000000","message":"Done","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a629c52366e8f45e34a63b89ad21c9081b579c8","unresolved":false,"context_lines":[{"line_number":3259,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":3260,"context_line":"    metavar\u003d\u0027\u003cavailability-zone\u003e\u0027,"},{"line_number":3261,"context_line":"    help\u003d\u0027Optional availability zone that the subnet should be created \u0027"},{"line_number":3262,"context_line":"         \u0027(Default\u003dNone). If None, the subnet will be considered default.\u0027)"},{"line_number":3263,"context_line":"def do_share_network_subnet_add(cs, args):"},{"line_number":3264,"context_line":"    \"\"\"Add a new subnet into a share network.\"\"\""},{"line_number":3265,"context_line":"    if xor(bool(args.neutron_net_id), bool(args.neutron_subnet_id)):"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_5a49ee88","line":3262,"range":{"start_line":3262,"start_character":65,"end_line":3262,"end_character":72},"updated":"2019-09-11 00:52:37.000000000","message":"as being available across all availability zones.","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3527c53a070cd4ed147edf1a56c30ee2a691a7f3","unresolved":false,"context_lines":[{"line_number":3259,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":3260,"context_line":"    metavar\u003d\u0027\u003cavailability-zone\u003e\u0027,"},{"line_number":3261,"context_line":"    help\u003d\u0027Optional availability zone that the subnet should be created \u0027"},{"line_number":3262,"context_line":"         \u0027(Default\u003dNone). If None, the subnet will be considered default.\u0027)"},{"line_number":3263,"context_line":"def do_share_network_subnet_add(cs, args):"},{"line_number":3264,"context_line":"    \"\"\"Add a new subnet into a share network.\"\"\""},{"line_number":3265,"context_line":"    if xor(bool(args.neutron_net_id), bool(args.neutron_subnet_id)):"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_fef66563","line":3262,"range":{"start_line":3262,"start_character":65,"end_line":3262,"end_character":72},"in_reply_to":"5faad753_5a49ee88","updated":"2019-09-12 14:58:01.000000000","message":"Done","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"366c483379522de3ec1d997b2de6c20db8b29260","unresolved":false,"context_lines":[{"line_number":3260,"context_line":"    metavar\u003d\u0027\u003cavailability-zone\u003e\u0027,"},{"line_number":3261,"context_line":"    help\u003d\u0027Optional availability zone that the subnet should be created \u0027"},{"line_number":3262,"context_line":"         \u0027(Default\u003dNone). If None, the subnet will be considered default.\u0027)"},{"line_number":3263,"context_line":"def do_share_network_subnet_add(cs, args):"},{"line_number":3264,"context_line":"    \"\"\"Add a new subnet into a share network.\"\"\""},{"line_number":3265,"context_line":"    if xor(bool(args.neutron_net_id), bool(args.neutron_subnet_id)):"},{"line_number":3266,"context_line":"        raise exceptions.CommandError("}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_1daa90d1","line":3263,"range":{"start_line":3263,"start_character":28,"end_line":3263,"end_character":31},"updated":"2019-09-11 01:13:50.000000000","message":"create\n\n\nadd/delete would be inconsistent with the other resources - most of them use the verbs create/delete","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3527c53a070cd4ed147edf1a56c30ee2a691a7f3","unresolved":false,"context_lines":[{"line_number":3260,"context_line":"    metavar\u003d\u0027\u003cavailability-zone\u003e\u0027,"},{"line_number":3261,"context_line":"    help\u003d\u0027Optional availability zone that the subnet should be created \u0027"},{"line_number":3262,"context_line":"         \u0027(Default\u003dNone). If None, the subnet will be considered default.\u0027)"},{"line_number":3263,"context_line":"def do_share_network_subnet_add(cs, args):"},{"line_number":3264,"context_line":"    \"\"\"Add a new subnet into a share network.\"\"\""},{"line_number":3265,"context_line":"    if xor(bool(args.neutron_net_id), bool(args.neutron_subnet_id)):"},{"line_number":3266,"context_line":"        raise exceptions.CommandError("}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_7e87d5b6","line":3263,"range":{"start_line":3263,"start_character":28,"end_line":3263,"end_character":31},"in_reply_to":"5faad753_1daa90d1","updated":"2019-09-12 14:58:01.000000000","message":"Done","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a629c52366e8f45e34a63b89ad21c9081b579c8","unresolved":false,"context_lines":[{"line_number":3265,"context_line":"    if xor(bool(args.neutron_net_id), bool(args.neutron_subnet_id)):"},{"line_number":3266,"context_line":"        raise exceptions.CommandError("},{"line_number":3267,"context_line":"            \"Both neutron_net_id and neutron_subnet_id should be specified. \""},{"line_number":3268,"context_line":"            \"Alternatively, none of them should be specified.\")"},{"line_number":3269,"context_line":""},{"line_number":3270,"context_line":"    share_network \u003d _find_share_network(cs, args.share_network)"},{"line_number":3271,"context_line":"    values \u003d {"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_fa5f7a3e","line":3268,"range":{"start_line":3268,"start_character":28,"end_line":3268,"end_character":32},"updated":"2019-09-11 00:52:37.000000000","message":"neither","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3527c53a070cd4ed147edf1a56c30ee2a691a7f3","unresolved":false,"context_lines":[{"line_number":3265,"context_line":"    if xor(bool(args.neutron_net_id), bool(args.neutron_subnet_id)):"},{"line_number":3266,"context_line":"        raise exceptions.CommandError("},{"line_number":3267,"context_line":"            \"Both neutron_net_id and neutron_subnet_id should be specified. \""},{"line_number":3268,"context_line":"            \"Alternatively, none of them should be specified.\")"},{"line_number":3269,"context_line":""},{"line_number":3270,"context_line":"    share_network \u003d _find_share_network(cs, args.share_network)"},{"line_number":3271,"context_line":"    values \u003d {"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_9e9c110f","line":3268,"range":{"start_line":3268,"start_character":28,"end_line":3268,"end_character":32},"in_reply_to":"5faad753_fa5f7a3e","updated":"2019-09-12 14:58:01.000000000","message":"Done","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a629c52366e8f45e34a63b89ad21c9081b579c8","unresolved":false,"context_lines":[{"line_number":3298,"context_line":"            cs.share_network_subnets.delete(share_network_ref, subnet)"},{"line_number":3299,"context_line":"        except Exception as e:"},{"line_number":3300,"context_line":"            failure_count +\u003d 1"},{"line_number":3301,"context_line":"            print(\"Delete for share network subnet %s failed: %s\" % ("},{"line_number":3302,"context_line":"                subnet, e), file\u003dsys.stderr)"},{"line_number":3303,"context_line":""},{"line_number":3304,"context_line":"    if failure_count \u003d\u003d len(args.share_network_subnet):"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_da54fe23","line":3301,"range":{"start_line":3301,"start_character":19,"end_line":3301,"end_character":29},"updated":"2019-09-11 00:52:37.000000000","message":"Deletion of","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3527c53a070cd4ed147edf1a56c30ee2a691a7f3","unresolved":false,"context_lines":[{"line_number":3298,"context_line":"            cs.share_network_subnets.delete(share_network_ref, subnet)"},{"line_number":3299,"context_line":"        except Exception as e:"},{"line_number":3300,"context_line":"            failure_count +\u003d 1"},{"line_number":3301,"context_line":"            print(\"Delete for share network subnet %s failed: %s\" % ("},{"line_number":3302,"context_line":"                subnet, e), file\u003dsys.stderr)"},{"line_number":3303,"context_line":""},{"line_number":3304,"context_line":"    if failure_count \u003d\u003d len(args.share_network_subnet):"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_9e6ad1ea","line":3301,"range":{"start_line":3301,"start_character":19,"end_line":3301,"end_character":29},"in_reply_to":"5faad753_da54fe23","updated":"2019-09-12 14:58:01.000000000","message":"Done","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a629c52366e8f45e34a63b89ad21c9081b579c8","unresolved":false,"context_lines":[{"line_number":3309,"context_line":"@cliutils.arg("},{"line_number":3310,"context_line":"    \u0027share_network\u0027,"},{"line_number":3311,"context_line":"    metavar\u003d\u0027\u003cshare-network\u003e\u0027,"},{"line_number":3312,"context_line":"    help\u003d\u0027Name or ID of share network(s) where the subnet is contained.\u0027)"},{"line_number":3313,"context_line":"@cliutils.arg("},{"line_number":3314,"context_line":"    \u0027share_network_subnet\u0027,"},{"line_number":3315,"context_line":"    metavar\u003d\u0027\u003cshare-network-subnet\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_5a3eceda","line":3312,"range":{"start_line":3312,"start_character":41,"end_line":3312,"end_character":70},"updated":"2019-09-11 00:52:37.000000000","message":"to which the subnet belongs","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3527c53a070cd4ed147edf1a56c30ee2a691a7f3","unresolved":false,"context_lines":[{"line_number":3309,"context_line":"@cliutils.arg("},{"line_number":3310,"context_line":"    \u0027share_network\u0027,"},{"line_number":3311,"context_line":"    metavar\u003d\u0027\u003cshare-network\u003e\u0027,"},{"line_number":3312,"context_line":"    help\u003d\u0027Name or ID of share network(s) where the subnet is contained.\u0027)"},{"line_number":3313,"context_line":"@cliutils.arg("},{"line_number":3314,"context_line":"    \u0027share_network_subnet\u0027,"},{"line_number":3315,"context_line":"    metavar\u003d\u0027\u003cshare-network-subnet\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_1e7ee1ae","line":3312,"range":{"start_line":3312,"start_character":41,"end_line":3312,"end_character":70},"in_reply_to":"5faad753_5a3eceda","updated":"2019-09-12 14:58:01.000000000","message":"Done","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a629c52366e8f45e34a63b89ad21c9081b579c8","unresolved":false,"context_lines":[{"line_number":3676,"context_line":"    \u0027--share-network-subnet\u0027, \u0027--share_network_subnet\u0027,"},{"line_number":3677,"context_line":"    type\u003dstr,"},{"line_number":3678,"context_line":"    metavar\u003d\u0027\u003cshare_network_subnet\u003e\u0027,"},{"line_number":3679,"context_line":"    help\u003d\"Share network subnet where share server has network allocations in. \""},{"line_number":3680,"context_line":"         \"The default subnet will be used if it\u0027s not specified. Available \""},{"line_number":3681,"context_line":"         \"for microversion \u003e\u003d 2.51 (Optional, Default\u003dNone).\","},{"line_number":3682,"context_line":"    default\u003dNone)"},{"line_number":3683,"context_line":"def do_share_server_list(cs, args):"},{"line_number":3684,"context_line":"    \"\"\"List all share servers (Admin only).\"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_5a17ae52","line":3681,"range":{"start_line":3679,"start_character":10,"end_line":3681,"end_character":60},"updated":"2019-09-11 00:52:37.000000000","message":"Filter results by share network subnet that the share server\u0027s network allocations exist within. Available for micro version \u003e\u003d 2.51 (Optional, Default\u003dNone)","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3527c53a070cd4ed147edf1a56c30ee2a691a7f3","unresolved":false,"context_lines":[{"line_number":3676,"context_line":"    \u0027--share-network-subnet\u0027, \u0027--share_network_subnet\u0027,"},{"line_number":3677,"context_line":"    type\u003dstr,"},{"line_number":3678,"context_line":"    metavar\u003d\u0027\u003cshare_network_subnet\u003e\u0027,"},{"line_number":3679,"context_line":"    help\u003d\"Share network subnet where share server has network allocations in. \""},{"line_number":3680,"context_line":"         \"The default subnet will be used if it\u0027s not specified. Available \""},{"line_number":3681,"context_line":"         \"for microversion \u003e\u003d 2.51 (Optional, Default\u003dNone).\","},{"line_number":3682,"context_line":"    default\u003dNone)"},{"line_number":3683,"context_line":"def do_share_server_list(cs, args):"},{"line_number":3684,"context_line":"    \"\"\"List all share servers (Admin only).\"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_fe3745fe","line":3681,"range":{"start_line":3679,"start_character":10,"end_line":3681,"end_character":60},"in_reply_to":"5faad753_5a17ae52","updated":"2019-09-12 14:58:01.000000000","message":"Done","commit_id":"c1a52f3b5ddeebc86003b79edfbd6301d80ea181"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"10742189eb5cdf079d13f8721362709803f87dd3","unresolved":false,"context_lines":[{"line_number":3223,"context_line":""},{"line_number":3224,"context_line":"    cliutils.print_list(security_services, fields\u003dfields)"},{"line_number":3225,"context_line":""},{"line_number":3226,"context_line":""},{"line_number":3227,"context_line":"@cliutils.arg("},{"line_number":3228,"context_line":"    \u0027share_network\u0027,"},{"line_number":3229,"context_line":"    metavar\u003d\u0027\u003cshare-network\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"5faad753_78f83748","line":3226,"range":{"start_line":3226,"start_character":0,"end_line":3226,"end_character":0},"updated":"2019-09-13 06:01:07.000000000","message":"@api_versions.wraps(\"2.51\")","commit_id":"b7d0d0d1289c3a8d74e584e894f7921c3d195d74"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"10742189eb5cdf079d13f8721362709803f87dd3","unresolved":false,"context_lines":[{"line_number":3273,"context_line":"    info \u003d share_network_subnet._info.copy()"},{"line_number":3274,"context_line":"    cliutils.print_dict(info)"},{"line_number":3275,"context_line":""},{"line_number":3276,"context_line":""},{"line_number":3277,"context_line":"@cliutils.arg("},{"line_number":3278,"context_line":"    \u0027share_network\u0027,"},{"line_number":3279,"context_line":"    metavar\u003d\u0027\u003cshare-network\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"5faad753_389cff0d","line":3276,"range":{"start_line":3276,"start_character":0,"end_line":3276,"end_character":0},"updated":"2019-09-13 06:01:07.000000000","message":"@api_versions.wraps(\"2.51\")","commit_id":"b7d0d0d1289c3a8d74e584e894f7921c3d195d74"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"10742189eb5cdf079d13f8721362709803f87dd3","unresolved":false,"context_lines":[{"line_number":3300,"context_line":"        raise exceptions.CommandError(\"Unable to delete any of the specified \""},{"line_number":3301,"context_line":"                                      \"share network subnets.\")"},{"line_number":3302,"context_line":""},{"line_number":3303,"context_line":""},{"line_number":3304,"context_line":"@cliutils.arg("},{"line_number":3305,"context_line":"    \u0027share_network\u0027,"},{"line_number":3306,"context_line":"    metavar\u003d\u0027\u003cshare-network\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"5faad753_1897c3ee","line":3303,"range":{"start_line":3303,"start_character":0,"end_line":3303,"end_character":0},"updated":"2019-09-13 06:01:07.000000000","message":"@api_versions.wraps(\"2.51\")","commit_id":"b7d0d0d1289c3a8d74e584e894f7921c3d195d74"}]}