)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3649b9db2718174da52a987c786008b7c8dea177","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix update share network tests and skip exception issue"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After fixing a bug that was allowing share network update when it"},{"line_number":10,"context_line":"shouldn\u0027t, the test that validates the share network creation and"},{"line_number":11,"context_line":"update started failing. An additional validation was introduced in"},{"line_number":12,"context_line":"the fix for this bug, and this was this test failure cause. This"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_3b7f0f18","line":9,"range":{"start_line":9,"start_character":18,"end_line":9,"end_character":19},"updated":"2019-10-28 23:48:56.000000000","message":"suggest linking the bug here: https://bugs.launchpad.net/manila/+bug/1846836","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"81065476433ca45707e209ec71c18a5878e94367","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix update share network tests and skip exception issue"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After fixing a bug that was allowing share network update when it"},{"line_number":10,"context_line":"shouldn\u0027t, the test that validates the share network creation and"},{"line_number":11,"context_line":"update started failing. An additional validation was introduced in"},{"line_number":12,"context_line":"the fix for this bug, and this was this test failure cause. This"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_de134900","line":9,"range":{"start_line":9,"start_character":18,"end_line":9,"end_character":19},"in_reply_to":"3fa7e38b_3b7f0f18","updated":"2019-10-29 01:53:35.000000000","message":"Sure, thanks.","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"46e37d73fa79fd0128023df43a08cefc59433dc1","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After fixing a bug that was allowing share network update when it"},{"line_number":10,"context_line":"shouldn\u0027t, the test that validates the share network creation and"},{"line_number":11,"context_line":"update started failing. An additional validation was introduced in"},{"line_number":12,"context_line":"the fix for this bug, and this was this test failure cause. This"},{"line_number":13,"context_line":"patch fixes the test and make it work properly."},{"line_number":14,"context_line":"This patch fixes test classes that are raising a skip exception"},{"line_number":15,"context_line":"inside the setUpClass function and failing due to testtool issue #272."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_18e33907","line":12,"range":{"start_line":11,"start_character":24,"end_line":12,"end_character":59},"updated":"2019-10-28 22:19:21.000000000","message":"Suggest:\n\nAn additional validation was introduced and it caused the new bug.  This patch fixes the test to make it work properly.\n\nIn addition this patch fixes test classes that are raising a skip exception inside the setUpClass function ...","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"81065476433ca45707e209ec71c18a5878e94367","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After fixing a bug that was allowing share network update when it"},{"line_number":10,"context_line":"shouldn\u0027t, the test that validates the share network creation and"},{"line_number":11,"context_line":"update started failing. An additional validation was introduced in"},{"line_number":12,"context_line":"the fix for this bug, and this was this test failure cause. This"},{"line_number":13,"context_line":"patch fixes the test and make it work properly."},{"line_number":14,"context_line":"This patch fixes test classes that are raising a skip exception"},{"line_number":15,"context_line":"inside the setUpClass function and failing due to testtool issue #272."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_7ed25536","line":12,"range":{"start_line":11,"start_character":24,"end_line":12,"end_character":59},"in_reply_to":"3fa7e38b_18e33907","updated":"2019-10-29 01:53:35.000000000","message":"Thanks Tom, I\u0027ll take your suggestion in the next PS.","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"}],"manilaclient/tests/functional/base.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c7d3cdd59274fa3ffb72ca25231a203c5be83e0c","unresolved":false,"context_lines":[{"line_number":257,"context_line":"                             neutron_net_id\u003dNone,"},{"line_number":258,"context_line":"                             neutron_subnet_id\u003dNone,"},{"line_number":259,"context_line":"                             availability_zone\u003dNone, client\u003dNone,"},{"line_number":260,"context_line":"                             cleanup_in_class\u003dTrue, microversion\u003dNone):"},{"line_number":261,"context_line":"        if client is None:"},{"line_number":262,"context_line":"            client \u003d cls.get_admin_client()"},{"line_number":263,"context_line":"        share_network \u003d client.create_share_network("}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_1e154f3d","line":260,"range":{"start_line":260,"start_character":29,"end_line":260,"end_character":50},"updated":"2019-10-29 23:43:28.000000000","message":"this should be False as well, by default so we can cleanup right after a test case..","commit_id":"fd87d8b322a033ba6aeb4f6c2b03103091474a70"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"3feb254195ce86469fe6b32205232033478b4033","unresolved":false,"context_lines":[{"line_number":257,"context_line":"                             neutron_net_id\u003dNone,"},{"line_number":258,"context_line":"                             neutron_subnet_id\u003dNone,"},{"line_number":259,"context_line":"                             availability_zone\u003dNone, client\u003dNone,"},{"line_number":260,"context_line":"                             cleanup_in_class\u003dTrue, microversion\u003dNone):"},{"line_number":261,"context_line":"        if client is None:"},{"line_number":262,"context_line":"            client \u003d cls.get_admin_client()"},{"line_number":263,"context_line":"        share_network \u003d client.create_share_network("}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_1e278fc9","line":260,"range":{"start_line":260,"start_character":29,"end_line":260,"end_character":50},"in_reply_to":"3fa7e38b_1e154f3d","updated":"2019-10-30 01:53:19.000000000","message":"Yes, I miss this one. Thanks!","commit_id":"fd87d8b322a033ba6aeb4f6c2b03103091474a70"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c7d3cdd59274fa3ffb72ca25231a203c5be83e0c","unresolved":false,"context_lines":[{"line_number":284,"context_line":"    def add_share_network_subnet(cls, share_network,"},{"line_number":285,"context_line":"                                 neutron_net_id\u003dNone, neutron_subnet_id\u003dNone,"},{"line_number":286,"context_line":"                                 availability_zone\u003dNone, client\u003dNone,"},{"line_number":287,"context_line":"                                 cleanup_in_class\u003dTrue, microversion\u003dNone):"},{"line_number":288,"context_line":"        if client is None:"},{"line_number":289,"context_line":"            client \u003d cls.get_admin_client()"},{"line_number":290,"context_line":"        share_network_subnet \u003d client.add_share_network_subnet("}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_be275bb6","line":287,"range":{"start_line":287,"start_character":33,"end_line":287,"end_character":54},"updated":"2019-10-29 23:43:28.000000000","message":"same","commit_id":"fd87d8b322a033ba6aeb4f6c2b03103091474a70"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"3feb254195ce86469fe6b32205232033478b4033","unresolved":false,"context_lines":[{"line_number":284,"context_line":"    def add_share_network_subnet(cls, share_network,"},{"line_number":285,"context_line":"                                 neutron_net_id\u003dNone, neutron_subnet_id\u003dNone,"},{"line_number":286,"context_line":"                                 availability_zone\u003dNone, client\u003dNone,"},{"line_number":287,"context_line":"                                 cleanup_in_class\u003dTrue, microversion\u003dNone):"},{"line_number":288,"context_line":"        if client is None:"},{"line_number":289,"context_line":"            client \u003d cls.get_admin_client()"},{"line_number":290,"context_line":"        share_network_subnet \u003d client.add_share_network_subnet("}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_de1ed76e","line":287,"range":{"start_line":287,"start_character":33,"end_line":287,"end_character":54},"in_reply_to":"3fa7e38b_be275bb6","updated":"2019-10-30 01:53:19.000000000","message":"Thanks","commit_id":"fd87d8b322a033ba6aeb4f6c2b03103091474a70"}],"manilaclient/tests/functional/test_export_locations.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3649b9db2718174da52a987c786008b7c8dea177","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        super(ExportLocationReadWriteTest, self).setUp()"},{"line_number":27,"context_line":"        self.share \u003d self.create_share("},{"line_number":28,"context_line":"            client\u003dself.get_user_client(),"},{"line_number":29,"context_line":"            cleanup_in_class\u003dTrue)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @ddt.data(\u0027admin\u0027, \u0027user\u0027)"},{"line_number":32,"context_line":"    def test_list_share_export_locations(self, role):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_9b93a34f","line":29,"range":{"start_line":29,"start_character":12,"end_line":29,"end_character":34},"updated":"2019-10-28 23:48:56.000000000","message":"no point in relegating this to class cleanup, each test case in this class will now call this setUp() method when being initialized, and get its own share that can be deleted automatically at the end of the test case...","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"624966eb890195110b9243a19085055f0c02dccb","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        super(ExportLocationReadWriteTest, self).setUp()"},{"line_number":27,"context_line":"        self.share \u003d self.create_share("},{"line_number":28,"context_line":"            client\u003dself.get_user_client(),"},{"line_number":29,"context_line":"            cleanup_in_class\u003dTrue)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @ddt.data(\u0027admin\u0027, \u0027user\u0027)"},{"line_number":32,"context_line":"    def test_list_share_export_locations(self, role):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_e1fa28b8","line":29,"range":{"start_line":29,"start_character":12,"end_line":29,"end_character":34},"in_reply_to":"3fa7e38b_1e5c8149","updated":"2019-10-29 02:45:39.000000000","message":"Oh, do you have these resources left behind after the tests?","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"aff11cd78a7c5c339d2eb42c9ece1a48fd98284a","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        super(ExportLocationReadWriteTest, self).setUp()"},{"line_number":27,"context_line":"        self.share \u003d self.create_share("},{"line_number":28,"context_line":"            client\u003dself.get_user_client(),"},{"line_number":29,"context_line":"            cleanup_in_class\u003dTrue)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @ddt.data(\u0027admin\u0027, \u0027user\u0027)"},{"line_number":32,"context_line":"    def test_list_share_export_locations(self, role):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_ce7870c2","line":29,"range":{"start_line":29,"start_character":12,"end_line":29,"end_character":34},"in_reply_to":"3fa7e38b_9b93a34f","updated":"2019-10-29 18:11:33.000000000","message":"Done","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"81065476433ca45707e209ec71c18a5878e94367","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        super(ExportLocationReadWriteTest, self).setUp()"},{"line_number":27,"context_line":"        self.share \u003d self.create_share("},{"line_number":28,"context_line":"            client\u003dself.get_user_client(),"},{"line_number":29,"context_line":"            cleanup_in_class\u003dTrue)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @ddt.data(\u0027admin\u0027, \u0027user\u0027)"},{"line_number":32,"context_line":"    def test_list_share_export_locations(self, role):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_1e5c8149","line":29,"range":{"start_line":29,"start_character":12,"end_line":29,"end_character":34},"in_reply_to":"3fa7e38b_9b93a34f","updated":"2019-10-29 01:53:35.000000000","message":"You\u0027re right, make no sense let all resources to be released in the class cleanup, but after placing some logs on BaseTestCase.clear_resources, I saw that it\u0027s not being called to release method resources, even with the addCleanup in setUp[1]. Need to investigate this.\n\nNow, don\u0027t you think that its better to have these class resources being created on classSetUp() and move only the skip exceptions to setUp()? Avoiding lots of resources allocations and cleanups?\n\n[1] https://github.com/openstack/python-manilaclient/blob/e6e8cad240463a4a1d86f16013ab81df2db26b73/manilaclient/tests/functional/base.py#L64","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"89f2455835a70be6a7eed7bb4c5dc4dd342e0a6c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        super(ExportLocationReadWriteTest, self).setUp()"},{"line_number":27,"context_line":"        self.share \u003d self.create_share("},{"line_number":28,"context_line":"            client\u003dself.get_user_client(),"},{"line_number":29,"context_line":"            cleanup_in_class\u003dTrue)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @ddt.data(\u0027admin\u0027, \u0027user\u0027)"},{"line_number":32,"context_line":"    def test_list_share_export_locations(self, role):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_e1bd48b1","line":29,"range":{"start_line":29,"start_character":12,"end_line":29,"end_character":34},"in_reply_to":"3fa7e38b_e1fa28b8","updated":"2019-10-29 03:15:56.000000000","message":"Not actually, it might be just the test tool capturing my outputs.","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"}],"manilaclient/tests/functional/test_messages.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3649b9db2718174da52a987c786008b7c8dea177","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def setUp(self):"},{"line_number":35,"context_line":"        super(MessagesReadWriteTest, self).setUp()"},{"line_number":36,"context_line":"        self.message \u003d self.create_message(cleanup_in_class\u003dTrue)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def test_list_messages(self):"},{"line_number":39,"context_line":"        self.skip_if_microversion_not_supported(\u00272.37\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_1b9fb350","line":36,"range":{"start_line":36,"start_character":43,"end_line":36,"end_character":64},"updated":"2019-10-28 23:48:56.000000000","message":"same comment as earlier, inline setUpClass, setUp will be invoked at the beginning of every test case in the class. Resources created within the setUp method are unique to each test case and will not be available to other test cases; \n\nSo, no need to defer cleanup","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"aff11cd78a7c5c339d2eb42c9ece1a48fd98284a","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def setUp(self):"},{"line_number":35,"context_line":"        super(MessagesReadWriteTest, self).setUp()"},{"line_number":36,"context_line":"        self.message \u003d self.create_message(cleanup_in_class\u003dTrue)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def test_list_messages(self):"},{"line_number":39,"context_line":"        self.skip_if_microversion_not_supported(\u00272.37\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_6e4b7c86","line":36,"range":{"start_line":36,"start_character":43,"end_line":36,"end_character":64},"in_reply_to":"3fa7e38b_1b9fb350","updated":"2019-10-29 18:11:33.000000000","message":"Done","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"}],"manilaclient/tests/functional/test_share_access.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4b5af36bbd29a0a8389e1382d5a8b9165be1b9c1","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    access_level \u003d None"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @classmethod"},{"line_number":34,"context_line":"    def setUpClass(cls):"},{"line_number":35,"context_line":"        super(ShareAccessReadWriteBase, cls).setUpClass()"},{"line_number":36,"context_line":"        if cls.protocol not in CONF.enable_protocols:"},{"line_number":37,"context_line":"            message \u003d \"%s tests are disabled.\" % cls.protocol"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_372d0ca8","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":24},"updated":"2019-10-25 02:03:13.000000000","message":"This seems to be a problem; if we changed to using a instance builder : setUp(self) instead of setUpClass(cls), the workaround implemented by Ghanshyam would work...","commit_id":"3330dc96c0f2cde3e4ffbf31a8387d6f95dc7f7b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3649b9db2718174da52a987c786008b7c8dea177","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        self.share \u003d self.create_share(share_protocol\u003dself.protocol,"},{"line_number":52,"context_line":"                                       public\u003dTrue,"},{"line_number":53,"context_line":"                                       cleanup_in_class\u003dTrue)"},{"line_number":54,"context_line":"        self.share_id \u003d self.share[\u0027id\u0027]"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        # NOTE(vponomaryov): increase following int range when significant"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_bba77fa8","line":53,"range":{"start_line":53,"start_character":39,"end_line":53,"end_character":60},"updated":"2019-10-28 23:48:56.000000000","message":"remove, don\u0027t defer cleanup for instance resources.","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"aff11cd78a7c5c339d2eb42c9ece1a48fd98284a","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        self.share \u003d self.create_share(share_protocol\u003dself.protocol,"},{"line_number":52,"context_line":"                                       public\u003dTrue,"},{"line_number":53,"context_line":"                                       cleanup_in_class\u003dTrue)"},{"line_number":54,"context_line":"        self.share_id \u003d self.share[\u0027id\u0027]"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        # NOTE(vponomaryov): increase following int range when significant"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_2e410464","line":53,"range":{"start_line":53,"start_character":39,"end_line":53,"end_character":60},"in_reply_to":"3fa7e38b_bba77fa8","updated":"2019-10-29 18:11:33.000000000","message":"Done","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"}],"manilaclient/tests/functional/test_share_networks.py":[{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"1a9db57a819205afada589ff7c63ba6e0634cc73","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            self.assertEqual(self.neutron_subnet_id, get[\u0027neutron_subnet_id\u0027])"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def _get_expected_update_data(self, net_data, net_creation_data):"},{"line_number":128,"context_line":"        # NOTE(dviroel): When subnets are supported we need to convert the"},{"line_number":129,"context_line":"        # outputs from string to literal structures in order to process the"},{"line_number":130,"context_line":"        # content of \u0027share_network_subnets\u0027 field."},{"line_number":131,"context_line":"        default_return_value \u003d ("},{"line_number":132,"context_line":"            None if utils.share_network_subnets_are_supported() else \u0027None\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_ff0e3c30","line":129,"range":{"start_line":128,"start_character":25,"end_line":129,"end_character":51},"updated":"2019-10-29 12:42:58.000000000","message":"Since the code below is not doing the actual conversion, you could rephrase it to \"When subnets are supported, the outputs are converted from string to literal structures...\"","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"aff11cd78a7c5c339d2eb42c9ece1a48fd98284a","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            self.assertEqual(self.neutron_subnet_id, get[\u0027neutron_subnet_id\u0027])"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def _get_expected_update_data(self, net_data, net_creation_data):"},{"line_number":128,"context_line":"        # NOTE(dviroel): When subnets are supported we need to convert the"},{"line_number":129,"context_line":"        # outputs from string to literal structures in order to process the"},{"line_number":130,"context_line":"        # content of \u0027share_network_subnets\u0027 field."},{"line_number":131,"context_line":"        default_return_value \u003d ("},{"line_number":132,"context_line":"            None if utils.share_network_subnets_are_supported() else \u0027None\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_0e5c4849","line":129,"range":{"start_line":128,"start_character":25,"end_line":129,"end_character":51},"in_reply_to":"3fa7e38b_ff0e3c30","updated":"2019-10-29 18:11:33.000000000","message":"Done","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"}],"manilaclient/tests/functional/test_shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3649b9db2718174da52a987c786008b7c8dea177","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            name\u003dself.name,"},{"line_number":46,"context_line":"            description\u003dself.description,"},{"line_number":47,"context_line":"            client\u003dself.get_user_client(),"},{"line_number":48,"context_line":"            cleanup_in_class\u003dTrue)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_create_delete_share(self):"},{"line_number":51,"context_line":"        name \u003d data_utils.rand_name(\u0027autotest_share_name\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_fbcad74c","line":48,"range":{"start_line":48,"start_character":12,"end_line":48,"end_character":33},"updated":"2019-10-28 23:48:56.000000000","message":"remove, don\u0027t defer cleanup for instance resources.","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"aff11cd78a7c5c339d2eb42c9ece1a48fd98284a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            name\u003dself.name,"},{"line_number":46,"context_line":"            description\u003dself.description,"},{"line_number":47,"context_line":"            client\u003dself.get_user_client(),"},{"line_number":48,"context_line":"            cleanup_in_class\u003dTrue)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_create_delete_share(self):"},{"line_number":51,"context_line":"        name \u003d data_utils.rand_name(\u0027autotest_share_name\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_ce515032","line":48,"range":{"start_line":48,"start_character":12,"end_line":48,"end_character":33},"in_reply_to":"3fa7e38b_fbcad74c","updated":"2019-10-29 18:11:33.000000000","message":"Done","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"}],"manilaclient/tests/functional/test_shares_listing.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3649b9db2718174da52a987c786008b7c8dea177","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            name\u003dself.admin_private_name,"},{"line_number":131,"context_line":"            description\u003dself.admin_private_description,"},{"line_number":132,"context_line":"            public\u003dFalse,"},{"line_number":133,"context_line":"            cleanup_in_class\u003dTrue,"},{"line_number":134,"context_line":"            client\u003dNone,"},{"line_number":135,"context_line":"            wait_for_creation\u003dFalse)"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_bbc0df2c","line":133,"range":{"start_line":133,"start_character":12,"end_line":133,"end_character":33},"updated":"2019-10-28 23:48:56.000000000","message":"remove, don\u0027t defer cleanup for instance resources.","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"aff11cd78a7c5c339d2eb42c9ece1a48fd98284a","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            name\u003dself.admin_private_name,"},{"line_number":131,"context_line":"            description\u003dself.admin_private_description,"},{"line_number":132,"context_line":"            public\u003dFalse,"},{"line_number":133,"context_line":"            cleanup_in_class\u003dTrue,"},{"line_number":134,"context_line":"            client\u003dNone,"},{"line_number":135,"context_line":"            wait_for_creation\u003dFalse)"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_6e305c08","line":133,"range":{"start_line":133,"start_character":12,"end_line":133,"end_character":33},"in_reply_to":"3fa7e38b_bbc0df2c","updated":"2019-10-29 18:11:33.000000000","message":"Done","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3649b9db2718174da52a987c786008b7c8dea177","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            name\u003dself.private_name,"},{"line_number":139,"context_line":"            description\u003dself.private_description,"},{"line_number":140,"context_line":"            public\u003dFalse,"},{"line_number":141,"context_line":"            cleanup_in_class\u003dTrue,"},{"line_number":142,"context_line":"            client\u003dself.get_user_client(),"},{"line_number":143,"context_line":"            wait_for_creation\u003dFalse)"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_dbbd9bb1","line":141,"range":{"start_line":141,"start_character":12,"end_line":141,"end_character":33},"updated":"2019-10-28 23:48:56.000000000","message":"remove, don\u0027t defer cleanup for instance resources.","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"aff11cd78a7c5c339d2eb42c9ece1a48fd98284a","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            name\u003dself.private_name,"},{"line_number":139,"context_line":"            description\u003dself.private_description,"},{"line_number":140,"context_line":"            public\u003dFalse,"},{"line_number":141,"context_line":"            cleanup_in_class\u003dTrue,"},{"line_number":142,"context_line":"            client\u003dself.get_user_client(),"},{"line_number":143,"context_line":"            wait_for_creation\u003dFalse)"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_8e3598f9","line":141,"range":{"start_line":141,"start_character":12,"end_line":141,"end_character":33},"in_reply_to":"3fa7e38b_dbbd9bb1","updated":"2019-10-29 18:11:33.000000000","message":"Done","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3649b9db2718174da52a987c786008b7c8dea177","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            description\u003dself.public_description,"},{"line_number":148,"context_line":"            public\u003dTrue,"},{"line_number":149,"context_line":"            client\u003dself.get_user_client(),"},{"line_number":150,"context_line":"            cleanup_in_class\u003dTrue)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        for share_id in (self.private_share[\u0027id\u0027], self.public_share[\u0027id\u0027],"},{"line_number":153,"context_line":"                         self.admin_private_share[\u0027id\u0027]):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_9be163d3","line":150,"range":{"start_line":150,"start_character":12,"end_line":150,"end_character":33},"updated":"2019-10-28 23:48:56.000000000","message":"remove, don\u0027t defer cleanup for instance resources.","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"aff11cd78a7c5c339d2eb42c9ece1a48fd98284a","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            description\u003dself.public_description,"},{"line_number":148,"context_line":"            public\u003dTrue,"},{"line_number":149,"context_line":"            client\u003dself.get_user_client(),"},{"line_number":150,"context_line":"            cleanup_in_class\u003dTrue)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        for share_id in (self.private_share[\u0027id\u0027], self.public_share[\u0027id\u0027],"},{"line_number":153,"context_line":"                         self.admin_private_share[\u0027id\u0027]):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_4e3b20e9","line":150,"range":{"start_line":150,"start_character":12,"end_line":150,"end_character":33},"in_reply_to":"3fa7e38b_9be163d3","updated":"2019-10-29 18:11:33.000000000","message":"Done","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3649b9db2718174da52a987c786008b7c8dea177","unresolved":false,"context_lines":[{"line_number":319,"context_line":"            description\u003du\u0027共享描述\u0027,"},{"line_number":320,"context_line":"            public\u003dTrue,"},{"line_number":321,"context_line":"            client\u003dself.get_user_client(),"},{"line_number":322,"context_line":"            cleanup_in_class\u003dTrue)"},{"line_number":323,"context_line":"        filters \u003d {\u0027name~\u0027: u\u0027名称\u0027}"},{"line_number":324,"context_line":"        shares \u003d self.user_client.list_shares(filters\u003dfilters)"},{"line_number":325,"context_line":"        self.assertGreater(len(shares), 0)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_fbcf3754","line":322,"range":{"start_line":322,"start_character":12,"end_line":322,"end_character":33},"updated":"2019-10-28 23:48:56.000000000","message":"Can you please fix this as well?","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"aff11cd78a7c5c339d2eb42c9ece1a48fd98284a","unresolved":false,"context_lines":[{"line_number":319,"context_line":"            description\u003du\u0027共享描述\u0027,"},{"line_number":320,"context_line":"            public\u003dTrue,"},{"line_number":321,"context_line":"            client\u003dself.get_user_client(),"},{"line_number":322,"context_line":"            cleanup_in_class\u003dTrue)"},{"line_number":323,"context_line":"        filters \u003d {\u0027name~\u0027: u\u0027名称\u0027}"},{"line_number":324,"context_line":"        shares \u003d self.user_client.list_shares(filters\u003dfilters)"},{"line_number":325,"context_line":"        self.assertGreater(len(shares), 0)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_ee23ecbc","line":322,"range":{"start_line":322,"start_character":12,"end_line":322,"end_character":33},"in_reply_to":"3fa7e38b_fbcf3754","updated":"2019-10-29 18:11:33.000000000","message":"Done","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"}],"manilaclient/tests/functional/test_shares_metadata.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3649b9db2718174da52a987c786008b7c8dea177","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        super(SharesMetadataReadWriteTest, self).setUp()"},{"line_number":26,"context_line":"        self.share \u003d self.create_share("},{"line_number":27,"context_line":"            client\u003dself.get_user_client(),"},{"line_number":28,"context_line":"            cleanup_in_class\u003dTrue)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def test_set_metadata_in_share_creation(self):"},{"line_number":31,"context_line":"        md \u003d {\"key1\": \"value1\", \"key2\": \"value2\"}"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_3bfb8f7b","line":28,"range":{"start_line":28,"start_character":12,"end_line":28,"end_character":33},"updated":"2019-10-28 23:48:56.000000000","message":"remove, don\u0027t defer cleanup for instance resources.","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"aff11cd78a7c5c339d2eb42c9ece1a48fd98284a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        super(SharesMetadataReadWriteTest, self).setUp()"},{"line_number":26,"context_line":"        self.share \u003d self.create_share("},{"line_number":27,"context_line":"            client\u003dself.get_user_client(),"},{"line_number":28,"context_line":"            cleanup_in_class\u003dTrue)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def test_set_metadata_in_share_creation(self):"},{"line_number":31,"context_line":"        md \u003d {\"key1\": \"value1\", \"key2\": \"value2\"}"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_6e193c86","line":28,"range":{"start_line":28,"start_character":12,"end_line":28,"end_character":33},"in_reply_to":"3fa7e38b_3bfb8f7b","updated":"2019-10-29 18:11:33.000000000","message":"Done","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"}],"manilaclient/tests/functional/test_snapshot_access.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3649b9db2718174da52a987c786008b7c8dea177","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        self.share \u003d self.create_share(share_protocol\u003dself.protocol,"},{"line_number":41,"context_line":"                                       public\u003dTrue,"},{"line_number":42,"context_line":"                                       cleanup_in_class\u003dTrue,"},{"line_number":43,"context_line":"                                       client\u003dself.get_user_client())"},{"line_number":44,"context_line":"        int_range \u003d range(0, 10)"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_fbf8977c","line":42,"range":{"start_line":42,"start_character":39,"end_line":42,"end_character":61},"updated":"2019-10-28 23:48:56.000000000","message":"remove, don\u0027t defer cleanup for instance resources.","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"aff11cd78a7c5c339d2eb42c9ece1a48fd98284a","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        self.share \u003d self.create_share(share_protocol\u003dself.protocol,"},{"line_number":41,"context_line":"                                       public\u003dTrue,"},{"line_number":42,"context_line":"                                       cleanup_in_class\u003dTrue,"},{"line_number":43,"context_line":"                                       client\u003dself.get_user_client())"},{"line_number":44,"context_line":"        int_range \u003d range(0, 10)"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_8e1ef86d","line":42,"range":{"start_line":42,"start_character":39,"end_line":42,"end_character":61},"in_reply_to":"3fa7e38b_fbf8977c","updated":"2019-10-29 18:11:33.000000000","message":"Done","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"}],"manilaclient/tests/functional/test_snapshot_instances.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3649b9db2718174da52a987c786008b7c8dea177","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        super(SnapshotInstancesTest, self).setUp()"},{"line_number":35,"context_line":"        self.share \u003d self.create_share("},{"line_number":36,"context_line":"            client\u003dself.get_user_client(),"},{"line_number":37,"context_line":"            cleanup_in_class\u003dTrue)"},{"line_number":38,"context_line":"        self.snapshot \u003d self.create_snapshot(share\u003dself.share[\u0027id\u0027],"},{"line_number":39,"context_line":"                                             client\u003dself.get_user_client(),"},{"line_number":40,"context_line":"                                             cleanup_in_class\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_dbeb5ba1","line":37,"range":{"start_line":37,"start_character":12,"end_line":37,"end_character":33},"updated":"2019-10-28 23:48:56.000000000","message":"remove, don\u0027t defer cleanup for instance resources.","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"aff11cd78a7c5c339d2eb42c9ece1a48fd98284a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        super(SnapshotInstancesTest, self).setUp()"},{"line_number":35,"context_line":"        self.share \u003d self.create_share("},{"line_number":36,"context_line":"            client\u003dself.get_user_client(),"},{"line_number":37,"context_line":"            cleanup_in_class\u003dTrue)"},{"line_number":38,"context_line":"        self.snapshot \u003d self.create_snapshot(share\u003dself.share[\u0027id\u0027],"},{"line_number":39,"context_line":"                                             client\u003dself.get_user_client(),"},{"line_number":40,"context_line":"                                             cleanup_in_class\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_2e0fc439","line":37,"range":{"start_line":37,"start_character":12,"end_line":37,"end_character":33},"in_reply_to":"3fa7e38b_dbeb5ba1","updated":"2019-10-29 18:11:33.000000000","message":"Done","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3649b9db2718174da52a987c786008b7c8dea177","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            cleanup_in_class\u003dTrue)"},{"line_number":38,"context_line":"        self.snapshot \u003d self.create_snapshot(share\u003dself.share[\u0027id\u0027],"},{"line_number":39,"context_line":"                                             client\u003dself.get_user_client(),"},{"line_number":40,"context_line":"                                             cleanup_in_class\u003dTrue)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def test_list_all_snapshot_instances(self):"},{"line_number":43,"context_line":"        snapshot_instances \u003d self.admin_client.list_snapshot_instances()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_bbee9fb2","line":40,"range":{"start_line":40,"start_character":45,"end_line":40,"end_character":66},"updated":"2019-10-28 23:48:56.000000000","message":"remove, don\u0027t defer cleanup for instance resources.","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"aff11cd78a7c5c339d2eb42c9ece1a48fd98284a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            cleanup_in_class\u003dTrue)"},{"line_number":38,"context_line":"        self.snapshot \u003d self.create_snapshot(share\u003dself.share[\u0027id\u0027],"},{"line_number":39,"context_line":"                                             client\u003dself.get_user_client(),"},{"line_number":40,"context_line":"                                             cleanup_in_class\u003dTrue)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def test_list_all_snapshot_instances(self):"},{"line_number":43,"context_line":"        snapshot_instances \u003d self.admin_client.list_snapshot_instances()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_4e14804d","line":40,"range":{"start_line":40,"start_character":45,"end_line":40,"end_character":66},"in_reply_to":"3fa7e38b_bbee9fb2","updated":"2019-10-29 18:11:33.000000000","message":"Done","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"}],"manilaclient/tests/functional/test_snapshot_instances_export_locations.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3649b9db2718174da52a987c786008b7c8dea177","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        super(SnapshotInstanceExportLocationReadWriteTest, self).setUp()"},{"line_number":36,"context_line":"        self.share \u003d self.create_share("},{"line_number":37,"context_line":"            client\u003dself.get_user_client(),"},{"line_number":38,"context_line":"            cleanup_in_class\u003dTrue)"},{"line_number":39,"context_line":"        self.snapshot \u003d self.create_snapshot(share\u003dself.share[\u0027id\u0027],"},{"line_number":40,"context_line":"                                             client\u003dself.get_user_client(),"},{"line_number":41,"context_line":"                                             cleanup_in_class\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_7b2a67e7","line":38,"range":{"start_line":38,"start_character":12,"end_line":38,"end_character":33},"updated":"2019-10-28 23:48:56.000000000","message":"remove, don\u0027t defer cleanup for instance resources.","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"aff11cd78a7c5c339d2eb42c9ece1a48fd98284a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        super(SnapshotInstanceExportLocationReadWriteTest, self).setUp()"},{"line_number":36,"context_line":"        self.share \u003d self.create_share("},{"line_number":37,"context_line":"            client\u003dself.get_user_client(),"},{"line_number":38,"context_line":"            cleanup_in_class\u003dTrue)"},{"line_number":39,"context_line":"        self.snapshot \u003d self.create_snapshot(share\u003dself.share[\u0027id\u0027],"},{"line_number":40,"context_line":"                                             client\u003dself.get_user_client(),"},{"line_number":41,"context_line":"                                             cleanup_in_class\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_ae02d40a","line":38,"range":{"start_line":38,"start_character":12,"end_line":38,"end_character":33},"in_reply_to":"3fa7e38b_7b2a67e7","updated":"2019-10-29 18:11:33.000000000","message":"Done","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3649b9db2718174da52a987c786008b7c8dea177","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            cleanup_in_class\u003dTrue)"},{"line_number":39,"context_line":"        self.snapshot \u003d self.create_snapshot(share\u003dself.share[\u0027id\u0027],"},{"line_number":40,"context_line":"                                             client\u003dself.get_user_client(),"},{"line_number":41,"context_line":"                                             cleanup_in_class\u003dTrue)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def test_get_snapshot_instance_export_location(self):"},{"line_number":44,"context_line":"        client \u003d self.admin_client"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_3b306f55","line":41,"range":{"start_line":41,"start_character":45,"end_line":41,"end_character":65},"updated":"2019-10-28 23:48:56.000000000","message":"remove, don\u0027t defer cleanup for instance resources.","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"aff11cd78a7c5c339d2eb42c9ece1a48fd98284a","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            cleanup_in_class\u003dTrue)"},{"line_number":39,"context_line":"        self.snapshot \u003d self.create_snapshot(share\u003dself.share[\u0027id\u0027],"},{"line_number":40,"context_line":"                                             client\u003dself.get_user_client(),"},{"line_number":41,"context_line":"                                             cleanup_in_class\u003dTrue)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def test_get_snapshot_instance_export_location(self):"},{"line_number":44,"context_line":"        client \u003d self.admin_client"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_ceff1000","line":41,"range":{"start_line":41,"start_character":45,"end_line":41,"end_character":65},"in_reply_to":"3fa7e38b_3b306f55","updated":"2019-10-29 18:11:33.000000000","message":"Done","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"}],"manilaclient/tests/functional/test_snapshots_export_locations.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3649b9db2718174da52a987c786008b7c8dea177","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        super(SnapshotExportLocationReadWriteTest, self).setUp()"},{"line_number":36,"context_line":"        self.share \u003d self.create_share("},{"line_number":37,"context_line":"            client\u003dself.get_user_client(),"},{"line_number":38,"context_line":"            cleanup_in_class\u003dTrue)"},{"line_number":39,"context_line":"        self.snapshot \u003d self.create_snapshot(share\u003dself.share[\u0027id\u0027],"},{"line_number":40,"context_line":"                                             client\u003dself.get_user_client(),"},{"line_number":41,"context_line":"                                             cleanup_in_class\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_fb3df72b","line":38,"range":{"start_line":38,"start_character":12,"end_line":38,"end_character":33},"updated":"2019-10-28 23:48:56.000000000","message":"remove, don\u0027t defer cleanup for instance resources.","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"aff11cd78a7c5c339d2eb42c9ece1a48fd98284a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        super(SnapshotExportLocationReadWriteTest, self).setUp()"},{"line_number":36,"context_line":"        self.share \u003d self.create_share("},{"line_number":37,"context_line":"            client\u003dself.get_user_client(),"},{"line_number":38,"context_line":"            cleanup_in_class\u003dTrue)"},{"line_number":39,"context_line":"        self.snapshot \u003d self.create_snapshot(share\u003dself.share[\u0027id\u0027],"},{"line_number":40,"context_line":"                                             client\u003dself.get_user_client(),"},{"line_number":41,"context_line":"                                             cleanup_in_class\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_8903520d","line":38,"range":{"start_line":38,"start_character":12,"end_line":38,"end_character":33},"in_reply_to":"3fa7e38b_fb3df72b","updated":"2019-10-29 18:11:33.000000000","message":"Done","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3649b9db2718174da52a987c786008b7c8dea177","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            cleanup_in_class\u003dTrue)"},{"line_number":39,"context_line":"        self.snapshot \u003d self.create_snapshot(share\u003dself.share[\u0027id\u0027],"},{"line_number":40,"context_line":"                                             client\u003dself.get_user_client(),"},{"line_number":41,"context_line":"                                             cleanup_in_class\u003dTrue)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @ddt.data(\u0027admin\u0027, \u0027user\u0027)"},{"line_number":44,"context_line":"    def test_get_snapshot_export_location(self, role):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_1b3b3338","line":41,"range":{"start_line":41,"start_character":45,"end_line":41,"end_character":66},"updated":"2019-10-28 23:48:56.000000000","message":"remove, don\u0027t defer cleanup for instance resources.","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"aff11cd78a7c5c339d2eb42c9ece1a48fd98284a","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            cleanup_in_class\u003dTrue)"},{"line_number":39,"context_line":"        self.snapshot \u003d self.create_snapshot(share\u003dself.share[\u0027id\u0027],"},{"line_number":40,"context_line":"                                             client\u003dself.get_user_client(),"},{"line_number":41,"context_line":"                                             cleanup_in_class\u003dTrue)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @ddt.data(\u0027admin\u0027, \u0027user\u0027)"},{"line_number":44,"context_line":"    def test_get_snapshot_export_location(self, role):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_29049e13","line":41,"range":{"start_line":41,"start_character":45,"end_line":41,"end_character":66},"in_reply_to":"3fa7e38b_1b3b3338","updated":"2019-10-29 18:11:33.000000000","message":"Done","commit_id":"011e86c19f565d5257e02b339956ac27b35f4205"}]}