)]}'
{"manilaclient/osc/utils.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0d67aa4c7b30de2cd6837a5c5682f0b448655d7b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from manilaclient import exceptions"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"BOOL_SPECS \u003d ("},{"line_number":21,"context_line":"    \u0027snapshot_support\u0027,"},{"line_number":22,"context_line":"    \u0027create_share_from_snapshot_support\u0027,"},{"line_number":23,"context_line":"    \u0027revert_to_snapshot_support\u0027,"},{"line_number":24,"context_line":"    \u0027mount_snapshot_support\u0027"},{"line_number":25,"context_line":")"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def extract_key_value_options(pairs):"}],"source_content_type":"text/x-python","patch_set":16,"id":"1fa4df85_8edd0316","line":25,"range":{"start_line":20,"start_character":0,"end_line":25,"end_character":1},"updated":"2020-02-27 00:33:04.000000000","message":"This is being declared in this file and in [1] as well. What do you think about adding this value to our constants file so you can reuse them?\nAlso, the values contained in BOOL_SPECS, could be constants as well, so they could be reused anywhere else in the code.\n[1] https://review.opendev.org/#/c/701229/16/manilaclient/osc/v2/share_types.py@38","commit_id":"03371846731ea2ca4546533fd52ef139fade1101"}],"manilaclient/osc/v2/share_type_access.py":[{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"9d2023962401cc94cd5fb868586fb36cea39f453","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2019 Red Hat, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#   not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_7f983a66","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":16},"updated":"2020-01-20 19:09:03.000000000","message":"happy 2020!","commit_id":"2acfed268f4795a0189deeb40a3ee94061350cee"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"78a9c8d0322f89fd95de85b7266cabf100ea1a03","unresolved":false,"context_lines":[{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class CreateShareTypeAccess(command.Command):"},{"line_number":28,"context_line":"    \"\"\"Add access for share type.\"\"\""},{"line_number":29,"context_line":"    _description \u003d _(\"Add access for share type\")"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_077cd820","line":27,"updated":"2020-01-30 03:15:55.000000000","message":"Suggest to change to share-type access allow","commit_id":"aedb8e81ad8192aed82941aef3f8b6db3a66a367"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"78a9c8d0322f89fd95de85b7266cabf100ea1a03","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        return (columns, values)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"class DeleteShareTypeAccess(command.Command):"},{"line_number":92,"context_line":"    \"\"\"Delete access from share type.\"\"\""},{"line_number":93,"context_line":"    _description \u003d _(\"Delete access from share type\")"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_2781d4fb","line":91,"updated":"2020-01-30 03:15:55.000000000","message":"Suggest to change to share type access deny","commit_id":"aedb8e81ad8192aed82941aef3f8b6db3a66a367"}],"manilaclient/osc/v2/share_types.py":[{"author":{"_account_id":5575,"name":"Jose Castro Leon","email":"jose.castro.leon@cern.ch","username":"jose-castro-leon"},"change_message_id":"2f2107dd0a3de2998bdd1a088474efe2b4b14adb","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                kwargs[\u0027is_public\u0027] \u003d True"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        if parsed_args.spec_driver_handles_share_servers is not None:"},{"line_number":162,"context_line":"            share_type \u003d share_client.share_types.create("},{"line_number":163,"context_line":"                spec_driver_handles_share_servers\u003dparsed_args"},{"line_number":164,"context_line":"                .spec_driver_handles_share_servers,"},{"line_number":165,"context_line":"                **kwargs"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_1958c654","line":162,"updated":"2020-01-10 15:58:44.000000000","message":"Nice job, just a small comment,\n\nIn the manila cli, there is a validation on some arguments even before sending the request, are we missing those?\n\nI am talking about this particular fragment\nhttps://github.com/openstack/python-manilaclient/blob/master/manilaclient/v2/shell.py#L4238-L4256","commit_id":"7a3495a7fd1af0c762a842324fa4d5f33aee68e9"},{"author":{"_account_id":5575,"name":"Jose Castro Leon","email":"jose.castro.leon@cern.ch","username":"jose-castro-leon"},"change_message_id":"2f2107dd0a3de2998bdd1a088474efe2b4b14adb","unresolved":false,"context_lines":[{"line_number":274,"context_line":"                kwargs[\u0027is_public\u0027] \u003d True"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"        if kwargs is not {}:"},{"line_number":277,"context_line":"            share_type.update(**kwargs)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        if parsed_args.extra_spec:"},{"line_number":280,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_59371efe","line":277,"updated":"2020-01-10 15:58:44.000000000","message":"If we are missing those checks, we need to add them here too.","commit_id":"7a3495a7fd1af0c762a842324fa4d5f33aee68e9"},{"author":{"_account_id":5575,"name":"Jose Castro Leon","email":"jose.castro.leon@cern.ch","username":"jose-castro-leon"},"change_message_id":"9c9579de8c17b0e6e538b26ec536a0ab4a0c1280","unresolved":false,"context_lines":[{"line_number":191,"context_line":"                   \"positional argument.\")"},{"line_number":192,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        # TODO(maaritamm) do we need to validate API version here?"},{"line_number":195,"context_line":"        # description is available for 2.41 and up"},{"line_number":196,"context_line":"        if parsed_args.description:"},{"line_number":197,"context_line":"            kwargs[\u0027description\u0027] \u003d parsed_args.description"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_748c22d8","line":194,"updated":"2020-01-15 13:31:16.000000000","message":"What about adding into the description that searching by extra_specs is only available on a specific microversion?","commit_id":"c882ca612e7717b1f95c344cf1707ce724dc09c1"},{"author":{"_account_id":5575,"name":"Jose Castro Leon","email":"jose.castro.leon@cern.ch","username":"jose-castro-leon"},"change_message_id":"9c9579de8c17b0e6e538b26ec536a0ab4a0c1280","unresolved":false,"context_lines":[{"line_number":413,"context_line":"    def take_action(self, parsed_args):"},{"line_number":414,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"        # TODO(maaritamm) do we need to validate API version here?"},{"line_number":417,"context_line":"        # sorting by extra specs is available for 2.43 and up"},{"line_number":418,"context_line":"        search_opts \u003d {}"},{"line_number":419,"context_line":"        if parsed_args.extra_specs:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_b4829aa5","line":416,"updated":"2020-01-15 13:31:16.000000000","message":"Same comment as above","commit_id":"c882ca612e7717b1f95c344cf1707ce724dc09c1"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"592839f920a96e855be35daa23b4c94a13d3ce9c","unresolved":false,"context_lines":[{"line_number":465,"context_line":"            columns \u003d ATTRIBUTES"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"        formatted_types \u003d []"},{"line_number":468,"context_line":"        for share_type in share_types:"},{"line_number":469,"context_line":"            formatted_types.append(format_share_type(share_type))"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        values \u003d (oscutils.get_dict_properties("}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_02820d52","line":468,"updated":"2020-01-21 14:35:37.000000000","message":"`share_types` remains unassinged with API microversion \u003c 2.43:\n\n    $ openstack --os-share-api-version 2.42 share type list\n    local variable \u0027share_types\u0027 referenced before assignment","commit_id":"d5f9594a58dfc87430c76c74da92af61a0c1ba39"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"78a9c8d0322f89fd95de85b7266cabf100ea1a03","unresolved":false,"context_lines":[{"line_number":44,"context_line":")"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def format_properties(properties):"},{"line_number":48,"context_line":"    formatted_data \u003d []"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    for item in properties:"}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_c7dec03c","line":47,"updated":"2020-01-30 03:15:55.000000000","message":"We could move this up to manilaclient.osc.utils so we can reuse it for other commands","commit_id":"aedb8e81ad8192aed82941aef3f8b6db3a66a367"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"78a9c8d0322f89fd95de85b7266cabf100ea1a03","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    return \"\\n\".join(formatted_data)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"def format_share_type(share_type):"},{"line_number":56,"context_line":"    # share_type_access:is_public (true/false) --\u003e visibility (public/private)"},{"line_number":57,"context_line":"    is_public \u003d \u0027share_type_access:is_public\u0027"},{"line_number":58,"context_line":"    visibility \u003d \u0027public\u0027 if share_type._info.get(is_public) else \u0027private\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_07ae18a1","line":55,"updated":"2020-01-30 03:15:55.000000000","message":"This seems to be very specific to share_type, so it\u0027s ok for it to live here","commit_id":"aedb8e81ad8192aed82941aef3f8b6db3a66a367"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"78a9c8d0322f89fd95de85b7266cabf100ea1a03","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    return share_type"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"def extract_extra_specs(extra_specs, specs_to_add):"},{"line_number":80,"context_line":"    for item in specs_to_add:"},{"line_number":81,"context_line":"        (key, value) \u003d item.split(\u0027\u003d\u0027, 1)"},{"line_number":82,"context_line":"        if key in extra_specs:"}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_e7c41c64","line":79,"updated":"2020-01-30 03:15:55.000000000","message":"This one could be moved to manila.osc.utils, perhaps other commands can use this util too","commit_id":"aedb8e81ad8192aed82941aef3f8b6db3a66a367"}],"manilaclient/tests/osc/unit/v2/fakes.py":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"78a9c8d0322f89fd95de85b7266cabf100ea1a03","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        self.share_types \u003d mock.Mock()"},{"line_number":34,"context_line":"        self.share_type_access \u003d mock.Mock()"},{"line_number":35,"context_line":"        self.shares.resource_class \u003d osc_fakes.FakeResource(None, {})"},{"line_number":36,"context_line":"        self.api_version \u003d api_versions.APIVersion(\u00272.51\u0027)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class ManilaParseException(Exception):"}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_ea970337","line":36,"updated":"2020-01-30 03:15:55.000000000","message":"I\u0027m have some doubts about this... I understand you need the APIVersion to check whether some commands are available or not, but maybe we can add it specifically to the tests so we avoid hardwiring the APIVersion for all tests","commit_id":"aedb8e81ad8192aed82941aef3f8b6db3a66a367"}]}