)]}'
{"manilaclient/osc/v2/share_access_rules.py":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"56e551360d60a82a2a3e3ea41423d25d1c1d54e8","unresolved":false,"context_lines":[{"line_number":39,"context_line":"]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def format_properties(properties):"},{"line_number":43,"context_line":"    formatted_data \u003d []"},{"line_number":44,"context_line":"    for item in properties:"},{"line_number":45,"context_line":"        formatted_data.append(\"%s : %s\" % (item, properties[item]))"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_5eecdc90","line":42,"updated":"2020-01-29 22:40:12.000000000","message":"Move this to manilaclient.osc.utils. Then we can reuse this for other commands.","commit_id":"07f675efcaab336b28dc7077b2b89dc6804bcf17"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"56e551360d60a82a2a3e3ea41423d25d1c1d54e8","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    return \"\\n\".join(formatted_data)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def extract_properties(properties):"},{"line_number":50,"context_line":"    result_dict \u003d {}"},{"line_number":51,"context_line":"    for item in properties:"},{"line_number":52,"context_line":"        (key, value) \u003d item.split(\u0027\u003d\u0027, 1)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_3ee560a3","line":49,"updated":"2020-01-29 22:40:12.000000000","message":"Ditto","commit_id":"07f675efcaab336b28dc7077b2b89dc6804bcf17"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"56e551360d60a82a2a3e3ea41423d25d1c1d54e8","unresolved":false,"context_lines":[{"line_number":49,"context_line":"def extract_properties(properties):"},{"line_number":50,"context_line":"    result_dict \u003d {}"},{"line_number":51,"context_line":"    for item in properties:"},{"line_number":52,"context_line":"        (key, value) \u003d item.split(\u0027\u003d\u0027, 1)"},{"line_number":53,"context_line":"        if key in result_dict:"},{"line_number":54,"context_line":"            raise exceptions.CommandError("},{"line_number":55,"context_line":"                \"Argument \u0027%s\u0027 is specified twice.\" % key)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_a486225f","line":52,"updated":"2020-01-29 22:40:12.000000000","message":"I think we would need a try except here for ValueError (not enough values to unpack). If someone misses passing the right format (k\u003dv) and put k v you would get something like \"not enough values to unpack (expected 2, got 1)\". We would need to catch that and put some help like \"Parsing error, expected the k\u003dv format\".","commit_id":"07f675efcaab336b28dc7077b2b89dc6804bcf17"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"56e551360d60a82a2a3e3ea41423d25d1c1d54e8","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    return result_dict"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"class CreateShareAccess(command.ShowOne):"},{"line_number":62,"context_line":"    \"\"\"Create a new share access rule.\"\"\""},{"line_number":63,"context_line":"    _description \u003d _(\"Create new share access rule\")"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_3ecc8031","line":61,"updated":"2020-01-29 22:40:12.000000000","message":"I\u0027m aware that in the spec we call this command \"access create\" but IMHO it should be access allow. Could you rename it?","commit_id":"07f675efcaab336b28dc7077b2b89dc6804bcf17"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"56e551360d60a82a2a3e3ea41423d25d1c1d54e8","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        parser.add_argument("},{"line_number":75,"context_line":"            \u0027access_type\u0027,"},{"line_number":76,"context_line":"            metavar\u003d\"\u003caccess_type\u003e\","},{"line_number":77,"context_line":"            help\u003d_(\u0027Access rule type (only \"ip\", \"user\"(user or group), \u0027"},{"line_number":78,"context_line":"                   \u0027\"cert\" or \"cephx\" are supported).\u0027)"},{"line_number":79,"context_line":"        )"},{"line_number":80,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_7e9438e7","line":77,"updated":"2020-01-29 22:40:12.000000000","message":"NIT. Add space between \"user\" and (user or group). \"user\" (user or group)","commit_id":"07f675efcaab336b28dc7077b2b89dc6804bcf17"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"56e551360d60a82a2a3e3ea41423d25d1c1d54e8","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            type\u003dstr,"},{"line_number":89,"context_line":"            nargs\u003d\u0027*\u0027,"},{"line_number":90,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":91,"context_line":"            help\u003d_(\u0027Space Separated list of key\u003dvalue pairs of properties. \u0027"},{"line_number":92,"context_line":"                   \u0027OPTIONAL: Default\u003dNone. \u0027"},{"line_number":93,"context_line":"                   \u0027Available only for API microversion \u003e\u003d 2.45.\u0027),"},{"line_number":94,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_fe7fc8b8","line":91,"updated":"2020-01-29 22:40:12.000000000","message":"NIT. separated should be lowercase","commit_id":"07f675efcaab336b28dc7077b2b89dc6804bcf17"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"56e551360d60a82a2a3e3ea41423d25d1c1d54e8","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                \"\u0027%s\u0027: %s\" % (share, e))"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"class DeleteShareAccess(command.Command):"},{"line_number":142,"context_line":"    \"\"\"Delete a share access rule.\"\"\""},{"line_number":143,"context_line":"    _description \u003d _(\"Delete a share access rule\")"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_fed108cb","line":141,"updated":"2020-01-29 22:40:12.000000000","message":"Same here. Instead of access delete it should be access deny.","commit_id":"07f675efcaab336b28dc7077b2b89dc6804bcf17"}],"manilaclient/tests/osc/unit/v2/fakes.py":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"ea46a73eb82817e6aec6c946378050f238d885d7","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        self.shares \u003d mock.Mock()"},{"line_number":34,"context_line":"        self.share_access_rules \u003d mock.Mock()"},{"line_number":35,"context_line":"        self.shares.resource_class \u003d osc_fakes.FakeResource(None, {})"},{"line_number":36,"context_line":"        self.api_version \u003d api_versions.APIVersion(\u00272.51\u0027)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class ManilaParseException(Exception):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_4ab097e0","line":36,"updated":"2020-01-30 03:20:03.000000000","message":"Same comment about the API version as in the share types patch, need to think about this a bit more :)","commit_id":"07f675efcaab336b28dc7077b2b89dc6804bcf17"}]}