)]}'
{"manilaclient/tests/functional/osc/base.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1ba971e6edb6c623afec0b20aa35dea5abcc54a3","unresolved":false,"context_lines":[{"line_number":25,"context_line":"CONF \u003d config.CONF"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class ClientTestBase(base.ClientTestBase):"},{"line_number":29,"context_line":"    \"\"\"Base class for OSC manila functional tests\"\"\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def _get_clients(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_7e2387aa","line":28,"range":{"start_line":28,"start_character":6,"end_line":28,"end_character":20},"updated":"2020-02-21 01:14:39.000000000","message":"nit: Could call this something else since it matches the name of the class it is inheriting from, perhaps \"OSCClientTestBase\"?","commit_id":"a6f181d25461abda0730a4df6c9d226cf90ba7d4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1ba971e6edb6c623afec0b20aa35dea5abcc54a3","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                % CONF.max_api_microversion)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        return self.clients.openstack(action, flags\u003dflags, params\u003dparams,"},{"line_number":97,"context_line":"                                      fail_ok\u003dfail_ok, merge_stderr\u003dFalse)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def listing_result(self, object_name, command):"},{"line_number":100,"context_line":"        \"\"\"Returns output for the given command as list of dictionaries\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_f826aecc","line":97,"range":{"start_line":97,"start_character":68,"end_line":97,"end_character":73},"updated":"2020-02-21 01:14:39.000000000","message":"merge_stderr","commit_id":"a6f181d25461abda0730a4df6c9d226cf90ba7d4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1ba971e6edb6c623afec0b20aa35dea5abcc54a3","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        return result_dict"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def create_share(self, share_protocol\u003dNone, size\u003dNone, name\u003dNone,"},{"line_number":116,"context_line":"                     snapshot_id\u003dNone, property\u003dNone, share_network\u003dNone,"},{"line_number":117,"context_line":"                     description\u003dNone, public\u003dFalse, share_type\u003dNone,"},{"line_number":118,"context_line":"                     availability_zone\u003dNone, share_group\u003dNone):"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_989a1a10","line":116,"range":{"start_line":116,"start_character":39,"end_line":116,"end_character":47},"updated":"2020-02-21 01:14:39.000000000","message":"Probably call this \"properties\" or metadata here to avoid shadowing the inbuilt \"property\"","commit_id":"a6f181d25461abda0730a4df6c9d226cf90ba7d4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1ba971e6edb6c623afec0b20aa35dea5abcc54a3","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        if snapshot_id:"},{"line_number":135,"context_line":"            cmd \u003d cmd + \u0027 --snapshot-id %s\u0027 % snapshot_id"},{"line_number":136,"context_line":"        if property:"},{"line_number":137,"context_line":"            cmd \u003d cmd + \u0027 --property %s\u0027 % property"},{"line_number":138,"context_line":"        if share_network:"},{"line_number":139,"context_line":"            cmd \u003d cmd + \u0027 --share-network %s\u0027 % share_network"},{"line_number":140,"context_line":"        if availability_zone:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_78971eec","line":137,"range":{"start_line":136,"start_character":8,"end_line":137,"end_character":51},"updated":"2020-02-21 01:14:39.000000000","message":"This is a repeatable option, so you\u0027d need to loop through the items..","commit_id":"a6f181d25461abda0730a4df6c9d226cf90ba7d4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"31e7b0339b3a084b233a30cec909ded27da58bb7","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class OSCClientTestBase(base.ClientTestBase):"},{"line_number":27,"context_line":"    \"\"\"Base class for OSC manila functional tests\"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def _get_clients(self):"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        return base.CLIClient("},{"line_number":32,"context_line":"            username\u003dCONF.admin_username or CONF.username,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_9a9eb005","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":27},"updated":"2020-02-26 03:31:32.000000000","message":"Currently, I understand there\u0027s no test case that you\u0027ve written that separates \"admin\" and regular user interactions. Ideally, you\u0027ll want both admin and regular tenant credentials for long term hardening of these test cases. \n\nThe test cases are currently being run with admin credentials because we always configure them in the CI, and in the code below you refer to admin credentials first. \n\nIt\u0027d be nice to match the way we\u0027re separating these clients right now: https://opendev.org/openstack/python-manilaclient/src/commit/0ca91287acffece4f78451e160fafa040a988f5a/manilaclient/tests/functional/base.py#L147-L193","commit_id":"afc2e4d65fa2692858983a1585268064e72dc333"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"31e7b0339b3a084b233a30cec909ded27da58bb7","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        return obj"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def _wait_for_object_status(self, object_name, object_id, status,"},{"line_number":57,"context_line":"                                timeout\u003d120, interval\u003d3):"},{"line_number":58,"context_line":"        \"\"\"Waits for a share to reach a given status.\"\"\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        start_time \u003d time.time()"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_f5501735","line":57,"range":{"start_line":57,"start_character":54,"end_line":57,"end_character":55},"updated":"2020-02-26 03:31:32.000000000","message":"this has to be CONF.build_interval","commit_id":"afc2e4d65fa2692858983a1585268064e72dc333"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"31e7b0339b3a084b233a30cec909ded27da58bb7","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        return obj"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def _wait_for_object_status(self, object_name, object_id, status,"},{"line_number":57,"context_line":"                                timeout\u003d120, interval\u003d3):"},{"line_number":58,"context_line":"        \"\"\"Waits for a share to reach a given status.\"\"\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        start_time \u003d time.time()"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_d54b9b84","line":57,"range":{"start_line":57,"start_character":40,"end_line":57,"end_character":43},"updated":"2020-02-26 03:31:32.000000000","message":"this has to be CONF.build_timeout","commit_id":"afc2e4d65fa2692858983a1585268064e72dc333"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"31e7b0339b3a084b233a30cec909ded27da58bb7","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        start_time \u003d time.time()"},{"line_number":61,"context_line":"        while time.time() - start_time \u003c timeout:"},{"line_number":62,"context_line":"            if status in self.openstack("},{"line_number":63,"context_line":"                    \u0027%s show\u0027 % object_name, params\u003dobject_id):"},{"line_number":64,"context_line":"                break"},{"line_number":65,"context_line":"            time.sleep(interval)"},{"line_number":66,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_956c4309","line":63,"range":{"start_line":63,"start_character":21,"end_line":63,"end_character":28},"updated":"2020-02-26 03:31:32.000000000","message":"Can restrict this further:\n\nif status \u003d\u003d self.openstack(\n  \"%s show\" % object_name, params\u003d\"-c status -f value %s\" % object_id)","commit_id":"afc2e4d65fa2692858983a1585268064e72dc333"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"31e7b0339b3a084b233a30cec909ded27da58bb7","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            self.fail(\"%s %s did not reach status %s after %d seconds.\""},{"line_number":68,"context_line":"                      % (object_name, object_id, status, timeout))"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def check_object_deleted(self, object_name, object_id, timeout\u003d60):"},{"line_number":71,"context_line":"        \"\"\"Check that object deleted successfully\"\"\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        cmd \u003d \u0027%s show %s\u0027 % (object_name, object_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_953a03e5","line":70,"range":{"start_line":70,"start_character":67,"end_line":70,"end_character":69},"updated":"2020-02-26 03:31:32.000000000","message":"CONF.build_timeout","commit_id":"afc2e4d65fa2692858983a1585268064e72dc333"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"31e7b0339b3a084b233a30cec909ded27da58bb7","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        cmd \u003d \u0027%s show %s\u0027 % (object_name, object_id)"},{"line_number":74,"context_line":"        try:"},{"line_number":75,"context_line":"            start_time \u003d time.time()"},{"line_number":76,"context_line":"            while time.time() - start_time \u003c timeout:"},{"line_number":77,"context_line":"                if object_id not in self.openstack(cmd):"},{"line_number":78,"context_line":"                    break"},{"line_number":79,"context_line":"        except exceptions.CommandFailed:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_b53fffd4","line":76,"range":{"start_line":76,"start_character":18,"end_line":76,"end_character":52},"updated":"2020-02-26 03:31:32.000000000","message":"Could use some backoff, like an interval (CONF.build_interval)","commit_id":"afc2e4d65fa2692858983a1585268064e72dc333"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"31e7b0339b3a084b233a30cec909ded27da58bb7","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            while time.time() - start_time \u003c timeout:"},{"line_number":77,"context_line":"                if object_id not in self.openstack(cmd):"},{"line_number":78,"context_line":"                    break"},{"line_number":79,"context_line":"        except exceptions.CommandFailed:"},{"line_number":80,"context_line":"            pass"},{"line_number":81,"context_line":"        else:"},{"line_number":82,"context_line":"            self.fail(\"%s %s not deleted after %d seconds.\""},{"line_number":83,"context_line":"                      % (object_name, object_id, timeout))"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_555fab40","line":80,"range":{"start_line":79,"start_character":15,"end_line":80,"end_character":16},"updated":"2020-02-26 03:31:32.000000000","message":"There could be some other issue?\n\nWouldn\u0027t it be better to check the list response for the specific ID, like you\u0027re doing in the deletion test, or what we\u0027re doing in the other client\u0027s functional tests (E.g.: https://opendev.org/openstack/python-manilaclient/src/commit/b7d0d0d1289c3a8d74e584e894f7921c3d195d74/manilaclient/tests/functional/client.py#L329-L341)","commit_id":"afc2e4d65fa2692858983a1585268064e72dc333"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"31e7b0339b3a084b233a30cec909ded27da58bb7","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        share_object \u003d self.dict_result(\u0027share\u0027, cmd)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        if add_cleanup:"},{"line_number":150,"context_line":"            self.addCleanup("},{"line_number":151,"context_line":"                self.openstack, \u0027share delete %s\u0027 % share_object[\u0027id\u0027]"},{"line_number":152,"context_line":"            )"},{"line_number":153,"context_line":"        return share_object"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_55248bc6","line":152,"range":{"start_line":149,"start_character":8,"end_line":152,"end_character":13},"updated":"2020-02-26 03:31:32.000000000","message":"LGTM","commit_id":"afc2e4d65fa2692858983a1585268064e72dc333"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b5151efaa0909947970a6863971b0024d4abd305","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        start_time \u003d time.time()"},{"line_number":60,"context_line":"        while time.time() - start_time \u003c timeout:"},{"line_number":61,"context_line":"            if status in self.openstack("},{"line_number":62,"context_line":"                    \u0027%(obj)s show -c status -f value %(id)s\u0027"},{"line_number":63,"context_line":"                    % {\u0027obj\u0027: object_name,"},{"line_number":64,"context_line":"                       \u0027id\u0027: object_id}):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1fa4df85_51f3319f","line":61,"range":{"start_line":61,"start_character":22,"end_line":61,"end_character":24},"updated":"2020-02-26 18:31:26.000000000","message":"\u003d\u003d\n\nSome statuses can be substrings, e.g.: \"error\" and \"manage_error\"","commit_id":"caf93edf0b94891f77d7acbb5793842d3ea6de9b"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"a1756e0b4d90d31caf6564f14a70134567d8c828","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        start_time \u003d time.time()"},{"line_number":60,"context_line":"        while time.time() - start_time \u003c timeout:"},{"line_number":61,"context_line":"            if status in self.openstack("},{"line_number":62,"context_line":"                    \u0027%(obj)s show -c status -f value %(id)s\u0027"},{"line_number":63,"context_line":"                    % {\u0027obj\u0027: object_name,"},{"line_number":64,"context_line":"                       \u0027id\u0027: object_id}):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1fa4df85_973502dd","line":61,"range":{"start_line":61,"start_character":22,"end_line":61,"end_character":24},"in_reply_to":"1fa4df85_47f3739f","updated":"2020-02-28 08:21:49.000000000","message":"yep, this works","commit_id":"caf93edf0b94891f77d7acbb5793842d3ea6de9b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2994fcb863b58883110fb48fec79f2ccb0338bc9","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        start_time \u003d time.time()"},{"line_number":60,"context_line":"        while time.time() - start_time \u003c timeout:"},{"line_number":61,"context_line":"            if status in self.openstack("},{"line_number":62,"context_line":"                    \u0027%(obj)s show -c status -f value %(id)s\u0027"},{"line_number":63,"context_line":"                    % {\u0027obj\u0027: object_name,"},{"line_number":64,"context_line":"                       \u0027id\u0027: object_id}):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1fa4df85_47f3739f","line":61,"range":{"start_line":61,"start_character":22,"end_line":61,"end_character":24},"in_reply_to":"1fa4df85_4c77183c","updated":"2020-02-26 21:39:18.000000000","message":"Oh, weird, is the newline character being escaped? So rstrip didn\u0027t help? Something like:\n\n self.openstack(\u0027%(obj)s show -c status -f value %(id)s\n     % {\u0027obj\u0027: object_name, \u0027id\u0027: object_id}).rstrip()","commit_id":"caf93edf0b94891f77d7acbb5793842d3ea6de9b"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"f02245e822ecdea7e7fcfdaf71b6901843830366","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        start_time \u003d time.time()"},{"line_number":60,"context_line":"        while time.time() - start_time \u003c timeout:"},{"line_number":61,"context_line":"            if status in self.openstack("},{"line_number":62,"context_line":"                    \u0027%(obj)s show -c status -f value %(id)s\u0027"},{"line_number":63,"context_line":"                    % {\u0027obj\u0027: object_name,"},{"line_number":64,"context_line":"                       \u0027id\u0027: object_id}):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1fa4df85_4c77183c","line":61,"range":{"start_line":61,"start_character":22,"end_line":61,"end_character":24},"in_reply_to":"1fa4df85_51f3319f","updated":"2020-02-26 19:43:49.000000000","message":"when using \u003d\u003d the statement was always false and wouldn\u0027t break the loop even if status was actually available. While debugging it I ran repr() on the command result and found that it was \"available\\\\n\" so ended up using \u0027in\u0027.","commit_id":"caf93edf0b94891f77d7acbb5793842d3ea6de9b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b5151efaa0909947970a6863971b0024d4abd305","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                             interval\u003dCONF.build_interval):"},{"line_number":74,"context_line":"        \"\"\"Check that object deleted successfully\"\"\""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        cmd \u003d \u0027%s list -c ID\u0027 % object_name"},{"line_number":77,"context_line":"        start_time \u003d time.time()"},{"line_number":78,"context_line":"        while time.time() - start_time \u003c timeout:"},{"line_number":79,"context_line":"            if object_id not in self.openstack(cmd):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1fa4df85_f1049d7d","line":76,"range":{"start_line":76,"start_character":28,"end_line":76,"end_character":29},"updated":"2020-02-26 18:31:26.000000000","message":"-f value","commit_id":"caf93edf0b94891f77d7acbb5793842d3ea6de9b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2994fcb863b58883110fb48fec79f2ccb0338bc9","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        output \u003d self.openstack(object_name, params\u003dcommand)"},{"line_number":110,"context_line":"        result_dict \u003d self._get_property_from_output(output)"},{"line_number":111,"context_line":"        self._wait_for_object_status("},{"line_number":112,"context_line":"            object_name, result_dict[\u0027id\u0027], \u0027available\u0027)"},{"line_number":113,"context_line":"        return result_dict"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def create_share(self, share_protocol\u003dNone, size\u003dNone, name\u003dNone,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1fa4df85_279af713","line":112,"range":{"start_line":111,"start_character":0,"end_line":112,"end_character":56},"updated":"2020-02-26 21:39:18.000000000","message":"Suggestion for your next patch: this needs to be done in the calling method, since you could use dict_result elsewhere, when you\u0027re not creating the resource...","commit_id":"caf93edf0b94891f77d7acbb5793842d3ea6de9b"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"a1756e0b4d90d31caf6564f14a70134567d8c828","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        output \u003d self.openstack(object_name, params\u003dcommand)"},{"line_number":110,"context_line":"        result_dict \u003d self._get_property_from_output(output)"},{"line_number":111,"context_line":"        self._wait_for_object_status("},{"line_number":112,"context_line":"            object_name, result_dict[\u0027id\u0027], \u0027available\u0027)"},{"line_number":113,"context_line":"        return result_dict"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def create_share(self, share_protocol\u003dNone, size\u003dNone, name\u003dNone,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1fa4df85_5776aaa6","line":112,"range":{"start_line":111,"start_character":0,"end_line":112,"end_character":56},"in_reply_to":"1fa4df85_279af713","updated":"2020-02-28 08:21:49.000000000","message":"thats a great note, doesn\u0027t make sense having it here, I will squeeze that change in right now.","commit_id":"caf93edf0b94891f77d7acbb5793842d3ea6de9b"}],"manilaclient/tests/functional/osc/shares.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"7526b459cf7470bd3e07ad0c2d56a0301bf744c9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2020 Red Hat, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#   not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_d53c1b2f","line":1,"updated":"2020-02-17 23:53:18.000000000","message":"This file should be called test_shares.py, otherwise stestr does not discover the tests it contains.","commit_id":"5f76df55963d6f53c795dffb71543b17c29791c1"}],"manilaclient/tests/functional/osc/test_shares.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"8293c0e780ea2316a66a27e9c0cca665170cecb5","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        ])"},{"line_number":48,"context_line":"        self.assertIn(share[\u0027id\u0027], [item[\u0027ID\u0027] for item in shares_list])"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        self.openstack(\u0027share delete %s\u0027 % share[\u0027id\u0027])"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def test_openstack_share_show(self):"},{"line_number":53,"context_line":"        share \u003d self.create_share()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_2780d79d","line":50,"updated":"2020-02-18 17:28:10.000000000","message":"I was wondering if those cleanup operations couldn\u0027t be done by the tempest clients triggered by self.addCleanup; in fact you are not testing the \u0027openstack share delete\u0027 operation in this test, only in test_openstack_share_delete.\n\nBUT. The existing functional tests for the current CLI use the \u0027manila\u0027 commands as well to execute testing closures, so this is consistent with the existing code. So fine by me, it\u0027s up to manila cores on whether they want to have this changed.","commit_id":"a6f181d25461abda0730a4df6c9d226cf90ba7d4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1ba971e6edb6c623afec0b20aa35dea5abcc54a3","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        ])"},{"line_number":48,"context_line":"        self.assertIn(share[\u0027id\u0027], [item[\u0027ID\u0027] for item in shares_list])"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        self.openstack(\u0027share delete %s\u0027 % share[\u0027id\u0027])"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def test_openstack_share_show(self):"},{"line_number":53,"context_line":"        share \u003d self.create_share()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_38aa061b","line":50,"in_reply_to":"3fa7e38b_2780d79d","updated":"2020-02-21 01:14:39.000000000","message":"+1, \n\nMaari: can we use addCleanup after creation in the base class\u0027s create_share() method; avoids having to write this in every test. Rarely will we have a case where teardown isn\u0027t necessary - e.g.: when testing delete operations themselves","commit_id":"a6f181d25461abda0730a4df6c9d226cf90ba7d4"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"8293c0e780ea2316a66a27e9c0cca665170cecb5","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            \u0027Value\u0027"},{"line_number":62,"context_line":"        ])"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        self.openstack(\u0027share delete %s\u0027 % share[\u0027id\u0027])"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def test_openstack_share_delete(self):"},{"line_number":67,"context_line":"        share \u003d self.create_share()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_e7895fc8","line":64,"updated":"2020-02-18 17:28:10.000000000","message":"see above","commit_id":"a6f181d25461abda0730a4df6c9d226cf90ba7d4"}]}