)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"ceeba22fe782d647a96e0bc87204f3f7a63bf0a4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve OSC test coverage"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In this patch we add some unit tests for exception cases"},{"line_number":10,"context_line":"to improve overall test coverage."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7604da8943dca8f3eada7c5ac1311086772f41a5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff570b3c_ea014806","line":9,"updated":"2020-05-28 17:30:00.000000000","message":"NIT Explicit is better than implicit. Make a short list of which test cases you added (considering they are not so many) so we have a record on the commit message for future reference","commit_id":"36cb30a62e6de4843867bce40868a23a0c7490db"}],"manilaclient/tests/unit/osc/v2/test_share.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4de2d6312ec547d05ec0510494f37608963be67f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import mock"},{"line_number":18,"context_line":"import uuid"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from mock import call"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from osc_lib.exceptions import CommandError"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from openstackclient.tests.unit.identity.v3 import fakes as identity_fakes"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from manilaclient.common.apiclient import exceptions"},{"line_number":27,"context_line":"from manilaclient.common import cliutils"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_3e8de27a","line":24,"range":{"start_line":20,"start_character":0,"end_line":24,"end_character":74},"updated":"2020-08-03 19:28:20.000000000","message":"Remove blank lines between imports here..","commit_id":"dc7264aeefb3a30f8d14a73729d49317074864d7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4de2d6312ec547d05ec0510494f37608963be67f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import uuid"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from openstackclient.tests.unit.identity.v3 import fakes as identity_fakes"},{"line_number":21,"context_line":"from osc_lib.exceptions import CommandError"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from manilaclient.common.apiclient import exceptions"},{"line_number":24,"context_line":"from manilaclient.common import cliutils"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_bfc76d64","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":43},"updated":"2020-08-03 19:28:20.000000000","message":"It\u0027s good practice to import modules, and not objects:\nhttps://docs.openstack.org/hacking/latest/user/hacking.html#imports\n\nPerhaps resolve the name collision with manila client\u0027s exceptions file by:\n\n from osc_lib import exceptions as osc_exceptions","commit_id":"502d6850ecd458875f896e6953e737fb2dd02d1d"}]}
