)]}'
{"manilaclient/api_versions.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f8a8878ba0e8b2fe4ad7e001e19e2afa1b6d03e7","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    if api_version \u003d\u003d manilaclient.API_DEPRECATED_VERSION:"},{"line_number":204,"context_line":"        msg \u003d _(\"Client version \u0027%(version)s\u0027 is deprecated.\") % {"},{"line_number":205,"context_line":"            \"version\": api_version.get_string()}"},{"line_number":206,"context_line":"        warnings.warn(msg)"},{"line_number":207,"context_line":"        return True"},{"line_number":208,"context_line":"    return False"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_58b7d33b","line":206,"updated":"2020-04-04 14:31:40.000000000","message":"cover:  UserWarning: Client version \u00271.0\u0027 is deprecated.","commit_id":"852e5ea4c685091c97014380ff2337e7b4bf9b2b"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f8a8878ba0e8b2fe4ad7e001e19e2afa1b6d03e7","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    if api_version \u003d\u003d manilaclient.API_DEPRECATED_VERSION:"},{"line_number":204,"context_line":"        msg \u003d _(\"Client version \u0027%(version)s\u0027 is deprecated.\") % {"},{"line_number":205,"context_line":"            \"version\": api_version.get_string()}"},{"line_number":206,"context_line":"        warnings.warn(msg)"},{"line_number":207,"context_line":"        return True"},{"line_number":208,"context_line":"    return False"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_38b48f35","line":206,"updated":"2020-04-04 14:31:40.000000000","message":"py36:  UserWarning: Client version \u00271.0\u0027 is deprecated.","commit_id":"852e5ea4c685091c97014380ff2337e7b4bf9b2b"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f8a8878ba0e8b2fe4ad7e001e19e2afa1b6d03e7","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    if api_version \u003d\u003d manilaclient.API_DEPRECATED_VERSION:"},{"line_number":204,"context_line":"        msg \u003d _(\"Client version \u0027%(version)s\u0027 is deprecated.\") % {"},{"line_number":205,"context_line":"            \"version\": api_version.get_string()}"},{"line_number":206,"context_line":"        warnings.warn(msg)"},{"line_number":207,"context_line":"        return True"},{"line_number":208,"context_line":"    return False"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_9882fb51","line":206,"updated":"2020-04-04 14:31:40.000000000","message":"py37:  UserWarning: Client version \u00271.0\u0027 is deprecated.","commit_id":"852e5ea4c685091c97014380ff2337e7b4bf9b2b"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f8a8878ba0e8b2fe4ad7e001e19e2afa1b6d03e7","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    if api_version \u003d\u003d manilaclient.API_DEPRECATED_VERSION:"},{"line_number":204,"context_line":"        msg \u003d _(\"Client version \u0027%(version)s\u0027 is deprecated.\") % {"},{"line_number":205,"context_line":"            \"version\": api_version.get_string()}"},{"line_number":206,"context_line":"        warnings.warn(msg)"},{"line_number":207,"context_line":"        return True"},{"line_number":208,"context_line":"    return False"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_78873763","line":206,"updated":"2020-04-04 14:31:40.000000000","message":"py38:  UserWarning: Client version \u00271.0\u0027 is deprecated.","commit_id":"852e5ea4c685091c97014380ff2337e7b4bf9b2b"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"a90452b3afbbf52864d3a29f2acb977af4e26e8e","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    if api_version \u003d\u003d manilaclient.API_DEPRECATED_VERSION:"},{"line_number":204,"context_line":"        msg \u003d _(\"Client version \u0027%(version)s\u0027 is deprecated.\") % {"},{"line_number":205,"context_line":"            \"version\": api_version.get_string()}"},{"line_number":206,"context_line":"        warnings.warn(msg)"},{"line_number":207,"context_line":"        return True"},{"line_number":208,"context_line":"    return False"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"df33271e_1595c8e4","line":206,"updated":"2020-04-08 02:06:16.000000000","message":"cover:  UserWarning: Client version \u00271.0\u0027 is deprecated.","commit_id":"dd05bfc9718c52b881075b0c2ef39384efc1623f"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"a90452b3afbbf52864d3a29f2acb977af4e26e8e","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    if api_version \u003d\u003d manilaclient.API_DEPRECATED_VERSION:"},{"line_number":204,"context_line":"        msg \u003d _(\"Client version \u0027%(version)s\u0027 is deprecated.\") % {"},{"line_number":205,"context_line":"            \"version\": api_version.get_string()}"},{"line_number":206,"context_line":"        warnings.warn(msg)"},{"line_number":207,"context_line":"        return True"},{"line_number":208,"context_line":"    return False"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"df33271e_f59784ea","line":206,"updated":"2020-04-08 02:06:16.000000000","message":"py36:  UserWarning: Client version \u00271.0\u0027 is deprecated.","commit_id":"dd05bfc9718c52b881075b0c2ef39384efc1623f"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"a90452b3afbbf52864d3a29f2acb977af4e26e8e","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    if api_version \u003d\u003d manilaclient.API_DEPRECATED_VERSION:"},{"line_number":204,"context_line":"        msg \u003d _(\"Client version \u0027%(version)s\u0027 is deprecated.\") % {"},{"line_number":205,"context_line":"            \"version\": api_version.get_string()}"},{"line_number":206,"context_line":"        warnings.warn(msg)"},{"line_number":207,"context_line":"        return True"},{"line_number":208,"context_line":"    return False"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"df33271e_559f5002","line":206,"updated":"2020-04-08 02:06:16.000000000","message":"py37:  UserWarning: Client version \u00271.0\u0027 is deprecated.","commit_id":"dd05bfc9718c52b881075b0c2ef39384efc1623f"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"a90452b3afbbf52864d3a29f2acb977af4e26e8e","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    if api_version \u003d\u003d manilaclient.API_DEPRECATED_VERSION:"},{"line_number":204,"context_line":"        msg \u003d _(\"Client version \u0027%(version)s\u0027 is deprecated.\") % {"},{"line_number":205,"context_line":"            \"version\": api_version.get_string()}"},{"line_number":206,"context_line":"        warnings.warn(msg)"},{"line_number":207,"context_line":"        return True"},{"line_number":208,"context_line":"    return False"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"df33271e_35a28c4c","line":206,"updated":"2020-04-08 02:06:16.000000000","message":"py38:  UserWarning: Client version \u00271.0\u0027 is deprecated.","commit_id":"dd05bfc9718c52b881075b0c2ef39384efc1623f"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b3030591229286520846997a10347f8b361c82bb","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    if api_version \u003d\u003d manilaclient.API_DEPRECATED_VERSION:"},{"line_number":204,"context_line":"        msg \u003d _(\"Client version \u0027%(version)s\u0027 is deprecated.\") % {"},{"line_number":205,"context_line":"            \"version\": api_version.get_string()}"},{"line_number":206,"context_line":"        warnings.warn(msg)"},{"line_number":207,"context_line":"        return True"},{"line_number":208,"context_line":"    return False"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"df33271e_18069d87","line":206,"updated":"2020-04-08 03:24:51.000000000","message":"cover:  UserWarning: Client version \u00271.0\u0027 is deprecated.","commit_id":"c93a82aa8d04b649c66d782f3a5456621dd99243"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b3030591229286520846997a10347f8b361c82bb","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    if api_version \u003d\u003d manilaclient.API_DEPRECATED_VERSION:"},{"line_number":204,"context_line":"        msg \u003d _(\"Client version \u0027%(version)s\u0027 is deprecated.\") % {"},{"line_number":205,"context_line":"            \"version\": api_version.get_string()}"},{"line_number":206,"context_line":"        warnings.warn(msg)"},{"line_number":207,"context_line":"        return True"},{"line_number":208,"context_line":"    return False"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"df33271e_f8081992","line":206,"updated":"2020-04-08 03:24:51.000000000","message":"py36:  UserWarning: Client version \u00271.0\u0027 is deprecated.","commit_id":"c93a82aa8d04b649c66d782f3a5456621dd99243"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b3030591229286520846997a10347f8b361c82bb","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    if api_version \u003d\u003d manilaclient.API_DEPRECATED_VERSION:"},{"line_number":204,"context_line":"        msg \u003d _(\"Client version \u0027%(version)s\u0027 is deprecated.\") % {"},{"line_number":205,"context_line":"            \"version\": api_version.get_string()}"},{"line_number":206,"context_line":"        warnings.warn(msg)"},{"line_number":207,"context_line":"        return True"},{"line_number":208,"context_line":"    return False"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"df33271e_58002568","line":206,"updated":"2020-04-08 03:24:51.000000000","message":"py37:  UserWarning: Client version \u00271.0\u0027 is deprecated.","commit_id":"c93a82aa8d04b649c66d782f3a5456621dd99243"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b3030591229286520846997a10347f8b361c82bb","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    if api_version \u003d\u003d manilaclient.API_DEPRECATED_VERSION:"},{"line_number":204,"context_line":"        msg \u003d _(\"Client version \u0027%(version)s\u0027 is deprecated.\") % {"},{"line_number":205,"context_line":"            \"version\": api_version.get_string()}"},{"line_number":206,"context_line":"        warnings.warn(msg)"},{"line_number":207,"context_line":"        return True"},{"line_number":208,"context_line":"    return False"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"df33271e_3803a175","line":206,"updated":"2020-04-08 03:24:51.000000000","message":"py38:  UserWarning: Client version \u00271.0\u0027 is deprecated.","commit_id":"c93a82aa8d04b649c66d782f3a5456621dd99243"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"8d2b1c67427725065eee00f79da26fb20d5bbffa","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    if api_version \u003d\u003d manilaclient.API_DEPRECATED_VERSION:"},{"line_number":204,"context_line":"        msg \u003d _(\"Client version \u0027%(version)s\u0027 is deprecated.\") % {"},{"line_number":205,"context_line":"            \"version\": api_version.get_string()}"},{"line_number":206,"context_line":"        warnings.warn(msg)"},{"line_number":207,"context_line":"        return True"},{"line_number":208,"context_line":"    return False"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"df33271e_9b7d871e","line":206,"updated":"2020-04-08 04:25:40.000000000","message":"cover:  UserWarning: Client version \u00271.0\u0027 is deprecated.","commit_id":"a0cbed52ed28beb6d0f1042041e9e1ddcd7263f9"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"8d2b1c67427725065eee00f79da26fb20d5bbffa","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    if api_version \u003d\u003d manilaclient.API_DEPRECATED_VERSION:"},{"line_number":204,"context_line":"        msg \u003d _(\"Client version \u0027%(version)s\u0027 is deprecated.\") % {"},{"line_number":205,"context_line":"            \"version\": api_version.get_string()}"},{"line_number":206,"context_line":"        warnings.warn(msg)"},{"line_number":207,"context_line":"        return True"},{"line_number":208,"context_line":"    return False"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"df33271e_7b78832a","line":206,"updated":"2020-04-08 04:25:40.000000000","message":"py36:  UserWarning: Client version \u00271.0\u0027 is deprecated.","commit_id":"a0cbed52ed28beb6d0f1042041e9e1ddcd7263f9"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:gate","change_message_id":"848eb4018742dd5ec38e4c5dba938964f30b18bf","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    if api_version \u003d\u003d manilaclient.API_DEPRECATED_VERSION:"},{"line_number":204,"context_line":"        msg \u003d _(\"Client version \u0027%(version)s\u0027 is deprecated.\") % {"},{"line_number":205,"context_line":"            \"version\": api_version.get_string()}"},{"line_number":206,"context_line":"        warnings.warn(msg)"},{"line_number":207,"context_line":"        return True"},{"line_number":208,"context_line":"    return False"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"df33271e_e304dcc8","line":206,"updated":"2020-04-08 14:45:56.000000000","message":"py36:  UserWarning: Client version \u00271.0\u0027 is deprecated.","commit_id":"a0cbed52ed28beb6d0f1042041e9e1ddcd7263f9"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:gate","change_message_id":"848eb4018742dd5ec38e4c5dba938964f30b18bf","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    if api_version \u003d\u003d manilaclient.API_DEPRECATED_VERSION:"},{"line_number":204,"context_line":"        msg \u003d _(\"Client version \u0027%(version)s\u0027 is deprecated.\") % {"},{"line_number":205,"context_line":"            \"version\": api_version.get_string()}"},{"line_number":206,"context_line":"        warnings.warn(msg)"},{"line_number":207,"context_line":"        return True"},{"line_number":208,"context_line":"    return False"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"df33271e_c30718c9","line":206,"updated":"2020-04-08 14:45:56.000000000","message":"py37:  UserWarning: Client version \u00271.0\u0027 is deprecated.","commit_id":"a0cbed52ed28beb6d0f1042041e9e1ddcd7263f9"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"8d2b1c67427725065eee00f79da26fb20d5bbffa","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    if api_version \u003d\u003d manilaclient.API_DEPRECATED_VERSION:"},{"line_number":204,"context_line":"        msg \u003d _(\"Client version \u0027%(version)s\u0027 is deprecated.\") % {"},{"line_number":205,"context_line":"            \"version\": api_version.get_string()}"},{"line_number":206,"context_line":"        warnings.warn(msg)"},{"line_number":207,"context_line":"        return True"},{"line_number":208,"context_line":"    return False"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"df33271e_db770f3a","line":206,"updated":"2020-04-08 04:25:40.000000000","message":"py37:  UserWarning: Client version \u00271.0\u0027 is deprecated.","commit_id":"a0cbed52ed28beb6d0f1042041e9e1ddcd7263f9"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"8d2b1c67427725065eee00f79da26fb20d5bbffa","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    if api_version \u003d\u003d manilaclient.API_DEPRECATED_VERSION:"},{"line_number":204,"context_line":"        msg \u003d _(\"Client version \u0027%(version)s\u0027 is deprecated.\") % {"},{"line_number":205,"context_line":"            \"version\": api_version.get_string()}"},{"line_number":206,"context_line":"        warnings.warn(msg)"},{"line_number":207,"context_line":"        return True"},{"line_number":208,"context_line":"    return False"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"df33271e_bb720b48","line":206,"updated":"2020-04-08 04:25:40.000000000","message":"py38:  UserWarning: Client version \u00271.0\u0027 is deprecated.","commit_id":"a0cbed52ed28beb6d0f1042041e9e1ddcd7263f9"}],"manilaclient/tests/functional/test_quotas.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e410147f8b5bf7ef3cd7d4b4be9e6942a9559f37","unresolved":false,"context_lines":[{"line_number":174,"context_line":"            cmd, microversion\u003d\u00272.40\u0027)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    @ddt.data(*set(["},{"line_number":177,"context_line":"        \"2.39\", \"2.40\", api_versions.MAX_VERSION,"},{"line_number":178,"context_line":"    ]))"},{"line_number":179,"context_line":"    def test_update_share_type_quotas_positive(self, microversion):"},{"line_number":180,"context_line":"        if not utils.is_microversion_supported(microversion):"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_7c408708","line":177,"range":{"start_line":177,"start_character":23,"end_line":177,"end_character":24},"updated":"2020-04-07 20:49:25.000000000","message":"add \u00272.53\u0027","commit_id":"852e5ea4c685091c97014380ff2337e7b4bf9b2b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"85b6d67dc11e94d1f53c3f5c392d8578df10128b","unresolved":false,"context_lines":[{"line_number":174,"context_line":"            cmd, microversion\u003d\u00272.40\u0027)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    @ddt.data(*set(["},{"line_number":177,"context_line":"        \"2.39\", \"2.40\", api_versions.MAX_VERSION,"},{"line_number":178,"context_line":"    ]))"},{"line_number":179,"context_line":"    def test_update_share_type_quotas_positive(self, microversion):"},{"line_number":180,"context_line":"        if not utils.is_microversion_supported(microversion):"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_50c92723","line":177,"range":{"start_line":177,"start_character":23,"end_line":177,"end_character":24},"in_reply_to":"df33271e_7c408708","updated":"2020-04-07 23:11:14.000000000","message":"Done","commit_id":"852e5ea4c685091c97014380ff2337e7b4bf9b2b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e410147f8b5bf7ef3cd7d4b4be9e6942a9559f37","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            \u0027snapshot_gigabytes\u0027: _get_share_type_quota_values("},{"line_number":195,"context_line":"                p_quotas[\u0027snapshot_gigabytes\u0027]),"},{"line_number":196,"context_line":"        }"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        # Update quotas for share type"},{"line_number":199,"context_line":"        cmd \u003d (\u0027quota-update %s --share-type %s \u0027"},{"line_number":200,"context_line":"               \u0027--shares %s --gigabytes %s --snapshots %s \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_dc4ef336","line":197,"range":{"start_line":197,"start_character":0,"end_line":197,"end_character":0},"updated":"2020-04-07 20:49:25.000000000","message":"add replica quotas here..","commit_id":"852e5ea4c685091c97014380ff2337e7b4bf9b2b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"85b6d67dc11e94d1f53c3f5c392d8578df10128b","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            \u0027snapshot_gigabytes\u0027: _get_share_type_quota_values("},{"line_number":195,"context_line":"                p_quotas[\u0027snapshot_gigabytes\u0027]),"},{"line_number":196,"context_line":"        }"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        # Update quotas for share type"},{"line_number":199,"context_line":"        cmd \u003d (\u0027quota-update %s --share-type %s \u0027"},{"line_number":200,"context_line":"               \u0027--shares %s --gigabytes %s --snapshots %s \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_70c6eb18","line":197,"range":{"start_line":197,"start_character":0,"end_line":197,"end_character":0},"in_reply_to":"df33271e_dc4ef336","updated":"2020-04-07 23:11:14.000000000","message":"Done","commit_id":"852e5ea4c685091c97014380ff2337e7b4bf9b2b"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"77d4aa986c5cb5b130f5e21c30752d2b3961dd06","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            st_custom_quotas[\u0027share_replicas\u0027] \u003d _get_share_type_quota_values("},{"line_number":204,"context_line":"                p_quotas[\u0027share_replicas\u0027]"},{"line_number":205,"context_line":"            )"},{"line_number":206,"context_line":"            st_custom_quotas[\u0027replica_gigabtyes\u0027] \u003d ("},{"line_number":207,"context_line":"                get_share_type_quota_values(p_quotas[\u0027replica_gigabytes\u0027]))"},{"line_number":208,"context_line":"            replica_params \u003d (\u0027 --share-replicas %s \u0027"},{"line_number":209,"context_line":"                              \u0027--replica-gigabytes %s\u0027) % ("}],"source_content_type":"text/x-python","patch_set":8,"id":"df33271e_4697adec","line":206,"range":{"start_line":206,"start_character":30,"end_line":206,"end_character":47},"updated":"2020-04-08 00:19:07.000000000","message":"typo: replica_gigabytes","commit_id":"accf37a52449ed82c29c784a5f5347788603bbf5"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0515165c22f35ea690031c4ac17a80120c404759","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            st_custom_quotas[\u0027share_replicas\u0027] \u003d _get_share_type_quota_values("},{"line_number":204,"context_line":"                p_quotas[\u0027share_replicas\u0027]"},{"line_number":205,"context_line":"            )"},{"line_number":206,"context_line":"            st_custom_quotas[\u0027replica_gigabtyes\u0027] \u003d ("},{"line_number":207,"context_line":"                get_share_type_quota_values(p_quotas[\u0027replica_gigabytes\u0027]))"},{"line_number":208,"context_line":"            replica_params \u003d (\u0027 --share-replicas %s \u0027"},{"line_number":209,"context_line":"                              \u0027--replica-gigabytes %s\u0027) % ("}],"source_content_type":"text/x-python","patch_set":8,"id":"df33271e_296d1a98","line":206,"range":{"start_line":206,"start_character":30,"end_line":206,"end_character":47},"in_reply_to":"df33271e_4697adec","updated":"2020-04-08 00:38:54.000000000","message":"Done","commit_id":"accf37a52449ed82c29c784a5f5347788603bbf5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"76a08a0b268ea07c09a64dcb318460b5994ddb01","unresolved":false,"context_lines":[{"line_number":204,"context_line":"                p_quotas[\u0027share_replicas\u0027]"},{"line_number":205,"context_line":"            )"},{"line_number":206,"context_line":"            st_custom_quotas[\u0027replica_gigabtyes\u0027] \u003d ("},{"line_number":207,"context_line":"                get_share_type_quota_values(p_quotas[\u0027replica_gigabytes\u0027]))"},{"line_number":208,"context_line":"            replica_params \u003d (\u0027 --share-replicas %s \u0027"},{"line_number":209,"context_line":"                              \u0027--replica-gigabytes %s\u0027) % ("},{"line_number":210,"context_line":"                st_custom_quotas[\u0027share_replicas\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"df33271e_a6831904","line":207,"range":{"start_line":207,"start_character":16,"end_line":207,"end_character":43},"updated":"2020-04-07 23:40:28.000000000","message":"_get_share_type_quota_values","commit_id":"accf37a52449ed82c29c784a5f5347788603bbf5"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5f0df1631cfa2741bd7cac7c26a21762a5db168f","unresolved":false,"context_lines":[{"line_number":204,"context_line":"                p_quotas[\u0027share_replicas\u0027]"},{"line_number":205,"context_line":"            )"},{"line_number":206,"context_line":"            st_custom_quotas[\u0027replica_gigabtyes\u0027] \u003d ("},{"line_number":207,"context_line":"                get_share_type_quota_values(p_quotas[\u0027replica_gigabytes\u0027]))"},{"line_number":208,"context_line":"            replica_params \u003d (\u0027 --share-replicas %s \u0027"},{"line_number":209,"context_line":"                              \u0027--replica-gigabytes %s\u0027) % ("},{"line_number":210,"context_line":"                st_custom_quotas[\u0027share_replicas\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"df33271e_e62361bd","line":207,"range":{"start_line":207,"start_character":16,"end_line":207,"end_character":43},"in_reply_to":"df33271e_a6831904","updated":"2020-04-08 00:13:28.000000000","message":"Done. Good catch, btw...","commit_id":"accf37a52449ed82c29c784a5f5347788603bbf5"}],"manilaclient/tests/unit/v2/test_quotas.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bb8fe1427697b248eeda5d6de1f0b2378f33edb7","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            \u0027share_networks\u0027: expected_body[\u0027quota_set\u0027][\u0027share_networks\u0027],"},{"line_number":163,"context_line":"            \u0027user_id\u0027: user_id,"},{"line_number":164,"context_line":"        }"},{"line_number":165,"context_line":"        if microversion \u003d\u003d \u00272.40\u0027:"},{"line_number":166,"context_line":"            expected_body[\u0027quota_set\u0027][\u0027share_groups\u0027] \u003d 6"},{"line_number":167,"context_line":"            expected_body[\u0027quota_set\u0027][\u0027share_group_snapshots\u0027] \u003d 7"},{"line_number":168,"context_line":"            kwargs[\u0027share_groups\u0027] \u003d expected_body[\u0027quota_set\u0027]["}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_52ab1ed5","line":165,"range":{"start_line":165,"start_character":24,"end_line":165,"end_character":27},"updated":"2020-03-24 07:27:29.000000000","message":"\u003e\u003d","commit_id":"435af76bafbe4a4d0e1a5f70c948a3aae8dd672f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"749f8ee6db6960ef8a7b5e3211e8f0909654a082","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            \u0027share_networks\u0027: expected_body[\u0027quota_set\u0027][\u0027share_networks\u0027],"},{"line_number":163,"context_line":"            \u0027user_id\u0027: user_id,"},{"line_number":164,"context_line":"        }"},{"line_number":165,"context_line":"        if microversion \u003d\u003d \u00272.40\u0027:"},{"line_number":166,"context_line":"            expected_body[\u0027quota_set\u0027][\u0027share_groups\u0027] \u003d 6"},{"line_number":167,"context_line":"            expected_body[\u0027quota_set\u0027][\u0027share_group_snapshots\u0027] \u003d 7"},{"line_number":168,"context_line":"            kwargs[\u0027share_groups\u0027] \u003d expected_body[\u0027quota_set\u0027]["}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_d8c0b57e","line":165,"range":{"start_line":165,"start_character":24,"end_line":165,"end_character":27},"in_reply_to":"df33271e_52ab1ed5","updated":"2020-03-26 21:04:30.000000000","message":"Done","commit_id":"435af76bafbe4a4d0e1a5f70c948a3aae8dd672f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bb8fe1427697b248eeda5d6de1f0b2378f33edb7","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                \u0027share_groups\u0027]"},{"line_number":170,"context_line":"            kwargs[\u0027share_group_snapshots\u0027] \u003d expected_body[\u0027quota_set\u0027]["},{"line_number":171,"context_line":"                \u0027share_group_snapshots\u0027]"},{"line_number":172,"context_line":"        if microversion \u003d\u003d REPLICA_QUOTAS_MICROVERSION:"},{"line_number":173,"context_line":"            expected_body[\u0027quota_set\u0027][\u0027share_replicas\u0027] \u003d 3"},{"line_number":174,"context_line":"            expected_body[\u0027quota_set\u0027][\u0027replica_gigabytes\u0027] \u003d 3"},{"line_number":175,"context_line":"            kwargs[\u0027share_replicas\u0027] \u003d expected_body[\u0027quota_set\u0027]["}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_b2b8aa2a","line":172,"range":{"start_line":172,"start_character":24,"end_line":172,"end_character":26},"updated":"2020-03-24 07:27:29.000000000","message":"\u003e\u003d","commit_id":"435af76bafbe4a4d0e1a5f70c948a3aae8dd672f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"749f8ee6db6960ef8a7b5e3211e8f0909654a082","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                \u0027share_groups\u0027]"},{"line_number":170,"context_line":"            kwargs[\u0027share_group_snapshots\u0027] \u003d expected_body[\u0027quota_set\u0027]["},{"line_number":171,"context_line":"                \u0027share_group_snapshots\u0027]"},{"line_number":172,"context_line":"        if microversion \u003d\u003d REPLICA_QUOTAS_MICROVERSION:"},{"line_number":173,"context_line":"            expected_body[\u0027quota_set\u0027][\u0027share_replicas\u0027] \u003d 3"},{"line_number":174,"context_line":"            expected_body[\u0027quota_set\u0027][\u0027replica_gigabytes\u0027] \u003d 3"},{"line_number":175,"context_line":"            kwargs[\u0027share_replicas\u0027] \u003d expected_body[\u0027quota_set\u0027]["}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_18385d9e","line":172,"range":{"start_line":172,"start_character":24,"end_line":172,"end_character":26},"in_reply_to":"df33271e_b2b8aa2a","updated":"2020-03-26 21:04:30.000000000","message":"Done","commit_id":"435af76bafbe4a4d0e1a5f70c948a3aae8dd672f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bb8fe1427697b248eeda5d6de1f0b2378f33edb7","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            },"},{"line_number":203,"context_line":"        }"},{"line_number":204,"context_line":"        kwargs \u003d {}"},{"line_number":205,"context_line":"        if microversion \u003d\u003d REPLICA_QUOTAS_MICROVERSION:"},{"line_number":206,"context_line":"            expected_body[\u0027quota_set\u0027][\u0027share_replicas\u0027] \u003d 3"},{"line_number":207,"context_line":"            expected_body[\u0027quota_set\u0027][\u0027replica_gigabytes\u0027] \u003d 3"},{"line_number":208,"context_line":"            kwargs \u003d {\u0027share_replicas\u0027: 3, \u0027replica_gigabytes\u0027: 3}"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_92b5a634","line":205,"range":{"start_line":205,"start_character":23,"end_line":205,"end_character":26},"updated":"2020-03-24 07:27:29.000000000","message":"\u003e\u003d","commit_id":"435af76bafbe4a4d0e1a5f70c948a3aae8dd672f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"749f8ee6db6960ef8a7b5e3211e8f0909654a082","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            },"},{"line_number":203,"context_line":"        }"},{"line_number":204,"context_line":"        kwargs \u003d {}"},{"line_number":205,"context_line":"        if microversion \u003d\u003d REPLICA_QUOTAS_MICROVERSION:"},{"line_number":206,"context_line":"            expected_body[\u0027quota_set\u0027][\u0027share_replicas\u0027] \u003d 3"},{"line_number":207,"context_line":"            expected_body[\u0027quota_set\u0027][\u0027replica_gigabytes\u0027] \u003d 3"},{"line_number":208,"context_line":"            kwargs \u003d {\u0027share_replicas\u0027: 3, \u0027replica_gigabytes\u0027: 3}"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_984bcd29","line":205,"range":{"start_line":205,"start_character":23,"end_line":205,"end_character":26},"in_reply_to":"df33271e_92b5a634","updated":"2020-03-26 21:04:30.000000000","message":"Done","commit_id":"435af76bafbe4a4d0e1a5f70c948a3aae8dd672f"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"77d4aa986c5cb5b130f5e21c30752d2b3961dd06","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        (\"2.7\", {}), (\"2.7\", {\"force\": True}),"},{"line_number":107,"context_line":"        (\"2.38\", {}), (\"2.38\", {\"force\": True}),"},{"line_number":108,"context_line":"        (\"2.39\", {}), (\"2.39\", {\"force\": True}),"},{"line_number":109,"context_line":"        (\"2.53\", {}), (\"2.53\", {\"force\": True, \"share_replicas\": 3,"},{"line_number":110,"context_line":"                                \"replica_gigabytes\": 3}),"},{"line_number":111,"context_line":"    )"},{"line_number":112,"context_line":"    @ddt.unpack"},{"line_number":113,"context_line":"    def test_update_quota(self, microversion, extra_data):"}],"source_content_type":"text/x-python","patch_set":8,"id":"df33271e_6662b118","line":110,"range":{"start_line":109,"start_character":0,"end_line":110,"end_character":57},"updated":"2020-04-08 00:19:07.000000000","message":"try to use a different value for each attr, this should be 8 and 9;","commit_id":"accf37a52449ed82c29c784a5f5347788603bbf5"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0515165c22f35ea690031c4ac17a80120c404759","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        (\"2.7\", {}), (\"2.7\", {\"force\": True}),"},{"line_number":107,"context_line":"        (\"2.38\", {}), (\"2.38\", {\"force\": True}),"},{"line_number":108,"context_line":"        (\"2.39\", {}), (\"2.39\", {\"force\": True}),"},{"line_number":109,"context_line":"        (\"2.53\", {}), (\"2.53\", {\"force\": True, \"share_replicas\": 3,"},{"line_number":110,"context_line":"                                \"replica_gigabytes\": 3}),"},{"line_number":111,"context_line":"    )"},{"line_number":112,"context_line":"    @ddt.unpack"},{"line_number":113,"context_line":"    def test_update_quota(self, microversion, extra_data):"}],"source_content_type":"text/x-python","patch_set":8,"id":"df33271e_4907beca","line":110,"range":{"start_line":109,"start_character":0,"end_line":110,"end_character":57},"in_reply_to":"df33271e_6662b118","updated":"2020-04-08 00:38:54.000000000","message":"Done","commit_id":"accf37a52449ed82c29c784a5f5347788603bbf5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"77d4aa986c5cb5b130f5e21c30752d2b3961dd06","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                \u0027share_group_snapshots\u0027]"},{"line_number":173,"context_line":"        if (api_versions.APIVersion(microversion) \u003e\u003d"},{"line_number":174,"context_line":"                api_versions.APIVersion(REPLICA_QUOTAS_MICROVERSION)):"},{"line_number":175,"context_line":"            expected_body[\u0027quota_set\u0027][\u0027share_replicas\u0027] \u003d 3"},{"line_number":176,"context_line":"            expected_body[\u0027quota_set\u0027][\u0027replica_gigabytes\u0027] \u003d 3"},{"line_number":177,"context_line":"            kwargs[\u0027share_replicas\u0027] \u003d expected_body[\u0027quota_set\u0027]["},{"line_number":178,"context_line":"                \u0027share_replicas\u0027]"},{"line_number":179,"context_line":"            kwargs[\u0027replica_gigabytes\u0027] \u003d expected_body[\u0027quota_set\u0027]["}],"source_content_type":"text/x-python","patch_set":8,"id":"df33271e_c6abbd1b","line":176,"range":{"start_line":175,"start_character":59,"end_line":176,"end_character":63},"updated":"2020-04-08 00:19:07.000000000","message":"try to use a different value for each attr, this should be 8 and 9;","commit_id":"accf37a52449ed82c29c784a5f5347788603bbf5"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0515165c22f35ea690031c4ac17a80120c404759","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                \u0027share_group_snapshots\u0027]"},{"line_number":173,"context_line":"        if (api_versions.APIVersion(microversion) \u003e\u003d"},{"line_number":174,"context_line":"                api_versions.APIVersion(REPLICA_QUOTAS_MICROVERSION)):"},{"line_number":175,"context_line":"            expected_body[\u0027quota_set\u0027][\u0027share_replicas\u0027] \u003d 3"},{"line_number":176,"context_line":"            expected_body[\u0027quota_set\u0027][\u0027replica_gigabytes\u0027] \u003d 3"},{"line_number":177,"context_line":"            kwargs[\u0027share_replicas\u0027] \u003d expected_body[\u0027quota_set\u0027]["},{"line_number":178,"context_line":"                \u0027share_replicas\u0027]"},{"line_number":179,"context_line":"            kwargs[\u0027replica_gigabytes\u0027] \u003d expected_body[\u0027quota_set\u0027]["}],"source_content_type":"text/x-python","patch_set":8,"id":"df33271e_a90e4ae2","line":176,"range":{"start_line":175,"start_character":59,"end_line":176,"end_character":63},"in_reply_to":"df33271e_c6abbd1b","updated":"2020-04-08 00:38:54.000000000","message":"Done","commit_id":"accf37a52449ed82c29c784a5f5347788603bbf5"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"77d4aa986c5cb5b130f5e21c30752d2b3961dd06","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        }"},{"line_number":206,"context_line":"        kwargs \u003d {}"},{"line_number":207,"context_line":"        if microversion \u003e\u003d REPLICA_QUOTAS_MICROVERSION:"},{"line_number":208,"context_line":"            expected_body[\u0027quota_set\u0027][\u0027share_replicas\u0027] \u003d 3"},{"line_number":209,"context_line":"            expected_body[\u0027quota_set\u0027][\u0027replica_gigabytes\u0027] \u003d 3"},{"line_number":210,"context_line":"            kwargs \u003d {\u0027share_replicas\u0027: 3, \u0027replica_gigabytes\u0027: 3}"},{"line_number":211,"context_line":"        with mock.patch.object(manager, \u0027_update\u0027,"},{"line_number":212,"context_line":"                               mock.Mock(return_value\u003d\u0027fake_update\u0027)):"},{"line_number":213,"context_line":"            manager.update("}],"source_content_type":"text/x-python","patch_set":8,"id":"df33271e_a66cb908","line":210,"range":{"start_line":208,"start_character":0,"end_line":210,"end_character":66},"updated":"2020-04-08 00:19:07.000000000","message":"same","commit_id":"accf37a52449ed82c29c784a5f5347788603bbf5"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0515165c22f35ea690031c4ac17a80120c404759","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        }"},{"line_number":206,"context_line":"        kwargs \u003d {}"},{"line_number":207,"context_line":"        if microversion \u003e\u003d REPLICA_QUOTAS_MICROVERSION:"},{"line_number":208,"context_line":"            expected_body[\u0027quota_set\u0027][\u0027share_replicas\u0027] \u003d 3"},{"line_number":209,"context_line":"            expected_body[\u0027quota_set\u0027][\u0027replica_gigabytes\u0027] \u003d 3"},{"line_number":210,"context_line":"            kwargs \u003d {\u0027share_replicas\u0027: 3, \u0027replica_gigabytes\u0027: 3}"},{"line_number":211,"context_line":"        with mock.patch.object(manager, \u0027_update\u0027,"},{"line_number":212,"context_line":"                               mock.Mock(return_value\u003d\u0027fake_update\u0027)):"},{"line_number":213,"context_line":"            manager.update("}],"source_content_type":"text/x-python","patch_set":8,"id":"df33271e_692d6245","line":210,"range":{"start_line":208,"start_character":0,"end_line":210,"end_character":66},"in_reply_to":"df33271e_a66cb908","updated":"2020-04-08 00:38:54.000000000","message":"Done","commit_id":"accf37a52449ed82c29c784a5f5347788603bbf5"}],"manilaclient/v2/quota_classes.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bb8fe1427697b248eeda5d6de1f0b2378f33edb7","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                \u0027snapshot_gigabytes\u0027: snapshot_gigabytes,"},{"line_number":65,"context_line":"                \u0027share_networks\u0027: share_networks,"},{"line_number":66,"context_line":"                \"share_replicas\": share_replicas"},{"line_number":67,"context_line":"            }"},{"line_number":68,"context_line":"        }"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        for key in list(body[\u0027quota_class_set\u0027]):"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_5294be8b","line":67,"range":{"start_line":67,"start_character":11,"end_line":67,"end_character":13},"updated":"2020-03-24 07:27:29.000000000","message":"replica_gigabytes","commit_id":"435af76bafbe4a4d0e1a5f70c948a3aae8dd672f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"749f8ee6db6960ef8a7b5e3211e8f0909654a082","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                \u0027snapshot_gigabytes\u0027: snapshot_gigabytes,"},{"line_number":65,"context_line":"                \u0027share_networks\u0027: share_networks,"},{"line_number":66,"context_line":"                \"share_replicas\": share_replicas"},{"line_number":67,"context_line":"            }"},{"line_number":68,"context_line":"        }"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        for key in list(body[\u0027quota_class_set\u0027]):"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_18617daa","line":67,"range":{"start_line":67,"start_character":11,"end_line":67,"end_character":13},"in_reply_to":"df33271e_5294be8b","updated":"2020-03-26 21:04:30.000000000","message":"Done","commit_id":"435af76bafbe4a4d0e1a5f70c948a3aae8dd672f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bb8fe1427697b248eeda5d6de1f0b2378f33edb7","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    @api_versions.wraps(REPLICA_QUOTAS_MICROVERSION)  # noqa"},{"line_number":95,"context_line":"    def update(self, class_name, shares\u003dNone, gigabytes\u003dNone,"},{"line_number":96,"context_line":"               snapshots\u003dNone, snapshot_gigabytes\u003dNone, share_networks\u003dNone,"},{"line_number":97,"context_line":"               share_replicas\u003dNone):"},{"line_number":98,"context_line":"        return self._do_update("},{"line_number":99,"context_line":"            class_name, shares, gigabytes, snapshots, snapshot_gigabytes,"},{"line_number":100,"context_line":"            share_networks, RESOURCE_PATH, share_replicas)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_12835655","line":97,"range":{"start_line":97,"start_character":15,"end_line":97,"end_character":36},"updated":"2020-03-24 07:27:29.000000000","message":"replica_gigabytes?","commit_id":"435af76bafbe4a4d0e1a5f70c948a3aae8dd672f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"749f8ee6db6960ef8a7b5e3211e8f0909654a082","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    @api_versions.wraps(REPLICA_QUOTAS_MICROVERSION)  # noqa"},{"line_number":95,"context_line":"    def update(self, class_name, shares\u003dNone, gigabytes\u003dNone,"},{"line_number":96,"context_line":"               snapshots\u003dNone, snapshot_gigabytes\u003dNone, share_networks\u003dNone,"},{"line_number":97,"context_line":"               share_replicas\u003dNone):"},{"line_number":98,"context_line":"        return self._do_update("},{"line_number":99,"context_line":"            class_name, shares, gigabytes, snapshots, snapshot_gigabytes,"},{"line_number":100,"context_line":"            share_networks, RESOURCE_PATH, share_replicas)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_385e01e6","line":97,"range":{"start_line":97,"start_character":15,"end_line":97,"end_character":36},"in_reply_to":"df33271e_12835655","updated":"2020-03-26 21:04:30.000000000","message":"Yep. Fixed.","commit_id":"435af76bafbe4a4d0e1a5f70c948a3aae8dd672f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e410147f8b5bf7ef3cd7d4b4be9e6942a9559f37","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    def _do_update(self, class_name, shares\u003dNone, gigabytes\u003dNone,"},{"line_number":55,"context_line":"                   snapshots\u003dNone, snapshot_gigabytes\u003dNone,"},{"line_number":56,"context_line":"                   share_networks\u003dNone, resource_path\u003dRESOURCE_PATH,"},{"line_number":57,"context_line":"                   share_replicas\u003dNone, replica_gigabytes\u003dNone):"},{"line_number":58,"context_line":"        body \u003d {"},{"line_number":59,"context_line":"            \u0027quota_class_set\u0027: {"},{"line_number":60,"context_line":"                \u0027class_name\u0027: class_name,"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_9cf2abe2","line":57,"range":{"start_line":57,"start_character":19,"end_line":57,"end_character":62},"updated":"2020-04-07 20:49:25.000000000","message":"consistency nit, keep resource_path at the end or at the very beginning and pass kwargs as kwargs...","commit_id":"852e5ea4c685091c97014380ff2337e7b4bf9b2b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"85b6d67dc11e94d1f53c3f5c392d8578df10128b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    def _do_update(self, class_name, shares\u003dNone, gigabytes\u003dNone,"},{"line_number":55,"context_line":"                   snapshots\u003dNone, snapshot_gigabytes\u003dNone,"},{"line_number":56,"context_line":"                   share_networks\u003dNone, resource_path\u003dRESOURCE_PATH,"},{"line_number":57,"context_line":"                   share_replicas\u003dNone, replica_gigabytes\u003dNone):"},{"line_number":58,"context_line":"        body \u003d {"},{"line_number":59,"context_line":"            \u0027quota_class_set\u0027: {"},{"line_number":60,"context_line":"                \u0027class_name\u0027: class_name,"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_b09eb304","line":57,"range":{"start_line":57,"start_character":19,"end_line":57,"end_character":62},"in_reply_to":"df33271e_9cf2abe2","updated":"2020-04-07 23:11:14.000000000","message":"Rather passing as kwargs, so I\u0027ve updated the other calls to this method as well.","commit_id":"852e5ea4c685091c97014380ff2337e7b4bf9b2b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e410147f8b5bf7ef3cd7d4b4be9e6942a9559f37","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            class_name, shares, gigabytes, snapshots, snapshot_gigabytes,"},{"line_number":86,"context_line":"            share_networks, RESOURCE_PATH_LEGACY)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    @api_versions.wraps(\"2.7\", \"2.51\")  # noqa"},{"line_number":89,"context_line":"    def update(self, class_name, shares\u003dNone, gigabytes\u003dNone,"},{"line_number":90,"context_line":"               snapshots\u003dNone, snapshot_gigabytes\u003dNone, share_networks\u003dNone):"},{"line_number":91,"context_line":"        return self._do_update("}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_fc6c979d","line":88,"range":{"start_line":88,"start_character":35,"end_line":88,"end_character":36},"updated":"2020-04-07 20:49:25.000000000","message":"2","commit_id":"852e5ea4c685091c97014380ff2337e7b4bf9b2b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"85b6d67dc11e94d1f53c3f5c392d8578df10128b","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            class_name, shares, gigabytes, snapshots, snapshot_gigabytes,"},{"line_number":86,"context_line":"            share_networks, RESOURCE_PATH_LEGACY)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    @api_versions.wraps(\"2.7\", \"2.51\")  # noqa"},{"line_number":89,"context_line":"    def update(self, class_name, shares\u003dNone, gigabytes\u003dNone,"},{"line_number":90,"context_line":"               snapshots\u003dNone, snapshot_gigabytes\u003dNone, share_networks\u003dNone):"},{"line_number":91,"context_line":"        return self._do_update("}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_90a1ef49","line":88,"range":{"start_line":88,"start_character":35,"end_line":88,"end_character":36},"in_reply_to":"df33271e_fc6c979d","updated":"2020-04-07 23:11:14.000000000","message":"Done","commit_id":"852e5ea4c685091c97014380ff2337e7b4bf9b2b"}],"manilaclient/v2/quotas.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e410147f8b5bf7ef3cd7d4b4be9e6942a9559f37","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            resource_path\u003dRESOURCE_PATH,"},{"line_number":168,"context_line":"        )"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    @api_versions.wraps(\"2.40\", \"2.51\")  # noqa"},{"line_number":171,"context_line":"    def update(self, tenant_id, user_id\u003dNone, share_type\u003dNone,"},{"line_number":172,"context_line":"               shares\u003dNone, snapshots\u003dNone, gigabytes\u003dNone,"},{"line_number":173,"context_line":"               snapshot_gigabytes\u003dNone, share_networks\u003dNone,"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_7c27e765","line":170,"range":{"start_line":170,"start_character":33,"end_line":170,"end_character":37},"updated":"2020-04-07 20:49:25.000000000","message":"2.52","commit_id":"852e5ea4c685091c97014380ff2337e7b4bf9b2b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"85b6d67dc11e94d1f53c3f5c392d8578df10128b","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            resource_path\u003dRESOURCE_PATH,"},{"line_number":168,"context_line":"        )"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    @api_versions.wraps(\"2.40\", \"2.51\")  # noqa"},{"line_number":171,"context_line":"    def update(self, tenant_id, user_id\u003dNone, share_type\u003dNone,"},{"line_number":172,"context_line":"               shares\u003dNone, snapshots\u003dNone, gigabytes\u003dNone,"},{"line_number":173,"context_line":"               snapshot_gigabytes\u003dNone, share_networks\u003dNone,"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_70bd4b67","line":170,"range":{"start_line":170,"start_character":33,"end_line":170,"end_character":37},"in_reply_to":"df33271e_7c27e765","updated":"2020-04-07 23:11:14.000000000","message":"Done","commit_id":"852e5ea4c685091c97014380ff2337e7b4bf9b2b"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bb8fe1427697b248eeda5d6de1f0b2378f33edb7","unresolved":false,"context_lines":[{"line_number":402,"context_line":"        if val is not None:"},{"line_number":403,"context_line":"            updates[resource] \u003d val"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"    if updates:"},{"line_number":406,"context_line":"        # default value of force is None to make sure this client"},{"line_number":407,"context_line":"        # will be compatible with old nova server"},{"line_number":408,"context_line":"        force_update \u003d getattr(args, \u0027force\u0027, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_12d19655","line":405,"range":{"start_line":405,"start_character":4,"end_line":405,"end_character":15},"updated":"2020-03-24 07:27:29.000000000","message":"updates should disallow replicas and replica_gigabytes for API version \u003c\u003d2.51","commit_id":"435af76bafbe4a4d0e1a5f70c948a3aae8dd672f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"749f8ee6db6960ef8a7b5e3211e8f0909654a082","unresolved":false,"context_lines":[{"line_number":402,"context_line":"        if val is not None:"},{"line_number":403,"context_line":"            updates[resource] \u003d val"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"    if updates:"},{"line_number":406,"context_line":"        # default value of force is None to make sure this client"},{"line_number":407,"context_line":"        # will be compatible with old nova server"},{"line_number":408,"context_line":"        force_update \u003d getattr(args, \u0027force\u0027, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_f83139a4","line":405,"range":{"start_line":405,"start_character":4,"end_line":405,"end_character":15},"in_reply_to":"df33271e_12d19655","updated":"2020-03-26 21:04:30.000000000","message":"Done","commit_id":"435af76bafbe4a4d0e1a5f70c948a3aae8dd672f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bb8fe1427697b248eeda5d6de1f0b2378f33edb7","unresolved":false,"context_lines":[{"line_number":540,"context_line":"         \"Available only for microversion \u003e\u003d 2.39\")"},{"line_number":541,"context_line":"@cliutils.arg("},{"line_number":542,"context_line":"    \u0027--share-replicas\u0027,"},{"line_number":543,"context_line":"    \u0027--share_replicas\u0027,"},{"line_number":544,"context_line":"    metavar\u003d\u0027\u003cshare-replicas\u003e\u0027,"},{"line_number":545,"context_line":"    type\u003dint,"},{"line_number":546,"context_line":"    default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_d2ed6e26","line":543,"range":{"start_line":543,"start_character":4,"end_line":543,"end_character":23},"updated":"2020-03-24 07:27:29.000000000","message":"also add \u0027--replicas\u0027","commit_id":"435af76bafbe4a4d0e1a5f70c948a3aae8dd672f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"749f8ee6db6960ef8a7b5e3211e8f0909654a082","unresolved":false,"context_lines":[{"line_number":540,"context_line":"         \"Available only for microversion \u003e\u003d 2.39\")"},{"line_number":541,"context_line":"@cliutils.arg("},{"line_number":542,"context_line":"    \u0027--share-replicas\u0027,"},{"line_number":543,"context_line":"    \u0027--share_replicas\u0027,"},{"line_number":544,"context_line":"    metavar\u003d\u0027\u003cshare-replicas\u003e\u0027,"},{"line_number":545,"context_line":"    type\u003dint,"},{"line_number":546,"context_line":"    default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_781d290e","line":543,"range":{"start_line":543,"start_character":4,"end_line":543,"end_character":23},"in_reply_to":"df33271e_d2ed6e26","updated":"2020-03-26 21:04:30.000000000","message":"Done","commit_id":"435af76bafbe4a4d0e1a5f70c948a3aae8dd672f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6c4213c30a0201dfd0df1ce0cd62e1fcd2801183","unresolved":false,"context_lines":[{"line_number":591,"context_line":"                \"\u0027snapshots\u0027 and \u0027snapshot_gigabytes\u0027 resources.\")"},{"line_number":592,"context_line":"        kwargs[\"share_groups\"] \u003d args.share_groups"},{"line_number":593,"context_line":"        kwargs[\"share_group_snapshots\"] \u003d args.share_group_snapshots"},{"line_number":594,"context_line":"    if args.share_replicas is not None:"},{"line_number":595,"context_line":"        if cs.api_version \u003c api_versions.APIVersion(\"2.52\"):"},{"line_number":596,"context_line":"            raise exceptions.CommandError("},{"line_number":597,"context_line":"                \"\u0027share replica\u0027 quotas are available only starting with \""},{"line_number":598,"context_line":"                \"\u00272.52\u0027 API microversion.\")"},{"line_number":599,"context_line":"        kwargs[\"share_replicas\"] \u003d args.share_replicas"},{"line_number":600,"context_line":"    if args.replica_gigabytes is not None:"},{"line_number":601,"context_line":"        if cs.api_version \u003c api_versions.APIVersion(\"2.52\"):"},{"line_number":602,"context_line":"            raise exceptions.CommandError("},{"line_number":603,"context_line":"                \"\u0027share replica gigabyte\u0027 quotas are available only starting \""},{"line_number":604,"context_line":"                \"with \u00272.52\u0027 API microversion.\")"},{"line_number":605,"context_line":"        kwargs[\"replica_gigabytes\"] \u003d args.replica_gigabytes"},{"line_number":606,"context_line":"    cs.quotas.update(**kwargs)"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_724aa227","line":605,"range":{"start_line":594,"start_character":0,"end_line":605,"end_character":60},"updated":"2020-03-24 07:30:27.000000000","message":"nit: missing unit test coverage: https://36a0c3cfabc8993b50c1-7065da08ff379150c9ba36e9e5cc82fd.ssl.cf5.rackcdn.com/712677/2/check/openstack-tox-cover/8a076e3/cover/manilaclient_v2_shell_py.html#t594","commit_id":"435af76bafbe4a4d0e1a5f70c948a3aae8dd672f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"749f8ee6db6960ef8a7b5e3211e8f0909654a082","unresolved":false,"context_lines":[{"line_number":591,"context_line":"                \"\u0027snapshots\u0027 and \u0027snapshot_gigabytes\u0027 resources.\")"},{"line_number":592,"context_line":"        kwargs[\"share_groups\"] \u003d args.share_groups"},{"line_number":593,"context_line":"        kwargs[\"share_group_snapshots\"] \u003d args.share_group_snapshots"},{"line_number":594,"context_line":"    if args.share_replicas is not None:"},{"line_number":595,"context_line":"        if cs.api_version \u003c api_versions.APIVersion(\"2.52\"):"},{"line_number":596,"context_line":"            raise exceptions.CommandError("},{"line_number":597,"context_line":"                \"\u0027share replica\u0027 quotas are available only starting with \""},{"line_number":598,"context_line":"                \"\u00272.52\u0027 API microversion.\")"},{"line_number":599,"context_line":"        kwargs[\"share_replicas\"] \u003d args.share_replicas"},{"line_number":600,"context_line":"    if args.replica_gigabytes is not None:"},{"line_number":601,"context_line":"        if cs.api_version \u003c api_versions.APIVersion(\"2.52\"):"},{"line_number":602,"context_line":"            raise exceptions.CommandError("},{"line_number":603,"context_line":"                \"\u0027share replica gigabyte\u0027 quotas are available only starting \""},{"line_number":604,"context_line":"                \"with \u00272.52\u0027 API microversion.\")"},{"line_number":605,"context_line":"        kwargs[\"replica_gigabytes\"] \u003d args.replica_gigabytes"},{"line_number":606,"context_line":"    cs.quotas.update(**kwargs)"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_788409b2","line":605,"range":{"start_line":594,"start_character":0,"end_line":605,"end_character":60},"in_reply_to":"df33271e_724aa227","updated":"2020-03-26 21:04:30.000000000","message":"Done","commit_id":"435af76bafbe4a4d0e1a5f70c948a3aae8dd672f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bb8fe1427697b248eeda5d6de1f0b2378f33edb7","unresolved":false,"context_lines":[{"line_number":696,"context_line":"    help\u003d\u0027New value for the \"share_networks\" quota.\u0027)"},{"line_number":697,"context_line":"@cliutils.arg("},{"line_number":698,"context_line":"    \u0027--share-replicas\u0027,"},{"line_number":699,"context_line":"    \u0027--share_replicas\u0027,  # alias"},{"line_number":700,"context_line":"    metavar\u003d\u0027\u003cshare-replicas\u003e\u0027,"},{"line_number":701,"context_line":"    type\u003dint,"},{"line_number":702,"context_line":"    default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_92e3e633","line":699,"range":{"start_line":699,"start_character":4,"end_line":699,"end_character":23},"updated":"2020-03-24 07:27:29.000000000","message":"also add \u0027--replicas\u0027","commit_id":"435af76bafbe4a4d0e1a5f70c948a3aae8dd672f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"749f8ee6db6960ef8a7b5e3211e8f0909654a082","unresolved":false,"context_lines":[{"line_number":696,"context_line":"    help\u003d\u0027New value for the \"share_networks\" quota.\u0027)"},{"line_number":697,"context_line":"@cliutils.arg("},{"line_number":698,"context_line":"    \u0027--share-replicas\u0027,"},{"line_number":699,"context_line":"    \u0027--share_replicas\u0027,  # alias"},{"line_number":700,"context_line":"    metavar\u003d\u0027\u003cshare-replicas\u003e\u0027,"},{"line_number":701,"context_line":"    type\u003dint,"},{"line_number":702,"context_line":"    default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_b817b1ed","line":699,"range":{"start_line":699,"start_character":4,"end_line":699,"end_character":23},"in_reply_to":"df33271e_92e3e633","updated":"2020-03-26 21:04:30.000000000","message":"Done","commit_id":"435af76bafbe4a4d0e1a5f70c948a3aae8dd672f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"45ad8801d2c66cb787d4f03126481597f31a2832","unresolved":false,"context_lines":[{"line_number":391,"context_line":"    \u0027gigabytes\u0027,"},{"line_number":392,"context_line":"    \u0027snapshot_gigabytes\u0027,"},{"line_number":393,"context_line":"    \u0027share_networks\u0027,"},{"line_number":394,"context_line":"]"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"def _quota_update(manager, identifier, args):"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_41ef9c86","line":394,"range":{"start_line":394,"start_character":0,"end_line":394,"end_character":1},"updated":"2020-04-07 20:42:00.000000000","message":"do include the new quotas here, in case this gets reused elsewhere","commit_id":"852e5ea4c685091c97014380ff2337e7b4bf9b2b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"85b6d67dc11e94d1f53c3f5c392d8578df10128b","unresolved":false,"context_lines":[{"line_number":391,"context_line":"    \u0027gigabytes\u0027,"},{"line_number":392,"context_line":"    \u0027snapshot_gigabytes\u0027,"},{"line_number":393,"context_line":"    \u0027share_networks\u0027,"},{"line_number":394,"context_line":"]"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"def _quota_update(manager, identifier, args):"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_90ad6f9d","line":394,"range":{"start_line":394,"start_character":0,"end_line":394,"end_character":1},"in_reply_to":"df33271e_41ef9c86","updated":"2020-04-07 23:11:14.000000000","message":"Done","commit_id":"852e5ea4c685091c97014380ff2337e7b4bf9b2b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"45ad8801d2c66cb787d4f03126481597f31a2832","unresolved":false,"context_lines":[{"line_number":394,"context_line":"]"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"def _quota_update(manager, identifier, args):"},{"line_number":398,"context_line":"    updates \u003d {}"},{"line_number":399,"context_line":"    for resource in _quota_resources:"},{"line_number":400,"context_line":"        val \u003d getattr(args, resource, None)"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_7ca40709","line":397,"range":{"start_line":397,"start_character":4,"end_line":397,"end_character":17},"updated":"2020-04-07 20:42:00.000000000","message":"this really is _quota_class_update","commit_id":"852e5ea4c685091c97014380ff2337e7b4bf9b2b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"85b6d67dc11e94d1f53c3f5c392d8578df10128b","unresolved":false,"context_lines":[{"line_number":394,"context_line":"]"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"def _quota_update(manager, identifier, args):"},{"line_number":398,"context_line":"    updates \u003d {}"},{"line_number":399,"context_line":"    for resource in _quota_resources:"},{"line_number":400,"context_line":"        val \u003d getattr(args, resource, None)"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_9c82aba4","line":397,"range":{"start_line":397,"start_character":4,"end_line":397,"end_character":17},"in_reply_to":"df33271e_7ca40709","updated":"2020-04-07 23:11:14.000000000","message":"Done","commit_id":"852e5ea4c685091c97014380ff2337e7b4bf9b2b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"45ad8801d2c66cb787d4f03126481597f31a2832","unresolved":false,"context_lines":[{"line_number":403,"context_line":""},{"line_number":404,"context_line":"    if updates:"},{"line_number":405,"context_line":"        # default value of force is None to make sure this client"},{"line_number":406,"context_line":"        # will be compatible with old nova server"},{"line_number":407,"context_line":"        force_update \u003d getattr(args, \u0027force\u0027, None)"},{"line_number":408,"context_line":"        user_id \u003d getattr(args, \u0027user\u0027, None)"},{"line_number":409,"context_line":"        if isinstance(manager, quotas.QuotaSetManager):"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_81e9a481","line":406,"range":{"start_line":406,"start_character":34,"end_line":406,"end_character":49},"updated":"2020-04-07 20:42:00.000000000","message":"heh","commit_id":"852e5ea4c685091c97014380ff2337e7b4bf9b2b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"85b6d67dc11e94d1f53c3f5c392d8578df10128b","unresolved":false,"context_lines":[{"line_number":403,"context_line":""},{"line_number":404,"context_line":"    if updates:"},{"line_number":405,"context_line":"        # default value of force is None to make sure this client"},{"line_number":406,"context_line":"        # will be compatible with old nova server"},{"line_number":407,"context_line":"        force_update \u003d getattr(args, \u0027force\u0027, None)"},{"line_number":408,"context_line":"        user_id \u003d getattr(args, \u0027user\u0027, None)"},{"line_number":409,"context_line":"        if isinstance(manager, quotas.QuotaSetManager):"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_90b8cfe5","line":406,"range":{"start_line":406,"start_character":34,"end_line":406,"end_character":49},"in_reply_to":"df33271e_81e9a481","updated":"2020-04-07 23:11:14.000000000","message":"Done","commit_id":"852e5ea4c685091c97014380ff2337e7b4bf9b2b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"45ad8801d2c66cb787d4f03126481597f31a2832","unresolved":false,"context_lines":[{"line_number":404,"context_line":"    if updates:"},{"line_number":405,"context_line":"        # default value of force is None to make sure this client"},{"line_number":406,"context_line":"        # will be compatible with old nova server"},{"line_number":407,"context_line":"        force_update \u003d getattr(args, \u0027force\u0027, None)"},{"line_number":408,"context_line":"        user_id \u003d getattr(args, \u0027user\u0027, None)"},{"line_number":409,"context_line":"        if isinstance(manager, quotas.QuotaSetManager):"},{"line_number":410,"context_line":"            manager.update(identifier, force\u003dforce_update, user_id\u003duser_id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_41bddc66","line":407,"range":{"start_line":407,"start_character":8,"end_line":407,"end_character":51},"updated":"2020-04-07 20:42:00.000000000","message":"can\u0027t really force update a quota class... this is just dead code","commit_id":"852e5ea4c685091c97014380ff2337e7b4bf9b2b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"85b6d67dc11e94d1f53c3f5c392d8578df10128b","unresolved":false,"context_lines":[{"line_number":404,"context_line":"    if updates:"},{"line_number":405,"context_line":"        # default value of force is None to make sure this client"},{"line_number":406,"context_line":"        # will be compatible with old nova server"},{"line_number":407,"context_line":"        force_update \u003d getattr(args, \u0027force\u0027, None)"},{"line_number":408,"context_line":"        user_id \u003d getattr(args, \u0027user\u0027, None)"},{"line_number":409,"context_line":"        if isinstance(manager, quotas.QuotaSetManager):"},{"line_number":410,"context_line":"            manager.update(identifier, force\u003dforce_update, user_id\u003duser_id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_50be47d4","line":407,"range":{"start_line":407,"start_character":8,"end_line":407,"end_character":51},"in_reply_to":"df33271e_41bddc66","updated":"2020-04-07 23:11:14.000000000","message":"Done","commit_id":"852e5ea4c685091c97014380ff2337e7b4bf9b2b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"45ad8801d2c66cb787d4f03126481597f31a2832","unresolved":false,"context_lines":[{"line_number":405,"context_line":"        # default value of force is None to make sure this client"},{"line_number":406,"context_line":"        # will be compatible with old nova server"},{"line_number":407,"context_line":"        force_update \u003d getattr(args, \u0027force\u0027, None)"},{"line_number":408,"context_line":"        user_id \u003d getattr(args, \u0027user\u0027, None)"},{"line_number":409,"context_line":"        if isinstance(manager, quotas.QuotaSetManager):"},{"line_number":410,"context_line":"            manager.update(identifier, force\u003dforce_update, user_id\u003duser_id,"},{"line_number":411,"context_line":"                           **updates)"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_21c098e0","line":408,"range":{"start_line":408,"start_character":8,"end_line":408,"end_character":45},"updated":"2020-04-07 20:42:00.000000000","message":"can\u0027t update a quota class for user_id either","commit_id":"852e5ea4c685091c97014380ff2337e7b4bf9b2b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"85b6d67dc11e94d1f53c3f5c392d8578df10128b","unresolved":false,"context_lines":[{"line_number":405,"context_line":"        # default value of force is None to make sure this client"},{"line_number":406,"context_line":"        # will be compatible with old nova server"},{"line_number":407,"context_line":"        force_update \u003d getattr(args, \u0027force\u0027, None)"},{"line_number":408,"context_line":"        user_id \u003d getattr(args, \u0027user\u0027, None)"},{"line_number":409,"context_line":"        if isinstance(manager, quotas.QuotaSetManager):"},{"line_number":410,"context_line":"            manager.update(identifier, force\u003dforce_update, user_id\u003duser_id,"},{"line_number":411,"context_line":"                           **updates)"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_50a3e7b1","line":408,"range":{"start_line":408,"start_character":8,"end_line":408,"end_character":45},"in_reply_to":"df33271e_21c098e0","updated":"2020-04-07 23:11:14.000000000","message":"Done","commit_id":"852e5ea4c685091c97014380ff2337e7b4bf9b2b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"45ad8801d2c66cb787d4f03126481597f31a2832","unresolved":false,"context_lines":[{"line_number":406,"context_line":"        # will be compatible with old nova server"},{"line_number":407,"context_line":"        force_update \u003d getattr(args, \u0027force\u0027, None)"},{"line_number":408,"context_line":"        user_id \u003d getattr(args, \u0027user\u0027, None)"},{"line_number":409,"context_line":"        if isinstance(manager, quotas.QuotaSetManager):"},{"line_number":410,"context_line":"            manager.update(identifier, force\u003dforce_update, user_id\u003duser_id,"},{"line_number":411,"context_line":"                           **updates)"},{"line_number":412,"context_line":"        else:"},{"line_number":413,"context_line":"            manager.update(identifier, **updates)"},{"line_number":414,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_81b7e486","line":411,"range":{"start_line":409,"start_character":8,"end_line":411,"end_character":37},"updated":"2020-04-07 20:42:00.000000000","message":"this code is unused, and can be dropped","commit_id":"852e5ea4c685091c97014380ff2337e7b4bf9b2b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"85b6d67dc11e94d1f53c3f5c392d8578df10128b","unresolved":false,"context_lines":[{"line_number":406,"context_line":"        # will be compatible with old nova server"},{"line_number":407,"context_line":"        force_update \u003d getattr(args, \u0027force\u0027, None)"},{"line_number":408,"context_line":"        user_id \u003d getattr(args, \u0027user\u0027, None)"},{"line_number":409,"context_line":"        if isinstance(manager, quotas.QuotaSetManager):"},{"line_number":410,"context_line":"            manager.update(identifier, force\u003dforce_update, user_id\u003duser_id,"},{"line_number":411,"context_line":"                           **updates)"},{"line_number":412,"context_line":"        else:"},{"line_number":413,"context_line":"            manager.update(identifier, **updates)"},{"line_number":414,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_b0aa3382","line":411,"range":{"start_line":409,"start_character":8,"end_line":411,"end_character":37},"in_reply_to":"df33271e_81b7e486","updated":"2020-04-07 23:11:14.000000000","message":"Done","commit_id":"852e5ea4c685091c97014380ff2337e7b4bf9b2b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e410147f8b5bf7ef3cd7d4b4be9e6942a9559f37","unresolved":false,"context_lines":[{"line_number":591,"context_line":"                \"\u0027snapshots\u0027 and \u0027snapshot_gigabytes\u0027 resources.\")"},{"line_number":592,"context_line":"        kwargs[\"share_groups\"] \u003d args.share_groups"},{"line_number":593,"context_line":"        kwargs[\"share_group_snapshots\"] \u003d args.share_group_snapshots"},{"line_number":594,"context_line":"    if args.share_replicas is not None:"},{"line_number":595,"context_line":"        if cs.api_version \u003c api_versions.APIVersion(\"2.53\"):"},{"line_number":596,"context_line":"            raise exceptions.CommandError("},{"line_number":597,"context_line":"                \"\u0027share replica\u0027 quotas are available only starting with \""},{"line_number":598,"context_line":"                \"\u00272.53\u0027 API microversion.\")"},{"line_number":599,"context_line":"        kwargs[\"share_replicas\"] \u003d args.share_replicas"},{"line_number":600,"context_line":"    if args.replica_gigabytes is not None:"},{"line_number":601,"context_line":"        if cs.api_version \u003c api_versions.APIVersion(\"2.53\"):"},{"line_number":602,"context_line":"            raise exceptions.CommandError("},{"line_number":603,"context_line":"                \"\u0027share replica gigabyte\u0027 quotas are available only starting \""},{"line_number":604,"context_line":"                \"with \u00272.53\u0027 API microversion.\")"},{"line_number":605,"context_line":"        kwargs[\"replica_gigabytes\"] \u003d args.replica_gigabytes"},{"line_number":606,"context_line":"    cs.quotas.update(**kwargs)"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_bcce8f80","line":605,"range":{"start_line":594,"start_character":4,"end_line":605,"end_character":60},"updated":"2020-04-07 20:49:25.000000000","message":"please combine these error checks, like the ones for share group quotas on line 583..","commit_id":"852e5ea4c685091c97014380ff2337e7b4bf9b2b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"85b6d67dc11e94d1f53c3f5c392d8578df10128b","unresolved":false,"context_lines":[{"line_number":591,"context_line":"                \"\u0027snapshots\u0027 and \u0027snapshot_gigabytes\u0027 resources.\")"},{"line_number":592,"context_line":"        kwargs[\"share_groups\"] \u003d args.share_groups"},{"line_number":593,"context_line":"        kwargs[\"share_group_snapshots\"] \u003d args.share_group_snapshots"},{"line_number":594,"context_line":"    if args.share_replicas is not None:"},{"line_number":595,"context_line":"        if cs.api_version \u003c api_versions.APIVersion(\"2.53\"):"},{"line_number":596,"context_line":"            raise exceptions.CommandError("},{"line_number":597,"context_line":"                \"\u0027share replica\u0027 quotas are available only starting with \""},{"line_number":598,"context_line":"                \"\u00272.53\u0027 API microversion.\")"},{"line_number":599,"context_line":"        kwargs[\"share_replicas\"] \u003d args.share_replicas"},{"line_number":600,"context_line":"    if args.replica_gigabytes is not None:"},{"line_number":601,"context_line":"        if cs.api_version \u003c api_versions.APIVersion(\"2.53\"):"},{"line_number":602,"context_line":"            raise exceptions.CommandError("},{"line_number":603,"context_line":"                \"\u0027share replica gigabyte\u0027 quotas are available only starting \""},{"line_number":604,"context_line":"                \"with \u00272.53\u0027 API microversion.\")"},{"line_number":605,"context_line":"        kwargs[\"replica_gigabytes\"] \u003d args.replica_gigabytes"},{"line_number":606,"context_line":"    cs.quotas.update(**kwargs)"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_dc49d3b7","line":605,"range":{"start_line":594,"start_character":4,"end_line":605,"end_character":60},"in_reply_to":"df33271e_bcce8f80","updated":"2020-04-07 23:11:14.000000000","message":"Done","commit_id":"852e5ea4c685091c97014380ff2337e7b4bf9b2b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"45ad8801d2c66cb787d4f03126481597f31a2832","unresolved":false,"context_lines":[{"line_number":702,"context_line":"    type\u003dint,"},{"line_number":703,"context_line":"    default\u003dNone,"},{"line_number":704,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":705,"context_line":"    help\u003d\u0027New value for the \"share_replicas\" quota.\u0027)"},{"line_number":706,"context_line":"@cliutils.arg("},{"line_number":707,"context_line":"    \u0027--replica-gigabytes\u0027,"},{"line_number":708,"context_line":"    \u0027--replica_gigabytes\u0027,  # alias"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_6102a071","line":705,"range":{"start_line":705,"start_character":0,"end_line":705,"end_character":53},"updated":"2020-04-07 20:42:00.000000000","message":"Available only for microversion \u003e\u003d 2.53","commit_id":"852e5ea4c685091c97014380ff2337e7b4bf9b2b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"85b6d67dc11e94d1f53c3f5c392d8578df10128b","unresolved":false,"context_lines":[{"line_number":702,"context_line":"    type\u003dint,"},{"line_number":703,"context_line":"    default\u003dNone,"},{"line_number":704,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":705,"context_line":"    help\u003d\u0027New value for the \"share_replicas\" quota.\u0027)"},{"line_number":706,"context_line":"@cliutils.arg("},{"line_number":707,"context_line":"    \u0027--replica-gigabytes\u0027,"},{"line_number":708,"context_line":"    \u0027--replica_gigabytes\u0027,  # alias"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_fce3f7a2","line":705,"range":{"start_line":705,"start_character":0,"end_line":705,"end_character":53},"in_reply_to":"df33271e_6102a071","updated":"2020-04-07 23:11:14.000000000","message":"Done","commit_id":"852e5ea4c685091c97014380ff2337e7b4bf9b2b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"45ad8801d2c66cb787d4f03126481597f31a2832","unresolved":false,"context_lines":[{"line_number":710,"context_line":"    type\u003dint,"},{"line_number":711,"context_line":"    default\u003dNone,"},{"line_number":712,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":713,"context_line":"    help\u003d\u0027New value for the \"replica_gigabytes\" quota.\u0027)"},{"line_number":714,"context_line":"def do_quota_class_update(cs, args):"},{"line_number":715,"context_line":"    \"\"\"Update the quotas for a quota class (Admin only).\"\"\""},{"line_number":716,"context_line":"    if args.share_replicas is not None:"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_81ffe465","line":713,"range":{"start_line":713,"start_character":0,"end_line":713,"end_character":56},"updated":"2020-04-07 20:42:00.000000000","message":"Available only for microversion \u003e\u003d 2.53","commit_id":"852e5ea4c685091c97014380ff2337e7b4bf9b2b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"85b6d67dc11e94d1f53c3f5c392d8578df10128b","unresolved":false,"context_lines":[{"line_number":710,"context_line":"    type\u003dint,"},{"line_number":711,"context_line":"    default\u003dNone,"},{"line_number":712,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":713,"context_line":"    help\u003d\u0027New value for the \"replica_gigabytes\" quota.\u0027)"},{"line_number":714,"context_line":"def do_quota_class_update(cs, args):"},{"line_number":715,"context_line":"    \"\"\"Update the quotas for a quota class (Admin only).\"\"\""},{"line_number":716,"context_line":"    if args.share_replicas is not None:"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_dcdef3d8","line":713,"range":{"start_line":713,"start_character":0,"end_line":713,"end_character":56},"in_reply_to":"df33271e_81ffe465","updated":"2020-04-07 23:11:14.000000000","message":"Done","commit_id":"852e5ea4c685091c97014380ff2337e7b4bf9b2b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"45ad8801d2c66cb787d4f03126481597f31a2832","unresolved":false,"context_lines":[{"line_number":713,"context_line":"    help\u003d\u0027New value for the \"replica_gigabytes\" quota.\u0027)"},{"line_number":714,"context_line":"def do_quota_class_update(cs, args):"},{"line_number":715,"context_line":"    \"\"\"Update the quotas for a quota class (Admin only).\"\"\""},{"line_number":716,"context_line":"    if args.share_replicas is not None:"},{"line_number":717,"context_line":"        if cs.api_version \u003c api_versions.APIVersion(\"2.53\"):"},{"line_number":718,"context_line":"            raise exceptions.CommandError("},{"line_number":719,"context_line":"                \"\u0027share replica\u0027 quotas are available only starting with \""},{"line_number":720,"context_line":"                \"\u00272.53\u0027 API microversion.\")"},{"line_number":721,"context_line":"        _quota_resources.append(\u0027share_replicas\u0027)"},{"line_number":722,"context_line":"    if args.replica_gigabytes is not None:"},{"line_number":723,"context_line":"        if cs.api_version \u003c api_versions.APIVersion(\"2.53\"):"},{"line_number":724,"context_line":"            raise exceptions.CommandError("},{"line_number":725,"context_line":"                \"\u0027share replica gigabyte\u0027 quotas are available only starting \""},{"line_number":726,"context_line":"                \"with \u00272.53\u0027 API microversion.\")"},{"line_number":727,"context_line":"        _quota_resources.append(\u0027replica_gigabytes\u0027)"},{"line_number":728,"context_line":""},{"line_number":729,"context_line":"    _quota_update(cs.quota_classes, args.class_name, args)"},{"line_number":730,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_dc5d5316","line":727,"range":{"start_line":716,"start_character":4,"end_line":727,"end_character":52},"updated":"2020-04-07 20:42:00.000000000","message":"since both are introduced in the same Microversion, you can combine and simplify this... The error message can be \"\u0027share replica quotas are only available starting with API version 2.53\"\n\nIt makes for better user experience too, if someone decides to use:\n\n manila quota-class-update default --replicas 20 and --replica-gigabytes 100\n\nAs it is currently written, you\u0027ll see only the first error message","commit_id":"852e5ea4c685091c97014380ff2337e7b4bf9b2b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"85b6d67dc11e94d1f53c3f5c392d8578df10128b","unresolved":false,"context_lines":[{"line_number":713,"context_line":"    help\u003d\u0027New value for the \"replica_gigabytes\" quota.\u0027)"},{"line_number":714,"context_line":"def do_quota_class_update(cs, args):"},{"line_number":715,"context_line":"    \"\"\"Update the quotas for a quota class (Admin only).\"\"\""},{"line_number":716,"context_line":"    if args.share_replicas is not None:"},{"line_number":717,"context_line":"        if cs.api_version \u003c api_versions.APIVersion(\"2.53\"):"},{"line_number":718,"context_line":"            raise exceptions.CommandError("},{"line_number":719,"context_line":"                \"\u0027share replica\u0027 quotas are available only starting with \""},{"line_number":720,"context_line":"                \"\u00272.53\u0027 API microversion.\")"},{"line_number":721,"context_line":"        _quota_resources.append(\u0027share_replicas\u0027)"},{"line_number":722,"context_line":"    if args.replica_gigabytes is not None:"},{"line_number":723,"context_line":"        if cs.api_version \u003c api_versions.APIVersion(\"2.53\"):"},{"line_number":724,"context_line":"            raise exceptions.CommandError("},{"line_number":725,"context_line":"                \"\u0027share replica gigabyte\u0027 quotas are available only starting \""},{"line_number":726,"context_line":"                \"with \u00272.53\u0027 API microversion.\")"},{"line_number":727,"context_line":"        _quota_resources.append(\u0027replica_gigabytes\u0027)"},{"line_number":728,"context_line":""},{"line_number":729,"context_line":"    _quota_update(cs.quota_classes, args.class_name, args)"},{"line_number":730,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_7ce9a77e","line":727,"range":{"start_line":716,"start_character":4,"end_line":727,"end_character":52},"in_reply_to":"df33271e_dc5d5316","updated":"2020-04-07 23:11:14.000000000","message":"Makes total sense. Done.","commit_id":"852e5ea4c685091c97014380ff2337e7b4bf9b2b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f052de59c0bacd21e9a13dc5a6d5be00006fc4e3","unresolved":false,"context_lines":[{"line_number":580,"context_line":"                \"\u00272.40\u0027 API microversion.\")"},{"line_number":581,"context_line":"        elif args.share_type is not None:"},{"line_number":582,"context_line":"            raise exceptions.CommandError("},{"line_number":583,"context_line":"                \"Share type quotas handle only \u0027shares\u0027, \u0027gigabytes\u0027, \""},{"line_number":584,"context_line":"                \"\u0027snapshots\u0027 and \u0027snapshot_gigabytes\u0027 resources.\")"},{"line_number":585,"context_line":"        kwargs[\"share_groups\"] \u003d args.share_groups"},{"line_number":586,"context_line":"        kwargs[\"share_group_snapshots\"] \u003d args.share_group_snapshots"},{"line_number":587,"context_line":"    if args.share_replicas is not None or args.replica_gigabytes is not None:"}],"source_content_type":"text/x-python","patch_set":7,"id":"df33271e_a6f2f904","line":584,"range":{"start_line":583,"start_character":35,"end_line":584,"end_character":65},"updated":"2020-04-07 23:14:51.000000000","message":"cannot be used to constrain share groups.","commit_id":"02706320b7dbe430a236cbf07383fc8e3123bdef"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"dbcf749cee8ab386f72e163d251feaf55bee8d33","unresolved":false,"context_lines":[{"line_number":580,"context_line":"                \"\u00272.40\u0027 API microversion.\")"},{"line_number":581,"context_line":"        elif args.share_type is not None:"},{"line_number":582,"context_line":"            raise exceptions.CommandError("},{"line_number":583,"context_line":"                \"Share type quotas handle only \u0027shares\u0027, \u0027gigabytes\u0027, \""},{"line_number":584,"context_line":"                \"\u0027snapshots\u0027 and \u0027snapshot_gigabytes\u0027 resources.\")"},{"line_number":585,"context_line":"        kwargs[\"share_groups\"] \u003d args.share_groups"},{"line_number":586,"context_line":"        kwargs[\"share_group_snapshots\"] \u003d args.share_group_snapshots"},{"line_number":587,"context_line":"    if args.share_replicas is not None or args.replica_gigabytes is not None:"}],"source_content_type":"text/x-python","patch_set":7,"id":"df33271e_66bbd1e4","line":584,"range":{"start_line":583,"start_character":35,"end_line":584,"end_character":65},"in_reply_to":"df33271e_a6f2f904","updated":"2020-04-07 23:33:31.000000000","message":"Done :)","commit_id":"02706320b7dbe430a236cbf07383fc8e3123bdef"}],"releasenotes/notes/add-share-replicas-and-replica-gigabytes-quotas-909436c2b2420f2c.yaml":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f241bcb48215439ce903c6113b1285959f7baf9e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    `share_replicas` and `replica_gigabytes`."},{"line_number":5,"context_line":"upgrade:"},{"line_number":6,"context_line":"  - Due to the new quotas for share replicas, it is now possible to hit an"},{"line_number":7,"context_line":"    \u0027over limit\u0027 error while creating share replicas for two purposes:"},{"line_number":8,"context_line":"    the limit of share replicas exceeded or the limit of allowed replica"},{"line_number":9,"context_line":"    gigabytes exceeded."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1fa4df85_adbcaa6c","line":7,"range":{"start_line":7,"start_character":69,"end_line":7,"end_character":70},"updated":"2020-03-12 14:45:17.000000000","message":"remove","commit_id":"8962286766e7edba7725eee920ca37dd91ccf3c0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bb8fe1427697b248eeda5d6de1f0b2378f33edb7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added support for two new quotas for share replicas, being"},{"line_number":4,"context_line":"    `share_replicas` and `replica_gigabytes`."},{"line_number":5,"context_line":"upgrade:"},{"line_number":6,"context_line":"  - Due to the new \u0027share_replicas\u0027 and \u0027replica_gigabytes\u0027 quotas for"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df33271e_72c5828e","line":3,"range":{"start_line":3,"start_character":55,"end_line":3,"end_character":62},"updated":"2020-03-24 07:27:29.000000000","message":":","commit_id":"435af76bafbe4a4d0e1a5f70c948a3aae8dd672f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5a72b4380bc5456730134a1b35c609a99c7ac189","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    Due to the new \u0027share_replicas\u0027 and \u0027replica_gigabytes\u0027 quotas for"},{"line_number":9,"context_line":"    share replicas, it is now possible to hit an \u0027over limit\u0027 error"},{"line_number":10,"context_line":"    while creating share replicas."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df33271e_dc8b9365","line":10,"range":{"start_line":10,"start_character":19,"end_line":10,"end_character":34},"updated":"2020-04-07 20:42:39.000000000","message":"replicated shares and share replicas.","commit_id":"852e5ea4c685091c97014380ff2337e7b4bf9b2b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"85b6d67dc11e94d1f53c3f5c392d8578df10128b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    Due to the new \u0027share_replicas\u0027 and \u0027replica_gigabytes\u0027 quotas for"},{"line_number":9,"context_line":"    share replicas, it is now possible to hit an \u0027over limit\u0027 error"},{"line_number":10,"context_line":"    while creating share replicas."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df33271e_90b44fd3","line":10,"range":{"start_line":10,"start_character":19,"end_line":10,"end_character":34},"in_reply_to":"df33271e_dc8b9365","updated":"2020-04-07 23:11:14.000000000","message":"Done","commit_id":"852e5ea4c685091c97014380ff2337e7b4bf9b2b"}]}
