)]}'
{"id":"openstack%2Fpython-manilaclient~715630","triplet_id":"openstack%2Fpython-manilaclient~master~I78ee32da2b158abda1ca4438c23c5245dd8849b2","project":"openstack/python-manilaclient","branch":"master","topic":"update-hacking","hashtags":[],"change_id":"I78ee32da2b158abda1ca4438c23c5245dd8849b2","subject":"Update hacking for Python3","status":"MERGED","created":"2020-03-28 15:03:02.000000000","updated":"2020-03-31 01:01:19.000000000","submitted":"2020-03-31 00:59:44.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"715630-1585616384576-ee9f4f24","meta_rev_id":"568ea4437c4f422b0c98d6e30d99a951af6ae16b","_number":715630,"virtual_id_number":715630,"owner":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"value":0,"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-03-31 00:59:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"all":[{"value":2,"date":"2020-03-30 23:55:37.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"value":2,"date":"2020-03-30 11:58:11.000000000","_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"all":[{"value":1,"date":"2020-03-30 23:55:37.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"value":0,"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-03-30 11:58:11.000000000","updated_by":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"reviewer":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"state":"REVIEWER"},{"updated":"2020-03-30 23:55:37.000000000","updated_by":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"reviewer":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"state":"REVIEWER"},{"updated":"2020-03-31 00:59:44.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d411ae59d96146b02615dade3d614c7235d2b5a7","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2020-03-28 15:03:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b6693dff42ce2ed6d1722fa705073c954749e96e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-28 16:08:03.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/620ce32b11d34c8da530d50557b55c0f : SUCCESS in 4m 36s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/9ea49581c2534f48919d47ce3592305a : SUCCESS in 3m 50s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e62f468193e64426aedc75d4ab257420 : SUCCESS in 4m 05s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/bb479b9eae984c7d9bea369801f49110 : SUCCESS in 3m 02s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/a7c3d9471423415bb2599458c5bceed8 : SUCCESS in 3m 19s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/d6c86b5253fb413e9899bc13862e8273 : SUCCESS in 3m 29s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/90ef72d6c24e463199aa91ff9464f05b : SUCCESS in 3m 41s (non-voting)\n- requirements-check https://zuul.opendev.org/t/openstack/build/fde5f81bbbdf43feb377d37517e65f01 : SUCCESS in 2m 11s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/f8b05db9b94a46dca0bbc6ad707ded46 : SUCCESS in 3m 21s\n- manilaclient-dsvm-neutron-functional https://zuul.opendev.org/t/openstack/build/8d8c8cc14b654f16845cfa2ed1642a30 : SUCCESS in 1h 00m 19s","accounts_in_message":[],"_revision_number":1},{"id":"df9bd9c5b002ea1aebd4c9a3f34184ca5b30090b","author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"date":"2020-03-29 21:24:31.000000000","message":"Patch Set 1: Code-Review+2\n\nThanks for doing all these fixes.  I\u0027m in favor of getting them merged.","accounts_in_message":[],"_revision_number":1},{"id":"03fad59e67abce3c746f9a06afb202c1bc03439c","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2020-03-30 10:04:34.000000000","message":"Patch Set 2: Published edit on patch set 1.","accounts_in_message":[],"_revision_number":2},{"id":"61fa5232c8442265479c5433c2c8f5b8ee4ace7e","author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"date":"2020-03-30 10:12:26.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"91949f4ae6b9d3231bc1f7eb9f776a19a1411e4f","author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"date":"2020-03-30 10:13:49.000000000","message":"Patch Set 2: -Code-Review\n\nLGTM but let\u0027s see if hacking version 3.0 requires any other code fixes.","accounts_in_message":[],"_revision_number":2},{"id":"aa755bb34e654b87c2bab4368e577ae234d22f74","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-30 11:10:41.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/58c0154ffd98412e9177ae301c9e2b52 : SUCCESS in 8m 21s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/da9dcd91e39042c0811ce69741069371 : SUCCESS in 4m 58s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/bda163eb437c417da0d325f1bb3d725b : SUCCESS in 4m 37s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a7f75bdd4d5542589cc9b291fb6d786a : SUCCESS in 3m 17s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/45f4a4988fac4d53b5d48ff68ea676d4 : SUCCESS in 4m 42s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/1ed36a65f1a349958cf0d16855ba21b9 : SUCCESS in 4m 19s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/b96fd674f9964d36863745b4b8b8ad16 : SUCCESS in 3m 56s (non-voting)\n- requirements-check https://zuul.opendev.org/t/openstack/build/cdbc58b6c05b4733814bd31180d4ce31 : SUCCESS in 3m 33s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/00249c8d379e45518d61a01d2fd44cb4 : SUCCESS in 3m 28s\n- manilaclient-dsvm-neutron-functional https://zuul.opendev.org/t/openstack/build/9a5d2ef810634e19bc5babd486118a29 : SUCCESS in 58m 27s","accounts_in_message":[],"_revision_number":2},{"id":"fa3746c974d058ac3b862ec0decbfb661a1eb821","author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"date":"2020-03-30 11:58:11.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"994ef242de3ea92a7b8c1c073d716c956c0c3ca7","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2020-03-30 23:55:37.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nThanks for combing through and fixing up the non-conforming code..","accounts_in_message":[],"_revision_number":2},{"id":"ddda25735b88a154793567a999c792770a39ff32","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-30 23:55:49.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"777bb76b201bae1aef78055856e5c58642dbf9f9","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-31 00:59:44.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b1ad1da4f8de4a448a15df254639db27 : SUCCESS in 4m 43s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/81f5eaaa06c141839b268c661e1d49d7 : SUCCESS in 4m 39s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ac1e7006296142c49f1a5fb7c8a6b2b2 : SUCCESS in 3m 14s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b9b4ec320a974613b18b9e0b3af1f655 : SUCCESS in 4m 31s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/6ae40dbaecb9467c90154a9e2cba0113 : SUCCESS in 4m 24s\n- requirements-check https://zuul.opendev.org/t/openstack/build/0e7a7ed99531438a99ca369945129657 : SUCCESS in 2m 26s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/4a951b5ad83940399a14da412121671b : SUCCESS in 3m 53s\n- manilaclient-dsvm-neutron-functional https://zuul.opendev.org/t/openstack/build/725398c87d1d43fba15179e87c0d04e3 : SUCCESS in 58m 37s","accounts_in_message":[],"_revision_number":2},{"id":"020869f28cb8396e56db4f4423322dd9590e6a16","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-31 00:59:44.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"b421f787fe4c7e18b86023bf90b6f1bda1899661","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-31 01:01:19.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b5a608019e9e4ec7b5718826046220f8 : SUCCESS in 1m 11s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/cfa7c9cfcf7c41879685d3d77c57712f : SUCCESS in 1m 15s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"7cf94c6527418b1f2cbf130c4607f81e98eb83e8","revisions":{"2cfa2f1b7fb316d81587daae148113b475961c9a":{"kind":"REWORK","_number":1,"created":"2020-03-28 15:03:02.000000000","uploader":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"ref":"refs/changes/30/715630/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/30/715630/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/30/715630/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/30/715630/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/30/715630/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/30/715630/1"}}},"commit":{"parents":[{"commit":"e3652b9c1c36c825d07dce741802930ad0ec1a12","subject":"Implement OSC share type commands","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/e3652b9c1c36c825d07dce741802930ad0ec1a12"}]}],"author":{"name":"Andreas Jaeger","email":"aj@suse.com","date":"2020-03-28 14:48:17.000000000","tz":60},"committer":{"name":"Andreas Jaeger","email":"aj@suse.com","date":"2020-03-28 15:02:47.000000000","tz":60},"subject":"Update hacking for Python3","message":"Update hacking for Python3\n\nThe repo is Python 3 now, so update hacking to version 2.0 which\nsupports Python 3.\n\nFix found problems.\n\nChange-Id: I78ee32da2b158abda1ca4438c23c5245dd8849b2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/2cfa2f1b7fb316d81587daae148113b475961c9a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/2cfa2f1b7fb316d81587daae148113b475961c9a"}]},"branch":"refs/heads/master"},"7cf94c6527418b1f2cbf130c4607f81e98eb83e8":{"kind":"REWORK","_number":2,"created":"2020-03-30 10:04:34.000000000","uploader":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"ref":"refs/changes/30/715630/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/30/715630/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/30/715630/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/30/715630/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/30/715630/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/30/715630/2"}}},"commit":{"parents":[{"commit":"e3652b9c1c36c825d07dce741802930ad0ec1a12","subject":"Implement OSC share type commands","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/e3652b9c1c36c825d07dce741802930ad0ec1a12"}]}],"author":{"name":"Andreas Jaeger","email":"aj@suse.com","date":"2020-03-28 14:48:17.000000000","tz":60},"committer":{"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","date":"2020-03-30 10:04:29.000000000","tz":0},"subject":"Update hacking for Python3","message":"Update hacking for Python3\n\nThe repo is Python 3 now, so update hacking to version 3.0 which\nsupports Python 3.\n\nFix found problems.\n\nChange-Id: I78ee32da2b158abda1ca4438c23c5245dd8849b2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/7cf94c6527418b1f2cbf130c4607f81e98eb83e8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/7cf94c6527418b1f2cbf130c4607f81e98eb83e8"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}