)]}'
{"manilaclient/osc/v2/share.py":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"c0b7b30b0170e8d30a99e1c7b0a601127fc94edd","unresolved":false,"context_lines":[{"line_number":708,"context_line":"        )"},{"line_number":709,"context_line":"        return parser"},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"    def resize_failed(self, error_message):"},{"line_number":712,"context_line":"        raise exceptions.CommandError(_("},{"line_number":713,"context_line":"            \"Share resize failed: %s\" % error_message"},{"line_number":714,"context_line":"        ))"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_03a6c9c1","line":711,"updated":"2020-06-04 00:41:31.000000000","message":"I understand you added the exception in this function to avoid code duplication and/or make code easier to read, but I don\u0027t actually see much gain of doing so. We should simply raise the exception in place or factorize this to a general module in which all exceptions are treated (as we do here, for example https://github.com/openstack/python-manilaclient/blob/master/manilaclient/exceptions.py). Perhaps the second one is the one that works best in the long run.","commit_id":"de5f6b1d739c09a155e6a006de6922f51f92ec2d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"152687be87540e6f3bb9e0a02570ae2d343f95a3","unresolved":false,"context_lines":[{"line_number":696,"context_line":"    def get_parser(self, prog_name):"},{"line_number":697,"context_line":"        parser \u003d super(ResizeShare, self).get_parser(prog_name)"},{"line_number":698,"context_line":"        parser.add_argument("},{"line_number":699,"context_line":"            \u0027share\u0027,"},{"line_number":700,"context_line":"            metavar\u003d\"\u003cshare\u003e\","},{"line_number":701,"context_line":"            help\u003d_(\u0027Name or ID of share to resize\u0027)"},{"line_number":702,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_866b0483","line":699,"range":{"start_line":699,"start_character":13,"end_line":699,"end_character":18},"updated":"2020-06-04 06:44:48.000000000","message":"Looking at this instruction from the OSC contributor design guide: https://docs.openstack.org/python-openstackclient/latest/contributor/command-options.html#required-options\n\nit feels like we ought to implement this with two leading dashes. I don\u0027t recall a discussion regarding this here, but what are your thoughts on that - we\u0027re still at a very early stage of supporting OSC, so we can do the right thing and follow it consistently..\n\nOSC implementation itself seems wildly inconsistent with that recommendation :|","commit_id":"c1327c624a69de59a29045646b4d652ac96840fb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b39a899b512cb8683ce301c4145b150245f79111","unresolved":false,"context_lines":[{"line_number":696,"context_line":"    def get_parser(self, prog_name):"},{"line_number":697,"context_line":"        parser \u003d super(ResizeShare, self).get_parser(prog_name)"},{"line_number":698,"context_line":"        parser.add_argument("},{"line_number":699,"context_line":"            \u0027share\u0027,"},{"line_number":700,"context_line":"            metavar\u003d\"\u003cshare\u003e\","},{"line_number":701,"context_line":"            help\u003d_(\u0027Name or ID of share to resize\u0027)"},{"line_number":702,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_f40edc2f","line":699,"range":{"start_line":699,"start_character":13,"end_line":699,"end_character":18},"in_reply_to":"ff570b3c_3dc84253","updated":"2020-06-04 19:17:21.000000000","message":"We should, I guess - I\u0027d hate to break consistency - but, I really could use a recommendation that suggests \"predictable\" consistency\n\nWhen you want to act on a resource, don\u0027t make that need a verbose option with preceding dashes - it\u0027s not necessary;","commit_id":"c1327c624a69de59a29045646b4d652ac96840fb"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"dd0270f1fbe71f59c99f30c19e83d258b4ad5f17","unresolved":false,"context_lines":[{"line_number":696,"context_line":"    def get_parser(self, prog_name):"},{"line_number":697,"context_line":"        parser \u003d super(ResizeShare, self).get_parser(prog_name)"},{"line_number":698,"context_line":"        parser.add_argument("},{"line_number":699,"context_line":"            \u0027share\u0027,"},{"line_number":700,"context_line":"            metavar\u003d\"\u003cshare\u003e\","},{"line_number":701,"context_line":"            help\u003d_(\u0027Name or ID of share to resize\u0027)"},{"line_number":702,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_3dc84253","line":699,"range":{"start_line":699,"start_character":13,"end_line":699,"end_character":18},"in_reply_to":"ff570b3c_866b0483","updated":"2020-06-04 13:43:09.000000000","message":"Hm... just saw this. IMHO it adds unnecessary verbosity \"openstack resize myshare 10\" is way simpler than \"openstack share resize --share myshare --new-size 10\". If I were an operator I\u0027d expect to write less. We can talk about this with the osc folks maybe.","commit_id":"c1327c624a69de59a29045646b4d652ac96840fb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"152687be87540e6f3bb9e0a02570ae2d343f95a3","unresolved":false,"context_lines":[{"line_number":702,"context_line":"        )"},{"line_number":703,"context_line":"        parser.add_argument("},{"line_number":704,"context_line":"            \u0027new_size\u0027,"},{"line_number":705,"context_line":"            metavar\u003d\"\u003cnew_size\u003e\","},{"line_number":706,"context_line":"            type\u003dint,"},{"line_number":707,"context_line":"            help\u003d_(\u0027New size of share, in GiBs\u0027)"},{"line_number":708,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_83ee56ea","line":705,"range":{"start_line":705,"start_character":22,"end_line":705,"end_character":30},"updated":"2020-06-04 06:44:48.000000000","message":"a hyphen instead of an underscore: https://docs.openstack.org/python-openstackclient/latest/contributor/humaninterfaceguide.html#command-structure","commit_id":"c1327c624a69de59a29045646b4d652ac96840fb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"152687be87540e6f3bb9e0a02570ae2d343f95a3","unresolved":false,"context_lines":[{"line_number":705,"context_line":"            metavar\u003d\"\u003cnew_size\u003e\","},{"line_number":706,"context_line":"            type\u003dint,"},{"line_number":707,"context_line":"            help\u003d_(\u0027New size of share, in GiBs\u0027)"},{"line_number":708,"context_line":"        )"},{"line_number":709,"context_line":"        return parser"},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_e60f60dd","line":708,"range":{"start_line":708,"start_character":8,"end_line":708,"end_character":9},"updated":"2020-06-04 06:44:48.000000000","message":"This is optional, but, a bunch of projects are looking to adopt a waiter interface, ex: https://opendev.org/openstack/python-octaviaclient/src/branch/master/octaviaclient/osc/v2/amphora.py#L137-L141\nhttps://opendev.org/openstack/python-octaviaclient/src/branch/master/octaviaclient/osc/v2/utils.py#L606-L638\n\nThe idea is that we can allow the command to return only after the action has been performed...What are your thoughts on adding a wait option?","commit_id":"c1327c624a69de59a29045646b4d652ac96840fb"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"9fc9ae01472ca59762e30268e9c31f800feda703","unresolved":false,"context_lines":[{"line_number":705,"context_line":"            metavar\u003d\"\u003cnew_size\u003e\","},{"line_number":706,"context_line":"            type\u003dint,"},{"line_number":707,"context_line":"            help\u003d_(\u0027New size of share, in GiBs\u0027)"},{"line_number":708,"context_line":"        )"},{"line_number":709,"context_line":"        return parser"},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_0d494cb6","line":708,"range":{"start_line":708,"start_character":8,"end_line":708,"end_character":9},"in_reply_to":"ff570b3c_3415f43d","updated":"2020-06-12 06:11:08.000000000","message":"Sounds good, I can take that","commit_id":"c1327c624a69de59a29045646b4d652ac96840fb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b39a899b512cb8683ce301c4145b150245f79111","unresolved":false,"context_lines":[{"line_number":705,"context_line":"            metavar\u003d\"\u003cnew_size\u003e\","},{"line_number":706,"context_line":"            type\u003dint,"},{"line_number":707,"context_line":"            help\u003d_(\u0027New size of share, in GiBs\u0027)"},{"line_number":708,"context_line":"        )"},{"line_number":709,"context_line":"        return parser"},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_3415f43d","line":708,"range":{"start_line":708,"start_character":8,"end_line":708,"end_character":9},"in_reply_to":"ff570b3c_3df68290","updated":"2020-06-04 19:17:21.000000000","message":"sure thing.","commit_id":"c1327c624a69de59a29045646b4d652ac96840fb"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"dd0270f1fbe71f59c99f30c19e83d258b4ad5f17","unresolved":false,"context_lines":[{"line_number":705,"context_line":"            metavar\u003d\"\u003cnew_size\u003e\","},{"line_number":706,"context_line":"            type\u003dint,"},{"line_number":707,"context_line":"            help\u003d_(\u0027New size of share, in GiBs\u0027)"},{"line_number":708,"context_line":"        )"},{"line_number":709,"context_line":"        return parser"},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_3df68290","line":708,"range":{"start_line":708,"start_character":8,"end_line":708,"end_character":9},"in_reply_to":"ff570b3c_e60f60dd","updated":"2020-06-04 13:43:09.000000000","message":"Feels like something we can do as a follow up patch as part of enhancements. We could even have a \"add waiters\" bp and then add waiters for all those commands that need so.","commit_id":"c1327c624a69de59a29045646b4d652ac96840fb"}]}