)]}'
{"manilaclient/tests/functional/test_shares.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0a86ec2eca32b4a1c8fd7df4f6200936cf4f11ea","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        self.assertEqual(expected_status, share_1[\u0027status\u0027])"},{"line_number":110,"context_line":"        self.assertEqual(expected_status, share_2[\u0027status\u0027])"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        if use_wait_option:"},{"line_number":113,"context_line":"            self.delete_share([share_1[\u0027id\u0027], share_2[\u0027id\u0027]],"},{"line_number":114,"context_line":"                              wait\u003duse_wait_option,"},{"line_number":115,"context_line":"                              client\u003dself.user_client)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fffc6b78_7c18e680","line":112,"range":{"start_line":112,"start_character":8,"end_line":112,"end_character":27},"updated":"2020-11-19 11:26:09.000000000","message":"A thing that came into my mind:\nsince no actions are taken when this statement is False, and there is another test [1] testing the scenario without wait, the ddt for the False wait value could be avoided and the [1] test could have an assert to check if the share status is \u0027creating\u0027...\n\n[1] https://review.opendev.org/#/c/755667/3/manilaclient/tests/functional/test_shares.py@51\n\nBut I don\u0027t see a problem on keeping as is :)","commit_id":"d3c4e8fa16570e255dd3e00f4a4c40258542c06e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"75f101177fabf310651e8b1f985b024f5d87b344","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        self.assertEqual(expected_status, share_1[\u0027status\u0027])"},{"line_number":110,"context_line":"        self.assertEqual(expected_status, share_2[\u0027status\u0027])"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        if use_wait_option:"},{"line_number":113,"context_line":"            self.delete_share([share_1[\u0027id\u0027], share_2[\u0027id\u0027]],"},{"line_number":114,"context_line":"                              wait\u003duse_wait_option,"},{"line_number":115,"context_line":"                              client\u003dself.user_client)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fffc6b78_43b89629","line":112,"range":{"start_line":112,"start_character":8,"end_line":112,"end_character":27},"in_reply_to":"fffc6b78_4d9f2ab4","updated":"2020-11-19 19:04:54.000000000","message":"I see, good point. No point duplicating tests, i\u0027ll drop the ddt here.","commit_id":"d3c4e8fa16570e255dd3e00f4a4c40258542c06e"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"d3e8e27c8f76f6ed549edd2fbb1d37c6ea2e1524","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        self.assertEqual(expected_status, share_1[\u0027status\u0027])"},{"line_number":110,"context_line":"        self.assertEqual(expected_status, share_2[\u0027status\u0027])"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        if use_wait_option:"},{"line_number":113,"context_line":"            self.delete_share([share_1[\u0027id\u0027], share_2[\u0027id\u0027]],"},{"line_number":114,"context_line":"                              wait\u003duse_wait_option,"},{"line_number":115,"context_line":"                              client\u003dself.user_client)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fffc6b78_4d9f2ab4","line":112,"range":{"start_line":112,"start_character":8,"end_line":112,"end_character":27},"in_reply_to":"fffc6b78_7c18e680","updated":"2020-11-19 14:45:52.000000000","message":"Good point, we could remove ddt here and only pass use_wait_option\u003dtrue. It\u0027s not harmful though","commit_id":"d3c4e8fa16570e255dd3e00f4a4c40258542c06e"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5f08d66ac930eb1405a576c1f05298b87cc8e118","unresolved":false,"context_lines":[{"line_number":812,"context_line":"@cliutils.arg("},{"line_number":813,"context_line":"    \u0027--wait\u0027,"},{"line_number":814,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":815,"context_line":"    help\u003d\u0027Wait for share creation\u0027)"},{"line_number":816,"context_line":"@cliutils.service_type(\u0027sharev2\u0027)"},{"line_number":817,"context_line":"def do_create(cs, args):"},{"line_number":818,"context_line":"    \"\"\"Creates a new share (NFS, CIFS, CephFS, GlusterFS, HDFS or MAPRFS).\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_c5a106fa","line":815,"range":{"start_line":815,"start_character":25,"end_line":815,"end_character":33},"updated":"2020-10-01 22:35:34.000000000","message":"add a fullstop","commit_id":"c4559b51a2d983cc71af3da94b5e9e68cf1d5b36"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ceda2d7ecb3d432d352cef3f17a9e4faec52dd76","unresolved":false,"context_lines":[{"line_number":839,"context_line":""},{"line_number":840,"context_line":"    if args.wait:"},{"line_number":841,"context_line":"        time_elapsed \u003d 0"},{"line_number":842,"context_line":"        poll_timeout \u003d 300"},{"line_number":843,"context_line":"        message \u003d (\"Share %(share)s did not become \u0027available\u0027 within \""},{"line_number":844,"context_line":"                   \"%(seconds)d seconds.\")"},{"line_number":845,"context_line":"        while True:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_25b0c240","line":842,"range":{"start_line":842,"start_character":8,"end_line":842,"end_character":20},"updated":"2020-10-01 22:36:38.000000000","message":"make this configurable","commit_id":"c4559b51a2d983cc71af3da94b5e9e68cf1d5b36"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"d3e8e27c8f76f6ed549edd2fbb1d37c6ea2e1524","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        expected_status \u003d (expected_status, )"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    time_elapsed \u003d 0"},{"line_number":73,"context_line":"    timeout_message \u003d (\"%(resource_type)s %(resource)s did not reach \""},{"line_number":74,"context_line":"                       \"%(expected_states)s within %(seconds)d seconds.\")"},{"line_number":75,"context_line":"    error_message \u003d (\"%(resource_type)s %(resource)s has reached a failed \""},{"line_number":76,"context_line":"                     \"state.\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"fffc6b78_6d830e58","line":73,"updated":"2020-11-19 14:45:52.000000000","message":"NIT add translation _","commit_id":"d3c4e8fa16570e255dd3e00f4a4c40258542c06e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"75f101177fabf310651e8b1f985b024f5d87b344","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        expected_status \u003d (expected_status, )"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    time_elapsed \u003d 0"},{"line_number":73,"context_line":"    timeout_message \u003d (\"%(resource_type)s %(resource)s did not reach \""},{"line_number":74,"context_line":"                       \"%(expected_states)s within %(seconds)d seconds.\")"},{"line_number":75,"context_line":"    error_message \u003d (\"%(resource_type)s %(resource)s has reached a failed \""},{"line_number":76,"context_line":"                     \"state.\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"fffc6b78_436376dd","line":73,"in_reply_to":"fffc6b78_6d830e58","updated":"2020-11-19 19:04:54.000000000","message":"I\u0027d agree but, this project doesn\u0027t get translated right now:\n\nhttps://translate.openstack.org/explore?dswid\u003d-104\u0026q\u003dpython-manilaclient\n\nWe could add it to the translation suite and make changes everywhere - wdyt?","commit_id":"d3c4e8fa16570e255dd3e00f4a4c40258542c06e"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"d3e8e27c8f76f6ed549edd2fbb1d37c6ea2e1524","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    time_elapsed \u003d 0"},{"line_number":73,"context_line":"    timeout_message \u003d (\"%(resource_type)s %(resource)s did not reach \""},{"line_number":74,"context_line":"                       \"%(expected_states)s within %(seconds)d seconds.\")"},{"line_number":75,"context_line":"    error_message \u003d (\"%(resource_type)s %(resource)s has reached a failed \""},{"line_number":76,"context_line":"                     \"state.\")"},{"line_number":77,"context_line":"    deleted_message \u003d (\"%(resource_type)s %(resource)s has been successfully \""},{"line_number":78,"context_line":"                       \"deleted.\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"fffc6b78_4d88ca70","line":75,"updated":"2020-11-19 14:45:52.000000000","message":"Ditto","commit_id":"d3c4e8fa16570e255dd3e00f4a4c40258542c06e"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"d3e8e27c8f76f6ed549edd2fbb1d37c6ea2e1524","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                       \"%(expected_states)s within %(seconds)d seconds.\")"},{"line_number":75,"context_line":"    error_message \u003d (\"%(resource_type)s %(resource)s has reached a failed \""},{"line_number":76,"context_line":"                     \"state.\")"},{"line_number":77,"context_line":"    deleted_message \u003d (\"%(resource_type)s %(resource)s has been successfully \""},{"line_number":78,"context_line":"                       \"deleted.\")"},{"line_number":79,"context_line":"    message_payload \u003d {"},{"line_number":80,"context_line":"        \u0027resource_type\u0027: resource_type.capitalize(),"}],"source_content_type":"text/x-python","patch_set":3,"id":"fffc6b78_ad7df66f","line":77,"updated":"2020-11-19 14:45:52.000000000","message":"Ditto","commit_id":"d3c4e8fa16570e255dd3e00f4a4c40258542c06e"}]}