)]}'
{"manilaclient/osc/v2/share.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d782646da9c1dd10a7c1b20539e02c536a5d904f","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                share \u003d apiutils.find_resource(share_client.shares,"},{"line_number":234,"context_line":"                                               share.id)"},{"line_number":235,"context_line":"            else:"},{"line_number":236,"context_line":"                msg \u003d _(\"Share is in error state.\")"},{"line_number":237,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        printable_share \u003d share._info"},{"line_number":240,"context_line":"        printable_share.pop(\u0027links\u0027, None)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f6b1bfe_9d596400","line":237,"range":{"start_line":236,"start_character":16,"end_line":237,"end_character":50},"updated":"2020-10-13 18:47:13.000000000","message":"still have to print the share details.. perhaps store the result, print the share and test the result to raise this exception","commit_id":"fb6f17947cee78b665a82cd88cc5822c4e9c53df"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"825f951169bd172ab2812bcbebf5b3d9bb3f7db8","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                share \u003d apiutils.find_resource(share_client.shares,"},{"line_number":234,"context_line":"                                               share.id)"},{"line_number":235,"context_line":"            else:"},{"line_number":236,"context_line":"                msg \u003d _(\"Share is in error state.\")"},{"line_number":237,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        printable_share \u003d share._info"},{"line_number":240,"context_line":"        printable_share.pop(\u0027links\u0027, None)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f65232a_660af08a","line":237,"range":{"start_line":236,"start_character":16,"end_line":237,"end_character":50},"in_reply_to":"7f6b1bfe_9d596400","updated":"2020-10-21 20:10:03.000000000","message":"You\u0027re absolutely right, still need to print the details, thanks! Instead of printing though, what if we only log the error and return? In that case we are sure the output will match both cases, for example if a user requests the output in json or specifies some columns...","commit_id":"fb6f17947cee78b665a82cd88cc5822c4e9c53df"}]}