)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d7dda051a3dfbe3a1a8ffc6d6fe161ffd9d6afaf","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Running openstack share type list -c with a single option raises an"},{"line_number":10,"context_line":"AttributeError:\u0027list\u0027 object has no attribute \u0027split\u0027."},{"line_number":11,"context_line":"Deleted the if..else case to only allow for"},{"line_number":12,"context_line":" --column/-c when used"},{"line_number":13,"context_line":"Deleted accompanying testcase for --columns"},{"line_number":14,"context_line":"Running openstack share access list myshare -c id raises"},{"line_number":15,"context_line":"AttributeError:\u0027list\u0027 object has no attribute \u0027split\u0027"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f621f24_4d6e66c9","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":22},"updated":"2020-11-10 00:50:39.000000000","message":"This is no longer accurate","commit_id":"66c1084e0968cdc1a5a4db1bed49c8619865cb6f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d7dda051a3dfbe3a1a8ffc6d6fe161ffd9d6afaf","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Deleted accompanying testcase for --columns"},{"line_number":14,"context_line":"Running openstack share access list myshare -c id raises"},{"line_number":15,"context_line":"AttributeError:\u0027list\u0027 object has no attribute \u0027split\u0027"},{"line_number":16,"context_line":"Deleted the if...else case to allow for case when"},{"line_number":17,"context_line":"-c/--column is used"},{"line_number":18,"context_line":"Deleted accompanying testcase for --columns"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f621f24_8d6b5eb5","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":19},"updated":"2020-11-10 00:50:39.000000000","message":"Same\n\nPerhaps you mean to say:\n\n\"openstack share type list\" and \"openstack share access list\"\ndon\u0027t need a \"columns\" option. The OSC client has inherent support for output filtering via the \"-c/--column\" options.","commit_id":"66c1084e0968cdc1a5a4db1bed49c8619865cb6f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d7dda051a3dfbe3a1a8ffc6d6fe161ffd9d6afaf","unresolved":false,"context_lines":[{"line_number":17,"context_line":"-c/--column is used"},{"line_number":18,"context_line":"Deleted accompanying testcase for --columns"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"DocImpact"},{"line_number":21,"context_line":"Closes-Bug:#1899325"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I6666e279e5ec97ced2e03aaf1eb88faec7408531"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f621f24_2da84ad9","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":9},"updated":"2020-11-10 00:50:39.000000000","message":"No user facing documentation update is necessary - you can remove this flag\n\n\nPlease add a release note instead: https://docs.openstack.org/manila/latest/contributor/adding_release_notes.html","commit_id":"66c1084e0968cdc1a5a4db1bed49c8619865cb6f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"895f5428103605727e2077f38406b6125e00994c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"do not need a \"--columns\" option."},{"line_number":11,"context_line":"The OSC Client has inherent support for output filtering"},{"line_number":12,"context_line":"via the \"-c/--column\" options"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I6666e279e5ec97ced2e03aaf1eb88faec7408531"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1f621f24_75c957aa","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":0},"updated":"2020-11-11 05:57:41.000000000","message":"you lost the Closes-Bug line:\n\nCloses-Bug: #1899325","commit_id":"77ad9eceef6b2d4aa67d4db5ed80fbd4c98a1569"}],"manilaclient/osc/v2/share_access_rules.py":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"41853d6723fb8e95533ed4da6e438b55eaa8f465","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            metavar\u003d\"\u003cshare\u003e\","},{"line_number":165,"context_line":"            help\u003d_(\u0027Name or ID of the share.\u0027)"},{"line_number":166,"context_line":"        )"},{"line_number":167,"context_line":"        parser.add_argument("},{"line_number":168,"context_line":"            \u0027--columns\u0027,"},{"line_number":169,"context_line":"            metavar\u003d\"\u003ccolumns\u003e\","},{"line_number":170,"context_line":"            default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_52bdcc63","line":167,"updated":"2020-10-31 15:23:16.000000000","message":"delete this argument","commit_id":"8bc5163ce9e8f02fd9100089ee08fba153564f3e"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"41853d6723fb8e95533ed4da6e438b55eaa8f465","unresolved":false,"context_lines":[{"line_number":222,"context_line":"            list_of_keys.append(\u0027created_at\u0027)"},{"line_number":223,"context_line":"            list_of_keys.append(\u0027updated_at\u0027)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        if parsed_args.columns:"},{"line_number":226,"context_line":"            try:"},{"line_number":227,"context_line":"                columns \u003d parsed_args.columns.split(\u0027,\u0027)"},{"line_number":228,"context_line":"            except AttributeError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_12c354ef","line":225,"updated":"2020-10-31 15:23:16.000000000","message":"delete this whole if/else block","commit_id":"8bc5163ce9e8f02fd9100089ee08fba153564f3e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"a0045af6abbab6b7606b22b894cf3bc20580c332","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                        msg \u003d (\"No column named \u0027%s\u0027. Possible columns are: \""},{"line_number":234,"context_line":"                               \"\u0027id\u0027, \u0027access_type\u0027, \u0027access_to\u0027, \""},{"line_number":235,"context_line":"                               \"\u0027access_level\u0027, \u0027state\u0027, \""},{"line_number":236,"context_line":"                               \"\u0027access_key\u0027(API microversion 2.21 and beyond), \""},{"line_number":237,"context_line":"                               \"\u0027created_at\u0027(API microversion 2.33 and beyond), \""},{"line_number":238,"context_line":"                               \"\u0027updated_at\u0027(API microversion 2.33 and beyond).\""},{"line_number":239,"context_line":"                               % column)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_b25f0040","line":236,"updated":"2020-10-31 15:26:14.000000000","message":"pep8: E501 line too long (81 \u003e 79 characters)","commit_id":"8bc5163ce9e8f02fd9100089ee08fba153564f3e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"a0045af6abbab6b7606b22b894cf3bc20580c332","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                               \"\u0027id\u0027, \u0027access_type\u0027, \u0027access_to\u0027, \""},{"line_number":235,"context_line":"                               \"\u0027access_level\u0027, \u0027state\u0027, \""},{"line_number":236,"context_line":"                               \"\u0027access_key\u0027(API microversion 2.21 and beyond), \""},{"line_number":237,"context_line":"                               \"\u0027created_at\u0027(API microversion 2.33 and beyond), \""},{"line_number":238,"context_line":"                               \"\u0027updated_at\u0027(API microversion 2.33 and beyond).\""},{"line_number":239,"context_line":"                               % column)"},{"line_number":240,"context_line":"                        raise exceptions.CommandError(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_925c844c","line":237,"updated":"2020-10-31 15:26:14.000000000","message":"pep8: E501 line too long (81 \u003e 79 characters)","commit_id":"8bc5163ce9e8f02fd9100089ee08fba153564f3e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"a0045af6abbab6b7606b22b894cf3bc20580c332","unresolved":false,"context_lines":[{"line_number":235,"context_line":"                               \"\u0027access_level\u0027, \u0027state\u0027, \""},{"line_number":236,"context_line":"                               \"\u0027access_key\u0027(API microversion 2.21 and beyond), \""},{"line_number":237,"context_line":"                               \"\u0027created_at\u0027(API microversion 2.33 and beyond), \""},{"line_number":238,"context_line":"                               \"\u0027updated_at\u0027(API microversion 2.33 and beyond).\""},{"line_number":239,"context_line":"                               % column)"},{"line_number":240,"context_line":"                        raise exceptions.CommandError(msg)"},{"line_number":241,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_f259785a","line":238,"updated":"2020-10-31 15:26:14.000000000","message":"pep8: E501 line too long (80 \u003e 79 characters)","commit_id":"8bc5163ce9e8f02fd9100089ee08fba153564f3e"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"41853d6723fb8e95533ed4da6e438b55eaa8f465","unresolved":false,"context_lines":[{"line_number":242,"context_line":"            columns \u003d list_of_keys"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        values \u003d (oscutils.get_item_properties("},{"line_number":245,"context_line":"            a, columns) for a in access_list)"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        return (columns, values)"},{"line_number":248,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_72b8c875","line":245,"range":{"start_line":245,"start_character":15,"end_line":245,"end_character":22},"updated":"2020-10-31 15:23:16.000000000","message":"list_of_keys","commit_id":"8bc5163ce9e8f02fd9100089ee08fba153564f3e"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"41853d6723fb8e95533ed4da6e438b55eaa8f465","unresolved":false,"context_lines":[{"line_number":244,"context_line":"        values \u003d (oscutils.get_item_properties("},{"line_number":245,"context_line":"            a, columns) for a in access_list)"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        return (columns, values)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"class ShowShareAccess(command.ShowOne):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_726d6803","line":247,"range":{"start_line":247,"start_character":16,"end_line":247,"end_character":23},"updated":"2020-10-31 15:23:16.000000000","message":"list_of_keys","commit_id":"8bc5163ce9e8f02fd9100089ee08fba153564f3e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"5f3dd628796c3ed7cd4fa1f61f3a5a1af1cf84d3","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            metavar\u003d\"\u003cshare\u003e\","},{"line_number":165,"context_line":"            help\u003d_(\u0027Name or ID of the share.\u0027)"},{"line_number":166,"context_line":"        )"},{"line_number":167,"context_line":"        "},{"line_number":168,"context_line":"        # metadata --\u003e properties in osc"},{"line_number":169,"context_line":"        parser.add_argument("},{"line_number":170,"context_line":"            \u0027--properties\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_3d462125","line":167,"updated":"2020-10-31 17:14:22.000000000","message":"pep8: W293 blank line contains whitespace","commit_id":"053afd03947beb1291fc66891257083362744707"}],"manilaclient/osc/v2/share_types.py":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"41853d6723fb8e95533ed4da6e438b55eaa8f465","unresolved":false,"context_lines":[{"line_number":392,"context_line":"                   \u0027Available only for API microversion \u003e\u003d 2.43. \u0027"},{"line_number":393,"context_line":"                   \u0027OPTIONAL: Default\u003dNone.\u0027),"},{"line_number":394,"context_line":"        )"},{"line_number":395,"context_line":"        parser.add_argument("},{"line_number":396,"context_line":"            \u0027--columns\u0027,"},{"line_number":397,"context_line":"            metavar\u003d\u0027\u003ccolumns\u003e\u0027,"},{"line_number":398,"context_line":"            help\u003d_(\u0027Comma separated list of columns to be displayed \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_126874f3","line":395,"updated":"2020-10-31 15:23:16.000000000","message":"delete this argument","commit_id":"8bc5163ce9e8f02fd9100089ee08fba153564f3e"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"41853d6723fb8e95533ed4da6e438b55eaa8f465","unresolved":false,"context_lines":[{"line_number":420,"context_line":"            search_opts\u003dsearch_opts,"},{"line_number":421,"context_line":"            show_all\u003dparsed_args.all)"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"        if parsed_args.columns:"},{"line_number":424,"context_line":"            try:"},{"line_number":425,"context_line":"                columns \u003d parsed_args.columns.split(\u0027,\u0027)"},{"line_number":426,"context_line":"            except AttributeError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_92ae442c","line":423,"updated":"2020-10-31 15:23:16.000000000","message":"delete this if/else block","commit_id":"8bc5163ce9e8f02fd9100089ee08fba153564f3e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"a0045af6abbab6b7606b22b894cf3bc20580c332","unresolved":false,"context_lines":[{"line_number":429,"context_line":"                for column in columns:"},{"line_number":430,"context_line":"                    if column not in ATTRIBUTES:"},{"line_number":431,"context_line":"                        msg \u003d (\"No column named \u0027%s\u0027. \""},{"line_number":432,"context_line":"                               \"Possible columns are: \u0027id\u0027, \u0027name\u0027, \u0027visibility\u0027, \""},{"line_number":433,"context_line":"                               \"is_default\u0027, \u0027required_extra_specs\u0027, \""},{"line_number":434,"context_line":"                               \"\u0027optional_extra_specs\u0027, \u0027description\u0027.\" % column)"},{"line_number":435,"context_line":"                        raise exceptions.CommandError(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_d256fc29","line":432,"updated":"2020-10-31 15:26:14.000000000","message":"pep8: E501 line too long (83 \u003e 79 characters)","commit_id":"8bc5163ce9e8f02fd9100089ee08fba153564f3e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"a0045af6abbab6b7606b22b894cf3bc20580c332","unresolved":false,"context_lines":[{"line_number":431,"context_line":"                        msg \u003d (\"No column named \u0027%s\u0027. \""},{"line_number":432,"context_line":"                               \"Possible columns are: \u0027id\u0027, \u0027name\u0027, \u0027visibility\u0027, \""},{"line_number":433,"context_line":"                               \"is_default\u0027, \u0027required_extra_specs\u0027, \""},{"line_number":434,"context_line":"                               \"\u0027optional_extra_specs\u0027, \u0027description\u0027.\" % column)"},{"line_number":435,"context_line":"                        raise exceptions.CommandError(msg)"},{"line_number":436,"context_line":"        else:"},{"line_number":437,"context_line":"            columns \u003d ATTRIBUTES"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_3231300d","line":434,"updated":"2020-10-31 15:26:14.000000000","message":"pep8: E501 line too long (81 \u003e 79 characters)","commit_id":"8bc5163ce9e8f02fd9100089ee08fba153564f3e"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"41853d6723fb8e95533ed4da6e438b55eaa8f465","unresolved":false,"context_lines":[{"line_number":441,"context_line":"            formatted_types.append(format_share_type(share_type))"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"        values \u003d (oscutils.get_dict_properties("},{"line_number":444,"context_line":"            s._info, columns) for s in formatted_types)"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"        return (columns, values)"},{"line_number":447,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_d2a8bc20","line":444,"range":{"start_line":444,"start_character":21,"end_line":444,"end_character":28},"updated":"2020-10-31 15:23:16.000000000","message":"ATTRIBUTES","commit_id":"8bc5163ce9e8f02fd9100089ee08fba153564f3e"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"41853d6723fb8e95533ed4da6e438b55eaa8f465","unresolved":false,"context_lines":[{"line_number":443,"context_line":"        values \u003d (oscutils.get_dict_properties("},{"line_number":444,"context_line":"            s._info, columns) for s in formatted_types)"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"        return (columns, values)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"class ShowShareType(command.ShowOne):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_3263f01c","line":446,"range":{"start_line":446,"start_character":16,"end_line":446,"end_character":23},"updated":"2020-10-31 15:23:16.000000000","message":"ATTRIBUTES","commit_id":"8bc5163ce9e8f02fd9100089ee08fba153564f3e"}],"manilaclient/releasenotes/notes/bug-1899325-implement-usage-of-c-or-column-without-additional-logic-2970ee294f32bd31.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"895f5428103605727e2077f38406b6125e00994c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The commands \"openstack share type list\" and "},{"line_number":5,"context_line":"    \"openstack share access list \" use \"-c\" or"},{"line_number":6,"context_line":"    \"--column\" options .These options are supported "},{"line_number":7,"context_line":"    by the OSC client."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1f621f24_55cedbb3","line":4,"range":{"start_line":4,"start_character":48,"end_line":4,"end_character":49},"updated":"2020-11-11 05:57:41.000000000","message":"Notice the trailing whitespace in this line and on line 6, please remove these.","commit_id":"77ad9eceef6b2d4aa67d4db5ed80fbd4c98a1569"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"895f5428103605727e2077f38406b6125e00994c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    \"openstack share access list \" use \"-c\" or"},{"line_number":6,"context_line":"    \"--column\" options .These options are supported "},{"line_number":7,"context_line":"    by the OSC client."},{"line_number":8,"context_line":"    Support for \"--columns\" has been removed."},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1f621f24_35387f9e","line":8,"range":{"start_line":8,"start_character":44,"end_line":8,"end_character":45},"updated":"2020-11-11 05:57:41.000000000","message":"I suggest rewriting this note in a simpler manner:\n\n - |\n   The commands \"openstack share type list\" and \"openstack share access list\"\n   no longer support the \"--columns\" option. Use \"--column\"\n   to filter the output.","commit_id":"77ad9eceef6b2d4aa67d4db5ed80fbd4c98a1569"}]}
