)]}'
{"id":"openstack%2Fpython-manilaclient~761654","triplet_id":"openstack%2Fpython-manilaclient~master~I5fcafd4bdfb40b2054e1205c14493c2f4be1f77a","project":"openstack/python-manilaclient","branch":"master","topic":"bug/1902873","hashtags":[],"change_id":"I5fcafd4bdfb40b2054e1205c14493c2f4be1f77a","subject":"Fix undesirable raw Python error","status":"MERGED","created":"2020-11-05 18:35:44.000000000","updated":"2020-11-16 18:36:26.000000000","submitted":"2020-11-16 18:35:05.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"761654-1605551705480-e490bc4f","meta_rev_id":"c1886e8bba49979a880dc176f8fcb57e6918fbbd","_number":761654,"virtual_id_number":761654,"owner":{"_account_id":32411,"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","username":"ecsantos"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-11-16 18:35:05.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},{"value":0,"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-11-16 17:00:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},{"value":2,"date":"2020-11-10 00:52:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-11-16 17:00:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},{"value":0,"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-11-10 00:52:53.000000000","updated_by":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"reviewer":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"state":"REVIEWER"},{"updated":"2020-11-16 17:00:07.000000000","updated_by":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"reviewer":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"state":"REVIEWER"},{"updated":"2020-11-16 18:35:05.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"7ea4147f6441171ff5f541dff5136b6fb62af873","author":{"_account_id":32411,"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","username":"ecsantos"},"date":"2020-11-05 18:35:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"65ca5b6c484ae108904ccc4c62b50dc6b97bdd2b","author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"date":"2020-11-05 19:08:42.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)\n\nHi Eduardo,\n\nThank you for providing this fix.\nCan you also add a release note in the next patch? Tks","accounts_in_message":[],"_revision_number":1},{"id":"ee6b74fe106552718340fa127e674e614a967b13","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-05 19:36:54.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/484d554d19fd4abe95792661b3ce4336 : SUCCESS in 7m 10s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/aaf9ff66c34f4e339a418d768c75c2f6 : SUCCESS in 6m 39s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/bbfc86b7b0744025abb5d304c1886252 : SUCCESS in 4m 40s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/592d7eb9bccd4a5595c28c74ce15f3e8 : SUCCESS in 3m 38s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/51cfd229b9ea414da3fd178a52b7dc89 : SUCCESS in 4m 07s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/25be91a4512d48ec82b3d226d908d3bc : SUCCESS in 3m 43s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/f0d9b2b8f2a24b87b61a237c471ff7d6 : SUCCESS in 4m 59s (non-voting)\n- python-manilaclient-functional https://zuul.opendev.org/t/openstack/build/f17d0a50aa154f81b9848b312a8bc0a8 : SUCCESS in 46m 11s","accounts_in_message":[],"_revision_number":1},{"id":"e5952d22e0f1f73877bc08a5ad0fd84171e9d601","author":{"_account_id":32411,"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","username":"ecsantos"},"date":"2020-11-06 11:57:37.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"08b84194f8f8a63dc9516a767ca22423662f924e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-06 12:46:53.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/467b03af55914af29ece95e3533bb453 : SUCCESS in 5m 51s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/fb0e6c38d95c42d4b7fe2e50a50c889c : SUCCESS in 5m 19s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/9159e7a46e5e4977a5245c1e4ab30872 : SUCCESS in 4m 27s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/751542aa2c2c4fa89f9a8fb837c80c84 : SUCCESS in 3m 11s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d47176fbe905471f85490b608f18e40b : SUCCESS in 3m 57s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/15684b04e9934b1d9d3be46ea27bad94 : SUCCESS in 4m 51s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/70733cf335754e438fa99c36a4c6c4ee : SUCCESS in 3m 52s (non-voting)\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/cabb38dca8db4b65af5c3818c3a32d1d : SUCCESS in 3m 37s\n- python-manilaclient-functional https://zuul.opendev.org/t/openstack/build/ef502ebc703e487597834537bd8e749c : SUCCESS in 44m 23s","accounts_in_message":[],"_revision_number":2},{"id":"8ca3218e62cc2c2d5972248f16088cd837fa652f","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2020-11-10 00:52:53.000000000","message":"Patch Set 2: Code-Review+2\n\nThanks! Good find, and fix!","accounts_in_message":[],"_revision_number":2},{"id":"32a7e8ac37c6f2745098ac24d5086fc590f5cb8f","author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"date":"2020-11-16 17:00:07.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nThank you Eduardo, LGTM.","accounts_in_message":[],"_revision_number":2},{"id":"2b2cb85f690c42a55491d2b619266c696b0fec5d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-16 17:00:22.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"6b489bfb2ccdec7f055c61a52a5e1bd58c557675","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-16 18:35:05.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"fc369978da73ecb6ed91e64b11a1034b1178be34","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-16 18:35:05.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/285d72c3aa23462088566239638391ec : SUCCESS in 7m 00s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/7e1bcf81a360450eac72798305c01597 : SUCCESS in 5m 16s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/622589d5bf6d43a8817d75a75448d647 : SUCCESS in 3m 22s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b25374cbea3c4ff8937eb400b9066b18 : SUCCESS in 4m 32s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/bc71ecfd2c374b3db79fba871e9ae47b : SUCCESS in 4m 27s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/e3d94c3207a84f29b373473e7645ebbc : SUCCESS in 3m 56s\n- python-manilaclient-functional https://zuul.opendev.org/t/openstack/build/c8389e259a1a40d4b73588fd7ad6d19a : SUCCESS in 1h 29m 35s","accounts_in_message":[],"_revision_number":2},{"id":"e3711b5f581eb9170dece8efbe8a4d5345df9b0f","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-16 18:36:26.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e2a02e5ca14c4080ad85dd1f841547a2 : SUCCESS in 57s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/26ed6451bcf54639bfa1ad0261edd3b5 : SUCCESS in 49s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"aeb47213eaa8f27bea43bb6b915d6be255a9e246","revisions":{"05daac3fd8c11f55c84d873b151298d3aac3d9b8":{"kind":"REWORK","_number":1,"created":"2020-11-05 18:35:44.000000000","uploader":{"_account_id":32411,"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","username":"ecsantos"},"ref":"refs/changes/54/761654/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/54/761654/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/54/761654/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/54/761654/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/54/761654/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/54/761654/1"}}},"commit":{"parents":[{"commit":"6673930aa49ec51c52ae80018a6cca6e5a71daa1","subject":"Merge \"Remove six.moves.urllib\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/6673930aa49ec51c52ae80018a6cca6e5a71daa1"}]}],"author":{"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","date":"2020-11-05 18:27:55.000000000","tz":0},"committer":{"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","date":"2020-11-05 18:27:55.000000000","tz":0},"subject":"Fix undesirable raw Python error","message":"Fix undesirable raw Python error\n\nUsing the manilaclient without a subcommand while\npassing an optional argument triggers the raw Python\nerror `ERROR: \u0027Namespace\u0027 object has no attribute\n\u0027func\u0027`. This bug can be reproduced by issuing the\ncommand `cinder --os-cache`.\nAdded a default value to `func` and an empty value to\n`command` as placeholders so that a help message is\nshown instead of the Python error.\nThis patch uses the same fix implemented in the\npython-cinderclient.\n\nChange-Id: I5fcafd4bdfb40b2054e1205c14493c2f4be1f77a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/05daac3fd8c11f55c84d873b151298d3aac3d9b8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/05daac3fd8c11f55c84d873b151298d3aac3d9b8"}]},"branch":"refs/heads/master"},"aeb47213eaa8f27bea43bb6b915d6be255a9e246":{"kind":"REWORK","_number":2,"created":"2020-11-06 11:57:37.000000000","uploader":{"_account_id":32411,"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","username":"ecsantos"},"ref":"refs/changes/54/761654/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/54/761654/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/54/761654/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/54/761654/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/54/761654/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/54/761654/2"}}},"commit":{"parents":[{"commit":"6673930aa49ec51c52ae80018a6cca6e5a71daa1","subject":"Merge \"Remove six.moves.urllib\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/6673930aa49ec51c52ae80018a6cca6e5a71daa1"}]}],"author":{"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","date":"2020-11-05 18:27:55.000000000","tz":0},"committer":{"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","date":"2020-11-06 11:55:44.000000000","tz":0},"subject":"Fix undesirable raw Python error","message":"Fix undesirable raw Python error\n\nUsing the manilaclient without a subcommand while\npassing an optional argument triggers the raw Python\nerror `ERROR: \u0027Namespace\u0027 object has no attribute\n\u0027func\u0027`. This bug can be reproduced by issuing the\ncommand `manila --os-cache`.\nAdded a default value to `func` and an empty value to\n`command` as placeholders so that a help message is\nshown instead of the Python error.\nThis patch uses the same fix implemented in the\npython-cinderclient.\n\nCloses-Bug: #1902873\nChange-Id: I5fcafd4bdfb40b2054e1205c14493c2f4be1f77a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/aeb47213eaa8f27bea43bb6b915d6be255a9e246"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/aeb47213eaa8f27bea43bb6b915d6be255a9e246"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}