)]}'
{"manilaclient/tests/unit/osc/v2/test_share.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"2918eb0fdac57a6233fb31404c33ce6dfbfeb2ca","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        self.share_types_mock.reset_mock()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        self.app.client_manager.share.api_version \u003d api_versions.APIVersion("},{"line_number":49,"context_line":"            \"2.51\")"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def setup_shares_mock(self, count):"},{"line_number":52,"context_line":"        shares \u003d manila_fakes.FakeShare.create_shares(count\u003dcount)"}],"source_content_type":"text/x-python","patch_set":2,"id":"898920b3_c80b8fb5","line":49,"range":{"start_line":49,"start_character":12,"end_line":49,"end_character":18},"updated":"2020-12-17 14:54:47.000000000","message":"is there a specific reason to have 2.51 as default?","commit_id":"752d71c807ef97f955ed5008b4b55297e38642eb"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"96070a53b3bfb0ccd8c4682fe9bf57848fa998bc","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        self.share_types_mock.reset_mock()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        self.app.client_manager.share.api_version \u003d api_versions.APIVersion("},{"line_number":49,"context_line":"            \"2.51\")"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def setup_shares_mock(self, count):"},{"line_number":52,"context_line":"        shares \u003d manila_fakes.FakeShare.create_shares(count\u003dcount)"}],"source_content_type":"text/x-python","patch_set":2,"id":"f62a7104_ef73bfc5","line":49,"range":{"start_line":49,"start_character":12,"end_line":49,"end_character":18},"in_reply_to":"39149cb7_7bcc9f71","updated":"2021-01-05 20:37:10.000000000","message":"+1, let\u0027s fix this before merging :)","commit_id":"752d71c807ef97f955ed5008b4b55297e38642eb"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"429ec7217c72190896eb4671ec6842a0eccc1e00","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        self.share_types_mock.reset_mock()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        self.app.client_manager.share.api_version \u003d api_versions.APIVersion("},{"line_number":49,"context_line":"            \"2.51\")"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def setup_shares_mock(self, count):"},{"line_number":52,"context_line":"        shares \u003d manila_fakes.FakeShare.create_shares(count\u003dcount)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9e36d8f1_099185ea","line":49,"range":{"start_line":49,"start_character":12,"end_line":49,"end_character":18},"in_reply_to":"898920b3_c80b8fb5","updated":"2020-12-19 15:30:18.000000000","message":"That\u0027s a great question, no reason really and I believe now that it should be MAX_VERSION instead, would you agree?","commit_id":"752d71c807ef97f955ed5008b4b55297e38642eb"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5b20e0efb537b0c17c9b2f79dbb6a14c871041b5","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        self.share_types_mock.reset_mock()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        self.app.client_manager.share.api_version \u003d api_versions.APIVersion("},{"line_number":49,"context_line":"            \"2.51\")"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def setup_shares_mock(self, count):"},{"line_number":52,"context_line":"        shares \u003d manila_fakes.FakeShare.create_shares(count\u003dcount)"}],"source_content_type":"text/x-python","patch_set":2,"id":"39149cb7_7bcc9f71","line":49,"range":{"start_line":49,"start_character":12,"end_line":49,"end_character":18},"in_reply_to":"9e36d8f1_099185ea","updated":"2021-01-05 20:31:36.000000000","message":"Yeah, MAX_VERSION makes sense :)","commit_id":"752d71c807ef97f955ed5008b4b55297e38642eb"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"2918eb0fdac57a6233fb31404c33ce6dfbfeb2ca","unresolved":true,"context_lines":[{"line_number":1434,"context_line":"        self.assertCountEqual(self.columns, columns)"},{"line_number":1435,"context_line":"        self.assertCountEqual(self.datalist, data)"},{"line_number":1436,"context_line":""},{"line_number":1437,"context_line":"    def test_share_adopt(self):"},{"line_number":1438,"context_line":"        arglist \u003d ["},{"line_number":1439,"context_line":"            \u0027some.host@driver#pool\u0027,"},{"line_number":1440,"context_line":"            \u0027NFS\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ef2edc0a_0f801556","line":1437,"updated":"2020-12-17 14:54:47.000000000","message":"As far as I understood, seems that the only scenario that is being tested is the adopt containing a share server id.\nIf that is correct, could you please cover the scenario where the share server id is not specified?","commit_id":"752d71c807ef97f955ed5008b4b55297e38642eb"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5b20e0efb537b0c17c9b2f79dbb6a14c871041b5","unresolved":true,"context_lines":[{"line_number":1434,"context_line":"        self.assertCountEqual(self.columns, columns)"},{"line_number":1435,"context_line":"        self.assertCountEqual(self.datalist, data)"},{"line_number":1436,"context_line":""},{"line_number":1437,"context_line":"    def test_share_adopt(self):"},{"line_number":1438,"context_line":"        arglist \u003d ["},{"line_number":1439,"context_line":"            \u0027some.host@driver#pool\u0027,"},{"line_number":1440,"context_line":"            \u0027NFS\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"d370a867_4c7344de","line":1437,"in_reply_to":"c132e538_35fff890","updated":"2021-01-05 20:31:36.000000000","message":"Oh, sorry, I missed the adopt_required_args test. I think the ones we have should be enough! Thanks","commit_id":"752d71c807ef97f955ed5008b4b55297e38642eb"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"429ec7217c72190896eb4671ec6842a0eccc1e00","unresolved":true,"context_lines":[{"line_number":1434,"context_line":"        self.assertCountEqual(self.columns, columns)"},{"line_number":1435,"context_line":"        self.assertCountEqual(self.datalist, data)"},{"line_number":1436,"context_line":""},{"line_number":1437,"context_line":"    def test_share_adopt(self):"},{"line_number":1438,"context_line":"        arglist \u003d ["},{"line_number":1439,"context_line":"            \u0027some.host@driver#pool\u0027,"},{"line_number":1440,"context_line":"            \u0027NFS\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"c132e538_35fff890","line":1437,"in_reply_to":"ef2edc0a_0f801556","updated":"2020-12-19 15:30:18.000000000","message":"test_share_adopt_required_args does not specify \u0027--share-server-id\u0027 and also two exception scenario tests: test_share_adopt_wait_error \u0026 test_share_adopt_visibility_api_version_exception. Should I add more? I aimed for good coverage but it\u0027s possible that I\u0027m not aware of some specific cases and combinations of arguments we\u0027d want to test here. Maybe you have some suggestions?","commit_id":"752d71c807ef97f955ed5008b4b55297e38642eb"}]}