)]}'
{"id":"openstack%2Fpython-manilaclient~768606","triplet_id":"openstack%2Fpython-manilaclient~master~Ie21cad4754f32afdaf2c3f69202acfd7aa10f57c","project":"openstack/python-manilaclient","branch":"master","topic":"None","hashtags":[],"change_id":"Ie21cad4754f32afdaf2c3f69202acfd7aa10f57c","subject":"Forbid users to create shares with the name \"None\"","status":"MERGED","created":"2020-12-28 13:28:03.000000000","updated":"2021-02-10 20:09:41.000000000","submitted":"2021-02-10 20:07:40.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":6,"unresolved_comment_count":3,"has_review_started":true,"submission_id":"768606-None","meta_rev_id":"ec1b698b9545f72c6b92e240d78802cf126c9a29","_number":768606,"virtual_id_number":768606,"owner":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-02-10 20:07:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"all":[{"value":2,"date":"2021-02-10 19:02:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-02-10 18:59:28.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"all":[{"value":1,"date":"2021-02-10 19:02:12.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"}],"reviewers":{"REVIEWER":[{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-12-28 13:33:17.000000000","updated_by":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"reviewer":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"state":"REVIEWER"},{"updated":"2020-12-28 13:33:17.000000000","updated_by":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"reviewer":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"state":"REVIEWER"},{"updated":"2020-12-28 13:33:17.000000000","updated_by":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"reviewer":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"state":"REVIEWER"},{"updated":"2020-12-28 13:33:45.000000000","updated_by":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"reviewer":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"state":"REVIEWER"},{"updated":"2020-12-28 14:15:27.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-12-30 20:32:43.000000000","updated_by":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"reviewer":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"state":"CC"},{"updated":"2021-01-10 12:24:18.000000000","updated_by":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"reviewer":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"state":"CC"},{"updated":"2021-02-04 13:05:37.000000000","updated_by":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"reviewer":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"state":"REMOVED"},{"updated":"2021-02-10 18:59:28.000000000","updated_by":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"reviewer":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"state":"REVIEWER"}],"messages":[{"id":"ce18c5260796df9be8e29865ec0cd7b0e41ee4f7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"date":"2020-12-28 13:28:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"927352f466661d29f7f7883966763e9928d33187","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-28 14:15:27.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7ef0b6869f534700a0ce2d7ef0ea23dd : SUCCESS in 5m 07s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/39c937c65dac42c4bf609da54a5aefd8 : SUCCESS in 5m 20s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/fc9935cb59f64bdeae2af70c6be7cbc8 : SUCCESS in 4m 28s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3673709ac7c1410189f3961ed14976c0 : SUCCESS in 3m 07s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/0ad565248c274a6d9cc3d6b14e0bdfa8 : SUCCESS in 4m 36s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/82bb88144f8c46ab9855c3508daa9776 : SUCCESS in 3m 37s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/81acd5e8631e4750ad302bb02a13cfc1 : SUCCESS in 3m 21s (non-voting)\n- python-manilaclient-functional https://zuul.opendev.org/t/openstack/build/9174cd5a87af4b4fafef219424aa6352 : SUCCESS in 46m 12s","accounts_in_message":[],"_revision_number":1},{"id":"fe83d4775780a4427a3614328f90b0d27ce5f624","author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"date":"2020-12-28 21:17:13.000000000","message":"Patch Set 1:\n\nI wonder if we should define some reserved words. I\u0027m thinking that we will hit the same issue if the user creates a share with the name \"-\". If we forbid users to create shares with the name \"None\" instead of replacing \"None\" for \"-\" when doing a share-list, we might have a better backwards-compatibility. Thoughts?","accounts_in_message":[],"_revision_number":1},{"id":"cda32607e343a5441a8b73b5cf71c5b597874742","author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"date":"2020-12-29 09:03:49.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e I wonder if we should define some reserved words. I\u0027m thinking that we will hit the same issue if the user creates a share with the name \"-\". If we forbid users to create shares with the name \"None\" instead of replacing \"None\" for \"-\" when doing a share-list, we might have a better backwards-compatibility. Thoughts?\n\nThanks for your comment.\nI think visually it\u0027s better to use \"-\" when user creates a share without the name.\nSo as you suggested regarding preventing the share creation with \"None\" let\u0027s prevent\nusers to use \"-\". But let\u0027s see what others think","accounts_in_message":[],"_revision_number":1},{"id":"9cc60e812ce805566058b4ccdd6f6ed60e8aecf8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"date":"2020-12-29 09:04:43.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"bda24f70954971ecde40045717bf1fe0cc4f076b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-29 09:57:48.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/70c2383010ea4c698b456af9cba983bc : SUCCESS in 5m 20s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/f7352c822d0f4bb9a7d6daf5a8dbef99 : SUCCESS in 4m 07s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/247735565c9d44e18da880849e940cc6 : SUCCESS in 4m 23s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/919fbd0239084a94b45d6e6a1aedb9c8 : SUCCESS in 3m 18s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/be983973cca44949a2aaecec71fc3aab : SUCCESS in 3m 54s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/414133d9f21347bea10043b8fe8d7d8b : SUCCESS in 3m 39s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/82c19f2ee4d64aff924f38762e3af4c1 : SUCCESS in 3m 43s (non-voting)\n- python-manilaclient-functional https://zuul.opendev.org/t/openstack/build/ddb61df3a95e45a98194a48349ee13ea : SUCCESS in 49m 07s","accounts_in_message":[],"_revision_number":2},{"id":"3333ec286ce85d7b5b6c21f1b0ba4b97166ba55e","author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"date":"2020-12-30 20:32:43.000000000","message":"Patch Set 2:\n\n(2 comments)\n\nHi Liron! In my opinion it would be better to use instead of data \u003d \"-\", data \u003d \" \" (one space), so it wouldn\u0027t conflict with \u0027-\u0027 and \u0027None\u0027 as share name argument. I tried creating share with --name argument of single space, and I couldn\u0027t. What do you think?","accounts_in_message":[],"_revision_number":2},{"id":"46dfd761f1141ba35329687b8f7714040bfe7acc","author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"date":"2020-12-31 07:41:27.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2:\n\u003e \n\u003e (2 comments)\n\u003e \n\u003e Hi Liron! In my opinion it would be better to use instead of data \u003d \"-\", data \u003d \" \" (one space), so it wouldn\u0027t conflict with \u0027-\u0027 and \u0027None\u0027 as share name argument. I tried creating share with --name argument of single space, and I couldn\u0027t. What do you think?\n\nHi Dina,\nThanks for your suggestion, but there is a possibility to create with one space or more when using quotes.\n$ manila create nfs 1 --name \u0027 \u0027\n\n$ manila list\n+--------------------------------------+------+------+-------------+-----------+-----------+-----------------+-------------------------+-------------------+\n| ID                                   | Name | Size | Share Proto | Status    | Is Public | Share Type Name | Host                    | Availability Zone |\n+--------------------------------------+------+------+-------------+-----------+-----------+-----------------+-------------------------+-------------------+\n| c1c93440-9ec3-4e98-af11-bffaf2abc3f8 |      | 1    | NFS         | available | False     | default         | hostgroup@cephfs#cephfs | nova              |\n+--------------------------------------+------+------+-------------+-----------+-----------+-----------------+-------------------------+-------------------+","accounts_in_message":[],"_revision_number":2},{"id":"557f4c876164b11c51cf568774c2839e44aa53e7","author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"date":"2021-01-10 12:24:18.000000000","message":"Patch Set 2:\n\nHi Liron, thanks for reporting this and working on it! I do find this solution a bit confusing though. By switching the value for the name field when printing out a list of shares, we are not actually changing the value. If you then run \u0027manila show\u0027 command on a share the name field will still be \u0027None\u0027 in both cases. Would it be clear for all users that when listing shares, the name \u0027None\u0027 means that there is a string walue of \u0027None\u0027 set and \u0027-\u0027 means the absence of a value or well \u0027None\u0027 itself? What do you think about addressing this at share creation?(https://github.com/openstack/python-manilaclient/blob/master/manilaclient/v2/shell.py#L873) We can differentiate between \u003cclass \u0027str\u0027\u003e with a value of \u0027None\u0027 and an actual \u003cclass \u0027NoneType\u0027\u003e there. I also like what Victoria suggested, not allowing users to use --name \u0027None\u0027, for \u0027None\u0027 having the general meaning of \u0027absence of a value\u0027. Thoughts? :)","accounts_in_message":[],"_revision_number":2},{"id":"31d659233ffc56b6ff282508288f2d06fa065d13","author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"date":"2021-01-10 14:29:50.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2:\n\u003e \n\u003e Hi Liron, thanks for reporting this and working on it! I do find this solution a bit confusing though. By switching the value for the name field when printing out a list of shares, we are not actually changing the value. If you then run \u0027manila show\u0027 command on a share the name field will still be \u0027None\u0027 in both cases. Would it be clear for all users that when listing shares, the name \u0027None\u0027 means that there is a string walue of \u0027None\u0027 set and \u0027-\u0027 means the absence of a value or well \u0027None\u0027 itself? What do you think about addressing this at share creation?(https://github.com/openstack/python-manilaclient/blob/master/manilaclient/v2/shell.py#L873) We can differentiate between \u003cclass \u0027str\u0027\u003e with a value of \u0027None\u0027 and an actual \u003cclass \u0027NoneType\u0027\u003e there. I also like what Victoria suggested, not allowing users to use --name \u0027None\u0027, for \u0027None\u0027 having the general meaning of \u0027absence of a value\u0027. Thoughts? :)\n\nThanks Maari,\nI do agree that it\u0027s a bit confusing.\nAs I mentioned before, I think visually it\u0027s better to use \"-\" when the value is None(\u003cclass \u0027NoneType\u0027\u003e).\nI hope it\u0027s better now.","accounts_in_message":[],"_revision_number":2},{"id":"8a988b170f57ea498ce36d25a3fe99b32ea82aad","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"date":"2021-01-10 14:30:57.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"5da3cb216ffe1235be0803a5a9343c05354bfec0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-10 15:20:39.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e1e0a44cf4124639adaeadacbe36db86 : SUCCESS in 7m 56s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/c1259b83becb418581b3f74bbec35ab7 : FAILURE in 4m 37s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/2270980eefd6403e8b50c3de28945b1a : FAILURE in 4m 49s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8e95a14b28574723a5ce6f5d4cee9178 : SUCCESS in 3m 00s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/00943069bf4e415486b460d99e624973 : FAILURE in 3m 29s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/4b40a0672a1d471d90cb20e8c1ff47af : FAILURE in 3m 29s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/e8367c73b0da46a28ca8f273fc7da740 : FAILURE in 3m 56s (non-voting)\n- python-manilaclient-functional https://zuul.opendev.org/t/openstack/build/5947d37b4ac94a299ba95ba82e8904e6 : SUCCESS in 39m 25s","accounts_in_message":[],"_revision_number":3},{"id":"0901cc024b832eacb4258b418730d49f66ff2233","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"date":"2021-01-10 15:50:39.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"5ba98e9f655efeecc3c868749d093ebe2aeab69f","author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"date":"2021-01-10 15:56:31.000000000","message":"Patch Set 4:\n\nI guess if we agree on that direction, we\u0027ll have to update the other resources: snapshot, share network and share type.","accounts_in_message":[],"_revision_number":4},{"id":"73d2b9439cc21f173e994c5a937eb26363378de9","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-10 16:32:33.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/23d9577c077f420ea2f48676ac934eda : SUCCESS in 5m 13s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/657a112eb00347628be9543eebfcf27e : SUCCESS in 4m 02s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/68c9ad3f92cb4cb2927b647eb8fa5438 : SUCCESS in 4m 35s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f5268a71418b4077956808dcb242a041 : SUCCESS in 4m 32s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/08b5773a47db46ca88d9d113a6477bce : SUCCESS in 5m 38s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/8c10f1df571f42f69d9fddb82ef28e56 : SUCCESS in 5m 30s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/d4a4a6fc51224aa9b674d135c88a5268 : SUCCESS in 5m 14s (non-voting)\n- python-manilaclient-functional https://zuul.opendev.org/t/openstack/build/931c9103ab084228a5bdeaedc8569991 : SUCCESS in 39m 59s","accounts_in_message":[],"_revision_number":4},{"id":"d4e438b1cf2c5ab2f52492f64b4a5ff2e64bbd44","author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"date":"2021-02-03 18:26:05.000000000","message":"Patch Set 4:\n\nHi Liron, sorry for the delay in response. I\u0027ve given this some thought and while I could agree with not allowing setting \"None\"(string) values I don\u0027t really agree with using \"-\" as a placeholder of sort. None is the default for all fields that are missing a value and I\u0027d prefer cohesion. I\u0027ll leave it up to other reviewers, respectfully.","accounts_in_message":[],"_revision_number":4},{"id":"9b8352f64b988e3b5673f408bbc474e87db22bb9","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2021-02-04 07:20:04.000000000","message":"Patch Set 4: Code-Review-1\n\n\u003e Patch Set 4:\n\u003e \n\u003e Hi Liron, sorry for the delay in response. I\u0027ve given this some thought and while I could agree with not allowing setting \"None\"(string) values I don\u0027t really agree with using \"-\" as a placeholder of sort. None is the default for all fields that are missing a value and I\u0027d prefer cohesion. I\u0027ll leave it up to other reviewers, respectfully.\n\nThanks for proposing this change Liron,\nI agree with Maari here; this pattern exists across OpenStack services, and substituting the name with a \"-\" isn\u0027t particularly helpful; \n\nApart from in-theory, why would anyone decide to name their shares \"None\"? If they choose to do so, someone could also in theory want to name their shares \"-\" (or any constant string we choose).","accounts_in_message":[],"_revision_number":4},{"id":"132447ec99508207aef786aaed9455da20a79c28","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"date":"2021-02-04 08:35:05.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"fb1403270e6914d189ad979271d09dfa61621652","author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"date":"2021-02-04 08:42:43.000000000","message":"Patch Set 5:\n\nI agree with both of you.\nLet\u0027s make it simple and uniform.","accounts_in_message":[],"_revision_number":5},{"id":"c9ede565e0951653c2dfe29e1979bf86041bd8ca","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-04 09:33:42.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f76fac7459e54899a057c1da9d616e0b : SUCCESS in 6m 01s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/c471fc7824844da2996ac09566bd08f3 : SUCCESS in 4m 37s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/af9e06c37202478bbabfbb14d0d70953 : SUCCESS in 4m 45s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7b735b09153e4b0582e3585abb43510d : SUCCESS in 3m 50s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/7ee40ea55f5040ffaf3fa2b87e244f4b : SUCCESS in 5m 18s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/783f14a3b9a94db09f7c5155d7139ea2 : SUCCESS in 5m 28s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/6d86d1913e824e8e84573080b11d934b : SUCCESS in 4m 42s (non-voting)\n- python-manilaclient-functional https://zuul.opendev.org/t/openstack/build/8c3a71e74ffe43779dbcb8a9c3e555ce : SUCCESS in 50m 17s","accounts_in_message":[],"_revision_number":5},{"id":"ec08ad226a6c0888c312e1f5079d82d32410e292","tag":"autogenerated:gerrit:deleteReviewer","author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"date":"2021-02-04 13:05:37.000000000","message":"Removed reviewer Dina Saparbaeva.","accounts_in_message":[],"_revision_number":5},{"id":"bbd2effd6de40b9e036c2aaedf739924fc8809f7","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2021-02-05 00:03:01.000000000","message":"Patch Set 5:\n\n(2 comments)","accounts_in_message":[],"_revision_number":5},{"id":"f7e19d5df314f73f0d96dd49da530c40e567e406","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"date":"2021-02-05 05:37:56.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"341eb80d954f22006c24060974ee2e74926020a5","author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"date":"2021-02-05 05:39:00.000000000","message":"Patch Set 6:\n\n(2 comments)","accounts_in_message":[],"_revision_number":6},{"id":"c5c7f54942a953bde3b9de22a67351002d4cb0ac","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-05 06:24:25.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b5d070f0b900457fa9f79c1ce8217e4e : SUCCESS in 6m 22s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/cdedda0eabfe42b9b846eb2a3a18c712 : SUCCESS in 4m 33s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/ac0840bef0e04d8da8fc7098923cf4fb : SUCCESS in 4m 27s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ce79b068d238424991a1c9299ede6dea : SUCCESS in 3m 17s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b7490b85ecfa4a88be9f0b81bb5a828c : SUCCESS in 3m 32s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/bd75d649b7c04483acc39319349eadba : SUCCESS in 4m 08s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/bf82d9f9b3724d8e878ddfdfa75044e6 : SUCCESS in 3m 54s (non-voting)\n- python-manilaclient-functional https://zuul.opendev.org/t/openstack/build/5daa647f85f4471d89888d962abe62d4 : SUCCESS in 44m 41s","accounts_in_message":[],"_revision_number":6},{"id":"7ff54036224df1380f1a2b064074ec8805f86ea5","author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"date":"2021-02-10 18:59:28.000000000","message":"Patch Set 6: Code-Review+2\n\nThanks for the changes Liron!","accounts_in_message":[],"_revision_number":6},{"id":"a1a9f9dde4bce299a856c4379d04ec89ecf293a6","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2021-02-10 19:02:12.000000000","message":"Patch Set 6: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":6},{"id":"91afb89717a70b6e5a3041fb30283a551e87f9f8","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-10 19:07:31.000000000","message":"Patch Set 6: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":6},{"id":"59c9eab624bfc686df8247a8cdccb10d1ae87c84","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-10 20:07:39.000000000","message":"Patch Set 6: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a1fe21cf73994e22a6ff8c56c98495a6 : SUCCESS in 8m 29s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a236827d10ab404085bb5335dfdd97af : SUCCESS in 5m 49s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e90454ceebe14df6a67875c96389b571 : SUCCESS in 4m 50s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/2f1bca6f3b704eff93ada14a1b607e82 : SUCCESS in 4m 05s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/304973e268f741eda90c2b4617c604e0 : SUCCESS in 5m 45s\n- python-manilaclient-functional https://zuul.opendev.org/t/openstack/build/261494b5df2d437d8dab0dabbf3a0a02 : SUCCESS in 55m 47s","accounts_in_message":[],"_revision_number":6},{"id":"772d06e42a12874e9ba20bbe23d7dc12772269d0","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-10 20:07:40.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":6},{"id":"ec1b698b9545f72c6b92e240d78802cf126c9a29","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-10 20:09:41.000000000","message":"Patch Set 6:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/10a0f67f9bfb4fb69a37b019bb8d25bc : SUCCESS in 1m 10s","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"fc5b6c598518a600fa01750d1ad03e3de981afe9","revisions":{"9fbe1512cc9f40a7ae94c8fcf8b9c6a4c6ee9da7":{"kind":"REWORK","_number":1,"created":"2020-12-28 13:28:03.000000000","uploader":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"ref":"refs/changes/06/768606/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/06/768606/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/06/768606/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/06/768606/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/06/768606/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/06/768606/1"}}},"commit":{"parents":[{"commit":"07898faca67e88809dff9b416fb512a99b1cc796","subject":"Fixes create share from snapshot in OSC","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/07898faca67e88809dff9b416fb512a99b1cc796"}]}],"author":{"name":"lkuchlan","email":"lkuchlan@redhat.com","date":"2020-12-28 13:26:47.000000000","tz":120},"committer":{"name":"lkuchlan","email":"lkuchlan@redhat.com","date":"2020-12-28 13:26:47.000000000","tz":120},"subject":"Display a dash(\u0027-\u0027) instead of None when performing list action","message":"Display a dash(\u0027-\u0027) instead of None when performing list action\n\nThis patch will prevent ambiguity between manila share creation\nwith name \u003d \u0027None\u0027 and without name argument.\n\nCloses-Bug: #1909477\nChange-Id: Ie21cad4754f32afdaf2c3f69202acfd7aa10f57c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/9fbe1512cc9f40a7ae94c8fcf8b9c6a4c6ee9da7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/9fbe1512cc9f40a7ae94c8fcf8b9c6a4c6ee9da7"}]},"branch":"refs/heads/master"},"e3ba3c83f535614bd0c216cc7781bff66d50b0c1":{"kind":"REWORK","_number":2,"created":"2020-12-29 09:04:43.000000000","uploader":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"ref":"refs/changes/06/768606/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/06/768606/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/06/768606/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/06/768606/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/06/768606/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/06/768606/2"}}},"commit":{"parents":[{"commit":"07898faca67e88809dff9b416fb512a99b1cc796","subject":"Fixes create share from snapshot in OSC","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/07898faca67e88809dff9b416fb512a99b1cc796"}]}],"author":{"name":"lkuchlan","email":"lkuchlan@redhat.com","date":"2020-12-28 13:26:47.000000000","tz":120},"committer":{"name":"lkuchlan","email":"lkuchlan@redhat.com","date":"2020-12-29 09:04:10.000000000","tz":120},"subject":"Display a dash(\u0027-\u0027) instead of None when performing list action","message":"Display a dash(\u0027-\u0027) instead of None when performing list action\n\nThis patch will prevent ambiguity between manila share creation\nwith name \u003d \u0027None\u0027 and without name argument.\n\nCloses-Bug: #1909477\nChange-Id: Ie21cad4754f32afdaf2c3f69202acfd7aa10f57c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/e3ba3c83f535614bd0c216cc7781bff66d50b0c1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/e3ba3c83f535614bd0c216cc7781bff66d50b0c1"}]},"branch":"refs/heads/master"},"d40d094640c9e80a26a94541bad436190e926524":{"kind":"REWORK","_number":3,"created":"2021-01-10 14:30:57.000000000","uploader":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"ref":"refs/changes/06/768606/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/06/768606/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/06/768606/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/06/768606/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/06/768606/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/06/768606/3"}}},"commit":{"parents":[{"commit":"07898faca67e88809dff9b416fb512a99b1cc796","subject":"Fixes create share from snapshot in OSC","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/07898faca67e88809dff9b416fb512a99b1cc796"}]}],"author":{"name":"lkuchlan","email":"lkuchlan@redhat.com","date":"2020-12-28 13:26:47.000000000","tz":120},"committer":{"name":"lkuchlan","email":"lkuchlan@redhat.com","date":"2021-01-10 14:30:15.000000000","tz":120},"subject":"Display a dash(\u0027-\u0027) instead of None when performing list action","message":"Display a dash(\u0027-\u0027) instead of None when performing list action\n\nThis patch will prevent ambiguity between manila share creation\nwith name \u003d \u0027None\u0027 and without name argument.\n\nCloses-Bug: #1909477\nChange-Id: Ie21cad4754f32afdaf2c3f69202acfd7aa10f57c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/d40d094640c9e80a26a94541bad436190e926524"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/d40d094640c9e80a26a94541bad436190e926524"}]},"branch":"refs/heads/master"},"98607cc8cabeff1e952301ff16a443a5029cee87":{"kind":"REWORK","_number":4,"created":"2021-01-10 15:50:39.000000000","uploader":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"ref":"refs/changes/06/768606/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/06/768606/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/06/768606/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/06/768606/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/06/768606/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/06/768606/4"}}},"commit":{"parents":[{"commit":"07898faca67e88809dff9b416fb512a99b1cc796","subject":"Fixes create share from snapshot in OSC","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/07898faca67e88809dff9b416fb512a99b1cc796"}]}],"author":{"name":"lkuchlan","email":"lkuchlan@redhat.com","date":"2020-12-28 13:26:47.000000000","tz":120},"committer":{"name":"lkuchlan","email":"lkuchlan@redhat.com","date":"2021-01-10 15:50:09.000000000","tz":120},"subject":"Display a dash(\u0027-\u0027) instead of None when performing list action","message":"Display a dash(\u0027-\u0027) instead of None when performing list action\n\nThis patch will prevent ambiguity between manila share creation\nwith name \u003d \u0027None\u0027 and without name argument.\n\nCloses-Bug: #1909477\nChange-Id: Ie21cad4754f32afdaf2c3f69202acfd7aa10f57c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/98607cc8cabeff1e952301ff16a443a5029cee87"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/98607cc8cabeff1e952301ff16a443a5029cee87"}]},"branch":"refs/heads/master"},"7a6fb9904c59545a97fdb28accb8bd06de52776f":{"kind":"REWORK","_number":5,"created":"2021-02-04 08:35:05.000000000","uploader":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"ref":"refs/changes/06/768606/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/06/768606/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/06/768606/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/06/768606/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/06/768606/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/06/768606/5"}}},"commit":{"parents":[{"commit":"68052cd26ba05baf72853280c6704dfd569ad3b6","subject":"Merge \"Tighten asserts in some wait tests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/68052cd26ba05baf72853280c6704dfd569ad3b6"}]}],"author":{"name":"lkuchlan","email":"lkuchlan@redhat.com","date":"2020-12-28 13:26:47.000000000","tz":120},"committer":{"name":"lkuchlan","email":"lkuchlan@redhat.com","date":"2021-02-04 08:32:10.000000000","tz":120},"subject":"Forbid users to create shares with the name \"None\"","message":"Forbid users to create shares with the name \"None\"\n\nThis patch will prevent ambiguity between manila share creation\nwith name \u003d \u0027None\u0027 and without name argument.\n\nCloses-Bug: #1909477\nChange-Id: Ie21cad4754f32afdaf2c3f69202acfd7aa10f57c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/7a6fb9904c59545a97fdb28accb8bd06de52776f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/7a6fb9904c59545a97fdb28accb8bd06de52776f"}]},"branch":"refs/heads/master"},"fc5b6c598518a600fa01750d1ad03e3de981afe9":{"kind":"REWORK","_number":6,"created":"2021-02-05 05:37:56.000000000","uploader":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"ref":"refs/changes/06/768606/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/06/768606/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/06/768606/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/06/768606/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/06/768606/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/06/768606/6"}}},"commit":{"parents":[{"commit":"68052cd26ba05baf72853280c6704dfd569ad3b6","subject":"Merge \"Tighten asserts in some wait tests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/68052cd26ba05baf72853280c6704dfd569ad3b6"}]}],"author":{"name":"lkuchlan","email":"lkuchlan@redhat.com","date":"2020-12-28 13:26:47.000000000","tz":120},"committer":{"name":"lkuchlan","email":"lkuchlan@redhat.com","date":"2021-02-05 05:37:28.000000000","tz":120},"subject":"Forbid users to create shares with the name \"None\"","message":"Forbid users to create shares with the name \"None\"\n\nThis patch will prevent ambiguity between manila share creation\nwith name \u003d \u0027None\u0027 and without name argument.\n\nCloses-Bug: #1909477\nChange-Id: Ie21cad4754f32afdaf2c3f69202acfd7aa10f57c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/fc5b6c598518a600fa01750d1ad03e3de981afe9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/fc5b6c598518a600fa01750d1ad03e3de981afe9"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}