)]}'
{"manilaclient/tests/unit/v2/test_shell.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f790756a7a8e3679276664836653515bab268657","unresolved":true,"context_lines":[{"line_number":1469,"context_line":""},{"line_number":1470,"context_line":"    def test_extend(self):"},{"line_number":1471,"context_line":"        self.run_command(\u0027extend 1234 77\u0027)"},{"line_number":1472,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/shares/1234\u0027)"},{"line_number":1473,"context_line":""},{"line_number":1474,"context_line":"    def test_extend_with_wait(self):"},{"line_number":1475,"context_line":"        self.run_command(\u0027extend 1234 77 --wait\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7d6279ce_3552603d","line":1472,"range":{"start_line":1472,"start_character":0,"end_line":1472,"end_character":49},"updated":"2021-01-20 18:42:14.000000000","message":"You don\u0027t want to delete the other assert here.","commit_id":"0739e9e45a51ebbefaccf9b3cae13702c302f8cc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f790756a7a8e3679276664836653515bab268657","unresolved":true,"context_lines":[{"line_number":1471,"context_line":"        self.run_command(\u0027extend 1234 77\u0027)"},{"line_number":1472,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/shares/1234\u0027)"},{"line_number":1473,"context_line":""},{"line_number":1474,"context_line":"    def test_extend_with_wait(self):"},{"line_number":1475,"context_line":"        self.run_command(\u0027extend 1234 77 --wait\u0027)"},{"line_number":1476,"context_line":"        expected \u003d {\u0027extend\u0027: {\u0027new_size\u0027: 77}}"},{"line_number":1477,"context_line":"        self.assert_called_anytime(\u0027POST\u0027, \u0027/shares/1234/action\u0027,"},{"line_number":1478,"context_line":"                                   body\u003dexpected, clear_callstack\u003dFalse)"},{"line_number":1479,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/shares/1234\u0027)"},{"line_number":1480,"context_line":""},{"line_number":1481,"context_line":"    def test_reset_state(self):"},{"line_number":1482,"context_line":"        self.run_command(\u0027reset-state 1234\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"317d66a7_6afda892","line":1479,"range":{"start_line":1474,"start_character":4,"end_line":1479,"end_character":49},"updated":"2021-01-20 18:42:14.000000000","message":"When the assert that a POST http call has been made to /shares/1234/action has been added back to the test above, both tests will look a lot similar, \n\nso, you could combine these two test cases with ddt.\n\nYou could mock the _find_share method to return the share in \"extending\" status a few times to distinguish between using the waiter and the case where you don\u0027t;","commit_id":"0739e9e45a51ebbefaccf9b3cae13702c302f8cc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f790756a7a8e3679276664836653515bab268657","unresolved":true,"context_lines":[{"line_number":1485,"context_line":""},{"line_number":1486,"context_line":"    def test_shrink(self):"},{"line_number":1487,"context_line":"        self.run_command(\u0027shrink 1234 77\u0027)"},{"line_number":1488,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/shares/1234\u0027)"},{"line_number":1489,"context_line":""},{"line_number":1490,"context_line":"    def test_shrink_with_wait(self):"},{"line_number":1491,"context_line":"        self.run_command(\u0027shrink 1234 77 --wait\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"523f9888_7500f30d","line":1488,"range":{"start_line":1488,"start_character":0,"end_line":1488,"end_character":49},"updated":"2021-01-20 18:42:14.000000000","message":"same comments as above apply to the shrink tests here","commit_id":"0739e9e45a51ebbefaccf9b3cae13702c302f8cc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"574e1c3fe64cb34549074fc5e25ca95a00df106a","unresolved":true,"context_lines":[{"line_number":1486,"context_line":"            shell_v2._find_share.assert_has_calls("},{"line_number":1487,"context_line":"                [mock.call(self.shell.cs, \u00271234\u0027)] * 4)"},{"line_number":1488,"context_line":"        else:"},{"line_number":1489,"context_line":"            shell_v2._find_share.assert_called_with("},{"line_number":1490,"context_line":"                self.shell.cs, \u00271234\u0027)"},{"line_number":1491,"context_line":""},{"line_number":1492,"context_line":"    def test_reset_state(self):"},{"line_number":1493,"context_line":"        self.run_command(\u0027reset-state 1234\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"f8e885cf_71aad4ad","line":1490,"range":{"start_line":1489,"start_character":12,"end_line":1490,"end_character":38},"updated":"2021-01-22 21:23:22.000000000","message":"i\u0027d like to tighten this assert a bit - assert_called_with just verifies if a call has been made, but doesn\u0027t exactly verify how many times the call has been made. So we must also assert how many times we expect this call here, and after line 1487.","commit_id":"153aa61146abcce593ddd82231de6ce2ec88f211"},{"author":{"_account_id":32635,"name":"Paul Ali","email":"paulali@protonmail.com","username":"paulali"},"change_message_id":"55b9c8cf55485dba2f45bfe2b8352332d4634916","unresolved":false,"context_lines":[{"line_number":1486,"context_line":"            shell_v2._find_share.assert_has_calls("},{"line_number":1487,"context_line":"                [mock.call(self.shell.cs, \u00271234\u0027)] * 4)"},{"line_number":1488,"context_line":"        else:"},{"line_number":1489,"context_line":"            shell_v2._find_share.assert_called_with("},{"line_number":1490,"context_line":"                self.shell.cs, \u00271234\u0027)"},{"line_number":1491,"context_line":""},{"line_number":1492,"context_line":"    def test_reset_state(self):"},{"line_number":1493,"context_line":"        self.run_command(\u0027reset-state 1234\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"2945a4dd_12142f9a","line":1490,"range":{"start_line":1489,"start_character":12,"end_line":1490,"end_character":38},"in_reply_to":"f8e885cf_71aad4ad","updated":"2021-01-25 18:58:44.000000000","message":"Ack","commit_id":"153aa61146abcce593ddd82231de6ce2ec88f211"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"92da508f8d37c99d5346555a7f4f9fbd0549171c","unresolved":true,"context_lines":[{"line_number":4280,"context_line":""},{"line_number":4281,"context_line":"    if args.wait:"},{"line_number":4282,"context_line":"        share \u003d _wait_for_share_status(cs, share)"},{"line_number":4283,"context_line":""},{"line_number":4284,"context_line":"    _print_share(cs, share)"},{"line_number":4285,"context_line":""},{"line_number":4286,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"cf2e5c0e_70242f2b","line":4283,"range":{"start_line":4283,"start_character":0,"end_line":4283,"end_character":0},"updated":"2021-01-13 17:45:54.000000000","message":"The share info needs to be refreshed either case to reflect changes:\n\n\n  else:\n    share \u003d _find_share(cs, args.share)","commit_id":"805b4002f1cc68bdd901da7f48e51304ca650c71"}]}