)]}'
{"id":"openstack%2Fpython-manilaclient~770537","triplet_id":"openstack%2Fpython-manilaclient~master~I41fc08f29149cf12abbf7ca75fd30f897061bd05","project":"openstack/python-manilaclient","branch":"master","topic":"bug/1898308","hashtags":[],"change_id":"I41fc08f29149cf12abbf7ca75fd30f897061bd05","subject":"Add a waiter to share extend/shrink","status":"MERGED","created":"2021-01-13 06:44:37.000000000","updated":"2021-01-25 18:58:44.000000000","submitted":"2021-01-22 22:12:29.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":9,"unresolved_comment_count":4,"has_review_started":true,"submission_id":"770537-bug/1898308","meta_rev_id":"55b9c8cf55485dba2f45bfe2b8352332d4634916","_number":770537,"virtual_id_number":770537,"owner":{"_account_id":32635,"name":"Paul Ali","email":"paulali@protonmail.com","username":"paulali"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-01-22 22:12:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},{"value":0,"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-01-22 20:58:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},{"value":2,"date":"2021-01-22 21:23:22.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},{"value":1,"date":"2021-01-22 21:23:22.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-01-13 07:25:27.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-01-13 17:45:54.000000000","updated_by":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"reviewer":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"state":"CC"},{"updated":"2021-01-19 07:21:03.000000000","updated_by":{"_account_id":32635,"name":"Paul Ali","email":"paulali@protonmail.com","username":"paulali"},"reviewer":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"state":"REVIEWER"},{"updated":"2021-01-20 02:14:28.000000000","updated_by":{"_account_id":32635,"name":"Paul Ali","email":"paulali@protonmail.com","username":"paulali"},"reviewer":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"state":"REVIEWER"}],"messages":[{"id":"3b865d469a1fa820663c9df72646670a2372bd69","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32635,"name":"Paul Ali","email":"paulali@protonmail.com","username":"paulali"},"date":"2021-01-13 06:44:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0eafe4752d8444a29545e8e9b141a07e5676de62","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-13 07:25:27.000000000","message":"Patch Set 1: Verified-1\n\n(1 comment)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/986c8b2214de460780df34828caea98d : SUCCESS in 8m 06s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/7d880cc275f54823a60ee3f1a069f3e3 : SUCCESS in 4m 44s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/54016f10892a4122b379af63c79a4899 : SUCCESS in 5m 10s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c662bcc1417d458f9ddc7269c614ac5c : FAILURE in 6m 16s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/7b0d5f60272f45cd9908450950f23ac0 : SUCCESS in 6m 39s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/2a5e905ef72340bdb804132fce539711 : SUCCESS in 3m 53s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/8cce96d9d9e84614a7db721d5a01a2bd : SUCCESS in 4m 13s (non-voting)\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/7509c5d005694e3e947db1e637113a3a : SUCCESS in 4m 39s\n- python-manilaclient-functional https://zuul.opendev.org/t/openstack/build/9dbf7a9a9cb64580b9cd8922e0393555 : SUCCESS in 37m 06s","accounts_in_message":[],"_revision_number":1},{"id":"596c7e771fead35b6d8b1a98b32fab8b60a70d5a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32635,"name":"Paul Ali","email":"paulali@protonmail.com","username":"paulali"},"date":"2021-01-13 15:55:36.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"4406c420597de9a972f1c6c8a15890cf9191951a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-13 16:46:09.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/11ff9ac3f90b4b5b966a93f05fee22fc : SUCCESS in 5m 14s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/be5c86051e8a421c8a88cb718fc1baa0 : SUCCESS in 4m 35s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/75a5af5313eb467f888319e1ce2537da : SUCCESS in 4m 07s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7690520e508a4cfba05c58bd1fd3842e : SUCCESS in 3m 55s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/0c03981308f645e4aea84e41a34625da : SUCCESS in 5m 04s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/a94ff85e390243b08f79fd835cf1b281 : SUCCESS in 3m 51s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/d9887aa8ad6240d4a7e3778f4254bfc4 : SUCCESS in 5m 02s (non-voting)\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/5ffe9fb3006d45358decee36b522191e : SUCCESS in 3m 46s\n- python-manilaclient-functional https://zuul.opendev.org/t/openstack/build/a3d0815266d045d5a3ccf5aa20139c7f : SUCCESS in 47m 09s","accounts_in_message":[],"_revision_number":2},{"id":"92da508f8d37c99d5346555a7f4f9fbd0549171c","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2021-01-13 17:45:54.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"fa7040c1596c170aac9586502d805ca27ead3d3a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32635,"name":"Paul Ali","email":"paulali@protonmail.com","username":"paulali"},"date":"2021-01-13 19:34:41.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"70e820f547faa1879811e60901594c1bdd018550","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-13 20:27:39.000000000","message":"Patch Set 3: Verified-1\n\n(2 comments)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/09628519174e49d1852c2ba745f71e30 : SUCCESS in 5m 57s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/0b6184c141884ae9bf2d1543e99cc0e2 : FAILURE in 3m 57s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e9b2780dfbae4a6a9192f603b375855d : FAILURE in 4m 08s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9bb6290bc1d24afaac537a2b656f5f9f : FAILURE in 3m 31s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/7178c3660306449e90fbf00d256581c2 : FAILURE in 3m 54s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/1689d6e9361943f19c98659afdc5eda7 : FAILURE in 4m 47s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/348b7463f198406990ba0c43a331b207 : FAILURE in 4m 55s (non-voting)\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/8c97b9327306472dbf92d1dab8712ad9 : SUCCESS in 4m 03s\n- python-manilaclient-functional https://zuul.opendev.org/t/openstack/build/ec0d730c94be4811bd38eb4222b380e8 : SUCCESS in 49m 50s","accounts_in_message":[],"_revision_number":3},{"id":"1812470f85582e2c914d1149a4428e8df86b01f8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32635,"name":"Paul Ali","email":"paulali@protonmail.com","username":"paulali"},"date":"2021-01-18 16:38:10.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"848b725959825177635e39ddfd6e0594caa1ec96","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-18 17:30:18.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b71d841dd5f949d086ad1cabdcf5f6d1 : SUCCESS in 8m 31s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/a09486a376ba462488f49ec230b3f5d1 : SUCCESS in 6m 52s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/2515e6c0c13b4095a8f240f7e910e622 : SUCCESS in 6m 33s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a72738f441c24c0ba1bb3a9cfca4484d : SUCCESS in 4m 37s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b1df974d5e5542d18dbbccb8ac44aca7 : SUCCESS in 4m 40s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/97dfc46416394d61b5c24c9c98858c32 : SUCCESS in 4m 51s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/21e29c97a1204f378c74716da566cfcd : SUCCESS in 4m 46s (non-voting)\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/0c4da367f1e94972853cfb5274f9ddfd : SUCCESS in 4m 43s\n- python-manilaclient-functional https://zuul.opendev.org/t/openstack/build/145210f5a2b7494da1d4e3de0c5f5808 : SUCCESS in 45m 57s","accounts_in_message":[],"_revision_number":4},{"id":"41a9ef89d00499bd082108e0cb75ed2391545034","author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"date":"2021-01-20 18:07:22.000000000","message":"Patch Set 4: Code-Review+2\n\nThanks for working on this Paul! Code looks great and works as expected, awesome!\nPlease do rebase it on top of master before we can merge 😊","accounts_in_message":[],"_revision_number":4},{"id":"f790756a7a8e3679276664836653515bab268657","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2021-01-20 18:42:14.000000000","message":"Patch Set 4: Code-Review+1\n\n(3 comments)\n\nThe fix LGTM, thanks Paul - as we discussed elsewhere, the testing can be improved with ddt and some mocking. I\u0027ll wait for you to resubmit with your new changes.","accounts_in_message":[],"_revision_number":4},{"id":"afd0aeb62b3224f89c86eb47e589b5b0ebdcc90f","author":{"_account_id":32635,"name":"Paul Ali","email":"paulali@protonmail.com","username":"paulali"},"date":"2021-01-21 04:27:27.000000000","message":"Patch Set 4:\n\n\u003e Patch Set 4: Code-Review+2\n\u003e \n\u003e Thanks for working on this Paul! Code looks great and works as expected, awesome!\n\u003e Please do rebase it on top of master before we can merge 😊\n\nThanks Maari for looking at it😁","accounts_in_message":[],"_revision_number":4},{"id":"5ba777d059fa4f5a43ec2410d51345aa7f57ef03","author":{"_account_id":32635,"name":"Paul Ali","email":"paulali@protonmail.com","username":"paulali"},"date":"2021-01-21 04:36:20.000000000","message":"Patch Set 4:\n\n\u003e Patch Set 4: Code-Review+1\n\u003e \n\u003e (3 comments)\n\u003e \n\u003e The fix LGTM, thanks Paul - as we discussed elsewhere, the testing can be improved with ddt and some mocking. I\u0027ll wait for you to resubmit with your new changes.\n\nThanks Goutham, let me make the changes and resubmit it again.","accounts_in_message":[],"_revision_number":4},{"id":"bf18defd1dc80b09f39b8b124e209bc985b6187a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32635,"name":"Paul Ali","email":"paulali@protonmail.com","username":"paulali"},"date":"2021-01-21 18:08:09.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"b302ec951c4c438d867fec54c53cf2a1925b573f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-21 18:48:34.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/aa0c0bc3563d41b89efd043d37380a4a : SUCCESS in 6m 06s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/b88ed41a7e854fa6bc03bb5ad2fd9e5d : SUCCESS in 4m 41s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/5bcbe28765c545f596d61a63173c3c0f : SUCCESS in 4m 46s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/89a26c97d0d14d18aff55062a2c88719 : SUCCESS in 3m 36s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/928e6a1a30204fb4b87bf19ef96489ee : SUCCESS in 4m 24s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/73a3dc2d169741fc8f733492418559c8 : SUCCESS in 3m 59s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/25955c45c9a741b5862a614ced60cc01 : SUCCESS in 3m 55s (non-voting)\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/775dc5168ad54472b79ea499bede9171 : SUCCESS in 3m 59s\n- python-manilaclient-functional https://zuul.opendev.org/t/openstack/build/f9c064e0b3f44353b93c5700564a1bb2 : SUCCESS in 36m 12s","accounts_in_message":[],"_revision_number":5},{"id":"4604dfe2fe4513904006df7ec850cffccb29e678","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32635,"name":"Paul Ali","email":"paulali@protonmail.com","username":"paulali"},"date":"2021-01-22 09:11:08.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"c6b871851de3e707d5dd60987c93bf92b40e4cc7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32635,"name":"Paul Ali","email":"paulali@protonmail.com","username":"paulali"},"date":"2021-01-22 09:17:54.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"d0eaaabbaec3ae091dc974e473dab514a0654c3e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-22 10:09:11.000000000","message":"Patch Set 7: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/927fc9c47201447296747856c8e5c6d1 : SUCCESS in 6m 00s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/50a57037b7a04e27a694bc0d61ba385d : SUCCESS in 5m 05s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f7efb82abc234f618c57b3929909646e : SUCCESS in 5m 36s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ef1cc7bbee2a402cbacc72806a47f462 : SUCCESS in 4m 43s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f51f25f6a6aa4cb295d86f94289719b2 : SUCCESS in 5m 56s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/623c3cca50924f98b876a64b7b69e2d1 : SUCCESS in 4m 09s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/ebc91713084243eeb9d962f810a4f57e : SUCCESS in 4m 05s (non-voting)\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/9252ead05f6e48758deceb68a17b6ceb : SUCCESS in 3m 26s\n- python-manilaclient-functional https://zuul.opendev.org/t/openstack/build/509ae8d4f5484b6f9ae3f2297a0170f8 : SUCCESS in 46m 27s","accounts_in_message":[],"_revision_number":7},{"id":"20e19387e4b637121d90af5e83244933ac1db4e6","author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"date":"2021-01-22 20:58:38.000000000","message":"Patch Set 7: Code-Review+2\n\nLooks good to me, thanks!","accounts_in_message":[],"_revision_number":7},{"id":"574e1c3fe64cb34549074fc5e25ca95a00df106a","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2021-01-22 21:23:22.000000000","message":"Patch Set 7: Code-Review+2 Workflow+1\n\n(1 comment)\n\nGood job, Paul. While it\u0027s certainly nice to have a functional test as well, it\u0027s not necessary because the unit test is pretty well written - with the caveat of a loose assert i\u0027ve indicated inline. I\u0027ll upload a follow up to illustrate this; so we can use the pattern for your future fixes.","accounts_in_message":[],"_revision_number":7},{"id":"9d67946c6d2b54fcaf7a2e5111d9286819c55331","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-22 21:23:38.000000000","message":"Patch Set 7: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":7},{"id":"74d824ec03e66f7300c3228d57f1d405546c7e96","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-22 22:12:27.000000000","message":"Patch Set 7: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2c9b85734fb54c67972ec88402c2bfbd : SUCCESS in 6m 45s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/66936a9ec990437aa873b5b36f997a10 : SUCCESS in 5m 23s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a8915802fa1249348b11c92b272fb8ad : SUCCESS in 3m 59s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f8518cf5b4cf4c5a93741783494f438f : SUCCESS in 4m 26s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/73b0e0b85c8e48a0beb2d884bf7b4d5d : SUCCESS in 3m 57s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/2123443a10c9455696222cd3782e09e7 : SUCCESS in 3m 35s\n- python-manilaclient-functional https://zuul.opendev.org/t/openstack/build/7d75ec1bd7104338a0136021827cb60d : SUCCESS in 45m 34s","accounts_in_message":[],"_revision_number":7},{"id":"9a82ef7311b6baa779600a3426d96453ba6e523c","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-22 22:12:29.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":7},{"id":"4279bf3ee2c31bf8fb632bc6fdf1916aaa6842c2","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-22 22:13:50.000000000","message":"Patch Set 7:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/bcd8987b1b5d4aadafd66d0ea1653b02 : SUCCESS in 52s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/a7f335672adf4aa5a2489395bdbed1f6 : SUCCESS in 51s","accounts_in_message":[],"_revision_number":7},{"id":"55b9c8cf55485dba2f45bfe2b8352332d4634916","author":{"_account_id":32635,"name":"Paul Ali","email":"paulali@protonmail.com","username":"paulali"},"date":"2021-01-25 18:58:44.000000000","message":"Patch Set 7:\n\n(1 comment)\n\n\u003e Patch Set 7: Code-Review+2 Workflow+1\n\u003e \n\u003e (1 comment)\n\u003e \n\u003e Good job, Paul. While it\u0027s certainly nice to have a functional test as well, it\u0027s not necessary because the unit test is pretty well written - with the caveat of a loose assert i\u0027ve indicated inline. I\u0027ll upload a follow up to illustrate this; so we can use the pattern for your future fixes.\n\nAwesome Goutham, I totally agree.","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"153aa61146abcce593ddd82231de6ce2ec88f211","revisions":{"19a43fd62901d33cd4ba5447235d0aa71427ff23":{"kind":"REWORK","_number":1,"created":"2021-01-13 06:44:37.000000000","uploader":{"_account_id":32635,"name":"Paul Ali","email":"paulali@protonmail.com","username":"paulali"},"ref":"refs/changes/37/770537/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/37/770537/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/37/770537/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/37/770537/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/37/770537/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/37/770537/1"}}},"commit":{"parents":[{"commit":"3cc12ce444feaf069f3953788a3d9f9c425bd768","subject":"Merge \"Fix duplicate wait functional test\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/3cc12ce444feaf069f3953788a3d9f9c425bd768"}]}],"author":{"name":"yara","email":"paulali@protonmail.com","date":"2021-01-13 04:29:27.000000000","tz":0},"committer":{"name":"yara","email":"paulali@protonmail.com","date":"2021-01-13 04:54:09.000000000","tz":0},"subject":"WIP:Add a waiter to share extend/shrink","message":"WIP:Add a waiter to share extend/shrink\n\nThis option enables \"extend\" and \"shrink\"\ncommands to wait until the action has completed.\n\nChange-Id: I41fc08f29149cf12abbf7ca75fd30f897061bd05\nPartially-implements: bp add-wait-to-async-commands\nCloses-Bug: #1898308\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/19a43fd62901d33cd4ba5447235d0aa71427ff23"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/19a43fd62901d33cd4ba5447235d0aa71427ff23"}]},"branch":"refs/heads/master"},"805b4002f1cc68bdd901da7f48e51304ca650c71":{"kind":"REWORK","_number":2,"created":"2021-01-13 15:55:36.000000000","uploader":{"_account_id":32635,"name":"Paul Ali","email":"paulali@protonmail.com","username":"paulali"},"ref":"refs/changes/37/770537/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/37/770537/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/37/770537/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/37/770537/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/37/770537/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/37/770537/2"}}},"commit":{"parents":[{"commit":"3cc12ce444feaf069f3953788a3d9f9c425bd768","subject":"Merge \"Fix duplicate wait functional test\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/3cc12ce444feaf069f3953788a3d9f9c425bd768"}]}],"author":{"name":"yara","email":"paulali@protonmail.com","date":"2021-01-13 04:29:27.000000000","tz":0},"committer":{"name":"yara","email":"paulali@protonmail.com","date":"2021-01-13 15:55:08.000000000","tz":0},"subject":"WIP: Add a waiter to share extend/shrink","message":"WIP: Add a waiter to share extend/shrink\n\nThis option enables \"extend\" and \"shrink\"\ncommands to wait until the action has completed.\n\nChange-Id: I41fc08f29149cf12abbf7ca75fd30f897061bd05\nPartially-implements: bp add-wait-to-async-commands\nCloses-Bug: #1898308\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/805b4002f1cc68bdd901da7f48e51304ca650c71"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/805b4002f1cc68bdd901da7f48e51304ca650c71"}]},"branch":"refs/heads/master"},"bc3227e0e37248563efdc1630064076426f2f23d":{"kind":"REWORK","_number":3,"created":"2021-01-13 19:34:41.000000000","uploader":{"_account_id":32635,"name":"Paul Ali","email":"paulali@protonmail.com","username":"paulali"},"ref":"refs/changes/37/770537/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/37/770537/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/37/770537/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/37/770537/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/37/770537/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/37/770537/3"}}},"commit":{"parents":[{"commit":"3cc12ce444feaf069f3953788a3d9f9c425bd768","subject":"Merge \"Fix duplicate wait functional test\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/3cc12ce444feaf069f3953788a3d9f9c425bd768"}]}],"author":{"name":"yara","email":"paulali@protonmail.com","date":"2021-01-13 04:29:27.000000000","tz":0},"committer":{"name":"yara","email":"paulali@protonmail.com","date":"2021-01-13 19:34:06.000000000","tz":0},"subject":"WIP: Add a waiter to share extend/shrink","message":"WIP: Add a waiter to share extend/shrink\n\nThis option enables \"extend\" and \"shrink\"\ncommands to wait until the action has completed.\n\nChange-Id: I41fc08f29149cf12abbf7ca75fd30f897061bd05\nPartially-implements: bp add-wait-to-async-commands\nCloses-Bug: #1898308\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/bc3227e0e37248563efdc1630064076426f2f23d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/bc3227e0e37248563efdc1630064076426f2f23d"}]},"branch":"refs/heads/master"},"0739e9e45a51ebbefaccf9b3cae13702c302f8cc":{"kind":"REWORK","_number":4,"created":"2021-01-18 16:38:10.000000000","uploader":{"_account_id":32635,"name":"Paul Ali","email":"paulali@protonmail.com","username":"paulali"},"ref":"refs/changes/37/770537/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/37/770537/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/37/770537/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/37/770537/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/37/770537/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/37/770537/4"}}},"commit":{"parents":[{"commit":"3cc12ce444feaf069f3953788a3d9f9c425bd768","subject":"Merge \"Fix duplicate wait functional test\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/3cc12ce444feaf069f3953788a3d9f9c425bd768"}]}],"author":{"name":"yara","email":"paulali@protonmail.com","date":"2021-01-13 04:29:27.000000000","tz":0},"committer":{"name":"paulali","email":"paulali@protonmail.com","date":"2021-01-18 16:38:07.000000000","tz":0},"subject":"Add a waiter to share extend/shrink","message":"Add a waiter to share extend/shrink\n\nThis option enables \"extend\" and \"shrink\"\ncommands to wait until the action has completed.\n\nChange-Id: I41fc08f29149cf12abbf7ca75fd30f897061bd05\nPartially-implements: bp add-wait-to-async-commands\nCloses-Bug: #1898308\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/0739e9e45a51ebbefaccf9b3cae13702c302f8cc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/0739e9e45a51ebbefaccf9b3cae13702c302f8cc"}]},"branch":"refs/heads/master"},"7342fe6a977168985307a12c8a14ef7f65047800":{"kind":"REWORK","_number":5,"created":"2021-01-21 18:08:09.000000000","uploader":{"_account_id":32635,"name":"Paul Ali","email":"paulali@protonmail.com","username":"paulali"},"ref":"refs/changes/37/770537/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/37/770537/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/37/770537/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/37/770537/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/37/770537/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/37/770537/5"}}},"commit":{"parents":[{"commit":"bf3e7cb7161dc3f48dbba36e6619f2b924b2795b","subject":"[OSC] Implement Share Adopt \u0026 Abandon Commands","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/bf3e7cb7161dc3f48dbba36e6619f2b924b2795b"}]}],"author":{"name":"yara","email":"paulali@protonmail.com","date":"2021-01-13 04:29:27.000000000","tz":0},"committer":{"name":"paulali","email":"paulali@protonmail.com","date":"2021-01-21 18:07:34.000000000","tz":0},"subject":"Add a waiter to share extend/shrink","message":"Add a waiter to share extend/shrink\n\nThis option enables \"extend\" and \"shrink\"\ncommands to wait until the action has completed.\n\nChange-Id: I41fc08f29149cf12abbf7ca75fd30f897061bd05\nPartially-implements: bp add-wait-to-async-commands\nCloses-Bug: #1898308\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/7342fe6a977168985307a12c8a14ef7f65047800"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/7342fe6a977168985307a12c8a14ef7f65047800"}]},"branch":"refs/heads/master"},"b4c0398cfd47bdbecbadbb1817d05ddf49236a7f":{"kind":"REWORK","_number":6,"created":"2021-01-22 09:11:08.000000000","uploader":{"_account_id":32635,"name":"Paul Ali","email":"paulali@protonmail.com","username":"paulali"},"ref":"refs/changes/37/770537/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/37/770537/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/37/770537/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/37/770537/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/37/770537/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/37/770537/6"}}},"commit":{"parents":[{"commit":"bf3e7cb7161dc3f48dbba36e6619f2b924b2795b","subject":"[OSC] Implement Share Adopt \u0026 Abandon Commands","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/bf3e7cb7161dc3f48dbba36e6619f2b924b2795b"}]}],"author":{"name":"yara","email":"paulali@protonmail.com","date":"2021-01-13 04:29:27.000000000","tz":0},"committer":{"name":"paulali","email":"paulali@protonmail.com","date":"2021-01-22 09:10:45.000000000","tz":0},"subject":"Add a waiter to share extend/shrink","message":"Add a waiter to share extend/shrink\n\nThis option enables \"extend\" and \"shrink\"\ncommands to wait until the action has completed.\n\nChange-Id: I41fc08f29149cf12abbf7ca75fd30f897061bd05\nPartially-implements: bp add-wait-to-async-commands\nCloses-Bug: #1898308\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/b4c0398cfd47bdbecbadbb1817d05ddf49236a7f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/b4c0398cfd47bdbecbadbb1817d05ddf49236a7f"}]},"branch":"refs/heads/master"},"153aa61146abcce593ddd82231de6ce2ec88f211":{"kind":"REWORK","_number":7,"created":"2021-01-22 09:17:54.000000000","uploader":{"_account_id":32635,"name":"Paul Ali","email":"paulali@protonmail.com","username":"paulali"},"ref":"refs/changes/37/770537/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/37/770537/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/37/770537/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/37/770537/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/37/770537/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/37/770537/7"}}},"commit":{"parents":[{"commit":"bf3e7cb7161dc3f48dbba36e6619f2b924b2795b","subject":"[OSC] Implement Share Adopt \u0026 Abandon Commands","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/bf3e7cb7161dc3f48dbba36e6619f2b924b2795b"}]}],"author":{"name":"yara","email":"paulali@protonmail.com","date":"2021-01-13 04:29:27.000000000","tz":0},"committer":{"name":"paulali","email":"paulali@protonmail.com","date":"2021-01-22 09:14:49.000000000","tz":0},"subject":"Add a waiter to share extend/shrink","message":"Add a waiter to share extend/shrink\n\nThis option enables \"extend\" and \"shrink\"\ncommands to wait until the action has completed.\n\nChange-Id: I41fc08f29149cf12abbf7ca75fd30f897061bd05\nPartially-implements: bp add-wait-to-async-commands\nCloses-Bug: #1898308\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/153aa61146abcce593ddd82231de6ce2ec88f211"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/153aa61146abcce593ddd82231de6ce2ec88f211"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}