)]}'
{"id":"openstack%2Fpython-manilaclient~772121","triplet_id":"openstack%2Fpython-manilaclient~master~I5681a86589c5d59337dbad878a2bb0ebc732f831","project":"openstack/python-manilaclient","branch":"master","topic":"change-770537-7","hashtags":[],"change_id":"I5681a86589c5d59337dbad878a2bb0ebc732f831","subject":"Tighten asserts in some wait tests","status":"MERGED","created":"2021-01-22 21:34:11.000000000","updated":"2021-02-01 14:01:01.000000000","submitted":"2021-02-01 13:59:20.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"772121-change-770537-7","meta_rev_id":"177fbe820ddaae8b87669b5834d70c88b43274c9","_number":772121,"virtual_id_number":772121,"owner":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-02-01 13:59:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},{"value":0,"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},{"value":0,"_account_id":32635,"name":"Paul Ali","email":"paulali@protonmail.com","username":"paulali"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-01-25 17:52:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},{"value":2,"date":"2021-02-01 13:48:28.000000000","_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},{"value":1,"date":"2021-01-25 18:38:21.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":32635,"name":"Paul Ali","email":"paulali@protonmail.com","username":"paulali"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},{"value":1,"date":"2021-02-01 13:48:28.000000000","_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},{"value":0,"_account_id":32635,"name":"Paul Ali","email":"paulali@protonmail.com","username":"paulali"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},{"_account_id":32635,"name":"Paul Ali","email":"paulali@protonmail.com","username":"paulali"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-01-22 21:34:35.000000000","updated_by":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"reviewer":{"_account_id":32635,"name":"Paul Ali","email":"paulali@protonmail.com","username":"paulali"},"state":"REVIEWER"},{"updated":"2021-01-22 21:45:40.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-01-25 17:52:20.000000000","updated_by":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"reviewer":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"state":"REVIEWER"},{"updated":"2021-02-01 13:48:28.000000000","updated_by":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"reviewer":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"state":"REVIEWER"}],"messages":[{"id":"5bf7b1f9918b318edb4b502a7e3432de6bc3a9a7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2021-01-22 21:34:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b1bd40f4b4c95373255938fcd9209d95ee2aa0d0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-22 21:45:40.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a380d3768d8d48ce868a582300bfa792 : SUCCESS in 6m 03s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/2239f4889bf04e93b13fec01ac069b5f : SUCCESS in 4m 09s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f4a481e09a534619836ed3bb0d8aac40 : SUCCESS in 4m 26s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3cbd13afe5c74a2bb0124b7dbca03615 : SUCCESS in 4m 33s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/ab9cb6135b1e4af0b2b9f54cac2a0a62 : SUCCESS in 4m 09s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/204ba4fd26824dc5ad0d0e6143cca239 : SUCCESS in 4m 11s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/a9f605a3ec2d4ce49e044087686924c1 : SUCCESS in 5m 08s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"96c0c70dce4d93234d163c692ca5dbe76bfc884e","author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"date":"2021-01-25 17:52:20.000000000","message":"Patch Set 1: Code-Review+2\n\nThanks Goutham! 😊","accounts_in_message":[],"_revision_number":1},{"id":"4d8cb5e3f665d933ce648a27423f951a48ab230c","author":{"_account_id":32635,"name":"Paul Ali","email":"paulali@protonmail.com","username":"paulali"},"date":"2021-01-25 18:38:21.000000000","message":"Patch Set 1: Code-Review+1\n\nGood catch Goutham 👍👍👍","accounts_in_message":[],"_revision_number":1},{"id":"7e62acdf43aabd36f147b29eaad0a297f078b64a","author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"date":"2021-02-01 13:48:28.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nLooks good, thanks Goutham!","accounts_in_message":[],"_revision_number":1},{"id":"418b22ae3484cb7ca3fa977b9ea98937e6f4d5c5","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-01 13:48:43.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"df2e6d6f561936eaed04be5fb46e5955eb0db17d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-01 13:59:20.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8cd1ef8768744afa939681cd5577f8f0 : SUCCESS in 7m 09s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/4018c35123fa4fa893cecf7fad1db4b7 : SUCCESS in 5m 12s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f9cc5a769c9d455482a3988dec069603 : SUCCESS in 3m 47s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/08fe5a0353294415931834c1e10f8001 : SUCCESS in 3m 44s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/63c00b69d66f408a92af74af90b13f2b : SUCCESS in 4m 27s","accounts_in_message":[],"_revision_number":1},{"id":"4ab34813110c56c8c4c49e759c506792edb802dd","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-01 13:59:20.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"177fbe820ddaae8b87669b5834d70c88b43274c9","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-01 14:01:01.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/317df57747424a6aafcffdee25e22a1a : SUCCESS in 1m 13s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"08fb635670625617816fe33d3fe842e96292169d","revisions":{"08fb635670625617816fe33d3fe842e96292169d":{"kind":"REWORK","_number":1,"created":"2021-01-22 21:34:11.000000000","uploader":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"ref":"refs/changes/21/772121/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/21/772121/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/21/772121/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/21/772121/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/21/772121/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/21/772121/1"}}},"commit":{"parents":[{"commit":"153aa61146abcce593ddd82231de6ce2ec88f211","subject":"Add a waiter to share extend/shrink","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/153aa61146abcce593ddd82231de6ce2ec88f211"}]}],"author":{"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","date":"2021-01-22 21:33:58.000000000","tz":-480},"committer":{"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","date":"2021-01-22 21:33:58.000000000","tz":-480},"subject":"Tighten asserts in some wait tests","message":"Tighten asserts in some wait tests\n\nhttps://review.opendev.org/770537 introduced\na wait flag for shrink and extend methods.\nThe unit tests could use a tighter assert\nstatement so we catch possible future\nregressions.\n\nTrivialFix\nRelated bp: add-wait-to-async-commands\n\nChange-Id: I5681a86589c5d59337dbad878a2bb0ebc732f831\nSigned-off-by: Goutham Pacha Ravi \u003cgouthampravi@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/08fb635670625617816fe33d3fe842e96292169d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/08fb635670625617816fe33d3fe842e96292169d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}