)]}'
{"manilaclient/v2/shell.py":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"dae7b317ba0d93b4cb3e23f50aa6912c59f39b1a","unresolved":true,"context_lines":[{"line_number":1693,"context_line":"@cliutils.service_type(\u0027sharev2\u0027)"},{"line_number":1694,"context_line":"def do_force_delete(cs, args):"},{"line_number":1695,"context_line":"    \"\"\"Attempt force-delete of share, regardless of state (Admin only).\"\"\""},{"line_number":1696,"context_line":"    failure_count \u003d 0"},{"line_number":1697,"context_line":"    for share in args.share:"},{"line_number":1698,"context_line":"        try:"},{"line_number":1699,"context_line":"            _find_share(cs, share).force_delete()"}],"source_content_type":"text/x-python","patch_set":1,"id":"48e19e0a_768226e3","line":1696,"updated":"2021-01-29 18:26:01.000000000","message":"Add here: shares_to_delete \u003d []","commit_id":"9e37a49f7ef60074745f354d52d33ea68f8ac8c0"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"dae7b317ba0d93b4cb3e23f50aa6912c59f39b1a","unresolved":true,"context_lines":[{"line_number":1696,"context_line":"    failure_count \u003d 0"},{"line_number":1697,"context_line":"    for share in args.share:"},{"line_number":1698,"context_line":"        try:"},{"line_number":1699,"context_line":"            _find_share(cs, share).force_delete()"},{"line_number":1700,"context_line":"        except Exception as e:"},{"line_number":1701,"context_line":"            failure_count +\u003d 1"},{"line_number":1702,"context_line":"            print(\"Delete for share %s failed: %s\" % (share, e),"}],"source_content_type":"text/x-python","patch_set":1,"id":"ce13eff5_a4c15fe9","line":1699,"range":{"start_line":1699,"start_character":12,"end_line":1699,"end_character":49},"updated":"2021-01-29 18:26:01.000000000","message":"define the share object:  share_ref \u003d _find_share(cs, share) \nadd it to a list you can loop over later:  shares_to_delete.append(share_ref) \nonly then delete:  share_ref.force_delete()","commit_id":"9e37a49f7ef60074745f354d52d33ea68f8ac8c0"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"dae7b317ba0d93b4cb3e23f50aa6912c59f39b1a","unresolved":true,"context_lines":[{"line_number":1705,"context_line":"        raise exceptions.CommandError(\"Unable to force delete any of \""},{"line_number":1706,"context_line":"                                      \"specified shares.\")"},{"line_number":1707,"context_line":"    if args.wait:"},{"line_number":1708,"context_line":"        try:"},{"line_number":1709,"context_line":"            _wait_for_share_status(cs, share, expected_status\u003d\u0027deleted\u0027)"},{"line_number":1710,"context_line":"        except exceptions.CommandError as e:"},{"line_number":1711,"context_line":"            print(e, file\u003dsys.stderr)"}],"source_content_type":"text/x-python","patch_set":1,"id":"e9429fd8_e53e68da","line":1708,"updated":"2021-01-29 18:26:01.000000000","message":"Now you can loop through the share objects here:\nfor share in shares_to_delete:","commit_id":"9e37a49f7ef60074745f354d52d33ea68f8ac8c0"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"dae7b317ba0d93b4cb3e23f50aa6912c59f39b1a","unresolved":true,"context_lines":[{"line_number":2373,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":2374,"context_line":"    help\u003d\u0027Wait for share instance deletion\u0027)"},{"line_number":2375,"context_line":"@cliutils.service_type(\u0027sharev2\u0027)"},{"line_number":2376,"context_line":"def do_share_instance_force_delete(cs, args):"},{"line_number":2377,"context_line":"    \"\"\"Force-delete the share instance, regardless of state (Admin only).\"\"\""},{"line_number":2378,"context_line":"    failure_count \u003d 0"},{"line_number":2379,"context_line":"    for instance in args.instance:"}],"source_content_type":"text/x-python","patch_set":1,"id":"458982cf_95d9e331","line":2376,"updated":"2021-01-29 18:26:01.000000000","message":"Apply similar logic as above, collect all instances to be deleted in a list before calling .force_delete()\nThen loop though that list if \u0027--wait\u0027 is used","commit_id":"9e37a49f7ef60074745f354d52d33ea68f8ac8c0"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"dae7b317ba0d93b4cb3e23f50aa6912c59f39b1a","unresolved":true,"context_lines":[{"line_number":2388,"context_line":"                                      \"specified share instances.\")"},{"line_number":2389,"context_line":"    if args.wait:"},{"line_number":2390,"context_line":"        try:"},{"line_number":2391,"context_line":"            _wait_for_share_status(cs, instance, expected_status\u003d\u0027deleted\u0027)"},{"line_number":2392,"context_line":"        except exceptions.CommandError as e:"},{"line_number":2393,"context_line":"            print(e, file\u003dsys.stderr)"},{"line_number":2394,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"a2286762_15e3a641","line":2391,"range":{"start_line":2391,"start_character":12,"end_line":2391,"end_character":34},"updated":"2021-01-29 18:26:01.000000000","message":"Here we are not waiting for share, probably we can use _wait_for_resource_status()","commit_id":"9e37a49f7ef60074745f354d52d33ea68f8ac8c0"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"dae7b317ba0d93b4cb3e23f50aa6912c59f39b1a","unresolved":true,"context_lines":[{"line_number":2839,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":2840,"context_line":"    help\u003d\u0027Wait for snapshot to delete\u0027)"},{"line_number":2841,"context_line":"@cliutils.service_type(\u0027sharev2\u0027)"},{"line_number":2842,"context_line":"def do_snapshot_force_delete(cs, args):"},{"line_number":2843,"context_line":"    \"\"\"Attempt force-deletion of one or more snapshots."},{"line_number":2844,"context_line":""},{"line_number":2845,"context_line":"    Regardless of the state (Admin only)."}],"source_content_type":"text/x-python","patch_set":1,"id":"915c3a86_9000f7e7","line":2842,"updated":"2021-01-29 18:26:01.000000000","message":"Here too, apply similar logic as above.","commit_id":"9e37a49f7ef60074745f354d52d33ea68f8ac8c0"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"dae7b317ba0d93b4cb3e23f50aa6912c59f39b1a","unresolved":true,"context_lines":[{"line_number":2861,"context_line":"                                      \"specified snapshots.\")"},{"line_number":2862,"context_line":"    if args.wait:"},{"line_number":2863,"context_line":"        try:"},{"line_number":2864,"context_line":"            snapshot_ref \u003d _wait_for_share_status("},{"line_number":2865,"context_line":"                cs, snapshot, expected_status\u003d\u0027deleted\u0027)"},{"line_number":2866,"context_line":"        except exceptions.CommandError as e:"},{"line_number":2867,"context_line":"            print(e, file\u003dsys.stderr)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1bc788a8_a9aa2e94","line":2864,"range":{"start_line":2864,"start_character":27,"end_line":2864,"end_character":49},"updated":"2021-01-29 18:26:01.000000000","message":"Here too, use _wait_for_resource_status()","commit_id":"9e37a49f7ef60074745f354d52d33ea68f8ac8c0"}]}
