)]}'
{"id":"openstack%2Fpython-manilaclient~772849","triplet_id":"openstack%2Fpython-manilaclient~master~I39afab6c844972a1c97c15055dbc1f07ed90a68b","project":"openstack/python-manilaclient","branch":"master","topic":"Bug-#1898317","hashtags":[],"change_id":"I39afab6c844972a1c97c15055dbc1f07ed90a68b","subject":"Add \"--wait\" option for force-deleting a share/snapshot/share-instance","status":"ABANDONED","created":"2021-01-28 10:41:59.000000000","updated":"2021-02-07 08:02:13.000000000","total_comment_count":7,"unresolved_comment_count":7,"has_review_started":true,"meta_rev_id":"264a62abed6e0fa49531f83d898595313c98bdf6","_number":772849,"virtual_id_number":772849,"owner":{"_account_id":32493,"name":"Kafilat Adeleke","email":"adelekekafilatadenike@gmail.com","username":"kafilat-adeleke"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-01-28 11:36:03.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-01-28 11:36:03.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-01-29 11:41:30.000000000","updated_by":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"reviewer":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"state":"REVIEWER"}],"messages":[{"id":"01869827f60f5ca0863c9c679549969dbe87d21d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32493,"name":"Kafilat Adeleke","email":"adelekekafilatadenike@gmail.com","username":"kafilat-adeleke"},"date":"2021-01-28 10:41:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"837570f62854c30fa2aa897074dfa77f56fff2d3","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-28 11:36:03.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4e5c47df64bb4528a6f62eb04e50d330 : SUCCESS in 6m 29s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/9327d8a8c9dc465a8355423f959d99d0 : FAILURE in 5m 15s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/d6c7e65c197d4d14baca6ddf4b1262c9 : FAILURE in 5m 03s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/800bf616f5a347f5b6d0081d23871985 : SUCCESS in 3m 29s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/1ab577b777e5414ebba7c73f114166ee : FAILURE in 4m 20s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/25393c7c58c046f3b2aa3b72d51f2b06 : FAILURE in 5m 04s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/6b79bfbd89db4e72bc6c50f3091bbbfb : FAILURE in 4m 28s (non-voting)\n- python-manilaclient-functional https://zuul.opendev.org/t/openstack/build/d97d6f8ae336474480787f9cfbb79070 : SUCCESS in 46m 32s","accounts_in_message":[],"_revision_number":1},{"id":"dae7b317ba0d93b4cb3e23f50aa6912c59f39b1a","author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"date":"2021-01-29 18:26:01.000000000","message":"Patch Set 1:\n\n(7 comments)\n\nHi Kafilat, thanks for working on this! 😊 I have been testing this patch in my environment and all 3 commands are failing with using the \u0027--wait\u0027 option:\n\"\u0027str\u0027 object has no attribute \u0027id\u0027\"\nI believe the issue here is that we are not properly passing the required objects to _wait_for_resource_status()\nWe can use the \u0027do_delete\u0027 example from a previous patch as an inspiration how to get those objects where we need them: https://review.opendev.org/c/openstack/python-manilaclient/+/755667/3/manilaclient/v2/shell.py\nI left some comments inline as well.\nAs discussed on IRC, I am still looking into that test and will get back to you, I still haven\u0027t figured that out. Let me know if you have any questions, hope this helps 😊","accounts_in_message":[],"_revision_number":1},{"id":"43184d7f7869f2bbb708248b5880882ab8e5a696","author":{"_account_id":32493,"name":"Kafilat Adeleke","email":"adelekekafilatadenike@gmail.com","username":"kafilat-adeleke"},"date":"2021-01-30 13:28:19.000000000","message":"Patch Set 1:\n\nThanks 😊. I\u0027ll work on them.","accounts_in_message":[],"_revision_number":1},{"id":"0e97c79ffe9496a94846f659d9cd1a337ca9f2f6","author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"date":"2021-02-06 18:55:47.000000000","message":"Patch Set 1:\n\nHi Kafilat, looks like you forgot to add the \u0027--amend\u0027 flag when submitting your changes and ended up with two patches 😊\nI suggest we continue working with the newer one: https://review.opendev.org/c/openstack/python-manilaclient/+/773313\nSo, you can abandon this one here: look for the \"Abandon\" button on the top right corner and add a comment pointing to the new change.\nNext time you are submitting new changes for this, amend your commit as: \"git commit -a --amend\" so you\u0027ll update a follow-up patch to the same change.","accounts_in_message":[],"_revision_number":1},{"id":"264a62abed6e0fa49531f83d898595313c98bdf6","tag":"autogenerated:gerrit:abandon","author":{"_account_id":32493,"name":"Kafilat Adeleke","email":"adelekekafilatadenike@gmail.com","username":"kafilat-adeleke"},"date":"2021-02-07 08:02:13.000000000","message":"Abandoned\n\nAbandoned for https://review.opendev.org/c/openstack/python-manilaclient/+/773313","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"9e37a49f7ef60074745f354d52d33ea68f8ac8c0","revisions":{"9e37a49f7ef60074745f354d52d33ea68f8ac8c0":{"kind":"REWORK","_number":1,"created":"2021-01-28 10:41:59.000000000","uploader":{"_account_id":32493,"name":"Kafilat Adeleke","email":"adelekekafilatadenike@gmail.com","username":"kafilat-adeleke"},"ref":"refs/changes/49/772849/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/49/772849/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/49/772849/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/49/772849/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/49/772849/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/49/772849/1"}}},"commit":{"parents":[{"commit":"4eec42711a25e265466fb4ceeede6746a80fef03","subject":"Merge \"[OSC] Implement Share Export Location Commands\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/4eec42711a25e265466fb4ceeede6746a80fef03"}]}],"author":{"name":"kafilat-adeleke","email":"adelekekafilatadenike@gmail.com","date":"2021-01-28 10:32:48.000000000","tz":60},"committer":{"name":"kafilat-adeleke","email":"adelekekafilatadenike@gmail.com","date":"2021-01-28 10:41:37.000000000","tz":60},"subject":"Add \"--wait\" option for force-deleting a share/snapshot/share-instance","message":"Add \"--wait\" option for force-deleting a share/snapshot/share-instance\n\nChange-Id: I39afab6c844972a1c97c15055dbc1f07ed90a68b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/9e37a49f7ef60074745f354d52d33ea68f8ac8c0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/9e37a49f7ef60074745f354d52d33ea68f8ac8c0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}